Monday, 2014-09-08

portanteachhabra: https://wiki.openstack.org/wiki/Meetings#Swift_team_meeting00:01
achhabraportante: Thank you.00:05
*** dmorita has joined #openstack-swift00:51
*** achhabra has quit IRC00:55
*** IgnacioCorderi has joined #openstack-swift01:10
*** IgnacioCorderi has quit IRC01:12
*** erlon has joined #openstack-swift01:47
*** nosnos has joined #openstack-swift01:51
*** HenryG_ is now known as HenryG02:01
*** echevemaster has joined #openstack-swift02:03
*** judd7 has joined #openstack-swift02:11
*** bkopilov has quit IRC02:30
*** judd7 has quit IRC02:56
*** echevemaster has quit IRC03:19
*** tkay has joined #openstack-swift03:19
*** mrsnivvel has joined #openstack-swift03:23
*** tkay has quit IRC03:23
*** dvorkbjel has quit IRC03:23
*** IgnacioCorderi has joined #openstack-swift03:40
*** IgnacioCorderi has quit IRC03:41
*** erlon has quit IRC04:00
*** bkopilov has joined #openstack-swift04:00
*** IgnacioCorderi has joined #openstack-swift05:07
*** kopparam has joined #openstack-swift05:10
*** kopparam has quit IRC05:26
*** tsg has quit IRC05:27
*** kopparam has joined #openstack-swift05:27
*** kopparam has quit IRC05:31
*** ppai has joined #openstack-swift05:37
*** geaaru has quit IRC05:44
*** nosnos has quit IRC05:57
*** nosnos_ has joined #openstack-swift06:00
openstackgerritMatthew Oliver proposed a change to openstack/swift: Treat 404s as 204 on object delete in proxy  https://review.openstack.org/11412006:02
*** kopparam has joined #openstack-swift06:06
*** nshaikh has joined #openstack-swift06:09
*** IgnacioCorderi has quit IRC06:38
*** kopparam_ has joined #openstack-swift07:14
*** kopparam has quit IRC07:16
*** ujjain has quit IRC07:17
*** ujjain has joined #openstack-swift07:17
*** zul has quit IRC07:24
*** geaaru has joined #openstack-swift07:31
*** tattabbum has joined #openstack-swift07:39
tattabbumHi there!07:39
tattabbumI would to upload a zip file (file.zip) into a swift container by means of REST API. The container's path is: http://SWIFT_IP:8080/v1/AUTH_043c13d5c76747f3befed94215b0b0fd/ApplicationRepositoryPubblico07:41
tattabbumHow can I do it?07:41
tattabbumThe file.zip has a dimension of 30MB07:42
tattabbumI am using this guide: http://docs.openstack.org/api/openstack-object-storage/1.0/content/PUT_createOrReplaceObject__v1__account___container___object__storage_object_services.html08:08
ahaletattabbum: something like this: curl -XPUT -T file.zip http://swift/v1/account/container/file and headers for whatever auth you are using and content type I guess08:13
*** Dafna has joined #openstack-swift08:24
tattabbumahale: Thank you. It works! I have used: curl -X PUT -T kunagi.war http://SWIFT_IP:8080/v1/AUTH_043c13d5c76747f3befed94215b0b0fd/ApplicationRepositoryPubblico/file.war -H "X-Auth-Token: $token" -H "Content-Type: application"08:28
ahaleawesome08:28
ahalehm, is that content type right? should be application/zip or something like that ? a two part thing anyway08:29
tattabbumahale: I have uploaded a war file. So, inserting -H "Content-Type: application" it works.08:30
ahaleah cool :) just looked weird is all - glad its working08:30
ahaleremembered the X-Detect-Content-Type:true header too that makes swift guess, if you're on a relatively recent swift08:31
tattabbumahale: I am using swift 1.6.008:32
ahaleah thats probably not got that feature then08:32
*** aix has joined #openstack-swift08:39
*** vr2 has joined #openstack-swift08:41
*** infotection has quit IRC08:46
*** infotection has joined #openstack-swift08:50
*** nshaikh has quit IRC08:53
*** homegrown has joined #openstack-swift08:57
*** infotection has quit IRC09:06
*** infotection has joined #openstack-swift09:07
openstackgerritAlistair Coles proposed a change to openstack/swift: moving object validation checks to top of PUT method  https://review.openstack.org/11599509:16
acolestdasilva: fix for the py26 failure ^^09:16
*** mkollaro has joined #openstack-swift09:22
*** zul has joined #openstack-swift09:24
*** bvandenh has joined #openstack-swift09:32
*** mkollaro has quit IRC09:36
tattabbumHi there! How many custom metadata can I create using the X-Object-Meta-{name} header? In other words, I need to create 2 custom metadata for an object: "X-Object-Meta-Name_1=Value_1" and "X-Object-Meta-Name_2=Value_2"09:37
tattabbumIs it possible?09:37
*** mkollaro has joined #openstack-swift09:44
*** nshaikh has joined #openstack-swift09:44
openstackgerritPrashanth Pai proposed a change to openstack/swift: Mention storage backends in Associated Projects  https://review.openstack.org/11972410:37
mattoliverautattabbum: so long as the names are unique you can make as many as you want.10:57
*** ppai has quit IRC11:07
*** Midnightmyth has joined #openstack-swift11:17
*** dmsimard_away is now known as dmsimard11:17
*** ppai has joined #openstack-swift11:23
*** ppai has quit IRC11:47
tdasilvaacoles: good morning! thanks for taking care of that11:47
*** kopparam_ has quit IRC12:06
*** tdasilva has quit IRC12:06
*** dmorita has quit IRC12:06
*** kopparam has joined #openstack-swift12:07
*** kopparam has quit IRC12:11
*** nosnos_ has quit IRC12:13
*** nosnos has joined #openstack-swift12:14
*** nosnos has quit IRC12:18
*** Trixboxer has joined #openstack-swift12:32
*** marcusvrn has joined #openstack-swift12:46
*** bkopilov has quit IRC12:48
*** sandywalsh_ has joined #openstack-swift13:21
*** sandywalsh has quit IRC13:24
*** annegent_ has joined #openstack-swift13:24
openstackgerritAlistair Coles proposed a change to openstack/swift: Extra unit tests for check_delete_headers  https://review.openstack.org/11975613:37
*** miqui has joined #openstack-swift13:49
*** nshaikh has quit IRC13:57
*** tattabbum has quit IRC14:08
*** kopparam has joined #openstack-swift14:11
*** kopparam has quit IRC14:16
*** tsg has joined #openstack-swift14:22
*** tdasilva has joined #openstack-swift14:27
openstackgerritJohn Dickinson proposed a change to openstack/swift: make the bind_port config setting required  https://review.openstack.org/11820014:29
*** zaitcev has joined #openstack-swift14:30
*** ChanServ sets mode: +v zaitcev14:30
*** mahatic has joined #openstack-swift14:50
*** judd7 has joined #openstack-swift14:52
openstackgerritYummy Bian proposed a change to openstack/swift: Too many if clauses in the _clean_incoming_headers and the _clean_outgoing_headers routines of the tempurl module  https://review.openstack.org/11978214:53
*** jergerber has joined #openstack-swift14:55
openstackgerritDavid Goetz proposed a change to openstack/swift: Delete expired objects in slightly smarter way.  https://review.openstack.org/11843415:00
acolesnotmyname: morning, process trivia: does this https://review.openstack.org/#/c/119724/ need DocImpact?15:00
*** marcusvrn has quit IRC15:01
*** Midnightmyth has quit IRC15:07
*** mwstorer has joined #openstack-swift15:09
*** aix has quit IRC15:13
*** aix has joined #openstack-swift15:15
*** vr2 has quit IRC15:37
*** vr3 has joined #openstack-swift15:37
*** tattabbum has joined #openstack-swift15:38
*** vr3 has quit IRC15:38
*** vr2 has joined #openstack-swift15:40
tattabbumDear all, I would like that two users (Alice and Bob) of the same tenant (TENANT) see own objects they have uploaded. In other words, Alice haven't see the Bob's objects and viceversa. Is this scenario realizable? Thank you15:41
*** bvandenh has quit IRC15:42
openstackgerritAlistair Coles proposed a change to openstack/swift: Make probe tests tolerate deprecated policies  https://review.openstack.org/11979815:56
*** kyles_ne has joined #openstack-swift15:59
*** gyee has joined #openstack-swift15:59
acolestattabbum: does you scenario use keystone auth?16:03
*** annegent_ has quit IRC16:03
*** homegrown has left #openstack-swift16:03
tattabbumacoles: yes, it does.16:05
acolestattabbum: If Alice and Bob both have admin roles on the same tenant then they can both read all containers/objects in that tenant, so they would be able to read each other's objects.16:07
acolestattabbum: If Alice and Bob do _not_ have admin roles on the tenant then a third user (with admin role) could grant Alice read/write access to one container and Bob read/write access to another container16:08
acolesusing X-Container-Read and X-Container-Write headers to set container access control.16:09
acolesthere is no way to apply different access controls to objects in the _same_ container.16:10
*** mahatic has quit IRC16:10
tattabbumacoles: Thanks for your reply. Alice and Bob do _not_ have admin roles on the tenant16:12
*** geaaru has quit IRC16:13
*** kevinc_ has joined #openstack-swift16:16
tattabbumDear all, I would like that the user Bill with admin role on the tenant TENANT can access the SWIFT's REST API using a "static token", so that he no need to request a new token every time he have to either upload or download an object.16:20
tattabbumHow can do it? Thank you.16:22
ekarlso-how do I get a tempurl ?16:24
*** geaaru has joined #openstack-swift16:24
acolestattabbum: this may be useful http://blog.fsquat.net/?p=4016:26
notmynamegood morning16:28
notmynameacoles: no. that doesn't need DocImpact AFAIK16:28
*** mahatic has joined #openstack-swift16:28
notmynametattabbum: the token you use (and its validity) is up to the auth system. so if you're using keystone, then you'll have to ask keystone for a non-expiring token.16:30
acolesnotmyname: thx16:30
acolestattabbum: i _think_ that by default a keystone token is valid for 1 hour16:31
tattabbumnotmyname: how can I ask keystone a a non-expiring token?16:31
notmynameacoles: I think DocImpact is for things that would need to change in operator docs (eg configs) and API docs. I don't think the docs team maintains any ecosystem stuff16:31
notmynametattabbum: I don't know (or even if that's possible). maybe acoles knows. or you'll need to ask keystone devs in #openstack-dev16:32
tattabbumnotmyname: thank you16:32
acolesnotmyname: yeah thats what i figured but just wanted to doublecheck16:32
notmynametattabbum: however, while I'm not questioning your use case, "forever" sounds kinda scary when thinking about auth tokens. doesn't seem (to me, not knowing your use case) too hard to account for a 401 response to do a reauth16:33
*** mahatic has quit IRC16:33
notmynameespecially since you'll need to have most of the "go get a valid token" code anyway. and you'll already need to handle other error conditions for retries16:33
acolestattabbum: sorry i don't know about non-expiring token. try #openstack-keystone16:34
notmynametattabbum: eg there's a pretty robust retry method in the python-swiftclient codebase that you could use as a pattern. it handles not only reauth but also ratelimiting and other errors. https://github.com/openstack/python-swiftclient/blob/master/swiftclient/client.py#L121916:35
*** mahatic has joined #openstack-swift16:36
*** kenhui has joined #openstack-swift16:36
tattabbumnotmyname: acoles: thank you all!16:37
*** tattabbum has quit IRC16:38
acolestattabbum: no problem16:38
*** tkay has joined #openstack-swift16:50
*** vr2 has quit IRC16:50
*** vr1 has joined #openstack-swift16:50
openstackgerritOpenStack Proposal Bot proposed a change to openstack/swift: Updated from global requirements  https://review.openstack.org/8873616:54
*** judd7 has quit IRC16:59
*** vr1 has quit IRC17:01
*** judd7 has joined #openstack-swift17:02
*** annegent_ has joined #openstack-swift17:04
*** kyles_ne has quit IRC17:08
*** kyles_ne has joined #openstack-swift17:09
*** kopparam has joined #openstack-swift17:10
*** gyee has quit IRC17:12
*** kopparam has quit IRC17:15
*** kevinc_ has quit IRC17:15
*** tsg has quit IRC17:16
*** kevinc_ has joined #openstack-swift17:18
notmynameacoles: FWIW, just asked a wikimedia guy if they explicitly set the bind_port for swift and it turns out they already do17:20
acolesnotmyname: same with our public service17:22
notmynamegreat!17:22
acolestripleo is the issue17:23
acolesbut gerry's on it17:23
notmynamealso, thinking about lifeless's idea of binding to multiple ports, that seems to me that it would be trickier for operators since it's another port to configure/secure and also at least one other config to enable/disable17:23
notmynameso I prefer the current plan of making it explicit17:23
acoleshmmm so that would mean we'd need to explicitly disable a second port or get a surprise17:25
notmynameright. or run with both open17:25
acolesor, could be that if a port is config'd, use only that, otherwise run with bot17:26
acolesh17:26
notmynameI can't see that surprising anyone, ever /s17:26
notmynamethat's the kind of thing pentest guys love :-)17:26
acoleswell you gotta keep them in a job ;)17:27
*** gyee has joined #openstack-swift17:29
*** jon___ has joined #openstack-swift17:32
*** annegent_ has quit IRC17:34
*** kenhui has quit IRC17:35
*** kenhui has joined #openstack-swift17:35
notmynamechmouel: will making the bind_port explicit cause any problems with devstack?17:40
jon___I tried before using 127.0.0.1 because of DHCP issues. It worked for me17:44
*** gyee has quit IRC17:46
*** geaaru has quit IRC17:47
*** annegent_ has joined #openstack-swift17:50
*** homegrown has joined #openstack-swift17:50
*** IgnacioCorderi has joined #openstack-swift17:51
homegrownI'm looking at some pointers to speed up the listing of objects. I have a bout 500k objects in a container with some pseudo folders.17:54
homegrownCurrently using static web, but would be happy with plain text17:54
claygmorning...17:55
*** tab_ has joined #openstack-swift17:55
homegrownevening... ;-)17:55
notmynamehomegrown: what are you looking to do? get a full list of all 500k objects17:59
notmyname?17:59
homegrownyes, as quick as i can18:00
homegrownnot sure where to do the tuning / put the resources to speed it up18:00
notmynamehomegrown: infrastructure wise, I always recommend using flash storage for container dbs. but otherwise, you'll have to page through the results18:01
notmynamehomegrown: now with your UI, there are some tricks you could do, I'd think18:02
homegrownok, it's currently on fairly old hardware, so sure ssd would speed it up18:02
notmynamehomegrown: for example, you have some sort of hierarchy in the object naming your said, so you could eg do a listing with a delimiter and display that immediately then do other concurrent listings in the background18:03
notmynamehomegrown: so if your delimiter is '/', then do that listing first, then you can do subsequent (and concurrent!) listings with the prefixes you get back from the first request. effectively walking the tree of listings with  breadth-first search.18:04
homegrownpossibly, its also important to "find" the latest objects in each pseudo folder first18:04
notmynamehomegrown: that would only work if you have structure in the name18:04
homegrownalthough the name of the object wouldn't necessarily be known when doing the query18:05
notmynamehomegrown: ah, swift doesn't index on anything but the name of the object, so you can't get "newest first" or anything like that (interestingly I've heard that request recently elsewhere though)18:05
torgomaticeven if you don't have structure you could do prefix=%01, prefix=%02, ..., prefix=%FF and get a 255-way fanout (no %00 because I don't think we allow null bytes)18:05
torgomaticprobably some stuff you can remove there too since obj names are UTF-8, so not every byte can start a UTF-8 string18:06
notmynamehomegrown: if you want to do listings, sorting, or searching on anything other than the name you'll have to keep your own index of what's in the container18:06
homegrownsome more background - it's to use as an artifact store18:07
torgomaticlike warehouse 13? neat.18:07
notmynamelol18:07
jon___I am looking at running my proxy nodes on KVM. I have a 8 VCPU VM, I set it to 16 workers. I was testing with just going from 1,2,3,4,5... current client. I noticed that only 1 of the 16 processes were taking requests. I was not up to closer to 8 or 10 current client that a second process we being used. But on physical hardware I saw the process have a MECH more even usage. Has anyone seen this?18:08
homegrownlike apache ivy18:08
homegrownjokers ;-018:09
jon___any ideas? This seems kind of odd to me.18:11
torgomaticjon___: nope, never seen anything like it18:11
homegrownnotmyname: torgomatic: maintaining a separate index is not ideal, but i might be able to do something by maintaining a more predictable structure.18:11
torgomatichomegrown: sounds like a job for a static index file and a cronjob, tbh18:12
torgomaticevery 5 minutes, walk the whole container (blah blah concurrently blah blah BFS, whatever) and generate an index, then store that index in Swift18:13
torgomaticthen when clients go looking for jars or wars or whatev-ars, they'll get the index18:14
homegrowntorgomatic: possibly ... will post back here if i manage something better. for now it's beer o'clock in sunny London.18:14
torgomaticI mean, that does assume that uploaders are okay with it taking a few minutes for their stuff to become available, but meh18:14
torgomatichomegrown: hah! well, enjoy. :)18:14
jon___+torgomatic: thanks. I will create a dummy eventlet wsgi app to see if that is it/18:15
notmynamehomegrown: feel free to keep asking questions :-)18:15
homegrowntorgomatic: that's the problem, nobody is willing to wait18:15
*** homegrown has quit IRC18:15
*** IgnacioCorderi has quit IRC18:20
*** aix has quit IRC18:21
*** homegrown has joined #openstack-swift18:21
*** tsg has joined #openstack-swift18:37
*** annegent_ has quit IRC18:38
*** homegrown has quit IRC18:49
*** openstackgerrit has quit IRC18:51
*** mkollaro has quit IRC18:51
chmouelnotmyname: humm, let me check18:53
*** kenhui has quit IRC18:54
*** swat30 has quit IRC18:54
chmouelnotmyname: yeah i think it will, https://github.com/openstack-dev/devstack/blob/b6f183ad09c51f0d116fecc0c526d6752424a35b/lib/swift#L25918:55
chmouelnotmyname: send a patch and we will see the devstack results if it does if not i will make the iniuncomment function more robust18:55
*** thurloat has quit IRC18:56
*** mkollaro has joined #openstack-swift19:03
*** tdasilva has quit IRC19:03
*** kevinc_ has quit IRC19:06
*** tdasilva has joined #openstack-swift19:06
*** openstackgerrit has joined #openstack-swift19:08
*** thurloat has joined #openstack-swift19:11
*** swat30 has joined #openstack-swift19:11
*** kopparam has joined #openstack-swift19:15
*** thurloat has quit IRC19:16
*** swat30 has quit IRC19:16
pelusetorgomatic, any chance you can complete at least a first pass of https://review.openstack.org/#/c/106910/ here soon?19:18
torgomaticpeluse: sure; I'm slogging through reviews as we speak19:18
pelusetorgomatic, cool.  BTW I'll slip over to the PUT side of your slice set here in the next few days as well...19:19
torgomaticpeluse: yeah, whenever you get a chance... the socket stuff in there is kind of fun though ;)19:19
* peluse might have to save a special beer for that one then...19:20
*** kopparam has quit IRC19:20
*** thurloat has joined #openstack-swift19:25
openstackgerritClay Gerrard proposed a change to openstack/swift: test tempurl header sanitization priority  https://review.openstack.org/11988519:26
*** tkay has quit IRC19:42
*** annegent_ has joined #openstack-swift19:45
*** echevemaster has joined #openstack-swift19:51
mahaticcan someone please help me how to add a new patchset for my first commit? I made the changes and did a "git commit -a". It created a new commit. I then did a "git revert HEAD" and then a "git commit -a --amend"20:01
mahatichere is what "git log" looks like: http://paste.openstack.org/show/108446/20:02
*** gyee has joined #openstack-swift20:03
torgomaticmahatic: so, you're going to want to run "git rebase -i 80b03304^" so that you rebase on the parent of your first commit20:05
torgomaticthat'll give you an $EDITOR window with three lines, one per commit20:05
torgomatickeep 80b03304, squash 79e883b into it, and throw away 4457a61 (the revert of 79e883b)20:06
torgomaticthat should result in one commit that has all the changes in it20:06
*** anderstj has quit IRC20:12
*** anderstj has joined #openstack-swift20:13
*** tdasilva has quit IRC20:15
*** anticw has quit IRC20:15
mahatictorgomatic, i did a revert of 79e883b because i did not want those changes20:15
mahatictorgomatic, maybe i can just rebase it to original like you said and remove the rest of the two. Then modify my document, then run a "git commit -a --amend". Will that do?20:15
claygso i'm a little bitter at Ceilometer...20:16
*** anticw has joined #openstack-swift20:16
claygI could stop there I 'spose; but I have a specific in this case20:16
notmynameclayg: what's up clayg?20:16
claygI didn't care for Najc claiming Greg's aweomse writeup on the rings was somehow "lacking"20:16
torgomaticmahatic: yeah, if you don't like those other two commits, that'll work20:17
claygI wanted to post back - but I can hear the disdain coming through -> https://gist.github.com/20:17
claygmaybe someone should tell me to bite my tongue20:17
clayghere i mean https://gist.github.com/clayg/d46146719c4412fedb0220:17
claygoh well, maybe it was just therepudic to get it out and I can go back to ignoring it20:19
*** thurloat has quit IRC20:19
notmynameclayg: I think it's a good response, especially calling out the mistake of just building two rings instead of actually rebalancing20:19
notmynameclayg: there's a few things that could be reworded20:20
*** echevemaster has quit IRC20:20
notmynameclayg: probably taking out the first sentence of the 2nd paragraph would be enough to remove the disdain coming through :-)20:21
*** thurloat has joined #openstack-swift20:23
claygwas that the one about thinking for ourselves or copying and pasting your ring off some blog post on the internet?20:25
*** mahatic has quit IRC20:25
notmynameclayg: thinking for yourself :-)20:25
*** erlon has joined #openstack-swift20:26
mattoliverauMorning20:26
notmynamemattoliverau: hi20:26
mattoliverauYou all have a good weekend?20:27
*** mahatic has joined #openstack-swift20:27
*** jergerber has quit IRC20:29
openstackgerritMahati proposed a change to openstack/swift: Made changes according to review comments.  https://review.openstack.org/11919320:29
smart_developerHas anyone run into this error when trying a "swift-init all restart"?20:29
smart_developer"No handlers could be found for logger "swift"20:29
smart_developerThis happened after changing the proxy-server.conf file to use authtoken/keystoneauth instead of tempauth.20:31
notmynamesmart_developer: what version of swift and keystone are you using?20:32
chmouelclayg: i was thinking about the same the guy didn't read the full blog post, i think john's reply was excellent tho20:32
smart_developerswift: 1.13.120:32
smart_developerkeystone: 1.0, I believe20:32
chmouelsmart_developer: i think this has to be with the keystoneclient version instead20:32
chmouelwhich has the auth_token20:32
notmynamechmouel: yeah, that :-)20:33
smart_developerswift: 1.1320:34
notmynamesmart_developer: I think chmouel has the right idea. it's an issue with whatever version of keystoneclient you're using20:34
torgomaticmahatic: you should put the commit message back to what it was before; right now the whole commit message is just "Made changes according to review comments", and you're gonna get dinged for that20:35
mahatictorgomatic, oh yeah, my bad!20:35
smart_developerI did "keystone --version" my Keystone server and it returned 0.7.1.20:35
notmynamemahatic: (which you can fix with a `git commit --amend` without having to worry about rebasing)20:35
notmynameand if you do `git commit -amend` you get a new commit with the commit message of "end"20:36
openstackgerritA change was merged to openstack/swift: Pay attention to all punctual nodes  https://review.openstack.org/11948420:36
chmouelsmart_developer: to be honest i think we fixed that but i can't rem in which part of the stack this was fixed, keystoneauth (i.e: swift), swift core or keystoneclient20:36
notmynamewhich is why I have a git alias of "git amend" -> "git commit --amend" cause I'm kinda bad at typing sometimes20:37
chmouel(there is even a keystone auth token middleware repo now but i doubt you have that unless you run git head)20:37
*** jon___ has quit IRC20:37
openstackgerritMahati proposed a change to openstack/swift: Added instructions to create a label or UUID to the XFS volume and mount using it.  https://review.openstack.org/11919320:38
mahaticnotmyname, great. torgomatic, done. Thank you both!20:40
notmynamemahatic: one tiny thing there. in the UUID example, you're using tabs for indention, not spaces. can you change it?20:40
*** robemcallister has joined #openstack-swift20:41
mahaticnotmyname, oh okay. sure, i will.20:41
notmynamethanks20:42
*** robemcallister has quit IRC20:42
*** robemcallister has joined #openstack-swift20:43
*** miqui has quit IRC20:43
*** robemcallister is now known as rmcall20:44
*** annegent_ has quit IRC20:44
mahaticnotmyname, is it advised that i make a quick change and push it? or maybe just wait for the comments, put them together and then make a commit?20:45
notmynamemahatic: go ahead and make this short one. I only asked since I guessed you still have it open and haven't moved on to something else. otherwise I could just push over your patch whenever I get around to it20:46
mahaticnotmyname, yup. it is still open. i can make it now20:46
notmynamemahatic: thanks20:46
mattoliverauBoarding a plane, be back in an hour or so. Unless they have WiFi (which I doubt)20:47
notmynamemattoliverau: you could use gertty!20:47
notmynamemattoliverau: where are you going?20:47
mattoliverauI have it installed so reviews will happen :)20:47
notmynamelol. awesome :-)20:47
*** HenryG has quit IRC20:48
mattoliverauI'm off to visit and work from the folks place (at the beach) :) being a good son :)20:49
notmynamenice20:50
*** rmcall has quit IRC20:50
*** occupant has joined #openstack-swift20:51
openstackgerritMahati proposed a change to openstack/swift: Added instructions to create a label or UUID to the XFS volume and mount using it.  https://review.openstack.org/11919320:53
*** rmcall has joined #openstack-swift20:53
*** annegent_ has joined #openstack-swift21:00
*** HenryG has joined #openstack-swift21:00
*** tgohad has joined #openstack-swift21:01
*** tsg has quit IRC21:02
*** mahatic has quit IRC21:06
*** tsg has joined #openstack-swift21:08
*** tgohad has quit IRC21:10
*** kevinc_ has joined #openstack-swift21:25
*** annegent_ has quit IRC21:36
*** shri has joined #openstack-swift21:36
*** tgohad has joined #openstack-swift21:43
*** tsg has quit IRC21:46
hurricanerix_torgomatic: you around?21:52
*** tgohad has quit IRC22:00
*** jasondotstar has quit IRC22:03
torgomatichurricanerix_: yep22:05
*** miqui has joined #openstack-swift22:13
*** kopparam has joined #openstack-swift22:25
hurricanerix_torgomatic: sorry, i stepped away for a bit.  I just wanted to talk about that formpost test some to see if there is a better solution.22:26
torgomatichurricanerix_: if you take off the exception handler, then a unit test with a too-large file should fail with an error, I think22:27
hurricanerix_torgomatic: Yeah, my main issue was that the unit test would pass (since the formpost middleware would catch the exception).  But when you ran your saio, it would never see the exception.  So having the test didn't really help any.22:28
mattoliverauLanded, it was the bumpiest flight I've ever taken (small regional airline = small plane + bad weather). Interesting trying to review via gertty while bumping around.. I'll call it extreme reviewing :p22:28
hurricanerix_torgomatic: *never see it since the real app wraps everything in a try/except Exception/Timeout.22:29
hurricanerix_torgomatic: So I was just trying to modify the test so without the change, the test would fail similar to how it works in a saio/prod.22:30
*** kopparam has quit IRC22:30
torgomatichurricanerix_: that makes sense, it just makes it harder to write new tests because your no-such-method error gets swallowed22:33
hurricanerix_torgomatic: Yeah.  So you think I should just revert it, or do you have a better approach that I can try?  I don't want to make writing new tests harder, but at the same time, if they don't catch problems, why bother writing them?  =)22:35
torgomatichurricanerix_: I'd write a test with a too-large file that looks for a 400 status code; right now it looks like it'll get a 499, yes?22:35
torgomaticso that'll be a nice failure, and it'll help document the intent of the code22:36
hurricanerix_No, it will get the 40022:36
torgomaticso clients right now see 400 on too-large file?22:36
hurricanerix_we get the 499 because in a real saio, the app catches the IOError and thinks the client disconnected.22:36
hurricanerix_Since in the test, the fake app does not wrap everything in a try/except, the formpost is able to catch the IOError22:37
torgomaticso formpost replies to the client with a 400, and some other request looks disconnected and gets a 499?22:37
*** tsg has joined #openstack-swift22:37
torgomaticalso, is "too large" too large for Swift, or too large for the max_file_size param of the form?22:38
hurricanerix_*EOFError22:38
hurricanerix_So formpost raises the EOFError when the file size is exceeded.22:38
hurricanerix_The formpost middleware attempts to catch it22:38
*** IgnacioCorderi has joined #openstack-swift22:38
*** IgnacioCorderi has quit IRC22:38
hurricanerix_But, because the app wraps everything in a try/except, it thinks it is the client disconnecting.22:38
*** tgohad has joined #openstack-swift22:39
hurricanerix_So if you run the unit test, the test passes checking for a 400, because the fake app does not have that try/except.22:39
*** tgohad__ has joined #openstack-swift22:39
hurricanerix_Bug if you spin up a saio, and post a file larger than the max file size, you will get a 499 back.22:39
hurricanerix_*But22:39
torgomaticOh... so formpost replaces the request's wsgi.input with Folger's crystals^W^Wa _CappedFileLikeObject, and that raises an exception when it's done to blow up22:40
hurricanerix_yeah22:40
torgomaticblow up in the proxy code, that is22:40
hurricanerix_Yeah, and the app catches it and it never gets relayed back to the middleware.22:41
*** tsg has quit IRC22:41
*** tgohad has quit IRC22:42
hurricanerix_So I added that flag, so that the middleware could check if the file size was exceeded.  But the unit test will always pass, so I thought I would change it also, so in the future it could catch the error.22:42
torgomaticand so, against a real Swift proxy, the client receives a 499 status code?22:42
hurricanerix_Yeah22:42
hurricanerix_Sorry if I am doing a terrible job at explaining this.  =)22:42
torgomaticYikes... okay, I'd change the test's app so that it catches EOFError and emits a 499 just like the proxy does, then go ahead and fix formpost22:42
torgomaticno, I got it :)22:42
hurricanerix_Ok, thanks.22:44
torgomaticsure :)22:44
*** dmsimard is now known as dmsimard_away22:49
*** mkollaro has quit IRC23:08
*** dmsimard_away is now known as dmsimard23:09
*** mwstorer has quit IRC23:15
*** tab_ has quit IRC23:16
*** kyles_ne has quit IRC23:20
*** Trixboxer has quit IRC23:23
*** tsg has joined #openstack-swift23:30
*** tgohad__ has quit IRC23:30
*** tgohad has joined #openstack-swift23:32
*** tsg has quit IRC23:35
*** rmcall has quit IRC23:56
*** rmcall has joined #openstack-swift23:57
*** kyles_ne has joined #openstack-swift23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!