| kmalloc | wxy-xiyuan: adding that callback in as a followup | 00:23 |
|---|---|---|
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert system (role) api to flask native dispatching https://review.openstack.org/590588 | 00:30 |
| *** dklyle has quit IRC | 00:32 | |
| *** dklyle has joined #openstack-keystone | 00:32 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Add callback action back in https://review.openstack.org/590590 | 00:35 |
| *** markvoelker has quit IRC | 00:35 | |
| kmalloc | wxy-xiyuan: ^ | 00:41 |
| *** mtreinish has quit IRC | 00:45 | |
| *** mtreinish has joined #openstack-keystone | 00:46 | |
| *** mtreinish has quit IRC | 01:06 | |
| *** mtreinish has joined #openstack-keystone | 01:08 | |
| *** Nel1x has joined #openstack-keystone | 01:12 | |
| *** zhurong has joined #openstack-keystone | 01:23 | |
| *** lbragstad has quit IRC | 01:45 | |
| openstackgerrit | Merged openstack/python-keystoneclient master: refactor the getid method in keystoneclient/base.py https://review.openstack.org/589689 | 02:11 |
| *** zhurong has quit IRC | 02:23 | |
| openstackgerrit | zhengliuyang proposed openstack/keystone master: Redundant parameters in api-ref:domain-config https://review.openstack.org/590604 | 02:28 |
| openstackgerrit | Li Yingjun proposed openstack/keystone master: Explicitly assigning the exception to a variable for reraise https://review.openstack.org/590606 | 02:40 |
| openstackgerrit | Merged openstack/keystone master: Set initiator id as user_id for auth events https://review.openstack.org/588086 | 02:52 |
| *** Nel1x has quit IRC | 03:04 | |
| *** shyamb has joined #openstack-keystone | 05:17 | |
| *** hoonetorg has joined #openstack-keystone | 05:28 | |
| *** shyamb has quit IRC | 05:35 | |
| *** shyamb has joined #openstack-keystone | 05:38 | |
| *** nicolasbock has joined #openstack-keystone | 05:50 | |
| openstackgerrit | Li Yingjun proposed openstack/keystone master: Explicitly assigning the exception to a variable for reraise https://review.openstack.org/590606 | 05:51 |
| *** shyamb has quit IRC | 05:54 | |
| *** Emine has quit IRC | 06:12 | |
| *** shyamb has joined #openstack-keystone | 06:15 | |
| *** pcaruana has joined #openstack-keystone | 06:43 | |
| openstackgerrit | Merged openstack/keystone master: Update reno for stable/rocky https://review.openstack.org/590405 | 06:47 |
| *** evrardjp has joined #openstack-keystone | 07:06 | |
| *** rcernin has quit IRC | 07:07 | |
| *** jaosorior has quit IRC | 07:15 | |
| *** shyamb has quit IRC | 07:22 | |
| *** shyamb has joined #openstack-keystone | 07:30 | |
| *** josecastroleon has quit IRC | 07:58 | |
| *** josecastroleon has joined #openstack-keystone | 07:59 | |
| openstackgerrit | Li Yingjun proposed openstack/keystone master: Explicitly assigning the exception to a variable for reraise https://review.openstack.org/590606 | 08:15 |
| *** shyamb has quit IRC | 08:15 | |
| *** shyamb has joined #openstack-keystone | 08:55 | |
| *** josecastroleon has quit IRC | 09:20 | |
| *** shyamb has quit IRC | 09:37 | |
| *** josecastroleon has joined #openstack-keystone | 09:38 | |
| *** jaosorior has joined #openstack-keystone | 09:48 | |
| *** dave-mccowan has joined #openstack-keystone | 10:55 | |
| *** shyamb has joined #openstack-keystone | 10:57 | |
| *** dave-mccowan has quit IRC | 11:00 | |
| *** dave-mccowan has joined #openstack-keystone | 11:02 | |
| *** shyamb has quit IRC | 11:15 | |
| *** shyamb has joined #openstack-keystone | 11:15 | |
| *** nicolasbock has quit IRC | 11:19 | |
| openstackgerrit | Merged openstack/keystone master: Expose a bug that issue token with project-scope gets error https://review.openstack.org/587368 | 11:30 |
| *** shyamb has quit IRC | 11:54 | |
| *** shyamb has joined #openstack-keystone | 11:54 | |
| *** jaosorior has quit IRC | 12:03 | |
| *** _ix has joined #openstack-keystone | 12:08 | |
| *** shyamb has quit IRC | 12:10 | |
| *** elibrokeit has quit IRC | 12:12 | |
| knikolla | o/ | 12:17 |
| *** mchlumsky has joined #openstack-keystone | 12:26 | |
| *** raildo has joined #openstack-keystone | 12:39 | |
| *** shyamb has joined #openstack-keystone | 12:46 | |
| openstackgerrit | Merged openstack/keystone master: Unified code style nullable description parameter https://review.openstack.org/587721 | 13:00 |
| orange_julius | Replicated ldappool lockout issue in a test environment. Trying to pool disable fix now | 13:16 |
| *** dansmith is now known as SteelyDan | 13:31 | |
| *** shyamb has quit IRC | 13:35 | |
| orange_julius | Turning off connection pooling fixes the issue. Note: setting pool_retry_max = 0 does NOT work. This breaks the LDAP. setting use_pool = False is the fix | 13:36 |
| cmurphy | orange_julius: wow great work | 13:40 |
| cmurphy | orange_julius: what do you mean by "This breaks the LDAP"? | 13:40 |
| orange_julius | It throws a 500 error immediately. I didn't investigate too far into that and just moved on to setting use_pool = False | 13:41 |
| orange_julius | sec I can get the logs | 13:41 |
| cmurphy | orange_julius: what about pool_retry_max = 1? i wonder if there's an off by one problem | 13:43 |
| orange_julius | Ok ldappool throws a MaxConnectionReachedError immediately and keystone freaks out when pool_retry_max = 0. | 13:43 |
| orange_julius | I'll try 1 | 13:43 |
| *** jistr is now known as jistr|call | 13:46 | |
| orange_julius | Setting pool_retry_max = 1 seems to work! | 13:46 |
| cmurphy | with use_pool set back to true? :) | 13:47 |
| orange_julius | Yes =P | 13:47 |
| cmurphy | neat | 13:47 |
| orange_julius | So in my mind... ldappool should first try to catch an ldap.invalidcredentials, then abort and then do a catchall ldap.ldaperror catch. It seems reasonable that this is where the issue is happening: https://git.openstack.org/cgit/openstack/ldappool/tree/ldappool/__init__.py#n255. This would probably require a change in keystone as well though | 13:59 |
| *** jistr|call is now known as jistr | 14:00 | |
| cmurphy | i'm surprised that ldap.ldaperror seems to be a catch-all for both server side and client side errors | 14:01 |
| orange_julius | You are surprised that its used in ldappool that way or you are surprised that python-ldap would make it the catch-all for both server side and client side? | 14:04 |
| cmurphy | surprised that python-ldap acts that way | 14:04 |
| cmurphy | i imagine the author of ldappool would be surprised too or they wouldn't have written it that way | 14:05 |
| orange_julius | Yea most likely. All the exception types are documented here: https://www.python-ldap.org/en/latest/reference/ldap.html#ldap.LDAPError It looks like we would just use ldap.invalid_credentials before ldaperror and break out of the retry loop early. It looks like logic is already in there for handling a bad password so we probably wouldn't have to c | 14:08 |
| orange_julius | hange too much. https://git.openstack.org/cgit/openstack/ldappool/tree/ldappool/__init__.py#n268 | 14:08 |
| cmurphy | ildikov: is there a good reference link to the opnfv edge group and meeting schedule? i've found https://wiki.opnfv.org/display/meetings/Edge+Cloud but the etherpad link seems to be to a different minutes etherpad so i'm not sure that's the right one | 14:31 |
| ildikov | cmurphy: that's a working group and not the Edge Cloud Project | 14:32 |
| cmurphy | ildikov: what is the group that uses https://etherpad.opnfv.org/p/edge_cloud_meeting_minutes for their meeting minutes? | 14:33 |
| ildikov | cmurphy: this is the project wiki:https://wiki.opnfv.org/display/PROJ/Edge+cloud | 14:33 |
| ildikov | cmurphy: they use that meeting etherpad | 14:34 |
| cmurphy | ildikov: okay thank you | 14:34 |
| ildikov | cmurphy: np | 14:34 |
| cmurphy | ildikov: is the zoom link open or is it invite-only? | 14:35 |
| ildikov | cmurphy: you mean to join their meetings? | 14:36 |
| cmurphy | ildikov: yes | 14:36 |
| ildikov | cmurphy: it's open | 14:36 |
| ildikov | the next one will be the week after next | 14:37 |
| cmurphy | ildikov: and published somewhere? it's not on https://wiki.opnfv.org/display/PROJ/Edge+cloud | 14:37 |
| ildikov | the Wednesday meetings are bi-weekly AFAIK | 14:37 |
| cmurphy | ildikov: i'm writing a team update email for the openstack-dev mailing list and wondering whether i should encourage people to attend this meeting and if so how they can discover how to attend the meeting | 14:39 |
| ildikov | cmurphy: I have a calendar invite: https://zoom.us/j/5014627785 | 14:39 |
| ildikov | cmurphy: if people are interested in the demo and federation testing activity, then I think it's worth mentioning | 14:41 |
| ildikov | cmurphy: I couldn't find the info on the wiki, I'll ping Fu Qiao about it | 14:41 |
| cmurphy | ildikov: okay thank you :) | 14:41 |
| ildikov | cmurphy: you can also point people to this wiki on our end: https://wiki.openstack.org/wiki/Keystone_edge_architectures | 14:42 |
| ildikov | cmurphy: and this one for activities: https://wiki.openstack.org/wiki/Edge_Computing_Group#Keystone | 14:42 |
| ildikov | cmurphy: me thanks! :) | 14:43 |
| kmalloc | O/ | 14:43 |
| kmalloc | orange_julius: I'll poke ldappool if someone else doesn't re: that bug. | 14:43 |
| cmurphy | ildikov: will do, just want to make sure i'm covering both groups :) | 14:44 |
| ildikov | cmurphy: +1 :) | 14:44 |
| cmurphy | kmalloc: i feel like orange_julius is closing in on being able to submit the patch themselves ;) | 14:48 |
| gagehugo | o/ | 14:50 |
| kmalloc | cmurphy: ++ | 15:26 |
| openstackgerrit | Gage Hugo proposed openstack/keystone master: Remove unused util function https://review.openstack.org/587232 | 15:53 |
| *** aojea has joined #openstack-keystone | 16:46 | |
| *** aojea has quit IRC | 16:52 | |
| *** hoonetorg has quit IRC | 17:04 | |
| *** N3l1x has joined #openstack-keystone | 17:14 | |
| *** hoonetorg has joined #openstack-keystone | 17:19 | |
| *** gyee has joined #openstack-keystone | 17:21 | |
| openstackgerrit | Merged openstack/keystone master: Remove redundant get_project call https://review.openstack.org/589027 | 17:51 |
| openstackgerrit | Merged openstack/keystone master: More accurate explanation in api-ref:application credentials https://review.openstack.org/589135 | 17:51 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Move json_home "extension" rel functions https://review.openstack.org/591025 | 17:51 |
| *** raildo_ has joined #openstack-keystone | 18:10 | |
| *** raildo has quit IRC | 18:14 | |
| *** pcaruana has quit IRC | 19:19 | |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.limit master: import zuul job settings from project-config https://review.openstack.org/588697 | 19:35 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.limit master: add python 3.6 unit test job https://review.openstack.org/589599 | 19:35 |
| openstackgerrit | Doug Hellmann proposed openstack/oslo.limit master: remove unused variable to fix pep8 issue https://review.openstack.org/591068 | 19:35 |
| *** raildo_ has quit IRC | 20:41 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert OS-FEDERATION to flask native dispatching https://review.openstack.org/591082 | 20:42 |
| kmalloc | knikolla, cmurphy: ^ that change, the OS-FEDERATION one is ... lets just say the scariest of changes to flask, and that is because it is relatively untested code. | 20:43 |
| kmalloc | i need some pretty heavy eyes on those bits to make sure i didn't regress something. | 20:43 |
| kmalloc | that is pre-unit tests btw. | 20:43 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert OS-FEDERATION to flask native dispatching https://review.openstack.org/591082 | 20:44 |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert OS-FEDERATION to flask native dispatching https://review.openstack.org/591082 | 20:48 |
| *** mchlumsky has quit IRC | 21:11 | |
| *** ayoung has quit IRC | 21:23 | |
| *** dave-mccowan has quit IRC | 21:24 | |
| *** dave-mccowan has joined #openstack-keystone | 21:25 | |
| *** aojea has joined #openstack-keystone | 21:56 | |
| openstackgerrit | Morgan Fainberg proposed openstack/keystone master: Convert OS-FEDERATION to flask native dispatching https://review.openstack.org/591082 | 22:17 |
| *** dave-mccowan has quit IRC | 22:19 | |
| *** aojea has quit IRC | 22:27 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!