Saturday, 2018-08-11

« Friday, 2018-08-10 Index Sunday, 2018-08-12 »
*** gyee has quit IRC00:15
kmallocknikolla, cmurphy: about to post a patchset that will pass tests. again, this is ugly and i def. need solid eyes on it.01:09
knikollakmalloc: will give it a first pass tomorrow.01:14
kmallocknikolla: thnx01:51
kmallocugh, we have a broken json_home document01:52
*** aojea has joined #openstack-keystone02:02
openstackgerritMorgan Fainberg proposed openstack/keystone master: Convert OS-FEDERATION to flask native dispatching  https://review.openstack.org/59108202:02
*** aojea has quit IRC02:06
*** dklyle has quit IRC03:50
*** zhurong has joined #openstack-keystone04:36
*** hoonetorg has quit IRC04:46
*** hoonetorg has joined #openstack-keystone05:00
*** zhurong has quit IRC05:43
*** viks_ has quit IRC06:20
*** zhurong has joined #openstack-keystone07:39
*** zhurong has quit IRC08:42
*** _ix_ has joined #openstack-keystone09:01
*** _ix has quit IRC09:04
*** zhurong has joined #openstack-keystone09:33
*** zhurong has quit IRC10:31
*** dave-mccowan has joined #openstack-keystone10:43
*** dave-mccowan has quit IRC10:50
openstackgerritMorgan Fainberg proposed openstack/keystone master: Refactor ProviderAPIs object to better design pattern  https://review.openstack.org/57195513:02
openstackgerritMorgan Fainberg proposed openstack/keystone master: Fix RBACEnforcer get_member_from_driver mechanism  https://review.openstack.org/59114613:02
openstackgerritMorgan Fainberg proposed openstack/keystone master: Convert groups API to flask native dispatching  https://review.openstack.org/59114713:02
openstackgerritMorgan Fainberg proposed openstack/keystone master: Fix RBACEnforcer get_member_from_driver mechanism  https://review.openstack.org/59114613:05
openstackgerritMorgan Fainberg proposed openstack/keystone master: Convert groups API to flask native dispatching  https://review.openstack.org/59114713:05
openstackgerritDoug Hellmann proposed openstack/oslo.limit master: import zuul job settings from project-config  https://review.openstack.org/58869714:45
openstackgerritDoug Hellmann proposed openstack/oslo.limit master: add python 3.6 unit test job  https://review.openstack.org/58959914:45
openstackgerritDoug Hellmann proposed openstack/oslo.limit master: fix documentation build  https://review.openstack.org/59115414:45
openstackgerritMorgan Fainberg proposed openstack/keystone master: Fix RBACEnforcer get_member_from_driver mechanism  https://review.openstack.org/59114615:39
openstackgerritMorgan Fainberg proposed openstack/keystone master: Convert groups API to flask native dispatching  https://review.openstack.org/59114715:39
*** shyamb has joined #openstack-keystone16:09
*** shyamb has quit IRC16:15
*** orange_julius74 has joined #openstack-keystone16:45
orange_julius74Hey guys. I left my regular account logged in at work =(  I've create a patch for the LDAPPool issue we have been discussing. Its in my github currently. What is the best way to get it into the project?16:46
orange_julius74Is the ldappool github accepting pull requests or should it go elsewhere?16:47
*** _ix has joined #openstack-keystone17:22
kmallocorange_julius74: no worries, you'll need to submit it to gerrit (review.openstack.org)17:25
*** _ix_ has quit IRC17:25
kmallocorange_julius74: https://docs.openstack.org/zaqar/latest/contributor/first_patch.html best reference guide i have17:26
orange_julius74Alrighty. I'll start working on that. Thanks!17:26
kmallocwell one of them, obviously zaquar replaced with ldappool17:26
kmalloc;)17:26
orange_julius74Adding a test for this might be a little funky. I'm still sorting that out now17:27
kmalloclet me know, i spend a lot of time writing wonky tests, i can probably give advice if you need it17:27
kmalloc:)17:27
* kmalloc sighs. My patch stack is getting a bit deep again: https://review.openstack.org/#/q/status:open+project:openstack/keystone+branch:master+topic:bug/177650417:28
kmalloccmurphy: after flask, i think i'll be working on stand-alone keystone stuff [or at least piling on to that]17:29
kmalloccmurphy: since flask should help to make it a bit easier.17:29
openstackgerritDoug Hellmann proposed openstack/oslo.limit master: import zuul job settings from project-config  https://review.openstack.org/58869717:32
openstackgerritDoug Hellmann proposed openstack/oslo.limit master: add python 3.6 unit test job  https://review.openstack.org/58959917:32
openstackgerritDoug Hellmann proposed openstack/oslo.limit master: fix gate  https://review.openstack.org/59116217:32
orange_julius74Alright so I tried to keep the test inline with what was already there. I'm going to clean up the commits and fix a few indentation issues, but I was hoping to get your thoughts. https://github.com/ragingpastry/ldappool/blob/fix-pool-retry/ldappool/tests/test_ldapconnection.py17:35
kmalloccool.17:35
kmalloclet me finish my test run and i'll take a look17:35
* kmalloc is running unit tests before adding yet-another-patch to the huge pile of "omg flask" conversion patches17:36
orange_julius74Some things: _bind_fails on line 50 wasn't actually used so I kinda took over that. Looking back I probably should make a new function there. I also removed ldap.INVALID_CREDENTIALS from the check here: https://github.com/ragingpastry/ldappool/blob/fix-pool-retry/ldappool/__init__.py#L272 . It made sense to me since that is being throw up above and17:37
orange_julius74 lets us test for invalid_credentials more specifically. Let me know if this sucks =P17:37
kmalloci doubt it will suck ;)17:37
kmallochey, you're fixing a real bug for us, that in my mind already says "this doesn't suck"17:38
kmalloc(even if you need some adjustments to the code to land it, still not "sucking")17:38
orange_julius74hehe alrighty. Well let me know whenever you get a chance! I'll be around17:41
kmallocdo we need to actually raise up INVALID_CREDENTIALS or would a break of the loop be more correct? /me is still reading17:42
orange_julius74We could certainly just break out of the loop. It might be more clean to have all of the raise logic in one place (272)17:44
kmallocthat was my initial thought17:44
kmalloci don't have a problem with it as is17:44
kmallocbut it might be a lot cleaner to just break and raise out at 272 as needed17:44
orange_julius74Yup for sure. I'll change that17:44
kmallocif you have issues getting that patch into gerrit, i can help17:45
kmallocand submit on your behalf, but would pref if you can do it17:45
kmalloci'll also want to see the test(s) running in our gate. :)17:45
kmallocoverall, i like the direction17:45
kmallocand it's a nice and simple patch17:45
*** aojea has joined #openstack-keystone17:46
orange_julius74Cool I'll make that change and get working on getting patch into gerrit. Does the test I added make sense?17:53
*** aojea has quit IRC18:04
kmallocmostly18:11
kmalloci don't see anything wonky with it at first glance18:12
openstackgerritMorgan Fainberg proposed openstack/keystone master: Fix a translation of log  https://review.openstack.org/59116418:31
openstackgerritMorgan Fainberg proposed openstack/keystone master: Convert OS-INHERIT API to flask native dispatching  https://review.openstack.org/59116518:31
openstackgerritMorgan Fainberg proposed openstack/keystone master: Convert OS-INHERIT API to flask native dispatching  https://review.openstack.org/59116520:17
*** Nel1x has joined #openstack-keystone20:52
*** Nel1x has quit IRC21:19
*** Nel1x has joined #openstack-keystone21:19
openstackgerritNick Wilburn proposed openstack/ldappool master: fix ldappool bad password retry logic  https://review.openstack.org/59117421:52
* orange_julius74 crosses fingers21:53
*** evrardjp has quit IRC21:55
kmallocwoot22:09
kmallocthats a good first patch if i ever saw one:)22:09
kmallocorange_julius74: commented on your patch in gerrit. I'll upgrade to a +2 when i have a little more time to eyeball it. but it looks good.22:15
openstackgerritDoug Hellmann proposed openstack/oslo.limit master: add lib-forward-testing-python3 test job  https://review.openstack.org/59118522:22
openstackgerritDoug Hellmann proposed openstack/oslo.policy master: add lib-forward-testing-python3 test job  https://review.openstack.org/59118922:22
orange_julius74Awsome!22:49
openstackgerritMorgan Fainberg proposed openstack/keystone master: Add safety to the inferred target extraction during enforcement  https://review.openstack.org/59120323:09
openstackgerritMorgan Fainberg proposed openstack/keystone master: Convert role_assignments API to flask native dispatching  https://review.openstack.org/59051823:10
openstackgerritMorgan Fainberg proposed openstack/keystone master: Convert system (role) api to flask native dispatching  https://review.openstack.org/59058823:10
openstackgerritMorgan Fainberg proposed openstack/keystone master: Move json_home "extension" rel functions  https://review.openstack.org/59102523:10
openstackgerritMorgan Fainberg proposed openstack/keystone master: Convert OS-FEDERATION to flask native dispatching  https://review.openstack.org/59108223:11
openstackgerritMorgan Fainberg proposed openstack/keystone master: Refactor ProviderAPIs object to better design pattern  https://review.openstack.org/57195523:11
openstackgerritMorgan Fainberg proposed openstack/keystone master: Fix RBACEnforcer get_member_from_driver mechanism  https://review.openstack.org/59114623:11
openstackgerritMorgan Fainberg proposed openstack/keystone master: Convert groups API to flask native dispatching  https://review.openstack.org/59114723:11
openstackgerritMorgan Fainberg proposed openstack/keystone master: Fix a translation of log  https://review.openstack.org/59116423:11
openstackgerritMorgan Fainberg proposed openstack/keystone master: Convert OS-INHERIT API to flask native dispatching  https://review.openstack.org/59116523:11
« Friday, 2018-08-10 Index Sunday, 2018-08-12 »

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!