| *** davideagnello has quit IRC | 00:04 | |
| flwang | Eva-i: this method needs to be refactored | 00:12 |
|---|---|---|
| flwang | it's on my list, but lower priority | 00:12 |
| wanghao | flwang:ping | 00:13 |
| flwang | Eva-i: currently, the high priority on my list is the puppet/ansible zaqar, zaqar UI and API ref doc | 00:13 |
| wanghao | flwang: hi | 00:13 |
| flwang | wanghao: hi there | 00:14 |
| Eva-i | flwang: okay, let's fix it before releasing the client | 00:14 |
| flwang | Eva-i: there is a case we need to hide the error, i can't remember it now | 00:15 |
| Eva-i | flwang: it's CLI case. We need to handle this exception and hide it behind "The subscriber already exists" in the CLI code. | 00:17 |
| flwang | Eva-i: anyway, you can propose a change and i'm happy to review it | 00:20 |
| Eva-i | flwang: oki, it's a small change, it will not eat much of my time. | 00:21 |
| flwang | not so small like you assumed ;) will see | 00:22 |
| Eva-i | =) | 00:22 |
| *** shu-mutou has joined #openstack-zaqar | 01:29 | |
| *** wxy_ has joined #openstack-zaqar | 01:32 | |
| Eva-i | flwang: mdnadeem: I'm going to propose a spec which is alternative to this one: https://review.openstack.org/#/c/246147/. Is it okay? | 01:33 |
| wxy_ | Does anyone know that whether the wsgi v2 APIs need Client-ID? | 01:34 |
| flwang | wxy_: it needs, what's the problem? | 01:34 |
| flwang | Eva-i: Add POST? | 01:35 |
| Eva-i | flwang: yes | 01:35 |
| flwang | if i were you, i would like to put my time on some others higher priorities | 01:35 |
| *** csoukup_ has joined #openstack-zaqar | 01:38 | |
| openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Fix wrong api version type https://review.openstack.org/267906 | 01:39 |
| wxy_ | flwang: But I can't find the check in v2 See: https://github.com/openstack/zaqar/blob/master/zaqar/common/transport/wsgi/helpers.py#L106 | 01:41 |
| wxy_ | it only checked v1.1 | 01:41 |
| wxy_ | So now I send de request without Client-ID in v2, it works | 01:42 |
| wxy_ | s/de/a | 01:42 |
| Eva-i | flwang: yes, sorry. I already wrote a small spec. ryansb thinks the spec would be a good place to discuss the idea. | 01:43 |
| Eva-i | wxy_: thank you for this bug report, I'll try to reproduce now | 01:43 |
| flwang | Eva-i: you can feel free to upload it for review, but personally, i don't think that's the thing we would like to do in Mitaka based on the discussion on the weekly meeting | 01:44 |
| flwang | wxy_: I can't give a reason why we don't need a client id for v2, because we still need a way to distinguish different clients, unless i missed something | 01:46 |
| flwang | kgriffs: flaper87: any idea? ^ | 01:46 |
| wxy_ | I'm not familiar with the zaqar-wsgi API history. So just a query. :) | 01:48 |
| flwang | wxy_: it's a nice catch. | 01:48 |
| flwang | wxy_: and i just checked the schema of v2, in the schema, v2 still requires client-id | 01:49 |
| flwang | so i think we still need to validate the client-id | 01:50 |
| wxy_ | flwang: Yes, the client side still check the Client-ID in schema | 01:50 |
| flwang | wxy_: https://github.com/openstack/zaqar/blob/master/zaqar/api/v2/request.py#L33 | 01:51 |
| flwang | so feel free file a bug and submit a patch | 01:51 |
| Eva-i | wxy_: I tested this bug, indeed a nice catch. Good job =) | 01:53 |
| wxy_ | Thanks,guys. I'll file a bug later. | 01:55 |
| flwang | wxy_: thanks | 01:55 |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar-specs: Add POST method for creating pools and flavors https://review.openstack.org/274968 | 01:58 |
| flwang | Eva-i: like i mentioned in the meeting | 01:59 |
| flwang | pool and flavor, user know the url when they create the resource | 01:59 |
| flwang | so for that case, PUT is the right way | 01:59 |
| Eva-i | flwang: yes, our current PUT method is perfect. | 02:00 |
| Eva-i | flwang: I don't mind if the spec would be declined, since the user now is able to perform safe operations with pools and flavors, when he remembers to check the existense of the resource by GET method first. | 02:03 |
| flwang | Eva-i: i didn't say it's perfect, i just want to highlight the focus | 02:09 |
| flwang | we're small team, and i would like to put our effort on the high priority things | 02:09 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Add the missing Client-ID check in wsgi v2 https://review.openstack.org/274972 | 02:19 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Add the missing Client-ID check in wsgi v2 https://review.openstack.org/274972 | 02:21 |
| Eva-i | flwang: yes, you're right, I abandoned the spec. | 02:26 |
| flwang | Eva-i: thanks for the understanding, welcome to argue if you think it's a high priority work ;) | 02:27 |
| Eva-i | flwang: as you know, we can't make our API reference in the official place now. Perhaps I can update our existing API reference in the wiki to temporarily provide the reference for our users. And once we'll be able to do the API reference in the official place, the migration will be a bit easier with the updated API reference in the wiki. Would you like that? | 02:41 |
| flwang | Eva-i: can you follow the nova way? | 02:42 |
| Eva-i | flwang: can do it, but personally I would like to triage bugs, and review and write patches. | 02:42 |
| Eva-i | flwang: nova... lets see | 02:43 |
| flwang | Eva-i: ok, sounds good for me | 02:45 |
| flwang | Eva-i: but pls keep an eye on the api-ref work | 02:45 |
| Eva-i | flwang: no, I don't want to create our reference in hard-to-write docbook/wadl which nova has now. If I'll do it, it will be soon converted to swagger/rst and even after conversion it will require additional rewriting. | 02:48 |
| flwang | Eva-i: ok, i see | 02:50 |
| Eva-i | flwang: "ok, sounds good for me" - do you mean patches and bugs work? I'd like to. | 02:50 |
| flwang | Eva-i: yes | 02:53 |
| Eva-i | flwang: cool | 02:53 |
| flwang | cool | 02:53 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Add the missing Client-ID check in wsgi v2 https://review.openstack.org/274972 | 03:36 |
| *** achanda has joined #openstack-zaqar | 03:43 | |
| *** csoukup_ has quit IRC | 03:43 | |
| *** flwang1 has quit IRC | 04:03 | |
| *** achanda has quit IRC | 04:04 | |
| *** achanda has joined #openstack-zaqar | 04:11 | |
| openstackgerrit | MD NADEEM proposed openstack/zaqar: PUT improvement for pool create https://review.openstack.org/238006 | 04:24 |
| *** exploreshaifali has joined #openstack-zaqar | 05:39 | |
| *** jtomasek has quit IRC | 06:15 | |
| *** rcernin has joined #openstack-zaqar | 06:22 | |
| *** boris-42 has quit IRC | 06:23 | |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Add queue name to notifications. https://review.openstack.org/275030 | 06:30 |
| *** csoukup_ has joined #openstack-zaqar | 06:39 | |
| *** csoukup_ has quit IRC | 06:43 | |
| *** rcernin has quit IRC | 06:46 | |
| *** exploreshaifali has quit IRC | 07:00 | |
| *** eliqiao has quit IRC | 07:10 | |
| *** eliqiao has joined #openstack-zaqar | 07:12 | |
| *** achanda has quit IRC | 07:40 | |
| *** achanda has joined #openstack-zaqar | 07:43 | |
| *** achanda has quit IRC | 07:55 | |
| *** boris-42 has joined #openstack-zaqar | 08:17 | |
| *** exploreshaifali has joined #openstack-zaqar | 08:53 | |
| *** dynarro has joined #openstack-zaqar | 09:20 | |
| *** achanda has joined #openstack-zaqar | 09:25 | |
| *** achanda has quit IRC | 09:30 | |
| *** dynarro has quit IRC | 09:39 | |
| *** dynarro has joined #openstack-zaqar | 09:41 | |
| *** openstackgerrit has quit IRC | 10:17 | |
| *** openstackgerrit has joined #openstack-zaqar | 10:17 | |
| *** dynarro has quit IRC | 10:20 | |
| *** exploreshaifali has quit IRC | 11:09 | |
| *** achanda has joined #openstack-zaqar | 11:29 | |
| *** achanda has quit IRC | 11:34 | |
| *** exploreshaifali has joined #openstack-zaqar | 11:56 | |
| *** boris-42 has quit IRC | 12:43 | |
| *** exploreshaifali has quit IRC | 13:06 | |
| *** achanda has joined #openstack-zaqar | 13:33 | |
| *** pradk has joined #openstack-zaqar | 13:36 | |
| *** pradk has quit IRC | 13:36 | |
| *** achanda has quit IRC | 13:38 | |
| *** pradk has joined #openstack-zaqar | 13:43 | |
| *** pradk has quit IRC | 13:43 | |
| *** amitgandhinz has joined #openstack-zaqar | 13:52 | |
| *** sriram has joined #openstack-zaqar | 14:04 | |
| *** sriram has quit IRC | 14:06 | |
| *** dynarro has joined #openstack-zaqar | 14:06 | |
| *** sriram has joined #openstack-zaqar | 14:07 | |
| *** njohnston_ is now known as njohnston | 14:12 | |
| *** achanda has joined #openstack-zaqar | 14:18 | |
| *** achanda has quit IRC | 14:27 | |
| *** pradk has joined #openstack-zaqar | 14:43 | |
| *** wanghao_ has joined #openstack-zaqar | 14:47 | |
| *** malini has joined #openstack-zaqar | 14:53 | |
| *** csoukup_ has joined #openstack-zaqar | 15:28 | |
| *** ametts has joined #openstack-zaqar | 15:30 | |
| *** pradk_ has joined #openstack-zaqar | 15:44 | |
| *** pradk has quit IRC | 15:44 | |
| *** pradk_ is now known as pradk | 15:44 | |
| *** david-lyle has joined #openstack-zaqar | 16:02 | |
| *** fesp has joined #openstack-zaqar | 16:29 | |
| *** dynarro has quit IRC | 16:35 | |
| *** fesp has quit IRC | 16:42 | |
| *** AAzza has quit IRC | 16:45 | |
| *** AAzza has joined #openstack-zaqar | 16:45 | |
| *** AAzza has quit IRC | 16:50 | |
| *** AAzza has joined #openstack-zaqar | 16:50 | |
| *** achanda has joined #openstack-zaqar | 16:57 | |
| *** wanghao_ has quit IRC | 16:57 | |
| *** AAzza_ has joined #openstack-zaqar | 17:02 | |
| *** AAzza has quit IRC | 17:02 | |
| *** AAzza_ is now known as AAzza | 17:02 | |
| *** achanda has quit IRC | 17:06 | |
| *** AAzza has quit IRC | 17:06 | |
| *** AAzza has joined #openstack-zaqar | 17:11 | |
| *** fesp has joined #openstack-zaqar | 17:11 | |
| *** fesp has quit IRC | 17:12 | |
| *** dynarro has joined #openstack-zaqar | 17:17 | |
| *** openstackgerrit has quit IRC | 17:32 | |
| *** openstackgerrit has joined #openstack-zaqar | 17:32 | |
| *** dynarro has quit IRC | 17:55 | |
| *** malini has quit IRC | 18:03 | |
| *** davideagnello has joined #openstack-zaqar | 18:09 | |
| *** kgriffs is now known as kgriffs|afk | 18:14 | |
| *** c_soukup has joined #openstack-zaqar | 18:14 | |
| *** csoukup_ has quit IRC | 18:18 | |
| *** achanda has joined #openstack-zaqar | 18:19 | |
| *** amitgandhinz has quit IRC | 18:34 | |
| *** amitgandhinz has joined #openstack-zaqar | 18:35 | |
| *** exploreshaifali has joined #openstack-zaqar | 18:38 | |
| *** malini has joined #openstack-zaqar | 18:42 | |
| *** whydidyoustealmy has joined #openstack-zaqar | 19:02 | |
| *** wanghao has quit IRC | 19:12 | |
| *** barra204 has quit IRC | 19:12 | |
| *** wanghao has joined #openstack-zaqar | 19:12 | |
| *** boris-42 has joined #openstack-zaqar | 19:19 | |
| *** exploreshaifali has quit IRC | 19:24 | |
| openstackgerrit | Thai Tran proposed openstack/zaqar-ui: Fixes test settings https://review.openstack.org/275382 | 19:36 |
| openstackgerrit | Thai Tran proposed openstack/zaqar-ui: Fixes test settings https://review.openstack.org/275382 | 19:38 |
| openstackgerrit | Thai Tran proposed openstack/zaqar-ui: Add queues API and table https://review.openstack.org/258474 | 19:39 |
| *** kgriffs|afk is now known as kgriffs | 19:43 | |
| *** whydidyoustealmy is now known as barra204 | 19:53 | |
| *** achanda has quit IRC | 20:11 | |
| flwang | ryansb: ping | 20:44 |
| ryansb | flwang: hi! | 20:45 |
| *** achanda has joined #openstack-zaqar | 20:52 | |
| *** csoukup_ has joined #openstack-zaqar | 20:55 | |
| *** malini has quit IRC | 20:57 | |
| *** c_soukup has quit IRC | 20:58 | |
| *** ksheedlo-rax is now known as ksheedlo | 21:04 | |
| *** achanda has quit IRC | 21:48 | |
| flwang | ryansb: do you still have any concern for this one https://review.openstack.org/270464? | 21:49 |
| ryansb | ah, I'll look | 21:50 |
| flwang | ryansb: thanks | 21:50 |
| openstackgerrit | Merged openstack/zaqar-ui: Fixes test settings https://review.openstack.org/275382 | 21:51 |
| openstackgerrit | Merged openstack/zaqar-ui: Add queues API and table https://review.openstack.org/258474 | 21:51 |
| *** flwang1 has joined #openstack-zaqar | 21:58 | |
| *** achanda has joined #openstack-zaqar | 21:59 | |
| *** sriram has quit IRC | 22:00 | |
| *** achanda has quit IRC | 22:30 | |
| *** amitgandhinz has quit IRC | 22:51 | |
| *** ametts has quit IRC | 23:05 | |
| *** boris-42 has quit IRC | 23:53 | |
| *** csoukup_ has quit IRC | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!