| zaitcev | look that line 50 for the reverse transition http://paste.openstack.org/show/177211/ | 00:04 |
|---|---|---|
| zaitcev | But like Sam said, you can't mix and match simultaneously | 00:04 |
| *** lcurtis has quit IRC | 00:08 | |
| *** nellysmitt has joined #openstack-swift | 00:19 | |
| *** nellysmitt has quit IRC | 00:24 | |
| *** rmcall has joined #openstack-swift | 00:31 | |
| *** zul has quit IRC | 00:32 | |
| *** dmorita has joined #openstack-swift | 00:32 | |
| *** jkremer has quit IRC | 00:35 | |
| *** david-lyle is now known as david-lyle_afk | 00:41 | |
| *** zul has joined #openstack-swift | 00:42 | |
| *** zhill has quit IRC | 00:50 | |
| openstackgerrit | Leah Klearman proposed openstack/swift: refactor kill_nonprimary_server https://review.openstack.org/157219 | 00:59 |
| *** vishy has quit IRC | 01:07 | |
| *** vishy has joined #openstack-swift | 01:09 | |
| *** EmilienM is now known as EmilienM|afk | 01:36 | |
| *** zhill has joined #openstack-swift | 01:40 | |
| clayg | zaitcev: what sorcery is this cript!? | 01:44 |
| clayg | for some reason "this script" didn't autocorrect to a link to http://paste.openstack.org/show/177211/ | 01:44 |
| *** rdaly2 has quit IRC | 01:45 | |
| zaitcev | clayg: I used it every time I want to upgrade Keystone, because sometimes the schema update fails | 01:45 |
| zaitcev | It basically re-creates Keystone from scratch and loads all users into it. | 01:46 |
| * clayg thinks he's being trolled | 01:46 | |
| zaitcev | Since I must keep the Swift accounts as they were, it's essential to create users with the same IDs | 01:46 |
| zaitcev | Although Keystone's CLI does not permit it, the simple curl command in that script accomplishes that. | 01:47 |
| clayg | ah the good ol' bash escaped json piped to curl | 01:48 |
| clayg | it's sorta crazy their api supports the pk in the json payload - there's bound to be a vector there :\ | 01:48 |
| zaitcev | Vector to what? It's an admin command. | 01:49 |
| clayg | oh, ok | 01:51 |
| *** devlaps has quit IRC | 01:55 | |
| *** SkyRocknRoll has joined #openstack-swift | 01:56 | |
| clayg | it seems keystone has embraced the eventually consistent mentality -> https://gist.github.com/clayg/4606afa9038cd30658e0 | 01:59 |
| clayg | except I think they focused more on the "it's ok to return inconsistent results" and less on the "eventually they'll be consistent" | 01:59 |
| mattoliverau | Lol | 02:00 |
| zaitcev | Looks pretty stable to me: odd tries fail, even tries pass. Something's flipping. | 02:01 |
| clayg | yeah... | 02:03 |
| *** km__ has joined #openstack-swift | 02:06 | |
| zaitcev | "Originally the blueprint was for python-neutronclient only, but pluggable auth is a wide-reaching issue." -- nice, as if clients weren't complex enough | 02:07 |
| clayg | oh my god oh my god oh my god - my devstack started swift! | 02:08 |
| *** km has quit IRC | 02:08 | |
| *** nellysmitt has joined #openstack-swift | 02:20 | |
| *** nellysmitt has quit IRC | 02:24 | |
| clayg | holy shit, my devstack vm was firing up *10* apache processes just for keystone | 02:36 |
| clayg | they're only ~54M RSS, but like how much ram do they think I have in this vm? | 02:36 |
| *** zhill has quit IRC | 02:40 | |
| openstackgerrit | Pete Zaitcev proposed openstack/python-swiftclient: Fix crash with -l, -d /, and pseudo folders https://review.openstack.org/154648 | 02:47 |
| *** zhill has joined #openstack-swift | 02:50 | |
| *** jrichli has joined #openstack-swift | 03:09 | |
| *** rmcall has quit IRC | 03:21 | |
| clayg | zaitcev: idk, i saw about to say why not just item.get('bytes', 0) - but I guess you and matt already had that dicussion? | 03:29 |
| zaitcev | You mean me and Christian | 03:30 |
| clayg | zaitcev: you are correct! | 03:30 |
| zaitcev | clayg: well, that certainly works, but this looks more regular to me. | 03:31 |
| clayg | interesting | 03:31 |
| zaitcev | Personally I think the minimization of patch length is a non-goal. | 03:32 |
| *** km has joined #openstack-swift | 03:32 | |
| clayg | zaitcev: thats because you haven't embraced the idea that every line of code you write is just a bug waiting to happen | 03:33 |
| clayg | well.... maybe that's just a difference between zaitcev's lines and clayg's lines :\ | 03:33 |
| clayg | i'm kidding i agree - write for clarity, but having to think about the unitialized None in item_bytes seems like where the bug really came from - setting a default at the top I think acctully nuters the bug harder | 03:34 |
| *** km__ has quit IRC | 03:34 | |
| clayg | acoles_away: donagh: is it a good idea to publish the reseller prefixes? | 03:40 |
| *** SkyRocknRoll has quit IRC | 03:53 | |
| *** SkyRocknRoll has joined #openstack-swift | 04:05 | |
| *** zaitcev has quit IRC | 04:09 | |
| *** nellysmitt has joined #openstack-swift | 04:21 | |
| *** nellysmitt has quit IRC | 04:25 | |
| *** silor has joined #openstack-swift | 04:31 | |
| clayg | gd keystone auth - what's the difference between a group and role? I thought groups where just the role assigned to the user for the project within the domain!? | 04:47 |
| clayg | http://docs.openstack.org/admin-guide-cloud/content/keystone-concepts.html does not have groups | 04:47 |
| clayg | why do we have required_groups - wtf is a group | 04:48 |
| clayg | oh heh | 04:52 |
| * clayg is sorta embarassed | 04:52 | |
| clayg | required_groups was just a thing the tests made up | 04:53 |
| clayg | ... to demonstrate the nested config opiton parsing thing | 04:53 |
| klrmn | clayg: wow, i didn't expect changing the tests to use self.container_brain.containter_name would cause OperationalError: database is locked exceptions that nose doesn't catch | 04:55 |
| clayg | wat? | 04:57 |
| clayg | klrmn: you are so in the right line of work - you're better at breaking software than anyone I know | 04:58 |
| *** ppai has joined #openstack-swift | 05:03 | |
| *** jrichli has quit IRC | 05:09 | |
| klrmn | clayg: it's eventlet, i don't have to try hard | 05:15 |
| *** gyee has quit IRC | 05:36 | |
| *** sandywalsh has joined #openstack-swift | 05:38 | |
| *** sandywalsh_ has quit IRC | 05:40 | |
| *** ppai has quit IRC | 05:45 | |
| *** echevemaster has quit IRC | 05:47 | |
| *** ppai has joined #openstack-swift | 05:47 | |
| *** zigo has quit IRC | 05:54 | |
| *** zigo has joined #openstack-swift | 05:55 | |
| *** ppai has quit IRC | 06:14 | |
| *** nellysmitt has joined #openstack-swift | 06:22 | |
| dmorita | notmyname: I deleted 1 line from Swift (general) section in PriorityReview wiki page because that patch is already merged to master. | 06:23 |
| *** nellysmitt has quit IRC | 06:26 | |
| *** ppai has joined #openstack-swift | 06:28 | |
| clayg | dmorita: nice work! | 06:29 |
| *** ppai has quit IRC | 06:40 | |
| *** madhuri_ has quit IRC | 06:46 | |
| *** madhuri_ has joined #openstack-swift | 06:52 | |
| *** ppai has joined #openstack-swift | 06:52 | |
| *** bill_az has joined #openstack-swift | 07:05 | |
| *** bill_ibm__ has quit IRC | 07:05 | |
| clayg | acoles_away: donagh: phew, got a review on service tokens for ya! | 07:09 |
| *** chlong has quit IRC | 07:19 | |
| *** ho has quit IRC | 07:26 | |
| *** nshaikh has joined #openstack-swift | 07:27 | |
| *** SkyRocknRoll has quit IRC | 07:34 | |
| *** SkyRocknRoll has joined #openstack-swift | 07:47 | |
| *** mmcardle has joined #openstack-swift | 07:48 | |
| clayg | dmorita: do you have any idea if kota is still looking at https://review.openstack.org/#/c/155542/ or should I dig back into it | 08:07 |
| clayg | i'm not sure why i asked that, i'm about to shut down, i'll take my answer async ;) | 08:08 |
| clayg | g'night | 08:08 |
| *** rledisez has joined #openstack-swift | 08:10 | |
| openstackgerrit | Kota Tsuyuzaki proposed openstack/swift: Fix efficient replication handoff delete https://review.openstack.org/157290 | 08:12 |
| *** silor1 has joined #openstack-swift | 08:20 | |
| *** silor has quit IRC | 08:22 | |
| *** nellysmitt has joined #openstack-swift | 08:22 | |
| *** nellysmitt has quit IRC | 08:27 | |
| *** nellysmitt has joined #openstack-swift | 08:36 | |
| *** Trixboxer has joined #openstack-swift | 08:38 | |
| *** jistr has joined #openstack-swift | 08:42 | |
| *** jordanP has joined #openstack-swift | 08:53 | |
| *** km has quit IRC | 08:57 | |
| openstackgerrit | Kazuhiro MIYAHARA proposed openstack/swift: bug fix:response code 201 in SLO conflict case https://review.openstack.org/157293 | 09:02 |
| openstackgerrit | Kazuhiro MIYAHARA proposed openstack/swift: Fix conflict SLO reponse https://review.openstack.org/157305 | 09:38 |
| openstackgerrit | Kazuhiro MIYAHARA proposed openstack/swift: Fix conflict SLO reponse https://review.openstack.org/157305 | 09:45 |
| *** silor has joined #openstack-swift | 09:46 | |
| *** silor1 has quit IRC | 09:49 | |
| *** briancline has quit IRC | 10:22 | |
| *** briancline has joined #openstack-swift | 10:23 | |
| *** csmart has joined #openstack-swift | 10:23 | |
| *** silor has quit IRC | 10:28 | |
| *** ppai has quit IRC | 10:30 | |
| *** acoles_away is now known as acoles | 10:41 | |
| *** ppai has joined #openstack-swift | 10:44 | |
| *** aix has quit IRC | 11:04 | |
| *** aix has joined #openstack-swift | 11:05 | |
| openstackgerrit | Daniel Wakefield proposed openstack/python-swiftclient: Verify MD5 of uploaded objects. https://review.openstack.org/129254 | 11:23 |
| *** silor has joined #openstack-swift | 11:26 | |
| openstackgerrit | Daniel Wakefield proposed openstack/python-swiftclient: Add flag to disable automatic checksum validation. https://review.openstack.org/156677 | 11:37 |
| *** chlong has joined #openstack-swift | 11:41 | |
| *** madhuri_ has quit IRC | 11:58 | |
| *** dmorita has quit IRC | 12:05 | |
| *** agentle_ has quit IRC | 12:06 | |
| *** SkyRocknRoll has quit IRC | 12:16 | |
| *** foexle has joined #openstack-swift | 12:20 | |
| *** panbalag has joined #openstack-swift | 12:24 | |
| *** mmcardle has quit IRC | 12:29 | |
| *** SkyRocknRoll has joined #openstack-swift | 12:33 | |
| *** SkyRocknRoll has quit IRC | 12:40 | |
| *** mmcardle has joined #openstack-swift | 12:48 | |
| openstackgerrit | Stuart McLaren proposed openstack/python-swiftclient: Allow reading from object body on download https://review.openstack.org/155291 | 12:58 |
| *** EmilienM|afk is now known as EmilienM | 12:58 | |
| *** pconstantine has joined #openstack-swift | 13:03 | |
| openstackgerrit | Stuart McLaren proposed openstack/python-swiftclient: Allow reading from object body on download https://review.openstack.org/155291 | 13:08 |
| *** ppai has quit IRC | 13:15 | |
| *** aix has quit IRC | 13:29 | |
| *** rdaly2 has joined #openstack-swift | 13:31 | |
| *** mahatic has joined #openstack-swift | 13:33 | |
| *** jistr_ has joined #openstack-swift | 13:37 | |
| *** jistr has quit IRC | 13:39 | |
| *** bkopilov has joined #openstack-swift | 13:40 | |
| *** haomaiw__ has quit IRC | 13:41 | |
| *** briancline has quit IRC | 13:48 | |
| *** jistr_ is now known as jistr | 13:48 | |
| *** briancline has joined #openstack-swift | 13:49 | |
| *** mkerrin has quit IRC | 13:55 | |
| *** aix has joined #openstack-swift | 14:01 | |
| eikke | notmyname: any docs on what was discussed about storage policies during the sprint week? | 14:26 |
| *** EmilienM is now known as EmilienM|afk | 14:32 | |
| *** tdasilva has joined #openstack-swift | 14:33 | |
| *** briancline has quit IRC | 14:37 | |
| *** briancline has joined #openstack-swift | 14:38 | |
| openstackgerrit | Arnaud proposed openstack/swift: Add support of x-remove- headers for container-sync https://review.openstack.org/157388 | 14:40 |
| openstackgerrit | Arnaud proposed openstack/swift: Add support of x-remove- headers for container-sync https://review.openstack.org/157388 | 14:45 |
| *** RackerShagz has joined #openstack-swift | 14:46 | |
| *** SkyRocknRoll has joined #openstack-swift | 14:47 | |
| *** foexle has quit IRC | 14:53 | |
| acoles | eikke: i think notmyname is away for rest of week. there are a couple of blogs on last week: | 14:54 |
| acoles | https://thiagodasilvablog.wordpress.com/2015/02/16/openstack-swift-mid-cycle-report/ | 14:54 |
| acoles | https://swiftstack.com/blog/2015/02/13/openstack-swift-hackathon/ | 14:55 |
| *** rdaly2 has quit IRC | 14:55 | |
| *** rdaly2 has joined #openstack-swift | 14:55 | |
| eikke | acoles: thanks. read those before ;-) | 14:55 |
| *** rdaly2 has quit IRC | 14:56 | |
| peluse | eikke, interested in something specific? | 14:56 |
| eikke | peluse: we have a PoC of policy support in our diskfile, and proposed a talk about it for vancouver, so if things are going to change in that field, I'd be fairly interested :-) | 14:56 |
| eikke | too bad couldn't attend the sprint | 14:57 |
| acoles | clayg: great, thanks! will be interesting to follow the diagnosis of your keystone issue. weird. | 14:57 |
| peluse | eikke, I think you're OK. The main topics around policies were (a) a bunch of patches around better error handling/logging (b) a proposl for how to change the policy of a container (c) a proposl on how to use policies to implement tier'ing | 14:59 |
| eikke | peluse: ah, ok. for (b) we're set already, and (c) should work out of the box as well :-) | 14:59 |
| eikke | I mean, without changes in swift or our diskfile, only in the backend (and maybe diskfile config) | 14:59 |
| peluse | eikke, ahh, OK | 15:00 |
| peluse | and note that the big items won't happen that quickly anyway | 15:00 |
| peluse | b & c that is.... | 15:00 |
| eikke | I was positively surprised by how generic the policies implementation is, which allows us to provide quite some functionality without ugly hacks or workarounds | 15:01 |
| peluse | eikke, thanks, that was by design :) (by everyone that worked on it) | 15:12 |
| *** delattec has joined #openstack-swift | 15:14 | |
| *** lcurtis has joined #openstack-swift | 15:18 | |
| *** jrichli has joined #openstack-swift | 15:28 | |
| *** SkyRocknRoll has quit IRC | 15:33 | |
| *** EmilienM|afk is now known as EmilienM | 15:41 | |
| *** MasterPiece has joined #openstack-swift | 15:41 | |
| *** abhirc has joined #openstack-swift | 15:44 | |
| *** SkyRocknRoll has joined #openstack-swift | 15:50 | |
| *** SkyRocknRoll has quit IRC | 15:54 | |
| pconstantine | hi, guys, long time no see, anyway, is there a particular reason that not even single middleware in Swift is built according to PEP333? | 15:56 |
| pconstantine | PEP333 is a WSGI standard, btw | 15:56 |
| *** nellysmitt has quit IRC | 15:58 | |
| pconstantine | i mean specifically calling close() when finishing with app_iter's that you've got from down-stream | 16:01 |
| *** annegentle has joined #openstack-swift | 16:04 | |
| *** david-lyle_afk is now known as david-lyle | 16:04 | |
| openstackgerrit | Stuart McLaren proposed openstack/python-swiftclient: Allow reading from object body on download https://review.openstack.org/155291 | 16:06 |
| *** silor has quit IRC | 16:09 | |
| *** nellysmitt has joined #openstack-swift | 16:11 | |
| glange | pconstantine: is this the part of PEP333 that you are talking about? "If the iterable returned by the application has a close() method, the server or gateway must call that method upon completion of the current request, whether the request was completed normally, or terminated early due to an error." | 16:28 |
| *** wasmum has left #openstack-swift | 16:28 | |
| pconstantine | glange: yep, that part | 16:28 |
| pconstantine | for example proxy_logging does not do it | 16:28 |
| pconstantine | and, last time I've checked it's included in almost any chain | 16:29 |
| glange | look in eventlet/wsgi.py in the method "handle_one_response()" | 16:29 |
| glange | you have "result = self.application(self.environ, start_response)" | 16:29 |
| *** delatte has joined #openstack-swift | 16:30 | |
| glange | and lower down you have | 16:30 |
| *** wasmum has joined #openstack-swift | 16:30 | |
| glange | if hasattr(result, 'close'): | 16:30 |
| glange | result.close() | 16:30 |
| pconstantine | glange: that's cool and stuff, but who will call it downstream? | 16:30 |
| pconstantine | let's consider a simple chain | 16:30 |
| pconstantine | chain = proxy_logging | 16:31 |
| pconstantine | pipeline = proxy-logging proxy-server | 16:31 |
| pconstantine | who will call app_iter.close() on proxy-server app_iter? | 16:31 |
| glange | I don't understand what you mean, the app is what returns the iterable and the PEP says the iterable returned by the app must have its close() method called -- that seems to be happening in that method? | 16:31 |
| pconstantine | hint: nobody | 16:31 |
| pconstantine | yes, the close() of proxy-logiing will be called | 16:32 |
| *** delattec has quit IRC | 16:32 | |
| pconstantine | but close of any other middleware in the pipeline will not be called | 16:32 |
| pconstantine | because proxy-logging does not call close() anywhere | 16:32 |
| *** nellysmitt has quit IRC | 16:33 | |
| pconstantine | https://github.com/openstack/swift/blob/master/swift/common/middleware/proxy_logging.py#L287 | 16:34 |
| *** nellysmitt has joined #openstack-swift | 16:35 | |
| pconstantine | here, in finally: it should do the same thing that eventlet does | 16:35 |
| pconstantine | i.e. | 16:35 |
| pconstantine | if hasattr(iterable, 'close'): | 16:35 |
| pconstantine | iterable.close() | 16:35 |
| *** openstackgerrit has quit IRC | 16:36 | |
| glange | in the "Latinator" example from the PEP, where is close() called? | 16:36 |
| *** openstackgerrit has joined #openstack-swift | 16:36 | |
| *** SkyRocknRoll has joined #openstack-swift | 16:36 | |
| pconstantine | glange: I don't know, if it's not called, it should be called | 16:37 |
| *** zhill has joined #openstack-swift | 16:37 | |
| pconstantine | you can check it with the debugger that none of the close() on anything downstream from proxy-logging is called ever | 16:37 |
| pconstantine | and it should be | 16:38 |
| glange | ok, stick around -- west coast people will start waking up and getting on irc soon, let's see what they say | 16:39 |
| *** annegentle has quit IRC | 16:39 | |
| pconstantine | I have checked out other proxy level middleware and it seems like only proxy_logging is actively pulling data from downstream iterators | 16:40 |
| pconstantine | therefore it will be probably a small change, only in proxy-logging | 16:40 |
| glange | yeah, maybe there is a problem | 16:40 |
| *** annegentle has joined #openstack-swift | 16:40 | |
| glange | maybe it's in the iter_response() method of logging middleware | 16:42 |
| *** rdaly2 has joined #openstack-swift | 16:42 | |
| glange | it gets an iterator and iterates through it, yielding chunks as it goes, but it doesn't call close() on the iterator it gets? | 16:43 |
| glange | pconstantine: what if you slapped a if hasattr(iterable, 'close'): iterable.close() in the finally in that method? | 16:44 |
| pconstantine | this is what I'm proposing :) | 16:45 |
| glange | you might be right! :) | 16:45 |
| glange | and when you are right, you are right | 16:45 |
| *** nellysmitt has quit IRC | 16:45 | |
| *** dmsimard_away is now known as dmsimard | 16:47 | |
| pconstantine | glange: yep, it never closes the iterator it gets, therefore other middlewares are memory-leaking and people like me get a lot less hair on their behind after debugging why is it happening :) | 16:47 |
| pconstantine | oh, here we go, an article about that: | 16:48 |
| pconstantine | http://blog.dscpl.com.au/2012/10/obligations-for-calling-close-on.html | 16:48 |
| glange | pconstantine: I bet that is the only middleware that does that with the iterable, and the only reason it does that is to get the total bytes transfered | 16:50 |
| pconstantine | glange: probably true, but it is used twice in proxy pipeline usually ... :) | 16:50 |
| pconstantine | just to ensure that no other middlewares will ever work properly inisde :) | 16:51 |
| *** IRTermite has joined #openstack-swift | 16:51 | |
| pconstantine | I mean obviously people do write other "non upstream" middlewares that will be grieved a lot by that one | 16:52 |
| *** annegentle has quit IRC | 17:01 | |
| *** RackerShagz has quit IRC | 17:07 | |
| *** rledisez has quit IRC | 17:10 | |
| *** silor has joined #openstack-swift | 17:14 | |
| *** silor1 has joined #openstack-swift | 17:15 | |
| *** nshaikh has quit IRC | 17:17 | |
| *** silor has quit IRC | 17:19 | |
| *** nellysmitt has joined #openstack-swift | 17:21 | |
| glange | I made that change and it doesn't break any of the unit, functional, or probe tests | 17:22 |
| glange | if it turns out to be a change we need to make, do you think we could get Graham Dumpleton, himself, to make it? | 17:22 |
| glange | because that would be awesome | 17:22 |
| *** Trixboxer has quit IRC | 17:25 | |
| *** jistr has quit IRC | 17:28 | |
| *** zaitcev has joined #openstack-swift | 17:30 | |
| *** ChanServ sets mode: +v zaitcev | 17:30 | |
| *** csmart has quit IRC | 17:33 | |
| *** csmart has joined #openstack-swift | 17:33 | |
| openstackgerrit | Alistair Coles proposed openstack/swift-specs: Updates to encryption spec https://review.openstack.org/154318 | 17:34 |
| *** SkyRocknRoll has quit IRC | 17:41 | |
| *** anayag has joined #openstack-swift | 17:42 | |
| *** silor1 has quit IRC | 17:44 | |
| anayag | Hi, I downloaded the latest swift code and deployed it in a cluster. It worked fine. Then I did some changes in these files [swift/common/wsgi.py swift/proxy/server.py swift/proxy/controllers/base.py swift/proxy/controllers/obj.py] after deploying those changes I get the same error mentioned in this link. | 17:45 |
| anayag | https://bugs.launchpad.net/keystone/+bug/1392264 | 17:45 |
| openstack | Launchpad bug 1392264 in keystonemiddleware "Keystonemiddleware crashes when memcache encryption is enabled with Swift" [Low,Fix released] - Assigned to Rodrigo Duarte (rodrigodsousa) | 17:45 |
| anayag | could anybody help me to resolve it? | 17:46 |
| *** jordanP has quit IRC | 17:47 | |
| openstackgerrit | Alistair Coles proposed openstack/swift: Update guest VM OS recommendation in SAIO doc https://review.openstack.org/156539 | 17:47 |
| openstackgerrit | Donagh McCabe proposed openstack/swift: Add multiple reseller prefixes and composite tokens https://review.openstack.org/137086 | 18:06 |
| *** anayag has quit IRC | 18:07 | |
| *** aix has quit IRC | 18:07 | |
| *** CoffeeMarker has joined #openstack-swift | 18:14 | |
| acoles | cschwede: the swiftclient functional tests job is passing since the tox -e func change :) | 18:15 |
| *** CrackerJackMack has quit IRC | 18:20 | |
| *** CrackerJackMack has joined #openstack-swift | 18:22 | |
| *** mmcardle has quit IRC | 18:27 | |
| *** EmilienM is now known as EmilienM|afk | 18:40 | |
| *** zhill has quit IRC | 18:40 | |
| *** acoles is now known as acoles_away | 18:48 | |
| *** khivin has quit IRC | 18:57 | |
| *** zhill has joined #openstack-swift | 19:03 | |
| *** dencaval has joined #openstack-swift | 19:04 | |
| *** bkopilov has quit IRC | 19:07 | |
| *** bkopilov has joined #openstack-swift | 19:11 | |
| *** delatte has quit IRC | 19:15 | |
| *** joeljwright has left #openstack-swift | 19:20 | |
| *** NM has joined #openstack-swift | 19:22 | |
| *** bkopilov has quit IRC | 19:25 | |
| *** nellysmitt has quit IRC | 19:26 | |
| *** tdasilva has quit IRC | 19:28 | |
| *** abhirc has quit IRC | 19:31 | |
| pconstantine | glange: dunno, but I hope it gets into trunk faster than usually ;) | 19:37 |
| *** tdasilva has joined #openstack-swift | 19:39 | |
| glange | pconstantine: you want me to submit a patch and see what people say? | 19:48 |
| glange | or do you want to do it? | 19:48 |
| pconstantine | go ahead, if you've already created it, I think although that writing test for it could be non-trivial | 19:49 |
| glange | oh yeah, I forgot about that -- I'll see what I can do | 19:49 |
| pconstantine | glange: but if we will rely on the fact that finally is always, always called, then probably just testing that iterable.close() was called is enough | 19:50 |
| *** erlon has quit IRC | 19:51 | |
| clayg | glange: ! | 19:52 |
| *** nellysmitt has joined #openstack-swift | 19:54 | |
| *** ofcourseistilllo has joined #openstack-swift | 20:00 | |
| glange | clayg: ! | 20:02 |
| glange | clayg: did you read through the above? what do you think of what pconstantine is saying? | 20:02 |
| pconstantine | hmm, it looks like xprofile middleware also does not close the downstream iterators | 20:08 |
| pconstantine | I think that's all, all other "standard" middlewares are ok | 20:09 |
| glange | cool, thanks for looking | 20:10 |
| clayg | glange: pconstantine: fwiw, I think the right place to close the app's iterable is when we catch GeneraterExit | 20:15 |
| pconstantine | clayg: you need to close it in both cases, and finally is called anyway after GeneratorExit | 20:15 |
| clayg | ah... yes, you're probably right | 20:16 |
| pconstantine | I think Graham Dumpleton blog post nails all peculiarities of calling close() quite well... | 20:17 |
| *** bill_az has quit IRC | 20:18 | |
| glange | I wish Graham Dumpleton would fix this so we could get his name in the AUTHORS file, that is a good name | 20:19 |
| *** abhirc has joined #openstack-swift | 20:25 | |
| *** vinsh has joined #openstack-swift | 20:25 | |
| *** mahatic has quit IRC | 20:30 | |
| clayg | i did read gd's article, and looked up the follow up slides where he talked about a way to do it better with context managers; maybe we could use a ProxiedIterable class -> https://gist.github.com/clayg/641503fa10a90c368458 | 20:38 |
| clayg | something in app.common.wsgi | 20:38 |
| clayg | neat bug | 20:40 |
| clayg | does anyone besides me think there's limited value in exposing the reseller prefixes -> https://review.openstack.org/#/c/137086/ | 20:43 |
| clayg | I can definately think of use-cases where you wouldn't want a specific reseller prefix exposed - like if you have some internal accounts or something, or there's a prefix that is for accounts you're I don't know.... *reselling* | 20:45 |
| clayg | it *seems* like your catalog auth response would return whatever x-storage-url(s) you need - and if you want to go trying to put data somewhere else you're either authorized or not - no apriory knowledge is needed | 20:46 |
| clayg | in fact, if you had a list of all the valid reseller prefixes - you might just keep trying all of them until you find one you can stuff data into | 20:46 |
| clayg | which may or may not have been what was intended? | 20:46 |
| clayg | idk, I guess any auth middleware can decide on it's own if it wants to expose that or not, but I'm worried if both tempauth and keystone to it some client will pick up on it and start expecting this to just be a thing that all swift clusters publish | 20:47 |
| glange | yeah, it's kind of weird | 20:48 |
| clayg | oh apparently it's "a priori" stupid latin - i'm such a horrible speller with english, i'm dommed when I start trying to sound smart | 20:48 |
| clayg | heh... dommed | 20:48 |
| * clayg walks away | 20:49 | |
| *** vinsh has quit IRC | 20:50 | |
| *** vinsh has joined #openstack-swift | 20:50 | |
| clayg | gerrit is fucking slow for me today - when i was at home I thought it was just my dsl, but I think someone smart is running our office network | 20:51 |
| torgomatic | clayg: utils.CloseableChain, perhaps? | 20:52 |
| clayg | torgomatic: if we get the name right I think the code is practially irrelevant | 20:53 |
| *** gyee has joined #openstack-swift | 20:53 | |
| torgomatic | clayg: what? | 20:53 |
| clayg | s/whateverthefiwastyping/practically irrelevant/ - it was a sideways jab at "I don't care what it's called" :) | 20:54 |
| klrmn | clayg: do you want to have that talk before or after i push the next patch to the current review? =) | 20:59 |
| clayg | push away! | 21:00 |
| *** nellysmitt has quit IRC | 21:01 | |
| torgomatic | clayg: oh, I wasn't trying to suggest a name; we already have one of the thing you were talking about, and it's called utils.CloseableChain | 21:01 |
| torgomatic | line 2561 | 21:02 |
| clayg | pahahhahaha! | 21:02 |
| torgomatic | :) | 21:02 |
| clayg | ahhhh man - and WSGIContext does all the rigt things automagically | 21:04 |
| clayg | ... and proxy logging doesn't use it :'( | 21:05 |
| clayg | hrmm.... I don't know it's not obvious to me how proxy_logging could use CloseableChain directly... the problem i suppose is that calling close on the returned iter_response doesn't call close on the iterable | 21:08 |
| *** abhirc has quit IRC | 21:13 | |
| *** abhirc has joined #openstack-swift | 21:17 | |
| mattoliverau | Morning | 21:19 |
| jrichli | morning | 21:21 |
| zaitcev | clayg: are you tired of that lost fd by any chance? I do not understand Kota's follow-up 157290. | 21:31 |
| *** morganfainberg is now known as needscoffee | 21:32 | |
| clayg | zaitcev: how do you mean? he was looking at a test case i wrote that showed an unsynced object could be deleted. | 21:34 |
| clayg | zaitcev: I'm reviewing it now | 21:34 |
| clayg | acctually i had a few updates to the test I was going to stick in, and run it through some functional testing | 21:34 |
| zaitcev | I don't understand why it's bad to delete if delete_handoff is nonzero at ssync | 21:38 |
| *** NM has quit IRC | 21:39 | |
| clayg | zaitcev: so delete_handoff is true when what... all jobs return success? but on a poke job, you can successfully validate that not all objects are in sync - right? So you can't delete the partition, you can only delete your candidate objs | 21:39 |
| zaitcev | well, okay. I thought the idea here was that all the variables were correct no matter the sync method (by way of rsync returning empty delete candidates always). But now apparently we cannot decide to delete or not based on that information and have to refer to the replication type. Something is fishy. | 21:44 |
| *** zhill has quit IRC | 21:44 | |
| clayg | oic, yeah I think a unittest for the rsync behavior is warranted | 21:49 |
| *** lcurtis has quit IRC | 21:56 | |
| *** MasterPiece has quit IRC | 21:56 | |
| clayg | so with rsync all success always means it's safe to delete everything, with ssync, all successes mean you can delete any objects that are in sync on all nodes | 21:56 |
| clayg | hrm.... I think there may be a bug when then delete_handoff option is set to < replica count... maybe... no i guess it's the same thing... unless you don't have any local primaries... myabe it's fine | 21:57 |
| *** IRTermite has quit IRC | 22:02 | |
| *** openstackstatus has joined #openstack-swift | 22:15 | |
| *** ChanServ sets mode: +v openstackstatus | 22:15 | |
| openstackgerrit | Leah Klearman proposed openstack/swift: refactor kill_nonprimary_server https://review.openstack.org/157219 | 22:20 |
| *** imkarrer has joined #openstack-swift | 22:28 | |
| imkarrer | Good afternoon everyone! I have an interesting problem. I have encountered a situation where 'swift stat' lists containers which do not exist. Has anyone encountered this before? The containers show up in 'swift stat' but they cannot be deleted because they do not exist. | 22:31 |
| clayg | imkarrer: run you container-updaters | 22:32 |
| imkarrer | clayg: Thanks for the quick reply. I will check that | 22:33 |
| imkarrer | clayg: shouldn't the account updater be running at a set intervals if the container-server is running? I figure this problem should be self healing. | 22:43 |
| clayg | the account's don't update anything - that's the top of the chain - the container's update the accounts - via the container updater mostly - and yes, they will heal any descrepencies, unless the containers themselves are out of sync - maybe there's a container server out there with db's on disk that didn't get a new ring? | 22:45 |
| *** zhill has joined #openstack-swift | 22:45 | |
| imkarrer | clayg: I misspoke I meant to say container updater. Thanks for the ideas on where to look. | 22:46 |
| torgomatic | and FWIW, the container updater and the container server are two different daemons. starting one does not imply starting the other. | 22:47 |
| clayg | look at torgomatic all questioning assumptions like a good sysadmin | 22:48 |
| *** vinsh has quit IRC | 22:48 | |
| *** zhill has quit IRC | 22:50 | |
| imkarrer | torgomatic: good point, I did make a foolish assumption. I do remember now that they are started separately by swift-init. Again, many thanks guys! | 22:50 |
| clayg | hrmmm... you know it's interesting, the container-updater doesn't seem to look at the container ring - so if you removed a nodes devices from the ring (instead of weight 0 and let them drain) - it may send bogus updates forever? I haven't functionally verified any of this - swift has surprised me before working when I didn't think it could :\ | 22:51 |
| imkarrer | clayg: I created a container with the same name, and then I was able to delete it. This is not a solution to my problem, but I thought I would mention the behavior in case is sheds any light on the problem. | 22:52 |
| clayg | well... wait a while see if it shows back up :P | 22:54 |
| imkarrer | clayg: It will be interesting to see, I will let ya know what I find out. | 22:55 |
| *** nellysmitt has joined #openstack-swift | 23:02 | |
| *** jrichli has quit IRC | 23:03 | |
| *** wer_ has quit IRC | 23:04 | |
| *** abhirc has quit IRC | 23:04 | |
| *** CoffeeMarker has quit IRC | 23:05 | |
| *** wer_ has joined #openstack-swift | 23:05 | |
| *** nellysmitt has quit IRC | 23:07 | |
| *** Guest936 has joined #openstack-swift | 23:13 | |
| *** Guest936 is now known as annegentle | 23:13 | |
| *** lcurtis has joined #openstack-swift | 23:25 | |
| *** vinsh has joined #openstack-swift | 23:32 | |
| *** vinsh has quit IRC | 23:32 | |
| *** madhuri_ has joined #openstack-swift | 23:36 | |
| *** IRTermite has joined #openstack-swift | 23:44 | |
| *** zhill has joined #openstack-swift | 23:46 | |
| *** zhill has quit IRC | 23:51 | |
| *** abhirc has joined #openstack-swift | 23:56 | |
| *** vinsh has joined #openstack-swift | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!