Monday, 2014-12-01

*** chandan_kumar has joined #openstack-sprint02:44
*** chandan_kumar has quit IRC04:39
*** chandankumar has joined #openstack-sprint04:59
*** AJaeger has joined #openstack-sprint09:05
*** chandankumar has quit IRC10:25
*** chandankumar has joined #openstack-sprint10:39
*** chandankumar has quit IRC11:42
*** chandankumar has joined #openstack-sprint11:43
*** chandankumar has quit IRC13:06
*** AJaeger has quit IRC14:25
*** AJaeger has joined #openstack-sprint14:38
*** AJaeger has quit IRC14:38
*** AJaeger has joined #openstack-sprint14:38
pleia2anteaya: sprint time?15:19
AJaegergood morning, pleia215:20
pleia2good morning AJaeger :)15:20
anteayait is15:21
anteayaso it is15:21
anteayawe are sprinting15:21
*** jeblair has joined #openstack-sprint15:21
pleia2\o/15:21
anteayawelcome everyone15:21
anteayaand thanks to those for getting up early or staying up late15:21
anteayalet's check our notes: https://etherpad.openstack.org/p/infra-manual-sprint-December-201415:22
anteayaso any questions on the etherpad before we get rolling?15:23
anteayaif so, ask as we go along15:24
AJaegerjust as noted on the etherpad: Enhancements for RST markup to the wiki page is welcome! IF there's none, just add - and if there's disagreement with what I added already, please change15:24
anteayaawesome, thank you15:24
* AJaeger cleaned up the bold/emphasis patches on Friday.15:24
anteayathank you15:24
anteayapleia2: actually by way of getting started, do you mind running some stats?15:24
pleia2stats of?15:24
anteayahow many patches up, open, abandoned15:25
AJaegercould one of the cores please abandon https://review.openstack.org/107360 now?15:25
anteayaso we can track our progress for the sprint in terms of patches created, merged etc15:25
AJaegerI've moved the real content to https://review.openstack.org/13781915:25
anteayaAJaeger: can you put that in the etherpad as a request for cores?15:25
anteayain case it gets lost in scrollback?15:25
AJaegerwill do, anteaya15:25
anteayathank you15:25
pleia2anteaya: I'll grab number opened now, and see what I can do stats-wise about open/merged/abandoned this evening15:26
anteayapleia2: awesome thank you15:27
pleia2or tomorrow evening15:27
anteayaso we have some numbers to announce when we are done15:27
pleia2this is a 2 day thing :)15:27
anteayasure, either way15:27
anteayait is15:27
AJaegerI'd like to have a review on https://review.openstack.org/137819 - please tell me what to do with the -1 there. If there's agreement to just link to the gerrit page, I can rework it.15:28
anteayasure15:29
pleia2yeah, link to gerrit docs wfm15:29
AJaegerjeblair, I would love to have current patches approved so that we know what really needs working on and have less merge conflicts15:29
jeblairAJaeger: yep.  i'm just waking up, hope to soon.15:30
*** nibalizer has joined #openstack-sprint15:30
AJaegerjeblair, thanks! Drink your coffee first ;)15:30
anteayaAJaeger: I like your approach, for beginners sending them all over the place confuses them15:31
anteayathey don't know what they should be looking at when they arrive at the new link15:31
anteayabest to describe as you do15:31
anteayaand then add the link for reference at the bottom of your description15:31
AJaeger(not my text, copied from 107360)15:31
AJaegerOk, let me do that - pleia2 ok?15:32
jeblairanteaya: ++15:32
anteayaAJaeger: and if you did a straight copy can you link the copied patch, for reference in the commit message?15:32
AJaegeranteaya, will update15:32
pleia2sure15:33
anteayathanks, you gave co-author credit, lets explictly see why15:33
anteayaand thank you15:33
AJaegerupdated 13781915:35
anteayaI'm waiting for the docs to come back, but the rst looks good15:36
AJaegeranteaya, docs are back15:38
pleia2it's back, looks good15:38
anteayaAJaeger: this sentence is a bit long: After you add one or more inline comments, you still have to send the Review message (see above, with or without text and vote), prior to sending the inline comments in a review comment the inline comments are stored as Drafts in your browser.15:39
anteayacan we split it at all?15:39
AJaegerlet me try reworking...15:40
anteayathanks15:40
pleia2it's something that confuses people often, so I didn't feel it was run-on, but I am the queen of run-on sentences, so ;)15:40
AJaegerWas easy to split ;)15:40
anteayaI'm looking at the gerrit link, the content is for reviewing a change, not just adding an inline comment15:40
anteayaAJaeger: yay15:41
anteayaperhaps we should add the gerrit link as a reference for that entire Reviewing a Patch section, not just adding an inline comment15:41
anteayathoughts?15:41
anteayasorry that entire Code Review section15:42
dhellmannanteaya, pleia2 : as promised: https://review.openstack.org/138094 (I tried to remove most of the oslo-specific stuff, but there are a few places where knowing oslo vs. not oslo is important for the process so I tried to make those more generic)15:42
AJaegeranteaya, will do.15:42
pleia2dhellmann: wow, excellent!15:42
anteayadhellmann: morning15:42
anteayadhellmann: are you around for much of the sprint?15:43
AJaegeranteaya, check again ;)15:43
anteayaor just ducking in and out?15:43
dhellmannpleia2: I think I found a few things that were out of date, too, so please read closely :-)15:43
anteayaAJaeger: thanks15:43
pleia2dhellmann: will do15:43
anteayadhellmann: the reason I ask15:44
dhellmannanteaya: I'll be in and out. I have the Oslo meeting in 15 minutes but then I'll be more responsive. I'd like to land some version of this guide if possible so I can update our wiki page to refer to it, so I'm motivated to respond to review comments. I'll try to help with some reviews, too, of course.15:44
anteayadhellmann: great thanks15:44
AJaegerdhellmann, thanks!15:44
anteayadhellmann: I will leave some stuff in channel and the channel is logged so reply as you are able15:44
dhellmannanteaya: sounds good15:44
anteayaat summit we had a chat about how to organize content15:45
anteayasince some content doesn't fit in just one place in our intended format15:45
anteayaof having guides for specific audiences15:45
dhellmannanteaya: I saw some comments about that, so if this can be split into snippets that should work out15:45
anteayabeginning developers, core-reviewers (or those wanting to), ptls15:45
anteayadhellmann: great that is what I am getting to15:46
anteayathe snippets syntax15:46
anteayamordred found it and we have it on the etherpad15:46
anteayaand so far the rest of us don't have experience with it or how to use it15:46
anteayaI see your patch introduces a new file15:46
dhellmannanteaya: ok, I have lots of sphinx experience so maybe I can help there15:46
*** fungi has joined #openstack-sprint15:46
anteayawhich would be outside our format of guides15:46
anteayaawesome15:46
anteayaso I can review for content15:47
anteayathen we would have to have a chew about how to use snippets so the content can be accessed via one or more of the guides15:47
anteayaif that makes sense15:47
pleia2I'm still a bit tired, need some fresh air, going to go for a quick jog + pick up some coffee15:47
anteayapleia2: enjoy, thanks for getting use rolling15:47
anteayapleia2: see you when you get back15:47
anteayas/use/us15:48
dhellmannanteaya: the only gotcha I can think of with mordred's idea is you will need to make sure sphinx knows it is ok for the snippet files to not be in the toctree. There are a couple of ways to handle that. Simplest is probably to create a doc/snippets and put them all there instead of under doc/source15:48
*** hashar has joined #openstack-sprint15:48
anteayaI'm for the simpliest approach15:48
anteayaespecially since we don't have legacy to consider15:48
anteayaso you have your meeting, I'll have some breakfast, I'll review for content and we can talk more about structure15:49
anteayaand thanks15:49
dhellmannanteaya: sounds good15:49
jeblairre snippets:  we should consider when to use snippers vs simply linking to elsewhere in our own doc.  there's a value to teaching people where to find things in the manual by linking to them (and thereby also introducing them to other content they may otherwise miss), whereas repetition may cause confusion15:54
jeblairi'm not saying one way or the other is always right; i just want us to keep that in mind when making the choice15:54
anteayagood point15:54
anteayamakes sense15:54
anteayasince dhellmann's patch introduces a new file, which is not one of our guides files, i thought talking about snippets was warrented15:55
anteayaso once we have a look at the content we can decide where it should live and when to snip and when to link15:56
anteayasound fair?15:56
jeblairyep15:56
anteayathanks15:56
fungias soon as i finish catching up with things this morning, i'm happy to start reviewing or writing infra-manual changes, whichever is more urgently needed16:01
anteayafungi: thank you! reviewing to start16:03
fungican do16:03
jeblairapproved 126506 (Remove call of 'python setup.py testr' in tox.ini)16:03
anteayafungi: we have an etherpad: https://etherpad.openstack.org/p/infra-manual-sprint-December-201416:04
*** clarkb has joined #openstack-sprint16:09
clarkbohai16:10
jeblairthis is really cool: https://review.openstack.org/#/c/132844/1/doc/source/code_review.png16:10
jeblair(new gerrit showing image diff)16:10
jeblairand approved16:10
clarkbso for someone just waking up after the long weekend, where should I start? review infra-manual changes?16:11
AJaegerjeblair, yeah, really helpfull and much apprectiated for doc reviews16:12
jeblairclarkb: yes.  also see etherpad here: https://etherpad.openstack.org/p/infra-manual-sprint-December-201416:12
clarkbshould that etherpad be in the topic?16:12
jeblairclarkb, fungi: here's one ready for a +3: 10492116:12
jeblairclarkb: probably should be; i think for future virtual sprints, we should work out how to make it easy for people to change the topic and put gerritbot in here16:13
clarkb++16:13
jeblairin the mean time, i will ask an openstack irc op to do it.  ;)16:14
*** ChanServ sets mode: +o jeblair16:14
* AJaeger is driving home now, will rejoin in two hours....16:14
*** jeblair changes topic to "OpenStack infra-manual sprint | Etherpad: https://etherpad.openstack.org/p/infra-manual-sprint-December-2014 | Channel logs at: http://eavesdrop.openstack.org/irclogs/%23openstack-sprint/"16:15
anteayathank you16:18
anteayaclarkb: yes, if you could review any patches that can be merged, that would be a great place to begin16:19
anteayaand welcome16:19
anteayawe had discussed putting gerritbot in here but felt with the lag in changeover after we were done that it wasn't worth it for this sprint16:21
clarkbpleia2: maybe you want to update 135397 with your suggested fix then we can get that through?16:39
pleia2clarkb: sure16:40
*** annegent_ has joined #openstack-sprint16:40
pleia2there we go16:43
clarkbdanke16:43
anteayaso I have a few comments in https://review.openstack.org/#/c/138094/1 about style things16:44
anteayalike should we have a manual wide syntax for saying "this value needs to be replaced"?16:45
anteaya<replacethisvalue>16:45
anteaya$replacethisvalue16:45
anteayahave both been suggested16:45
anteayaI'd like to pick one16:45
anteayaanyone else care/have thoughts?16:46
pleia2I'll sift through docs standards, this must be covered16:46
anteayapleia2: well it is possible that both are used, depending on the documentation16:46
anteayaso don't take too much time with it as we may just have to pick one ourselves16:47
anteayabut I would like to see anything you find on the topic16:47
annegent_pleia2: currently in the install guide we have chosen <replaceable>VARIABLENAME</replaceable> with no dollar sign, but we do get complaints it's not copy pastable16:49
pleia2I don't see anything, but I think I'd prefer the man-style <this> thing16:50
annegent_pleia2: https://wiki.openstack.org/wiki/Documentation/Markup_conventions#Variable_text16:50
clarkbI personally prefer $foo16:51
pleia2annegent_: aha, I was only looking through the contents of the first menubar on that page, thanks :)16:51
pleia2clarkb: me too, but I think that's my geek brain16:51
pleia2documentation for normal people seems to use other things16:51
anteayacan we get a core to mark https://review.openstack.org/#/c/109800/ as wip and take any third party issues out of the rotation for this sprint please?16:52
fungianteaya: on it16:52
anteayathanks16:53
anteayaI don't care whether we pick $foo or <foo> for infra-manual16:53
anteayajust that we pick one16:54
anteayaI can set up a poll if we need to16:54
anteayaso we can vote on it16:54
fungi¿foo?16:54
*** krtaylor has joined #openstack-sprint16:54
*** chandankumar has joined #openstack-sprint16:54
anteayaI don't think that the <replaceable>VARIABLENAME</replaceable> is what we want here, thanks though annegent_16:54
anteayafungi: there's an option too16:55
fungior just ☃16:55
*** annegent_ has quit IRC16:55
clarkbfungi: :)16:55
clarkbreplace all instances of snowman with context sensitive data16:55
anteayaha ha ha16:57
anteayacan't wait for the translation team to weigh in on that16:57
fungiit's a universal constant... no need to translate it16:59
clarkbanteaya: for 108857 does someone want to just add that comma so that we can move on?16:59
jeblairannegent went away :(17:00
clarkbanteaya: note that david is correct about not being able to link to section on git.o.o17:00
jeblairAJaeger: does "<replaceable>VARIABLENAME</replaceable>" do something in docbook?17:01
jeblairperhaps we should make an RST role that does some special decoration?17:01
pleia2clarkb: yeah, I'll take care of that one too17:02
jeblair"The text is frequently italicized in output. " from the wiki page17:02
anteayaclarkb: sorry I just realized I had a draft comment there that I never published17:04
anteayaclarkb: re-reading the patch17:05
*** hashar has quit IRC17:05
clarkbdhellmann: any chance you will be able to address the comments in 138094 this morning?17:06
clarkbawesome looks like dhellmann is one step ahead of me :)17:08
jeblairanteaya: re your general comment on 13809417:08
anteayajeblair: yes17:09
anteayado share your thoughts17:09
fungiany objections to me slightly reworking 108857 per my inline comment?17:09
jeblairanteaya, dhellmann: i think that 'project creators' (or possibly a variant like 'project administrators', or 'project configurators' :) may warrant a manual section...17:09
anteayayay17:09
clarkbfungi: nope17:10
anteayaboy that would make it easy17:10
jeblairat least, it seems to fit in the same kind of audience classifacation as "developers", "core reviewers", "project drivers" ... "project creators"17:10
anteayamakes sense to me17:10
* anteaya notes we still need to have the snippets conversation, just not right now17:10
jeblair(otherwise, i would suggest it belongs with "project drivers", but i actually think they may often be distinct groups of people)17:10
anteayadhellmann: what kind of label would you like?17:11
anteayait is a hefty bit of doc in and of itself17:11
dhellmannjeblair: the problem with a special rst role for variables is it can't be used inline with other markup like preformatted blocks17:12
dhellmannclarkb: yeah, I was in the oslo meeting when those came in17:12
fungipleia2: regarding your reply on my comment, is there some consensus that we should inline display the urls of non-cooked documentation or other files (rather than hyperlinking descriptive text)?17:13
dhellmannjeblair: yeah, I really want this thing to be one LOOOONG list of instructions (well, I'd really prefer a short list, but you know)17:13
pleia2fungi: no, I think that's the problem17:13
fungipleia2: if so, then i'm cool with that. just want to make sure we're reasonably consistent17:13
jeblaircurrently, it's in the form of a tutorial, which is great; i think eventually we may want to evolve a reference-oriented approach (but still keeping a tutoral perhaps as a separate section).  i think if/when that happens, we may be motivated to find a name for it that encompases ongoing administration.17:13
dhellmannanteaya: label? for variables? I'm OK with the <> syntax (see my common on draft 1)17:14
jeblairso i think 'project creators' works for now :)17:14
pleia2fungi: I'm actually inclined to agree with you, since it's proper rst-wise whether we're publishing it somewhere or not (plus, we might some day)17:14
dhellmannjeblair: wfm17:14
anteayadhellmann: I like <> personally17:15
dhellmannanteaya: ok, I think pleia2 did, too, so I'll go make that change now17:15
anteayaand you do raise a good point about using $foo and getting confused with shell script17:16
fungipleia2: i think in this case it counts as a to-do item for the git-review project (there's no reason i'm aware of that we're not publishing its documentation to, e.g., docs.o.o/developer/git-review)17:16
anteayaclarkb: any thoughts ^^17:16
pleia2fungi: sounds good, I'll linkify17:16
fungipleia2: i already have the patch ready, just wanted to check with you before pushing17:17
clarkbanteaya: I think $foo beingconfused with a shell script is the whole point17:17
clarkbanteaya: you can export foo=thingIneed then evaluate any of the text in the document to get the output you really want17:17
pleia2fungi: oh, go for it17:18
fungipleia2: already done17:18
dhellmannanteaya: done17:18
jeblairperhaps we should adopt "$FOO" as a style since it serves the dual purpose of indicating replacability and being directly replaceable in shell scripts (and still likely to fail if the person does not set a value)17:19
fungi<foo> means required parameter to those who read manpages a lot, but i agree it's potentially confusing if someone accidentally pastes it directly into a command prompt since they end up with fd redirections instead17:21
fungialso it gets complicated to render in some html-oriented situations17:21
fungi+1 for $foo in command-line examples17:21
jeblairfungi: though sphinx should take care of <> for us17:21
fungiin this particular case, yes17:22
* anteaya waits17:22
anteayadhellmann: can sphinx do some <> magic?17:23
dhellmannanteaya: yeah, it will render properly17:23
fungiin non-sphinx situations where the document could get rendered as fuzzy sgml, it's possible for the browser to hide it as an unrecognized tag17:23
jeblairanteaya: it's automatic, it's not a concern17:23
fungibut for this case it's not a concern17:23
dhellmannI can change them to $ if you like, and use all caps, too17:23
anteayaso do we have consensens?17:23
* dhellmann doesn't have a bike in this shed :-)17:23
anteayaAJaeger: looks like we need an entry on the doc style conventions17:24
anteayaAJaeger: we appear to agree we are using $FOO for values that need to be replaced17:24
jeblairyeah.  i think we need to choose one style to keep our readers from going crazy, and it seems like $FOO is the most useful, particularly in preformatted blocks of shell commands, which we have a lot of17:25
anteayayes, my goal was one style, so if this is it, I'm good17:26
dhellmannok, $FOO works for me17:26
anteayayay17:26
jeblair(though if you look at the bottom of dhellmann's change, there's a lot of $VARIABLES which actually don't need to be substituted17:26
jeblairso that's sort of context-dependent)17:26
dhellmannjeblair: yeah, I just spotted those17:27
dhellmannthis may be a case where one-size-fits-all doesn't17:27
*** chandankumar has quit IRC17:28
jeblairclarkb: ^ a case for why we shouldn't use $foo -- they are indistinguishable from variables that you should _not_ substitute17:28
clarkbhrm17:29
dhellmannjeblair, clarkb : it has been a while, but that might be why I chose to just go with 'projectname' in the wiki page, assuming it was clear that it needed to be replaced17:29
jeblairdhellmann: you're right about the inline block case; though i think if we really really wanted styled inline blocks, we could define a new directive that did that ('.. niftyinlinereplacementhighlighting::')17:30
dhellmannjeblair: quite likely17:30
jeblairi'm now uncomfortable with the $FOO idea that i think we ought to stick with the <projectname> syntax dhellmann has for now17:32
jeblairi think it will work well enough for the moment and will be more unambiguous if we want to change it later.17:33
anteayaI can get behind <projectname>17:33
clarkbwfm17:34
dhellmannwould it make sense to add a style section to the guide itself?17:34
fungihow about all-caps with no additional wrapper characters?17:34
dhellmannfungi: that has the same ambiguity questions when documenting changes to devstack17:34
dhellmanns/questions/issues17:34
anteayadhellmann: well we are using the Documentation team's style guide17:35
fungithat's infrequently confusing in command-line examples because programmers are lazy and don't like to hold down shift or needlessly strike caps-lock17:35
dhellmannfungi: PROJECTS="openstack/<projectname> $PROJECTS17:35
anteayahttps://wiki.openstack.org/wiki/Documentation/Conventions17:35
fungihrm, yeah i suppose so17:35
dhellmannanteaya: I was thinking of a small section at the top saying "when you see <projectname> in an example, replace it with the name of your project" or whatever17:36
anteayadhellmann: ah a reader's usage style guide17:36
* dhellmann notes that the real solution to this is to automate the process of generating the first version of the patch17:36
anteayadhellmann: I think we should have one infra-manual wide17:37
fungia "documentation conventions" section?17:37
anteayayeah17:37
dhellmannfungi: yeah17:37
dhellmannanteaya: sure, that makes sense, too17:37
anteayamakes sense, then readers know what we mean17:37
fungithat's a fairly common convention, so seems useful to tackle it that way17:37
anteayawell I hope that what we decide for conventions will be infra-manual wide17:37
anteayashall we put it in the ehterpad as a todo?17:38
anteayathen we can track it17:38
anteayahttps://etherpad.openstack.org/p/infra-manual-sprint-December-201417:38
anteayaI can add it17:38
fungithough i note that <> syntax is (less frequently) confusing in cases like `./script.sh </dev/null>/dev/null 2>&1 &`17:39
anteayafair enough17:39
anteayatough to find a one size fits all17:39
fungisince < and > are shell convention for redirecting file descriptors17:40
fungiyep. i think that's an unusual enough situation that it doesn't merit optimizing our style to avoid17:41
fungijust putting it out there that it can have a potentially confusing failure mode with invisible side effects if someone pastes a <foo> in a command line invocation without properly substituting17:42
anteayayes17:44
anteayajeblair: let me know when you are able to discuss https://review.openstack.org/#/c/104951/17:44
*** AJaeger_ has joined #openstack-sprint17:44
anteayajeblair: you suggest putting it in a section other than the one offered17:44
anteayawhich I am fine with and you make a good point17:45
anteayaany thoughts on where to put it?17:45
anteayais this a case for snippets, I wonder17:47
dhellmannanteaya: regarding the "groups" list; I'd like to have a valid default to mention in the docs but I don't know what it is. "openstack"? is that the launchpad project group name, or something else?17:48
anteayadhellmann: you raise a good question, to which I dont' have the answer17:49
anteayadhellmann: lets see if we can ask in -infra17:49
fungipleia2: inline comments on 107741. let me know if you agree and would like me to address those or if you want to do it17:49
dhellmannanteaya: it looks like most projects don't have the value at all, so I assume it can be left out unless the lp project is not in the openstack project group17:50
pleia2fungi: thanks, I'll have a look17:50
anteayadhellmann: we could do that yes, to be honest I am uncertain of the state of launchpad/storyboard groups so I don't know if not offering a default value is the preference17:52
jeblairi need to check out for maybe 30-60 mins; anteaya: talk when i'm back?17:56
anteayajeblair: of course, happy whateveritisyouaredoing17:58
anteayadhellmann: the information fungi provides in the comment is actually useful information that I didn't clearly have before I read that17:58
anteayadhellmann: any thoughts on capturing the information in the comment in the document?17:59
fungianteaya: dhellmann: the history is that used to be a single-parameter option called "launchpad" which was used to do git repository to lp project mapping for situations where they were not equivalent. we renamed it to "group" and then later to "groups" and turned it into a list of potential group names, so that we can leverage it for grouping in storyboard at some point in the future18:00
fungidocumenting the history isn't necessary, but pointing out that it's optional and in many (most?) cases unnecessary18:01
fungiwould be good i think18:01
anteayaokay18:02
anteayaI'll just have these logs for my reference18:02
dhellmannfungi: done18:04
fungidhellmann: thanks--going through it in greater detail now18:07
*** jesusaurus has joined #openstack-sprint18:09
*** reed has joined #openstack-sprint18:11
anteayaso where do we stand on directing new projects to set up launchpad pages?18:12
pleia2I don't like continuing to go down that path, but it will be several months before storyboard is ready for them18:13
pleia2I think we have to document how it's done today and update when it's time to make the transition18:13
dhellmannpleia2: ++18:13
fungiyes, launchpad is where we (openstack projects on the whole) do bugs. best not to get ahead of ourselves18:16
anteayadhellmann: how do we make a comment in .rst so we can note this section needs to be updated when we move to storyboard, but won't be published18:16
anteayaokay, as long as we have a plan18:16
dhellmannanteaya: if you prefix a section with just ".." that will make it a comment. I'll do that for the section you're talking about18:16
anteayathanks18:16
AJaeger_I'm currently updating developers.rst to remove reverify and noticed some overlong lines.18:17
fungianteaya: dhellmann: though i also like to think of the rst files as readable plaintext documentation, so having content in there which is hidden from the rendered version ought to be avoided when reasonably possible18:17
AJaeger_Ok to wrap them as part of changing a paragraph? Or should this be a separate patch?18:17
anteayaalso it appears the cookiecutters will need to be allow for storyboard, if I understand nibalizer's cookiecutter concerns correctly18:18
anteayaAJaeger_: you are so wonderful, thank you18:18
anteayafungi: fair enough18:18
dhellmannanteaya: done18:18
*** gothicmindfood has joined #openstack-sprint18:18
anteayaI would like some sort of indicator to show that we know this part of the process in in flux18:18
dhellmannanteaya: the templates provide a link to the place to report bugs for the project, so it should be easy enough to update them18:19
pleia2combing through reviews+documentation now to identify some todo items for folks who want to pitch in, will add to the etherpad under "What you're working on now" so people can assign themselves18:19
anteayait might stave off some questions from folks who wonder about storyboard18:19
nibalizeranteaya: that wasn't really my point but you're right that they'll need that18:19
anteayapleia2: thanks, actually I have added a TODO section18:19
anteayanibalizer: an extention of the point you made18:19
pleia2anteaya: ah! just noticed that, I'll add there18:19
anteayapleia2: thanks18:20
anteayadhellmann: great18:20
* dhellmann heads off in search of food18:21
anteayadhellmann: enjoy18:22
anteayayay we are merging stuff: http://git.openstack.org/cgit/openstack-infra/infra-manual/log/18:25
anteaya\o/18:25
pleia2anteaya: are we going to ignore 3rd party entirely during this sprint? (I don't remember what the consensus was as far as what goes in our docs and what goes elsewhere re: jaypipes' blog posts)18:25
anteayayes, I would like to18:26
pleia2ok, I'll make a note in the pad18:26
anteayasimply because we could spend two days on that material18:26
krtaylorpleia2, I thought we had agreed to wait until third_party.rst had been revised with the third-party WG18:26
anteayathanks18:26
krtayloragreed18:27
anteayaand we have entire manuals that have no content18:27
anteayathe core-reviewers section has nothing but titles18:27
anteayaso we focus on dev, core, ptl sections and get as far as we can18:27
anteayaand then rally round third party docs seperately18:27
*** annegent_ has joined #openstack-sprint18:27
anteayapleia2: and thanks18:28
anteayakrtaylor: :D18:28
pleia2anteaya: yep, under TODO I identified those sections18:29
anteayathanks18:31
anteayashould we create an images directory? http://git.openstack.org/cgit/openstack-infra/infra-manual/tree/doc/source18:32
anteayaI'm leaning yes18:32
pleia2Developer's Guide is pretty low hanging fruit, we need some project driver types and core reviewers to tackle much of what we have left to write18:32
anteayapleia2: we do18:32
anteayaI think if we can focus on hitting the style and structure conventions in this sprint18:33
anteayathen we can track down ptl types and at least pick their brain for this info18:33
anteayafor the sections I don't know anyway18:33
anteayaI have time to do that at mid-cycles18:33
anteayathat was my plan18:34
pleia2is anyone using blueprints anymore, or has everything been transitioned to specs?18:34
AJaeger_pleia2: I think manila has no specs - but that's the odd one out.18:35
fungipleia2: they're used together18:35
AJaeger_Just document the specs process and add a section for project that only use blueprints but not specs repo.18:35
AJaeger_pleia2: workflow is AFAIK : Create spec, create blueprint, get blueprint approved, approve spec18:36
AJaeger_and create links between spec and blueprint18:36
AJaeger_for the developers guide: What do we expect to cover in the merging part?18:36
AJaeger_post jobs?18:36
clarkbok sorry I got distracted. Turns out today is a good day to buy a laptop and I needed a new one18:36
AJaeger_And that jobs get merged automatically?18:37
clarkbany pressing things I should look at?18:37
anteayaclarkb: pick a good one18:37
anteayaclarkb: ah you are back from shopping18:37
clarkbmostly. I do need to eat some food thouhg18:37
AJaeger_reviews for  https://review.openstack.org/138143 - removes reverify - are welcome18:37
anteayame too18:37
anteayaI'm going to go eat then will respond to your questions AJaeger_18:38
AJaeger_anteaya: enjoy your mail!18:38
pleia2AJaeger_: that workflow hurts my brain :(18:38
AJaeger_pleia2: yeah ;(18:38
AJaeger_pleia2: see http://specs.openstack.org/openstack/nova-specs/readme.html18:39
AJaeger_I think most specs repos use a similar wording, once we have this in, we could send patches to the specs repo ;)18:39
pleia2AJaeger_: thanks, I'll work with this for a patch and we can review away against it :)18:40
AJaeger_pleia2: go for it!18:40
reedI've started putting the review checklist in developer.rst and wanted to ask how we want to treat the different instructions for separate programs18:44
clarkbreed: I think we would have to defer to the programs18:44
clarkband be hand wavy about it18:44
clarkbimo this document shouldn't try to accomodate all the specific projects18:44
reedon https://wiki.openstack.org/wiki/ReviewChecklist there are notes for horizon and non-core...18:44
reedclarkb, I agree with you...18:45
reedok, pushing the change up for review as I have it and we can discuss on gerrit the details18:45
fungithough mentioning practices common across a majority of programs is definitely on topic there18:45
clarkbyup18:45
fungias perhaps is linking to places where you can find general info about program-specific practices not included in the document18:46
reedfungi, right ... would that be ... what? the generic landing page http://docs.openstack.org/developer ?18:48
AJaeger_reed: that page has no review information, I think it's mainly in the wiki. Perhaps we need to create one.18:50
reedclarkb, what laptop are you buying?18:50
clarkbreed: x24018:50
clarkbreed: ttx convinced me in paris that it actually is the machine I want. really good battery life, reasonable size and terrible trackpad18:50
reedAJaeger_, that page needs to be redone, yes... I have to start that conversation (I have a draft already, haven't had time to push the send button)18:50
clarkbbut I can live with terrible trackpad as there are apparently xorg hacks to make it better18:51
reedclarkb, I live with an external mouse anyway :)18:51
clarkbcan anyone reproduce `git review -d 137240` failures?18:51
clarkbit is failing for me18:51
clarkbalso broadwell looks like a bust so I am not waiting for those chips anymore18:52
fungireed: i know some groups have their own specific details linked from the how to contribute wiki18:52
AJaeger_clarkb: works for me in system-config18:52
clarkboh its system config18:53
clarkbI am in project-config18:53
clarkb:/18:53
clarkbAJaeger_: thank you18:53
anteayanibalizer: your vote on https://review.openstack.org/#/c/107741/ got applied to patchset 9, did you want to review patchset 10?19:00
nibalizersure19:05
clarkbjeblair: when you get back 108857 should be good to go and needs +319:07
AJaeger_reed: your patch contains many whitespaces at EOL and the lines are not properly intented. Do you know what to do to fix this or do you need help?19:08
clarkbanteaya: 104951 do you plan on doing the refactor that jeblair suggested?19:08
*** annegent_ has quit IRC19:08
reedAJaeger_, I definitely need help with the whitespace issue. A .viminfo example I can grab?19:09
clarkbreed: set list then set listchars=tab:>-,trail:-,extends:#,nbsp:- will highlight trailing whitespace19:09
AJaeger_reed: I don't have one to offer. I can offer to clean the patch up for you.19:09
dhellmannanteaya: your images directory: https://review.openstack.org/#/c/138153/19:10
reedAJaeger_, I better learn how not to repeat that mistake :) it scales better, thanks for offering though19:10
reedclarkb, there is no way to delete those automatically?19:10
AJaeger_reed: sure. Note that you need to indent lines in a enumerated list, see http://docutils.sourceforge.net/docs/user/rst/quickref.html#enumerated-lists19:11
clarkbreed: I think there may be. I prefer to highlight it19:11
clarkbso unsure of auto deletion19:11
anteayaclarkb: sorry I have marked 104951 as wip until I talk with Jim19:12
anteayaclarkb: yes, I want to find out where a better place for this should be19:12
clarkbanteaya: sounds good19:13
anteayathanks19:13
reedclarkb, how to make those changes permanent?19:13
clarkbAJaeger_: 138148 has a -1 from me19:13
anteayadhellmann: ah aren't you wonderful, thank you19:13
clarkbreed: I put them in my .vimrc file19:14
clarkbreed: on two separate lines so it is configured whenever vim runs19:14
fungii hate that i'm such a slow reader19:14
fungidhellmann: i just added 23 comments to patchset 5 of 13809419:15
fungiin that time it grew four new patchsets, so i'm not sure how many of them are relevant now19:15
dhellmannfungi: I'm working on adding sphinx docs to git-review for a bit, so I'll come back around and look at the comments in a while and ignore anything that's obsolete. Most of those other changes were really small though.19:16
reedthanks clarkb19:16
fungidhellmann: yeah, i'm checking the diff now. hopefully it didn't include any rebases19:16
reedAJaeger_, what about indentation? I'm not sure i see the problem19:16
dhellmannfungi: I don't think I did19:16
AJaeger_anteaya asks in https://review.openstack.org/138143 whether "recheck bug XXXX" is obsolete - I think it isn't. Anybody to clarify?19:17
AJaeger_reed, write:19:17
AJaeger_1. test19:17
AJaeger_  test test19:17
AJaeger_ARgh, one more space in front19:17
AJaeger_1. test long lline19:17
AJaeger_   next line of same paragraph19:17
AJaeger_reed: see the link I gave19:18
fungidhellmann: nope--looks like all my comments are still relevant19:18
AJaeger_another question about 138143: The current section mentions the lanuchpad "openstack-ci project"19:19
AJaeger_What should we say there?19:19
clarkbfungi: what is status on closing down openstack-ci and using the new tracker on launchpad?19:20
clarkbfungi: I see a fair amount of bug traffic via email today19:20
clarkbfungi: also https://review.openstack.org/#/c/138143/1/doc/source/developers.rst may need to be updated if we switch soon19:20
fungiclarkb: i haven't started yet19:21
* fungi wears hat of shame19:21
reedAJaeger_, how about nested enumerated lists?19:22
clarkbAJaeger_: comments on https://review.openstack.org/#/c/138143/ now too19:22
fungii'll ping the relevant people on it now, but i'll add updating the text from 138143 (with a new patchset or another change if it's already merged) to the list of steps19:22
AJaeger_clarkb: thanks for keeping me busy ;)19:22
clarkbAJaeger_: no problem19:22
AJaeger_reed: Indent them.19:22
AJaeger_reed: send a next review and I'll comment on it19:22
reedk19:23
AJaeger_clarkb: pushed new change sets.19:26
AJaeger_anteaya: you're right that we need to work storyboard in - but I propose to do this in a separate patch set.19:29
anteayaI will buy that19:30
anteayayou are the machine for patches, I am having trouble keeping up with you19:30
anteayago go go19:31
reedAJaeger_, thanks, check the new patch I sent19:31
anteayaI'm going over the summit etherpad: https://etherpad.openstack.org/p/kilo-infra-manual to ensure we are addressing all the mentioned issues19:31
pleia2anteaya: good thing someone is, my writing brain has apparently taken the day off, ugh19:31
clarkbits that long weekend hangover19:32
clarkbI am suffering from it as well19:32
clarkbdoing my best to review19:32
reeddevelopers.rst is a very long file already :)19:34
clarkbya ...19:34
clarkbnot sure if good or bad. But I think right now getting content then reorganizing as necessary may be best19:34
reedclarkb, totally agree with you: get off the wiki first :)19:35
anteayapleia2: not to worry, just do the thing that is in front of you, you are doing great :D19:35
anteayaclarkb: ++19:35
* pleia2 soldiers on with specs/blueprints section19:35
AJaeger_reed: nicely reformatted, I could concentrate on nits ;)19:37
AJaeger_yeah, two more patches merged ;)19:38
clarkbnibalizer: re 138159 not sure I want that there since its all generic "most other unix systems" too19:38
clarkbnibalizer: maybe link to generic pip how to install stuff instead?19:39
anteayayay merged patches19:40
anteayanibalizer: I'm in agreement with clarkb, using the word pip as an anchor leads me to believe we should be linking to pip docs19:41
AJaeger_for the core.rst file: Should we document "Work in Progress" setting of somebody else's patch?19:42
reeddo we want to keep https://wiki.openstack.org/wiki/GitCommitMessages in the wiki or move to infra-manual?19:43
anteayaAJaeger_: I think so19:44
* AJaeger_ adds it to the etherpad as section19:44
anteayareed: it is a fairly hefty body of work19:44
anteayareed: we have linked to it in the manual19:44
reedanteaya, ok, let's link it to wiki then19:44
anteayareed: I think linking to it is fine for the moment19:44
anteayareed: sounds good19:45
reedsame with DocImpact, I guess19:45
AJaeger_for now, let's leave it in the wiki - we can move this later. And then it needs to be a separate document.19:45
reedhttps://wiki.openstack.org/wiki/Documentation/DocImpact19:45
AJaeger_reed, yeah, just link to those for now.19:45
reedok, agreed19:45
anteayagreat19:53
nibalizerclarkb: anteaya what if i move the link to 'osx' ?19:56
nibalizerthat way you know you're getting something osxy ?19:56
clarkbnibalizer: no I think having an os x link in there at all is wrong19:57
reedAJaeger_, RST issue: this line with no break builds nicely  1. Learn the best practices for `git commit messages <https://wiki.openstack.org/wiki/GitCommitMessages>`_.19:57
clarkbnibalizer: we shouldn't try to handle every case ever. instead just say "use pip here are pip docs"19:57
reedbut if I put a line break between 'messages' and '<http...  the build fails19:57
nibalizerokay19:58
nibalizerill just abandon19:58
AJaeger_reed in that case don't wrap it ;)19:58
reedah, simple then :)19:58
* reed feels like rst is just another giant hack19:59
anteayanibalizer: I am in agreement with clarkb20:00
anteayanibalizer: please don't abandon20:00
anteayanibalizer: it would be great to have a link to pip docs20:00
anteayajust change the commit message and links20:00
reedseems like SecurityImpact is not fully documented on the wiki (couldn't find a URL for it)20:01
nibalizeranteaya: oh okay20:01
nibalizerwill do20:01
AJaeger_reed: You can link to https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references20:02
AJaeger_There's also APIImpact now20:02
AJaeger_reed: ping the security team to write a nice wiki page about it;)20:02
reedit's pretty awful but I'll make do20:02
reedsame with apiimpact20:02
anteayanibalizer: thanks20:03
AJaeger_reed, might be better not to link for those two for now.20:04
clarkbAJaeger_: there was already a WIP doc change somewhere20:04
clarkbAJaeger_: is yours conflicting with that?20:04
AJaeger_clarkb: OOps, let me check20:04
AJaeger_clarkb: I can't find it20:04
clarkbya I can't find it either but I swear I reviewed it this morning20:05
clarkbAJaeger_: I9ce84f5db0aac5e3e5e0ef8a1d8c3497903c16ac found it20:05
dhellmannfungi: regarding the pypi permissions, I have been telling everyone to use Owner for precisely the reason you point out -- it would let us edit all of the settings and remove a human "owner" who leaves the project20:06
AJaeger_clarkb: that's for developers - I think we need to document it for cores as well, don't we?20:06
clarkbAJaeger_: oh I see the distinction20:07
clarkbAJaeger_: yup20:07
AJaeger_clarkb: should we crosslink from core.rst to developer.rst?20:07
fungidhellmann: that's a valid counterargument20:07
clarkbAJaeger_: I think the audience is sufficiently different that we don't need to20:08
anteayafungi: can we get https://review.openstack.org/#/c/138153/ merged and then dhellmann can rebase?20:09
AJaeger_clarkb: let me move WIp to the end of the file, I'm currently looking into the other sections20:09
clarkbAJaeger_: ok20:09
fungianteaya: done20:09
AJaeger_clarkb: send again, no text changes20:10
dhellmannfungi, AJaeger_ : we should talk about the warnings for the project-config changes20:10
AJaeger_clarkb: thanks for the review20:10
anteayafungi: thank you20:11
dhellmannI found that those 2 spots where I included warnings to be the most commonly out of date sections, and included the warnings in the wiki so Oslo devs would pay attention and update the wiki as needed. It also reduced frustration at having a patch that "followed the directions" being rejected by the project-config team.20:11
AJaeger_dhellmann: thinking how long it took us with infra-manual to come to the current state, it might be better to leave the warnings in ;(20:11
anteayaI am fine with the warnings in20:11
reedAJaeger_, I noticed that if I don't indent the line break, the file builds: 6. The code should comply with the community `logging standards20:11
reed   <https://wiki.openstack.org/wiki/LoggingStandards>`_.20:11
dhellmannobviously, all of this *could* get out of date, but those are the spots that did *every time* we created a new repo -- there was a lot of template refactoring going on last cycle, I think20:12
anteayadhellmann: and no reason to believe template refactoring won't continue20:12
AJaeger_reed, send in what works ;)20:12
dhellmannAJaeger_: if this doc was in the project-config repository, those sections could pull in live examples using an include directive20:12
dhellmannanteaya: sure, though I think/hope maybe the pace will slow down now20:12
anteayadhellmann: idealist20:13
AJaeger_;)20:13
dhellmannanteaya: touche20:13
AJaeger_dhellmann: we just merged today another templatization patch ;)20:13
dhellmannAJaeger_, fungi : would it be more palatable if I included a sentence about submitting a patch to the doc if it is out of date?20:13
dhellmannAJaeger_: death by 1000 refactorings20:14
anteayadhellmann: yeah, work with AJaeger_ a bit longer20:14
anteayadhellmann: dude must rearrange his furniture in his house everyday20:14
anteayafor maximum efficientcy20:14
anteaya:D20:14
fungidhellmann: yeah, i think that's reasonable. but also we should try to be better about updating our documentation if we're making changes to that stuff... especially now that it's rst in git20:15
AJaeger_anteaya: my family won't let me ;)20:15
anteayaha ha ha20:15
anteayawhat magic incantation did they use, and can they teach it to me?20:15
AJaeger_dhellmann,  agreed20:15
dhellmannfungi: totally agree with wanting to be better20:15
* AJaeger_ is not going to answer anteaya ;)20:16
anteayaha ha ha20:16
anteaya:D20:16
fungidhellmann: i fairness, it was harder to keep updated when it was documented in a wiki article which was maybe only somewhat known to the infra team20:16
dhellmannfungi: yes, that was completely the problem and I knew that going in -- it was easier for us to manage it in the wiki until we had the steps worked out20:17
fungii'm hoping that we can convince people proposing major architectural changes to job stuff to update the relevant infra manual sections while they're at it20:17
dhellmannfungi: I didn't expect you all to manage the directions at that point20:17
jeblair'grep' helps a _lot_ with this sort of thing20:17
dhellmannfungi: ok, in the spirit of optimism that that will happen, I'll remove the warnings :-)20:18
fungidhellmann: my main concern with pessimistic warnings about it having the possibility of falling out of date is that it can reduce the reader's confidence in the accuracy of what they're reading (and thus the point in reading it at all)20:20
dhellmannfungi: fair20:20
fungiwhich just means they come asking us every time20:21
fungisomewhat defeating the purpose of having a manual20:21
AJaeger_fungi: we should ask people doing changes for project-config etc. to update infra-manual if needed as well.20:23
AJaeger_But that means we need to be aware of the content of infra-manual.20:23
anteayaAJaeger_: I have no problem with that20:24
fungiAJaeger_: yeah, i'm hoping anyone who acts as a core reviewer on any openstack-infra project has more than a passing familiarity with the contents of the infra manual ;)20:24
AJaeger_anteaya: it's something we should do as review on a best-effort base. I'm fine with adding a -1 to a patch and asking for a patch for infra-manual first20:24
AJaeger_fungi: not only familiarity but also knowing that it's documented and that a proposed patch will "break" the manual - and thus the manual needs updating20:25
anteayasure20:25
fungiAJaeger_: everything we do is "best effort" anyway, so no disagreement from me. there are no guarantees20:25
anteayathe manual patch doesn't need to be merged, just exist and linked in the commit message with the project-config patch mentioned in the commit message of the manual patch20:26
AJaeger_fungi: yeah...20:26
AJaeger_anteaya: yes, indeed20:27
fungii'm also hoping that we find ways to make infra-manual and our related infra projects abstracted from one another enough that it takes more than trivial changes to invalidate the documentation, so i wouldn't expect that to come up all the time unless we're doing something wrong20:27
dhellmannfungi: ps 9 of https://review.openstack.org/#/c/138094/ should address your comments20:41
fungidhellmann: great--thanks!20:41
anteayaI am noting the time and realize that I haven't gone for a walk yet today20:44
clarkband I haven't eaten20:44
clarkbso I am doing that now20:44
anteayaso I am heading out and will be back in about an hour20:44
anteayaclarkb: yes thank you, eating is a good idea20:44
anteayaplease eat20:44
AJaeger_clarkb: enjoy!20:50
AJaeger_anteaya: have a great walk!20:51
reeddhellmann, the instructions to create a new project may also go somewhere in docs.openstack.org/developer but I don't know how to do that20:52
reedin theory the whole content of infra-manual may well sit there since it's documentation for infra tool as much as it is documentation for contributors20:53
dhellmannreed: I assume there are plans to publish the infra-manual stuff, if it isn't already being published20:53
reeddhellmann, it's published already afaik20:54
reedhttp://docs.openstack.org/infra/manual/20:54
pleia2lunch break here too, bbiab20:55
AJaeger_and linked from http://docs.openstack.org/ , see "OpenStack Infrastructure User Manual "20:56
AJaeger_reed: for adding something to the index page - it's a patch against openstack-manuals20:57
AJaeger_reed: To get something published on docs.openstack.org: That's a patch against project-config repo20:57
reedAJaeger_, thanks20:57
jeblairanteaya: i'm back; i'm sorry that took so long :(21:02
AJaeger_jeblair: Now she's gone for a walk ;)21:02
jeblairi know :(21:02
jeblairwe should probably drop stackforge.rst from system-config docs once dhellmann's change merges21:04
clarkb+21:04
clarkber ++21:05
fungiagreed, i'm hoping it can fully replace that old document21:05
AJaeger_agreed21:05
fungidhellmann: the change lgtm but AJaeger_ has some good suggestions in there too. i think it's getting veeeery close now21:06
AJaeger_fungi: +121:08
jeblairhrm, i'm not sure i'm keen on the new project creation instructions requiring github21:09
jeblairit should be pretty easy to re-order those to "create the project, clone it, run cookiecutter, git commit, git review", right?21:09
AJaeger_jeblair: do you want to start with an empty repo?21:11
clarkbya or even host cookiecuttered project not on github21:11
AJaeger_Can we import from anywhere that is a public location?21:12
clarkbyup21:12
jeblairAJaeger_: yes.  i think starting from an empty repo is a good thing21:12
fungiright, unless there are preexisting commits you need imported to preserve history, you should ideally start with the empty repo and push your initial content as the first change21:12
AJaeger_fungi: agreed21:12
fungithe trick there is that cookiecutter will create a new git repo, right? so you need to adjust your remote and rebase it onto the initial .gitreview commit added by manage-projects in that case21:13
dhellmannAJaeger_: ps 10 should address your comments21:13
clarkbnibalizer: can you update the commit message on https://review.openstack.org/#/c/138159/2 too?21:13
AJaeger_dhellmann: it does - I'm calling it a day now ;)21:15
dhellmannAJaeger_: thanks for your reviews21:15
* AJaeger_ waves good-bye. I'll continue in 10 hours21:15
AJaeger_dhellmann: thanks a lot for your great patch and ultra-fast turn-around!21:15
*** AJaeger_ has quit IRC21:16
jeblairi need to add a command to "copy my line comments from previous patchset" to gertty21:17
clarkbpleia2: re 138179 did you want to address the suggestions there? there is no -1 but figured I would aks before I +221:18
dhellmannjeblair: these instructions are turning into something useless to me for oslo. I may have to maintain my wiki page even if this thing merges.21:19
dhellmannjeblair: what's more common, creating a project from scratch or importing something that has been started elsewhere?21:19
jeblairdhellmann: oh, i thought my suggestion was not incompatible with oslo21:19
dhellmannjeblair: in 99% of the cases for oslo there will be a repository somewhere that we need to import21:19
jeblairdhellmann: i was referring to where you provide directions on creating a new project from scratch21:20
jeblairdhellmann: i believe that both cases should be documented; i just thing that the case where a project is created from scratch should have different instructions21:20
dhellmannjeblair: yeah, we don't actually do that for oslo so I guess it doesn't matter21:20
dhellmannjeblair: ok, the initial steps are actually pretty different in the from scratch case that doesn't involve an import -- several of the other sections end up having to be split up because you don't want to add test jobs until there's content, for example21:21
dhellmannoh, I see, I didn't copy over the oslo-specific steps for exporting a repository21:22
jeblairdhellmann: are we still talking about the 'from scratch' case?21:22
pleia2clarkb: yeah, I'll address those in a few21:22
dhellmannjeblair: we are, although I'm assuming there's some stuff in that repository besides what cookiecutter creates21:22
jeblairdhellmann: it's okay to add test jobs for an empty repository -- the first commit just needs to add whatever they need.  cookiecutter should do that (eg, unit tests should noop successfully)21:23
dhellmannI guess the only difference is that there's a step after creating the repository to populate it, where if you have a repository you DO NOT want that, you want it imported21:24
jeblairdhellmann: yes (though it saves you the step of creating the project in github and pushing to it).  but yes, you very much don't want to create an empty repo if you plan on importing21:25
dhellmannjeblair: it's hard to make a linear set of instructions that supports both of these cases; lots of gotos21:27
dhellmannjeblair: I'll look at it a little more21:27
jeblairdhellmann: ok.  i'm not looking at it right now, but the vague idea in my head was that you'd discuss the import option when writing the project-config change, and then discuss the create-from-scratch option later on; so mostly linear with a few conditionals21:29
dhellmannyeah, that may work21:29
jeblairlater-on == after approval+creation21:29
*** jesusaur has joined #openstack-sprint21:29
anteayajeblair: I am back now21:30
anteayaand ready to discuss that patch21:30
jeblairwoohoo21:30
anteayahere it is: https://review.openstack.org/#/c/104951/21:31
* anteaya listens21:31
*** jesusaurus has quit IRC21:31
*** jesusaur is now known as jesusaurus21:31
jeblairanteaya: a lot of the material in there feels somewhat like a tutorial21:33
anteayafair enough21:33
anteayawhat is our ability to do javascripty expandable sections with rst21:33
jeblairwhich i think is really useful, but i don't want experienced git users to see it and think that the whole section is not for them21:33
anteayathen the folks who don't need the tutorial can not expand and aren't overwhelmed by content21:33
anteayaright21:33
anteayaand I wrote it for the brand new newbs I was handholding21:34
anteayaI don't tend to spend much time wiht the experienced git users21:34
anteayathey don't need me21:34
anteayaso how do we address both audiences21:34
anteayawithout upsetting the other?21:34
jeblairwe could create a new standalone document or section for this walkthrough, and link to it from the developer manual?21:35
anteayasure21:35
anteayawe have a section in the repo called notes21:35
anteayaI could stuff it in notes21:35
jeblairi think there are some similarities with the current work around new projects (except that most of that doesn't also have reference material yet)21:35
anteayasorry notes is a file, I'm not sure where it is used21:36
jeblairanteaya: i think notes might be left over from my original sketch :)21:36
anteayaah21:36
anteayathat would make sense21:37
anteayaso how to address the needs of the seasoned dev who needs slim docs so they feel comfortable and contribute21:39
anteayaand have something to point brand new people to so that I don't have to keep repeating myself21:39
jeblairanteaya: so i'm okay with the first part of that change more or less as-is where you change 'nova' -> 'sandbox' (even with the additional text)21:40
anteayanot sure if you caught it last night but the devs intel has selected for setting up the third party ci for nfv have never used irc before, so that was last night's work21:40
jeblairi think that's a good idea regardless21:40
anteayaokay, thanks21:41
jeblairanteaya: then the next section is really basic (like what happens if you are in the wrong directory), and then there's some stuff that's repetitive with the following sections in the manual21:43
jeblairanteaya: (under 'starting a change', we talk about how to create a branch, etc)21:43
anteayayeah21:44
fungii'm going to run out to grab some food. need to drill holes in walls tonight and want to be able to do that before it's so late i feel bad for the neighbors. after that i'll get some more infra-manual reviews knocked out21:44
anteayaand that is the stuff I have to tell folks over and over again21:44
anteayasince they don't know it and they don't know what to do21:44
jeblairanteaya: so i think that's all stuff that can be removed from this section without losing information21:44
anteayaand if it isn't written down, I have do tell them21:45
jeblairanteaya: well, it is written down, in the very document it's being added to21:45
anteayafungi: thanks enjoy food and drilling21:45
anteayajeblair: can I see it in a comment, so I know which lines you mean?21:45
jeblairanteaya: sure21:46
anteayaI have no problem removing repetition21:46
anteayathanks21:46
* anteaya puts some soup on the stove21:50
dhellmannjeblair: see what you think of ps 12 on https://review.openstack.org/#/c/138094/21:52
jeblairanteaya: specific line comments left.21:54
anteayajeblair: thank you21:55
* anteaya reviews21:55
anteayapleia2: you can't git clone by clicking an https link21:56
anteayabut I take your point about expectations around links in docs21:56
pleia2anteaya: you can't do anything by clicking on the http link21:56
pleia2er, https21:57
pleia2it opens a blank page, that confuses folks21:57
jeblaircan we convince sphinx _not_ to hyperlink that?21:57
clarkbliteral quote it?21:57
jeblairpleia2: also, istr some conversation about using mod rewrite to inspect incoming headers and possibly redirect that for non-git clients... is that something we should do?21:58
pleia2jeblair: I dunno, that gets sticky21:58
anteayaclarkb: double or single quotes?21:59
clarkb`` iirc21:59
clarkb``stuff``21:59
jeblairdhellmann: generally lgtm, thanks; left inline nit.21:59
anteayaI'll try ``stuff`` thanks, those are backticks I used not quotes22:00
clarkbyup22:01
dhellmannjeblair: nit addressed22:01
clarkbI will review dhellmann's change next22:02
dhellmannI'm going to call it a day. I'll check back for more comments on that creator's guide in the morning. Thanks for your help today, everyone!22:05
anteayadhellmann: thanks so much for all your help doug22:06
anteayadhellmann: enjoy the evening22:06
jeblairdhellmann: thank you so much!  you're filling in a huge gap in our docs! :)22:06
anteayadon't review my latest patchset I still need to figure out how to rework to remove duplication22:06
jeblairanteaya: i think it's worth figuring out why you don't like the existing content :)22:08
anteayaI like the existing content so much I duped it :D22:08
jeblairhehe22:08
anteayatrying to figure out how to figure out a better order22:08
anteayaor what I consider to be a better order22:08
anteayaI think part of it might be the sections22:12
anteayagetting started and development workflow22:12
anteayasince when I hand hold folks I don't even talk about anything else before they have a patch on sandbox22:12
anteayasince they haven't done enough to understand anything else anyway22:13
jeblairwhereas normally we would not recommend a new developer start a patch without claimining a bug or blueprint first :)22:13
jeblairclaiming even22:13
anteayawhereas it might be concievable that someone skips the getting started and moves straight to workflow22:13
anteayastarting a patch, yes22:13
anteayaand the folks I work with can't even comprehend starting a patch before they figure out the sandbox22:14
anteayaI guess it comes down to different audiences22:14
anteayaperhaps I am trying to make the manual be all things to all people22:15
anteayaand the folks I hand hold need something different than a manual22:15
jeblairanteaya: so i think our choices are to move your walkthrough to another section (and link to it from the dev guide), or merge all the existing 'git operations' together into the getting started section, similar to how you've structured the walkthrough (though we should probably still break it up into minor sections so we can link to, eg, "updating a change")22:18
anteayathe `` prevented the url from being a hyperlink but they show up in the text: http://docs-draft.openstack.org/51/104951/12/check/gate-infra-manual-docs/2b19394/doc/build/html/developers.html#development-workflow22:18
anteayalet's look at setting up another section and linking22:19
anteayathis won't be the first section that needs some remedial help22:19
anteayayou do make a good point, they need to create/find a bug or blueprint first, I don't want to be teaching folks bad habits22:20
anteayaso shall we create a directory of random pages not linked to the index page but linked via other pages?22:20
clarkbjeblair: I think the current stack of infra manual changes that are not WIP'd lgtm22:21
*** sweston has joined #openstack-sprint22:21
*** jhesketh has joined #openstack-sprint22:25
dhellmannanteaya: instead of :: try offsetting that block under a directive like: .. code-block:: none22:26
dhellmannanteaya: http://sphinx-doc.org/markup/code.html?highlight=code22:28
jeblairclarkb: me too, wasn't sure if we wanted to leave them out for more reviews (and possible nit fixes) or just go ahead and clear them out22:31
anteayadhellmann: thanks I will try that22:31
anteayaclear them out22:31
anteayaplease22:31
dhellmannanteaya: I tested it locally and it took care of it. The :: turns on "auto-highlighting" which tries to guess what syntax you're using. The ".. code-block:: none" turns off highlighting.22:32
dhellmannok, now I'm really leaving my desk for the day22:33
jeblairdhellmann: oh, i thought you were back for another shift! ;)22:33
anteayadhellmann: thanks22:33
anteayaI'm going to eat my soup and then will try what doug suggests22:33
clarkbjeblair: Ithink we should clear out. It is easy enough to go back and fix tyops and grammar22:35
* clarkb gets into writing the feature branch section22:35
jeblairokay, i merged 4, i left 138177 and 138179 though22:47
anteayathank you22:52
clarkbhttps://review.openstack.org/138200 for feature branches22:53
clarkbanteaya: https://review.openstack.org/#/c/138195/1 spits out a sphinx warning and we fail on awarnings :/23:00
clarkbanteaya: not sure how we want ot handle that, probably wait until we have aplace we want to link from?23:01
anteayaawesome, thanks23:01
anteayahmmm, perhaps that is the problem I will put a link in the parent patch and see if that fixes things23:01
clarkbjeblair: anteaya: I have a question about reapproval on the sprint etherpad23:09
clarkbdoes anyone know what the answer to that is? I figure I can start knocking the unstarted ones out23:10
anteayaclarkb: sorry I don't know what you mean by reapproval23:11
clarkbanteaya: its on the etherpad23:11
* anteaya was context switching23:11
* anteaya reads the etherpad23:11
clarkbRe-approval23:11
anteayaline 5423:12
anteayaI have no clue23:12
anteayawe will have to wait for jeblair23:12
anteayaI could guess and might brainstorm it might have something to do with getting stuck approved patches back into the gate23:13
anteayabut I'm not certain that would be its own heading in the docs23:13
jeblairoh23:15
jeblairlet me see if i can recall what i was thinking :)23:15
jeblairclarkb: i think i was thinking about "reverify" or other stuff related to "this is approved but isn't merged"23:16
anteayaI guessed right23:17
anteayawould that need its own section in the manual?23:17
jeblairnot necessarily; could probably be covered in the previous section23:18
jeblairi think the _topic_ deserves attention though23:18
anteayaagreed23:19
anteayathe topic does23:19
clarkbso a generic "things went wrong now what" section?23:20
jeblairclarkb: i hesitate to say yes to that phrasing :)23:21
jeblairclarkb: but i think we need to mention that you can approve again to re-enqueue23:22
jeblairclarkb: or leave a recheck comment23:22
jeblairclarkb: this has some overlap with the section in the developer guide that talks about what happens when jenkins fails (but i don't think we should focus on that here)23:23
clarkbok let me take a stab at it23:23
clarkbanteaya: jeblair maybe something like https://review.openstack.org/13820423:31
jeblairclarkb: ya23:32
anteayaI like it but jenkins doesn't23:33
clarkbany idea why my addition of _failed-tests as a target didn't work?23:33
jeblairclarkb: is '-' allowed?23:34
clarkboh maybe not /me does local testing23:34
jeblairsphinx docs say it is23:35
jeblair".. _my-reference-label:" is their example23:35
jeblairclarkb: but they say to use it use: ref:`my-reference-label`23:35
clarkboh I wonder if what I used only works within one document23:36
jeblairyeah, there's a different syntax that only works in one doc, that might be it.  :ref: works cross-doc23:36
clarkbjeblair: that works23:37
clarkbnew patchset should work. builds locally23:38
anteayaclarkb: I'm going to try that for my link that didn't work23:40
anteayaare those backticks or single quotes?23:42
anteayabackticks23:42
clarkbyes backticks23:44
clarkbanteaya: do you need a better font :)23:44
clarkbI will admit to using droid which has the major flaw of making 0 and O look the same23:45
clarkbthere is a version of droid out there that fixes that23:45
anteayaperhaps I need a better font23:47
anteayaI am currently not having good luck getting my dependencies updated properly23:48
anteayadocument isn't included in any toctree23:48
anteayaI'm getting tired23:49
anteayaI'm thinking about tossing my hands in the air and coming back tomorrow23:50
anteayaI don't think I'm blocking anyone23:50
jeblairanteaya: you add the filename to index.rst23:50
jeblairanteaya: and if we don't want it to show up in the main TOC, there's a way to specify that when adding it to the toctree in index.rst23:51
jeblairanteaya: i think system-config has an example of the latter23:51
reedI would like to add slides/ as output for the manual but I'm not familiar with tox23:52
reeddoes anyone have a pointer to a cheatsheet?23:52
jeblairreed: you want tox to run a sphinx command to build a slide deck?23:53
reedjeblair, yes23:53
anteayajeblair: thanks, I will look at system-config's index.rst23:53
reedjeblair, basically add one build target to man and html we have now23:53
jeblairreed: look at tox.ini for the docs env; you can copy that and change the command it uses23:54
jeblairreed: could also add the command to the docs env so it runs both23:54
* reed checks23:54

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!