| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify User Update https://review.openstack.org/499284 | 00:04 |
|---|---|---|
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Add User to Group https://review.openstack.org/499345 | 00:06 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Check User in Group https://review.openstack.org/499357 | 00:06 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Remove User from Group https://review.openstack.org/499360 | 00:07 |
| *** gouthamr has joined #openstack-shade | 00:18 | |
| *** slaweq has joined #openstack-shade | 00:34 | |
| *** slaweq has quit IRC | 00:39 | |
| *** slaweq has joined #openstack-shade | 01:35 | |
| *** slaweq has quit IRC | 01:40 | |
| *** slaweq has joined #openstack-shade | 02:49 | |
| *** slaweq has quit IRC | 02:55 | |
| *** slaweq has joined #openstack-shade | 03:37 | |
| *** gkadam_ has joined #openstack-shade | 03:41 | |
| *** slaweq has quit IRC | 03:42 | |
| *** gouthamr has quit IRC | 03:53 | |
| *** slaweq has joined #openstack-shade | 04:38 | |
| *** slaweq has quit IRC | 04:43 | |
| *** slaweq has joined #openstack-shade | 05:58 | |
| *** slaweq has quit IRC | 06:12 | |
| *** slaweq has joined #openstack-shade | 07:01 | |
| *** slaweq has quit IRC | 07:06 | |
| *** slaweq has joined #openstack-shade | 07:13 | |
| *** ioggstream has joined #openstack-shade | 07:44 | |
| *** slaweq has quit IRC | 08:00 | |
| *** slaweq has joined #openstack-shade | 08:01 | |
| *** slaweq has quit IRC | 08:09 | |
| *** slaweq has joined #openstack-shade | 08:09 | |
| *** gkadam_ has quit IRC | 12:27 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack-infra/shade master: Updated from global requirements https://review.openstack.org/499983 | 12:34 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Fix typo in tox.ini https://review.openstack.org/500045 | 13:13 |
| *** gouthamr has joined #openstack-shade | 13:56 | |
| samueldmq | morning shade! | 14:17 |
| samueldmq | mordred: https://review.openstack.org/#/c/499284 needs a couple of extra eyes | 14:17 |
| samueldmq | I left a comment there with a question | 14:18 |
| mordred | samueldmq: ah - so - the ansible os_user module is explicitly passing domain_id all the time, even when it's None - so our valid_kwargs isn't quite good enough | 14:21 |
| mordred | :( | 14:21 |
| samueldmq | mordred: maybe I could improve valid_kwargs to drop none things? | 14:22 |
| samueldmq | or do we want to keep none if passed in explicitly? | 14:22 |
| mordred | samueldmq: well- that's just the thing- valid_kwargs is done to allow a kwarg to be passed as None and have that be meaningful | 14:22 |
| samueldmq | maybe fixing os_user module would be more appropriate then | 14:22 |
| samueldmq | and do not pass domain_id if it is none | 14:23 |
| mordred | I think the issue here is actually in the os_user module BUT that's useful as it shows us behavior from before that we'd be breaking | 14:23 |
| mordred | we can fix os_user, but another user might be using shade expecting the same behavior (whichis coming from keystoneclient dropping domain_id if it's None) | 14:23 |
| samueldmq | hmm from that point of view yes. I guess keystoneclient was the one disregarding none values | 14:23 |
| mordred | yah | 14:23 |
| samueldmq | ok I will keep the same behavior, and add a note | 14:23 |
| samueldmq | and yah, we take backwards compatibility seriously in shade | 14:24 |
| mordred | so I think for now let's just add in some removing of kwargs entries with None values in this method - or maybe ahelper function that takes a dict and strips None values? | 14:24 |
| mordred | samueldmq: yes - we do -it's super annoying sometimes :) | 14:24 |
| mordred | samueldmq: so - the important thign here actually ... | 14:24 |
| mordred | is that some of these values are things where someone might want to update a user to remove a setting ... | 14:25 |
| samueldmq | exactly and we dont know. we can't know for sure | 14:25 |
| mordred | like - email | 14:25 |
| samueldmq | let's just respect the behavior and continue with the same behavior so we dont break any one's apps | 14:25 |
| mordred | but some are things where changing it to none makes no sense | 14:25 |
| mordred | domain_id is one of those I think | 14:25 |
| samueldmq | ++ | 14:25 |
| samueldmq | ++ I will just drop domain_id and leave a note for now | 14:26 |
| mordred | yah - I thin it's just domain_id that'st the problem | 14:26 |
| samueldmq | exactly | 14:26 |
| mordred | and honestly, domain_id as an argument to this method is really only useful for lookingup the user in the first place | 14:26 |
| samueldmq | well, good thing that gate caught it | 14:27 |
| mordred | so you could potentially promote it to being a real keyword arg | 14:27 |
| mordred | since it really never needs to be in the kwargs we pass to patch | 14:27 |
| samueldmq | hmm and treat the rest of kwargs consistently | 14:27 |
| samueldmq | that works too | 14:27 |
| openstackgerrit | Merged openstack-infra/shade master: Updated from global requirements https://review.openstack.org/499983 | 14:29 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Remove errant print https://review.openstack.org/500090 | 14:53 |
| *** slaweq has quit IRC | 14:54 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Use new keystoneauth version discovery https://review.openstack.org/493582 | 14:59 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Use new keystoneauth version discovery https://review.openstack.org/493582 | 15:10 |
| Shrews | mordred: +3'd ^^ | 15:14 |
| openstackgerrit | Merged openstack-infra/shade master: Fix typo in tox.ini https://review.openstack.org/500045 | 15:33 |
| mordred | SamYaple: left you a nice long note on https://review.openstack.org/#/c/496992 - don't hate me :) | 15:43 |
| SamYaple | mordred: yea i dont really understand what you want | 15:46 |
| SamYaple | im trying to find an example | 15:47 |
| mordred | SamYaple: look in shade/_normalize.py ... hrm, maybe we just land this patch as is and move the identity normalization functions as a followup | 15:47 |
| SamYaple | your call. this patch is not critical to me at all. | 15:49 |
| mordred | SamYaple: k. I'm going to put up a quick followup patch - identity turns out to be weird here in a few ways, but we already have some semantics defined for project | 15:58 |
| *** thrash is now known as thrash|biab | 16:02 | |
| openstackgerrit | Julia Kreger proposed openstack-infra/shade master: De-clientify baremetal create/delete https://review.openstack.org/500119 | 16:14 |
| openstackgerrit | Julia Kreger proposed openstack-infra/shade master: De-client-ify baremetal machine port list https://review.openstack.org/500120 | 16:14 |
| openstackgerrit | Julia Kreger proposed openstack-infra/shade master: De-client-ify machine patch operations https://review.openstack.org/500121 | 16:14 |
| SamYaple | mordred: i guess thats whats confusing me because i dont know how role+domain_id relates to project | 16:39 |
| SamYaple | but really, that patch was entirely a "here is part of the api we missed, it might be useful" thing. | 16:40 |
| SamYaple | i dont personally use roles assigned to domains, but that would be a cool way to limit who gets what roles | 16:40 |
| SamYaple | only roles per domain, and no one can get a role outside of thier domain | 16:41 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify User Update https://review.openstack.org/499284 | 16:46 |
| mordred | SamYaple: yah- don't worry about it - I mostly just noticed that role hadn't been migrated to thenew normalization yet | 16:47 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Add User to Group https://review.openstack.org/499345 | 16:48 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Check User in Group https://review.openstack.org/499357 | 16:50 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Remove User from Group https://review.openstack.org/499360 | 16:54 |
| *** ioggstream has quit IRC | 17:14 | |
| openstackgerrit | Merged openstack-infra/shade master: Use new keystoneauth version discovery https://review.openstack.org/493582 | 17:40 |
| cmurphy | ooooh nice ^ | 17:41 |
| *** thrash|biab is now known as thrash | 18:25 | |
| mordred | cmurphy: \o/ | 18:27 |
| SamYaple | mordred: its ok. ill work on the role normalization thing, but dont let that hold up tagging was my point | 18:44 |
| mordred | SamYaple: oh - I'm not | 18:45 |
| mordred | SamYaple: and I've got a thing actually ... one sec | 18:45 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Allow domain_id for roles https://review.openstack.org/496992 | 18:49 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Move role normalization to normalize.py https://review.openstack.org/500170 | 18:49 |
| SamYaple | ++ | 18:53 |
| mordred | SamYaple: ^^ rebased your patch too, just because I needed to for local testing | 18:58 |
| SamYaple | not a problem | 19:03 |
| SamYaple | almost finished converting all the internal saltcode we have to using shade. without enabling any caching yet its ~2x faster | 19:08 |
| SamYaple | oh speaking of which. is the cache safe when multiple instances of shade is hitting it? | 19:09 |
| SamYaple | is there locking and what not | 19:09 |
| mordred | SamYaple: depends on the backend you configure it to use | 19:31 |
| mordred | SamYaple: also - there are (currently) 2 different caches - one that's using dogpile.cache and thatyou can configure to use a shared cache - but for list_servers, list_ports and list_floating_ips there is a built-in in-memory cache that is written to work properly with the batched/ratelimited operations the multi-threaded task manager from nodepool uses | 19:32 |
| mordred | SamYaple: once we're done with restification (almost done!) the plan is swing back and finish getting everything to use dogpile - the last time we tried that is failed spectaularly so it'll be a few days of debugging fun when we try again :) | 19:33 |
| *** gouthamr has quit IRC | 19:51 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Check User in Group https://review.openstack.org/499357 | 20:02 |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify Remove User from Group https://review.openstack.org/499360 | 20:02 |
| SamYaple | i see | 20:09 |
| SamYaple | i wonder if salt can use the same cloud object across several states | 20:09 |
| openstackgerrit | Monty Taylor proposed openstack/oaktree master: Add zuul v3 job to trigger readthedocs https://review.openstack.org/498905 | 20:13 |
| mordred | SamYaple: it's a good question. also - there is a file cache backend to dogpile too - I _think_ it's threadsafe - but I have not verified that in anger | 20:16 |
| SamYaple | mordred: there is a shared __context__ dict across all states in a single run, i can add oscloud and opcloud to that and reuse. which is nice | 20:17 |
| mordred | SamYaple: btw - there is also a new constructor parameter that we just landed ... or, rather,crappit, I thought it merged but it's got a merge conflict ... | 20:17 |
| mordred | SamYaple: woot! | 20:18 |
| SamYaple | yea we will see how this goes | 20:18 |
| mordred | SamYaple: in any case, this: https://review.openstack.org/#/c/494535/ | 20:18 |
| SamYaple | i may not need dogpile after this | 20:18 |
| mordred | SamYaple: you may want to experiment with that flag from salt too (we added it because of a bug reported against ansible that things were doing too much listing) | 20:18 |
| SamYaple | oh yea... i may have made that merge conflict | 20:18 |
| openstackgerrit | Merged openstack/os-service-types master: Updated from global requirements https://review.openstack.org/500014 | 20:19 |
| SamYaple | cool. ill see what i can do | 20:20 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Use direct calls to get_<resource>_by_id https://review.openstack.org/494535 | 20:21 |
| *** gouthamr has joined #openstack-shade | 20:28 | |
| *** slaweq has joined #openstack-shade | 20:52 | |
| *** slaweq has quit IRC | 21:00 | |
| *** gouthamr has quit IRC | 21:16 | |
| openstackgerrit | Julia Kreger proposed openstack-infra/shade master: De-client-ify baremetal node_set_provision_state https://review.openstack.org/499773 | 21:39 |
| openstackgerrit | Paul Belanger proposed openstack-infra/shade master: WIP: Add openstack-doc-build to shade https://review.openstack.org/500201 | 21:44 |
| *** slaweq has joined #openstack-shade | 21:59 | |
| *** slaweq has quit IRC | 22:00 | |
| openstackgerrit | Paul Belanger proposed openstack-infra/shade master: Add openstack-doc-build to shade https://review.openstack.org/500201 | 22:34 |
| *** gouthamr has joined #openstack-shade | 23:14 | |
| *** olaph has quit IRC | 23:36 | |
| *** olaph has joined #openstack-shade | 23:37 | |
| *** thrash is now known as thrash|g0ne | 23:57 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!