| *** rods has quit IRC | 00:08 | |
| *** squid has quit IRC | 01:29 | |
| *** squid has joined #openstack-shade | 01:33 | |
| *** gkadam_ has joined #openstack-shade | 03:40 | |
| *** gouthamr has quit IRC | 03:49 | |
| *** slaweq has joined #openstack-shade | 05:31 | |
| *** slaweq has quit IRC | 05:35 | |
| *** slaweq has joined #openstack-shade | 05:41 | |
| *** slaweq has quit IRC | 05:42 | |
| *** slaweq has joined #openstack-shade | 06:26 | |
| *** slaweq has quit IRC | 06:28 | |
| *** slaweq has joined #openstack-shade | 06:28 | |
| *** yfried has joined #openstack-shade | 06:37 | |
| *** openstackgerrit has quit IRC | 08:17 | |
| *** umbSublime_ has joined #openstack-shade | 08:30 | |
| *** umbSublime has quit IRC | 08:33 | |
| *** yfried has quit IRC | 08:45 | |
| *** umbSublime_ has quit IRC | 09:41 | |
| *** umbSublime_ has joined #openstack-shade | 09:41 | |
| *** umbSublime_ is now known as umbSublime | 09:42 | |
| *** thrash|g0ne is now known as thrash | 11:41 | |
| *** openstackgerrit has joined #openstack-shade | 12:32 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Remove keystoneclient and ironicclient as direct depends https://review.openstack.org/492684 | 12:32 |
|---|---|---|
| *** gkadam_ has quit IRC | 12:40 | |
| *** gouthamr has joined #openstack-shade | 13:17 | |
| *** rcarrillocruz has quit IRC | 13:21 | |
| *** rcarrillocruz has joined #openstack-shade | 13:24 | |
| *** slaweq has quit IRC | 13:29 | |
| *** slaweq has joined #openstack-shade | 13:32 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add tox_install.sh to deal with upper-constraints https://review.openstack.org/499602 | 13:41 |
| *** slaweq has quit IRC | 13:52 | |
| *** slaweq has joined #openstack-shade | 13:53 | |
| *** slaweq has quit IRC | 13:57 | |
| *** slaweq has joined #openstack-shade | 13:59 | |
| *** ioggstream has joined #openstack-shade | 14:22 | |
| mordred | Shrews: switching to here real quick ... I'm mildly tempted to change our minds about the openstack constructor patch for the ansible modules and land it for 2.4 ... it'll let us also land a change to consume https://review.openstack.org/#/c/494535/ by default | 14:26 |
| Shrews | mordred: if it's not too late, no objection here | 14:27 |
| *** slaweq has quit IRC | 14:32 | |
| *** slaweq has joined #openstack-shade | 14:33 | |
| *** slaweq_ has joined #openstack-shade | 14:43 | |
| *** slaweq_ has quit IRC | 14:47 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add tox_install.sh to deal with upper-constraints https://review.openstack.org/499602 | 14:48 |
| mordred | Shrews: ^^ this ... so | 14:49 |
| mordred | Shrews: shade is now part of openstack/requirements because there are openstack projects (tripleo is the one that added it I tihnk) that are using the ansible modules for their things and thus needed to be able to depend on shade | 14:50 |
| mordred | that means it's in upper-constraints which means we need that | 14:50 |
| Shrews | mordred: +A | 14:53 |
| *** thrash is now known as thrash|biab | 15:16 | |
| *** rods has joined #openstack-shade | 15:31 | |
| *** slaweq has quit IRC | 15:36 | |
| *** slaweq has joined #openstack-shade | 15:37 | |
| TheJulia | out of curiosity, is a) anyone working on restifying ironic stuffs, and b) any good examples or docs to look at regarding the effort? | 15:39 |
| *** slaweq has quit IRC | 15:41 | |
| *** thrash|biab is now known as thrash | 15:50 | |
| *** slaweq has joined #openstack-shade | 16:10 | |
| *** slaweq has quit IRC | 16:14 | |
| *** rods has quit IRC | 16:16 | |
| *** rods has joined #openstack-shade | 16:54 | |
| *** rods has quit IRC | 17:00 | |
| TheJulia | I think I've got it figured out... | 17:44 |
| mordred | TheJulia: ola! a) not yet - b) yay! | 17:44 |
| mordred | TheJulia: tl;dr of process has been "convert unittests to request_mock but not the code itself" then "convert the code" | 17:45 |
| mordred | TheJulia: largely so that we can use the unittest conversion change to verify that the old code we know worked has valid requests_mock entries now - then when we do the code conversion we should be able to do it without making test changes | 17:45 |
| TheJulia | kind of makes sense | 17:46 |
| mordred | it doesn't ALWAYS work out that way - occasionally we find that the clien tlib makes an extra call somewhere or something - but those are easy to see at review time | 17:46 |
| TheJulia | I've been trying to change node_set_provision_state, but seems this is the first case of microverssion usage with this new way \o/ | 17:46 |
| mordred | yay! | 17:46 |
| mordred | well - I've got a patch up that we should be able to land today that should add all the good version discovery stuff from the new ksa | 17:47 |
| TheJulia | oddly enough, I couldn't even get unit tests to fire due to constraint issues :( | 17:47 |
| mordred | yah - there's a patch up for that too - one sec | 17:47 |
| mordred | (shade was just added to global-requirements) | 17:47 |
| TheJulia | I saw the chatter earlier | 17:48 |
| mordred | oh - goodie - something is slightly different with functional tests ... | 17:49 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add tox_install.sh to deal with upper-constraints https://review.openstack.org/499602 | 17:51 |
| mordred | Shrews, TheJulia: ^^ typo in that from originally - the -c was not a thing | 17:52 |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Use new keystoneauth version discovery https://review.openstack.org/493582 | 17:53 |
| mordred | and that's the use-new-ksa patch, now with a depends-on on the tox.ini patch | 17:53 |
| *** ioggstream has quit IRC | 17:57 | |
| TheJulia | wow, api returns a 404, shade vomits .get on a unicode object failure | 18:00 |
| TheJulia | wow, and it works | 18:08 |
| mordred | TheJulia: well, .get on unicode object failure on 404 seems less than ideal | 18:21 |
| mordred | TheJulia: it's probably working accidentally because the 404 error is an error and so is the unicode object failure so the exception handler is hapily ignoring the real thing | 18:21 |
| TheJulia | I have a sneaking suspicion that the session code didn't like ironic's 404 reply, but that is a context switch my brain doesn't need at the moment | 18:22 |
| TheJulia | mordred: it worked once I fixed the uri path. | 18:23 |
| mordred | TheJulia: \o/ | 18:23 |
| mordred | TheJulia: well- this: https://github.com/openstack-infra/shade/blob/master/shade/exc.py#L130-L137 | 18:23 |
| mordred | TheJulia: is probably the reason you got the unicode object failure on the 404 instead of, you know, a notfound exception | 18:23 |
| TheJulia | yup, that exactly | 18:24 |
| *** slaweq has joined #openstack-shade | 19:16 | |
| *** slaweq has quit IRC | 19:16 | |
| *** slaweq has joined #openstack-shade | 19:16 | |
| *** slaweq_ has joined #openstack-shade | 19:28 | |
| *** slaweq has quit IRC | 19:28 | |
| *** slaweq_ has quit IRC | 19:47 | |
| *** slaweq has joined #openstack-shade | 19:48 | |
| *** olaph1 has joined #openstack-shade | 19:57 | |
| *** olaph has quit IRC | 19:57 | |
| *** slaweq_ has joined #openstack-shade | 20:00 | |
| *** slaweq has quit IRC | 20:02 | |
| *** olaph has joined #openstack-shade | 20:05 | |
| *** olaph1 has quit IRC | 20:05 | |
| openstackgerrit | Julia Kreger proposed openstack-infra/shade master: De-client-ify baremetal node_set_provision_state https://review.openstack.org/499773 | 20:06 |
| openstackgerrit | Julia Kreger proposed openstack-infra/shade master: de-client-ify baremetal get_machine https://review.openstack.org/499774 | 20:06 |
| openstackgerrit | Julia Kreger proposed openstack-infra/shade master: Catch attrbute error for other APIs https://review.openstack.org/499775 | 20:06 |
| TheJulia | mordred: ^^^ I guess consider it all wip since I can't run unit tests presently. On a plus side, bifrost works \o/ | 20:08 |
| TheJulia | I didn't test the catch, I just figured I'd toss it up anyway | 20:08 |
| mordred | TheJulia: yay bifrost! | 20:09 |
| mordred | TheJulia: that's the thing that's the most important :) | 20:09 |
| TheJulia | I'm super thrilled, since now I'll be able to add features that require new microversions \o/ | 20:13 |
| TheJulia | without having to update logic all over the place | 20:13 |
| *** slaweq_ has quit IRC | 20:30 | |
| *** slaweq has joined #openstack-shade | 20:39 | |
| *** slaweq has quit IRC | 20:40 | |
| *** slaweq has joined #openstack-shade | 20:41 | |
| openstackgerrit | Monty Taylor proposed openstack-infra/shade master: Add tox_install.sh to deal with upper-constraints https://review.openstack.org/499602 | 20:45 |
| mordred | TheJulia: indeed! although, and I'm sure you know this already, but as we add microversion support shade users should by and large never know about microversions | 20:47 |
| mordred | TheJulia: that's a theory, and we haven't done anything with them yet - so I'm sure we'll learn things | 20:47 |
| mordred | but if we achieve that, I believe we will have achieved perfection in life | 20:47 |
| TheJulia | Yeah, I totally agree. If it wasn't for the desire that people had to delete things, it would actually be less of an issue. | 20:51 |
| TheJulia | Didn't we talk at one point about identifying/storing the versions if we could figure it out? | 20:51 |
| *** olaph1 has joined #openstack-shade | 21:14 | |
| SamYaple | mordred: do you have anything you need in before we tag? if so can I help with it? i need a new tag whenever possible to pull in shade to our salt code | 21:16 |
| *** olaph has quit IRC | 21:16 | |
| mordred | SamYaple: well - right now I'm waiting on the gate to unbreak itself | 21:37 |
| mordred | SamYaple: (which is related to shade being in upper-constraints now so we had to add a script to the tree to handle that) | 21:38 |
| SamYaple | WFM | 21:38 |
| SamYaple | yea i saw that | 21:38 |
| mordred | SamYaple: after that is unbroken I want to land the use-new-ksa patch, then I think we're in good shape to tag | 21:38 |
| SamYaple | then i remembered that Kolla doesnt use upper-constraints for the shade container | 21:38 |
| SamYaple | cool | 21:39 |
| *** gouthamr has quit IRC | 22:08 | |
| *** slaweq has quit IRC | 22:32 | |
| *** slaweq has joined #openstack-shade | 22:49 | |
| *** slaweq has quit IRC | 22:54 | |
| *** olaph has joined #openstack-shade | 23:05 | |
| *** olaph1 has quit IRC | 23:05 | |
| openstackgerrit | Merged openstack-infra/shade master: Add tox_install.sh to deal with upper-constraints https://review.openstack.org/499602 | 23:28 |
| *** slaweq has joined #openstack-shade | 23:33 | |
| *** slaweq has quit IRC | 23:38 | |
| openstackgerrit | Samuel de Medeiros Queiroz proposed openstack-infra/shade master: De-client-ify User Update https://review.openstack.org/499284 | 23:49 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!