Thursday, 2020-11-19

*** tosky has quit IRC00:14
*** LinPeiWen46 has joined #openstack-sdks00:36
*** ricolin has joined #openstack-sdks00:37
*** iokiwi has joined #openstack-sdks01:28
* iokiwi waves01:29
iokiwiHi I am working on a fix for this,!/story/2007672. According to the docs, the default behavior for `openstack image save` should go to stdout, but recent changes / current implimentation makes it go to memory.01:31
iokiwiIs it still desireable that output go to stdout? Should I restore this as the default output?01:52
*** enriquetaso has quit IRC02:32
openstackgerritMerged openstack/python-openstackclient master: Add "fields" parameter to ListPort query
*** evrardjp has quit IRC05:33
*** evrardjp has joined #openstack-sdks05:33
frickleriokiwi: it seems there are actually two issues here, both related to the switch from glanceclient to sdk:06:35
fricklera) the default output to stdout is broken06:36
fricklerb) osc now tries to buffer the complete image in memory before saving it to a file or stdout, leading to an OOM when the image size is larger than available memory06:37
fricklerwaiting for gtema to be back online for further discussion06:37
fricklerfor me, while a) certainly is a regression that should be fixed, b) is the more severe issue06:38
*** slaweq has joined #openstack-sdks07:00
openstackgerritSimon Merrick proposed openstack/python-openstackclient master: stop image downloads to memory
*** gtema has joined #openstack-sdks07:23
iokiwifrickler thanks my patch addresses both. Certainly agree that b) is the bigger issue (especially when downloading a 100gb image)07:32
* iokiwi is Simon Merrick07:32
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Complete compute.hypervisor functions
frickleriokiwi: thanks, that looks much simpler than I had expected. will test later today. it might be good to add a releasenote, though.07:36
gtemathat is definitely needed07:37
iokiwifickler sure I'll add one now07:37
gtemathings go easy when you use SDK ;-)07:37
iokiwiBased on the docs, I am not sure sdk will do md5 checksum when stream=True07:38
iokiwiDo you think this will be a problem?07:38
gtemawell, the checksum validation is anyway doomed, since many clouds do not do this properly07:38
iokiwiI think the sdk just wont/can't try to do md5 sum so to be more specific, is the md5 checksum important enough to us to implement it? Based on your comment above, maybe not.07:40
gtemait is important that this possibility remains in SDK as is, since there are other users (except OSC) depending on it07:41
gtemawell, looking to the code I don't see it would change the behaviour really.07:43
gtemait was initially designed to be either output or stream, not both together07:43
*** ralonsoh has joined #openstack-sdks07:43
gtemaso as long as you download image into file I do not think there is effect of this change07:48
gtema(since my cloud disabled image download I can't really verify anything)07:48
fricklergtema: saving a 50g image to a file gives OOM for me with latest, works fine with 5.1.0. setting test up with the patch now07:50
fricklerthe patch fixes that and also the stdout issue. does get some not so nice output when pipe fails, but that might be fixed in a followup
*** tremble has quit IRC07:55
openstackgerritSimon Merrick proposed openstack/python-openstackclient master: stop image downloads to memory
*** nikparasyr has joined #openstack-sdks07:59
gtemathat's weird. I can't understand why it should change the behavior07:59
openstackgerritCarlos Goncalves proposed openstack/openstacksdk master: Add ALPN support to load balancer pools
gtemaaah, overseen where it goes also to08:00
fricklergtema: see the sdk docs, default downloads the complete image to memory before writing it to the file08:01
gtemaI know, I was reworking this whole stuff heavily08:02
gtemajust forgot where which param goes into - it's a spaghetti08:02
*** rpittau|afk is now known as rpittau08:03
*** gtema has quit IRC08:05
*** gtema has joined #openstack-sdks08:06
*** tosky has joined #openstack-sdks08:44
*** tremble has joined #openstack-sdks09:05
*** jpich has joined #openstack-sdks09:08
*** holser has joined #openstack-sdks09:33
*** ricolin has quit IRC09:38
*** dtantsur|afk is now known as dtantsur09:41
*** frenzy_friday has joined #openstack-sdks09:44
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Complete compute.hypervisor functions
openstackgerritSagi Shnaidman proposed openstack/ansible-collections-openstack master: Migrating routers_info from AnsibleModule to OpenStackModule
openstackgerritMark Chappell proposed openstack/openstacksdk master: Add support for Block Storage (v3) VolumeType Encyption resources
*** tremble has quit IRC11:10
*** tkajinam has quit IRC11:29
*** tkajinam has joined #openstack-sdks11:30
*** enriquetaso has joined #openstack-sdks12:01
*** camelCaser has quit IRC12:15
*** ricolin has joined #openstack-sdks12:18
*** holser has quit IRC12:29
*** rpittau is now known as rpittau|brb13:16
*** holser has joined #openstack-sdks13:35
openstackgerritMerged openstack/ansible-collections-openstack master: Migrating routers_info from AnsibleModule to OpenStackModule
gtemahow was that command to start meeting?14:01
gtema#startmeeting SDK/OSC14:02
openstackMeeting started Thu Nov 19 14:02:17 2020 UTC and is due to finish in 60 minutes.  The chair is gtema. Information about MeetBot at
openstackUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:02
*** openstack changes topic to " (Meeting topic: SDK/OSC)"14:02
openstackThe meeting name has been set to 'sdk_osc'14:02
gtemaping gouthamr14:03
gtemado we want to use meetpad for voice meeting, or due to the time differences better in text ;-)14:03
gtemano opinions?14:04
gtemaagenda for the meeting is under
amotokiI have no strong preference on it, but most openstack projects use irc meetings and text meeting would be preferred in general.14:05
gtemano problem14:05
diablo_rojoPlease just text lol14:06
gtemaoki, was thinking14:06
gtema#topic Add Resolution of TC stance on the OpenStackClient Patch14:06
*** openstack changes topic to "Add Resolution of TC stance on the OpenStackClient Patch (Meeting topic: SDK/OSC)"14:06
diablo_rojoThis way we have logs and don't need to take notes.14:06
gtemaI left my +1 (yet again)14:06
gtemaI am (not actually really wondering) - even this way there is some resistance from the community14:07
gtemawhat is the plan of TC, to push on it or still try to get agreement from everyone14:08
diablo_rojoWe are trying to get that merged as a way forward.14:08
diablo_rojoI do think its close, people just want more detail than we originally wanted to provide.14:08
gtemathis is already expressed very "weak". Is there a plan to really have a harder control?14:09
* gouthamr takes a note on reviewing ^14:09
gtemaok, moving next, since there is actually no further action points14:10
gtema#topic Gerrit Breach Audit14:10
*** openstack changes topic to "Gerrit Breach Audit (Meeting topic: SDK/OSC)"14:10
gtemaI did audit immediately when it was announced, but most likely forgot to send info about that14:11
diablo_rojothe resolution is more of a stepping stone towards the end goal. A diplomatic way of starting to make progress.14:11
gtemaI have updated the linked etherpad with the info as well14:11
diablo_rojoOh cool, so all good then?14:11
diablo_rojoThanks gtema!14:12
stephenfingtema: You mean force patches for OSC? Not beyond the TC proposal, no. We need to rely on soft power more than hard power. It's not possible to force things through without the approval of the team, so we need to work to win those people over14:12
amotokigtema: did you audit all repos under openstacksdk?14:12
gtemaI reviewed both from gerrit side and from the attached commits. But due to the amount of projects under the SDK team ;-) I might have missed something14:12
gtemasdk, python-openstackclient, openstackclient, os-service-types14:12
gtemacliff, osc-lib14:13
stephenfinfwiw, I think only Glance have pushed back. Everyone else is onboard, though not everyone has allocated resources (my nova is purely spare time stuff)14:13
amotokigtema: lists our repos14:13
gtemaoh yes. shade as well14:13
stephenfin*that's effectively EOL though14:14
gtemawill again ensure requestsexceptions and js-openstack-lib are covered14:14
gtematja - sounds so "german"14:14
gtemadon't tell me you are located in germany :)14:14
gtema#topic Manila SDK work in Wallaby14:15
*** openstack changes topic to "Manila SDK work in Wallaby (Meeting topic: SDK/OSC)"14:15
gtemaas mentioned - I think we generally need to start merging Manila bits into SDK14:16
gouthamrhey! this was me. i had an update to share, and a couple of questions14:16
gtemaI know from own experience it is extremely hard to both add new services (complete)14:16
gtemaand also reviewing is terrible14:16
gtemathus suggestion - get small things with resource by resource14:16
gouthamri agree, i saw your comment on14:17
gouthamr#link (WIP: Add support for shared file systems (manila))14:17
gouthamrwe'll break the patch down into individual resources14:17
gtemaI would suggest you have a look yourself whether what is already there is working or not14:17
gtemaif yes - remove WIP status and let the reviews start14:18
stephenfingouthamr: Are you planning to work on OSC integration in parallel?14:18
gouthamryeah, the WIP never fell off of it, because the original author has moved on; and we're trying to pick up the work this cycle14:18
gtemahe - interesting question, since manila has own client14:18
amotokigtema: will the OSC integration be implemented as a plugin, right?14:19
gtemaafaik it is already a plugin14:19
amotokino gtema. i would like to mention gouthamr14:19
gouthamrstephenfin: yes, the OSC work is ongoing - we've about 50% parity with the python-manilaclient14:19
gouthamrand yes, the native client houses the plugin ^14:19
amotokithanks. it is nice14:19
stephenfingouthamr: okay, good to hear :)14:20
gtemaI guess once the SDK part lands they can start consuming it to hopefully generally reduce efforts14:20
gouthamrgreat, my update is that we're working with a few new university contributors to submit the openstacksdk bits14:21
gtemaI see manila is really evolving on the API part14:21
gouthamrhopefully, i'll have them here in the next meeting :)14:21
gtemaare there lots of changes planned for this cycle?14:22
gouthamrgtema: yes, we do hope to finish the openstacksdk by X, so much of the user facing resources you see in are planned for wallaby14:22
gtemaI mean on manila itself14:23
gtemawhen the change was initially started I know it was pretty close to cover all APIs14:23
gouthamri don't anticipate changes in manila, wdym?14:23
gtemabut since then lots of new APIs were added14:23
gtemaokay, I thought you might be knowing14:24
gouthamrthat'll not stop happening though :)14:24
gtemaokay then14:24
gtemamoving on14:24
amotokido we need functional test coverage in SDK in addition to unit test? it can be the next step though.14:24
gtemaI think better to add those as well, but no objections of doing this in a follow-up14:25
stephenfinif we're doing functional tests, we need to think about how we do so14:25
gtematests are taking sometimes 70% of the change itself14:25
stephenfinthe functional tests in OSC are _very_ racy14:25
gtemathat's absolutely correct stephenfin14:25
gtemamostly those racy tests are coming from nova ;-)14:26
stephenfinunfortunately so :(14:26
gtemafor sure we would need to start using more projects not to really corrupt things14:26
stephenfinwork for the future though, once we've more gaps closed14:27
gouthamri had a couple of other questions14:27
gouthamrand gtema answered one of them in the etherpad14:27
gtemathe remaining is about tracking, right?14:28
gouthamrdoes openstacksdk work need a spec? we intend to write one to plan our work14:28
gtemawe do not use specs currenlty14:28
gtemaI do not know whether those were ever used in SDK/OSC14:28
amotokiI don't think we need a spec. what we need is just to be aware of the effort as impls would be straight-forward.14:29
amotokithis kind of meetings would really help it :)14:29
gtemasomething like spec might be required for the discussion we had with stephenfin yesterday14:30
gouthamrack - thanks; i'll not bother you with it then; the spec was more for project planning and some designing - if we write one, we'll keep it in manila-specs14:30
gtemaabout what is better in OSC14:30
gtema'openstack aggregate cache image __aggregate__ __image1__ __image2__ ...'14:30
gouthamr(we did write a spec for our osc work too - we can argue endlessly about subcommand naming) :D14:30
gtemaor 'openstack aggregate cache image __aggregate__ --image __image1__ --image __image2__ ...'14:31
gouthamr(^ and things like that)14:31
gtemathere are 2 types currently used in different areas14:31
gtemaand we might need to agree what is the standard14:31
stephenfinyes, this is a place where we're missing a BDFL (Benevolent Dictator For Life) to settle things for us14:31
stephenfinIn the absence of dtroyer, we should probably put together a style guide?14:32
gtemahehe, I am not the one - tell you right now14:32
amotokiit is a topic on how our CLI command should be composed.  i think it can be discussed as a document change proposal in OSC14:32
stephenfinNonsense. All hail, gtema14:32
stephenfinamotoki++ yeah, I think this would be a great addition to the docs14:32
gtemaamotoki - right. We should start perhaps one14:32
* stephenfin can do put together a strawman proposal14:33
stephenfins/do //14:33
stephenfinand then we can debate it on Gerrit14:33
diablo_rojoI look forward to reviewing :)14:33
gtema#action - start a style guide for osc14:33
gouthamr^ this one already exists, though14:34
gtemaI new I was seeing this once, but completely forgot14:34
gouthamrand specifically:
gtemagreat, might need some extension14:35
amotokithey are good starts. If there are something not covered, we can cover more cases.14:36
stephenfinyes, good call. I didn't know that existed14:36
gouthamrsometimes patterns there don't make sense in all situations; an optional parameter is really required:
gouthamr"required options" :D14:36
stephenfinbit on an oxymoron, yes /o\14:37
gtemaokay, moving next14:37
gtema#topic Status OSC to use SDK for nova part14:37
*** openstack changes topic to "Status OSC to use SDK for nova part (Meeting topic: SDK/OSC)"14:37
gtemaI think we are progressing with stephenfin quite good on that14:38
gtemaof course there is still lot to cover14:38
gtemaI am explicitly afraid of starting changing 'server' operations - that would be a challenge14:39
gtemastephenfin, do you know whether this cycle we get something new from nova?14:39
*** yolanda has quit IRC14:40
stephenfinit shouldn't be _too_ bad - most server actions are implemented by POSTing a simply JSON body to the server actions API14:40
stephenfingtema: There were no API changes in Victoria. There are only minor changes (to the os-hypervisors API) planned for Wallaby so far14:40
gtemayes, it is always _easy_, until you start working on it14:40
stephenfinTrue :)14:40
gtemaoh, changes in hypervisor?14:40
gtemajust working on switching it14:40
stephenfinYes, but I'm doing that so I'll handle the SDK changes when I do it14:41
gtemawith few cool things: until 2.53 you use 1 API to search, after - another14:41
stephenfinoh, there's also a spec proposed to remove the final references to 'tenant_id' from the API, in favour of 'project_id'. It's not approved yet but it will be I suspect14:41
gtemaand then
stephenfinyeah, there's been a lot of that /o\14:42
gtemaI guess tenant_id/project_id is not a big deal at all14:42
gtemawrt this mentioned renaming I am currently thinking to return DictColumn instead of this renaming14:42
gtemaI do not think it is really useful to do this renaming, especially that it requires hacking14:43
gtemawhat do you think?14:43
gtemaI agree this is a "breaking" change14:43
gtemabut we anyway plan to bump a major release after this rework is done14:44
stephenfinno issues from me14:44
gtemaokay, great14:44
stephenfinso long as we signal it with a major version bump, yes14:44
gtemaI hope OSC part will arrive today14:44
amotokifrom POV of consumers, it would be nice if both of project_id and tenant_id can be used transparently.14:44
gtemaI guess since very long time those are everywhere translated to project_id14:45
amotokiI am not sure what part is discussed, nova API interaction or SDK abstraction?14:45
gtemawell - more about switching OSC to use SDK for nova part14:45
gtemaon the other hand stephenfin has also some UX improvents in head while we touch those14:46
gtemastephenfin - do you have ideas in which order we should touch remaining things?14:47
gtemaI was thinking to leave server to be last14:47
gtemasince it is huge14:47
gtemabut might be better other way around14:47
stephenfinNo ideas, no. Whatever suits, really14:47
stephenfinI'm planning to continue closing gaps with OSC and novaclient14:47
gtemaokay. For server I will be definitely create smaller patches switching individual commands of the server or server action14:48
gtemasince otherwise we will immediately get into some sort of long lock14:48
stephenfinMakes sense14:49
stephenfinI'll keep using the novaclient library to implement the CLIs until the necessary SDK bits are there to switch over14:49
stephenfinbecause I don't yet understand SDK well enough /o\14:49
gtemaI am not sure what is really better - do switch first and extend, or first extend and then switch to SDK14:50
gtemaSDK is a voodoo thanks to mordred ;-)14:50
stephenfinextend and switch means we have a known baseline14:51
gtemathere are just few persons around the world probably who completely understand SDK14:51
*** rpittau|brb is now known as rpittau14:51
gtemaagree on that, but14:51
stephenfini.e. I know novaclient works. I don't necessarily know new OSC changes works14:51
stephenfinalso, I'm adding missing options more so than missing commands14:51
gtemabefore the switch I go to SDK and verify it can do everything what API provides14:51
gtemaso SDK should be supporting everything for OSC to be able to implement missing params14:52
gtemadiablo_rojo - do you have students already you were mentioning in PTG?14:53
gtemathe ones who can support this work14:53
diablo_rojoStill working on the one from OSU.14:54
diablo_rojoBut the BU students are already working with gouthamr14:54
diablo_rojoI just got the email calling for projects for NDSU students in the spring so I will start working on putting that together tomorrow probably.14:55
gtemaI think we would be in time with the switch for nova command toward SDK this cycle - we are maybe 40% through currently14:55
gtemamaybe we can also start doing that for cinder as well, since I have a feeling those are now also a bit unhappy with OSC functionality14:56
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: Make use of comparable 'FormattableColumn' subclasses
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'server * -f yaml' output
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'usage * -f yaml' output
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'server group * -f yaml' output
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: compute: Fix 'hypervisor show -f yaml' output
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: compute: Add 'server group create --rule' option
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: compute: Add 'server show --topology' option
openstackgerritStephen Finucane proposed openstack/python-openstackclient master: trivial: Use plural for appended parameters
gtemacome on stephenfin - you want you work to be logged in the meeting minutes ;-)?14:56
diablo_rojogtema, stephenfin if you want me to make the NDSU proposal geared toward Nova work I can do that, but I will need your help with the mentoring :)14:56
stephenfingtema: Gerrit reviews wait for no meeting :)14:57
gtemaoh yes, mentoring14:57
amotokihehe. it might be a good trick to raise your reviews :)14:57
gtemaI guess in next couple of month this might be hard with the time for real mentoring14:58
stephenfindiablo_rojo: That's interesting and maybe possible, but I'd need to run it by folks internally first14:58
gtemano problem explaining/onboarding, but not really deeper mentoring14:58
gtemaokay, let's see how it evolves14:59
diablo_rojostephenfin, I think I have till the 30th to put together the project proposal, but I can get an extension if need be (I have in the past).14:59
stephenfinokay, I'll run it by people and see what they think. Should have an answer by EOW15:00
diablo_rojoIn the past is been 3-4 students for a semester and I usually met with them once a week for an hour.15:00
diablo_rojoPerfect :)15:00
gtemaif we get students we can actually also run in parallel work for cinder part, and not really nova15:01
gtemathen we have 200% output in the cycle15:01
stephenfinSounds good15:02
stephenfingtema: I think we're at time?15:02
diablo_rojoGood meeting :)15:02
gtemayes, right15:02
diablo_rojoOver by a couple min.15:02
gtemasorry, long thinking15:02
diablo_rojogtema, no worries :)15:02
diablo_rojoThanks for hosting!15:02
gtemaany questions unanswered?15:02
*** openstack changes topic to "Bug tracker for SDK and OSC is now at"15:03
openstackMeeting ended Thu Nov 19 15:03:09 2020 UTC.  Information about MeetBot at . (v 0.1.4)15:03
openstackMinutes (text):
amotokithanks all. it is really a nice time to sync our efforts :)15:03
gtemathanks everybody for joining15:03
gtemahave a nice day/evening/night or whatever else you have now15:04
*** tosky has quit IRC15:18
*** tosky has joined #openstack-sdks15:22
*** tosky has quit IRC15:26
*** Hybrid512 has joined #openstack-sdks15:40
dtantsurgtema: do we have a calendar file for this meeting. I think I've just learned about it :)15:46
*** tosky has joined #openstack-sdks15:50
gtemauhm, it's every 3rd thursday of the month15:53
gtemaI don't know whether there is some export15:53
dtantsuris it an official meeting?15:53
dtantsuraha, JFYI this is the information with an ICS file:
gtemawow, that's a great find15:55
gtemauhm, I should have used different meeting name upon start15:56
*** evrardjp has quit IRC16:17
*** nikparasyr has left #openstack-sdks16:32
*** mgariepy has quit IRC16:34
*** mgariepy has joined #openstack-sdks16:36
*** rpittau is now known as rpittau|afk16:52
*** bverschueren has quit IRC17:06
*** bverschueren has joined #openstack-sdks17:08
openstackgerritArtem Goncharov proposed openstack/openstacksdk master: Complete compute.hypervisor functions
*** bverschueren has quit IRC17:18
*** bverschueren has joined #openstack-sdks17:18
openstackgerritArtem Goncharov proposed openstack/python-openstackclient master: Switch hypervisor operations to SDK
openstackgerritArtem Goncharov proposed openstack/python-openstackclient master: Switch hypervisor operations to SDK
*** ralonsoh_ has joined #openstack-sdks17:27
*** gtema has quit IRC17:27
*** gtema has joined #openstack-sdks17:28
*** ralonsoh has quit IRC17:28
*** jpich has quit IRC17:28
*** gtema has quit IRC17:28
*** gtema has joined #openstack-sdks17:29
*** gtema has quit IRC17:54
*** gtema has joined #openstack-sdks17:55
*** gtema has quit IRC17:59
*** dtantsur is now known as dtantsur|afk18:23
*** ralonsoh_ has quit IRC18:53
*** gtema has joined #openstack-sdks19:11
*** gtema has quit IRC19:24
*** gtema has joined #openstack-sdks19:29
*** Hybrid512 has quit IRC19:53
*** gtema has quit IRC20:04

Generated by 2.17.2 by Marius Gedminas - find it at!