Tuesday, 2019-09-24

*** ricolin has joined #openstack-sdks02:48
*** black_ant has quit IRC03:50
*** gtema has joined #openstack-sdks04:40
*** Luzi has joined #openstack-sdks05:13
*** slaweq has joined #openstack-sdks06:08
*** yolanda has quit IRC06:34
*** e0ne has joined #openstack-sdks07:04
*** gtema has quit IRC07:04
*** e0ne has quit IRC07:09
*** Luzi has quit IRC07:18
*** tobiash has quit IRC07:27
*** tobiash has joined #openstack-sdks07:31
*** ralonsoh has joined #openstack-sdks07:34
*** jpich has joined #openstack-sdks08:01
*** gtema has joined #openstack-sdks08:06
*** enriquetaso has joined #openstack-sdks08:12
*** enriquetaso has quit IRC08:19
*** enriquetaso has joined #openstack-sdks08:19
*** enriquetaso has quit IRC08:30
*** jpena|off is now known as jpena08:30
*** enriquetaso has joined #openstack-sdks08:34
*** black_ant has joined #openstack-sdks08:36
*** mtreinish has quit IRC08:43
*** mtreinish has joined #openstack-sdks08:44
*** stephenfin has quit IRC08:44
*** frickler has quit IRC08:45
*** stephenfin has joined #openstack-sdks08:45
*** frickler has joined #openstack-sdks08:46
*** ricolin_ has joined #openstack-sdks09:05
*** ricolin has quit IRC09:08
openstackgerritVishakha Agarwal proposed openstack/keystoneauth master: Generate pdf documentation  https://review.opendev.org/68227209:16
*** ricolin_ is now known as ricolin09:23
*** cdent has joined #openstack-sdks09:37
*** ttsiouts has joined #openstack-sdks09:39
*** enriquetaso has quit IRC09:40
*** enriquetaso has joined #openstack-sdks09:48
*** e0ne has joined #openstack-sdks09:54
*** e0ne has quit IRC09:55
*** e0ne has joined #openstack-sdks09:55
*** gtema has quit IRC10:00
*** enriquetaso has quit IRC10:05
*** openstackstatus has quit IRC10:12
*** openstack has joined #openstack-sdks10:16
*** ChanServ sets mode: +o openstack10:16
*** dtantsur|afk is now known as dtantsur10:17
*** ttsiouts has quit IRC10:28
*** ttsiouts has joined #openstack-sdks10:28
*** ttsiouts has quit IRC10:33
*** enriquetaso has joined #openstack-sdks10:45
*** ttsiouts has joined #openstack-sdks11:07
*** jpena is now known as jpena|lunch11:34
mordredenriquetaso: I think dtroyer got you - but I agree with dtantsur and dtroyer - and I think the best outcome would be switching to sdk11:38
enriquetasomordred, thanks for answering me. This is my first time working with openstacksdk. Is openstack cli going to deprecate?11:42
*** noama has joined #openstack-sdks11:45
mordredoh no - openstack cli is the future. sdk is what we want to use for REST interactions with services instead of the per-service python-*client libraries11:53
mordredbut the idea is that we put shared needed logic for things into sdk - then it's available to python users, as well as other sdk consumers like ansible and salt, and we can build the osc commands from that same logic11:54
mordred*AND* - nova is starting to use sdk to talk to services - so the same logic can be reused for service-to-service interactions... but we don't have to maintain 30 different libraries11:55
*** jpich has quit IRC11:58
*** goldyfruit has quit IRC12:13
*** enriquetaso has quit IRC12:33
*** jpena|lunch is now known as jpena12:35
*** enriquetaso has joined #openstack-sdks12:40
*** gtema has quit IRC13:00
*** mriedem has joined #openstack-sdks13:24
*** goldyfruit has joined #openstack-sdks13:36
*** gtema has joined #openstack-sdks14:15
mriedemdtroyer: got a question about an osc-placement patch proposed to stable/train b/c of an osc 4.0.0 change to remove support for --os-url and replace it with --os-endpoint https://review.opendev.org/#/c/684292/114:18
mriedemcdent says that if you have python-openstackclient < 4.0 that won't work14:18
*** gtema has quit IRC14:19
mriedembut #14 on https://docs.openstack.org/python-openstackclient/latest/cli/backwards-incompatible.html makes it sound like that was a long-standing thing that we should have just not been using14:19
*** gtema has joined #openstack-sdks14:19
cdentI made it not work by only changing python-openstackclient, not osc-lib at the same time, so that may have been a factor14:19
mriedemso we're trying to figure out if we need to bump the minimum required version of osc to >= 4.0.0 in osc-placement's test-requirements14:20
dtroyerI'd have to refresh my memory, but —os-endpoint did not change, only the removal of —os-url.  The plugin I took out basically just aliased the option names14:21
mriedemcdent: ok so maybe you have to downgrade osc-lib to stein level and see if it works14:21
cdentone mo14:21
mriedemosc-lib 1.12.1 i guess?14:21
dtroyerI do not recall making the sorts of changes to osc-lib that would affect this going backward, only to support taking things out of osc4 itself14:21
*** ttsiouts has quit IRC14:21
dtroyerbut then my head went back to stx-land so who knows what I recall now… ;)14:22
mriedemso --os-endpoint should work with osc 3.19.014:22
*** ttsiouts has joined #openstack-sdks14:22
* cdent tries again14:22
*** ttsiouts has quit IRC14:22
*** ttsiouts has joined #openstack-sdks14:23
cdentif I downgrade just python-openstackclient it fails14:23
cdentif I downgrade also osc-lib it still fails14:24
cdentosc-lib 1.12.1 and p-osc 3.19.014:24
dtroyerI want to say osc-lib should not be a factor here14:25
cdentdtroyer: as you may recall, this is from the weird stuff that osc-placement is doing for its functional tests where it is sending an explicit token ("admin") to a defined url/endpoint14:26
cdentthe change that "fixes it" just replaces the use of --os-url with --os-endpoint in a call to shell.run()14:26
dtroyersome of the logic for deducing the proper auth-type has been removed from osc to make it compatible with sdk/ksa, that included changing os-url to os-endpoint to specifically set —os-auth-type to 'admin_token'14:31
dtroyerI can't imagine that ksa has changed in this area at all recently, that should not be a factor14:32
dtroyercdent: look at the comment in https://review.opendev.org/#/c/678059/1/openstackclient/tests/functional/base.py and see if that applies to what you are doing14:34
dtroyerit is about setting —os-auth-type in some cases and letting it default in others14:35
* cdent looks14:36
*** jpich has joined #openstack-sdks14:37
cdentdtroyer: what the osc-p functional tests are doing is shell.OpenStackShell().run(list_of_args) without setting --os-cloud or --os-auth-type. Solely: --os-endpoint, --os-token, --os-placement-api-version (if asked), -f json, and then whatever the command being tested happens to be14:40
cdentthings work correctly like that in 4.0.014:41
cdentand when it was --os-url they worked correctly in < 4.0.014:41
cdentIf I'm hearing you properly, what might be going on is that the os-endpoint support in < 4.0.0 needed an explicit --os-auth-type when --os-url did not?14:42
dtroyeryes, the check in osc was only on —os-url to set os-auth-type to 'token_endpoint'.  We never did a default for —os-endpoint before 4.014:43
mriedemah, so cdent - if you specify --os-auth-type in the functional test maybe we don't need to bump the required version of osc14:44
cdenthow should I orchestrate that patch wise?14:47
cdentjust do it on train?14:47
cdentdo it on both and backport14:48
cdentsomething else?14:48
mriedemdo it on both and backport14:48
mriedemif we want to require osc>=4.0 we should do that on master only14:48
mriedembut i'm not sure it's necessary anymore14:48
cdentroger con aye, 10 degree down bubble14:48
dtroyerosc4 will be the stable/train branch f that matters…14:48
cdentdtroyer: what is the proper auth-type to specify?14:51
cdentI guess 'admin_token'?14:54
efriedmordred: is a versioned root endpoint supposed to require auth?14:56
openstackgerritDean Troyer proposed openstack/python-openstackclient master: Microversion 2.78 - server show topology  https://review.opendev.org/68092814:57
dtroyercdent, mriedem: yes, admin_token is correct14:58
cdentthanks dtroyer14:59
*** enriquetaso has quit IRC15:03
*** goldyfruit_ has joined #openstack-sdks15:47
*** ttsiouts has quit IRC15:49
*** goldyfruit has quit IRC15:50
*** dtantsur is now known as dtantsur|afk16:15
*** gtema has quit IRC16:20
*** jpich has quit IRC16:21
*** gtema has joined #openstack-sdks16:21
*** gtema has quit IRC16:26
*** e0ne has quit IRC16:57
*** KeithMnemonic has quit IRC17:00
*** KeithMnemonic has joined #openstack-sdks17:00
*** ricolin has quit IRC17:03
*** jpena is now known as jpena|off17:32
*** ralonsoh has quit IRC17:42
*** e0ne has joined #openstack-sdks17:47
*** cdent has quit IRC18:08
*** e0ne has quit IRC18:09
openstackgerritguang-yee proposed openstack/keystoneauth master: Generate pdf documentation  https://review.opendev.org/68227218:21
*** e0ne has joined #openstack-sdks18:32
*** e0ne has quit IRC18:33
*** mriedem has quit IRC18:48
*** mriedem has joined #openstack-sdks18:49
*** e0ne has joined #openstack-sdks18:54
*** gtema has joined #openstack-sdks19:53
*** e0ne has quit IRC19:59
*** noama has quit IRC20:07
openstackgerritguang-yee proposed openstack/keystoneauth master: Generate pdf documentation  https://review.opendev.org/68227220:25
*** black_ant has quit IRC20:29
*** black_ant has joined #openstack-sdks20:30
*** e0ne has joined #openstack-sdks20:38
*** slaweq has quit IRC22:00
*** e0ne has quit IRC22:04
*** gtema has quit IRC22:13
openstackgerritEric Fried proposed openstack/openstacksdk master: Make proxy honor raise_exc in REST primitives  https://review.opendev.org/68443322:23
openstackgerritEric Fried proposed openstack/openstacksdk master: Make proxy honor raise_exc in REST primitives  https://review.opendev.org/68443322:25
*** black_ant has quit IRC22:28
*** ccamel has joined #openstack-sdks22:44
*** camelCaser has quit IRC22:47
*** dtantsur|afk has quit IRC22:51
*** goldyfruit_ has quit IRC23:14

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!