Thursday, 2018-10-04

*** slaweq has joined #openstack-sdks00:11
*** slaweq has quit IRC00:15
*** gildub has joined #openstack-sdks00:21
*** gildub has quit IRC00:39
*** dave-mccowan has quit IRC00:52
*** adriant has quit IRC00:54
*** adriant has joined #openstack-sdks01:00
*** mhen has quit IRC01:05
*** slaweq has joined #openstack-sdks01:11
*** slaweq has quit IRC01:15
*** pooja-jadhav has joined #openstack-sdks02:42
*** pooja_jadhav has quit IRC02:46
*** slaweq has joined #openstack-sdks03:11
*** slaweq has quit IRC03:16
*** pooja-jadhav has quit IRC04:14
*** pooja_jadhav has joined #openstack-sdks04:16
*** slaweq has joined #openstack-sdks05:11
*** slaweq has quit IRC05:16
*** gildub has joined #openstack-sdks05:27
*** gildub has quit IRC05:30
*** gildub has joined #openstack-sdks05:31
*** gildub has quit IRC05:34
*** gildub has joined #openstack-sdks05:36
*** gildub has quit IRC05:36
*** gildub has joined #openstack-sdks05:39
*** gildub has quit IRC05:43
*** Luzi has joined #openstack-sdks05:57
*** gildub has joined #openstack-sdks05:59
*** slaweq has joined #openstack-sdks06:57
*** ttsiouts has joined #openstack-sdks06:59
*** mhen has joined #openstack-sdks07:08
*** gildub has quit IRC07:10
*** ttsiouts has quit IRC07:16
*** tosky has joined #openstack-sdks07:45
*** olivierb_ has joined #openstack-sdks07:52
*** ttsiouts has joined #openstack-sdks08:00
*** gildub has joined #openstack-sdks08:19
*** gkadam has joined #openstack-sdks08:30
*** gkadam has quit IRC08:31
*** e0ne has joined #openstack-sdks08:42
*** ttsiouts has quit IRC08:49
*** gildub has quit IRC08:50
*** gtema has joined #openstack-sdks08:54
*** ttsiouts has joined #openstack-sdks08:59
*** ttsiouts has quit IRC09:04
*** ttsiouts has joined #openstack-sdks09:08
*** dtantsur|afk is now known as dtantsur09:55
dtantsurmordred: OOM killer, w000t10:00
dtantsuralso my question re raising the minimum version was not exactly about raising a version of an existing service10:00
dtantsurI'm writing a smart proxy for bare metal API, and I wonder if it's possible to not implement all 46-something microversions in it >_<10:01
*** ttsiouts has quit IRC10:21
*** ttsiouts has joined #openstack-sdks10:31
*** slaweq_ has joined #openstack-sdks10:37
*** slaweq has quit IRC10:40
*** slaweq__ has joined #openstack-sdks10:56
*** dave-mccowan has joined #openstack-sdks10:56
*** slaweq_ has quit IRC10:57
*** dave-mccowan has quit IRC11:01
*** dave-mccowan has joined #openstack-sdks11:01
*** cdent has joined #openstack-sdks11:14
cdentstephenfin: what's the issue with pytest?11:21
*** ttsiouts has quit IRC11:32
*** gtema has quit IRC11:46
*** ttsiouts has joined #openstack-sdks12:07
*** tosky__ has joined #openstack-sdks12:37
*** tosky is now known as Guest839912:37
*** tosky__ is now known as tosky12:37
*** Guest8399 has quit IRC12:39
stephenfincdent: IIRC, nose and pytest share the same problem: they're a-ok as test runners but its their use as a test library that raises objections12:49
cdentthat's a shame12:49
cdentpytest is so much _better_12:49
stephenfincdent: I'd suggest discussing that with mordred. He cares a *lot* about this stuff :)12:50
cdentyeah, I'm not meaning to badger you, just wondered if you had some insight12:51
cdentI ran up against similar resistance when creating gabbi. I didn't want it to be unitest-based12:51
cdentbut lifeless and a few others were super clear that I'd never get anywhere in openstack if it wasn't12:52
stephenfinYeah, mordred has explain his arguments for using it pretty well a couple of times but, alas, I never recorded them and can't find them now (maybe he should write a blog?)12:56
stephenfinFwiw though, while I enjoy the clever assertion handling, I'm really not a fan of the fixtures/markers. They're confusing and utterly unlike anything else I've seen in Python12:56
*** bobh has joined #openstack-sdks12:59
cdentstephenfin: I agree that pytest lost its way13:04
cdentI got into it in 2008ish, and back then it was very very very simple and I _loved_ it13:05
cdentnow, there's too many magics13:05
stephenfinmagic, yeah, that's the word13:05
stephenfinIt took me days to grok what on earth the Sphinx tests were doing and, even now, I'm carrying code for my own tests that I don't full understand. I blame pytest for a good chunk of that13:09
cdentwhen I added pytest support to dynamic test generation in gabbi, the very simple yield-based strategy that I had used back in 2009ish had been deprecated in favor of something insanely inscrutable13:18
*** slaweq__ is now known as slaweq13:36
*** brtknr has joined #openstack-sdks13:56
*** gkadam has joined #openstack-sdks14:00
* dtantsur follows this discussion with interest, since he was asked about pytest when giving a talk about unit testing python at the local user group14:04
cdentyou can still do non-magic in pytest, so it still has going for it14:05
brtknrI'm using python-openstackclient with python 3.7 and im getting this:14:06
brtknr(OS) ➜  osc-lib git:(master) openstack server list14:06
brtknrissubclass() arg 1 must be a class14:06
brtknri can still using nova list14:06
brtknri also didnt have the issue with python 3.614:07
smcginnisbrtknr: I'm not sure we are fully ready for Python 3.7 yet.14:24
*** tosky__ has joined #openstack-sdks14:27
*** tosky has quit IRC14:28
*** tosky__ is now known as tosky14:28
brtknrWell, it appears to work when I make this change:
brtknrBut I also saw this pending change on gerrit:
brtknrLast updated 30th August....14:30
*** pooja_jadhav has quit IRC14:30
brtknrLooking at the number of changes relating to this issue, looks like its a touchy subject...14:31
*** pooja_jadhav has joined #openstack-sdks14:31
brtknrfor e.g.
* dtantsur recalls something about issubclass becoming more picky in 3.714:31
fricklerbrtknr: our target for this cycle is to get all things working with 3.6, so 3.7 is still a bit down the road I think14:32
brtknrAnd this:
brtknrdtantsur: who are you? why do you speak in 3rd person14:34
* frickler likes that link14:36
* smcginnis laughs14:37
* brtknr says Oh...14:38
*** cdent has quit IRC14:53
*** bobh has quit IRC14:58
*** e0ne has quit IRC14:58
brtknrmy py37 tox test is passing when i change issubclass back to isinstance...
brtknraccording to this patch15:03
*** cdent has joined #openstack-sdks15:03
brtknron the other hand, its failing without the patch:
*** bobh has joined #openstack-sdks15:04
*** olivierb_ has quit IRC15:04
brtknrIt also fails for py27 without the patch!15:04
brtknr... wait no it doesnt15:05
*** olivierb_ has joined #openstack-sdks15:05
brtknr... my bad15:05
*** bobh has quit IRC15:10
*** ttsiouts has quit IRC15:11
openstackgerritStephen Finucane proposed openstack/os-api-ref master: tests: Support Sphinx 1.8+
*** e0ne has joined #openstack-sdks15:13
stephenfindhellmann: Would appreciate your Python-fu on the above. I'm not sure why a mock decorator on the class isn't working15:14
stephenfindhellmann: Specifically
*** Luzi has quit IRC15:25
*** olivierb_ has quit IRC15:29
mordredcdent: oh - yeah, I can't stand py.test15:29
*** olivierb_ has joined #openstack-sdks15:29
mordredcdent: but that's not why I'd suggest not using it in an openstack context - the main thing is that we have a bunch of infrastructure that's based around subunit streams15:31
mordredcdent: so far attempts to make a subunit output plugin for py.test have all died on the vine15:31
cdentyeah, that's my recollection from early gabbi too: can work however, as long as it can output subunit15:31
dtantsurmordred: out of curiosity: why can't you stand py.test?15:32
mordredI thinik it would be good for the world if someone would write a good subunit plugin for py.test15:32
mordreddtantsur: I find the way the magical fixtures work impossible to read/follow15:32
mordredin talking about it as a unittest library15:33
mordredbut also - the 'I'm a test runner and also a unittest library' annoys me since there is a unittest discovery protocol in core python - so nose and py.test mixing the two concerns is annoying15:33
cdenti think the original assertion with py.test, long before it became so magic, was that unittest (as mode and as a library) is entirely unpythonic, which I agree with15:34
mordredwhen we write tests that follow the standard unittest discovery protocol - then people are free to use py.test or stestr or nosetests on the command line as they feel like15:34
cdentwhen it moved on from holger it got a bit out of hand15:34
*** bobh has joined #openstack-sdks15:37
mordredmany things do15:42
*** bobh has quit IRC15:44
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Support firewall service for SDK
mordredml, dtantsur, Shrews: ^^ I squashed the test fix patches into the firewall service patch - that should be green, we should be able to land it and then the gate should stop being broken15:47
*** e0ne has quit IRC15:47
dtantsurI'm not sure what I think about squashing the fixes with a huge feature patch. Is it your way of forcing us to review it? :)15:47
mordreddtantsur: :) ... no, it was just to avoid rebase pain since the fwaas patch also adds job config that touches the same jobs15:49
mordreddtantsur: I could unsquash and try rebasing it into a different order if you want though15:50
dtantsurI'd prefer the gate fix separate, to be honest, and the fwaas patch on top of it15:52
*** olivierb_ has quit IRC15:55
Shrewsditto. these large changes to review are just not fun15:56
Shrewssmaller the better15:56
mordredkk. I'll take a stab at that real quick15:57
edleafe /me notes that API-SIG office hours have started16:00
edleafewell, office *hour*16:01
* dtantsur is semi-around but may leave earlier16:04
edleafedtantsur: don't worry, I'll try to keep up with the volume of participants :)16:05
cdentdid you all see the discussion with rosmaita yesterday or so?16:06
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Clean up python3 test and split networking into a job
openstackgerritMonty Taylor proposed openstack/openstacksdk master: Support firewall service for SDK
* cdent finds link16:06
mordreddtantsur, Shrews: ok - that wasn't as painful as I thought16:07
mordredI still merged the two testing update patches since they're both just basically updating .zuul.yaml16:07
dtantsurmordred: ok, I think this is fine16:09
mordrednow here's hoping I id it right :)16:09
edleafecdent: no, didn't see that16:10
dtantsurokay, actually. My head refuses to do any thinking more. I guess I'll go for some jogging instead.16:10
* cdent needs that kind of habit16:10
*** dtantsur is now known as dtantsur|afk16:10
smcginnisIf I were to work on adding more Cinder commands to python-openstackclient - is the plan now to put things in openstacksdk or other lib first, then expose it through osc? Or just use cinderclient within osc?16:11
* smcginnis seems to remember half paying attention to some long term plan discussions16:11
mordredsmcginnis: the plan is to move osc to using sdk and off of python-*client - and hopefully we will be in a position to start doing rip-and-replace in a few weeks16:29
smcginnismordred: So if I were to look at adding some commands, I should first look at adding that functionality to openstacksdk?16:31
mordredsmcginnis: that would be the bestest choice - but also python-cinderclient is also currently being used, so I wouldn't block yourself on that transition16:35
smcginnisGreat, sounds reasonable.16:35
smcginnisI'll see what works best, considering the long term plan I would like to avoid creating later work if possible.16:35
openstackgerritLogan V proposed openstack/openstacksdk master: Add networks to Limestone vendor
*** gkadam has quit IRC17:08
dhellmannstephenfin : is mock failing because of import ordering or something?17:15
dhellmannstephenfin : if you have a version of a change that wasn't working, I could poke at that a bit17:16
*** bobh has joined #openstack-sdks17:45
*** olivierb has joined #openstack-sdks18:01
*** olivierb has quit IRC18:01
*** imacdonn has quit IRC18:22
*** imacdonn has joined #openstack-sdks18:22
*** e0ne has joined #openstack-sdks18:31
*** e0ne has quit IRC18:33
*** mriedem has joined #openstack-sdks18:34
*** cdent has quit IRC18:39
*** mriedem has quit IRC19:15
*** cdent has joined #openstack-sdks19:23
*** mriedem has joined #openstack-sdks19:24
*** cdent has quit IRC19:54
*** e0ne has joined #openstack-sdks20:08
*** e0ne has quit IRC20:14
*** e0ne has joined #openstack-sdks20:30
mlmordred: thanks for the fix. any chance you can restore +2 CR?20:34
openstackgerritMatthias Lisin proposed openstack/openstacksdk master: Implement FWaaS wrapper methods.
*** tosky has quit IRC20:42
*** tosky has joined #openstack-sdks20:43
*** e0ne has quit IRC21:00
*** mriedem has quit IRC21:05
*** bobh has quit IRC21:58
*** tosky has quit IRC23:17
*** edleafe has quit IRC23:39
*** gildub has joined #openstack-sdks23:57

Generated by 2.15.3 by Marius Gedminas - find it at!