| cburgess | mriedem overachiever, I take it you all are finally removing nova-network from the tree? | 00:09 |
|---|---|---|
| *** germs has quit IRC | 00:15 | |
| *** salv-orlando has joined #openstack-nova | 00:15 | |
| *** germs has joined #openstack-nova | 00:17 | |
| *** gouthamr has joined #openstack-nova | 00:19 | |
| *** gyee has quit IRC | 00:20 | |
| *** claudiub has quit IRC | 00:20 | |
| *** salv-orlando has quit IRC | 00:21 | |
| *** chyka has quit IRC | 00:21 | |
| *** pchavva has joined #openstack-nova | 00:24 | |
| *** germs has quit IRC | 00:32 | |
| Spaz-Home | Morning | 00:35 |
| *** germs has joined #openstack-nova | 00:42 | |
| *** germs has quit IRC | 00:42 | |
| *** germs has joined #openstack-nova | 00:42 | |
| *** Zames has joined #openstack-nova | 00:44 | |
| *** Dinesh_Bhor has joined #openstack-nova | 00:47 | |
| *** germs has quit IRC | 00:48 | |
| *** liuzz has joined #openstack-nova | 00:48 | |
| *** germs has joined #openstack-nova | 00:49 | |
| *** yamahata_ has quit IRC | 00:49 | |
| *** yamahata_ has joined #openstack-nova | 00:50 | |
| *** Dinesh_Bhor has quit IRC | 00:51 | |
| *** germs has quit IRC | 00:53 | |
| *** odyssey4me has quit IRC | 00:53 | |
| *** odyssey4me has joined #openstack-nova | 00:53 | |
| *** Dinesh_Bhor has joined #openstack-nova | 00:54 | |
| *** gjayavelu has quit IRC | 00:55 | |
| *** wolverineav has quit IRC | 00:56 | |
| *** wolverineav has joined #openstack-nova | 00:57 | |
| *** jichen has joined #openstack-nova | 00:57 | |
| *** mingyu has quit IRC | 00:57 | |
| artom | Spaz-Home, you have a weird schedule ;) | 00:58 |
| *** Dinesh__Bhor has joined #openstack-nova | 00:59 | |
| *** Dinesh__Bhor has quit IRC | 00:59 | |
| *** zhaochao has joined #openstack-nova | 00:59 | |
| *** Dinesh_Bhor has quit IRC | 01:00 | |
| *** Zames has quit IRC | 01:01 | |
| *** phuongnh has joined #openstack-nova | 01:02 | |
| *** wolverineav has quit IRC | 01:02 | |
| *** r-daneel has quit IRC | 01:02 | |
| *** Dinesh_Bhor has joined #openstack-nova | 01:03 | |
| mnaser | is os_vif under nova or neutron's world | 01:03 |
| mnaser | https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py#L266-L268 -- im trying to understand why the unplug under linux is noop for ovs | 01:03 |
| jichen | mriedem: hi do you know where to find the etherpad that discussed in PTG to put patches of previously approved spec so that it can get more review and help? I want to put https://review.openstack.org/#/q/topic:bp/add-zvm-driver-rocky+(status:open+OR+status:merged) into it. thanks | 01:03 |
| *** pchavva has quit IRC | 01:06 | |
| Kevin_Zheng | mriedem Hi, saw you guys discussing about the quota thing, any conclusion? | 01:09 |
| *** hongbin has joined #openstack-nova | 01:12 | |
| *** itlinux has quit IRC | 01:12 | |
| *** salv-orlando has joined #openstack-nova | 01:17 | |
| *** harlowja has quit IRC | 01:20 | |
| *** salv-orlando has quit IRC | 01:21 | |
| *** yangyapeng has joined #openstack-nova | 01:22 | |
| *** hshiina has joined #openstack-nova | 01:24 | |
| *** suresh12 has quit IRC | 01:25 | |
| *** edmondsw has joined #openstack-nova | 01:25 | |
| *** suresh12 has joined #openstack-nova | 01:25 | |
| openstackgerrit | Artom Lifshitz proposed openstack/nova-specs master: Live migration with CPU pinning https://review.openstack.org/552722 | 01:26 |
| *** yangyapeng has quit IRC | 01:26 | |
| *** gongysh has quit IRC | 01:27 | |
| *** sdague has quit IRC | 01:28 | |
| *** edmondsw has quit IRC | 01:29 | |
| *** suresh12 has quit IRC | 01:30 | |
| *** Tom-Tom has joined #openstack-nova | 01:36 | |
| *** gbarros has quit IRC | 01:36 | |
| *** gongysh has joined #openstack-nova | 01:39 | |
| *** lei-zh has joined #openstack-nova | 01:39 | |
| *** yangyapeng has joined #openstack-nova | 01:41 | |
| *** tiendc has joined #openstack-nova | 01:55 | |
| *** suresh12 has joined #openstack-nova | 02:00 | |
| *** suresh12 has quit IRC | 02:04 | |
| *** zhaochao has quit IRC | 02:04 | |
| *** suresh12 has joined #openstack-nova | 02:05 | |
| jianghuaw_ | jichen, is this what you're looking for? https://etherpad.openstack.org/p/rocky-nova-priorities-tracking | 02:11 |
| Spaz-Home | lol indeed artom , Night shift, so I work Asia hours :p | 02:12 |
| *** vladikr has quit IRC | 02:13 | |
| *** vladikr has joined #openstack-nova | 02:13 | |
| artom | Spaz-Home, ah! I did night shift in a previous life, working support for a web host. It was... interesting | 02:14 |
| Spaz-Home | That it is.. i've been doing it for about 10 years.. It can be extremely unhealthy, Just in the paste 2 years or so i've started to prioritize my health in the situation. | 02:14 |
| Spaz-Home | But also.. I get to bother jianghuaw_ all night, which is probably the best benefit :P | 02:14 |
| jianghuaw_ | Spaz-Home, good morning:-) | 02:15 |
| Spaz-Home | Welcome home, sir. | 02:15 |
| artom | I only did it for a few months, it definitely messed with me, I can't imagine doing it for years. We're not cats. | 02:15 |
| jichen | jianghuaw_: thanks, I missed line 98 in the etherpad... :) | 02:15 |
| Spaz-Home | Hehe yes sir.. I've honestly seem people's minds go a little crazy .. some people just are not made for that transition. | 02:16 |
| jianghuaw_ | jichen, np:-) | 02:16 |
| jianghuaw_ | Spaz-Home, thanks. Good job on https://review.openstack.org/#/c/538415/ :-) | 02:18 |
| Spaz-Home | Hey jianghuaw_ before I lose ya, Dan is asking for a Xen Subteam member to attend Nova Meeting this week for https://blueprints.launchpad.net/nova/+spec/live-migration-in-xapi-pool | 02:18 |
| Spaz-Home | Haha thanks sir, made me happy | 02:18 |
| jianghuaw_ | Spaz-Home, yes. Naichuan or myself will attend this week's meeting. | 02:19 |
| jianghuaw_ | Hope will get that BP be approved. | 02:19 |
| Spaz-Home | Sounds good. I'd also like to discuss that with you a bit today or tomorrow if you have the time | 02:19 |
| Spaz-Home | I do thin kthey plan to approve | 02:19 |
| jianghuaw_ | Yes, we had some discussion in the PTG. | 02:20 |
| jianghuaw_ | Spaz-Home, so what do you want to to chat on that topic? | 02:20 |
| *** germs has joined #openstack-nova | 02:20 | |
| *** germs has quit IRC | 02:20 | |
| *** germs has joined #openstack-nova | 02:20 | |
| Spaz-Home | Well I understand the reason for the patch and it's basically just moving away from aggregates into the more refined pools, so I cannot speak anythign bad about the patch itself as it's the same situation but a different method | 02:21 |
| Spaz-Home | However I still dislike that we're forcing an optional feature into the xenapi drives for LM to work | 02:21 |
| jianghuaw_ | LM? | 02:22 |
| Spaz-Home | My apologies, Live Migration | 02:22 |
| Spaz-Home | I guess the best example would be my own environment we work in, We do not use Aggregates or Pooling, and just allow VMs to migrate around within the same Cell | 02:23 |
| Spaz-Home | Since Networks are assigned through the cell and inventory is similar.. My thought however is how common that swetup would be rather than using pooling or aggregates. | 02:23 |
| jianghuaw_ | Yes, the original plan for this feature is to support XAPI pool which is the direction which we think is better than the aggregation pool. | 02:23 |
| openstackgerrit | Merged openstack/nova master: Reparent placement objects to oslo_versionedobjects https://review.openstack.org/551529 | 02:23 |
| Spaz-Home | I can certainly agree on that point | 02:24 |
| jianghuaw_ | But later we noticed the existing aggregation pool is broken when introducing cells. | 02:24 |
| *** yangyapeng has quit IRC | 02:25 | |
| Spaz-Home | Hrm. | 02:26 |
| *** r-daneel has joined #openstack-nova | 02:26 | |
| jianghuaw_ | I guess the use case you mentioned should be still supported. | 02:27 |
| Spaz-Home | Well, as of right now it's definately not since it will fail pulling the aggregate, and I think it will now as well trying to pull a pool master. | 02:27 |
| *** Dinesh_Bhor has quit IRC | 02:27 | |
| jianghuaw_ | As you're not using pool or aggregation, so ML should still work. | 02:28 |
| *** amodi has joined #openstack-nova | 02:29 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:30 | |
| Spaz-Home | yeah I don't think it will work looking at the new is_same_pool_host | 02:30 |
| Spaz-Home | IT's going to look for that dest in the pool and fail just like the aggregation check does. | 02:30 |
| Spaz-Home | I'll need to fire up a host to confirm that, but should throw an error | 02:30 |
| Spaz-Home | I guess in the end I had two thoughts. If (when we make this final change to change the checks themselves) we could check if the pool is empty AND if CONF [cells]->Enable=True to figure out if a destination is acceptable | 02:31 |
| Spaz-Home | Or if you guys do decide to jsut rely on pools, I would like to submit a followup patch to increase parity with block-migration. Right now block-migration is very much not aligned, as this is how we currently live migrate to avoid the aggregation check. | 02:32 |
| Spaz-Home | That way things remain even and clean. We could use that opportunity to always run the assert_will_migrate and ensure that block-migration checks for the pool st atus as well. | 02:33 |
| jianghuaw_ | Spaz-Home, https://git.openstack.org/cgit/openstack/nova/tree/nova/virt/xenapi/vmops.py#n2322 | 02:34 |
| jianghuaw_ | I think it should go to this branch. | 02:34 |
| jianghuaw_ | It's not able to use shared SR to speed-up live-migration. | 02:35 |
| *** yamahata_ has quit IRC | 02:35 | |
| *** vladikr has quit IRC | 02:35 | |
| *** AlexeyAbashkin has joined #openstack-nova | 02:36 | |
| jianghuaw_ | If want to use shared SR, surely must add hosts into the same pool. | 02:36 |
| *** mriedem has quit IRC | 02:37 | |
| *** vladikr has joined #openstack-nova | 02:38 | |
| jianghuaw_ | Spaz-Home, also please note we will have a follow-up patch to remove the this upcall - _ensure_host_in_aggregate. | 02:38 |
| Spaz-Home | Yeah got ya | 02:38 |
| Spaz-Home | It's wierd that we're using block_migration like that.. but I actually hadn't looked at this line before | 02:39 |
| Spaz-Home | Sicne block_migration is intended purely for iscsi stuff.. it's itneresting that we're using it to reroute the code lol | 02:39 |
| *** AlexeyAbashkin has quit IRC | 02:40 | |
| Spaz-Home | Ok.. with that line I am fine with this then sir | 02:41 |
| jianghuaw_ | Indeed. I agree. At sometime we should refactor this part to make it more reasonable. | 02:41 |
| Spaz-Home | I think we need to just refactor the process overall.. I was thinking in a month or so just getting a whiteboard and seeing what I can do and send you pictures lol | 02:41 |
| Spaz-Home | But a project for another time | 02:41 |
| *** amodi has quit IRC | 02:42 | |
| *** hongbin_ has joined #openstack-nova | 02:42 | |
| jianghuaw_ | Great. yes. just ping me if you have any thoughts at any time. | 02:42 |
| jianghuaw_ | I'm happy that you're interested at it. | 02:42 |
| jianghuaw_ | :-) | 02:42 |
| *** hongbin has quit IRC | 02:43 | |
| *** germs has quit IRC | 02:43 | |
| Spaz-Home | Absolutely :D I'll submit a commit here this week as well to fix that assert_can_migrate as well so evertything asserts, and keep bug diving :P | 02:43 |
| Spaz-Home | Enjoy the rest of your shift sir, let me know if you need anything | 02:43 |
| *** germs has joined #openstack-nova | 02:43 | |
| *** germs has quit IRC | 02:43 | |
| *** germs has joined #openstack-nova | 02:43 | |
| jianghuaw_ | Thanks. It's too late for you. | 02:43 |
| jianghuaw_ | time for bed | 02:44 |
| *** fragatina has quit IRC | 02:46 | |
| *** psachin has joined #openstack-nova | 02:47 | |
| *** germs has quit IRC | 02:48 | |
| *** fragatina has joined #openstack-nova | 02:49 | |
| Spaz-Home | Hehe nah I stay on my night shift on my weekends. Will be up until well after you're asleep. | 02:50 |
| Spaz-Home | With my wife in Korea, I have to stay on the same hours as you basically :p | 02:50 |
| *** fragatina has quit IRC | 02:51 | |
| *** Dinesh_Bhor has quit IRC | 02:52 | |
| *** Dinesh_Bhor has joined #openstack-nova | 02:52 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722 | 02:53 |
| *** suresh12 has quit IRC | 02:54 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Allow abort live migrations in queued status https://review.openstack.org/536722 | 02:55 |
| Spaz-Home | Moving my second commit back down to subteam review. I self -1'ed it for the moment. Will fix unit tests tomorrow. | 02:56 |
| *** Dinesh_Bhor has quit IRC | 02:58 | |
| *** psachin has quit IRC | 02:59 | |
| *** Dinesh_Bhor has joined #openstack-nova | 03:00 | |
| *** psachin has joined #openstack-nova | 03:03 | |
| *** psachin has quit IRC | 03:05 | |
| *** psachin has joined #openstack-nova | 03:08 | |
| *** edmondsw has joined #openstack-nova | 03:14 | |
| *** vivsoni has quit IRC | 03:15 | |
| *** gongysh has quit IRC | 03:17 | |
| *** psachin has quit IRC | 03:17 | |
| *** edmondsw has quit IRC | 03:18 | |
| *** zhaochao has joined #openstack-nova | 03:18 | |
| *** salv-orlando has joined #openstack-nova | 03:18 | |
| *** salv-orlando has quit IRC | 03:23 | |
| *** nicolasbock has quit IRC | 03:26 | |
| *** vivsoni has joined #openstack-nova | 03:27 | |
| *** suresh12 has joined #openstack-nova | 03:28 | |
| *** hshiina2 has joined #openstack-nova | 03:31 | |
| *** hshiina has quit IRC | 03:31 | |
| *** esberglu has quit IRC | 03:32 | |
| *** suresh12 has quit IRC | 03:32 | |
| *** Zames has joined #openstack-nova | 03:32 | |
| *** psachin has joined #openstack-nova | 03:35 | |
| *** AlexeyAbashkin has joined #openstack-nova | 03:36 | |
| *** AlexeyAbashkin has quit IRC | 03:40 | |
| *** vivsoni has quit IRC | 03:45 | |
| *** yamahata_ has joined #openstack-nova | 03:51 | |
| *** Zames has quit IRC | 03:53 | |
| *** david-lyle has joined #openstack-nova | 03:55 | |
| *** vivsoni has joined #openstack-nova | 03:58 | |
| *** gongysh has joined #openstack-nova | 04:00 | |
| *** hongbin_ has quit IRC | 04:02 | |
| *** Zames has joined #openstack-nova | 04:02 | |
| *** janki has joined #openstack-nova | 04:02 | |
| *** esberglu has joined #openstack-nova | 04:05 | |
| *** udesale has joined #openstack-nova | 04:05 | |
| *** Dinesh_Bhor has quit IRC | 04:07 | |
| *** fragatina has joined #openstack-nova | 04:08 | |
| *** namnh has joined #openstack-nova | 04:09 | |
| *** suresh12 has joined #openstack-nova | 04:09 | |
| *** fragatina has quit IRC | 04:09 | |
| *** esberglu has quit IRC | 04:09 | |
| *** fragatina has joined #openstack-nova | 04:10 | |
| *** harlowja has joined #openstack-nova | 04:12 | |
| *** suresh12 has quit IRC | 04:14 | |
| *** Zames has quit IRC | 04:16 | |
| *** suresh12 has joined #openstack-nova | 04:17 | |
| *** wolverineav has joined #openstack-nova | 04:17 | |
| *** dave-mccowan has quit IRC | 04:17 | |
| *** salv-orlando has joined #openstack-nova | 04:19 | |
| *** wolverineav has quit IRC | 04:21 | |
| *** links has joined #openstack-nova | 04:22 | |
| *** salv-orlando has quit IRC | 04:24 | |
| *** moshele has joined #openstack-nova | 04:28 | |
| *** lei-zh has quit IRC | 04:28 | |
| *** diga has joined #openstack-nova | 04:29 | |
| *** moshele has quit IRC | 04:36 | |
| *** chyka has joined #openstack-nova | 04:38 | |
| *** harlowja has quit IRC | 04:40 | |
| *** Dinesh_Bhor has joined #openstack-nova | 04:42 | |
| *** chyka has quit IRC | 04:43 | |
| *** abhishekk has joined #openstack-nova | 04:45 | |
| *** andreas_s has joined #openstack-nova | 04:48 | |
| *** andreas_s has quit IRC | 04:52 | |
| *** lei-zh has joined #openstack-nova | 04:54 | |
| *** Dinesh_Bhor has quit IRC | 04:57 | |
| *** esberglu has joined #openstack-nova | 04:59 | |
| *** vladikr has quit IRC | 05:00 | |
| *** Dinesh_Bhor has joined #openstack-nova | 05:00 | |
| *** alexchadin has joined #openstack-nova | 05:03 | |
| *** esberglu has quit IRC | 05:03 | |
| *** ratailor has joined #openstack-nova | 05:14 | |
| *** Dinesh_Bhor has quit IRC | 05:17 | |
| *** salv-orlando has joined #openstack-nova | 05:20 | |
| *** salv-orlando has quit IRC | 05:24 | |
| *** mdnadeem has joined #openstack-nova | 05:31 | |
| *** sidx64 has joined #openstack-nova | 05:31 | |
| *** esberglu has joined #openstack-nova | 05:34 | |
| *** esberglu has quit IRC | 05:38 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/552774 | 05:46 |
| *** claudiub has joined #openstack-nova | 05:48 | |
| *** Spazmotic has joined #openstack-nova | 05:48 | |
| *** sidx64 has quit IRC | 05:49 | |
| *** Spaz-Home has quit IRC | 05:49 | |
| *** sridharg has joined #openstack-nova | 05:50 | |
| *** sidx64 has joined #openstack-nova | 05:51 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/533918 | 05:55 |
| *** sidx64 has quit IRC | 05:59 | |
| *** suresh12 has quit IRC | 05:59 | |
| *** sidx64 has joined #openstack-nova | 06:00 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Imported Translations from Zanata https://review.openstack.org/548772 | 06:17 |
| *** salv-orlando has joined #openstack-nova | 06:21 | |
| *** lajoskatona has joined #openstack-nova | 06:23 | |
| *** salv-orlando has quit IRC | 06:25 | |
| *** esberglu has joined #openstack-nova | 06:28 | |
| *** alexchadin has quit IRC | 06:28 | |
| *** alexchadin has joined #openstack-nova | 06:29 | |
| *** esberglu has quit IRC | 06:32 | |
| *** mdnadeem_ has joined #openstack-nova | 06:32 | |
| *** moshele has joined #openstack-nova | 06:33 | |
| *** mdnadeem has quit IRC | 06:33 | |
| openstackgerrit | Zhenyu Zheng proposed openstack/nova master: nova-manage db archive_deleted_rows is not multi-cell aware https://review.openstack.org/507486 | 06:34 |
| *** salv-orlando has joined #openstack-nova | 06:34 | |
| *** Dinesh_Bhor has joined #openstack-nova | 06:35 | |
| *** kholkina has joined #openstack-nova | 06:37 | |
| *** sidx64_ has joined #openstack-nova | 06:38 | |
| *** mdnadeem_ has quit IRC | 06:39 | |
| *** sidx64 has quit IRC | 06:40 | |
| *** trinaths has joined #openstack-nova | 06:41 | |
| *** dims has quit IRC | 06:41 | |
| *** sidx64 has joined #openstack-nova | 06:42 | |
| *** dims has joined #openstack-nova | 06:43 | |
| *** sidx64_ has quit IRC | 06:45 | |
| *** dims has quit IRC | 06:48 | |
| *** dims has joined #openstack-nova | 06:49 | |
| *** edmondsw has joined #openstack-nova | 06:50 | |
| *** mdnadeem_ has joined #openstack-nova | 06:50 | |
| *** deepak_ has quit IRC | 06:53 | |
| *** edmondsw has quit IRC | 06:54 | |
| *** tojuvone has joined #openstack-nova | 06:56 | |
| *** sahid has joined #openstack-nova | 06:58 | |
| *** pcaruana has joined #openstack-nova | 07:04 | |
| *** wangqwsh has joined #openstack-nova | 07:09 | |
| *** sidx64_ has joined #openstack-nova | 07:12 | |
| *** sidx64 has quit IRC | 07:13 | |
| *** andreas_s has joined #openstack-nova | 07:14 | |
| *** Dinesh_Bhor has quit IRC | 07:15 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:16 | |
| *** alexchadin has quit IRC | 07:16 | |
| *** sidx64_ has quit IRC | 07:17 | |
| *** alexchadin has joined #openstack-nova | 07:17 | |
| *** sidx64 has joined #openstack-nova | 07:17 | |
| *** sar has joined #openstack-nova | 07:19 | |
| *** Dinesh_Bhor has quit IRC | 07:20 | |
| *** Dinesh_Bhor has joined #openstack-nova | 07:27 | |
| *** tovin07 has joined #openstack-nova | 07:28 | |
| *** salv-orlando has quit IRC | 07:28 | |
| *** OctopusZhang has joined #openstack-nova | 07:29 | |
| *** andreas_s has quit IRC | 07:31 | |
| *** danpawlik has joined #openstack-nova | 07:31 | |
| *** andreas_s has joined #openstack-nova | 07:32 | |
| *** OctopusZhang_ has joined #openstack-nova | 07:32 | |
| *** OctopusZhang has quit IRC | 07:32 | |
| *** OctopusZhang_ is now known as yufei | 07:33 | |
| *** salv-orlando has joined #openstack-nova | 07:34 | |
| *** OctopusZhang has joined #openstack-nova | 07:35 | |
| *** Dinesh_Bhor has quit IRC | 07:37 | |
| *** trinaths has quit IRC | 07:38 | |
| *** yufei has quit IRC | 07:39 | |
| *** OctopusZhang is now known as yufei | 07:39 | |
| *** alexchadin has quit IRC | 07:39 | |
| *** chyka has joined #openstack-nova | 07:42 | |
| *** chyka has quit IRC | 07:47 | |
| *** alexchadin has joined #openstack-nova | 07:47 | |
| *** tssurya has joined #openstack-nova | 07:51 | |
| *** AlexeyAbashkin has joined #openstack-nova | 07:57 | |
| *** alexchadin has quit IRC | 07:57 | |
| *** alexchadin has joined #openstack-nova | 07:58 | |
| *** suresh12 has joined #openstack-nova | 07:59 | |
| *** mdnadeem has joined #openstack-nova | 08:02 | |
| *** suresh12 has quit IRC | 08:04 | |
| *** mdnadeem_ has quit IRC | 08:05 | |
| *** diga has quit IRC | 08:08 | |
| *** tesseract has joined #openstack-nova | 08:14 | |
| openstackgerrit | sahid proposed openstack/nova master: libvirt: slow live-migration to ensure network is ready https://review.openstack.org/497457 | 08:14 |
| *** Dinesh_Bhor has joined #openstack-nova | 08:17 | |
| *** salv-orlando has quit IRC | 08:17 | |
| *** damien_r has joined #openstack-nova | 08:21 | |
| *** yamahata_ has quit IRC | 08:24 | |
| *** jpena|off is now known as jpena | 08:25 | |
| openstackgerrit | Jie Li proposed openstack/nova-specs master: Support volume-backed server rebuild https://review.openstack.org/532407 | 08:27 |
| *** hoonetorg has quit IRC | 08:30 | |
| *** mingyu has joined #openstack-nova | 08:30 | |
| *** mdbooth has quit IRC | 08:33 | |
| *** ansiwen has quit IRC | 08:33 | |
| *** amoralej|off is now known as amoralej | 08:36 | |
| openstackgerrit | sahid proposed openstack/nova-specs master: libvirt: add support for virtio-net rx/tx queue sizes https://review.openstack.org/539605 | 08:36 |
| *** edmondsw has joined #openstack-nova | 08:38 | |
| *** Dinesh_Bhor has quit IRC | 08:38 | |
| *** edmondsw has quit IRC | 08:43 | |
| *** hoonetorg has joined #openstack-nova | 08:44 | |
| *** ragiman has joined #openstack-nova | 08:51 | |
| *** ralonsoh has joined #openstack-nova | 08:54 | |
| *** ccamacho has joined #openstack-nova | 08:55 | |
| *** cdent has joined #openstack-nova | 08:58 | |
| *** sidx64 has quit IRC | 09:03 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 09:05 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | 09:05 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Move placement exceptions into the placement package https://review.openstack.org/549862 | 09:05 |
| *** salv-orlando has joined #openstack-nova | 09:07 | |
| kashyap | mdbooth: Saw the change last evening was letting Zuul go through its course. | 09:08 |
| *** lucas-afk is now known as lucasagomes | 09:11 | |
| *** Dinesh_Bhor has joined #openstack-nova | 09:15 | |
| *** Dinesh_Bhor has quit IRC | 09:16 | |
| *** yamamoto_ has joined #openstack-nova | 09:18 | |
| *** hemna_ has quit IRC | 09:20 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Move placement exceptions into the placement package https://review.openstack.org/549862 | 09:20 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 09:20 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | 09:20 |
| *** Dinesh_Bhor has joined #openstack-nova | 09:21 | |
| *** trinaths has joined #openstack-nova | 09:21 | |
| *** yamamoto has quit IRC | 09:22 | |
| *** gongysh has quit IRC | 09:22 | |
| *** mgoddard_ has joined #openstack-nova | 09:24 | |
| bauzas | man, I forgot my manners | 09:27 |
| bauzas | good morning Nova | 09:27 |
| *** udesale_ has joined #openstack-nova | 09:27 | |
| *** udesale__ has joined #openstack-nova | 09:29 | |
| *** udesale has quit IRC | 09:29 | |
| *** Dinesh_Bhor has quit IRC | 09:30 | |
| *** udesale_ has quit IRC | 09:32 | |
| *** derekh has joined #openstack-nova | 09:34 | |
| *** lpetrut has joined #openstack-nova | 09:34 | |
| openstackgerrit | Yikun Jiang (Kero) proposed openstack/nova-specs master: Complex (Anti)-Affinity Policies https://review.openstack.org/546925 | 09:35 |
| pooja_jadhav | cdent: Hi | 09:37 |
| cdent | good morning pooja_jadhav | 09:38 |
| pooja_jadhav | cdent: actually i want discuss with you regarding shared resource provider thing. | 09:39 |
| pooja_jadhav | cdent: very gm :) | 09:39 |
| cdent | pooja_jadhav: sure, but you should be aware that share providers are still a bit of a work in progress. Most of the functionality is nearly there, but nothing really uses it yet. | 09:40 |
| cdent | What's your plan? | 09:41 |
| pooja_jadhav | cdent: planning to test correct disk usage or not on shared storage | 09:42 |
| pooja_jadhav | cdent : cdent: i have configured nfs backend, and created shared resource provider, but when i booted the instance it failing at line [1] https://github.com/openstack/nova/blob/master/nova/scheduler/manager.py#L138 | 09:42 |
| cdent | pooja_jadhav: is there an aggregate in place that associates the shared storage provider with one or more compute nodes that use it? | 09:43 |
| pooja_jadhav | yes, aggregate is there | 09:43 |
| pooja_jadhav | its not getting allocation request | 09:44 |
| pooja_jadhav | when i create the instance, that instance going into error state | 09:44 |
| pooja_jadhav | actually, where am i missing something, i am not getting :( | 09:46 |
| cdent | tetsuro recently wrote an email with some updated information on the state of sharing providers, let me find that. It may be that what you're trying to do simply doesn't work in /allocation_candidates yet | 09:47 |
| cdent | this message: http://lists.openstack.org/pipermail/openstack-dev/2018-March/128141.html | 09:47 |
| pooja_jadhav | ohkk | 09:47 |
| cdent | That first item he lists, about the resource class existing in both places, may be part of the problem? Is the compute node reporting disk inventory ? | 09:48 |
| *** lei-zh has quit IRC | 09:50 | |
| *** Tom-Tom has quit IRC | 09:52 | |
| *** Tom-Tom has joined #openstack-nova | 09:52 | |
| pooja_jadhav | i have checked the db, inventory record i have created that exists | 09:52 |
| *** wangqwsh has quit IRC | 09:52 | |
| pooja_jadhav | but to check that compute node is reporting it or not? | 09:52 |
| pooja_jadhav | but how to check that compute node is reporting that inventory or not? | 09:53 |
| cdent | pooja_jadhav: there's an osc-placement client now, so you can use that if you like, or use curl or another tool to interact with the placement api, or look in the database (there will be inventory rows that are associated with resource providers by resource provider id) | 09:55 |
| pooja_jadhav | yes, i have checked in the database, there is inventory which i have created with the resource provider which is created by me. | 09:56 |
| *** Tom-Tom has quit IRC | 09:57 | |
| *** jichen has quit IRC | 09:58 | |
| *** namnh has quit IRC | 10:00 | |
| cdent | pooja_jadhav: do you have disk inventory from both a compute node and the shared provider or only the shared provider? | 10:00 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Update contributor/placement.rst to contemporary reality https://review.openstack.org/552860 | 10:01 |
| cdent | stephenfin, gibi : quick doc improvement ^ | 10:01 |
| *** yufei has quit IRC | 10:02 | |
| cdent | stephenfin: I also reordered some of the remaining placement-extraction code that you recently helped merge so that the current "next one" is ahead of the optional db stuff: https://review.openstack.org/#/c/549862/ | 10:03 |
| pooja_jadhav | cdebt : disk inventory from both a compute node and the shared provider (bcz I have created only one inventory record for resource provider id 2 but in that table already 3 more records exists means 3 inventory records from resource provider id 1) | 10:04 |
| cdent | pooja_jadhav: in that case I think you're hitting the problem described here https://review.openstack.org/#/c/533396 it is possible for you try again with that code in place? | 10:05 |
| cdent | I'm going to get some more coffee but will be back shortly | 10:05 |
| pooja_jadhav | cdent: sure | 10:08 |
| pooja_jadhav | i will try | 10:10 |
| *** hshiina2 has quit IRC | 10:11 | |
| *** rcernin has quit IRC | 10:13 | |
| *** sidx64 has joined #openstack-nova | 10:17 | |
| *** alexchadin has quit IRC | 10:18 | |
| cdent | pooja_jadhav: let me know how it goes, I suspect there will be a few more issues, as shared providers hasn't received the same attention (yet) that other use cases have | 10:18 |
| *** mingyu has quit IRC | 10:18 | |
| *** sidx64 has quit IRC | 10:24 | |
| *** nicolasbock has joined #openstack-nova | 10:25 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Fix allocation_candidates not to ignore shared RPs https://review.openstack.org/533396 | 10:25 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Test alloc_cands with indirectly sharing RPs https://review.openstack.org/519601 | 10:25 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Support relay RP for allocation candidates https://review.openstack.org/533437 | 10:25 |
| *** priteau has joined #openstack-nova | 10:26 | |
| cdent | pooja_jadhav: in that ^ stack is an update version that resolves the merge conflicts, which you'll want if you're working from today's master | 10:26 |
| *** edmondsw has joined #openstack-nova | 10:26 | |
| pooja_jadhav | cdent : i have applied the patch https://review.openstack.org/#/c/533396, but facing same issue | 10:27 |
| cdent | :( | 10:27 |
| *** fanzhang has quit IRC | 10:28 | |
| *** fanzhang has joined #openstack-nova | 10:28 | |
| *** sdague has joined #openstack-nova | 10:28 | |
| pooja_jadhav | when i hit nova show <instance_uuid> then it shows error in fault section [1]http://paste.openstack.org/show/700903/ | 10:28 |
| *** phuongnh has quit IRC | 10:28 | |
| cdent | If you can write up a bug that might be the best thing at this point. I havent got a clear picture of exactly what you're doing and having the replication strategy written down in a bug will make it easier to understand | 10:29 |
| *** jmlowe has quit IRC | 10:30 | |
| cdent | ah, I hadnt understood you were using a custom resource class, that's an important bit of data. Do you have a log of the requests made to the placement service, it would be useful to see what the GET /allocation_candidartes query is | 10:30 |
| *** vivsoni has quit IRC | 10:30 | |
| cdent | pooja_jadhav: this bug may be related: https://bugs.launchpad.net/nova/+bug/1705231 | 10:31 |
| openstack | Launchpad bug 1705231 in OpenStack Compute (nova) "Placement returns no allocation candidate for request that needs both compute resources and custom shared resources" [High,Fix released] - Assigned to Chris Dent (cdent) | 10:31 |
| *** edmondsw has quit IRC | 10:31 | |
| *** esberglu has joined #openstack-nova | 10:41 | |
| *** Zames has joined #openstack-nova | 10:41 | |
| *** mingyu has joined #openstack-nova | 10:42 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Correct documentation for '[pci] passthrough_whitelist' https://review.openstack.org/552874 | 10:43 |
| stephenfin | lyarwood, sean-k-mooney: ^ | 10:43 |
| stephenfin | I'll probably look for that to be backported if all is ok | 10:43 |
| *** sidx64 has joined #openstack-nova | 10:44 | |
| *** esberglu has quit IRC | 10:45 | |
| lyarwood | stephenfin: cool yeah that would be great, will need a bug if you have time, happy to quickly write one if not, I did mean to do this yesterday :| | 10:46 |
| stephenfin | lyarwood: I'm working on the NUMA-aware vSwitch spec this morning, so if you're happy to write up said bug I'd appreciate it :) | 10:47 |
| *** sidx64 has quit IRC | 10:48 | |
| *** alexchadin has joined #openstack-nova | 10:48 | |
| *** Zames has quit IRC | 10:49 | |
| *** trinaths has quit IRC | 10:49 | |
| *** alexchadin has quit IRC | 10:51 | |
| *** mikal_ has joined #openstack-nova | 10:52 | |
| *** alexchadin has joined #openstack-nova | 10:53 | |
| *** mikal has quit IRC | 10:53 | |
| *** sidx64 has joined #openstack-nova | 10:55 | |
| *** alexchadin has quit IRC | 10:55 | |
| *** belmoreira has joined #openstack-nova | 10:56 | |
| *** cdent has quit IRC | 10:56 | |
| *** Zames has joined #openstack-nova | 10:56 | |
| *** sidx64 has quit IRC | 10:58 | |
| *** esberglu has joined #openstack-nova | 10:58 | |
| *** Zames has quit IRC | 10:59 | |
| *** Zames has joined #openstack-nova | 11:00 | |
| *** sidx64 has joined #openstack-nova | 11:01 | |
| *** esberglu has quit IRC | 11:03 | |
| *** alexchadin has joined #openstack-nova | 11:04 | |
| *** sidx64 has quit IRC | 11:09 | |
| *** janki has quit IRC | 11:10 | |
| *** sidx64 has joined #openstack-nova | 11:11 | |
| *** brault has joined #openstack-nova | 11:19 | |
| *** HW-Peter has quit IRC | 11:22 | |
| *** jmlowe has joined #openstack-nova | 11:23 | |
| *** dtantsur|afk is now known as dtantsur | 11:26 | |
| *** jmlowe has quit IRC | 11:27 | |
| *** abhishekk has quit IRC | 11:29 | |
| *** chyka has joined #openstack-nova | 11:30 | |
| *** chyka has quit IRC | 11:34 | |
| *** sambetts|afk is now known as sambetts | 11:36 | |
| *** Zames has quit IRC | 11:36 | |
| gibi | afternoon nova | 11:39 |
| * gibi was in an internal meeting all morning | 11:39 | |
| gibi | cdent: thanks for the placement doc update, I +2d it | 11:39 |
| *** janki has joined #openstack-nova | 11:43 | |
| *** ratailor has quit IRC | 11:43 | |
| *** salv-orlando has quit IRC | 11:44 | |
| *** udesale__ has quit IRC | 11:45 | |
| *** cdent has joined #openstack-nova | 11:49 | |
| *** tiendc has quit IRC | 11:52 | |
| openstackgerrit | Merged openstack/nova master: Update contributor/placement.rst to contemporary reality https://review.openstack.org/552860 | 11:57 |
| *** lucasagomes is now known as lucas-hungry | 12:03 | |
| *** tetsuro has quit IRC | 12:06 | |
| *** amodi has joined #openstack-nova | 12:07 | |
| *** pchavva has joined #openstack-nova | 12:14 | |
| *** yamamoto_ has quit IRC | 12:17 | |
| *** yamamoto has joined #openstack-nova | 12:18 | |
| *** chyka has joined #openstack-nova | 12:23 | |
| *** edmondsw has joined #openstack-nova | 12:24 | |
| *** chyka has quit IRC | 12:27 | |
| artom | bauzas, sahid, could you take a look at https://review.openstack.org/#/c/552722/ when you get a chance? It's the infamouse live migration with CPU pinning spec | 12:27 |
| *** jpena is now known as jpena|lunch | 12:27 | |
| artom | sahid, you weren't at PTG, but we basically agreed to start over, with a spec, since Nikola's patch is too hard to review/merge at this point | 12:27 |
| artom | jaypipes, ^^ dunno if you're around this early, but your input would be appreciated as well | 12:28 |
| *** mdnadeem_ has joined #openstack-nova | 12:31 | |
| *** dave-mccowan has joined #openstack-nova | 12:32 | |
| *** mdnadeem has quit IRC | 12:35 | |
| openstackgerrit | Nguyen Hai proposed openstack/nova-specs master: Enhance nova-specs webpage and clean up repo https://review.openstack.org/551802 | 12:36 |
| *** maciejjozefczyk has quit IRC | 12:37 | |
| *** maciejjozefczyk has joined #openstack-nova | 12:38 | |
| *** yamamoto has quit IRC | 12:38 | |
| *** claudiub has quit IRC | 12:39 | |
| *** yamamoto has joined #openstack-nova | 12:39 | |
| *** derekh has quit IRC | 12:41 | |
| *** yamamoto has quit IRC | 12:44 | |
| *** salv-orlando has joined #openstack-nova | 12:44 | |
| jaypipes | artom: yep, will look shortly. | 12:46 |
| jaypipes | thx for the heads up | 12:46 |
| artom | jaypipes, cheers :) | 12:47 |
| *** odyssey4me has quit IRC | 12:47 | |
| *** odyssey4me has joined #openstack-nova | 12:47 | |
| *** vladikr has joined #openstack-nova | 12:49 | |
| *** salv-orlando has quit IRC | 12:49 | |
| *** r-daneel has quit IRC | 12:53 | |
| *** yamamoto has joined #openstack-nova | 12:55 | |
| *** edmondsw_ has joined #openstack-nova | 12:55 | |
| *** mriedem has joined #openstack-nova | 12:57 | |
| *** edmondsw has quit IRC | 12:58 | |
| *** yamamoto has quit IRC | 12:59 | |
| *** alexchadin has quit IRC | 13:01 | |
| *** artom has quit IRC | 13:01 | |
| *** alexchadin has joined #openstack-nova | 13:06 | |
| *** lucas-hungry is now known as lucasagomes | 13:07 | |
| *** yamamoto has joined #openstack-nova | 13:10 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: generation in provider aggregate APIs https://review.openstack.org/548249 | 13:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: Return new provider from POST /rps https://review.openstack.org/548934 | 13:11 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Stop assuming initial provider generation is 0 https://review.openstack.org/548975 | 13:11 |
| jaypipes | efried: ^ that ready to go now? | 13:12 |
| efried | jaypipes: First two, yes. | 13:12 |
| efried | jaypipes: Quick, before edleafe's! | 13:12 |
| *** cmm_ has joined #openstack-nova | 13:13 | |
| *** sree has joined #openstack-nova | 13:13 | |
| *** yamamoto has quit IRC | 13:15 | |
| *** amoralej is now known as amoralej|lunch | 13:15 | |
| *** Tom-Tom has joined #openstack-nova | 13:19 | |
| *** lyan has joined #openstack-nova | 13:21 | |
| *** lyan is now known as Guest7641 | 13:21 | |
| edleafe | efried: no rush, working on alex_xu_'s comments | 13:22 |
| *** felipemonteiro_ has joined #openstack-nova | 13:23 | |
| *** yamamoto has joined #openstack-nova | 13:25 | |
| *** eharney has joined #openstack-nova | 13:25 | |
| *** jpena|lunch is now known as jpena | 13:27 | |
| *** edmondsw_ is now known as edmondsw | 13:27 | |
| *** pchavva has quit IRC | 13:29 | |
| *** mdnadeem has joined #openstack-nova | 13:29 | |
| *** yamamoto has quit IRC | 13:29 | |
| *** sidx64 has quit IRC | 13:31 | |
| *** pchavva has joined #openstack-nova | 13:32 | |
| *** sidx64 has joined #openstack-nova | 13:32 | |
| *** mdnadeem_ has quit IRC | 13:32 | |
| *** sahid has quit IRC | 13:36 | |
| *** yamamoto has joined #openstack-nova | 13:40 | |
| *** derekh has joined #openstack-nova | 13:40 | |
| *** yamamoto has quit IRC | 13:44 | |
| *** sridharg has quit IRC | 13:44 | |
| *** burt has joined #openstack-nova | 13:44 | |
| alex_xu_ | edleafe: the only help I can give is to review efried's patch :) | 13:44 |
| efried | hah! | 13:45 |
| *** salv-orlando has joined #openstack-nova | 13:45 | |
| *** Zames has joined #openstack-nova | 13:46 | |
| *** awaugama has joined #openstack-nova | 13:46 | |
| sar | So I had an issue where i couldn't delete an instance attached to a previously migrated volume. I get an error where it says it can't find the volume id. Turns out it doesn't update the volume_id in the json stored in block_device_mapping during volume migration. Can someone help me verify if this can be considered a bug? See around line 5656 here: https://git.openstack.org/cgit/openstack/nova/tree/nova/compute/manager.py | 13:49 |
| sar | Shouldn't there be a line such as this? : new_cinfo['volume_id'] = save_volume_id | 13:49 |
| *** crushil has joined #openstack-nova | 13:50 | |
| *** salv-orlando has quit IRC | 13:50 | |
| *** felipemonteiro_ has quit IRC | 13:51 | |
| *** amoralej|lunch is now known as amoralej | 13:52 | |
| *** Zames has quit IRC | 13:54 | |
| *** yamamoto has joined #openstack-nova | 13:54 | |
| *** yamamoto has quit IRC | 13:55 | |
| *** yamamoto has joined #openstack-nova | 13:55 | |
| *** yamamoto has quit IRC | 13:55 | |
| *** sridharg has joined #openstack-nova | 13:57 | |
| *** gbarros has joined #openstack-nova | 13:58 | |
| *** liverpooler has joined #openstack-nova | 14:00 | |
| *** esberglu has joined #openstack-nova | 14:00 | |
| edleafe | alex_xu_: should have an update soon. Until then, have at efried! | 14:01 |
| *** liverpooler has quit IRC | 14:02 | |
| *** liverpooler has joined #openstack-nova | 14:02 | |
| mriedem | gibi: i'm going through https://review.openstack.org/#/c/502306/ if you want to hold off on updating it | 14:04 |
| *** shaohe_feng has quit IRC | 14:04 | |
| cdent | thanks jaypipes for saying what you did on the low-level cache spec | 14:04 |
| jaypipes | cdent: yw | 14:05 |
| cdent | I tried to read that whitepaper that's reference before I made a judgement and dissolved in a sea of acronyms | 14:06 |
| cdent | but my gut reaction was "oh, you've got to be kidding me" | 14:06 |
| *** cdent has quit IRC | 14:07 | |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add --by-service to discover_hosts https://review.openstack.org/552691 | 14:10 |
| *** sidx64 has quit IRC | 14:10 | |
| *** sidx64 has joined #openstack-nova | 14:14 | |
| stephenfin | jaypipes: Low-level cache spec? | 14:15 |
| * stephenfin is intrigued | 14:15 | |
| *** gouthamr has quit IRC | 14:16 | |
| jaypipes | stephenfin: https://review.openstack.org/#/c/502575/1/specs/pike/approved/cache-as-a-resource-with-rdt.rst@101 | 14:17 |
| *** sahid has joined #openstack-nova | 14:18 | |
| stephenfin | eew | 14:18 |
| stephenfin | I change my mind | 14:18 |
| dansmith | I'm going tp propose a spec soon to let you reserve a single byte of physical memory | 14:18 |
| *** kholkina has quit IRC | 14:18 | |
| dansmith | hope that's cool | 14:18 |
| jaypipes | dansmith: totes. go for it. | 14:18 |
| dansmith | I've always been partial to memory location 0xdeadbeef | 14:18 |
| mriedem | jaypipes: just abandoned that spec - it was still targeting pike | 14:18 |
| jaypipes | dansmith: a single bit would be better, though. | 14:18 |
| dansmith | and I desire my byte to be stored there | 14:18 |
| ShilpaSD | stephenfin: Hi | 14:19 |
| stephenfin | ShilpaSD: o/ | 14:19 |
| ShilpaSD | stephenfin: Had one query on same topic what we discussed yesterday | 14:19 |
| mnaser | so i was working with the ODL folks and it looks like https://review.openstack.org/#/c/542738/ has their vif plugging. i dug in deeper and it looks like the unplug operation in os_vif with ovs is noop (so odl never really sees the port unplugged to change state) and then when the server is started again, it expects a network-vif-plugged event which never comes because the port is already plugged based on odl's | 14:19 |
| mnaser | logic | 14:19 |
| ShilpaSD | stephenfin: Instead of doing changes in manager to update access URL, can we add the url in novncproxy_base_url | 14:19 |
| mnaser | as this is being backported, it's breaking branch by branch unfortunately | 14:20 |
| ShilpaSD | stephenfin: novncproxy_base_url=http://<ip address>/vnc.html?path=websocikfy | 14:20 |
| mnaser | unfortunately the port type is still 'ovs' when using ODL.. should the fix be making os_vif actually unplug things rather than noop? | 14:21 |
| *** shaohe_feng has joined #openstack-nova | 14:21 | |
| jaypipes | mnaser: I will take a look at it as soon as I'm done with the cyborg demo. | 14:21 |
| mnaser | jaypipes: cool, thank you, i spent a lot of time digging around so i can point to a few things i've seen | 14:22 |
| jaypipes | cool | 14:22 |
| Kevin_Zheng | mriedem Hi saw you guys were talking about the quota issue yesterday, any conclusion? | 14:26 |
| mriedem | Kevin_Zheng: no, just that it's still a problem | 14:26 |
| openstackgerrit | Balazs Gibizer proposed openstack/nova-specs master: Network bandwidth resource provider https://review.openstack.org/502306 | 14:26 |
| gibi | mriedem: sorry | 14:26 |
| mriedem | efried: is there a spec or talk about adding a generation to https://developer.openstack.org/api-ref/placement/#update-allocations ? | 14:26 |
| mriedem | gibi: ! | 14:26 |
| gibi | mriedem: I just saw your ping | 14:27 |
| gibi | mriedem: I promise I will read your comments even if it is on older ps | 14:27 |
| mriedem | well ok then | 14:27 |
| *** salv-orlando has joined #openstack-nova | 14:27 | |
| mriedem | efried: oh i guess there is an optional generation in PUT /allocations/{consumer_id} in 1.12 | 14:28 |
| mriedem | so nvm | 14:28 |
| gibi | mriedem: sorry. I will not be available until Monday (national holiday in Hungary) and I have to leave soon | 14:29 |
| *** mlavalle has joined #openstack-nova | 14:29 | |
| Kevin_Zheng | mriedm OK, I will be intrested if we dicide to fix it | 14:29 |
| mriedem | np | 14:29 |
| mriedem | Kevin_Zheng: melwitt sounded semi interested in fixing it, so probably want to talk to her | 14:29 |
| Kevin_Zheng | Cool, good to know | 14:29 |
| efried | mriedem: No, there's nothing. | 14:30 |
| mriedem | efried: so https://developer.openstack.org/api-ref/placement/#request-microversions-1-12 is wrong? | 14:30 |
| *** moshele has quit IRC | 14:30 | |
| *** psachin has quit IRC | 14:30 | |
| Kevin_Zheng | gibi, I have a quick question about versioned notification | 14:31 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/placement/schemas/allocation.py#L85 | 14:31 |
| efried | It's ignored | 14:31 |
| efried | generation (Optional)bodyintegerA consistent view marker that assists with the management of concurrent resource provider updates. The value is ignored; it is present to preserve symmetry between read and write representations. | 14:32 |
| mriedem | oh gdi | 14:32 |
| *** Tom-Tom has quit IRC | 14:32 | |
| mriedem | ok, well, probably going to be important when both nova and neutron are changing allocatoins for the same consumer | 14:32 |
| *** alexchadin has quit IRC | 14:32 | |
| *** Tom-Tom has joined #openstack-nova | 14:32 | |
| Kevin_Zheng | gibi, I saw that InstanceActionPayload is a parent object of alot other payload objects, and seems some of the child object also got version bump when the parent object got bumped? | 14:32 |
| efried | mriedem: Yes. We talked about it in Dublin. On Wednesday IIRC. And agreed to add a generation field to the allocations table. jaypipes probably has more of it in his head. Not sure who's on the hook to do the spec/work. | 14:33 |
| mriedem | Kevin_Zheng: yes that's not new | 14:33 |
| gibi | Kevin_Zheng: if you add something to the parent then that will appeare in the children payloads therefore you need the bump | 14:33 |
| mriedem | you'll have to update all of the children | 14:33 |
| Kevin_Zheng | OMG | 14:33 |
| Kevin_Zheng | so many children | 14:33 |
| mriedem | c'mon | 14:33 |
| mriedem | climb that mountain | 14:33 |
| * mriedem inserts inspirational huawei training video speech | 14:34 | |
| gibi | Kevin_Zheng: the parent-child relationship is not visible in the serialized payload, as it only contains the child class name | 14:34 |
| gibi | Kevin_Zheng: therefore the version of the child should reflect the overall structure | 14:34 |
| Kevin_Zheng | gibi ack | 14:35 |
| gibi | Kevin_Zheng: dont worry I think the unit test will catch if you miss some of those children | 14:35 |
| *** germs has joined #openstack-nova | 14:35 | |
| *** germs has quit IRC | 14:35 | |
| *** germs has joined #openstack-nova | 14:35 | |
| Kevin_Zheng | mriedem you got trainning too, I thought it was just for us LOL | 14:35 |
| gibi | Kevin_Zheng: as the signature of the children classes will change if you add a field to the parent | 14:36 |
| Kevin_Zheng | gibi, yeah thats true | 14:37 |
| *** Tom-Tom has quit IRC | 14:37 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add 'member_of' param to GET /allocation_candidates https://review.openstack.org/552098 | 14:37 |
| edleafe | alex_xu_: ^^ now you can ignore efried | 14:37 |
| stephenfin | ShilpaSD: and that works as expected, for both noVNC 0.6 and 1.0? | 14:38 |
| *** sean-k-mooney has quit IRC | 14:38 | |
| ShilpaSD | yes, if we manage at configuration level, no need to do changes at nova-compute | 14:38 |
| stephenfin | mriedem: Thoughts on that? ^ | 14:39 |
| mriedem | stephenfin: huh? | 14:39 |
| *** suresh12 has joined #openstack-nova | 14:39 | |
| stephenfin | mriedem: This is for the breaking change in noVNC 1.0. Apparently we can set the config option to use 'vnc.html' with a parameter and this works with both noVNC 0.6 and 1.0 | 14:39 |
| stephenfin | 'vnc.html' instead of 'vnc_auto.html' for 0.6 and 'vnc_lite.html' for 1.0 | 14:40 |
| *** mvk has quit IRC | 14:40 | |
| mriedem | oh | 14:40 |
| mriedem | well that seems like the thing to do for the default then, but does that also work for 0.6? | 14:40 |
| mriedem | if that doesn't work for 0.6, then you'd be regressing the default for anyone <1.0 | 14:41 |
| stephenfin | mriedem: According to ShilpaSD, it does, yes | 14:41 |
| stephenfin | Yup, same as changing the default to 'vnc_lite.html' | 14:41 |
| mriedem | sure seems fine then, accompanied with a release note that the default is changing probably | 14:41 |
| stephenfin | Sweet | 14:41 |
| stephenfin | ShilpaSD: If you fancy making that change to the default, we can see if DevStack is happy. That will ensure we're OK with 0.6 | 14:42 |
| *** alex_xu has joined #openstack-nova | 14:42 | |
| *** sar has quit IRC | 14:43 | |
| *** danpawlik has quit IRC | 14:43 | |
| stephenfin | ShilpaSD: I already have a DevStack change up to bump noVNC 1.0. I can make this change 'Depends-on' your one | 14:43 |
| *** mrjk__ has quit IRC | 14:44 | |
| *** mrjk has joined #openstack-nova | 14:46 | |
| ShilpaSD | stephenfin: that will be great, but still one more query | 14:48 |
| stephenfin | Shoot | 14:49 |
| ShilpaSD | stephenfin: /opt/stack/nova/nova/tests/functional/api_sample_tests/api_samples/os-remote-consoles/get-vnc-console-post-resp.json.tpl....here also need to make that change? since functionaly TC using that | 14:49 |
| ShilpaSD | /opt/stack/nova/doc/api_samples/os-remote-consoles/get-vnc-console-post-resp.json | 14:49 |
| *** felipemonteiro_ has joined #openstack-nova | 14:49 | |
| stephenfin | ShilpaSD: Already done https://review.openstack.org/#/c/550173/ | 14:49 |
| stephenfin | Well, those are wrong. You can take that patch and fix it up, if you like | 14:50 |
| stephenfin | Or I'll rebase it onto whatever you do. You just need to modify nova/conf/pci.py and add a release note | 14:50 |
| *** felipemonteiro__ has joined #openstack-nova | 14:51 | |
| stephenfin | lyarwood: Regarding https://review.openstack.org/#/c/552874/, I think that's a bug in oslo_config.sphinxext. The rST is correct. | 14:51 |
| stephenfin | If I were to guess, we're not doing a nested parse | 14:51 |
| * gibi is going away back on Monday | 14:52 | |
| *** sean-k-mooney has joined #openstack-nova | 14:52 | |
| *** cdent has joined #openstack-nova | 14:52 | |
| *** shaohe_feng has quit IRC | 14:52 | |
| ShilpaSD | stephenfin: thnak you for clarification, will get back to you on what action i am taking aginst this | 14:53 |
| *** suresh12 has quit IRC | 14:54 | |
| stephenfin | (y) | 14:54 |
| sean-k-mooney | mriedem: stephenfin just looking at https://review.openstack.org/#/c/548525/1 the few runs of kuryr-kubernetes-tempest-daemon-octavia i have see so far against os-vif seam a little flaky. | 14:54 |
| *** artom has joined #openstack-nova | 14:54 | |
| sean-k-mooney | mriedem: stephenfin we may want to consider makeing it non voting if it contiues. ill keep an eye on it | 14:55 |
| *** germs has quit IRC | 14:55 | |
| *** felipemonteiro_ has quit IRC | 14:55 | |
| *** yamamoto has joined #openstack-nova | 14:55 | |
| *** hongbin has joined #openstack-nova | 14:55 | |
| *** mvk has joined #openstack-nova | 14:55 | |
| cdent | efried: re [t 1LbC] wasn't it to the consumer table? | 14:56 |
| purplerbot | <efried> mriedem: Yes. We talked about it in Dublin. On Wednesday IIRC. And agreed to add a generation field to the allocations table. jaypipes probably has more of it in his head. Not sure who's on the hook to do the spec/work. [2018-03-14 14:33:08.634568] [n 1LbC] | 14:56 |
| efried | cdent: Could be, sure. I'm not very familiar with the tables related to allocations. | 14:56 |
| efried | and don't remember the conversation exactly | 14:56 |
| efried | but I bet it's in the etherpad. | 14:56 |
| sean-k-mooney | stephenfin: mriedem for example it failed https://review.openstack.org/#/c/476612/ becase the tempest regex elminated all tests http://logs.openstack.org/12/476612/30/check/kuryr-kubernetes-tempest-daemon-octavia/576bfad/job-output.txt.gz#_2018-03-13_07_42_00_900216 and it did not publish results on https://review.openstack.org/#/c/482226/20 at all. | 14:57 |
| stephenfin | sean-k-mooney: Indeed. There was a thing on openstack-dev about it earlier in the week. Apparently some neutron (?) change has broken it | 14:58 |
| stephenfin | sean-k-mooney: Agreed though. Let's keep an eye on it | 14:58 |
| sean-k-mooney | stephenfin: well those two need other work to be mergable first but i would prefer to make it non voteing instead of blocking other changes to os-vif that may be need in the future. | 14:59 |
| *** chyka has joined #openstack-nova | 14:59 | |
| sean-k-mooney | stephenfin: its not blocking anything currently hence lets wait and see. legacy-tempest-dsvm-nova-os-vif on the other had we might want to make voteing or rework for zuul v3 | 15:00 |
| *** yamamoto has quit IRC | 15:02 | |
| *** mdnadeem has quit IRC | 15:02 | |
| Kevin_Zheng | mriedem gibi thanks alot | 15:06 |
| *** ayoung has quit IRC | 15:08 | |
| *** jbernard has quit IRC | 15:09 | |
| *** itlinux has joined #openstack-nova | 15:12 | |
| *** germs has joined #openstack-nova | 15:13 | |
| *** germs has quit IRC | 15:14 | |
| *** germs has joined #openstack-nova | 15:15 | |
| *** germs has quit IRC | 15:15 | |
| *** germs has joined #openstack-nova | 15:15 | |
| *** jbernard has joined #openstack-nova | 15:15 | |
| *** ragiman has quit IRC | 15:18 | |
| *** links has quit IRC | 15:18 | |
| *** ayoung has joined #openstack-nova | 15:20 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.openstack.org/552924 | 15:24 |
| bauzas | stephenfin: edleafe: jaypipes: dansmith: efried: you could be interested in https://review.openstack.org/552924 (NUMA topology with RPs) | 15:25 |
| bauzas | I just have a shitty docs problem that I don't see why | 15:25 |
| efried | bauzas: Added to review list. | 15:26 |
| efried | bauzas: You're having trouble getting the doc to build? | 15:26 |
| bauzas | yep | 15:26 |
| bauzas | nvm, found the issue | 15:27 |
| bauzas | PEBKAC | 15:27 |
| efried | yep, indent that graphic | 15:27 |
| bauzas | yeah, missed the code directive | 15:28 |
| efried | ...and the next one. | 15:28 |
| efried | Oh, or that. | 15:28 |
| efried | and an extra newline around L138 | 15:28 |
| efried | and 150 | 15:29 |
| efried | and 178 | 15:29 |
| efried | bauzas: With those fixed, it builds for me. | 15:29 |
| efried | bauzas: btw, not sure how you're building locally, but I use this to cut build time down to a sub-second: | 15:30 |
| *** tianhui has quit IRC | 15:30 | |
| efried | specs () | 15:30 |
| efried | { | 15:30 |
| efried | rele=${1:-rocky}; | 15:30 |
| efried | ( . .tox/docs/bin/activate || return; | 15:30 |
| efried | set -x; | 15:30 |
| efried | python setup.py build_sphinx -s doc/source/specs/$rele -c doc/source || return; | 15:30 |
| efried | find doc/build/html -type f -name '*.html' | xargs realpath ) | 15:30 |
| efried | } | 15:30 |
| stephenfin | bauzas: Also, single-backticks aren't really valid rST. They mean default role which just happens to be italics in current Sphinx. No reason that won't change going forward though (they do tend to break stuff often) | 15:30 |
| stephenfin | But that's a big nit :) Also placed on my review queue | 15:30 |
| bauzas | thanks both of you folks | 15:32 |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Spec for isolating configuration of placement database https://review.openstack.org/552927 | 15:32 |
| bauzas | stephenfin: so, for targeting links, you would recommend double-backticks ? | 15:32 |
| *** Tom-Tom has joined #openstack-nova | 15:33 | |
| *** esberglu has quit IRC | 15:33 | |
| stephenfin | bauzas: What do you mean? | 15:33 |
| bauzas | (16:30:24) stephenfin: bauzas: Also, single-backticks aren't really valid rST. T | 15:33 |
| stephenfin | Something like `xyz`_ or :role:`test` is valid. What's not valid is `xyz` | 15:33 |
| bauzas | I used single backticks for explicit targeting | 15:33 |
| bauzas | stephenfin: yeah, so I thought I did that everywhere, were have you seen a single-backtick without a link ? | 15:34 |
| *** felipemonteiro__ has quit IRC | 15:34 | |
| *** moshele has joined #openstack-nova | 15:34 | |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.openstack.org/552924 | 15:35 |
| *** felipemonteiro__ has joined #openstack-nova | 15:35 | |
| stephenfin | bauzas: Line 131 | 15:35 |
| stephenfin | 257 too | 15:35 |
| dansmith | edleafe: hey, I just noticed this went in and I'm a tad confused by it: https://review.openstack.org/#/c/539323/ | 15:36 |
| stephenfin | that's about it though, actually :) Like I said, it's the nitiest of nits | 15:36 |
| openstackgerrit | Sylvain Bauza proposed openstack/nova-specs master: Proposes NUMA topology with RPs https://review.openstack.org/552924 | 15:36 |
| edleafe | dansmith: on a call now | 15:36 |
| dansmith | edleafe: the uuid warning from o.vo has been around for a long time now and it seems like this is a bit of a heavy-handed way to resolve a warning | 15:36 |
| dansmith | edleafe: ack | 15:36 |
| dansmith | gibi: stephenfin ^ | 15:36 |
| stephenfin | dansmith: Heavy handed, perhaps, but it did resolve the issue and made sense to me | 15:37 |
| *** Tom-Tom has quit IRC | 15:38 | |
| dansmith | stephenfin: it resolves the warning in unit tests by storing an obfuscated uuid in the database which would make it really hard to examine what is going on | 15:38 |
| dansmith | that seems not sensical to me | 15:38 |
| dansmith | and would break anyone who was halfway through a mapping and then walked over this | 15:39 |
| dansmith | like someone doing an FFU | 15:39 |
| dansmith | and.. instance uuid _is_ a uuid, so if there's a warning about the format of it, maybe the warning is wrong or something else needs to change | 15:40 |
| dansmith | but munging the values (which I'm not even sure is legit uuid behavior) seems kinda silly | 15:40 |
| openstackgerrit | Merged openstack/nova master: Updated from global requirements https://review.openstack.org/552774 | 15:40 |
| dansmith | if you're not doing the rotation on all uuids then you're increasing your chances for collision, and since this doesn't (actual instance mappings have unrotated uuids, only the marker is rotated) | 15:42 |
| *** lpetrut has quit IRC | 15:42 | |
| *** sidx64 has quit IRC | 15:43 | |
| dansmith | since this is munging data in the database I think I'm going to exercise fast revert | 15:43 |
| *** tblakes has joined #openstack-nova | 15:44 | |
| stephenfin | dansmith: Gimme a sec. I'm trying to re-review this and see what my reasoning for letting it in was | 15:44 |
| cdent | bauzas: I may have missed some discussion in Dublin, but what's the different between a NUMA_CORE and a VCPU and why keep track of both of them? | 15:44 |
| *** tblakes_ has joined #openstack-nova | 15:46 | |
| bauzas | cdent: good question | 15:46 |
| bauzas | cdent: see my alternatives section | 15:46 |
| bauzas | if we shard VCPUs across NUMA nodes, then an instance spreading its cores amongst multilple NUMA nodes could have problems | 15:47 |
| dansmith | mriedem: I forget, in my revert patch should I explain the problems I think there are or just do a straight revert and then discuss on a re-propose | 15:47 |
| dansmith | ? | 15:47 |
| cdent | bauzas: yeah, saw that, but that doesn't really answer the question. If you are counting NUMA_CORES (as a separate thing) why would you record VCPU at all? | 15:47 |
| bauzas | dansmith: fast-revert and discuss later IMO | 15:47 |
| dansmith | bauzas: okay that's what I was thinking too, but it's been a while | 15:47 |
| bauzas | cdent: because operators that wouldn't care about NUMA things wouldn't then need to use a NUMA specific RC | 15:47 |
| *** esberglu has joined #openstack-nova | 15:48 | |
| *** hemna_ has joined #openstack-nova | 15:48 | |
| bauzas | dansmith: stephenfin: so I need a bit of context in order to chime in | 15:48 |
| cdent | I'll have to think on that some more. Having to track the same thing multiple times doesn't seem simple to me. It may, however, be that simple is not possible. | 15:49 |
| bauzas | cdent: np, I'll be on PTO till thurs starting EOB | 15:49 |
| dansmith | bauzas: after further examination, rotating one uuid out of a set is not a legit thing to do to a uuid and maintain uniqueness, so I think it's flawed just on that basis alone | 15:49 |
| bauzas | cdent: so take your time | 15:49 |
| cdent | roger | 15:49 |
| bauzas | cdent: that spec is maybe a strawman | 15:50 |
| *** tblakes has quit IRC | 15:50 | |
| dansmith | i.e. if your key space is 0-4, and you have keys 1, 2, 3, you can't just rotate 2, or you will end up with a conflict | 15:50 |
| bauzas | cdent: so I'm open to alternatives | 15:50 |
| dansmith | you have to rotate them all equally | 15:50 |
| cdent | cool | 15:50 |
| *** tblakes_ is now known as tblakes | 15:50 | |
| stephenfin | dansmith: So my understanding of this was that we're creating something akin to a fake InstanceMapping so we could keep track of where we were in the process | 15:50 |
| bauzas | dansmith: right, I don't like touching things | 15:50 |
| dansmith | stephenfin: that's the marker functionality, yes | 15:50 |
| bauzas | but that's not the only marker we had, right? | 15:51 |
| bauzas | like, I provided a marker IIRC for the RequestSpec migration thing | 15:51 |
| bauzas | now the code is gone, but lemme see how I did that and if that can help | 15:51 |
| stephenfin | dansmith: Right, so if were re-using the UUID of an existing instance we were going to bump into the UNIQUE constraint, as noted on line 1127 there | 15:51 |
| dansmith | bauzas: right, and also, this is storing an _actual_ uuid in this field | 15:51 |
| dansmith | bauzas: so if the warning is complaining about it, then it's wrong | 15:52 |
| stephenfin | and to work around that, alaski put in a patch that munged the instance UUID to avoid said constraint | 15:52 |
| stephenfin | dansmith: UUIDs need to have hyphens in them, no? | 15:52 |
| *** tblakes has quit IRC | 15:52 | |
| bauzas | aaaaah I see | 15:52 |
| stephenfin | https://en.wikipedia.org/wiki/Universally_unique_identifier#Format | 15:53 |
| bauzas | stephenfin: the RFC doesn't really mention that IIRC | 15:53 |
| bauzas | it's just a python uuid thing IIRC | 15:53 |
| dansmith | stephenfin: ah, I see what's going on | 15:53 |
| bauzas | stephenfin: https://tools.ietf.org/html/rfc4122#page-5 | 15:53 |
| bauzas | oops https://tools.ietf.org/html/rfc4122#section-4.1 | 15:53 |
| dansmith | stephenfin: it does't change the fact that we're rotating one uuid in a given namespace, and storing it in the DB, just to get past a uuid format warning | 15:54 |
| mriedem | dansmith: i always try to explain why i'm reverting something | 15:54 |
| mriedem | because the later patch might never come | 15:54 |
| dansmith | mriedem: okay, I just didn't want to argue over the rationale and delay the revert, but fair enough | 15:54 |
| stephenfin | dansmith: It seemed no worse than stripping out the spaces. It was still very much a reversible operation | 15:54 |
| stephenfin | However, you're suggesting that it's not actually valid thing to do. I didn't know that and that makes a revert the right thing to do, if so | 15:55 |
| dansmith | stephenfin: it's completely worse because (a) it could create a conflict, (b) it breaks the format that people in the middle of this operation may have already stored and (c) it's much harder to manually inspect if there is a problem | 15:55 |
| cfriesen | cdent: for the VCPU vs NUMA_CORES thing, also bear in mind the proposed specs for shared/dedicated instances on the same host, and even on the same instance, as well as sahid's spec to run the emulator threads on a separate pool of host pCPUs | 15:55 |
| stephenfin | Are UUID conflicts a thing? Aren't there, like, a bajillion permutations? | 15:55 |
| cdent | cfriesen: yeah, it makes my head swim | 15:56 |
| cfriesen | cdent: make that shared/dedicated vCPUs within the same instance | 15:56 |
| bauzas | okay, so I marked the last Requestspec I checked by using a NULL UUID for the instance https://github.com/openstack/nova/commit/09f2d4d5ec3a699176d70c2407ced0ce7cd58197#diff-cbbdc4d7c140314a7e0b2d97ebcd1f9c | 15:56 |
| stephenfin | That was noted in the commit message and I agreed with it https://review.openstack.org/#/c/539323/5//COMMIT_MSG@30 | 15:56 |
| dansmith | stephenfin: but it's wrong | 15:56 |
| bauzas | now, I need to understand why the marker is different for instance_mappings | 15:56 |
| stephenfin | :) | 15:56 |
| cfriesen | cdent: if we could figure out an efficient generic way to do dynamic allocation of pCPUs for shared vs dedicated it would simplify things, but it seems too complicated to do generically | 15:56 |
| bauzas | cfriesen: context is https://review.openstack.org/#/c/552924/ | 15:57 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Revert "Make the InstanceMapping marker UUID-like" https://review.openstack.org/552937 | 15:58 |
| *** yamamoto has joined #openstack-nova | 15:58 | |
| dansmith | bauzas: mriedem stephenfin ^ | 15:58 |
| bauzas | cfriesen: cdent: what I'd like is to keep the root RP responsible for the general resource classes for upgrade and consistency purposes, and just add NUMA-specific resources to the children | 15:58 |
| bauzas | the fact that the operator has to handle flavors accordingly (ie. having a NUMA_CORES value that matches with the flavor VCPU) is something important to note, but not a big deal | 15:59 |
| *** lajoskatona has quit IRC | 16:00 | |
| *** felipemonteiro_ has joined #openstack-nova | 16:01 | |
| *** felipemonteiro_ has quit IRC | 16:02 | |
| *** suresh12 has joined #openstack-nova | 16:02 | |
| bauzas | stephenfin: see https://docs.openstack.org/nova/latest/contributor/policies.html#reverts-for-retrospective-vetos | 16:02 |
| *** yamahata has joined #openstack-nova | 16:03 | |
| stephenfin | bauzas: Good to know :) | 16:03 |
| *** felipemonteiro_ has joined #openstack-nova | 16:03 | |
| *** diga has joined #openstack-nova | 16:04 | |
| *** yamamoto has quit IRC | 16:04 | |
| cfriesen | bauzas: so what would the extra-specs look like? would we drop the existing "dedicated" cpu policy? | 16:04 |
| *** arvindn05 has quit IRC | 16:04 | |
| *** felipemonteiro__ has quit IRC | 16:04 | |
| dansmith | stephenfin: wanna discuss why #1 is an issue? | 16:04 |
| cfriesen | bauzas: and what about the "isolate" hyperthreading policy, how would we handle the sibling LCPUs? | 16:05 |
| dansmith | or are you saying it's so unlikely that you don't care? | 16:05 |
| bauzas | cfriesen: I imagine some time being where two things would continue to work | 16:05 |
| bauzas | cfriesen: I'm not trying to boil the ocean and have all the NUMA policies be done in Placement | 16:05 |
| *** tbachman has joined #openstack-nova | 16:06 | |
| stephenfin | dansmith: Sure. I'd been going under the assumption that UUID conflicts were night-on impossible. Shuffling bits around on an existing UUID wouldn't change that | 16:06 |
| *** felipemonteiro__ has joined #openstack-nova | 16:06 | |
| *** Tom-Tom has joined #openstack-nova | 16:06 | |
| * edleafe is off the call and reading back | 16:06 | |
| cfriesen | bauzas: agreed, I just don't have a good picture of what the extra specs would look like when asking for dedicated cpus | 16:07 |
| dansmith | stephenfin: https://en.wikipedia.org/wiki/Universally_unique_identifier#Collisions | 16:07 |
| dansmith | stephenfin: "collisions can occur only when an implementation varies from the standards, either inadvertently or intentionally" | 16:07 |
| *** suresh12 has quit IRC | 16:07 | |
| dansmith | stephenfin: mutating one uuid (even predictably) within a given namespace of others that are not so mutated would amount to a different implementation right? | 16:07 |
| bauzas | dansmith: right, like I said, nothing in the RFC tells "-" is mandatory AFAIK | 16:07 |
| dansmith | bauzas: well, there's also that | 16:07 |
| dansmith | stephenfin: uuids boil down to a very large number space | 16:08 |
| edleafe | dansmith: so is your main concern the possibility of collisions? | 16:08 |
| *** arvindn05 has joined #openstack-nova | 16:08 | |
| dansmith | stephenfin: if you reduce that to a human-conceivable range and then populate it with some values, rotating one within the space, you can easily cause a conflict | 16:08 |
| dansmith | edleafe: my main concerns are in the revert.. collisions are one aspect | 16:08 |
| bauzas | cfriesen: from https://docs.openstack.org/nova/pike/admin/flavors.html#extra-specs-numa-topology | 16:09 |
| dansmith | edleafe: totally agree it's very unlikely but it's fundamentally a wrong thing to do to mutate one like that | 16:09 |
| *** felipemonteiro_ has quit IRC | 16:09 | |
| arvindn05 | mriedem: wanted to discuss your review on https://review.openstack.org/#/c/541507/. Are you going to be online an hr from now? | 16:10 |
| edleafe | dansmith: just to be clear: it wasn't to pretty up the unit tests. When o.vo switches from warning to raising, it will break this code | 16:10 |
| stephenfin | dansmith: I imagine it would, yes | 16:10 |
| edleafe | And adding spaces to a UUID is worse munging, IMO | 16:11 |
| stephenfin | and I certainly can't prove it wouldn't | 16:11 |
| mriedem | arvindn05: yes | 16:11 |
| stephenfin | Yeah, that was my thinking ^ | 16:11 |
| stephenfin | If we're going to munge, do it right | 16:11 |
| *** Tom-Tom has quit IRC | 16:11 | |
| dansmith | edleafe: which may never happen, if you look at the discussion around doing the uuid format checking a couple years ago.. | 16:11 |
| stephenfin | bauzas: What was this about using a null UUID as the marker? | 16:11 |
| arvindn05 | mriedem: thanks! | 16:11 |
| dansmith | stephenfin: edleafe: but changing dashes to spaces doesn't change the unique elements of the uuid, it only changes the uniqueness of the string as a SQL hack | 16:11 |
| bauzas | stephenfin: I was walking over the RequestSpec tablre | 16:12 |
| dansmith | using the null uuid is a completely legit way to do this, as bauzas did for reqspec | 16:12 |
| dansmith | but it doesn't help as much in this case because of where the constraints lie | 16:12 |
| cfriesen | bauzas: I understand the current extra specs, just wasn't sure what it would look like with the placement stuff added to it. | 16:13 |
| *** tbachman has quit IRC | 16:13 | |
| openstackgerrit | Chris Dent proposed openstack/nova-specs master: Spec for isolating configuration of placement database https://review.openstack.org/552927 | 16:14 |
| bauzas | dansmith: yeah, I'm trying to load again the instance mapping context in mind | 16:15 |
| *** r-daneel has joined #openstack-nova | 16:15 | |
| bauzas | and why it has to be different from my walkthrough over reqspec | 16:15 |
| dansmith | bauzas: instance mapping is storing the uuids of the instances, so it can't store a duplicate one since there is a unique constraint on that column | 16:15 |
| * bauzas looks at code | 16:15 | |
| dansmith | there's no room inside it to stash the uuid elsewhere and use the null uuid as the marker key | 16:16 |
| bauzas | disclaimer: I have goblins at home that make noise, I need to take my Bose headset | 16:16 |
| *** zhaochao has quit IRC | 16:18 | |
| bauzas | dansmith: mmmm, I was just considering the Nul UUID for storing the last RequestSpec record I was walking thru | 16:20 |
| *** felipemonteiro__ has quit IRC | 16:20 | |
| bauzas | now, I'm looking at instance_mappings | 16:20 |
| *** udesale has joined #openstack-nova | 16:20 | |
| dansmith | bauzas: you were storing the instance uuid inside a blob field, which was not required to be unique (nor would be) and thus it didn't conflict with the actual reqspec for the instance | 16:22 |
| *** diga has quit IRC | 16:22 | |
| dansmith | bauzas: and using the nil uuid to find the marker each time | 16:22 |
| bauzas | yeah, also because I was wrong 5 mins ago | 16:22 |
| dansmith | in instance mapping, we can't store the instance's uuid exactly again because it's a UC field | 16:23 |
| bauzas | I wasn't walking over reqspec, but rather over the instances table | 16:23 |
| bauzas | right | 16:23 |
| *** Tom-Tom has joined #openstack-nova | 16:23 | |
| bauzas | dansmith: I wasn't storing the instance field, I was storing the request spec of the last instance I checkedc | 16:24 |
| dansmith | right | 16:24 |
| *** tbachman has joined #openstack-nova | 16:24 | |
| bauzas | now, I'm looking at the instance mappings migration script | 16:24 |
| *** tbachman has quit IRC | 16:24 | |
| dansmith | we could have used the nil uuid here and then stashed the instance's real uuid in the project field or something like that, but that would be rather nasty as well and could have affected runtime in other ways | 16:24 |
| dansmith | and, this is done and in people's systems | 16:25 |
| bauzas | right | 16:26 |
| *** udesale has quit IRC | 16:26 | |
| bauzas | now the thing is done | 16:26 |
| cdent | edleafe: is member_of is a state of ready for review? | 16:26 |
| cdent | s/is/in/ | 16:26 |
| bauzas | gibi: so, I just saw https://github.com/openstack/oslo.versionedobjects/commit/0e3526710f67b3b4ebab60864ea060fa9caf9537 | 16:28 |
| *** Tom-Tom has quit IRC | 16:28 | |
| bauzas | gibi: like I said earlier, I bet that valid UUIDs with spaces instead of hypens are valid per-RFC | 16:28 |
| bauzas | hyphens | 16:28 |
| mriedem | i believe the gibster is currently celebrating the national holiday of the rubik's cube | 16:29 |
| *** andreas_s has quit IRC | 16:29 | |
| edleafe | cdent: yep | 16:29 |
| dansmith | ugh | 16:29 |
| melwitt | dansmith, mriedem, tssurya: I could use your eyeballs on this cells session recap to add/correct anything I might have missed before I send it to the dev ML https://etherpad.openstack.org/p/nova-ptg-rocky-cells-summary | 16:29 |
| dansmith | bauzas: that's really unfortunate | 16:29 |
| *** andreas_s has joined #openstack-nova | 16:30 | |
| cdent | thanks edleafe | 16:30 |
| *** AlexeyAbashkin has quit IRC | 16:30 | |
| bauzas | dansmith: I need some tests on my box | 16:30 |
| bauzas | dansmith: but I think o.vo badly coerces, that's it | 16:31 |
| dansmith | bauzas: hmm? | 16:31 |
| dansmith | bauzas: it should only be emitting a warning (now error) if the format doesn't match | 16:31 |
| dansmith | bauzas: making it required formatting would be breaking our RPC API | 16:31 |
| bauzas | dansmith: I'm just saying that '52ec5cae 1654 42ad bc38 ebab73fbb161' is a valid UUID | 16:32 |
| bauzas | dansmith: so o.vo shouldn't complain at all | 16:32 |
| dansmith | bauzas: ah, about that I seee | 16:32 |
| dansmith | bauzas: well, I was against enforcing any one of the many ways to write a uuid in the first place | 16:33 |
| dansmith | the warning was the compromise | 16:33 |
| dansmith | melwitt: looks okay to me | 16:33 |
| melwitt | cool, thanks | 16:33 |
| bauzas | dansmith: right, I remember the early and shiny days of nova/objects/fields.py and the UUID() field type :) | 16:33 |
| dansmith | yeah | 16:34 |
| tssurya | melwitt: did a small change, otherwise looks good to me | 16:34 |
| melwitt | sweet, thanks | 16:35 |
| bauzas | dansmith: stephenfin: gibi: so I'm wrapping my head around http://paste.openstack.org/show/700970/ | 16:36 |
| bauzas | because this is wrong | 16:36 |
| dansmith | it's opinionated | 16:36 |
| stephenfin | bauzas: I think the RFC is wrong | 16:37 |
| stephenfin | :) | 16:37 |
| bauzas | it says 16 octets, period. | 16:37 |
| dansmith | bauzas: note it allows removing the dashes :) | 16:37 |
| dansmith | bauzas: because it thinks that's okay :) | 16:37 |
| dansmith | which we could also have done | 16:37 |
| bauzas | we could have done many things | 16:39 |
| stephenfin | bauzas: It didn't matter much before anyway since we were undoing it. This will only start to bite us if/when o.vo decides to make that warning an error https://github.com/openstack/nova/blob/fd59fbd4d1914d2adf35a85435ba4aa433f082cd/nova/cmd/manage.py#L1171 | 16:39 |
| bauzas | but I'm trying to see how we could better coerce in o.vo so that would make both not changing the DB, and make edleafe and stephenfin happy | 16:40 |
| edleafe | bauzas: I really don't care | 16:40 |
| dansmith | stephenfin: that would (a) be a change to our (and others') RPC APIs, but also (b) we could easily handle this in _from_db_obj(), or by doing the migration process with the low-level routines instead of objects | 16:40 |
| edleafe | I was just trying to fix a potential issue | 16:40 |
| bauzas | \o/ | 16:40 |
| bauzas | I'm litterally 20 mins away from a long holiday period | 16:40 |
| bauzas | would those 20 mins well spent in fixing that then ? | 16:41 |
| edleafe | but spaces in a UUID are not valid. Removing the dashes is fine | 16:41 |
| *** crushil has quit IRC | 16:41 | |
| bauzas | c'on | 16:41 |
| bauzas | it's a *string* | 16:41 |
| dansmith | a UUID is a number | 16:41 |
| dansmith | the string representation of it can be many things | 16:41 |
| dansmith | microsoft encloses them in {} to make them stand out | 16:41 |
| bauzas | how the string translates to an hex is something fine even with spaces | 16:41 |
| *** gjayavelu has joined #openstack-nova | 16:42 | |
| bauzas | yeah | 16:42 |
| *** yamahata has quit IRC | 16:42 | |
| edleafe | hey, I wanted to store all uuids are 128-bit integers, but got out-voted by the human-readable people | 16:42 |
| edleafe | s/are/as | 16:42 |
| *** tbachman has joined #openstack-nova | 16:43 | |
| bauzas | edleafe: it's comprehensive | 16:43 |
| bauzas | edleafe: but the o.vo coercing method shouldn't care at all about the formatting | 16:43 |
| bauzas | it should just assume Good Faith (c) | 16:44 |
| cfriesen | on a totally different topic...does nova wait to ensure vifs are actually plugged when doing a live migration? I see it calling self.virtapi.wait_for_instance_event() on instance spawn and cold migration, but not for live. I assume the flow is somewhat different? | 16:46 |
| *** janki has quit IRC | 16:47 | |
| stephenfin | bauzas: Before you go, fancy pushing these two patches through? https://review.openstack.org/#/c/385071 | 16:47 |
| stephenfin | Additional shuffling things around/adding docstring patches | 16:47 |
| bauzas | my review stats are poor this week | 16:47 |
| bauzas | thanks to the NUMA spec | 16:47 |
| *** tbachman has quit IRC | 16:48 | |
| *** tbachman has joined #openstack-nova | 16:48 | |
| bauzas | (and the f*** tax-credit document I had to write) | 16:48 |
| *** andreas_s has quit IRC | 16:48 | |
| stephenfin | bauzas: No better time, in that case | 16:48 |
| bauzas | https://docs.python.org/2/library/uuid.html#uuid.UUID "When a string of hex digits is given, curly braces, hyphens, and a URN prefix are all optional.' | 16:48 |
| bauzas | so, yeah, really the space carries a lot more, but meh | 16:49 |
| dansmith | tssurya: ah, yeah, kudos for spotting it in the initial patch :) | 16:49 |
| *** andreas_s has joined #openstack-nova | 16:50 | |
| bauzas | dansmith: planning to do a Cells meeting in 10 mins ? | 16:50 |
| dansmith | yar | 16:50 |
| bauzas | cool, I can attend it for once \o/ | 16:50 |
| dansmith | bauzas: I thought you were leaving in 20 minutes? :) | 16:50 |
| bauzas | for the first time since 6 months I can attend a cells meeting, I won't skip it | 16:51 |
| dansmith | heh okay | 16:51 |
| bauzas | if I need to leave, I'll | 16:51 |
| dansmith | bauzas: you will leave only if I dismiss you! | 16:51 |
| bauzas | fine, I'll tell my children I can't go to Disneyland because of you | 16:52 |
| * dansmith nods | 16:52 | |
| bauzas | they'll understaznd | 16:52 |
| dansmith | dansmith -- keeping children from happiness since 1981 | 16:52 |
| bauzas | heh | 16:52 |
| *** tbachman has quit IRC | 16:53 | |
| *** suresh12 has joined #openstack-nova | 16:54 | |
| *** andreas_s has quit IRC | 16:54 | |
| openstackgerrit | Eric Berglund proposed openstack/nova master: PowerVM Driver: Snapshot https://review.openstack.org/543023 | 16:55 |
| openstackgerrit | Dan Smith proposed openstack/nova master: Add --by-service to discover_hosts https://review.openstack.org/552691 | 16:59 |
| *** yamamoto has joined #openstack-nova | 16:59 | |
| *** suresh12 has quit IRC | 17:00 | |
| *** suresh12 has joined #openstack-nova | 17:00 | |
| dansmith | melwitt: mriedem tssurya bauzas cells meeting? | 17:01 |
| *** sapd_ has joined #openstack-nova | 17:01 | |
| mriedem | melwitt: comments in your etherpad | 17:03 |
| *** suresh12 has quit IRC | 17:03 | |
| *** Tom-Tom has joined #openstack-nova | 17:03 | |
| *** jamesdenton has joined #openstack-nova | 17:04 | |
| *** sapd has quit IRC | 17:05 | |
| *** yamamoto has quit IRC | 17:05 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: DNM: Demo code for microversion parse extraction https://review.openstack.org/550265 | 17:06 |
| arvindn05 | mriedem: i've added comments to the review | 17:06 |
| cdent | jaypipes: if you like this https://review.openstack.org/#/c/159382/ (multi workers for scheduler) can you kick it in. Seems like one of those things we'd like to exercise for as long as possible | 17:07 |
| arvindn05 | mriedem: i think the only change would be to remove the workitem for ImageExtraSpecsFilter | 17:07 |
| stephenfin | mriedem: Gerrit keeps scrolling up when I try to reply to comments. Did you have a workaround for that? | 17:08 |
| *** ralonsoh has quit IRC | 17:08 | |
| *** Tom-Tom has quit IRC | 17:08 | |
| mriedem | stephenfin: i've noticed that today again too - the fix used to be to change the render setting to 'slow' | 17:08 |
| mriedem | arvindn05: in the cells meeting atm | 17:08 |
| *** suresh12 has joined #openstack-nova | 17:11 | |
| jaypipes | cdent: done | 17:12 |
| cdent | thanks | 17:12 |
| *** claudiub has joined #openstack-nova | 17:14 | |
| *** yamahata has joined #openstack-nova | 17:15 | |
| *** gbarros has quit IRC | 17:16 | |
| cfriesen | cdent: jaypipes: I'm nervous about defaulting to multiple workers...seems like a good way to hit races even with placement | 17:17 |
| *** gbarros has joined #openstack-nova | 17:17 | |
| *** suresh12 has quit IRC | 17:17 | |
| cdent | cfriesen: a) how?, b) that's why we're merging early | 17:17 |
| *** pcaruana has quit IRC | 17:18 | |
| openstackgerrit | Stephen Finucane proposed openstack/nova-specs master: Add 'numa-aware-vswitches' spec https://review.openstack.org/541290 | 17:19 |
| cfriesen | cdent: numa resources aren't allocated until you actually hit the compute node, so can fail late. Also, do we model server group policies in placement currently? | 17:19 |
| cfriesen | cdent: in order to fix server group policy stuff we had to serialize scheduling of instances in the same server group, otherwise we hit races even with just a single scheduler worker. | 17:19 |
| jaypipes | cfriesen: no, we do not model server group policies in placement. | 17:21 |
| *** ayoung has quit IRC | 17:21 | |
| *** gbarros has quit IRC | 17:21 | |
| cfriesen | cdent: jaypipes: the problem with server groups is that the group membership isn't updated until the instance actually hits the node, so there's a big window from when the scheduler made the decision until the membership changes | 17:21 |
| cfriesen | (in the DB) | 17:22 |
| *** moshele has quit IRC | 17:22 | |
| cfriesen | sorry, not group membership but the list of compute nodes being used by the group members | 17:22 |
| jaypipes | cfriesen: yes, that's group membership. | 17:22 |
| *** moshele has joined #openstack-nova | 17:23 | |
| jaypipes | cfriesen: so because of a crappy affinity implementation and crappy numa resource tracking, we'll continue to slow down the rest of the world... | 17:23 |
| jaypipes | cfriesen: can't we tell folks using that functionality to run a single worker? | 17:24 |
| sean-k-mooney | cfriesen: defulting to muliple works has other issue. like we used to hit the db max conncetion limits because several service in openstack defualted to use multiple works for things and defulted to 1 worker per cpu. | 17:24 |
| cfriesen | jaypipes: just pointing out that this could cause unexpected races if it's enabled by default. We might want to put something in the release notes. | 17:24 |
| cdent | also, if the aforementioned serialization is already present, will it help? | 17:25 |
| *** Swami has joined #openstack-nova | 17:25 | |
| jaypipes | sean-k-mooney: that's unrelated. | 17:25 |
| cfriesen | cdent: I don't think that serialization is upstream yet. How would we serialize across multiple workers? | 17:25 |
| *** moshele has quit IRC | 17:25 | |
| sean-k-mooney | jaypipes: proably i am just skimming the scoll back now | 17:25 |
| cdent | cfriesen: ah, sorry, I had misunderstood which "we" you meant :) | 17:26 |
| sean-k-mooney | i was in meeting all day up until this point | 17:26 |
| *** gbarros has joined #openstack-nova | 17:26 | |
| jaypipes | cfriesen: a single nova boot request is only handled by a single worker, no? the case you're worrying about is multiple clients calling nova boot with the same server group. | 17:27 |
| jaypipes | cfriesen: as for the NUMA issues, I don't think that changing to multiple workers will make a difference in the number of retries that happen. | 17:27 |
| sean-k-mooney | jaypipes: or perhaps the nova multi boot support we you say boot x instance of y flavour on network z ? | 17:27 |
| jaypipes | sean-k-mooney: I don't understand how that's relevant? | 17:28 |
| jaypipes | sean-k-mooney: that would be handled in a single thread. | 17:28 |
| jaypipes | sean-k-mooney: the only situation cfriesen is worried about is when multiple nova boot requests involving the same server group were executed simultaneously. | 17:29 |
| *** awaugama_ has joined #openstack-nova | 17:29 | |
| sean-k-mooney | jaypipes: i was wondering if that was a single boot request form the api point of view or x independet ones and a client feature | 17:29 |
| jaypipes | sean-k-mooney: a single nova boot is a single thread of execution. | 17:29 |
| sean-k-mooney | jaypipes: ya that makes sense. and nova boot --min 3 --max 3 --server-group... is considered a singel boot request | 17:30 |
| sean-k-mooney | jaypipes: so the only race would be if two client tried to boot servers in the same group concureently without the server group already having running instances | 17:31 |
| *** awaugama has quit IRC | 17:32 | |
| jaypipes | sean-k-mooney: yes, that is considered a single boot request. | 17:32 |
| jaypipes | sean-k-mooney: almost. the only race is two clients concurrently attempting to add instances to the same server group (regardless of whether the server group has members). and that is a situation I find pretty rare and not worth shooting the rest of the world in the foot for. | 17:33 |
| cfriesen | jaypipes: the scenario I'm worried about is where two instances race to schedule and get put onto the same compute node, but then one of them claims a mix of resources that causes the other to fail it's resource allocation. With a single sched worker this is less likely (though still possible). | 17:35 |
| jaypipes | cfriesen: unless those are NUMA resources, it's not possible to do that. | 17:35 |
| mriedem | arvindn05: ok what's up | 17:36 |
| cfriesen | jaypipes: yes, numa resources. CPUs, hugepages, PCI devices with strict affinity | 17:36 |
| *** Tom-Tom has joined #openstack-nova | 17:37 | |
| mriedem | arvindn05: oh i'll read your replies | 17:37 |
| cfriesen | I'm totally fine with the change to enable multiple workers, I just thing we might want to mention in the release notes that it could increase races in some cases. | 17:37 |
| bauzas | jaypipes: cfriesen: I'm totally up for deprecating https://developer.openstack.org/api-ref/compute/#create-multiple-servers y'know | 17:39 |
| melwitt | mriedem: on this bp, when you say you'd like to see the proposed code for deleting a server, did you mean you want to wait for proposed code before approving the bp? https://blueprints.launchpad.net/nova/+spec/add-server-group-remove-member-notifications | 17:39 |
| bauzas | it creates more problems than it solves | 17:39 |
| cfriesen | jaypipes: for server groups there's also the case where you resize/migrate/evacuate instances in a server group at the same time, or at the same time a new instance is created. I don't think we have late validation for all those scenarios. | 17:39 |
| bauzas | and when you say --min 1 --max 5, you'd expect that if you have room for 1, then only one would be created and 4 in ERROR, but that's not the case | 17:40 |
| cfriesen | bauzas: me too. :) but last time I brought it up people wanted to keep it. | 17:40 |
| mriedem | melwitt: kind of yeah | 17:40 |
| bauzas | because min/max are only relevant wrt quotas | 17:40 |
| cfriesen | bauzas: actually I'd expect that 1 would be created and the other 4 would be like they never existed | 17:40 |
| arvindn05 | mriedem: thanks....any questions for me? | 17:40 |
| bauzas | cfriesen: that's absolutely not the current behaviour | 17:40 |
| melwitt | mriedem: okay, I'm cool with that. just wanted to make sure I understood | 17:40 |
| cfriesen | bauzas: I know, but it should be given how it's documented in the API | 17:41 |
| mriedem | arvindn05: not yet, still reading | 17:41 |
| bauzas | the current behaviour is that if you asked for 10 instances but your quota only tells 2 left, then it will just check that | 17:41 |
| *** tidwellr has joined #openstack-nova | 17:41 | |
| arvindn05 | mriedem: great....just let me know when you have questions. | 17:41 |
| bauzas | but honestly, who cares ? | 17:41 |
| mriedem | bauzas: heh "Error handling for multiple create is not as consistent as for single server create, and there is no guarantee that all the servers will be built. This call should generally be avoided in favor of clients doing direct individual server creates." | 17:41 |
| mriedem | so actually, | 17:41 |
| *** Tom-Tom has quit IRC | 17:41 | |
| mriedem | concurrent creates is actually a problem for the affinity scenarios | 17:41 |
| mriedem | but not a single multi-create request | 17:41 |
| mriedem | damned if you do, damned if yo udon't | 17:42 |
| bauzas | I'm just saying that the "minimum" value is useless | 17:42 |
| bauzas | you ask for a max of 10, the scheduler will try to find you room for 10, or kick all of them | 17:42 |
| mriedem | maybe we should amend that to say, "unless of course you're creating servers in a server group, then because of race issues we have'nt fixed yet, you should use multi-create" | 17:42 |
| cfriesen | bauzas: and it shouldn't kick all of them if some of them pass | 17:43 |
| bauzas | cfriesen: I'm not sure | 17:43 |
| bauzas | cfriesen: it's a capacity problem | 17:43 |
| cfriesen | bauzas: the user has said "give me as many instances as you can, up to a max of 10" | 17:43 |
| bauzas | and we shouldn't leak the capacity to the user | 17:43 |
| mriedem | how is the min useless? give me at least 2, but 10 if you can | 17:43 |
| bauzas | mriedem: the "if you can" is only quota-wise | 17:43 |
| cfriesen | bauzas: no, it's in the boot request | 17:44 |
| *** imacdonn has quit IRC | 17:44 | |
| bauzas | cfriesen: but the info we give to the scheduler is "how many the user asked" | 17:44 |
| *** sree has quit IRC | 17:44 | |
| *** imacdonn has joined #openstack-nova | 17:44 | |
| bauzas | cfriesen: not "how many the user is agreeing to only have" | 17:44 |
| mriedem | also depends on the port quota, don't forget | 17:44 |
| bauzas | yeah | 17:45 |
| cfriesen | bauzas: I totally agree it's all messed up. but the API describes it as the min/max nubmer of servers to be created | 17:45 |
| bauzas | the API docs are wrong | 17:45 |
| *** sree has joined #openstack-nova | 17:45 | |
| cfriesen | the API docs are by definition correct, the implementation is wrong. :) | 17:45 |
| cfriesen | the user wants at least 2 and at most 10 instances. If the quota is 4, we should give them 4 | 17:45 |
| bauzas | that's an interesting PoV | 17:45 |
| cfriesen | If we can only schedule 3, we should give them 3 | 17:45 |
| mriedem | i'm pretty sure we've said in the past that the docs don't define the api | 17:46 |
| dansmith | cfriesen: I think the actual behavior, which people may have built dependencies on, is the canonical thing | 17:46 |
| mriedem | the current behavior defines the api | 17:46 |
| dansmith | right | 17:46 |
| mriedem | right | 17:46 |
| mriedem | right | 17:46 |
| dansmith | right | 17:46 |
| melwitt | right | 17:46 |
| mriedem | right | 17:46 |
| bauzas | right | 17:46 |
| bauzas | right | 17:46 |
| bauzas | right | 17:46 |
| dansmith | (man we're dorks) | 17:46 |
| mriedem | remember the docs of yore for the compute api were written by people that didn't actually code up nova api | 17:46 |
| *** moshele has joined #openstack-nova | 17:46 | |
| melwitt | I think we've said in the past that it makes more sense for the --min to be honored if we can but if we change that, we have to do it with a microversion | 17:46 |
| mriedem | and until sdague lifted them in tree they were all sorts of wrong | 17:46 |
| mriedem | and still are in parts | 17:47 |
| *** dtantsur is now known as dtantsur|afk | 17:47 | |
| bauzas | anyway, time to say goodbye | 17:47 |
| mriedem | adieu | 17:47 |
| cfriesen | have fun | 17:47 |
| *** awaugama has joined #openstack-nova | 17:48 | |
| bauzas | "adieu" has a very strong meaning of a final goodbye :) | 17:48 |
| bauzas | I just hope to be back in 5 days :) | 17:48 |
| cfriesen | au revoir | 17:48 |
| *** tssurya has quit IRC | 17:48 | |
| cfriesen | for what it's worth, it seems odd to say that nobody can trust our published API specification, and instead they have to observe the current behaviour. | 17:49 |
| *** sree has quit IRC | 17:50 | |
| cfriesen | but I get the argument about people already depending on the current behaviour | 17:50 |
| *** itlinux has quit IRC | 17:50 | |
| *** awaugama_ has quit IRC | 17:50 | |
| *** sar has joined #openstack-nova | 17:52 | |
| *** claudiub|2 has joined #openstack-nova | 17:53 | |
| *** moshele has quit IRC | 17:54 | |
| melwitt | I wonder if it only behaves that way for quota. like, what happens if you do --min 2 --max 10 and there's only compute capacity for 2. I wonder if that would pass scheduling and give back only 2 instances | 17:54 |
| dansmith | cfriesen: I think it's odd to say that we'd jump through hoops which might be very difficult to implement something the way someone guessed it may have worked long ago | 17:54 |
| dansmith | ...just because they put that in a doc | 17:54 |
| mriedem | arvindn05: ok thanks for the clarifications. replies inline for what i'd like to see changed, but it should be trivial | 17:55 |
| *** claudiub has quit IRC | 17:55 | |
| mriedem | cfriesen: if the docs are inaccurate, let's clean up the docs | 17:55 |
| mriedem | coincidentally i was just looking at https://bugs.launchpad.net/nova/+bug/1684261 again | 17:55 |
| openstack | Launchpad bug 1684261 in OpenStack Compute (nova) "AggregateImagePropertiesIsolation example doesn't actually indicate how it works" [Low,Confirmed] | 17:55 |
| arvindn05 | mriedem: awesome...will review them and let you know | 17:56 |
| mriedem | would be really nice if someone would take on fixing the doc for that filter | 17:57 |
| *** wolverineav has joined #openstack-nova | 17:57 | |
| *** links has joined #openstack-nova | 17:57 | |
| *** itlinux has joined #openstack-nova | 17:58 | |
| *** suresh12 has joined #openstack-nova | 17:58 | |
| arvindn05 | mriedem: sure. Updating the docs should be straitforward...will look into it | 17:58 |
| mriedem | famous, last, words | 17:59 |
| arvindn05 | mriedem: :) | 17:59 |
| cfriesen | there's a truth table for that filter in https://review.openstack.org/#/c/381912/17/specs/rocky/approved/strict_isolation_of_group_of_hosts_for_image.rst | 18:00 |
| cfriesen | might be handy to reference when reworking the docs | 18:00 |
| melwitt | let's put it in the docs! | 18:00 |
| *** yamamoto has joined #openstack-nova | 18:01 | |
| *** jpena is now known as jpena|off | 18:01 | |
| arvindn05 | yes | 18:01 |
| melwitt | mriedem: thanks for the comments on the cells summary, updated it and will send it out | 18:02 |
| *** lucasagomes is now known as lucas-afk | 18:02 | |
| *** wolverineav has quit IRC | 18:03 | |
| *** derekh has quit IRC | 18:04 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Move placement exceptions into the placement package https://review.openstack.org/549862 | 18:04 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 18:04 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | 18:04 |
| *** gyee has joined #openstack-nova | 18:05 | |
| *** yamamoto has quit IRC | 18:06 | |
| *** mgoddard_ has quit IRC | 18:07 | |
| *** AlexeyAbashkin has joined #openstack-nova | 18:07 | |
| *** mrjk has quit IRC | 18:08 | |
| *** mrjk has joined #openstack-nova | 18:09 | |
| *** wolverineav has joined #openstack-nova | 18:09 | |
| *** harlowja has joined #openstack-nova | 18:11 | |
| *** AlexeyAbashkin has quit IRC | 18:11 | |
| *** gbarros has quit IRC | 18:12 | |
| *** felipemonteiro_ has joined #openstack-nova | 18:12 | |
| *** alex_xu has quit IRC | 18:12 | |
| mnaser | jaypipes: don't want to bother you too much but if you have some free time about the vif plugging on reboot issue | 18:12 |
| *** wolverineav has quit IRC | 18:14 | |
| *** felipemonteiro__ has joined #openstack-nova | 18:15 | |
| *** fragatina has quit IRC | 18:15 | |
| *** fragatina has joined #openstack-nova | 18:16 | |
| *** gbarros has joined #openstack-nova | 18:17 | |
| jaypipes | mnaser: crap, sorry man. got distracted. looking now while tests are running locally. | 18:19 |
| *** felipemonteiro_ has quit IRC | 18:19 | |
| mnaser | jaypipes: np! i can get you a bit to what point i reached from my debugging | 18:19 |
| jaypipes | sure thing. | 18:20 |
| jaypipes | got for it. | 18:20 |
| mnaser | jaypipes: so https://review.openstack.org/#/q/Ib08afad3822f2ca95cfeea18d7f4fc4cb407b4d6 which was merged in master and in the process of getting backported changed behavior (after another change) where now, nova expects a vif-network-plugged event even on reboots | 18:21 |
| mnaser | now, it looks like linuxbridge broke because it didn't send that event, so a little work around was added in that patch above to skip that. now, opendaylight is broken because it doesn't send a notification either. | 18:21 |
| *** sahid has quit IRC | 18:21 | |
| mnaser | upon digging on *why* it doesn't send one, it looks like unplug with ovs on linux is a noop in os_vif | 18:22 |
| mnaser | which means that the port is never really unplugged in odl, so when it tries to 'plug' it, neutron never really does anything because the port state never changes, and the server times out booting because vif_plugging_timeout | 18:22 |
| mnaser | noop unplug here = https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py#L266-L268 | 18:22 |
| jaypipes | mnaser: and this is only on hard reboot, yes? | 18:23 |
| mnaser | jaypipes: correct, but afaik a clean state is a hard reboot too in the nova codebase? | 18:23 |
| mnaser | clean start* | 18:23 |
| mnaser | so first time you start an instance, it'll be okay, but stop and start again will cause it to want a plugged event | 18:23 |
| jaypipes | mnaser: no. a clean start does not issue a call to unplug() in the os-vif API. | 18:23 |
| mnaser | jaypipes: right, but a clean start means the port is created the first time and the vif plugged event comes through fine, but when the instance is stopped, nova calls unplug (but nothing happens) and when it starts again, it waits for vif plugged event (those patches changed that behaviour) | 18:24 |
| mnaser | this was noticed when the tempest start_stop tests failed because the startup would time out | 18:25 |
| jaypipes | hm | 18:26 |
| mnaser | http://logs.openstack.org/22/552922/1/check/networking-odl-tempest-oxygen/277adb4/testr_results.html.gz (you can look at nova logs there, but pretty much test_stop_start_server / test_reboot_server_hard / etc are the ones that arent working now) | 18:26 |
| mnaser | and failure is .. "Details: (ServerActionsTestJSON:test_stop_start_server) Server da9cead9-c217-495e-97a8-65a6adacf37c failed to reach ACTIVE status and task state "None" within the required time (196 s). Current status: SHUTOFF. Current task state: powering-on." .. nova logs shows it timing out after 5 minutes | 18:26 |
| jaypipes | mnaser: k. just a minute. reading through these patches... | 18:28 |
| mnaser | sure thing | 18:28 |
| *** lpetrut has joined #openstack-nova | 18:28 | |
| *** felipemonteiro__ has quit IRC | 18:30 | |
| *** felipemonteiro__ has joined #openstack-nova | 18:30 | |
| jaypipes | mnaser: ok, done. so are you suggesting the fix here is to add VIF_TYPE_OVS to line 5392 here? https://review.openstack.org/#/c/541442/6/nova/virt/libvirt/driver.py | 18:35 |
| mnaser | jaypipes: that would be a fix, or os_vif *actually* unplugging things could be a fix too | 18:36 |
| mnaser | i do feel if that list starts growing, it might start become confusing for users :< | 18:36 |
| jaypipes | mnaser: agreed. | 18:36 |
| jaypipes | mnaser: for os-vif linux bridge, though, I'm not entirely sure what should be done on unplug... | 18:37 |
| mnaser | jaypipes: yeah.. that's beyond me, but for openvswitch, im not sure if there is a link state, or maybe just deleting the actual port if its 'unplugged' | 18:37 |
| mnaser | im sure there's a really good reason why it's not being deleted though, but i don't know why | 18:38 |
| jaypipes | mnaser: I'm also not sure whether that would *ensure* that a vif-unplugged *event* from Neutron would be received... | 18:38 |
| jaypipes | sean-k-mooney: you still around? | 18:38 |
| mnaser | jaypipes: well, nova doesnt care about vif-unplugged afaik, issue is surrounding vif-plugged event | 18:39 |
| mnaser | jaypipes: based on my reading, the nova notifications are a hook to the db model in neutron when an object changes. so if it goes from active => active, nothing is being updated and it never sent anything | 18:39 |
| mnaser | now, maybe neutron-openvswitch-agent does things differently to trigger a change, i'm not sure. | 18:40 |
| mriedem | lyarwood: melwitt: probably want to listen to ^ | 18:40 |
| jaypipes | mnaser: not the neutron DB. the ovsdb... | 18:40 |
| mriedem | related https://review.openstack.org/#/c/550046/ | 18:40 |
| jaypipes | mnaser: and that's only for OVS of course. | 18:40 |
| melwitt | mriedem: thanks | 18:40 |
| *** tbachman has joined #openstack-nova | 18:40 | |
| *** mvk has quit IRC | 18:41 | |
| mriedem | adding VIF_TYPE_OVS to the blacklist would defeat the purpose of the change, which is apparently working for ovs | 18:41 |
| mriedem | we use ovs in our normal gate jobs | 18:41 |
| mnaser | https://github.com/openstack/neutron/blob/master/neutron/db/db_base_plugin_v2.py#L155-L169 | 18:42 |
| mriedem | building a giant list of which vifs types we should not wait on is going to be shitty | 18:42 |
| melwitt | yeah, we were under the impression that ovs *does* send events for the plug in the hard reboot case | 18:42 |
| melwitt | and that it was only linuxbridge that doesn't | 18:42 |
| mnaser | right, but for context, i'm talking about the case when opendaylight is used here | 18:42 |
| mriedem | does that use vif type ovs? | 18:42 |
| jaypipes | mriedem: you mean like this? https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py#L266-L268 | 18:42 |
| mnaser | yes | 18:42 |
| mriedem | guh | 18:42 |
| jaypipes | mriedem: welcome to our own private Idahell. | 18:43 |
| mriedem | jaypipes: heh shitty indeed | 18:43 |
| mriedem | can i be keanu? | 18:43 |
| melwitt | originally, the patch never waited for any events because we thought during a hard reboot, the neutron agent would never detect us doing a os-vif unplug/plug | 18:43 |
| jaypipes | no. | 18:43 |
| *** wolverineav has joined #openstack-nova | 18:43 | |
| mnaser | so afaik odl just 'notices' ports appearing, and in neutron-server there is a web socket connection to odl which notifies it that a port is appeared, so it sets it to active | 18:43 |
| melwitt | then we added another patch to only not wait if linuxbridge because we thought ovs was detecting the unplug/plug | 18:44 |
| mnaser | and so what happens is that, after the hard reboot, the port is always still plugged and didnt get a state change, so nothing happens in neutron and no notification goes out | 18:44 |
| jaypipes | mnaser: wow. I had no idea there were hard-coded hooks in the neutron base db plugin thing. :( | 18:44 |
| mnaser | well, the unplug in os_vif when using ovs literally does nothing | 18:44 |
| mnaser | jaypipes: yeah, TIL yesterday | 18:44 |
| mnaser | or YIL i guess | 18:44 |
| mnaser | i thought it was a bit more complex than that | 18:44 |
| jaypipes | heh | 18:44 |
| melwitt | yeah, but the plug? we asked people in #openstack-neutron and the consensus at the time was that the ovs agent would detect things and send events | 18:45 |
| mnaser | now question is does anyone know why os_vif_ovs does nothing when nova uses the 'unplug' method in it? win32 seems to remove the port from the bridge | 18:45 |
| mriedem | melwitt: this isn't 'ovs' this, | 18:45 |
| mriedem | it's opendaylight | 18:45 |
| melwitt | okay, so things are working fine for ovs then | 18:45 |
| mnaser | correct | 18:46 |
| mriedem | apparently same vif type, | 18:46 |
| mnaser | ^ and that too | 18:46 |
| mriedem | different backend implementation | 18:46 |
| mriedem | does the vif type == networking API or something? | 18:46 |
| *** abalutoiu_ has joined #openstack-nova | 18:46 | |
| mriedem | and odl implements the ovs api? | 18:46 |
| melwitt | sorry, I got confused by the earlier mention of adding VIF_TYPE_OVS to the blacklist? | 18:46 |
| melwitt | is that because opendaylight falls under that vif type? | 18:46 |
| mnaser | correct | 18:46 |
| mriedem | melwitt: yes | 18:46 |
| jaypipes | mnaser: I'll be honest. I don't know why for OVS we don't do anything for OVS when !Windows. | 18:46 |
| melwitt | okay, gotcha now | 18:46 |
| mriedem | if we had to add ovs to that blacklist, then there is really no point in even waiting for vif plug events during a hard reboot with the libvirt driver | 18:47 |
| *** abalutoiu__ has joined #openstack-nova | 18:47 | |
| mnaser | pretty much :\ | 18:47 |
| melwitt | right | 18:47 |
| mnaser | because i think if os_vif_ovs did an actual unplug, the state in neutron would be updated, and on the actual plug later, the state would be updated again and a notification goes out | 18:47 |
| jaypipes | mnaser: I'm going to git blame it... one sec | 18:47 |
| mnaser | i'm *assuming* neutron-openvswitch-agent magically realizes things have been unplugged and removes them | 18:47 |
| mnaser | jaypipes: i tried to git blame for a while and didn't get anywhere productive but my git-fu isn't strong | 18:48 |
| *** tidwellr has quit IRC | 18:48 | |
| *** tidwellr has joined #openstack-nova | 18:48 | |
| *** mgoddard_ has joined #openstack-nova | 18:48 | |
| *** abalutoiu has quit IRC | 18:48 | |
| *** gbarros has quit IRC | 18:49 | |
| jaypipes | mnaser: it was Rawlin Peters who added this code. | 18:49 |
| mnaser | again it could be something odl should be handling, does nova contact neutron for the unplug at the api layer? | 18:49 |
| jaypipes | mnaser: I don't know Rawlin. | 18:49 |
| mnaser | :< | 18:49 |
| jaypipes | https://github.com/openstack/os-vif/commit/d5b119ba37d5c724d1279cb2292dce05c32b51a0 | 18:49 |
| mriedem | mnaser: when we were talking about the differences between openvswith and linuxbridge agents here, sean-k-mooney was saying that ovs will send a notification which the neutron agent proxies to the server which is why ovs works and we don't miss plug events, but LB does polling and there could be a window where we miss it and then timeout waiting for an event that neutron never sends | 18:49 |
| *** abalutoiu has joined #openstack-nova | 18:49 | |
| jaypipes | mnaser: https://review.openstack.org/#/c/333486/ | 18:49 |
| mriedem | mnaser: no it's not a REST API call | 18:50 |
| jaypipes | perhaps we should ask danpb and sean-k-mooney since they approved this patch. | 18:50 |
| mriedem | it's a change on the host which the neutron agent routes up to neutron server | 18:50 |
| sean-k-mooney | i saw my name | 18:50 |
| sean-k-mooney | reading | 18:50 |
| *** abalutoiu_ has quit IRC | 18:50 | |
| mnaser | ok i see, so given that neutron agent doesnt exist on the host, it would never end up hitting neutron | 18:50 |
| melwitt | mnaser: yeah, we only do a unplug and plug through os-vif, no calls to neutron (unless os-vif does any, which I don't think it does) | 18:50 |
| mriedem | melwitt: it doesn't | 18:51 |
| jaypipes | melwitt: it does not, no. | 18:51 |
| mriedem | it's like os-brick, just all host level stuff | 18:51 |
| jaypipes | jinx | 18:51 |
| melwitt | cool | 18:51 |
| jaypipes | mriedem: it's like os-brick, only it bricked the host. | 18:51 |
| mnaser | so maybe if we actually unplugged in os-vif, then it probably wont "hurt" the ovs-agent and things like odl would notice that the port is gone | 18:51 |
| mnaser | and then update neutron in their own little mechanisms | 18:51 |
| sean-k-mooney | oh yes the neutron l2 agent subscribes to notification from the ovs db instead of polling so it gets notified when we do plug and unplug on a hard reboot | 18:51 |
| *** Tom-Tom has joined #openstack-nova | 18:51 | |
| mnaser | sean-k-mooney: but os_vif unplug with ovs does nothing | 18:52 |
| mnaser | https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py#L266-L268 | 18:52 |
| mnaser | so im not sure how n-ovs-agent even knows something changed | 18:52 |
| *** abalutoiu__ has quit IRC | 18:52 | |
| mriedem | jaypipes: rimshot'ed | 18:53 |
| sean-k-mooney | mnaser: yes libvirt does the port plug on the ovs bridge in that case | 18:53 |
| jaypipes | mriedem: :) | 18:53 |
| mnaser | sean-k-mooney: ok, so pretty much it doesn't know things were unplugged, but it knows when they're plugged | 18:53 |
| melwitt | how come odl doesn't have its own plugin for os-vif? | 18:53 |
| sean-k-mooney | odl is not a network backend | 18:53 |
| sean-k-mooney | odl mananges ovs | 18:53 |
| jaypipes | it's an SDN controller. | 18:53 |
| melwitt | oh | 18:53 |
| sean-k-mooney | same for ovn | 18:53 |
| melwitt | so odl manages ovs, but in the setup there are no ovs agents running on compute hosts | 18:54 |
| mnaser | melwitt: correct | 18:54 |
| mriedem | it's possible there is something in the port binding profile that tells us it's odl and not native ovs, but then again if we had to check that level of detail in the driver logic, it's going to suck | 18:55 |
| mriedem | given all of the different neutron backends | 18:55 |
| sean-k-mooney | neutron is repsocible for managing l2 and up nova/os-vif handel l1 netowrking for instances | 18:55 |
| melwitt | yeah, I didn't realize the ovs agent was optional if the backend is ovs | 18:55 |
| mnaser | backend is odl* :) | 18:56 |
| mriedem | i didn't realize you could have different backends for the same vif type either | 18:56 |
| sean-k-mooney | melwitt: well the reference implentation use the agent but, ovn,onos and odl can all be used instead of the agents | 18:56 |
| melwitt | sean-k-mooney said odl isn't a network backend. sorry, I lack knowledge on these | 18:56 |
| *** Tom-Tom has quit IRC | 18:56 | |
| melwitt | okay, so they replace the agents. thanks | 18:56 |
| * mnaser is just slowly learning more about this type of stuff anyways | 18:56 | |
| sean-k-mooney | melwitt: for a neutron vif_type perspctive its nots | 18:57 |
| *** itlinux_ has joined #openstack-nova | 18:57 | |
| *** itlinux has quit IRC | 18:57 | |
| *** ociuhandu has joined #openstack-nova | 18:57 | |
| sean-k-mooney | by the way i think there might be a way to get rid of the polling in the linux bridge agent if you use pyinotify but i have not run the idea past any of the neutron folks | 18:58 |
| mriedem | actually there isn't really anything in the port information that would help us distinguish odl vifs http://logs.openstack.org/22/552922/1/check/networking-odl-tempest-oxygen/277adb4/controller/logs/screen-n-cpu.txt.gz#_Mar_14_15_53_40_140157 | 18:58 |
| sean-k-mooney | mriedem: correct infact that is by design | 18:58 |
| sean-k-mooney | mriedem: if there was the tenant could also tell | 18:59 |
| mriedem | welp, we should probably not wait for vif plugged events on hard reboot in the libvirt driver then | 18:59 |
| mriedem | if we can't determine accurately when that will work | 18:59 |
| mriedem | which means reverting all of these https://review.openstack.org/#/q/Ib08afad3822f2ca95cfeea18d7f4fc4cb407b4d6 | 19:00 |
| jaypipes | yeah | 19:00 |
| melwitt | urgh | 19:00 |
| mriedem | dansmith: ^ fyi | 19:00 |
| sean-k-mooney | i missed the start of this convo. are ye discussing the fact that odl says it is finished wiring up the port imediatly when you bind the port | 19:00 |
| dansmith | yeah I'm following | 19:00 |
| dansmith | that does indeed suck | 19:00 |
| mriedem | sean-k-mooney: odl doesn't send the vif plugged event | 19:00 |
| *** salv-orlando has quit IRC | 19:00 | |
| mnaser | mriedem: it does send it, but only when the port is first created | 19:01 |
| mriedem | but is the ovs vif type | 19:01 |
| *** salv-orl_ has joined #openstack-nova | 19:01 | |
| mriedem | mnaser: ok | 19:01 |
| mnaser | mriedem: the port is never ever unplugged from the openvswitch port on shutdown (when nova calls unplug()) | 19:01 |
| sean-k-mooney | mriedem: it send it when the port is bound not when the port is wired up | 19:01 |
| mnaser | so when the vm is started again, it wont send it, because the port is already uo | 19:01 |
| *** fragatina has quit IRC | 19:01 | |
| melwitt | sean-k-mooney: we were trying to Do The Right Thing and wait for vif plug events when we unplug and replug vifs during a hard reboot. but that's messing up for odl because it doesn't send a plug event in that scenario | 19:01 |
| melwitt | and by unplug and replug we mean through os-vif only | 19:01 |
| sean-k-mooney | melwitt: to make that work with odl we would have to bind the port again | 19:01 |
| mriedem | and according to that other patch from lyarwood, there are other cases | 19:01 |
| * melwitt nods | 19:02 | |
| mriedem | https://review.openstack.org/#/c/550046/ | 19:02 |
| mnaser | yeah so that's gonna be a little list of 'things that don't send notifications' | 19:02 |
| *** yamamoto has joined #openstack-nova | 19:02 | |
| mnaser | (i can imagine that you'll have other closed source sdns showing up soon too) | 19:02 |
| mriedem | sean-k-mooney: and that would be a bigger change, to re-bind the port | 19:02 |
| sean-k-mooney | mriedem: yes it would. we could explore that at some point but prehaps not now | 19:02 |
| melwitt | yeah. I was wondering, is there a call to neutron we could make that would be mostly a no-op, not actually rebind it but update it to the same binding profile or something like that? | 19:03 |
| *** ociuhandu has quit IRC | 19:03 | |
| melwitt | I don't know if neutron would emit an event if nothing changed | 19:03 |
| mnaser | melwitt: it would not, i looked into the logic, its a db hook that checks if states changed | 19:03 |
| sean-k-mooney | as context the odl ml2 works the way it does today because odl does not have acess to rabitmq to be able to notify nova/neutron when its finished wireing things up | 19:03 |
| melwitt | mnaser: ah, rats | 19:03 |
| mnaser | https://github.com/openstack/neutron/blob/master/neutron/db/db_base_plugin_v2.py#L155-L169 | 19:04 |
| mnaser | https://github.com/openstack/neutron/blob/master/neutron/notifiers/nova.py | 19:04 |
| mnaser | and it explicitely ignores noops | 19:04 |
| *** crushil has joined #openstack-nova | 19:04 | |
| mriedem | nova would have to unbind/bind or change the state of the binding (i think) | 19:05 |
| mriedem | and that all seems scary and hacky | 19:05 |
| mnaser | mriedem: and not something you'd want to backport all the way to stable/ocata either | 19:05 |
| melwitt | yeah, I don't want to do that | 19:05 |
| sean-k-mooney | mriedem: ya we would have to set the host_id in the binding profile to None then back to the hostname to get it to work | 19:05 |
| mriedem | well the good news is the original change didn't make it to newton | 19:06 |
| sean-k-mooney | mriedem: maybe we can use the multiple port bindings neutron are adding to adress this in the future | 19:07 |
| melwitt | I was thinking if we could not actually change it, update it to the same, and it would emit a notification, that might be cool. but I definitely don't want to unbind and rebind it just for this. guess it all depends on what's the impact of not waiting for the event. instance says ACTIVE when it might not actually have networking yet? | 19:07 |
| mriedem | melwitt: yes | 19:07 |
| *** yamamoto has quit IRC | 19:07 | |
| mriedem | doing that for hard reboot is less shitty than initial create, at least from our CI system | 19:07 |
| sean-k-mooney | mriedem: how would you feel about nova calling activate on the port binding again on a hard reboot? | 19:08 |
| openstackgerrit | Arvind Nadendla proposed openstack/nova-specs master: Support traits in Glance https://review.openstack.org/541507 | 19:08 |
| mriedem | any places in tempest that fallout as a result could wait on the port being ACTIVE in addition to the server being ACTIVE | 19:08 |
| *** salv-orl_ has quit IRC | 19:08 | |
| mriedem | sean-k-mooney: calling activate? | 19:08 |
| *** salv-orlando has joined #openstack-nova | 19:08 | |
| melwitt | yeah, what's that do? | 19:08 |
| sean-k-mooney | in the multiple port binding spec there is a new api call to activate a binding as part of live migration | 19:09 |
| mriedem | if it relies on the new porting binding api, that doesn't exist yet, and isn't backportable :) | 19:09 |
| *** mvk has joined #openstack-nova | 19:09 | |
| mriedem | sean-k-mooney: you just mean changing the binding status to 'active' right? | 19:09 |
| mriedem | sean-k-mooney: for a hard-reboot with a single host binding, it would already be active | 19:09 |
| sean-k-mooney | well my taught would be allow that to tell neutron to validate its wired up again because did something(reboot) you man not have seen | 19:09 |
| melwitt | that sounds like what we want, but as mriedem said, not backportable | 19:10 |
| mriedem | mnaser: other good news is ocata isn't going anywhere :) https://review.openstack.org/#/c/548916/ | 19:10 |
| sean-k-mooney | mriedem: yes it would. but since that api is not in a release yet we could ammend it to say calling activate on an active binding forces it to wire it up again or at least check its in the active state | 19:11 |
| *** andreas_s has joined #openstack-nova | 19:11 | |
| mriedem | sean-k-mooney: that's pretty hacky, | 19:11 |
| melwitt | and validating it would cause an event to be sent? | 19:11 |
| mriedem | i think you'd have to deactivate the binding, and then activate it | 19:11 |
| mriedem | /ports/{id}/binding/{host}/action :) | 19:12 |
| sean-k-mooney | melwitt: validating would sent the event if it actully changed something | 19:12 |
| mriedem | i can see it now | 19:12 |
| melwitt | sean-k-mooney: yeah, I guess that seems similar to just unbinding it and binding it again | 19:12 |
| mriedem | so for present day options, | 19:12 |
| mriedem | i think we're talking revert right? | 19:12 |
| sean-k-mooney | melwitt: yep it is | 19:12 |
| mriedem | back through queens and pike | 19:12 |
| melwitt | I guess so. doesn't seem like we have any choice | 19:13 |
| sean-k-mooney | mriedem: revert waiting. yes i think so | 19:13 |
| mriedem | dansmith: jaypipes: how are you feeling about a revert | 19:13 |
| mriedem | i don't see other very good options | 19:13 |
| dansmith | yeah I mean, are there other options? | 19:13 |
| mriedem | not outside of changing the port binding on reboot | 19:13 |
| sean-k-mooney | i think we can/shoudl fix it for rocky so we can reenable waiting | 19:13 |
| mriedem | which is a bigger change | 19:13 |
| melwitt | unbinding the port and binding it again | 19:14 |
| mriedem | sean-k-mooney: i think that would also require talking to the neutron team about whether or not that would do what we need | 19:14 |
| *** idlemind has joined #openstack-nova | 19:14 | |
| mriedem | i can only talk to miguel once per day, he said | 19:14 |
| melwitt | haha | 19:14 |
| cfriesen | are there any races that come from not waiting for vifs to actually be plugged? | 19:14 |
| mriedem | mnaser: is there a bug report for the ODL issue? | 19:15 |
| mriedem | cfriesen: yes | 19:15 |
| dansmith | yes | 19:15 |
| sean-k-mooney | "in general" un binding and binding the port "should" be safe but it can fail | 19:15 |
| mriedem | tempest races assuming it can ssh into the guest | 19:15 |
| melwitt | cfriesen: instance can go to ACTIVE state without having networking yet | 19:15 |
| mnaser | mriedem: in ODL world yes, but not in nova world, but i can make one | 19:15 |
| mriedem | mnaser: yes please for tracking | 19:15 |
| mnaser | ok | 19:15 |
| melwitt | well, for ssh I know from using devstack that the instance says ACTIVE before ssh daemon is ready | 19:15 |
| sean-k-mooney | cfriesen: odl has no mechanisium to notify nova today that they have been plugged | 19:15 |
| melwitt | I thought | 19:15 |
| sean-k-mooney | * notify neutron | 19:16 |
| mriedem | melwitt: if that were true, | 19:16 |
| mriedem | our CI would shit its pants daily | 19:16 |
| sean-k-mooney | mriedem: we get around that by a retry loop | 19:16 |
| dansmith | mriedem: we retry waiting for ssh | 19:16 |
| mriedem | ah yes | 19:16 |
| dansmith | but that's a totally different problem than not having networking and DHCP ready during boot | 19:17 |
| *** tssurya has joined #openstack-nova | 19:17 | |
| mriedem | so we hide the poo | 19:17 |
| *** gbarros has joined #openstack-nova | 19:17 | |
| dansmith | it's totally legit to not expect the instance is ready when the state goes to active, | 19:17 |
| dansmith | it's not legit for the instance to boot up and expect networking but have none | 19:17 |
| sean-k-mooney | tempest waits for active then wiats for ping to work then ssh's i think | 19:17 |
| dansmith | and then tries ssh a few times with long timeouts | 19:17 |
| mriedem | sean-k-mooney: yes i forgot about the latter | 19:17 |
| mnaser | i mean, dhcp could be slow too, so it doesnt matter if internet is wired up.. | 19:17 |
| mnaser | start up of the OS could be slow | 19:18 |
| mnaser | unless you setup something inside the OS that tells nova the vm is ready, we'll always have ACTIVE vms that arent accessible | 19:18 |
| melwitt | yeah, +1 dansmith. could this screw boot up entirely? if DHCP not ready while it's coming up? or will it always recover | 19:18 |
| sean-k-mooney | dansmith: active and ready in an ironic case is partcallarly different things. vms tend to be ready soon after they are active | 19:18 |
| *** salv-orl_ has joined #openstack-nova | 19:18 | |
| dansmith | melwitt: yes if networking isn't running | 19:18 |
| melwitt | urgh | 19:18 |
| dansmith | melwitt: some OSes may try DHCP briefly, and if it gets none, then it never retries | 19:18 |
| dansmith | if you are a cloud image and don't know what kind of cloud you're on, | 19:19 |
| melwitt | that would majorly suck to just have a junk instance if this is hit | 19:19 |
| dansmith | you really have to just poke around until you figure it out because it could be a variety of things | 19:19 |
| mnaser | ...but then again this is something that has been in nova for 3-4 releases, so a fix would be nice, but i dont think its a issue thats happening often enough? | 19:19 |
| *** salv-orlando has quit IRC | 19:19 | |
| sean-k-mooney | melwitt: also oftend cloud images will wait for cloud init to finish before starting ssh so that can take a while too | 19:19 |
| mnaser | considering the port is never really unplugged in ovs, most things are already wired up | 19:19 |
| melwitt | I see | 19:19 |
| dansmith | mnaser: yeah less of a concern on reboot for that reason | 19:20 |
| sean-k-mooney | mnaser: on hard reboot it is unpluged | 19:20 |
| sean-k-mooney | mnaser: on soft reboot it is not | 19:20 |
| *** esberglu has quit IRC | 19:20 | |
| mnaser | sean-k-mooney: but the unplug in os_vif seems to be noop from what i see (or maybe im misunderstanding things) | 19:20 |
| mnaser | sean-k-mooney: https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/ovs.py#L266-L268 nothing happens here... | 19:20 |
| sean-k-mooney | mnaser: that only because in that code path the plugin is done by libvirt | 19:20 |
| *** tesseract has quit IRC | 19:20 | |
| mnaser | oh okay sorry i'm following you now | 19:20 |
| mnaser | the actual unplug happens by libvirt which is then picked up by n-ovs-agent | 19:21 |
| *** Tom-Tom has joined #openstack-nova | 19:21 | |
| sean-k-mooney | yep when we do the domain destroy on hard reboot libvirt remove the interface form ovs and deletes teh tap | 19:21 |
| mnaser | ok i understand now | 19:21 |
| mnaser | thank youy | 19:21 |
| cfriesen | my organization has a local patch to make plug_vifs() optionally wait until the vifs are actually plugged in order to ensure that things work reliably during a live migration...we added that a long time ago and I was wondering if it's still needed, but it sounds like it is. | 19:22 |
| sean-k-mooney | cfriesen: when you say actully plugged what do you wait for | 19:22 |
| dansmith | we can't know that the plumbing is done behind the neutron curtain without the event right? | 19:23 |
| *** esberglu has joined #openstack-nova | 19:23 | |
| sean-k-mooney | cfriesen: if its external-ids:iface-status=active in the ovs db we hard code that here https://github.com/openstack/os-vif/blob/master/vif_plug_ovs/linux_net.py#L71 | 19:23 |
| sean-k-mooney | dansmith: technically for ovs and ovs agents only we shoudl be able to use external-ids:iface-status=active but i dont know for odl | 19:24 |
| dansmith | but that's a very specific case | 19:24 |
| sean-k-mooney | dansmith: for lb or vpp or whatever else we have no way to tell | 19:24 |
| dansmith | for that one type | 19:24 |
| dansmith | yeah | 19:24 |
| *** andreas_s has quit IRC | 19:25 | |
| mnaser | mriedem: https://bugs.launchpad.net/nova/+bug/1755890 i tried to write a basic description and referenced this conversation but yeah feel free to update it with any lacking details | 19:25 |
| openstack | Launchpad bug 1755890 in OpenStack Compute (nova) "Instances fail to hard reboot when using OpenDaylight" [Undecided,New] | 19:25 |
| cfriesen | sean-k-mooney: actually, never mind. the only one with a useful query is for our custom networking thing, the others are assumed to always be up. My bad. | 19:25 |
| melwitt | I have to run for now but I'm cool with reverting those patches if that's the best option we have. bbl | 19:25 |
| arvindn05 | mriedem: jaypipes: updated the spec based on comments Patch set 9 should address the issues https://review.openstack.org/#/c/541507/9 | 19:25 |
| *** Tom-Tom has quit IRC | 19:26 | |
| sean-k-mooney | cfriesen: the dpdk based titainium server vswitch i assuem | 19:27 |
| cfriesen | yep | 19:27 |
| cfriesen | it'll query the vswitch API | 19:28 |
| sean-k-mooney | cfriesen: ya the issue is that bar seeting external-ids:iface-status=active which is an ovs agent specif thing there is no way to tell for ovs in general. | 19:29 |
| sean-k-mooney | when odl first intregrated support into the ml2 framework this gap was discussed back in icehouse but they had no way syncronis state in odl with neutron without a intoducing an sdn constrolller specific api, b having odl emit notifcation on the rabbitmq bus or be haveing the neutron server poll odl for state change | 19:31 |
| *** suresh12 has quit IRC | 19:32 | |
| sean-k-mooney | the chose to do non of the above an just report vif_plugged on port binding instead and its been that way ever since | 19:32 |
| mnaser | sean-k-mooney: maybe this is a networking-odl bug? i know that right now it creates a websocket that listens for state updates | 19:32 |
| mnaser | https://github.com/openstack/networking-odl/blob/master/networking_odl/ml2/port_status_update.py | 19:33 |
| mnaser | https://bugs.launchpad.net/networking-odl/+bug/1686023 | 19:33 |
| openstack | Launchpad bug 1686023 in networking-odl "networking-odl dynamic port status update full support missing" [Low,In progress] | 19:33 |
| mriedem | jaypipes: replied in https://review.openstack.org/#/c/539605/ - need bauzas to probably elaborate at this point since i don't remember this being talked about at the ptg | 19:33 |
| mnaser | i guess they support DOWN => ACTIVE but not ACTIVE=>DOWN | 19:33 |
| *** sridharg has quit IRC | 19:33 | |
| *** links has quit IRC | 19:34 | |
| mnaser | i wonder if there's an easy way to let neutron know that the port has gone down in there | 19:34 |
| mnaser | and avoid the revert | 19:34 |
| sean-k-mooney | mnaser: well i think its a ml2 framework feature request. e.g. allow agentless backend notify neutron of state changes | 19:34 |
| mriedem | if we can blame this all on an incomplete neutron backend then that works for me | 19:35 |
| sean-k-mooney | mnaser: that bug seams to focus on admin state which is different | 19:35 |
| mnaser | lolol | 19:35 |
| *** moshele has joined #openstack-nova | 19:35 | |
| mriedem | https://review.openstack.org/#/c/465463/ | 19:36 |
| mnaser | sean-k-mooney: https://github.com/openstack/networking-odl/blob/master/networking_odl/ml2/port_status_update.py#L91-L95 ever that little bit? the bug talks about admin state but it seems to get the actual port state | 19:36 |
| sean-k-mooney | mnaser: yest that should adress this but it seams that odl is not detecting the removal of the port and readding it | 19:37 |
| sean-k-mooney | mnaser: perhaps the networking-odl ml2 driver is just not sending the notification to nova when it recives the notification from odl | 19:38 |
| mriedem | shouldn't the driver go through the normal notificatoin code in neutron? | 19:38 |
| mnaser | sean-k-mooney: its certainly not sending it when its being unplugged, but it looks like the code to watch for state doesnt even update it to 'down' or 'unplugged' or whatever state it should be in neutron | 19:39 |
| *** Tom-Tom has joined #openstack-nova | 19:39 | |
| sean-k-mooney | mriedem: that notification code is triggered by port status updates on the rpc bus | 19:39 |
| sean-k-mooney | mriedem: these update from odl are from the websocket | 19:39 |
| *** moshele has quit IRC | 19:40 | |
| *** itlinux_ has quit IRC | 19:40 | |
| sean-k-mooney | mriedem: since we are not storing the state changes from https://github.com/openstack/networking-odl/blob/master/networking_odl/ml2/port_status_update.py#L91-L95 in the db i dont think https://github.com/openstack/neutron/blob/master/neutron/db/db_base_plugin_v2.py#L155-L169 will be invoked | 19:41 |
| *** moshele has joined #openstack-nova | 19:41 | |
| mnaser | sean-k-mooney: is there an example of a plugin that is storing/updating state changes in db which might be good to reference | 19:41 |
| sean-k-mooney | maybe look at the ovs agent code. | 19:42 |
| *** hemna_ has quit IRC | 19:43 | |
| mnaser | https://github.com/openstack/networking-ovn/blob/master/networking_ovn/ml2/mech_driver.py#L713-L729 | 19:43 |
| mnaser | i guess i can use that as a reference and try submitting something to networking-odl | 19:43 |
| *** Tom-Tom has quit IRC | 19:43 | |
| *** pchavva has quit IRC | 19:44 | |
| sean-k-mooney | i dont think we actully need to store it in the db. we just need to send the notification to nova | 19:44 |
| mnaser | i guess one thing though is talking about the revert is... if this is going to affect other drivers too | 19:45 |
| mnaser | aka we fix odl but find 4 other vif types that are affected by that issue | 19:45 |
| *** amoralej is now known as amoralej|off | 19:45 | |
| sean-k-mooney | mnaser: we are already special casing lb and we need to skip waithing i think for sriov too so basically we can only wait for ovs with agents today | 19:46 |
| sean-k-mooney | maybe we can wait for ovn? but not sure. | 19:46 |
| *** mgoddard_ has quit IRC | 19:48 | |
| mriedem | unless the port profile/details add some specific flag that says we can expect events on replug, i don't think it's safe to just have the blanket wait that we have today | 19:49 |
| *** salv-orl_ has quit IRC | 19:50 | |
| openstackgerrit | Ed Leafe proposed openstack/nova master: Add 'member_of' param to GET /allocation_candidates https://review.openstack.org/552098 | 19:50 |
| edleafe | jaypipes: cdent: ^^ Addressed your comments | 19:50 |
| *** salv-orlando has joined #openstack-nova | 19:50 | |
| sean-k-mooney | mriedem: that is true. i think this is something that first needs to made a requirement for all neutron backend before nova can start to depend on it. | 19:50 |
| sean-k-mooney | mriedem: one option is add a nova config opetion to the compute node? we wait there correct? but not ideal | 19:51 |
| *** awaugama has quit IRC | 19:52 | |
| *** suresh12 has joined #openstack-nova | 19:52 | |
| mriedem | it's an option yes but not a good one imo | 19:52 |
| mriedem | we already have vif_plugging_timeout and vif_plugging_is_fatal | 19:52 |
| mriedem | we'd have to add a vif_plugging_reboot_if_hard_and_libvirt_and_thursday_timeout | 19:53 |
| *** itlinux has joined #openstack-nova | 19:53 | |
| *** crushil has quit IRC | 19:53 | |
| *** sambetts is now known as sambetts|afk | 19:53 | |
| *** salv-orlando has quit IRC | 19:54 | |
| sean-k-mooney | hehe well it could be vif_wait_for_network but ya only ovs + reference agents could set it to true | 19:54 |
| sean-k-mooney | it would have to default to false and proably should be deprecated from the start | 19:55 |
| mnaser | i guess a revert seems like the cleanest possible choice? :x | 19:56 |
| sean-k-mooney | mnaser: ya | 19:56 |
| jaypipes | edleafe: +2 from me. | 19:56 |
| mnaser | i'm not sure how a revert would happen because this seems to be 2 patches. a patch that reverts both referencing both commits? | 19:56 |
| mnaser | unless someone else volunteers to do this | 19:56 |
| *** suresh12 has quit IRC | 19:57 | |
| sean-k-mooney | what were the 2 commits again. it will be next week if i do it at the earliest. | 19:57 |
| mriedem | i think it's just this one https://review.openstack.org/#/q/Ib08afad3822f2ca95cfeea18d7f4fc4cb407b4d6 | 19:57 |
| mriedem | that's the one that adding the wait back in | 19:58 |
| mnaser | what about https://review.openstack.org/#/q/Ib0cf5d55750f13d0499a570f14024dca551ed4d4 ? | 19:58 |
| mriedem | that's what you want to happen, not wait | 19:58 |
| mriedem | there were 3 changes: | 19:58 |
| mriedem | 1. full hard reboot blasting everything away and re-plug; that caused issues because we were waiting for something that wouldn't happen | 19:59 |
| mriedem | 2. to workaround ^, we stopped waiting | 19:59 |
| mriedem | 3. because not waiting when it will work for some (ovs but not lb), the final patch was added which added the bridge conditional | 19:59 |
| mriedem | but as we've now seen, that doesn't work for ovs (odl) | 19:59 |
| mriedem | so revert #3 to go back to not waiting | 20:00 |
| mriedem | which is https://review.openstack.org/#/c/541442/ | 20:00 |
| sean-k-mooney | mriedem: right https://review.openstack.org/#/c/541442/6/nova/virt/libvirt/driver.py skip waiting for lb and then larwood was extending it for sriov then odl came up | 20:00 |
| *** suresh12 has joined #openstack-nova | 20:00 | |
| mriedem | yeah so it's whack-a-mole at this point | 20:00 |
| mriedem | heh, we could just revert all of them | 20:01 |
| mnaser | so revert master and then cherry pick the reverts once they land? | 20:01 |
| mriedem | going back to https://review.openstack.org/#/c/400384/ | 20:01 |
| mriedem | mnaser: cherry picking reverts is weird, | 20:01 |
| sean-k-mooney | mriedem: so one patch to just remove waithing on reboot and backporting that is proable the simpelst thing | 20:01 |
| mriedem | i'd just revert individually on all branches | 20:01 |
| mnaser | ok i see | 20:01 |
| *** artom has quit IRC | 20:01 | |
| sean-k-mooney | mriedem: or that. | 20:01 |
| mriedem | i was never fully comfortable with https://review.openstack.org/#/c/400384/ | 20:02 |
| mriedem | it was trying to fix a problem with encrypted volumes and overshot probably to include vifs | 20:02 |
| mnaser | related-bug or closes-bug to https://bugs.launchpad.net/nova/+bug/1755890 ? | 20:02 |
| openstack | Launchpad bug 1755890 in OpenStack Compute (nova) "Instances fail to hard reboot when using OpenDaylight" [Undecided,New] | 20:02 |
| mnaser | (for the revert) | 20:02 |
| mriedem | closes | 20:02 |
| *** yamamoto has joined #openstack-nova | 20:03 | |
| openstackgerrit | Mohammed Naser proposed openstack/nova master: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553035 | 20:03 |
| sean-k-mooney | mriedem: we have to be carful not to reintroduce https://bugs.launchpad.net/nova/+bug/1724573 by reverting https://review.openstack.org/#/c/400384 | 20:04 |
| openstack | Launchpad bug 1724573 in OpenStack Compute (nova) "encrypted volumes are directly attached to instances after a compute host reboot" [Medium,Fix released] - Assigned to Matthew Booth (mbooth-9) | 20:04 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553037 | 20:04 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553038 | 20:04 |
| mnaser | https://review.openstack.org/#/c/542767/ | 20:05 |
| mnaser | can someone 'block' that from merging | 20:05 |
| mnaser | dansmith: maybe remove your +W? | 20:05 |
| dansmith | ack | 20:05 |
| sean-k-mooney | mnaser: it has a zuul -2 because its in merge conflict | 20:05 |
| mnaser | sean-k-mooney: figure just in case someone doesnt notice it :) | 20:06 |
| mnaser | https://review.openstack.org/#/q/topic:bug/1744361+is:open+owner:%22Mohammed+Naser+%253Cmnaser%2540vexxhost.com%253E%22 | 20:06 |
| mriedem | sean-k-mooney: yeah if we reverted all the way, we'd have to do a partial revert of https://review.openstack.org/#/c/400384 and only remove the changes for the vif plugging part | 20:07 |
| *** yamamoto has quit IRC | 20:08 | |
| sean-k-mooney | well looking at https://review.openstack.org/#/c/553035/ i think it solve the imidiate odl issue at least for now | 20:08 |
| sean-k-mooney | that seams like the minimal change at the cost of never waiting | 20:09 |
| *** sidx64 has joined #openstack-nova | 20:10 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Make nova-cells-v1 run with neutron https://review.openstack.org/549789 | 20:10 |
| mriedem | if we wanted to go back to https://review.openstack.org/#/c/400384/, | 20:14 |
| mriedem | we could pass destroy_vifs=False through self.destroy -> self.cleanup | 20:14 |
| *** Tom-Tom has joined #openstack-nova | 20:14 | |
| *** suresh12 has quit IRC | 20:14 | |
| mriedem | because that was the change in behavior in that patch that caused a lot of the trouble | 20:14 |
| mriedem | as i said, https://review.openstack.org/#/c/400384/ was meant to fix an encrypted volume issue and turned into "let's just fully destroy the damn thing and everything associated with it except disks" | 20:15 |
| *** sidx64 has quit IRC | 20:15 | |
| *** suresh12 has joined #openstack-nova | 20:15 | |
| *** sidx64 has joined #openstack-nova | 20:16 | |
| *** Tom-Tom has quit IRC | 20:18 | |
| sean-k-mooney | im going to head off soon. FYI ill be online intermitely tommorw and then off until tuesday. | 20:21 |
| *** mgoddard_ has joined #openstack-nova | 20:25 | |
| efried | You don't like me anymore, jaypipes? | 20:31 |
| dansmith | efried: we took a vote | 20:32 |
| dansmith | sad to say, you're off the island | 20:32 |
| efried | And edleafe won??? | 20:32 |
| efried | Come ON! | 20:32 |
| dansmith | hah | 20:32 |
| * dansmith doesn't even know the context | 20:32 | |
| efried | I mean, he does have seniority. | 20:33 |
| efried | SERIOUS seniority. | 20:33 |
| jaypipes | efried: your torch has been extinguished. | 20:33 |
| dansmith | you must leave the tribal council area IMMEDIATELY | 20:34 |
| jaypipes | dansmith: edleafe has won the microversion battle being currently waged. | 20:34 |
| * efried feels he is missing some pop culture reference, but suspect it has to do with survival shows. | 20:34 | |
| dansmith | ah heh | 20:34 |
| efried | dansmith: It's not too late! You can saaaaave me! | 20:34 |
| jaypipes | efried: that is correct. when a person is voted off the island in the survivor show, their torch is extinguished. | 20:35 |
| dansmith | I wouldn't mind seeing a fire making challenge between the two of you | 20:35 |
| * efried whips out trusty Zippo | 20:35 | |
| jaypipes | efried: or at least, that's the way it was the last time I saw that show, which would have been around 2005. | 20:35 |
| *** jmlowe has joined #openstack-nova | 20:35 | |
| *** awaugama has joined #openstack-nova | 20:35 | |
| dansmith | efried: nah, you have to use flint and coconut husk | 20:35 |
| *** AlexeyAbashkin has joined #openstack-nova | 20:36 | |
| efried | or my high-velocity eyeballs? | 20:36 |
| jaypipes | dansmith: you can't make fried_rice without fire. | 20:36 |
| * dansmith turns to the judges | 20:36 | |
| dansmith | bah dum. | 20:36 |
| openstackgerrit | Merged openstack/nova master: Revert "Make the InstanceMapping marker UUID-like" https://review.openstack.org/552937 | 20:36 |
| * mriedem hands edleafe a single rose | 20:36 | |
| jaypipes | hahaha | 20:36 |
| dansmith | nice | 20:39 |
| *** fragatina has joined #openstack-nova | 20:39 | |
| *** AlexeyAbashkin has quit IRC | 20:40 | |
| * edleafe blushes | 20:41 | |
| mriedem | i assume edleafe is an avid bachelor(ette) watcher | 20:41 |
| mriedem | although it does come on pretty late... | 20:41 |
| dansmith | um, aren't we all? | 20:41 |
| edleafe | Nah, no cable in this house | 20:41 |
| mriedem | it's not cable! | 20:41 |
| dansmith | it's not on cable dude :) | 20:41 |
| mriedem | rabbit ears | 20:41 |
| dansmith | haha | 20:41 |
| edleafe | guess I'll have to pick some up to see what all the fuss is about | 20:42 |
| mriedem | or, your texas-sized satellite in the backyard should pick it up | 20:42 |
| edleafe | maybe it's on hulu? | 20:42 |
| mriedem | idk, but i wouldn't advice trying to find it | 20:42 |
| dansmith | I bet it's on hulu, | 20:42 |
| dansmith | but we're not serious about watching/liking it | 20:43 |
| edleafe | oh sure | 20:43 |
| *** salv-orlando has joined #openstack-nova | 20:43 | |
| edleafe | you're just probably embarrassed to admit it | 20:43 |
| dansmith | heh | 20:43 |
| edleafe | it *is* on hulu | 20:44 |
| edleafe | wait - season 22?? | 20:44 |
| dansmith | oh boy, edleafe is in for a treat tonight | 20:44 |
| dansmith | oh yeah man, it's a major deal | 20:44 |
| *** idlemind_ has joined #openstack-nova | 20:44 | |
| dansmith | that's why I figured it'd be on hulu.. they couldn't have a subscriber base without it | 20:44 |
| *** idlemind_ has quit IRC | 20:44 | |
| *** idlemind has quit IRC | 20:44 | |
| edleafe | oh, they have all sorts of trashy TV: the voice, top model, the kardashians | 20:45 |
| edleafe | I'm so culturally deprived | 20:45 |
| efried | culturally depraved if you watch that crap. Take your pick | 20:46 |
| edleafe | efried: good point | 20:47 |
| *** pchavva has joined #openstack-nova | 20:48 | |
| *** eharney has quit IRC | 20:49 | |
| *** Tom-Tom has joined #openstack-nova | 20:50 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: handle DiskNotFound during update_available_resource https://review.openstack.org/553067 | 20:51 |
| *** esberglu has quit IRC | 20:52 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: libvirt: handle DiskNotFound during update_available_resource https://review.openstack.org/553067 | 20:54 |
| *** Tom-Tom has quit IRC | 20:55 | |
| *** esberglu_ has joined #openstack-nova | 20:55 | |
| *** esberglu_ has quit IRC | 20:56 | |
| *** moshele has quit IRC | 20:56 | |
| *** esberglu_ has joined #openstack-nova | 20:56 | |
| cfriesen | got something wierd, looking for ideas. With libvirt, when you power off a node it calls _destroy() which will loop over the serial ports and call serial_console.release_port(). Then in power_on() we end up calling _destroy() again, which could end up releasing serial ports that are now in use by another instance. | 20:58 |
| cfriesen | (I think these are basically TCP ports on the host.) | 21:00 |
| mriedem | mnaser: left a comment in https://review.openstack.org/#/c/553035/ - how do you feel about working that into the commit message before we start a revert party | 21:01 |
| mnaser | mriedem: are you okay with me copypasta-ing that comment and adding co-authored because you seem to have summarized it well | 21:03 |
| mriedem | that's fine | 21:04 |
| mriedem | don't really need the co-author | 21:04 |
| mnaser | okay cool, let me see | 21:04 |
| *** yamamoto has joined #openstack-nova | 21:04 | |
| *** gagehugo has joined #openstack-nova | 21:06 | |
| openstackgerrit | sean mooney proposed openstack/nova master: WIP add mtu to libvirt xml for ethernet and bridge types https://review.openstack.org/553072 | 21:07 |
| openstackgerrit | Mohammed Naser proposed openstack/nova master: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553035 | 21:07 |
| mnaser | mriedem: is that ok? if thats okay ill update the other ones | 21:07 |
| mriedem | yeah lgtm | 21:08 |
| *** rcernin has joined #openstack-nova | 21:08 | |
| sean-k-mooney | i have not tested the mtu ptach so ignore it for now. ill test it tomorrow and remove the WIP once i add unit test and check it actully works. | 21:08 |
| mriedem | use the same change id in the stable branch ones too | 21:08 |
| mriedem | please | 21:08 |
| mnaser | will do | 21:08 |
| *** tojuvone has quit IRC | 21:08 | |
| *** tojuvone has joined #openstack-nova | 21:09 | |
| *** sar has quit IRC | 21:09 | |
| arvindn05 | mriedem: jaypipes: updated the spec based on comments Patch set 9 should address the issues https://review.openstack.org/#/c/541507/9 | 21:10 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/queens: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553037 | 21:10 |
| *** yamamoto has quit IRC | 21:10 | |
| openstackgerrit | Eric Fried proposed openstack/nova master: Stop assuming initial provider generation is 0 https://review.openstack.org/548975 | 21:10 |
| efried | cdent: jaypipes: That 'un is ready now too ^ | 21:10 |
| openstackgerrit | Mohammed Naser proposed openstack/nova stable/pike: Revert "Refine waiting for vif plug events during _hard_reboot" https://review.openstack.org/553038 | 21:10 |
| cdent | rad | 21:10 |
| mnaser | mriedem: apparently changing the id in change-id: <foo> doesn't do it? | 21:11 |
| mnaser | maybe i need to recommit or rebase (i did edited with the ui) | 21:12 |
| mriedem | i figured you could use the ui | 21:17 |
| *** tojuvone_ has joined #openstack-nova | 21:20 | |
| *** tojuvone has quit IRC | 21:20 | |
| *** tidwellr has quit IRC | 21:21 | |
| sean-k-mooney | jaypipes: just on the nic feature based schduling spec https://review.openstack.org/#/c/545951/ | 21:21 |
| *** lpetrut has quit IRC | 21:22 | |
| *** sidx64 has quit IRC | 21:22 | |
| sean-k-mooney | i just responed to you comments . i can resping if you want but many of the nits you raised are due to the fact that half of this feature merged in pike since it was feature complete since then | 21:22 |
| sean-k-mooney | moving the nic feature to placement would be cool but they have been stored in the nova db for 2 release now so i would like to finish the use fo them first then port to placement | 21:23 |
| *** dave-mccowan has quit IRC | 21:26 | |
| *** Tom-Tom has joined #openstack-nova | 21:28 | |
| jaypipes | sean-k-mooney: I'm already +2 on that. no need. | 21:30 |
| *** tssurya has quit IRC | 21:30 | |
| *** andreas_s has joined #openstack-nova | 21:31 | |
| arvindn05 | jaypipes: quick question on one of your comments | 21:33 |
| *** Tom-Tom has quit IRC | 21:33 | |
| *** dave-mccowan has joined #openstack-nova | 21:33 | |
| *** awaugama has quit IRC | 21:33 | |
| arvindn05 | https://review.openstack.org/#/c/541507/ - Don't forget you will need to modify the existing ImageExtraSpecsFilter to ignore keys that start with "trait:", since clearly the placement API will have already filtered out hosts without the required traits... | 21:33 |
| arvindn05 | for the comment mriedem pointed out there is no ImageExtraSpecsFilter. Was there a different filter you had in mind? | 21:33 |
| *** pchavva has quit IRC | 21:34 | |
| jaypipes | arvindn05: yeah, it's ImagePropertiesFilter, sorry about that | 21:34 |
| jaypipes | arvindn05: I always forget that it's named differently. | 21:35 |
| mriedem | ImagePropertiesFilter only cares about 3 specific image props | 21:35 |
| mriedem | should probably be renamed | 21:35 |
| *** tbachman has quit IRC | 21:35 | |
| jaypipes | orly? | 21:35 |
| mriedem | SuperSpecificImagePropertiesFilter | 21:35 |
| jaypipes | lol | 21:35 |
| jaypipes | TIL... | 21:35 |
| arvindn05 | ^what mriedem said | 21:35 |
| melwitt | ThreeSpecificImagePropertiesFilter | 21:35 |
| mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/image_props_filter.py#L46 | 21:35 |
| arvindn05 | actually 4 properties looks like.. | 21:36 |
| jaypipes | efried: "bogosity". well played. | 21:36 |
| arvindn05 | if i trust the documentation :) | 21:36 |
| *** andreas_s has quit IRC | 21:36 | |
| melwitt | FourSpecificImagePropertiesFilter | 21:36 |
| jaypipes | lol | 21:36 |
| arvindn05 | architecture,hypervisor_type,hypervisor_version_requires,vm_mode | 21:36 |
| efried | jaypipes: I calls 'em like I sees 'em | 21:36 |
| * arvindn05 less changes yay | 21:37 | |
| jaypipes | arvindn05: don't forget the illustrative "i_am_nfv_and_do_what_want" property. | 21:38 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change TestNewtonCellsCheck to not rely on objects https://review.openstack.org/553082 | 21:38 |
| mriedem | the value is a wildcard right? | 21:38 |
| *** esberglu_ has quit IRC | 21:38 | |
| mriedem | dansmith: melwitt: ^ is the thing tssurya needed | 21:38 |
| jaypipes | mriedem: on Tuesdays. on Wednesdays it's a reverse wildcard. On Thursday it's a regex and on Friday it's all whitespace. | 21:39 |
| arvindn05 | lol | 21:39 |
| melwitt | jaypipes: been meaning to ask you, were you gonna update this unit test to do the BFV thing? or I can try to help with that if you want. if possible, I want to backport that all the way to ocata where it broke https://review.openstack.org/#/c/538310/2/nova/tests/unit/virt/libvirt/test_driver.py@3722 | 21:39 |
| jaypipes | melwitt: I'd definitely appreciate a hand on that one. | 21:39 |
| *** itlinux has quit IRC | 21:40 | |
| melwitt | jaypipes: cool, I'll take a stab at it | 21:40 |
| jaypipes | melwitt: tyvm | 21:40 |
| *** edmondsw has quit IRC | 21:41 | |
| *** belmoreira has quit IRC | 21:45 | |
| *** liverpooler has quit IRC | 21:48 | |
| jaypipes | efried: issue in https://review.openstack.org/#/c/548249/ | 21:49 |
| efried | ack | 21:50 |
| * cdent has shame | 21:50 | |
| efried | jaypipes: Oh - cdent and I discussed this at the ptg | 21:50 |
| jaypipes | efried: oh? | 21:50 |
| * cdent has less shame | 21:51 | |
| jaypipes | heh | 21:51 |
| efried | he assured me the exception wasn't possible anymore | 21:51 |
| cdent | https://review.openstack.org/#/c/548249/2/nova/objects/resource_provider.py@493 | 21:51 |
| mriedem | arvindn05: +2 on https://review.openstack.org/#/c/541507/ now, thanks | 21:51 |
| cdent | I did not assure you! I said I couldn't see how it could happen. | 21:51 |
| cdent | Entirely different, sirrah. | 21:51 |
| cdent | I may be blind | 21:51 |
| jaypipes | efried, cdent: pretty sure it's still possible. | 21:52 |
| efried | You totally assured me | 21:52 |
| efried | listen to the tape | 21:52 |
| * cdent would totally punch efried except that's really scary | 21:52 | |
| *** esberglu has joined #openstack-nova | 21:52 | |
| jaypipes | efried, cdent: plus, defensive coding and all that... | 21:52 |
| efried | shrug, okay | 21:53 |
| arvindn05 | mriedem: thanks for the +2 :) | 21:53 |
| cdent | it was conversation that would have been nice to have jaypipes at because we were both struggling to conceptualize how the transaction was operating | 21:53 |
| cdent | and that without that it was all speculation and we didn't know how/if to even test it | 21:54 |
| arvindn05 | now just need to bother jaypipes for his original +2 :) | 21:54 |
| jaypipes | cdent: it's not necessarily about the transaction itself (or how it operates). it's about the consistent read view. another process could have modified the same resource provider in between the time when we originally began the transaction and when we go to incremenet the generation. | 21:55 |
| cdent | so, jaypipes, if we ever get a clear moment to talk through that, it would be cool. probably wants a whiteboard though, so perhaps vancouver | 21:55 |
| cdent | well that's exactly the part we couldn't conceptualize how/when does the read view change? | 21:56 |
| jaypipes | arvindn05: +W | 21:56 |
| *** Matias has quit IRC | 21:57 | |
| cdent | if we have at some point in our transaction done a select on the resource provider (as is the case here), isn't that going to be "true" for the duration of the transaction? | 21:57 |
| cdent | or does that require additional syntax? | 21:58 |
| jaypipes | cdent: read view == "before I began trying to set these aggregates, the provider generation was 101". we then start the transaction and begin inserting and deleting records from the resource_provider_aggregates table. after our transaction began, another process can modify the resource provider record and update the generation. that is an indication that the state we viewed at the beginning of the transaction has changed and we will need to | 21:59 |
| jaypipes | re-read our view. | 21:59 |
| *** Matias has joined #openstack-nova | 21:59 | |
| *** wolverineav has quit IRC | 21:59 | |
| *** wolverineav has joined #openstack-nova | 22:00 | |
| *** Tom-Tom has joined #openstack-nova | 22:01 | |
| jaypipes | cdent: when another process calls COMMIT on a transaction, the changes made in that transaction are now viewable by other transactions that are in process. Changes made in another process's transaction *before* the COMMIT are generally *not* viewable by another process' transactions unless the READ UNCOMMITTED transaction isolation level is set. | 22:01 |
| *** wolverineav has quit IRC | 22:01 | |
| *** wolverin_ has joined #openstack-nova | 22:01 | |
| *** tbachman has joined #openstack-nova | 22:02 | |
| * cdent parses | 22:02 | |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Change TestNewtonCellsCheck to not rely on objects https://review.openstack.org/553082 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: Add disabled column to cell_mappings table. https://review.openstack.org/552505 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: [WIP] Add disabled field to CellMapping object https://review.openstack.org/550090 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: [WIP] Add CellMappingList.get_all_enabled() query method https://review.openstack.org/550188 | 22:02 |
| openstackgerrit | Matt Riedemann proposed openstack/nova master: [WIP] Allow scheduling only to enabled cells (Filter Scheduler) https://review.openstack.org/550527 | 22:02 |
| efried | Meaning the operation as a whole is atomic, but non-locking. | 22:02 |
| efried | It's a race: whoever gets to COMMIT first, wins. | 22:03 |
| *** burt has quit IRC | 22:03 | |
| efried | But the stuff happening within one transaction isn't fuddling the other. | 22:03 |
| *** chyka has quit IRC | 22:03 | |
| cdent | efried: I seem to recall you had concerns that needed to be addressed if this is how things turned out, or is "this" some middle ground between the extremes you were thinking of? | 22:04 |
| *** Matias has quit IRC | 22:04 | |
| efried | the latter | 22:04 |
| efried | Because I was concerned that the state would change between when we read things an when we updated them. | 22:04 |
| *** owalsh_ has joined #openstack-nova | 22:06 | |
| efried | I guess that's still true, but the code is set up to raise ConcurrentUpdateException if that happens - assuming whatever operation we're doing is incrementing the generation. | 22:06 |
| *** Tom-Tom has quit IRC | 22:06 | |
| efried | though this may actually mean we have holes in things that don't muck with generations... | 22:06 |
| *** yamamoto has joined #openstack-nova | 22:06 | |
| cdent | right, the only reason it's not a problem is becsuse incrementing the generation is an update | 22:06 |
| * cdent makes a slight adjustment to his mental model | 22:07 | |
| efried | specifically because we have this code to check for generation mismatch. | 22:07 |
| cdent | yes | 22:08 |
| efried | Though technically there's still a hole - if we check for mismatch riiiight before the other transaction commits. | 22:08 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: generation in provider aggregate APIs https://review.openstack.org/548249 | 22:09 |
| openstackgerrit | Eric Fried proposed openstack/nova master: placement: Return new provider from POST /rps https://review.openstack.org/548934 | 22:09 |
| openstackgerrit | Eric Fried proposed openstack/nova master: Stop assuming initial provider generation is 0 https://review.openstack.org/548975 | 22:09 |
| efried | jaypipes: Howzat? ^ | 22:09 |
| cdent | efried: I don't think that's the case, because we're not checking for mismatch. We are doing an update that can fail, which is different (at least as far as I understand things, but as this conversation has demonstrated there are some holes in my understanding) | 22:09 |
| efried | Never mind about the hole, I think I see how it works. | 22:10 |
| efried | yeah. | 22:10 |
| *** owalsh has quit IRC | 22:10 | |
| *** owalsh_ has quit IRC | 22:11 | |
| *** yamamoto has quit IRC | 22:12 | |
| *** mgoddard_ has quit IRC | 22:14 | |
| *** priteau has quit IRC | 22:15 | |
| *** owalsh has joined #openstack-nova | 22:16 | |
| *** felipemonteiro_ has joined #openstack-nova | 22:20 | |
| *** felipemonteiro__ has quit IRC | 22:23 | |
| *** fragatina has quit IRC | 22:23 | |
| *** mlavalle has quit IRC | 22:23 | |
| *** fragatina has joined #openstack-nova | 22:24 | |
| openstackgerrit | Giridhar Jayavelu proposed openstack/nova-specs master: VMware: place instances on resource pool https://review.openstack.org/549067 | 22:24 |
| openstackgerrit | Merged openstack/nova-specs master: Support traits in Glance https://review.openstack.org/541507 | 22:25 |
| *** cmm_ has quit IRC | 22:28 | |
| *** fragatina has quit IRC | 22:29 | |
| *** Guest7641 has quit IRC | 22:30 | |
| *** tasker has quit IRC | 22:30 | |
| *** gjayavelu has quit IRC | 22:30 | |
| *** owalsh has quit IRC | 22:32 | |
| *** owalsh has joined #openstack-nova | 22:33 | |
| *** fragatina has joined #openstack-nova | 22:36 | |
| *** fragatina has quit IRC | 22:36 | |
| *** Tom-Tom has joined #openstack-nova | 22:38 | |
| *** fragatina has joined #openstack-nova | 22:38 | |
| *** fragatina has quit IRC | 22:40 | |
| *** danpawlik has joined #openstack-nova | 22:41 | |
| *** Tom-Tom has quit IRC | 22:43 | |
| openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | 22:43 |
| openstackgerrit | Chris Dent proposed openstack/nova master: Isolate placement database config https://review.openstack.org/541435 | 22:43 |
| *** fragatina has joined #openstack-nova | 22:46 | |
| *** dave-mccowan has quit IRC | 22:47 | |
| *** Tom-Tom has joined #openstack-nova | 22:47 | |
| melwitt | mriedem: here's the nova/cinder session summary, if you have anything to add/correct https://etherpad.openstack.org/p/nova-ptg-rocky-cinder-summary | 22:48 |
| *** felipemonteiro_ has quit IRC | 22:49 | |
| *** danpawlik has quit IRC | 22:52 | |
| *** Tom-Tom has quit IRC | 22:52 | |
| *** shaohe_feng has joined #openstack-nova | 22:57 | |
| *** hongbin has quit IRC | 22:59 | |
| *** cdent has quit IRC | 23:05 | |
| *** tbachman has quit IRC | 23:07 | |
| *** yamamoto has joined #openstack-nova | 23:07 | |
| *** liverpooler has joined #openstack-nova | 23:08 | |
| *** wolverin_ has quit IRC | 23:09 | |
| *** wolverineav has joined #openstack-nova | 23:10 | |
| *** wolverineav has quit IRC | 23:11 | |
| *** wolverin_ has joined #openstack-nova | 23:11 | |
| *** yamamoto has quit IRC | 23:12 | |
| *** artom has joined #openstack-nova | 23:17 | |
| *** Tom-Tom has joined #openstack-nova | 23:19 | |
| *** david-lyle has quit IRC | 23:21 | |
| *** Tom-Tom has quit IRC | 23:24 | |
| *** david-lyle has joined #openstack-nova | 23:26 | |
| *** gjayavelu has joined #openstack-nova | 23:27 | |
| *** liverpooler has quit IRC | 23:27 | |
| Spazmotic | Morning folks. | 23:28 |
| *** david-lyle has quit IRC | 23:28 | |
| mriedem | melwitt: do you want to link patches in there for stuff that's in progress now? | 23:29 |
| melwitt | mriedem: sure, why not. I wasn't really thinking about it | 23:30 |
| *** david-lyle has joined #openstack-nova | 23:30 | |
| mriedem | melwitt: done | 23:33 |
| *** shaohe_feng has quit IRC | 23:33 | |
| melwitt | thank ye | 23:33 |
| *** kmalloc has quit IRC | 23:38 | |
| openstackgerrit | Giridhar Jayavelu proposed openstack/nova-specs master: VMware: place instances on resource pool https://review.openstack.org/549067 | 23:41 |
| *** Matias has joined #openstack-nova | 23:43 | |
| *** itlinux has joined #openstack-nova | 23:47 | |
| *** esberglu has quit IRC | 23:50 | |
| *** Tom-Tom has joined #openstack-nova | 23:51 | |
| *** gjayavelu has quit IRC | 23:51 | |
| *** hamzy has quit IRC | 23:56 | |
| *** Tom-Tom has quit IRC | 23:56 | |
| *** hamzy has joined #openstack-nova | 23:58 | |
| *** liverpooler has joined #openstack-nova | 23:59 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!