Wednesday, 2023-07-12

*** senrique is now known as enriquetaso13:59
whoami-rajat#startmeeting cinder14:00
opendevmeetMeeting started Wed Jul 12 14:00:08 2023 UTC and is due to finish in 60 minutes.  The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot.14:00
opendevmeetUseful Commands: #action #agreed #help #info #idea #link #topic #startvote.14:00
opendevmeetThe meeting name has been set to 'cinder'14:00
whoami-rajat#topic roll call14:00
enriquetasohell14:00
enriquetasohello*14:00
Tony_Saadhi14:00
simondodsleyo/14:00
crohmanno/14:00
rosmaitao/14:00
caiqilongo/14:00
thiagoalvoravelo/14:01
jungleboyjo/14:01
keerthivasansuresho/14:01
jbernardo/14:01
felipe_rodrigueso/14:01
* jungleboyj has returned from Covid hell.14:01
rosmaitawelcome back!14:02
nahimsouza[m]o/14:02
MatheusAndrade[m]o/14:02
luizsantos[m]o/14:02
helenadantas[m]o/14:02
whoami-rajat#link https://etherpad.opendev.org/p/cinder-bobcat-meetings14:02
enriquetasojungleboyj++14:05
whoami-rajatjungleboyj, good to know that you are feeling better14:05
whoami-rajatgood turnout14:05
whoami-rajatlet's get started14:05
whoami-rajat#topic announcements14:06
jungleboyjThanks.  :-)14:06
whoami-rajat:)14:06
whoami-rajatfirst, PTG Registration14:06
whoami-rajatnext PTG for CC cycle is going to be virtual14:06
whoami-rajat#link https://lists.openstack.org/pipermail/openstack-discuss/2023-July/034363.html14:06
jungleboyjYay!14:07
whoami-rajatDate: October 23-27, 202314:08
whoami-rajatRegistration link14:08
whoami-rajat#link https://ptg2023.openinfra.dev/14:08
whoami-rajatso please register if you are planning to be there14:10
whoami-rajatthere is no fee since it's a virtual event14:10
whoami-rajatbut the registration is going to act as a head count14:10
whoami-rajatnext, Extended Driver merge Deadline14:10
whoami-rajat#link https://lists.openstack.org/pipermail/openstack-discuss/2023-July/034360.html14:10
whoami-rajatsince the drivers lacked review, we planned to extend the deadline to this week14:11
whoami-rajatNew deadline is 14th July14:11
whoami-rajathere is the list of drivers14:11
whoami-rajat#link https://etherpad.opendev.org/p/cinder-2023-2-bobcat-drivers14:11
whoami-rajatlet's discuss the driver status14:11
whoami-rajat1. TOYOU NetStor TYDS14:11
whoami-rajat#link https://review.opendev.org/c/openstack/cinder/+/88694214:12
whoami-rajatIt's already reviewed by Eric Brian and I14:12
whoami-rajatsince I was a late reviewer, the comments from Eric and Brian are addressed14:12
rosmaita(you can see that we all caught different issues, which is why it's good to have multiple reviewers!)14:12
whoami-rajatthanks caiqilong for quickly responding to the feedback14:12
whoami-rajatrosmaita++14:12
caiqilongthanks for reviewing it.14:13
whoami-rajatright now my main issue was the client isn't tested and could have some syntax error that might fail the driver operation14:13
whoami-rajatso we should have some code coverage there14:13
whoami-rajatI'm OK if we do that as a followup14:13
whoami-rajatbut wanted a confirmation on it14:13
caiqilongyes, I will do it as a followup.14:14
rosmaitaa followup sounds ok to me14:15
whoami-rajatgreat thanks14:15
caiqilongI have a question about "the client isn't tested"14:16
whoami-rajatsure, go ahead14:16
caiqilongis it the code coverage test?14:16
jungleboyjThat is consistent with what we have done in the past.  We have allowed for test coverage to be improved after merge.14:16
rosmaitacode coverage: https://6d3a6db80c7cdddc63a0-6a3155c041608419d4d57ad6e32791fa.ssl.cf1.rackcdn.com/886942/10/check/cinder-code-coverage/5118ae5/cover/14:16
rosmaitai guess this is the main file: https://6d3a6db80c7cdddc63a0-6a3155c041608419d4d57ad6e32791fa.ssl.cf1.rackcdn.com/886942/10/check/cinder-code-coverage/5118ae5/cover/d_36619f643b600f10_tyds_client_py.html14:17
caiqilongthanks, I will recheck later.14:18
whoami-rajatcaiqilong, yes, once you start writing test for it, the red lines in the coverage (as shared by rosmaita ) will disappear14:18
caiqilongwhat about the translation.14:18
rosmaitacaiqilong: do you know how to find the coverage results in gerrit?14:19
rosmaitayou can also run them  locally with 'tox -e cover'14:19
caiqilongI think open then zuul check result link14:20
rosmaitathat's right14:20
rosmaitathis was my comment about the logs: About the En/Zh logs ... we should discuss at the cinder meeting. The logs aren't translated for openstack because operators decided that it was better to have log messages in English only to make it more likely that you'd find something when searching the web. But I can see how it would be useful to have logs in a local language also for day-to-day monitoring of the system.14:20
caiqilongwhat the rate should the driver reach?14:20
rosmaitacaiqilong: we don't have a specific rate, the idea is to add tests that make sense to make sure that the requests you are sending (for any complicated requests) look right14:21
rosmaitathe reason is so that when people fix bugs, if they make a bad change, it can get caught by the tests14:22
rosmaitaso like if you pass a pagination parameter or something to your client, make sure that it appears correctly in the request the client makes14:23
caiqilongrosmaita: thanks, I will added proper unit tests for client too.14:24
rosmaitabut back to the logs, if you want to have messages appear *both* in en and zh, i don't think there's a way to do that without having 2 loggers like you do in your patch14:25
rosmaitai could be wrong about that, though14:25
whoami-rajatrosmaita, in our driver checklist, it says that warning logs should be translated14:25
rosmaitai thought there was a hacking rule to make sure the _() doesn't occur in logging contexts?14:26
whoami-rajatrosmaita, also if we use i18n, doesn't the log get translated? I mean does it never get translated or it's optional?14:26
whoami-rajatAll exception messages that could be raised to users should be marked for translation with _()14:27
rosmaitathat's correct14:27
caiqilongabout the log, I think we should translate on the storage system better, instead of cinder driver.14:28
jungleboyjwhoami-rajat:  Right14:28
rosmaitait   C312 = checks:no_translate_logs14:29
rosmaitacaiqilong: is your goal to have both en and zh messages in the logs?14:30
caiqilongit not a mandatory requirements14:31
rosmaitai see how it could be useful, though14:31
caiqilongis "C312 = checks:no_translate_logs" a checklist items from the checklist link?14:32
rosmaitahttps://opendev.org/openstack/cinder/src/branch/master/tox.ini#L27314:32
rosmaitait's a rule that is checked when you run 'tox -e pep8'14:33
rosmaitait is slightly different from what you are doing, you are using two non-translated logs, one in en and one in zh14:33
caiqilongI am going to log en logs to the storage systems and then when the ci systems display logs, the storage system select to translate it to zh or not.14:34
rosmaitaif you can do that, it would be better14:35
caiqilongyes, I will discard the zh one.14:35
whoami-rajatthanks rosmaita and caiqilong for the discussion14:36
rosmaitasounds good, we can always revisit this if necessary later14:36
whoami-rajatif everything is addressed, i think we should move on with the meeting since we have more topics to discuss14:36
whoami-rajatyes, we can always continue the discussion in #openstack-cinder14:37
caiqilongsorry for the delay, thanks.14:37
whoami-rajatno problem, good to see the issues are addressed14:37
whoami-rajatlet's move to the second driver14:37
whoami-rajat2. Yadro FC Driver14:37
whoami-rajat#link https://review.opendev.org/c/openstack/cinder/+/87674314:38
whoami-rajatmy comments are addressed and I will revisit it14:38
whoami-rajatit's in a pretty good state since a lot of common code already existed14:38
whoami-rajatbut would be good to get more eyes on it14:39
whoami-rajat3. Lustre Driver14:40
whoami-rajat#link https://review.opendev.org/q/topic:bp%252Fadd-lustre-driver14:40
whoami-rajatI don't see the CI reporting yet14:40
whoami-rajatso we might postpone it to the next cycle14:40
jbernardo/ i can look at the yadro driver today14:41
whoami-rajatgreat, thanks!14:42
whoami-rajatlast announcement, EM discussion14:43
whoami-rajat#link https://lists.openstack.org/pipermail/openstack-discuss/2023-July/034350.html14:43
whoami-rajatTC started the discussion on the ML14:43
whoami-rajatthere is also a patch proposed to the governance project14:43
whoami-rajat#link https://review.opendev.org/c/openstack/governance/+/88796614:43
rosmaitaand a long discussion at the TC meeting yesterday14:43
whoami-rajat#link https://etherpad.opendev.org/p/openstack-exteneded-maintenance14:44
whoami-rajathaven't followed it, i will take a look at the discussion14:44
rosmaitareal quickly:14:44
rosmaitawe will stop calling them "extended maintenance", probably will be "unsupported"14:45
rosmaitathey won't have 'stable' in the branch name14:45
simondodsleyyea14:45
rosmaitathere will be a separate set of cores to watch those branches14:45
rosmaita(which could be cinder-core, but doesn't have to be)14:46
rosmaitathe projects do not have *any* responsibility for those un-stable branches14:46
rosmaitakristi should have updates to the proposals posted today14:46
whoami-rajatthanks Brian, that sounds like a lot of improvement from our current model14:47
rosmaitai'm not real clear on how EOL will work, though14:47
rosmaita(that's all)14:48
whoami-rajatEOL should work the same right? no branch in gerrit and final release tagged?14:48
whoami-rajatas branch-EOL14:48
rosmaitawell, there's the coordination across projects issue still14:49
rosmaitabut the key thing is it will be clear that even if the branches exist, we have no responsibility/make no guarantees about them14:49
whoami-rajatyeah, i thought TC/release team will do the coordination instead of project teams doing it individually, maybe project teams could vote on the branch14:50
whoami-rajatrosmaita, yes, that's the major improvement, and addresses our bandwidth concerns14:50
rosmaitayep14:50
whoami-rajatcool14:51
whoami-rajatanyone who is interested, feel free to follow the discussion in above links14:51
whoami-rajatlet's move to topics14:51
whoami-rajatthat's all for announcements14:51
whoami-rajat#topic [Telemetry] How to properly deliver cinder metrics to Ceilometer14:51
whoami-rajatcrohmann, that's you14:52
crohmannshort and sweet: could someone who knows please clarify my question (on the ML?), I will then gladly push a documentation patch.14:52
crohmann(to fix the documentation bug I opened)14:53
whoami-rajatI'm not sure about that14:56
enriquetasoemail: https://lists.openstack.org/pipermail/openstack-discuss/2023-June/034192.html14:56
enriquetaso#link https://lists.openstack.org/pipermail/openstack-discuss/2023-June/034192.html14:56
whoami-rajatif anyone uses telemetry in their deployment, please take a look ^14:56
whoami-rajatthanks enriquetaso 14:56
zaitcevWait, anyone still uses Ceilometer?!14:57
whoami-rajat#link https://bugs.launchpad.net/ceilometer/+bug/202447514:57
whoami-rajatbug report ^14:57
whoami-rajatzaitcev, that's a good question14:57
zaitcevEveryone I know have switched to Prometheus (sometimes behind statsd for collection).14:57
whoami-rajatcrohmann, do you want to quickly discuss your other topics or should we move them to next week?14:57
crohmannThe next two are simply about me asking for help :-)14:58
rosmaitacrohmann: from the cinder side, your point (2) makes sense to me14:58
rosmaita(point (2) in your email)14:58
whoami-rajatcrohmann, ack14:58
whoami-rajatso i will quickly mention the next 2 topics14:58
whoami-rajat#link [Cinder-Backup]  Spec to introduce a backup_status field for volumes and a split-up of the backup status away from the volume_status14:59
whoami-rajatif there is anyone interested in implementing this, please contact crohmann and he can help you out with the details14:59
whoami-rajat#topic  [Cinder-Backup]  Spec to introduce a backup_status field for volumes and a split-up of the backup status away from the volume_status14:59
whoami-rajatsorry my bad, not a link but it's a topic14:59
whoami-rajat#topic [Cinder-Backup] Performance issues with chunked driver14:59
whoami-rajatsame with this one, if anyone would like to work on this, help is appreciated15:00
zaitcevI think jbernard staked the backup performance.15:00
whoami-rajatyes, correct15:00
whoami-rajati think jbernard is around today15:01
crohmannI also have the Enrico Bocchi from Cern who observed the same issues.15:01
whoami-rajatwe're over time15:03
crohmannzaitcev: Regarding Ceilometer. I don't want to add any fuel to any EoL discussions, but Ceilometer is communicated as THE telemetry solution for OpenStack. We love Prometheus and use it, but question is what a proper data source for OpenStack would be? https://github.com/openstack-exporter/openstack-exporter?15:03
whoami-rajatthanks everyone for attending15:03
whoami-rajatand please take a look at review request section15:03
jungleboyjThanks whoami-rajat !15:03
whoami-rajatwe can continue the discussion in #openstack-cinder after BS meeting15:03
whoami-rajat#endmeeting15:03
opendevmeetMeeting ended Wed Jul 12 15:03:59 2023 UTC.  Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4)15:03
opendevmeetMinutes:        https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-07-12-14.00.html15:03
opendevmeetMinutes (text): https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-07-12-14.00.txt15:03
opendevmeetLog:            https://meetings.opendev.org/meetings/cinder/2023/cinder.2023-07-12-14.00.log.html15:03
*** geguileo is now known as Guest577715:11
*** Guest5777 is now known as geguileo15:21

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!