| *** jesusaur has joined #openstack-meeting-alt | 00:21 | |
| *** tetsuro has joined #openstack-meeting-alt | 00:30 | |
| *** hongbin has joined #openstack-meeting-alt | 01:03 | |
| *** lei-zh has joined #openstack-meeting-alt | 02:05 | |
| *** bhavikdbavishi has joined #openstack-meeting-alt | 02:55 | |
| *** ircuser-1 has joined #openstack-meeting-alt | 03:18 | |
| *** lei-zh has quit IRC | 03:36 | |
| *** lei-zh has joined #openstack-meeting-alt | 03:39 | |
| *** dtrainor has quit IRC | 04:22 | |
| *** lei-zh has quit IRC | 04:37 | |
| *** lei-zh has joined #openstack-meeting-alt | 04:56 | |
| *** hongbin has quit IRC | 05:27 | |
| *** e0ne has joined #openstack-meeting-alt | 05:34 | |
| *** radeks__ has joined #openstack-meeting-alt | 06:00 | |
| *** janki has joined #openstack-meeting-alt | 06:06 | |
| *** dpawlik has joined #openstack-meeting-alt | 06:10 | |
| *** dpawlik has quit IRC | 06:11 | |
| *** dpawlik_ has joined #openstack-meeting-alt | 06:11 | |
| *** bhavikdbavishi has quit IRC | 06:16 | |
| *** jtomasek has joined #openstack-meeting-alt | 06:16 | |
| *** e0ne has quit IRC | 06:16 | |
| *** apetrich has joined #openstack-meeting-alt | 06:38 | |
| *** rdopiera has joined #openstack-meeting-alt | 06:45 | |
| *** kopecmartin has joined #openstack-meeting-alt | 06:48 | |
| *** ccamacho has joined #openstack-meeting-alt | 06:50 | |
| *** alexchadin has joined #openstack-meeting-alt | 07:24 | |
| *** slaweq has quit IRC | 07:30 | |
| *** slaweq has joined #openstack-meeting-alt | 07:31 | |
| *** rcernin has quit IRC | 07:31 | |
| *** d0ugal has joined #openstack-meeting-alt | 07:54 | |
| *** jtomasek has quit IRC | 08:15 | |
| *** jtomasek has joined #openstack-meeting-alt | 08:16 | |
| *** tssurya has joined #openstack-meeting-alt | 08:30 | |
| *** radeks has joined #openstack-meeting-alt | 08:41 | |
| *** radeks__ has quit IRC | 08:43 | |
| *** radeks_ has joined #openstack-meeting-alt | 08:44 | |
| *** radeks has quit IRC | 08:47 | |
| *** e0ne has joined #openstack-meeting-alt | 08:48 | |
| *** ttsiouts has joined #openstack-meeting-alt | 08:52 | |
| *** Emine has joined #openstack-meeting-alt | 08:53 | |
| *** GeraldK has joined #openstack-meeting-alt | 09:02 | |
| *** alexchadin has quit IRC | 09:43 | |
| *** lei-zh has quit IRC | 09:53 | |
| *** ttsiouts has quit IRC | 10:23 | |
| *** slagle has quit IRC | 10:42 | |
| *** slagle has joined #openstack-meeting-alt | 10:44 | |
| *** erlon has joined #openstack-meeting-alt | 10:48 | |
| *** tetsuro has quit IRC | 10:50 | |
| *** slagle has quit IRC | 10:55 | |
| *** ttsiouts has joined #openstack-meeting-alt | 11:02 | |
| *** apetrich has quit IRC | 11:04 | |
| *** apetrich has joined #openstack-meeting-alt | 11:13 | |
| *** tetsuro has joined #openstack-meeting-alt | 11:15 | |
| *** rdopiera has quit IRC | 11:28 | |
| *** tetsuro has quit IRC | 11:30 | |
| *** jroll has quit IRC | 11:43 | |
| *** jroll has joined #openstack-meeting-alt | 11:44 | |
| *** jaypipes has joined #openstack-meeting-alt | 11:57 | |
| *** raildo has joined #openstack-meeting-alt | 11:59 | |
| *** dtrainor has joined #openstack-meeting-alt | 12:05 | |
| *** tpsilva has joined #openstack-meeting-alt | 12:13 | |
| *** alexchadin has joined #openstack-meeting-alt | 12:18 | |
| *** jcoufal has joined #openstack-meeting-alt | 12:37 | |
| *** alexchadin has quit IRC | 12:51 | |
| *** dustins has joined #openstack-meeting-alt | 12:53 | |
| *** janki has quit IRC | 12:55 | |
| *** ttsiouts has quit IRC | 13:16 | |
| *** alexchadin has joined #openstack-meeting-alt | 13:18 | |
| *** ttsiouts has joined #openstack-meeting-alt | 13:30 | |
| *** tetsuro has joined #openstack-meeting-alt | 13:32 | |
| *** alexchadin has quit IRC | 13:43 | |
| *** alexchadin has joined #openstack-meeting-alt | 13:44 | |
| *** ganso has left #openstack-meeting-alt | 13:45 | |
| *** cdent has joined #openstack-meeting-alt | 13:51 | |
| *** alex_xu has joined #openstack-meeting-alt | 13:52 | |
| *** Emine has quit IRC | 13:55 | |
| *** takashin has joined #openstack-meeting-alt | 13:57 | |
| efried | #startmeeting nova-scheduler | 14:00 |
|---|---|---|
| openstack | Meeting started Mon Aug 27 14:00:03 2018 UTC and is due to finish in 60 minutes. The chair is efried. Information about MeetBot at http://wiki.debian.org/MeetBot. | 14:00 |
| openstack | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 14:00 |
| *** openstack changes topic to " (Meeting topic: nova-scheduler)" | 14:00 | |
| openstack | The meeting name has been set to 'nova_scheduler' | 14:00 |
| cdent | o/ | 14:00 |
| takashin | o/ | 14:00 |
| edleafe | \o | 14:01 |
| alex_xu | o/ | 14:01 |
| efried | #link agenda https://wiki.openstack.org/wiki/Meetings/NovaScheduler#Agenda_for_next_meeting | 14:01 |
| tetsuro | o/ | 14:01 |
| efried | #topic specs and review | 14:02 |
| efried | #link latest pupdate: http://lists.openstack.org/pipermail/openstack-dev/2018-August/132852.html | 14:02 |
| efried | cdent to pick this up again near the PTG \o/ | 14:02 |
| *** openstack changes topic to "specs and review (Meeting topic: nova-scheduler)" | 14:02 | |
| *** mriedem has joined #openstack-meeting-alt | 14:02 | |
| mriedem | o/ | 14:02 |
| efried | #link reshaper series: https://review.openstack.org/#/q/topic:bp/reshape-provider-tree+status:open | 14:02 |
| efried | Half is +A (still blocked by -2 at the bottom). Let's get it merged early this week. | 14:02 |
| *** raildo_ has joined #openstack-meeting-alt | 14:03 | |
| efried | There are a few additional barnacle patches fixing nits | 14:03 |
| edleafe | efried: How much of that is placement-side? | 14:03 |
| *** raildo has quit IRC | 14:03 | |
| efried | edleafe: There are four placement-side patches, I believe. | 14:03 |
| efried | The main one, two bug fixes, and a doc fix. | 14:04 |
| edleafe | So we should be good to freeze after they merge? | 14:04 |
| edleafe | I'm asking because we are just about ready to do the extraction to a new repo | 14:04 |
| efried | https://review.openstack.org/#/c/576927/ https://review.openstack.org/#/c/585033/ (both +A), https://review.openstack.org/#/c/596497/ and https://review.openstack.org/#/c/596494/ respectively. | 14:05 |
| efried | The latter two still need reviews | 14:05 |
| efried | edleafe: Got a topic for extraction later on: remind me to ask more about the freeze thing. | 14:06 |
| efried | Any other questions/comments on reshaper series? | 14:06 |
| *** rmascena__ has joined #openstack-meeting-alt | 14:06 | |
| edleafe | ack | 14:07 |
| efried | #link Gigantor SQL split and debug logging: https://review.openstack.org/#/c/590041/ | 14:07 |
| efried | This is merging | 14:07 |
| efried | Planning/Doing support in nova/report client for: | 14:07 |
| efried | #link consumer generation handling (gibi): https://review.openstack.org/#/q/topic:consumer_gen+(status:open+OR+status:merged) | 14:07 |
| efried | #link ML thread on consumer gen conflict handling: http://lists.openstack.org/pipermail/openstack-dev/2018-August/133373.html | 14:07 |
| efried | #link nested and shared providers for initial & migration (and other?) allocations: https://review.openstack.org/#/q/topic:use-nested-allocation-candidates+(status:open+OR+status:merged) | 14:07 |
| efried | #link Spec: Placement modeling of PCI devices ("generic device management") https://review.openstack.org/#/c/591037/ | 14:08 |
| efried | Anyone have other specs or reviews to bring up? | 14:09 |
| *** raildo_ has quit IRC | 14:09 | |
| * cdent enqueues | 14:09 | |
| efried | #topic bugs | 14:10 |
| efried | #link placement bugs: https://bugs.launchpad.net/nova/+bugs?field.tag=placement&orderby=-id | 14:10 |
| *** openstack changes topic to "bugs (Meeting topic: nova-scheduler)" | 14:10 | |
| efried | anyone have bugs to highlight? | 14:10 |
| mriedem | i need to write a bug at some point, | 14:10 |
| mriedem | for resize to same host doubling allocations against the same compute RP | 14:10 |
| mriedem | even though it's different consumers | 14:11 |
| mriedem | that's going to be a tricky one to fix most likely, | 14:11 |
| mriedem | at least in a non-racy way | 14:11 |
| *** alexchadin has quit IRC | 14:11 | |
| efried | mm | 14:11 |
| mriedem | b/c we swap the instance allocation to the migration record before hitting the scheduler, | 14:11 |
| efried | "greatest common denominator" allocation candidate request | 14:11 |
| mriedem | to find out if the scheduler has selected the same host | 14:11 |
| efried | or "least superset"? | 14:12 |
| mriedem | something like that yes, | 14:12 |
| mriedem | 1. am i resizing on the same host | 14:12 |
| mriedem | 2. figure out superset of allocations | 14:12 |
| efried | but different depending on same vs different host, yah. | 14:12 |
| mriedem | 3. put them back on the instance | 14:12 |
| efried | can we tell whether resizing to the same host beforehand? | 14:13 |
| mriedem | don't think so | 14:13 |
| efried | fun times | 14:13 |
| *** takashin has quit IRC | 14:13 | |
| mriedem | anyway, just thinking out loud | 14:13 |
| *** Emine has joined #openstack-meeting-alt | 14:13 | |
| mriedem | carry on | 14:13 |
| efried | Do we have a way to ask for allocation candidates limited to a specific host yet? | 14:14 |
| mriedem | nope | 14:14 |
| mriedem | that was part of that force_hosts bug | 14:14 |
| efried | Seems like that's going to be necessary at some point. | 14:14 |
| mriedem | we talked about as an option | 14:14 |
| mriedem | right for the force_hosts bug, we just remove the limit to GET /allocation_candidates | 14:14 |
| mriedem | but what we really want is GET /allocation_candidates?in_tree=rp_uuid | 14:14 |
| mriedem | or something like that | 14:14 |
| efried | Cause then not only can you solve the force_hosts thing, you can ask for resize candidates in two batches: one with the superset-difference for same host, one for fresh new-size for other hosts. | 14:15 |
| efried | but in the meantime, you have to do two separate full requests and then filter them manually. | 14:15 |
| efried | Lemme know when you have that bug written. | 14:15 |
| mriedem | ok | 14:15 |
| efried | moving on, any other bug-like stuff to talk about? | 14:16 |
| efried | #topic opens | 14:16 |
| efried | Extraction | 14:16 |
| efried | #link extraction etherpad: https://etherpad.openstack.org/p/placement-extract-stein | 14:16 |
| efried | #link extraction ML thread (when should it happen? what should the status/position of the project be?) http://lists.openstack.org/pipermail/openstack-dev/2018-August/133445.html | 14:16 |
| efried | cdent/edleafe: what's the latest? | 14:16 |
| *** openstack changes topic to "opens (Meeting topic: nova-scheduler)" | 14:16 | |
| efried | (I hear the etherpad may be temporarily busted? | 14:16 |
| efried | ) | 14:16 |
| edleafe | We have a working repo | 14:16 |
| edleafe | Once you apply cdent's PR | 14:17 |
| edleafe | #link https://github.com/EdLeafe/placement/pull/3 | 14:17 |
| edleafe | IOW, tests passing | 14:17 |
| mriedem | so, | 14:18 |
| cdent | #link de-placement-ed nova https://review.openstack.org/#/c/596291/ | 14:18 |
| cdent | has been updated to use the latest pull | 14:18 |
| mriedem | is the proposal to seed the repo with a big pull request rather than a series of changes in gerrit? | 14:18 |
| mriedem | like, | 14:18 |
| mriedem | couldn't we extract to a repo and have non-voting CI jobs until the changes that make it work? | 14:18 |
| mriedem | and then make them voting? | 14:18 |
| edleafe | mriedem: that would be.... tedious | 14:19 |
| edleafe | Most of the changes I made are from a script | 14:19 |
| dansmith | we *have* to do that I think | 14:19 |
| mriedem | but it would be correctly using our code review system in openstack | 14:19 |
| cdent | we're not losing any history by doing it the way the experiments have been done thus far | 14:19 |
| edleafe | The plan was to get tests passing first, and then push the extracted repo | 14:19 |
| cdent | we just aren't creating that history in gerrit | 14:19 |
| dansmith | IMHO, we have to extract to a repo, have changes against CI jobs that use the alternate repo instead of the nova stuff, | 14:19 |
| dansmith | and then delete the nova stuff once we're not using it anymore | 14:19 |
| edleafe | dansmith: that's exactly what this is | 14:19 |
| mriedem | i'm confused | 14:20 |
| mriedem | https://github.com/EdLeafe/placement/pull/3/commits/a7805ca13a98e3a25876285c37d603aee9c65c3f is a github-only change right? | 14:20 |
| dansmith | edleafe: okay I thought you were implying that making the CI jobs work against the split was "tedious" | 14:20 |
| edleafe | dansmith: No, I meant doing a small change, pushing to gerrit, doing another small change, etc. | 14:21 |
| mriedem | but that's totally not following our community dev policy | 14:21 |
| dansmith | oh okay, yeah I don't think that can happen | 14:21 |
| mriedem | which is reviews in gerrit | 14:21 |
| edleafe | mriedem: there isn't a repo to review yet | 14:21 |
| mriedem | it looks to me like this is (1) fork nova repo, (2) remove nova stuff (3) pull request in fixes to make placement tests pass | 14:21 |
| mriedem | with the eventual plan to (4) seed the openstack/placement repo based on that repo from github | 14:22 |
| edleafe | 2) and 3) are intertwined | 14:22 |
| edleafe | but yeah | 14:22 |
| dansmith | I don't think I understand why 2 and 3 are intertwined | 14:22 |
| cdent | mriedem: yes, that's what's been discussed for a few weeks on the (now broken etherpad) and in the several emails and blog posts associated with this stuff. What is your preference? | 14:22 |
| mriedem | so i guess my point is i think the core team should be involved in reviewing these changes | 14:23 |
| mriedem | in gerrit | 14:23 |
| mriedem | not github pull requests | 14:23 |
| edleafe | dansmith: a lot of the test failures come from imports that reference the nova directory structure | 14:23 |
| cdent | mriedem: we can do that if you want, but as most of it is very mechanical it seemed... wasteful? | 14:23 |
| cdent | mriedem: but it sounds like you want (correct me if I'm wrong please): | 14:24 |
| edleafe | Isn't that the point of having tests? | 14:24 |
| cdent | 1. use the filter script | 14:24 |
| cdent | 2. seed a broken repo | 14:24 |
| cdent | 3. incremental review and fix things | 14:24 |
| mriedem | is there more? | 14:24 |
| cdent | 4. add some tests at the end | 14:25 |
| cdent | eof | 14:25 |
| cdent | s/add/automate/ | 14:25 |
| mriedem | 4) is also getting tempest-full / devstack working with the placement repo? | 14:25 |
| cdent | yes | 14:25 |
| mriedem | 5) drop code from nova? | 14:25 |
| mriedem | that's more inline with what i was expecting yes, | 14:25 |
| cdent | I was leaving 5 out of the picture entirely for now as it seemed like a "we'll visit that when we get there" | 14:25 |
| mriedem | edleafe's repo was an experimental is my understanding | 14:26 |
| mriedem | *experiment | 14:26 |
| edleafe | mriedem: It was more like a work area that we knew would be messy | 14:26 |
| cdent | so the reason we didn't 3 was because of what I said before about mechanical | 14:26 |
| cdent | and messy | 14:26 |
| mriedem | i think messy is ok | 14:26 |
| mriedem | i don't really think "fork into ed's github repo, do stuff, voila here is a thing" is the right way to do this per community norms | 14:27 |
| edleafe | mriedem: what exactly do you think a review will entail? | 14:27 |
| mriedem | it goes against (1) our code review system of using gerrit and (2) our core review team | 14:27 |
| cdent | I guess I wasn't really expecting that people would think of it that way, mriedem: the expectation was that people like you would come and look at ed's repo too | 14:27 |
| mriedem | looking at https://github.com/EdLeafe/placement/pull/3 these are individual commits | 14:27 |
| mriedem | so why wouldn't the same be pushed to gerrit? | 14:27 |
| cdent | they _can_ be. But I thought we were saving some hassle by doing it "outside". Apparently not. | 14:28 |
| mriedem | i was out for a week and don't read all the personal blog posts from everyone, so i'm coming in late, | 14:28 |
| mriedem | but this is my 2 cents | 14:28 |
| edleafe | mriedem: There are a couple dozen commits there. The initial commit I pushed has about that many steps. So are you saying that you want to commit at least 2 nova cores to review around 50 patches? | 14:29 |
| mriedem | it looks like the wrinkles have been ironed out in the github repo, | 14:29 |
| mriedem | and could easily be transitioned into a working repo with gerrit | 14:29 |
| mriedem | look, i'm one person | 14:29 |
| mriedem | i don't like the idea of doing this in github, outside gerrit and our core team, and then using it to seed the official openstack namespaced repo | 14:30 |
| mriedem | but if majority rules and doesn't want to deal with the incremental changes in gerrit, whatever | 14:30 |
| cdent | efried, jaypipes, alex_xu : thoughts? | 14:31 |
| *** ttsiouts has quit IRC | 14:31 | |
| edleafe | I would think that the core team's time could be better spent | 14:31 |
| jaypipes | sorry, I need to read back. | 14:31 |
| mriedem | melwitt should probably also at least be aware of the direction here and alternatives | 14:32 |
| edleafe | mriedem: just to be clear: there are no logical changes being made. Just pathing updates for the updated directory structure | 14:33 |
| efried | Well, I said a lot of the same things last week, but phrased as questions, and was satisfied with the answers. | 14:33 |
| edleafe | And changing some docs to only keep the placement-specific part | 14:33 |
| edleafe | *pars | 14:33 |
| efried | My understanding was that the commit history would still be available for anyone to look at. | 14:34 |
| edleafe | efried: yep | 14:34 |
| *** takashin has joined #openstack-meeting-alt | 14:35 | |
| edleafe | What you won't see is the gyrations needed to restructure placement from the way it is in Nova | 14:35 |
| efried | so | 14:35 |
| mriedem | well we have 2 +2s for a reason, so i figure this is no different if it's openstack | 14:35 |
| mriedem | should i just air out my concerns in the ML thread on this so we can move on or...? | 14:35 |
| efried | what I expressed before was that being able to see, in a gerrit review, the steps from raw to working, would be useful. | 14:35 |
| cdent | so, we can do it in gerrit, just the existing patches | 14:36 |
| edleafe | mriedem: I haven't gotten an answer from you on the question of whether you are committing 2 nova cores to review 50 or so patches in a timely fashion? | 14:36 |
| *** ianychoi has quit IRC | 14:36 | |
| mriedem | edleafe: i can help, it's not going to be my sole focus day in and out, but i'm sure efried is also going to be on board to help with that | 14:37 |
| mriedem | i can't speak for others really | 14:37 |
| cdent | but in order to do that we're going to need more concerted help from the entire nova group with regard to the repo setup, understanding zuul, etc. The current style was a shortcut to step into the future without needing to recruit as many people | 14:37 |
| efried | Like, as a placement core, I would like to be able to approve that initial seed patch by comparing base with PS<N> to see that e.g. 'import nova.api.openstack.placement.foo' was replaced with 'import placement.foo' but the guts of that file weren't changed. | 14:37 |
| edleafe | efried: so the initial commit to openstack/placement would be the full nova code base? | 14:37 |
| efried | I don't necessarily think we need to deviate much from the current process to make that happen. | 14:37 |
| efried | edleafe: Nah, I think it would be adequate if it was just the selected files, but in their form as they exist in nova initially. | 14:38 |
| mriedem | like i said, | 14:38 |
| mriedem | non-voting test jobs until it's passing | 14:38 |
| efried | i.e. I don't need to see fifty thousand file deletes between base and PS1. But I also don't want to see a couple hundred file adds with no delta context. | 14:38 |
| mriedem | with the series of incremental changes to get there | 14:38 |
| edleafe | I do feel like this is going to be a major time suck on the cores | 14:39 |
| efried | well, I don't think we need to span multiple change sets to go from seed to working. | 14:39 |
| efried | I think we should do that in one change set. | 14:39 |
| edleafe | wait.. what? You want a huge patch? | 14:39 |
| efried | Heck, I think we could even do it in one patch set. | 14:39 |
| mriedem | that's gonna be hard to review | 14:39 |
| edleafe | talk about going against the way we do things in openstack | 14:39 |
| efried | um | 14:39 |
| efried | sorry, maybe I've been misunderstanding how the repo would get seeded. | 14:40 |
| efried | We need an initial change set with all the file adds, no? | 14:40 |
| efried | it wasn't just going to... spring into existence already populated, with nobody reviewing or approving, was it? | 14:40 |
| jaypipes | FTR, I agree with mriedem and would prefer to review Gerrit patches for this. | 14:40 |
| edleafe | efried: a quick and dirty check showed that the single patch would be 23,000 lines | 14:41 |
| edleafe | jaypipes: and will you also commit to reviewing them? | 14:41 |
| jaypipes | edleafe: yes, but as I have repeatedly said on this topic, they will take lower priority to other nova items. | 14:42 |
| efried | edleafe: how many files? | 14:42 |
| *** ianychoi has joined #openstack-meeting-alt | 14:42 | |
| edleafe | efried: 410 | 14:43 |
| edleafe | jaypipes: This feels like a huge roadblock | 14:43 |
| jaypipes | I was under the impression that cdent and edleafe were experimenting with extraction automation/scripts in the GH repo and that we weren't actually going to be importing said GH repo as "the new placement". | 14:43 |
| edleafe | jaypipes: the GH repo was so that we could see what each other was doing | 14:44 |
| cdent | I'm a little confused. Do we have confidence that the placement tests test placement well and represent "the placement functionality"? | 14:44 |
| jaypipes | edleafe: I've been 100% upfront about that since cdent originally began discussing extraction. | 14:44 |
| edleafe | cdent: obviously not | 14:44 |
| *** jcoufal has quit IRC | 14:44 | |
| jaypipes | edleafe: ack. and I was fine with the GH collaboration/experimentation. | 14:44 |
| jaypipes | edleafe: I just didn't realize the plan was to make that GH repo the seed for a new placement. | 14:44 |
| efried | So here's what I would like to see: | 14:44 |
| efried | - One change set. | 14:44 |
| efried | - The initial patch set of that change should be the 410 files from nova in their raw form. I should be able to do a diff -r with nova (with whatever the flaggyflag is to ignore missing files), and get effectively no output. | 14:44 |
| efried | - Then the second patch set of that same change should be the resolved thingy that edleafe and cdent have been working out in the github repo. Now I can diff base with PS2 and see e.g. file renames and changes in import lines but effectively nothing else. | 14:44 |
| edleafe | ok, then I'll start working on a step-by-step patch series, starting with the results of the history-preserving extraction script | 14:45 |
| *** jcoufal has joined #openstack-meeting-alt | 14:45 | |
| mriedem | efried: i don't love that | 14:45 |
| edleafe | And I agree with Jay that this will all be lower priority, and will most likely languish | 14:45 |
| efried | perhaps I'm not understanding what you're suggesting, then. | 14:45 |
| mriedem | "The initial patch set of that change should be the 410 files from nova in their raw form. I should be able to do a diff -r with nova (with whatever the flaggyflag is to ignore missing files), and get effectively no output." | 14:46 |
| jaypipes | edleafe: it's not my priority, sorry. | 14:46 |
| mriedem | cool, agree, change 1 | 14:46 |
| mriedem | then separate changes to make things work, as i'm seeing in this pull request in githu | 14:46 |
| mriedem | *github | 14:46 |
| mriedem | otherwise there isn't really a point in doing it in gerrit if it's so big i can't review it coherently | 14:46 |
| *** dpawlik_ has quit IRC | 14:46 | |
| cdent | I'm a little confused on whether efried and mriedem are using the same definition of terms for 'patch set' and 'change set' | 14:46 |
| edleafe | mriedem: agree that huge patches suck | 14:47 |
| mriedem | before anyone goes off and doing anything, | 14:47 |
| cdent | I think what we are talking about is a stack of 25-50ish individual reviews | 14:47 |
| mriedem | i would like to first reply on the latest extraction ML thread to clarify understanding and raise the issue | 14:47 |
| *** GeraldK has quit IRC | 14:47 | |
| efried | Yeah, see, I don't see the point in multiple *change sets* for the initial seed repo. | 14:47 |
| *** takashin has quit IRC | 14:47 | |
| cdent | mriedem: if you're inclined, use the thread with "(technical)" in the subject? | 14:47 |
| mriedem | yes that's the one i was going to use | 14:48 |
| cdent | efried: so you're disagreeing with mriedem, or no, still not clear | 14:48 |
| efried | I.e. I don't get why we need to merge patently broken code initially. | 14:48 |
| mriedem | to sanely review the differences to get to working | 14:49 |
| mriedem | clearly https://github.com/EdLeafe/placement/pull/3 is made of individual commits | 14:49 |
| mriedem | for similar reasons | 14:49 |
| *** alexchadin has joined #openstack-meeting-alt | 14:49 | |
| mriedem | not just "here is 1 patch with 50 or some logical changes" | 14:49 |
| *** jcoufal_ has joined #openstack-meeting-alt | 14:49 | |
| *** jcoufal has quit IRC | 14:50 | |
| mriedem | looks like it's more around ~30 changes | 14:50 |
| mriedem | given ed's 2 here https://github.com/EdLeafe/placement/commits/master | 14:50 |
| edleafe | mriedem: you've also got to take into account my initial push | 14:50 |
| mriedem | isn't that https://github.com/EdLeafe/placement/commit/e3173faf59bd1453c3800b2bf57c2af8cfde1697 ? | 14:51 |
| *** macza has joined #openstack-meeting-alt | 14:51 | |
| edleafe | mriedem: Like I said, there were at least a couple dozen steps from the hsotory filter to that push | 14:51 |
| *** ttsiouts has joined #openstack-meeting-alt | 14:51 | |
| mriedem | so you would also post those in gerrit or not? | 14:52 |
| *** jcoufal_ has quit IRC | 14:52 | |
| edleafe | If the idea is that you want to see what changed from the original files to the placement repo, then yes | 14:52 |
| edleafe | To clarify, I don't *want* to post them to gerrit | 14:53 |
| mriedem | https://github.com/EdLeafe/placement/commit/e3173faf59bd1453c3800b2bf57c2af8cfde1697 itself might be ok | 14:53 |
| edleafe | I think this is a huge waste of time | 14:53 |
| edleafe | But I'm being outvoted | 14:53 |
| mriedem | i was thinking more https://github.com/EdLeafe/placement/commit/e3173faf59bd1453c3800b2bf57c2af8cfde1697 + https://github.com/EdLeafe/placement/commit/e984bef8587009378ea430dd1c12ca3e40a3c901 + what's in https://github.com/EdLeafe/placement/pull/3 | 14:53 |
| efried | Being able to "see what changed from the original files to the placement repo" is all I care about. But I don't think we get benefit from splitting it into a couple dozen change sets. | 14:53 |
| edleafe | My first commit was abandoned, and I force pushed the second. Like I said, this was supposed to be a messy work area | 14:53 |
| cdent | mriedem: you understand the change in pull/3 are basically the same as the changes in pull/2 except broken apart so people can have insight into what's going on, yeah? | 14:54 |
| efried | IMO there's no reason for gerrit to contain "show your work" info. | 14:54 |
| edleafe | efried: So you'd be able to review something like https://github.com/EdLeafe/placement/commit/e3173faf59bd1453c3800b2bf57c2af8cfde1697 ? | 14:54 |
| mriedem | sure, an experimental repo to mess around and see what works is fine, and that's what i thought this was doing; i didn't expect this to eventually be "ok here we go - official placement" | 14:54 |
| cdent | (the main different is that we chose to have some different paths for modules) | 14:54 |
| cdent | it's still a seed | 14:55 |
| cdent | because until it is gating it isn't anything | 14:55 |
| mriedem | edleafe: that change is mostly file moves and deleting nova stuff right? | 14:55 |
| edleafe | mriedem: we learn as we go. Once we have it figured out, then we re-run the steps and push clean to the openstack repo | 14:55 |
| *** markvoelker has joined #openstack-meeting-alt | 14:55 | |
| edleafe | mriedem: and some import pathing changes | 14:55 |
| mriedem | sure that's all pretty trivial to review | 14:55 |
| edleafe | that's the point - it *is* trivial. What needs to be reviewed is the final product | 14:56 |
| efried | right. So no need to do it in a zillion change sets. | 14:56 |
| *** gcb_ has joined #openstack-meeting-alt | 14:56 | |
| mriedem | edleafe: so how would you expect me to review the final product? pull it down and diff it against the nova repo? | 14:56 |
| mriedem | or just not review it at all and assume that if tests are passing it's good enough? | 14:57 |
| edleafe | Oh, I dunno - see that the tests are all there, and that they are passing? | 14:57 |
| efried | edleafe: I would be reviewing such a thing by diffing against nova, yes. And then the next delta I would be able to mostly skim, because it would comprise mostly renames and import changes, and the evidence that it's fully mechanically correct is that it passes tests. | 14:57 |
| mriedem | by that logic i don't need to review any changes ever right? | 14:57 |
| edleafe | Unless you don't have confidence in the tests, of course | 14:57 |
| mriedem | as long as tests pass | 14:57 |
| cdent | i have to leave very soon to get physio on my shoulder. jaypipes was internet contagious. it is also a holiday today for me, so i'm not really coming back today. Can people please be sure that whatever is decided today it gets reflected on the email thread? | 14:57 |
| efried | yes | 14:57 |
| *** hongbin has joined #openstack-meeting-alt | 14:58 | |
| edleafe | Yeah, I think I'll find something else to occupy myself today | 14:58 |
| efried | mriedem: Skimming to assure myself that what changed was imports not content, plus tests passing, equals approval in this case, yes. | 14:58 |
| mriedem | "what changed was imports not content" is what i mostly care about | 14:58 |
| efried | extending that to "any change ever" is obviously spurious | 14:58 |
| mriedem | and why we do reviews | 14:58 |
| efried | And I don't see the point in splitting that across multiple change sets. | 14:59 |
| mriedem | so with <1 minute, | 14:59 |
| efried | Is that the only thing we're discussing here? | 14:59 |
| mriedem | i can reply with the options to the ML thread | 14:59 |
| edleafe | Be sure to include the load on the nova cores in that post | 14:59 |
| efried | #endmeeting | 15:00 |
| *** openstack changes topic to "OpenStack Meetings || https://wiki.openstack.org/wiki/Meetings/" | 15:00 | |
| mriedem | you can review my post and include it if i missed something :P | 15:00 |
| openstack | Meeting ended Mon Aug 27 15:00:14 2018 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 15:00 |
| openstack | Minutes: http://eavesdrop.openstack.org/meetings/nova_scheduler/2018/nova_scheduler.2018-08-27-14.00.html | 15:00 |
| openstack | Minutes (text): http://eavesdrop.openstack.org/meetings/nova_scheduler/2018/nova_scheduler.2018-08-27-14.00.txt | 15:00 |
| openstack | Log: http://eavesdrop.openstack.org/meetings/nova_scheduler/2018/nova_scheduler.2018-08-27-14.00.log.html | 15:00 |
| efried | edleafe, cdent: I would like to understand the freeze thing, can we continue in -placement? | 15:00 |
| edleafe | sure | 15:00 |
| *** tetsuro has left #openstack-meeting-alt | 15:02 | |
| *** jcoufal has joined #openstack-meeting-alt | 15:09 | |
| *** e0ne has quit IRC | 15:19 | |
| *** markstur has joined #openstack-meeting-alt | 15:23 | |
| *** rmascena__ is now known as raildo | 15:26 | |
| *** dpawlik has joined #openstack-meeting-alt | 15:30 | |
| *** alexchadin has quit IRC | 15:32 | |
| *** mriedem has left #openstack-meeting-alt | 15:33 | |
| *** dpawlik has quit IRC | 15:34 | |
| *** markvoelker has quit IRC | 15:36 | |
| *** efried has quit IRC | 15:37 | |
| *** munimeha1 has joined #openstack-meeting-alt | 15:41 | |
| *** ttsiouts has quit IRC | 15:42 | |
| *** efried has joined #openstack-meeting-alt | 15:43 | |
| *** ttsiouts has joined #openstack-meeting-alt | 15:43 | |
| *** ttsiouts has quit IRC | 15:47 | |
| *** gcb_ has quit IRC | 15:48 | |
| *** pashkin_ has quit IRC | 15:57 | |
| *** Emine has quit IRC | 16:00 | |
| *** markstur has quit IRC | 16:05 | |
| *** ccamacho is now known as ccamacho|brb | 16:10 | |
| *** cdent has quit IRC | 16:11 | |
| *** cdent has joined #openstack-meeting-alt | 16:16 | |
| *** radeks_ has quit IRC | 16:26 | |
| *** radeks has joined #openstack-meeting-alt | 16:29 | |
| *** raildo_ has joined #openstack-meeting-alt | 16:31 | |
| *** raildo has quit IRC | 16:32 | |
| *** tssurya has quit IRC | 16:34 | |
| *** jlviva-viva is now known as jlvillal | 16:40 | |
| *** raildo_ is now known as raildo | 16:41 | |
| *** e0ne has joined #openstack-meeting-alt | 16:41 | |
| *** kopecmartin has quit IRC | 16:41 | |
| *** raildo has quit IRC | 16:48 | |
| *** raildo has joined #openstack-meeting-alt | 16:48 | |
| *** markstur has joined #openstack-meeting-alt | 16:50 | |
| *** raildo_ has joined #openstack-meeting-alt | 17:03 | |
| *** raildo has quit IRC | 17:05 | |
| *** yamahata has quit IRC | 17:11 | |
| *** rmascena__ has joined #openstack-meeting-alt | 17:16 | |
| *** raildo has joined #openstack-meeting-alt | 17:18 | |
| *** raildo_ has quit IRC | 17:18 | |
| *** rmascena__ has quit IRC | 17:21 | |
| *** raildo_ has joined #openstack-meeting-alt | 17:22 | |
| *** raildo has quit IRC | 17:23 | |
| *** raildo_ has quit IRC | 17:28 | |
| *** raildo has joined #openstack-meeting-alt | 17:40 | |
| *** radeks has quit IRC | 17:41 | |
| *** yamahata has joined #openstack-meeting-alt | 17:45 | |
| *** dpawlik has joined #openstack-meeting-alt | 17:47 | |
| *** dpawlik has quit IRC | 17:51 | |
| *** markstur has quit IRC | 18:04 | |
| *** dtrainor has quit IRC | 18:14 | |
| *** gyee has joined #openstack-meeting-alt | 18:27 | |
| *** gyee has quit IRC | 18:28 | |
| *** gyee has joined #openstack-meeting-alt | 18:28 | |
| *** cdent has quit IRC | 18:28 | |
| *** dtrainor has joined #openstack-meeting-alt | 18:44 | |
| *** hongbin has quit IRC | 18:53 | |
| *** hongbin has joined #openstack-meeting-alt | 18:54 | |
| *** radeks has joined #openstack-meeting-alt | 18:55 | |
| *** diablo_rojo has joined #openstack-meeting-alt | 19:17 | |
| *** e0ne has quit IRC | 19:27 | |
| *** e0ne has joined #openstack-meeting-alt | 19:29 | |
| *** e0ne has quit IRC | 19:44 | |
| *** e0ne has joined #openstack-meeting-alt | 20:00 | |
| *** dtrainor_ has joined #openstack-meeting-alt | 20:05 | |
| *** dtrainor has quit IRC | 20:06 | |
| *** macza has quit IRC | 20:14 | |
| *** macza has joined #openstack-meeting-alt | 20:18 | |
| *** hongbin has quit IRC | 20:26 | |
| *** hongbin has joined #openstack-meeting-alt | 20:27 | |
| *** raildo has quit IRC | 20:32 | |
| *** e0ne has quit IRC | 20:37 | |
| *** raildo has joined #openstack-meeting-alt | 20:54 | |
| *** raildo has quit IRC | 20:54 | |
| *** erlon has quit IRC | 21:02 | |
| *** markvoelker has joined #openstack-meeting-alt | 21:04 | |
| *** markvoelker has quit IRC | 21:13 | |
| *** dustins has quit IRC | 21:24 | |
| *** radeks has quit IRC | 21:36 | |
| *** munimeha1 has quit IRC | 21:44 | |
| *** rcernin has joined #openstack-meeting-alt | 21:51 | |
| *** slaweq has quit IRC | 21:55 | |
| *** apetrich has quit IRC | 22:09 | |
| *** slaweq has joined #openstack-meeting-alt | 22:11 | |
| *** apetrich has joined #openstack-meeting-alt | 22:14 | |
| *** slaweq has quit IRC | 22:16 | |
| *** slaweq has joined #openstack-meeting-alt | 22:32 | |
| *** slaweq has quit IRC | 22:37 | |
| *** hongbin has quit IRC | 22:45 | |
| *** macza has quit IRC | 22:50 | |
| *** macza has joined #openstack-meeting-alt | 22:51 | |
| *** bnemec has quit IRC | 23:00 | |
| *** bnemec has joined #openstack-meeting-alt | 23:01 | |
| *** jcoufal has quit IRC | 23:16 | |
| *** jaypipes has quit IRC | 23:24 | |
| *** jaypipes has joined #openstack-meeting-alt | 23:25 | |
| *** tpsilva has quit IRC | 23:39 | |
| *** dpawlik has joined #openstack-meeting-alt | 23:47 | |
| *** dpawlik has quit IRC | 23:52 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!