Tuesday, 2017-01-24

*** dustins has quit IRC00:07
*** tommylikehu_ has joined #openstack-manila00:10
*** tommylikehu_ has quit IRC00:16
*** akerr has quit IRC00:30
*** cknight has joined #openstack-manila01:01
*** a-pugachev has quit IRC01:05
openstackgerritTommyLike proposed openstack/manila: Enable IPv6 in manila(network plugins and drivers)  https://review.openstack.org/40677601:26
*** mtanino has quit IRC01:30
openstackgerritTommyLike proposed openstack/manila: Enable IPv6 in manila(allow access)  https://review.openstack.org/31232101:30
*** mtanino has joined #openstack-manila01:32
*** cknight has quit IRC01:42
openstackgerritRodrigo Barbieri proposed openstack/manila: Add mountable snapshots support  https://review.openstack.org/34552601:52
*** kaisers_ has joined #openstack-manila02:05
*** kaisers has quit IRC02:08
*** akerr has joined #openstack-manila02:28
openstackgerritHa Dung proposed openstack/manila: Fixes some current typo errors on Manila project.  https://review.openstack.org/42316402:34
*** mtanino has quit IRC02:40
*** harlowja has quit IRC02:44
openstackgerritTommyLike proposed openstack/manila: Enable IPv6 in manila(network plugins and drivers)  https://review.openstack.org/40677603:43
*** ociuhandu has quit IRC03:57
*** ganso has quit IRC04:14
*** ociuhandu has joined #openstack-manila04:21
*** tommylikehu_ has joined #openstack-manila05:07
*** tommylikehu_ has quit IRC05:11
*** tommylikehu1 has joined #openstack-manila05:20
*** tommylikehu has quit IRC05:20
*** tommylikehu1 is now known as tommylikehu05:20
*** ianychoi has joined #openstack-manila05:26
*** makowals_ has quit IRC05:29
*** makowals has joined #openstack-manila05:33
*** lpetrut has joined #openstack-manila06:15
*** harlowja has joined #openstack-manila06:34
*** lpetrut has quit IRC06:56
*** nkrinner_afk is now known as nkrinner06:59
*** lpetrut has joined #openstack-manila07:16
*** jprovazn has joined #openstack-manila07:17
*** harlowja has quit IRC07:26
*** lpetrut has quit IRC07:50
*** openstackgerrit has quit IRC08:03
*** lpetrut has joined #openstack-manila08:06
*** zengyingzhe has quit IRC08:21
*** vponomaryov1 has joined #openstack-manila08:37
*** pcaruana has joined #openstack-manila08:45
*** openstackgerrit has joined #openstack-manila08:49
openstackgerritVitaliy Levitski proposed openstack/manila-ui: Add MapRFS protocol  https://review.openstack.org/42188408:49
*** lpetrut has quit IRC08:56
*** makowals has quit IRC08:56
*** makowals_ has joined #openstack-manila08:59
*** a-pugachev has joined #openstack-manila09:03
openstackgerritHelen Walsh proposed openstack/manila: VMAX manila plugin - Support for VMAX in Manila  https://review.openstack.org/40485909:05
*** ganso has joined #openstack-manila09:15
*** dsariel has joined #openstack-manila09:48
*** alyson_ has joined #openstack-manila09:59
gansovponomaryov, vponomaryov1: Hi Valeriy. I noticed you're reviewing the mountable patch, I am addressing all your comments right now (have already addressed the existing ones, I am testing the HTTPMethodNotAllowed change)10:09
gansovponomaryov, vponomaryov1: Please let me know when you're done so I can submit a new patch10:11
vponomaryov1ganso: Hello, I am in process and publishing comments right away10:13
gansovponomaryov1: thanks10:13
vponomaryov1ganso: you are responsible now for "mountable_snapshots" feature?10:15
gansovponomaryov1: yes10:15
gansovponomaryov1: well, the whole team here is now, actually10:17
vponomaryov1ganso: yeah, I remember that you have "BIG" support ))10:22
vponomaryov1ganso: do you have cheerleaders among them? ))10:22
gansovponomaryov1: unfortunately no10:24
gansovponomaryov1: as you can notice, coding style is varying a lot within the same patch10:32
vponomaryov1ganso: yes, I see10:33
vponomaryov1ganso: style of "Crouching Tiger" and "Hidden Dragon" =)10:34
gansovponomaryov1: I haven't watched that movie10:35
vponomaryov1ganso: in some places - "drunken monkey" ))10:35
gansovponomaryov1: drunken monkey still would be better than sleepy monkey10:35
vponomaryov1ganso: have some of you tested this feature with LVM driver?10:38
gansovponomaryov1: yes10:38
gansovponomaryov1: it needs the code you mentioned as being separate bugfix10:38
vponomaryov1ganso: exactly mounting snapshot?10:38
gansovponomaryov1: else it does not work10:38
gansovponomaryov1: yes, we tested it, the scenario test patch that is dependent on that one tests that as well10:39
*** yumiriam has joined #openstack-manila10:41
*** tommylikehu_ has joined #openstack-manila10:52
*** rraja has joined #openstack-manila11:07
vponomaryov1ganso: letting you know I've finished review of server side change11:09
gansovponomaryov1: thanks11:10
vponomaryov1ganso: but you have there bugs, that client change discovered -> http://logs.openstack.org/25/345625/23/check/gate-manilaclient-dsvm-neutron-functional-ubuntu-xenial/62024a2/logs/screen-m-shr.txt.gz?level=TRACE11:11
gansovponomaryov1: I'll take a look11:12
vponomaryov1gouthamr: for case you read it, change with microversion 2.30 requires commit to client too, at least for having reasenote11:16
gansovponomaryov1: mapping.soft_delete(session, update_status=True ==> AttributeError: 'NoneType' object has no attribute 'soft_delete'11:17
gansovponomaryov1: there is a "if not mapping" right above that statement11:17
gansovponomaryov1: any idea why it would be None and not enter condition?11:17
vponomaryov1ganso: I guess it is object11:22
vponomaryov1ganso: sql object11:22
vponomaryov1ganso: s/sql/sqla/11:23
vponomaryov1ganso: so, there should be other kind of check to verify absense of record11:23
vponomaryov1but I agree, it is VERY strange11:24
openstackgerritRamana Raja proposed openstack/manila: WIP ganesha: dynamically update access of share  https://review.openstack.org/42459811:33
openstackgerritRamana Raja proposed openstack/manila: WIP: Refactor and rename CephFSNativeDriver  https://review.openstack.org/42120111:45
openstackgerritRamana Raja proposed openstack/manila: cephfs: add nfs protocol support  https://review.openstack.org/42460511:56
openstackgerritRamana Raja proposed openstack/manila: [WIP] cephfs: add nfs protocol support  https://review.openstack.org/42460511:56
openstackgerritRamana Raja proposed openstack/manila: [WIP] cephfs: add nfs protocol support  https://review.openstack.org/42460511:59
openstackgerritRamana Raja proposed openstack/manila: [WIP] Refactor and rename CephFSNativeDriver  https://review.openstack.org/42120111:59
*** porrua has joined #openstack-manila12:04
openstackgerritRodrigo Barbieri proposed openstack/manila: Add mountable snapshots support  https://review.openstack.org/34552612:04
openstackgerritOpenStack Proposal Bot proposed openstack/manila: Updated from global requirements  https://review.openstack.org/42461612:11
*** gouthamr has joined #openstack-manila12:14
*** catintheroof has joined #openstack-manila12:16
*** shausy has joined #openstack-manila12:28
*** lpetrut has joined #openstack-manila12:37
*** mtanino has joined #openstack-manila13:00
*** lpetrut has quit IRC13:04
*** dustins has joined #openstack-manila13:05
openstackgerritAlyson proposed openstack/python-manilaclient: Add mountable snapshots support to manila client  https://review.openstack.org/34562513:18
*** tommylikehu_ has quit IRC13:26
*** gouthamr has quit IRC13:32
openstackgerritHelen Walsh proposed openstack/manila: VMAX manila plugin - Support for VMAX in Manila  https://review.openstack.org/40485913:41
*** akerr has quit IRC13:52
*** tommylikehu_ has joined #openstack-manila13:59
*** tommylikehu_ has quit IRC13:59
*** tommylikehu_ has joined #openstack-manila13:59
*** mtanino has quit IRC14:13
*** gouthamr has joined #openstack-manila14:16
*** breitz has quit IRC14:30
*** eharney has joined #openstack-manila14:37
bswartztommylikehu tommylikehu_: can you share the devstack config you used for testing of ipv6 with manila?14:42
*** lpetrut has joined #openstack-manila14:43
bswartztommylikehu tommylikehu_: I have created several different configurations but I haven't yet found one that allows a Nova VM to communicate with the LVM driver over ipv614:43
tbarronbswartz: tangentially related to ^^ are you by any chance using bridged KVM ubuntu xenial vm as your devstack host machine?14:46
tbarronbswartz: I am and it auto ipv6 doesn't work on its main external interface14:46
tbarrons/it//14:47
*** rraja has quit IRC14:47
tbarronbswartz: my home network has ipv6 of sorts, i.e. centurylink ipv6 "rd"14:48
bswartztbarron: I have tried many things14:48
bswartztbarron: in the process I found 4 bugs in devstack14:48
bswartz>_<14:48
bswartzit's clear nobody has tested devstack with IPv6 and provider networks14:48
*** gouthamr_ has joined #openstack-manila14:49
bswartztbarron: https://review.openstack.org/42444414:49
tbarronphysical centos and fedora machines get non link local ipv6 addr on main external interface, but my ubuntu xenial machine does not14:49
bswartztbarron: part of the problem is that there are too many options for networking in devstack14:49
bswartzthe number of possible configuration is dizzying and impossible to test14:49
tbarronbswartz: right14:49
tbarronbswartz: I've just been trying to get it to work with the neutron ipv6 cidrs assigned to the "public" and "private" networks, but so far no dice14:50
*** gouthamr has quit IRC14:50
tbarronbswartz: so I thought I'd debug by manually updating exports on my host/hypervisor attempting ipv6 mounts from the guest14:51
tbarronbswartz: or from the host itself14:51
*** gouthamr_ is now known as gouthamr14:51
bswartztbarron: I'm close to having a working config to share14:51
bswartztbarron: I need to fix a bug in manila now to get it fully working14:52
bswartztbarron: I was hoping tommylikehu had some alternative config that would work out of the box14:52
tbarronbswartz: but my hypervisor/devstack host only has a non-link-local ipv6 addr on br-ex, it's not acquiring one on its main external interface14:52
bswartzI bet it's possible to use the l3 agent and create a virtual router that make this "just work"14:52
bswartzhowever I haven't stumbled across that config yet14:53
bswartzpersonally I find it easier to debug when there is no l3 agent involved so I'm pushing ahead with that config14:53
tbarronbswartz: you'd think that the default ipv6 cidrs assigned as neutron subnets to the basic admin/public and demo/private subnets would be usable14:53
bswartztbarron: they *are* usable14:53
tbarronbswartz: routable14:54
bswartzthere just aren't routes to them from the hypervisor14:54
bswartzthat's by design -- it's a security issue14:54
tbarronbswartz: yeah, I can get a dhcp6 assignment to my guest just fine14:54
bswartzremember there's no NAT for ipv6 and thus no "floating IPs"14:54
tbarronbswartz: yes, that's why I thought it would in a sense be easier14:54
bswartzheh14:55
bswartzwe are all so addicted to NAT that we don't realize how hard it will be to give up when we move to ipv614:55
tbarronmaybe there's some adjustment that needs to be done to that little router that connects public and private networks14:55
bswartzI'm one of the few people on this planet that thinks NAT6 is a good thing14:55
*** belmoreira has joined #openstack-manila14:56
tbarronbswartz: whether good or bad, we should be able to make it work w/o floating ips14:56
*** jprovazn has quit IRC14:57
openstackgerritBen Swartzlander proposed openstack/manila: Fix devstack plugin to not depend on private network  https://review.openstack.org/42468514:59
bswartztbarron: it will work14:59
bswartztbarron: after I fix all the bugs14:59
* bswartz was up late last night fixing bugs14:59
bswartzvponomaryov1: this is what we talked about -> https://review.openstack.org/42468515:01
vponomaryov1bswartz: thanks, LGTM15:02
*** tommylikehu_ has quit IRC15:09
openstackgerritMerged openstack/manila: Rename consistency group modules to share groups  https://review.openstack.org/40986415:09
openstackgerritMerged openstack/manila: Manila Share Groups  https://review.openstack.org/33509315:10
*** tommylikehu_ has joined #openstack-manila15:11
openstackgerritOpenStack Proposal Bot proposed openstack/manila: Updated from global requirements  https://review.openstack.org/42461615:11
*** cknight has joined #openstack-manila15:12
tommylikehu_hey bswartz, tbarron does the IPv6 feature have something related to devstack?15:12
openstackgerritRodrigo Barbieri proposed openstack/manila-ui: Implement Share Migration Ocata improvements  https://review.openstack.org/40630715:13
*** mtanino has joined #openstack-manila15:13
*** gouthamr has quit IRC15:13
*** cdelatte has joined #openstack-manila15:13
vponomaryov1bswartz, markstur: after merging server side change for share groups, need to merge client -> https://review.openstack.org/#/c/33512015:14
*** mtanino has quit IRC15:15
bswartzvponomaryov1: no15:15
*** mtanino has joined #openstack-manila15:15
bswartzerr sorry vponomaryov115:15
vponomaryov1bswartz: ?15:15
bswartznm15:15
bswartztommylikehu_: obviously your patch doesn't modify the devstack plugin15:15
bswartztommylikehu_: however properly testing ipv6 will require that I think15:16
bswartztommylikehu_: we were hoping you could tell us how you did your testing15:16
tommylikehu_:( I did not realised that we the devstack should be changed.15:17
tommylikehu_The tested procedure for me about IPv6 is configure backend with lvm which use the host's ipv6 address and filter backend with extra-specs15:17
bswartztommylikehu_: it doesn't need to be done as part of this patch, we can do it later15:17
vponomaryov1tommylikehu_: how was your feature tested?15:17
tommylikehu_then add the access rule for agent with IPv6 address15:18
bswartztommylikehu_: but those of us testing it want to see a mount from a nova vm to the lvm driver over ipv6 succeed15:18
vponomaryov1tommylikehu_: have you tested real IPv6 access?15:18
bswartztommylikehu_: were you able to get a mount to succeed?15:18
bswartztommylikehu_: and if so, how did you get the routing to work?15:18
tommylikehu_the agent  nodes are not belonged to the openstack15:20
bswartzwhat agent?15:21
bswartzyou mean the client you mounted from was not a nova VM?15:21
tommylikehu_no15:22
bswartzno it wasn't a nova VM or no it was a nova VM?15:22
tommylikehu_it was not a nova vm15:22
bswartzk15:23
bswartzthat's an easier case to test15:23
bswartzI should have started with that one15:23
bswartztbarron: ^15:23
bswartzI'm very close to getting an actual nova VM to work now though so I'm going to pursue that case a bit longer15:23
tbarronyeah, i don't see a lot of point in this unless we know how to mount shares to nova instances15:27
tbarronit's good work, don't get me wrong, just not an exposable feature till then15:27
bswartztbarron: it has value even without that15:27
bswartztbarron: because we care about non-nova use cases15:27
bswartztbarron: however there's no reason we shouldn't be able to get it working with nova too15:27
bswartzthe main problems are that devstack has too many networking options and too little documentation15:28
tommylikehu_bswartz, tbarron if we can not make the generic driver and at least one of the vendor drivers get merged into this version of IPv6, could this be little valued15:33
tommylikehu_?15:34
bswartztommylikehu_: I'm okay with LVM support only15:36
bswartztommylikehu_: we have to get started somewhere and ipv6 is an essential feature15:36
bswartzassuming we can get ipv6 merged today or tomorrow vendors can start working on driver support in pike15:36
bswartztommylikehu_: you do have at least 1 merge conflict to resolve15:37
tommylikehu_bswartz: ok, I will fix that.15:37
*** nkrinner is now known as nkrinner_afk15:44
*** tommylikehu_ has quit IRC15:46
*** ociuhandu has quit IRC15:48
*** breitz has joined #openstack-manila15:51
gansobswartz, tbarron, vponomaryov1, markstur, cknight: Hello, could we please merge https://review.openstack.org/#/c/406307/ ?15:55
openstackgerritRodrigo Barbieri proposed openstack/manila: Add mountable snapshots support  https://review.openstack.org/34552615:56
*** shausy has quit IRC15:56
marksturvponomaryov1: share groups client needs microversion update doesn't it (looking now)15:57
vponomaryov1markstur: it doesn't15:59
openstackgerritAlyson proposed openstack/python-manilaclient: Add mountable snapshots support to manila client  https://review.openstack.org/34562515:59
marksturvponomaryov1: saw some suspicious looking 2.29s15:59
bswartzomg devstack completed without errors16:00
bswartzfirst time this happened since 11pm last night16:00
vponomaryov1markstur: 2.30 was not merged as it does nto require changes to client except change of version16:00
vponomaryov1ganso: are you sure that in your change for manila-ui there is no need to change other APIs after bumping used microversion?16:03
marksturvponomaryov1: share_group_snapshots.py  wraps("2.29")16:03
marksturmax version bumped up to 2.3116:05
vponomaryov1markstur: strange, very strange16:06
vponomaryov1markstur: tought I changed it16:06
vponomaryov1markstur: thanks16:06
marksturmicrostrange16:06
vponomaryov1will update16:06
marksturwe should use MACROversions.  They are easier to see16:06
*** dmellado has quit IRC16:07
bswartzmarkstur: nanoversions16:07
marksturbswartz: Ooooh. That sounds interesting. Next thing!16:07
bswartz2.00000003116:07
*** breitz has quit IRC16:07
gansovponomaryov1: share migration is 2.2916:07
bswartz2.00000003216:07
*** breitz has joined #openstack-manila16:08
marksturbswartz: how about we just use timestamps. API as of now()16:08
bswartzmarkstur: only if you use gettimeofday() and tv_usec16:09
*** a-pugachev has quit IRC16:10
bswartzthe API could change every microsecond16:10
marksturbswartz: Not with our gate16:10
bswartzlol16:10
bswartzDuncanT proposed using semver for API versions16:11
bswartzI have reservations about that idea16:11
bswartzokay I'm banged my head against the wall long enough that there's a hole in the wall -- going to get some food and drive into the office16:12
*** pcaruana has quit IRC16:16
openstackgerritValeriy Ponomaryov proposed openstack/python-manilaclient: Add share group support to Manila client  https://review.openstack.org/33512016:17
marksturvponomaryov1: Sorry I didn't catch that last night. I thought it was ready to go.16:17
*** a-pugachev has joined #openstack-manila16:17
vponomaryov1markstur: I thought I changed it ))16:17
vponomaryov1markstur: anyway, check this out -> https://review.openstack.org/33512016:18
vponomaryov1ganso: it is not the answer for question16:20
*** ociuhandu has joined #openstack-manila16:21
gansovponomaryov1: I haven't noticed anything break16:21
vponomaryov1markstur: what about https://review.openstack.org/#/c/355264/ ?16:21
gansovponomaryov1: even if so, a separate patch should be created16:21
gansovponomaryov1: not in scope of my patch16:21
marksturvponomaryov1: OK. So you are just turning it off to skip redundant tests. Thought that might be the case.16:23
vponomaryov1ganso: like this -> https://github.com/openstack/manila-ui/blob/7c90c469/manila_ui/api/manila.py#L22816:23
vponomaryov1ganso: actually, it is part of the patch, because you change used microversion16:24
marksturvponomaryov1: I thought it was odd you skipped it for those but then turned it on by default for everyone else <-- good explanation though. Thanks.16:24
gansovponomaryov1: no, a separate patch needs to be create to address that according to its microversion, as we are doing with python-manilaclient16:25
gansovponomaryov1: but it should come before my patch16:25
vponomaryov1ganso: bump of microversion in manila-ui should be done with update of APIs we use there, so they are compatible with this microversion or nanoversion16:26
gansovponomaryov1: yes, should, but we changed server deprecating nova_network but we haven't updated manila-ui16:26
vponomaryov1markstur: so, I answered your questions there?16:27
marksturvponomaryov1: Yes. Just doing a quick review now. Just in case.16:27
vponomaryov1ganso: we also haven't bumped used microversion16:27
gansovponomaryov1: yes, but we should have16:28
gansovponomaryov1: also, just an observation, some changes are automatically incorporated into manila-ui when we just bump the microversion, because they are done in python-manilaclient16:28
gansovponomaryov1: I am not sure if the deprecation of nova_network falls into this category16:29
vponomaryov1ganso: it becomes server error now16:29
vponomaryov1ganso: with your change16:29
vponomaryov1ganso: can you create share-network with your patch?16:32
gansovponomaryov1: no16:32
vponomaryov1ganso: using manila-ui?16:32
vponomaryov1ganso: no - you tried and failed, or no - you cannot try?16:33
gansovponomaryov1: I tried and failed16:33
vponomaryov1ganso: it is unacceptable, don't you agree?16:34
gansovponomaryov1: Recoverable error: create() got an unexpected keyword argument 'nova_net_id'16:34
gansovponomaryov1: I agree, someone should fix it16:34
*** ociuhandu has quit IRC16:40
rhagartyhello... I'm also running into issues using manila-ui. I've started to implement this - https://blueprints.launchpad.net/manila/+spec/manila-share-group-ui16:45
rhagartyin Horizon IRC, it looks like latest pyton-novaclient has issues, and it is recommended to go back to 6.0.016:47
vponomaryov1rhagarty: "forbidden" thing?16:47
*** dmellado has joined #openstack-manila16:48
*** a-pugachev has quit IRC16:50
rhagartyvponomaryov1: the error I was seeing was it couldn't access nova quotas16:52
vponomaryov1rhagarty: right, "forbidden" error on nova quotas16:52
rhagartywith 6.0.0 it gets past that, but now seeing errors creating shares16:53
rhagartyhttp://pastebin.com/ZngqsX9s16:53
*** dmellado has quit IRC16:53
*** dsariel has quit IRC16:53
vponomaryov1rhagarty: I haven't seen this problem, looks like something funny with novaclient again, you can avoid usage of novaclient16:56
vponomaryov1rhagarty: in your case you can use any other driver except generic16:56
vponomaryov1rhagarty: also, "dummy" one16:56
*** akapil has joined #openstack-manila16:56
vponomaryov1rhagarty: it is recommended to use when you care about APIs only16:56
vponomaryov1rhagarty: like in your case - support in manila UI16:57
rhagartyvponomaryov1: ok, thanks16:57
vponomaryov1rhagarty: example of its configuration is not in the docs, but in our mainla repo and used in CI16:57
vponomaryov1rhagarty: see https://github.com/openstack/manila/blob/master/contrib/ci/pre_test_hook.sh and https://github.com/openstack/manila/blob/master/contrib/ci/post_test_hook.sh searching for "dummy" word16:59
*** dmellado has joined #openstack-manila16:59
vponomaryov1rhagarty: and manila config in CI with this fake driver -> http://logs.openstack.org/59/404859/19/check/gate-manila-tempest-minimal-dsvm-dummy-ubuntu-xenial/bba6028/logs/etc/manila/manila.conf.txt.gz17:00
vponomaryov1rhagarty: you do not need reinstall devstack, you can just update manila config and restart services adding new backends17:01
vponomaryov1rhagarty: that use this driver17:01
*** a-pugachev has joined #openstack-manila17:01
vponomaryov1rhagarty: in this case novaclient will not make problems at all17:02
rhagartyvponomaryov1: thank you.17:02
rhagartyvponomaryov1: btw, will be needing to set up microversion support in manila-ui to access share group APIs. Not sure if anyone else has looked at this yet...17:03
openstackgerritRodrigo Barbieri proposed openstack/manila-ui: Bump microversion to 2.26  https://review.openstack.org/42474817:03
gansovponomaryov1: ^ happy?17:03
bswartzback17:07
vponomaryov1ganso: I already have tests for it, don't you mind if I upload it to your patch?17:07
gansovponomaryov1: go ahead17:08
openstackgerritValeriy Ponomaryov proposed openstack/manila-ui: Bump microversion to 2.26  https://review.openstack.org/42474817:08
*** xyang_ has joined #openstack-manila17:09
*** cdelatte has quit IRC17:11
openstackgerritRodrigo Barbieri proposed openstack/manila-ui: Bump microversion to 2.26  https://review.openstack.org/42474817:13
openstackgerritMerged openstack/manila-ui: Add MapRFS protocol  https://review.openstack.org/42188417:14
gansobswartz: https://review.openstack.org/#/c/345526/ is ready17:15
bswartzganso: ty17:15
*** Yogi1 has joined #openstack-manila17:15
rhagartymicroversion question - looks like the manila-ui just passes the a version number to the client. What happens if the server and/or client don't support that version?17:21
bswartzganso: did you rebase recently?17:21
gansobswartz: yes, after share groups17:21
bswartzrhagarty: if the client doesn't support that version, then the installation has been screwed up -- dependencies should catch that case17:22
bswartzrhagarty: if the server doesn't support the version, then microversion negotiation should save you, unless you're insanely out of date17:23
rhagartybswartz: and how would you handle deprecation? Like feature_a works until 2.24 and feature_b workis in > 2.25?17:23
bswartzrhagarty: applications can write 2 code paths if they want to support both feature_a and feature_b, but if they don't then they're stuck with whichever one they choose17:24
vponomaryov1rhagarty: manila UI, providing only single microversion, is of single version too, so, it either support something or not17:24
rhagartyvponomaryov1: so how do you show that in the UI? things just don't work anymore?17:25
vponomaryov1rhagarty: the only problem - to update all usages API usages in manila UI bumping microversion17:25
bswartzrhagarty: currently manila-ui is in the latter case as vponomaryov1 says17:25
vponomaryov1rhagarty: not "doesn't work", "available" only that is supported by current microversion17:26
rhagartyvponomaryov1: but you would only have to bump the API's that care about microversions. Everything else just uses latest17:26
vponomaryov1rhagarty: yes, update changed ones17:26
vponomaryov1rhagarty: microversion changes can be tiny17:27
vponomaryov1rhagarty: like this -> https://review.openstack.org/42474817:27
rhagartyvponomaryov1: so if feature_a has a tab and requires 2.25, but server is running at 2.24, it would be nice to not show tab17:28
vponomaryov1rhagarty: manila UI uses same microversion for every call17:28
vponomaryov1rhagarty: so, if server does not support it, you get nothing at all17:28
bswartzganso: any other changes in ps61 other than the rebase?17:29
gansobswartz: reverted the HTTP 405 error to 40017:29
bswartzganso: why not 404?17:29
gansobswartz: IMO 400 is more appropriate than 404, and can be consistent across acess-allow/deny and access-list17:30
rhagartyvponomaryov1: for now, but what happens when you want to replace a feature. Cinder has this issue with going from consistency groups to generic groups. They want to show one or the other depending on current server microversion support17:30
bswartzvponomaryov1: that may be what we do, but we don't have to -- we could make the UI smarter, which is what I think rhagarty is suggesting17:30
gansobswartz: I don't like the idea of saying HTTP 404 Not found: "Canno control access of snapshot because it is not supported"17:30
vponomaryov1rhagarty: as bswartz points out, I just described current approach17:31
gansobswartz: s/Canno/Cannot17:31
bswartzganso: I agree it's shitty17:31
vponomaryov1ganso: actually, 404 is the answer you get when URL does not exist17:31
gansovponomaryov1: yes, but the URL does exist17:32
bswartzganso: you have to admin that 400 Bad Request is also confusing because it implies that the client send malformed data17:32
vponomaryov1ganso: but should not17:32
bswartzs/admin/admit/17:32
vponomaryov1ganso: it is restriction of API router usage17:32
gansovponomaryov1: the URL + resource combination is not valid though17:32
bswartzganso: the resource is part of the URL in REST17:33
rhagartywell, I know there is an effort to standardize on getting back current server/client microversion support. Once this is in place, I suggest manila adopt it, and then use that information to make the UI work "better"17:33
vponomaryov1ganso: in GET you have only URL17:33
bswartzthe deeper problem here is that HTTP 400 is already used in many similar situations17:34
vponomaryov1rhagarty: but I cannot say I like this idea as a developer ))17:34
vponomaryov1rhagarty: it will be much more complicated17:34
vponomaryov1rhagarty: to support each microversion separately,17:35
bswartzvponomaryov1: it's more work for us, but better experience for the user17:35
bswartzI think that's the argument rhagarty is making17:35
gansobswartz: how about 403?17:35
vponomaryov1bswartz: actually, we should focus only on latest microversions for each release17:35
bswartzthere is no technical reason we can't do it, it's a question of effort17:35
rhagartyvponomaryov1: not that much harder... it just effects those APIs that were implemented after microversions. And you set them once and forget about them until they need to be replaced.17:36
bswartzvponomaryov1: that's the higher priority but if we had more resources we would do what rhagarty suggests too17:36
bswartzganso: 403 is my 3rd choice17:36
bswartzganso I prefer 404, then 400, then 40317:36
vponomaryov1bswartz: and, since we release manila-ui with all openstack, we really need only single microversion - latest for release17:36
rhagartyI'll sign up to do what I suggested17:37
gansobswartz: can we settle for 400 then? :P17:37
bswartzganso: honestly I just hate how REST limits itself to HTTP error codes only17:37
vponomaryov1rhagarty, bswartz: support of multiple microversions is useful only when we have single version of manila-ui17:37
*** shausy has joined #openstack-manila17:37
vponomaryov1rhagarty, bswartz: not tied to openstack releases17:37
gansobswartz: since it will have the advantage of being the same response for allow and deny17:37
bswartzvponomaryov1: it's not unreasonable to say that the ocata version of manila-ui should work with both ocata servers and newton servers17:38
vponomaryov1ganso: what is the point having the same answer?17:38
vponomaryov1bswartz: actually, it is question of being compatible with Horizon too17:38
*** cdelatte has joined #openstack-manila17:38
gansovponomaryov1: just consistency17:39
vponomaryov1bswartz: it is really possible that you will just fail to use manila-ui with other version of horizon17:39
vponomaryov1ganso: for consistency we can raise same error in all our APIs17:39
bswartzvponomaryov1: horizon version and manila-ui version must be compatible, as they're installed together17:39
vponomaryov1ganso: don't see value in this kind of "consistency"17:39
bswartzhowever the server could run elsewhere and there could be more than 1 server to talk to17:39
* bswartz crosses fingers17:40
bswartzabout to boot another ipv6 vm17:40
gansovponomaryov1: thing is, error is the same for access_allow/deny and access-list, for the exact same error, I think it is preferable if the response code was consistent17:41
rhagartyand there are "real world" reasons to stick with a working version of a server, but want to have the latest UI17:41
vponomaryov1bswartz: "complex" means "error-prone"r17:41
vponomaryov1ganso: API URL are different17:41
vponomaryov1ganso: consistency should be for allow/deny only17:41
gansovponomaryov1: what code should allow/deny have then?17:42
vponomaryov1ganso: have you read latest comments in gerrit?17:42
*** belmoreira has quit IRC17:42
gansobswartz, markstur, tbarron, xyang_: Jenkins has voted https://review.openstack.org/#/c/42474817:43
vponomaryov1rhagarty: bugfixes in manila Ui and Horizon?17:43
*** xyang_ has quit IRC17:43
rhagartyvponomaryov1: sure17:43
gansovponomaryov1: it says should stay 400, but how about this argument: "<bswartz> ganso: you have to admin that 400 Bad Request is also confusing because it implies that the client send malformed data" ??17:44
gansovponomaryov1: it is not malformed at all17:44
vponomaryov1ganso: that is why 400 is not really suitable, it is not malformed17:45
gansovponomaryov1: then why would we continue using 400 for POST?17:45
vponomaryov1ganso: it is correct, but server refuses to process it17:46
gansovponomaryov1: so, what is the correct code for that?17:46
vponomaryov1ganso: it is debatable, as you can see17:46
bswartzhonestly I hate the REST API error code situation so much I'm okay with using 400 as a "catch all" error code17:47
gansobswartz: +117:47
bswartzI think that's how it's done in other projects17:47
bswartznova and neutron give me HTTP 400 all the time when I made requests that a valid except for some value in the database17:47
bswartzthat are* valid17:48
vponomaryov1bswartz, ganso: we need to bump minimal client version for UI17:48
gansovponomaryov1: another patch?17:49
bswartzvponomaryov: https://review.openstack.org/#/c/424205/ https://review.openstack.org/#/c/424207/17:49
bswartzI will do another release later this week but I can do additional ones as needed17:49
vponomaryov1ganso: to requirements project17:49
bswartzgood point17:49
gansovponomaryov1: oh I see17:50
vponomaryov1bswartz: to requirements rpoject so we could have automatic requirements update17:50
bswartzyes17:52
bswartzg-r.txt and uc.txt17:52
*** akapil has quit IRC17:52
bswartzvponomaryov1: if you want to push I can +117:52
bswartzI have a meeting in a few minutes and I'm still fighting with the ipv6 routing tables17:53
vponomaryov1bswartz: ok, I will make a change17:54
gansomarkstur: thanks17:56
*** a-pugachev has quit IRC17:57
marksturganso: I had to put an end to it. Couldn't just sit back and watch you and Valeriy +1 your own patches   ;)18:00
gansomarkstur: lol18:00
gansomarkstur: it is sad to not be able to use +2 powers18:01
marksturIt is good to pick on someone for voting on their own patch -- but in cases like this it is actually good to know that the contributors both approve of the other18:01
*** yumiriam1 has joined #openstack-manila18:02
*** yumiriam has quit IRC18:04
vponomaryov1ganso, bswartz: https://review.openstack.org/#/c/424781/18:06
*** akapil has joined #openstack-manila18:07
*** yumiriam1 has quit IRC18:07
gansovponomaryov1: won't it need to be updated when we merge the share groups client patch?18:07
*** akapil has quit IRC18:07
openstackgerritMerged openstack/manila: VMAX manila plugin - Support for VMAX in Manila  https://review.openstack.org/40485918:08
*** akapil has joined #openstack-manila18:08
*** yumiriam has joined #openstack-manila18:09
vponomaryov1ganso: only when we will add its support to client18:10
vponomaryov1ganso: 1.12.0 supports 2.29 - it is what you need18:10
gansovponomaryov1: ok18:10
vponomaryov1markstur, ganso: temporary amnesia about 24hour rule detected ))18:11
*** jprovazn has joined #openstack-manila18:11
gansovponomaryov1: does 24 hour apply to FF?18:11
gansovponomaryov1: hour *rule18:11
vponomaryov1ganso: I am just kidding ))18:12
gansovponomaryov1: as you can see, I am not good with jokes18:12
vponomaryov1ganso: today or in general? ))18:12
gansovponomaryov1: in general18:13
marksturwe can laugh about it tomorrow18:13
*** shausy has quit IRC18:14
gansovponomaryov1, markstur, bswartz, tbarron, cknight: https://review.openstack.org/#/c/406307 can now be merged without breaking previously microversioned changes18:15
openstackgerritRodrigo Barbieri proposed openstack/manila: Add mountable snapshots support to HNAS driver  https://review.openstack.org/41147418:25
*** akapil has quit IRC18:25
openstackgerritRodrigo Barbieri proposed openstack/manila: Mountable snapshots scenario tests  https://review.openstack.org/41200118:28
* vponomaryov1 thinks that markstur is waiting while ganso sets +1 on https://review.openstack.org/#/c/406307 18:42
marksturvponomaryov1: Stop spying on me18:43
vponomaryov1markstur: coincidence18:44
gansovponomaryov1, markstur: thanks18:50
gansovponomaryov1: it seems bswartz has agreed with code 400 here https://review.openstack.org/#/c/345526/18:50
gansovponomaryov1: is there anything holding you back?18:50
vponomaryov1ganso: I am looking at diff18:51
gansovponomaryov1: great, thanks18:51
vponomaryov1ganso: and making note about that 400 stuff ))18:51
vponomaryov1"evil"18:51
vponomaryov1^_^18:51
gansovponomaryov1: ='(18:52
vponomaryov1ganso: https://review.openstack.org/#/c/345526/59..61/manila/db/sqlalchemy/models.py18:55
vponomaryov1ganso: first comment half fixed18:55
openstackgerritMerged openstack/manila-ui: Implement Share Migration Ocata improvements  https://review.openstack.org/40630718:55
vponomaryov1ganso: line 213 should have been fixed too18:56
vponomaryov1ganso: "not touched" - more correctly18:56
gansovponomaryov1: oops :(18:56
*** xyang_ has joined #openstack-manila18:56
gansovponomaryov1: ok I'll wait for the last set of comments before I upload the updated patch18:57
vponomaryov1ganso: ok18:58
*** xyang_ has quit IRC18:59
*** ianychoi has quit IRC19:00
bswartzhey I'm back19:01
vponomaryov1ganso: no nee dto use "six" in https://review.openstack.org/#/c/345526/59..61/manila_tempest_tests/tests/api/test_snapshot_rules.py19:04
vponomaryov1ganso: just wrapping with "list" would be enough19:05
vponomaryov1ganso: have you solved problem found by client change?19:12
vponomaryov1ganso: s/problem/problems/19:12
gansovponomaryov1: yes19:13
vponomaryov1ganso: and what was the problem with "NoneType"?19:14
gansovponomaryov1: incorrect ID was being passed, but I am unsure about how the object was able to skip the condition19:15
*** lpetrut has quit IRC19:16
bswartzcrap19:17
bswartzdoes anyone know if cirros even has ipv6 support?19:17
bswartzmy problem might be that the VM itself doesn't talk ipv619:17
* bswartz goes to get an image of a real OS19:18
vponomaryov1bswartz: our service image should have ipv6 support19:18
vponomaryov1bswartz: if I am not mistaken19:18
vponomaryov1ganso: those 5 is all I found19:19
bswartzstandard ubuntu cloud images are smaller than our service image19:19
vponomaryov1bswartz: it does not have samba )19:19
vponomaryov1bswartz: and nfs by default19:19
bswartzI don't care just need the client bits19:19
bswartzI can always apt-get install stuff after I'm able to SSH in19:20
bswartzproblem with cirros is I can't even ssh or ping619:20
gansovponomaryov1: thanks, working on them19:21
*** eharney has quit IRC19:22
openstackgerritRodrigo Barbieri proposed openstack/manila: Add mountable snapshots support  https://review.openstack.org/34552619:30
gansovponomaryov1: fixed ^19:33
*** yumiriam has quit IRC19:36
*** eharney has joined #openstack-manila19:37
bswartzokay it wasn't the guest19:40
bswartzstill neutron that's screwed up19:41
*** harlowja has joined #openstack-manila19:41
cknightganso: NetApp CI is green again. https://review.openstack.org/#/c/357545/19:42
cknightganso: We enabled snapshot revert tests, so all other patches will fail our CI until this merges.19:42
gansocknight: give me 10min I'll +2, I am on the road19:43
cknightganso: No worries, thanks!19:44
cknightganso: And I hope you're not driving.19:44
bswartzganso has a neural link to IRC so he can talk on IRC and drive at the same time19:45
gansobswartz: lol19:45
gansocknight: no not driving at this moment  :)19:45
vponomaryov1ganso: you are literally on the road? ))19:47
vponomaryov1ganso: I like fresh air too19:47
vponomaryov1ganso: but not that much19:47
gansovponomaryov1: was literally on the road19:48
gansovponomaryov1: getting close to my building now19:48
gansocknight: done19:53
cknightganso: Thanks!19:54
*** timcl has quit IRC19:56
*** xyang_ has joined #openstack-manila20:13
*** xyang_ has quit IRC20:15
*** timcl has joined #openstack-manila20:23
*** xyang_ has joined #openstack-manila20:33
*** xyang1 has joined #openstack-manila20:36
openstackgerritMerged openstack/manila: NetApp: Support share revert to snapshot  https://review.openstack.org/35754520:43
bswartzvponomaryov1: you still waiting on anything for the mountable snapshot patch?20:52
*** jprovazn has quit IRC20:52
gansovponomaryov1: server and client patches passed CI20:54
*** ChanServ changes topic to "OpenStack Share File Systems | Manila | Review focus https://etherpad.openstack.org/p/manila-ocata-code-review-focus"20:54
bswartzI should have updated the topic last week20:55
openstackgerritOpenStack Proposal Bot proposed openstack/manila: Updated from global requirements  https://review.openstack.org/42461620:55
*** gcb has joined #openstack-manila21:01
*** kaisers_ has quit IRC21:01
*** porrua has quit IRC21:01
*** kaisers has joined #openstack-manila21:02
vponomaryov1bswartz: mountable snapshots destiny is in your hands21:04
*** alyson_ has quit IRC21:07
*** lpetrut has joined #openstack-manila21:10
tbarronbswartz: tommylikehu there is an issue with ipv6 exports that breaks lvm quite apart from the routing from hypervisor to host21:14
tbarronbswartz: tommylikehu I put notes in my latest reply on https://review.openstack.org/#/c/40677621:14
tbarronbswartz: tommylikehu but essentially the 'exportfs ' command is returning shell status zero but failing to actually do an export21:15
tbarronbswartz: tommylikehu appears to be a known nfs-kernel-server bug21:15
tbarronbswartz: just saw your remarks above about cirros21:16
tbarronbswartz: apparently it does, but you need separate interface than for ipv421:16
tbarronbswartz: rather than getting cloudinit to make it work for me I moved to using a CentOS image, which was (for me) much easier to set up21:17
tbarronbswartz: I set it up for dhcp6 and dhcp4 on the same interface and it acquires both an addr from the neutron v4 cidr and from the neutron v6 cidr on the subnets associated with the neutron network that is attached to that single nic21:18
tbarronbswartz: I tried acquiring ipv6 addr with stateless slacc and got nothing21:19
bswartztbarron: thanks21:19
bswartztbarron: those kinds of bugs should be fixed21:19
bswartztbarron: I'm about to give up (for now) on trying to get nova vms to have working ipv621:20
tbarronbswartz: I'd be interested in your devstack setup in any case21:20
bswartzI was hoping that investing a day in it would pay dividends, but all I'm getting is frustration dividends21:21
tbarronbswartz: you may have one end of this working and I may have another21:21
bswartztbarron: I tried hard to make provider networks work21:21
bswartzit sort of worked for ipv4, although I somehow broke cloudinit21:21
bswartzfor some reason ipv6 packet just go into a black hole21:21
bswartztbarron: do you happen to know how to change neutron to use the noop firewall driver?21:22
bswartzI'd like to remove neutron's security layers so I can rule them out as the source of problems21:22
tbarronbswartz: no, but if I find out I'll share21:22
tbarronagree, had the same thought21:22
tbarronbswartz: do you have an ipv6 address (non link local) on your hypervisor external interface?21:23
tbarronbswartz: I can't get one there (though I have it on br-ex)21:23
tbarronbswartz: dunno if it's b/c of my virsh definition for the hypervisor or something about the weird ipv6-rd setup I have at home.21:24
tbarronmy physical machines get ipv6 addr on their external interface just fine with ipv6-rd on my home router (the way I do IPv6 with CenturyLink ISP)21:25
tbarronbswartz: anyways, we have way too may obstacles in the way of doing end-to-end (actual mount to compute instance) testing of this new feature and I really think we need to see the results of such testing.21:27
tbarronbswartz: there may be some infra here worth merging in ocata anyways so that continues research/progress can be made on this front.21:27
bswartztbarron: yes I have ipv6 addresses everywhere21:28
tbarronbswartz: but I don't see any end-user-exposable feature in this at the moment, despite my supporting the overall initiative21:28
bswartzand routes are working and slaac is working21:28
*** timcl has quit IRC21:28
bswartzbut packets that enter the land of neutron are never seen again21:28
tbarronbswartz: for me too with physical machines but not with my xenial vm/hypervisor21:28
bswartzyou use virt-manager/virsh on your hypervisor?21:29
*** kaisers has quit IRC21:29
bswartzor something else?21:29
*** kaisers_ has joined #openstack-manila21:29
tbarronbswartz: but within that vm/hypervisor neutron dhcp works to my compute instance21:29
tbarron:D21:29
tbarronI use virt-manager/virsh21:29
tbarronif you have a chance just dumpxml in a pastebin for me21:30
bswartzokay I have a frontend and a backend network configured in virt-manager21:30
bswartzyeah 1 sec21:30
*** catintheroof has quit IRC21:35
*** catintheroof has joined #openstack-manila21:35
*** catintheroof has quit IRC21:35
*** kaisers has joined #openstack-manila21:45
*** kaisers_ has quit IRC21:48
*** Yogi1 has quit IRC21:50
*** cknight has quit IRC21:52
openstackgerritMerged openstack/python-manilaclient: Add share group support to Manila client  https://review.openstack.org/33512021:58
*** breitz has quit IRC21:59
*** breitz has joined #openstack-manila22:00
*** kaisers_ has joined #openstack-manila22:01
*** kaisers__ has joined #openstack-manila22:02
*** kaisers__ has quit IRC22:04
*** kaisers has quit IRC22:04
*** kaisers has joined #openstack-manila22:05
*** kaisers_ has quit IRC22:05
*** vponomaryov1 has quit IRC22:07
*** eharney has quit IRC22:18
*** dustins has quit IRC22:19
openstackgerritOpenStack Proposal Bot proposed openstack/manila-ui: Updated from global requirements  https://review.openstack.org/42488422:26
openstackgerritRodrigo Barbieri proposed openstack/python-manilaclient: Add mountable snapshots support to manila client  https://review.openstack.org/34562522:31
*** lpetrut has quit IRC22:44
*** david-lyle has quit IRC22:50
*** david-lyle has joined #openstack-manila22:53
*** xyang_ has quit IRC22:57
*** xyang1 has quit IRC22:59
*** gcb has quit IRC23:06
*** harlowja has quit IRC23:08
*** tommylikehu_ has joined #openstack-manila23:23
*** tommylikehu_ has quit IRC23:28
*** mtanino_ has joined #openstack-manila23:29
*** mtanino has quit IRC23:30
*** harlowja has joined #openstack-manila23:58

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!