| *** iurygregory_ is now known as iurygregory | 06:28 | |
| opendevreview | Itsik Kanias proposed openstack/horizon master: [WIP]Adding 3 regression tests to horizon upstream https://review.opendev.org/c/openstack/horizon/+/806137 | 11:17 |
|---|---|---|
| opendevreview | Manpreet Kaur proposed openstack/horizon master: [WIP]Changes for tacker-horizon integration tests https://review.opendev.org/c/openstack/horizon/+/803465 | 13:44 |
| opendevreview | Manpreet Kaur proposed openstack/horizon master: [WIP]Changes for tacker-horizon integration tests https://review.opendev.org/c/openstack/horizon/+/803465 | 14:01 |
| opendevreview | Manpreet Kaur proposed openstack/horizon master: Changes for tacker-horizon integration tests https://review.opendev.org/c/openstack/horizon/+/803465 | 15:38 |
| amotoki | vishalmanchanda: manpreetk: when I looked at https://review.opendev.org/c/openstack/horizon/+/803465, I wonder why only tacker-horzion needs such workaround? while I am not against a workaround, do you know what is the root cause? | 15:54 |
| manpreetk | amotoki: Hi, in tacker-horizon we have 2 panel groups, "VNF Management" and "NFV Orchestration". The "VNF Management" is default panel & remains expanded in NFV dashboard. Whereas "NFV Orchestration" is collapsed. The menu item expansion code in horizon integration framework expands only those menu items (any level 1,2 or 3) if only previous menu item at same level was expand. | 16:07 |
| manpreetk | For example transition from "Project" to "NFV" dashboard, they are at same level so NFV is clicked and expanded. But in case of "NFV Orchestration" there isn't any such transition so code skip expansion. | 16:07 |
| amotoki | manpreetk: I wonder what is special in tacker-horizon. I don't know the full context, but at least a hard-coded thing does not make sense to me. | 16:48 |
| amotoki | manpreetk: if it happens in generall, it should be improved but I am not sure it is genral enough so far. perhaps vishalmanchanda or e0ne knows more context. | 16:49 |
| amotoki | if so, it would be nice to cover such context in the commit message :-) | 16:52 |
| manpreetk | amotoki: Totally agree to not hard-coded things in source code . As suggested will add the context in the commit message. Thank you so much for feedback. | 16:56 |
| amotoki | manpreetk: I am not sure why such workaround is required at all. is it discussed already? | 16:59 |
| manpreetk | amotoki: Well formally there isn't any discussion held by me, but as per my understanding I have pushed the code. Would appreciate if you could share a better solution than one proposed. | 17:06 |
| amotoki | manpreetk: what do you mean by "than one proposed."? at least, a hard-encoded one would be appreciated as I mentioned | 17:07 |
| manpreetk | amotoki: vishalmanchanda: e0ne: Could we please continue this discussion tomorrow as its late hours, meanwhile I will update commit message with detail context. Thanks | 17:55 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!