| *** sumanth has joined #openstack-horizon | 00:01 | |
| *** alexpilotti has quit IRC | 00:10 | |
| *** iamjarvo has quit IRC | 00:16 | |
| *** Drago has quit IRC | 00:19 | |
| openstackgerrit | tinytmy proposed openstack/horizon: fix usage property(vcpus, vcpu_hours) error use https://review.openstack.org/152376 | 00:23 |
|---|---|---|
| *** Piet_ has joined #openstack-horizon | 00:27 | |
| *** Sukhdev has quit IRC | 00:29 | |
| *** yingjun has joined #openstack-horizon | 00:30 | |
| *** jbell8 has joined #openstack-horizon | 00:30 | |
| *** lhcheng has quit IRC | 00:31 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 00:36 |
| *** hurgleburgler1 has joined #openstack-horizon | 00:39 | |
| *** hurgleburgler has quit IRC | 00:39 | |
| openstackgerrit | Merged openstack/horizon: Fix failed wizard tests https://review.openstack.org/188612 | 00:41 |
| *** alexvictorchan has quit IRC | 00:44 | |
| sqchen | krotscheck: r1chardj0n3s: Fix of those failed tests just merged. :) | 00:45 |
| r1chardj0n3s | \o/ | 00:45 |
| *** tosky has quit IRC | 00:50 | |
| *** mwhagedorn has quit IRC | 00:50 | |
| *** Desh_Shukla has quit IRC | 00:51 | |
| *** hurgleburgler1 has quit IRC | 00:51 | |
| *** KunalGandhi has quit IRC | 00:52 | |
| *** chlong has quit IRC | 00:52 | |
| *** amotoki has joined #openstack-horizon | 00:53 | |
| *** chlong has joined #openstack-horizon | 00:54 | |
| *** lhcheng has joined #openstack-horizon | 00:55 | |
| *** ybathia has quit IRC | 01:02 | |
| *** yamamoto has quit IRC | 01:04 | |
| *** yamamoto has joined #openstack-horizon | 01:05 | |
| *** alanf-mc has quit IRC | 01:05 | |
| *** nlahouti has quit IRC | 01:06 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move framework.util.form to validators https://review.openstack.org/185475 | 01:09 |
| *** yingjun has quit IRC | 01:10 | |
| *** bpokorny has quit IRC | 01:10 | |
| *** yingjun has joined #openstack-horizon | 01:10 | |
| *** yamamoto has quit IRC | 01:12 | |
| *** dscottsf has joined #openstack-horizon | 01:13 | |
| *** dscottsf has quit IRC | 01:14 | |
| *** jwy has quit IRC | 01:16 | |
| *** dscottsf has joined #openstack-horizon | 01:17 | |
| *** dscottsf has quit IRC | 01:18 | |
| openstackgerrit | Merged openstack/horizon: ngReorg - move utils from dashboad-app https://review.openstack.org/185140 | 01:24 |
| r1chardj0n3s | \o/ one down! | 01:24 |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move framework.util.form to validators https://review.openstack.org/185475 | 01:24 |
| sqchen | \o/ | 01:24 |
| r1chardj0n3s | sqchen: pls check comment on https://review.openstack.org/#/c/185132/ :) | 01:27 |
| sqchen | r1chardj0n3s: where is the setting.py patch? | 01:28 |
| r1chardj0n3s | it's in that patch... | 01:28 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Filtered projects based on selected domain in create user modal https://review.openstack.org/188645 | 01:30 |
| esp | TravT_: did you get your bouncer working? | 01:36 |
| esp | I’m I talking to it now… | 01:37 |
| *** jwy has joined #openstack-horizon | 01:43 | |
| *** yamamoto has joined #openstack-horizon | 01:46 | |
| *** ducttape_ has joined #openstack-horizon | 01:51 | |
| *** dboik has joined #openstack-horizon | 01:52 | |
| *** dboik_ has joined #openstack-horizon | 01:54 | |
| *** dboik has quit IRC | 01:57 | |
| r1chardj0n3s | sqchen: we should discuss that patch here, not in gerrit :) | 01:57 |
| sqchen | k, did u see my last comments? | 01:58 |
| r1chardj0n3s | yep, I'm not sure why you're still -1 | 01:59 |
| r1chardj0n3s | maybe we used a set once to do the collection, but we don't any more, we use a list. order is preserved. | 01:59 |
| sqchen | u sure the order is correct? | 01:59 |
| r1chardj0n3s | yes | 01:59 |
| sqchen | ok, +1’ing. :) | 02:00 |
| r1chardj0n3s | all we do is remove additional occurrences of a file in the list after the first one | 02:00 |
| r1chardj0n3s | thanks! | 02:00 |
| sqchen | r1chardj0n3s: As for 186295, thanks for the explanation. I like your idea, but how can we make sure other projects are not going to brocken? | 02:05 |
| *** yingjun has quit IRC | 02:05 | |
| r1chardj0n3s | yep, well that's a concern of course, but basically if a project is currently building off of those templates they *still* can build off those templates. they've not gone away, they're still in the same template namespace in django. | 02:09 |
| *** iamjarvo has joined #openstack-horizon | 02:15 | |
| *** yingjun has joined #openstack-horizon | 02:15 | |
| *** iamjarvo has quit IRC | 02:15 | |
| *** iamjarvo has joined #openstack-horizon | 02:15 | |
| *** Piet_ has quit IRC | 02:15 | |
| *** ducttape_ has quit IRC | 02:15 | |
| sqchen | r1chardj0n3s: If they replace openstack_dashboard with their own django application, they lost the case.html staff. Actually I am prototyping of all the possible way of using Horizon, this is one of the possibilty that I want to use internally in our team. | 02:18 |
| r1chardj0n3s | ok, but I guess the problem is: exactly how much should the framework do before it's become the application. In this case, I believe the framework is encoding too much application. | 02:19 |
| r1chardj0n3s | it's imposing a structure, and a set of itself, on any application that uses it | 02:19 |
| sqchen | Actally I will remove my -1, since I really like the change! just want to raising a discussion. | 02:19 |
| r1chardj0n3s | ("a set of itself" referring to the forced use of everything in _scripts and _conf - the latter which *defines the top-level angular application name*) | 02:20 |
| r1chardj0n3s | yes! discussion is good :) | 02:20 |
| sqchen | At least I am seriuse when looking into your code. :) | 02:20 |
| r1chardj0n3s | yes! thanks :) | 02:21 |
| r1chardj0n3s | wait. are you having a go at my cowsay +1? :P | 02:21 |
| r1chardj0n3s | (for a patch that basically un-broke master from a previous bad, naughty patch? :) | 02:22 |
| * r1chardj0n3s goes away for a while | 02:22 | |
| *** stevemar has quit IRC | 02:40 | |
| *** jwy has quit IRC | 02:59 | |
| *** yingjun has quit IRC | 03:03 | |
| *** lhcheng has quit IRC | 03:08 | |
| *** zul has quit IRC | 03:08 | |
| *** yingjun has joined #openstack-horizon | 03:09 | |
| *** yingjun has quit IRC | 03:10 | |
| *** sqchen has quit IRC | 03:11 | |
| *** zul has joined #openstack-horizon | 03:21 | |
| *** bpokorny has joined #openstack-horizon | 03:21 | |
| *** amotoki has quit IRC | 03:22 | |
| *** sumanth has quit IRC | 03:30 | |
| *** sumanth has joined #openstack-horizon | 03:32 | |
| *** hurgleburgler has joined #openstack-horizon | 03:34 | |
| r1chardj0n3s | . | 03:39 |
| *** lhcheng has joined #openstack-horizon | 04:05 | |
| *** lhcheng has quit IRC | 04:08 | |
| *** masco has joined #openstack-horizon | 04:12 | |
| *** neelabh has joined #openstack-horizon | 04:18 | |
| *** lhcheng has joined #openstack-horizon | 04:18 | |
| *** lhcheng has quit IRC | 04:19 | |
| *** rushiagr_away is now known as rushiagr | 04:22 | |
| *** rushiagr is now known as rushiagr_away | 04:27 | |
| *** lhcheng has joined #openstack-horizon | 04:28 | |
| *** Longgeek has joined #openstack-horizon | 04:30 | |
| *** Longgeek has quit IRC | 04:30 | |
| *** amotoki has joined #openstack-horizon | 04:31 | |
| *** iamjarvo has quit IRC | 04:31 | |
| *** jamielennox is now known as jamielennox|away | 04:32 | |
| *** Longgeek has joined #openstack-horizon | 04:32 | |
| *** iamjarvo has joined #openstack-horizon | 04:36 | |
| *** hurgleburgler has quit IRC | 04:37 | |
| *** jingliuqing has joined #openstack-horizon | 04:40 | |
| *** rushiagr_away is now known as rushiagr | 04:40 | |
| *** oro_ has joined #openstack-horizon | 04:42 | |
| *** lhcheng has quit IRC | 04:48 | |
| *** Longgeek_ has joined #openstack-horizon | 04:50 | |
| *** Longgeek has quit IRC | 04:54 | |
| *** sumanth has quit IRC | 04:54 | |
| *** Ephur has quit IRC | 04:55 | |
| *** sumanth has joined #openstack-horizon | 04:55 | |
| *** lhcheng has joined #openstack-horizon | 04:56 | |
| *** Desh_Shukla has joined #openstack-horizon | 04:59 | |
| *** fedexo has joined #openstack-horizon | 05:00 | |
| *** bpokorny has quit IRC | 05:01 | |
| *** lhcheng has quit IRC | 05:01 | |
| sumanth | hi | 05:01 |
| openstackgerrit | Neill Cox proposed openstack/horizon: WIP - Replace makemessages with babel https://review.openstack.org/188665 | 05:03 |
| jingliuqing | cool babel | 05:08 |
| *** esp has left #openstack-horizon | 05:12 | |
| *** Desh_Shukla has quit IRC | 05:22 | |
| *** iamjarvo has quit IRC | 05:32 | |
| *** mitz has quit IRC | 05:41 | |
| *** josecastroleon has joined #openstack-horizon | 05:50 | |
| *** belmoreira has joined #openstack-horizon | 05:55 | |
| *** vishwana_ has quit IRC | 05:56 | |
| sumanth | is there anyway to chek the version of DOA, horizon is using | 05:57 |
| *** lhcheng has joined #openstack-horizon | 05:58 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/188673 | 06:02 |
| *** jbell8 has quit IRC | 06:03 | |
| *** mrunge has joined #openstack-horizon | 06:10 | |
| *** jbell8 has joined #openstack-horizon | 06:10 | |
| *** romainh has joined #openstack-horizon | 06:11 | |
| *** jingliuqing has quit IRC | 06:13 | |
| *** amotoki has quit IRC | 06:16 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/188678 | 06:18 |
| *** romainh has quit IRC | 06:20 | |
| *** amotoki has joined #openstack-horizon | 06:25 | |
| *** jbell8 has quit IRC | 06:28 | |
| *** jbell8 has joined #openstack-horizon | 06:29 | |
| *** KunalGandhi has joined #openstack-horizon | 06:33 | |
| *** Kunal has joined #openstack-horizon | 06:33 | |
| *** amotoki has quit IRC | 06:36 | |
| *** amotoki has joined #openstack-horizon | 06:37 | |
| openstackgerrit | Merged openstack/horizon: ngReorg - move dashboard-app/login out https://review.openstack.org/185133 | 06:41 |
| TravT_ | .r1chardj0n3s ^ | 06:41 |
| *** amotoki has quit IRC | 06:41 | |
| *** svasheka has joined #openstack-horizon | 06:42 | |
| openstackgerrit | Merged openstack/horizon: fix usage property(vcpus, vcpu_hours) error use https://review.openstack.org/152376 | 06:47 |
| openstackgerrit | Li Yingjun proposed openstack/horizon: Disable disassociate fip button when no fip associated https://review.openstack.org/188683 | 06:54 |
| *** e0ne has joined #openstack-horizon | 06:54 | |
| *** ttrifonov is now known as zz_ttrifonov | 06:55 | |
| *** KunalGandhi has quit IRC | 07:01 | |
| *** e0ne has quit IRC | 07:04 | |
| *** Kunal has quit IRC | 07:05 | |
| *** cody-somerville has quit IRC | 07:09 | |
| *** cody-somerville has joined #openstack-horizon | 07:10 | |
| *** jbell8 has quit IRC | 07:12 | |
| *** markus_z has joined #openstack-horizon | 07:15 | |
| *** oro_ has quit IRC | 07:26 | |
| *** KunalGandhi has joined #openstack-horizon | 07:26 | |
| *** Miouge_ has joined #openstack-horizon | 07:26 | |
| *** Kunal has joined #openstack-horizon | 07:28 | |
| *** Miouge has quit IRC | 07:29 | |
| *** Miouge_ is now known as Miouge | 07:29 | |
| *** Miouge has quit IRC | 07:31 | |
| *** Miouge has joined #openstack-horizon | 07:35 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/188678 | 07:36 |
| *** zz_ttrifonov is now known as ttrifonov | 07:37 | |
| *** dguerri` is now known as dguerri | 07:39 | |
| *** KunalGandhi has quit IRC | 07:44 | |
| *** romainh has joined #openstack-horizon | 07:47 | |
| *** fedexo has quit IRC | 07:47 | |
| *** rwsu has joined #openstack-horizon | 07:48 | |
| *** Kunal has quit IRC | 07:48 | |
| *** bluex-pl has joined #openstack-horizon | 07:48 | |
| *** Ala has joined #openstack-horizon | 07:52 | |
| *** Miouge has quit IRC | 08:05 | |
| *** Miouge has joined #openstack-horizon | 08:08 | |
| *** Miouge has quit IRC | 08:11 | |
| *** svasheka has quit IRC | 08:16 | |
| *** dguerri is now known as dguerri` | 08:22 | |
| *** dguerri` is now known as dguerri | 08:22 | |
| *** dguerri is now known as dguerri` | 08:22 | |
| *** dguerri` is now known as dguerri | 08:22 | |
| *** Miouge has joined #openstack-horizon | 08:22 | |
| *** ygbo has joined #openstack-horizon | 08:29 | |
| *** ZZelle has quit IRC | 08:31 | |
| *** chlong has quit IRC | 08:34 | |
| *** rwsu has quit IRC | 08:36 | |
| *** Ala has quit IRC | 08:38 | |
| *** oro_ has joined #openstack-horizon | 08:41 | |
| *** sumanth has quit IRC | 08:46 | |
| *** Ala has joined #openstack-horizon | 08:46 | |
| *** sumanth has joined #openstack-horizon | 08:47 | |
| *** dsneddon has quit IRC | 08:47 | |
| *** pkarikh has joined #openstack-horizon | 08:48 | |
| openstackgerrit | Merged openstack/django_openstack_auth: Imported Translations from Transifex https://review.openstack.org/188673 | 08:53 |
| *** masco has quit IRC | 08:54 | |
| *** svasheka has joined #openstack-horizon | 08:58 | |
| *** jbell8 has joined #openstack-horizon | 09:01 | |
| *** sumanth has quit IRC | 09:02 | |
| *** sumanth has joined #openstack-horizon | 09:02 | |
| *** jbell8 has quit IRC | 09:05 | |
| *** sumanth has quit IRC | 09:07 | |
| *** e0ne has joined #openstack-horizon | 09:09 | |
| *** sumanth has joined #openstack-horizon | 09:13 | |
| *** lhcheng has quit IRC | 09:17 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: JSCS Cleanup - dashboard-app https://review.openstack.org/188316 | 09:18 |
| *** masco has joined #openstack-horizon | 09:18 | |
| openstackgerrit | tinytmy proposed openstack/horizon: Change 'Update Metadata' to specific name in modal header https://review.openstack.org/188713 | 09:24 |
| *** sumanth has quit IRC | 09:24 | |
| *** sumanth has joined #openstack-horizon | 09:26 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 09:29 | |
| *** sumanth has quit IRC | 09:30 | |
| *** aix has joined #openstack-horizon | 09:34 | |
| *** tosky has joined #openstack-horizon | 09:36 | |
| *** abc__ has joined #openstack-horizon | 09:41 | |
| abc__ | hi I am trying to add a new html file | 09:42 |
| abc__ | these are the following things I have done | 09:42 |
| abc__ | 1) I created a new django app | 09:42 |
| abc__ | 2) Added ROOT_URLCONF = app.url | 09:43 |
| abc__ | whenever I am trying to load /app/ I get the error django tried looking through pattern and could not find /app/ in openstack_dashboard.urls | 09:45 |
| abc__ | I am a beginner to horizon can you pls tell me what am I missing? | 09:45 |
| *** alexpilotti has joined #openstack-horizon | 09:45 | |
| openstackgerrit | Masco Kaliyamoorthy proposed openstack/horizon: Hide attach fip if already fip attached https://review.openstack.org/188718 | 09:47 |
| *** romainh has quit IRC | 09:52 | |
| *** sumanth has joined #openstack-horizon | 09:53 | |
| neelabh | I want to create the alarm with some threshold value (for some matrix) when measurement of that matrix cross the threshold value It will send email, So How to embedded email in openstack.. | 10:01 |
| neelabh | Means I want to trigger email, when some criteria meets in openstack.. | 10:03 |
| *** e0ne is now known as e0ne_ | 10:07 | |
| *** e0ne_ is now known as e0ne | 10:12 | |
| openstackgerrit | Sam Betts proposed openstack/horizon: Use JQuery promise/deferred objects to track AJAX https://review.openstack.org/172067 | 10:14 |
| openstackgerrit | Sam Betts proposed openstack/horizon: Ensure log messages are not translation objects https://review.openstack.org/173974 | 10:28 |
| *** NikitaKonovalov has quit IRC | 10:39 | |
| *** TravT has joined #openstack-horizon | 10:41 | |
| *** TravT_ has quit IRC | 10:44 | |
| *** KunalGandhi has joined #openstack-horizon | 10:45 | |
| *** KunalGandhi has quit IRC | 10:50 | |
| *** NikitaKonovalov has joined #openstack-horizon | 10:50 | |
| *** mrunge has quit IRC | 10:54 | |
| *** wasmum has quit IRC | 10:55 | |
| *** julim has joined #openstack-horizon | 11:01 | |
| *** e0ne is now known as e0ne_ | 11:05 | |
| *** lhcheng has joined #openstack-horizon | 11:05 | |
| *** e0ne_ is now known as e0ne | 11:07 | |
| *** lhcheng has quit IRC | 11:10 | |
| *** romainh has joined #openstack-horizon | 11:12 | |
| *** wasmum has joined #openstack-horizon | 11:20 | |
| *** neelabh has quit IRC | 11:23 | |
| *** radez is now known as radez_g0n3 | 11:23 | |
| *** yamamoto has quit IRC | 11:31 | |
| *** JeanBriceCombebi has quit IRC | 11:31 | |
| *** neelabh has joined #openstack-horizon | 11:35 | |
| *** rwsu has joined #openstack-horizon | 11:43 | |
| *** dguerri is now known as dguerri` | 11:48 | |
| *** cody-somerville has quit IRC | 11:53 | |
| *** ducttape_ has joined #openstack-horizon | 11:54 | |
| *** iamjarvo has joined #openstack-horizon | 11:54 | |
| *** TravT_ has joined #openstack-horizon | 12:00 | |
| *** TravT has quit IRC | 12:02 | |
| *** ducttape_ has quit IRC | 12:06 | |
| *** cody-somerville has joined #openstack-horizon | 12:07 | |
| *** zul has quit IRC | 12:16 | |
| *** zul has joined #openstack-horizon | 12:16 | |
| *** sumanth has quit IRC | 12:17 | |
| *** yamamoto has joined #openstack-horizon | 12:19 | |
| *** yamamoto has quit IRC | 12:20 | |
| *** yamamoto_ has joined #openstack-horizon | 12:20 | |
| *** e0ne is now known as e0ne_ | 12:21 | |
| *** e0ne_ is now known as e0ne | 12:22 | |
| neelabh | Where should I create log files for 'log://, In alarm creation.. | 12:23 |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Logout user if he has no valid tokens https://review.openstack.org/142481 | 12:25 |
| *** svasheka has quit IRC | 12:27 | |
| *** dguerri` is now known as dguerri | 12:35 | |
| *** zhenguo has quit IRC | 12:37 | |
| *** masco has quit IRC | 12:40 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:45 | |
| *** mattfarina has joined #openstack-horizon | 12:48 | |
| *** matt-borland has joined #openstack-horizon | 12:50 | |
| *** radez_g0n3 is now known as radez | 12:52 | |
| *** lblanchard has joined #openstack-horizon | 12:52 | |
| *** lhcheng has joined #openstack-horizon | 12:55 | |
| *** romainh has left #openstack-horizon | 12:58 | |
| *** DaveJ__ has joined #openstack-horizon | 12:59 | |
| *** lhcheng has quit IRC | 13:00 | |
| *** svasheka has joined #openstack-horizon | 13:02 | |
| *** petertr7_away is now known as petertr7 | 13:07 | |
| *** iamjarvo has quit IRC | 13:08 | |
| *** JeanBriceCombebi has quit IRC | 13:12 | |
| *** doug-fish has joined #openstack-horizon | 13:13 | |
| *** Piet has joined #openstack-horizon | 13:15 | |
| *** mattfarina has quit IRC | 13:17 | |
| *** lhcheng has joined #openstack-horizon | 13:18 | |
| *** lhcheng has quit IRC | 13:23 | |
| *** peristeri has joined #openstack-horizon | 13:26 | |
| *** rushiagr is now known as rushiagr_away | 13:28 | |
| *** jtriley has joined #openstack-horizon | 13:30 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 13:30 | |
| *** mattfari_ has joined #openstack-horizon | 13:32 | |
| *** iamjarvo has joined #openstack-horizon | 13:32 | |
| *** iamjarvo has quit IRC | 13:32 | |
| *** e0ne is now known as e0ne_ | 13:39 | |
| *** e0ne_ is now known as e0ne | 13:39 | |
| *** _crobertsrh is now known as crobertsrh | 13:43 | |
| *** mattfari_ has quit IRC | 13:45 | |
| *** svasheka has quit IRC | 13:52 | |
| *** tqtran has joined #openstack-horizon | 14:00 | |
| *** jtriley has quit IRC | 14:02 | |
| *** clu_ has joined #openstack-horizon | 14:04 | |
| *** TravT has joined #openstack-horizon | 14:05 | |
| *** asahlin_away is now known as asahiln | 14:06 | |
| *** asahiln is now known as asahllin | 14:06 | |
| *** yamamoto_ has quit IRC | 14:06 | |
| *** TravT_ has quit IRC | 14:07 | |
| *** iamjarvo has joined #openstack-horizon | 14:09 | |
| *** yamamoto has joined #openstack-horizon | 14:09 | |
| *** iamjarvo has quit IRC | 14:09 | |
| *** iamjarvo has joined #openstack-horizon | 14:10 | |
| *** tqtran has quit IRC | 14:10 | |
| *** sjmc7 has joined #openstack-horizon | 14:16 | |
| *** e0ne is now known as e0ne_ | 14:16 | |
| matt-borland | Is there progress on getting the selenium gate job to function properly? | 14:16 |
| matt-borland | We have failing tests that are not blocking anymore, meaning we could have broken code getting past the gate. | 14:17 |
| matt-borland | david-lyle: ^^ | 14:18 |
| *** ducttape_ has joined #openstack-horizon | 14:18 | |
| *** rushiagr_away is now known as rushiagr | 14:18 | |
| *** yamamoto has quit IRC | 14:19 | |
| *** jtriley has joined #openstack-horizon | 14:20 | |
| *** e0ne_ has quit IRC | 14:26 | |
| *** clu_ has quit IRC | 14:28 | |
| *** packet has joined #openstack-horizon | 14:37 | |
| *** JeanBriceCombebi has quit IRC | 14:37 | |
| *** vijendar has joined #openstack-horizon | 14:38 | |
| doug-fish | matt-borland: there is at least some progress - we have some interns that have identified this https://bugs.launchpad.net/horizon/+bug/1456294 and will be submitting a fix soon | 14:40 |
| openstack | Launchpad bug 1456294 in OpenStack Dashboard (Horizon) "test_user_create_delete fails" [Undecided,In progress] - Assigned to Timmy Vanderwiel (tvander) | 14:40 |
| *** nlahouti has joined #openstack-horizon | 14:42 | |
| *** nlahouti has quit IRC | 14:42 | |
| *** belmoreira has quit IRC | 14:42 | |
| *** mark-os has joined #openstack-horizon | 14:43 | |
| mark-os | Could anyone tell my why the css files aren't generated until the dashboard is accessed? | 14:44 |
| *** stevemar has joined #openstack-horizon | 14:44 | |
| mark-os | Whenever I install Horizon, the static css directories stay empty until I try to access it | 14:44 |
| *** e0ne has joined #openstack-horizon | 14:45 | |
| matt-borland | doug-fish: cool...is there anything I can do to help? | 14:47 |
| matt-borland | I don't know much about the gate | 14:47 |
| ducttape_ | mark-os - you can run collectstatic and compress on demand if you like, but that is common DEBUG=True type behavior | 14:48 |
| doug-fish | matt-borland: at this point the main roadblock is getting internal company approval to do community work. I don't think you can help much there. But I think their approval is imminent. | 14:48 |
| mark-os | ducttape_: how do I run the collectstatic command? | 14:49 |
| matt-borland | doug-fish: this seems like a different problem | 14:49 |
| doug-fish | yeah - I was just going to say I don't think that's a complete solution | 14:50 |
| ducttape_ | https://docs.djangoproject.com/en/1.8/ref/contrib/staticfiles/#management-commands mark-os | 14:50 |
| *** yamamoto has joined #openstack-horizon | 14:50 | |
| matt-borland | I'm talking about the fact that failures don't cause gate-horizon-selenium to fail. That seems different than fixing individual tests... | 14:50 |
| ducttape_ | it's the same command for django 1.6 / 1.7 / whatever | 14:51 |
| doug-fish | matt-borland: I'm not expert on gate debugging, but I'm planning to go back and review this presentation to see what I can pick up on it: https://www.openstack.org/summit/vancouver-2015/summit-videos/presentation/tales-from-the-gate-how-debugging-the-gate-helps-your-enterprise | 14:52 |
| matt-borland | Yep, that was a good presentation | 14:52 |
| doug-fish | well if you know all of that you're set! | 14:53 |
| doug-fish | just fix it then! | 14:53 |
| doug-fish | :-) | 14:53 |
| matt-borland | lol...that is how to debug failures... :) | 14:53 |
| matt-borland | and all we are getting is successes! | 14:53 |
| matt-borland | It's actually a huge problem. We no longer have a gate when any JS tests start failing. | 14:54 |
| doug-fish | matt-borland: I share your concern | 14:54 |
| doug-fish | matt-borland: I'm looking right here: https://review.openstack.org/#/c/188588/ gate-horizon-dsvm-integration has a failure | 14:56 |
| *** jbell8 has joined #openstack-horizon | 14:57 | |
| matt-borland | yeah, that's been true for a while, non-voting. | 14:57 |
| *** juggler has quit IRC | 14:57 | |
| david-lyle | so selenium is working great for us | 14:57 |
| doug-fish | that's the one I'm most concerned about and would like to get fixed + voting again | 14:57 |
| matt-borland | yup | 14:57 |
| *** Drago has joined #openstack-horizon | 14:58 | |
| *** Drago has quit IRC | 14:58 | |
| *** Drago has joined #openstack-horizon | 14:58 | |
| matt-borland | although for JS coding arguably false passes in gate-horizon-selenium are bad | 14:58 |
| doug-fish | sure | 14:59 |
| matt-borland | I feel like I have to police master just to keep the tests clean. | 14:59 |
| david-lyle | I would rather have false falses, than false positives | 14:59 |
| matt-borland | it's not a fun job, when it should be automated. | 14:59 |
| matt-borland | yup. | 14:59 |
| *** esp has joined #openstack-horizon | 15:01 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Tests for Base Controllers https://review.openstack.org/172057 | 15:02 |
| david-lyle | doug-fish: when traveling, do you just fly from Minneapolis? | 15:04 |
| david-lyle | Rochester appears convenient to nowhere :P | 15:05 |
| doug-fish | normally, yes. Rochester does have an airport, but it's usually just as fast to take a shuttle | 15:05 |
| david-lyle | makes sense | 15:06 |
| ygbo | Hi all, I guess this question might have already been asked, but wen updating with master today, unittests now fail with: http://paste.openstack.org/show/266199/ | 15:06 |
| *** Longgeek_ has quit IRC | 15:07 | |
| *** Longgeek has joined #openstack-horizon | 15:07 | |
| *** Miouge has quit IRC | 15:08 | |
| *** jbell8 has quit IRC | 15:09 | |
| *** Desh_Shukla has joined #openstack-horizon | 15:09 | |
| *** akrivoka has quit IRC | 15:10 | |
| *** dsneddon has joined #openstack-horizon | 15:11 | |
| matt-borland | ygbo: yes, that is true :( | 15:11 |
| matt-borland | that's part of what we were just discussing | 15:12 |
| *** lsmola has quit IRC | 15:12 | |
| matt-borland | I am trying to figure out if anyone is actively looking at our gate problem. | 15:13 |
| *** yamamoto has quit IRC | 15:13 | |
| matt-borland | I don't really have an answer. | 15:13 |
| openstackgerrit | Merged openstack/horizon: JSCS Cleanup - Legacy JS test files https://review.openstack.org/187301 | 15:15 |
| *** Kunal has joined #openstack-horizon | 15:15 | |
| *** KunalGandhi has joined #openstack-horizon | 15:15 | |
| david-lyle | ygbo: my guess is you pbr is too old | 15:16 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Trigger tox from package.json, if necessary. https://review.openstack.org/188225 | 15:16 |
| david-lyle | or pip | 15:16 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Added karma-cli to package.json https://review.openstack.org/188198 | 15:16 |
| matt-borland | david-lyle: I don't think so | 15:16 |
| *** neelabh has quit IRC | 15:17 | |
| david-lyle | you think the version string issue is coming from the horizon code itself?? | 15:17 |
| matt-borland | david-lyle: so what is the situation with ever-passing gate-horizon-selenium? | 15:17 |
| david-lyle | matt-borland: haven't had a chance to look at it | 15:17 |
| matt-borland | ok, is there anything I can do to help? | 15:17 |
| david-lyle | fix it :P | 15:18 |
| matt-borland | I would love to | 15:18 |
| david-lyle | Not sure what's going on | 15:18 |
| *** abc__ has quit IRC | 15:18 | |
| openstackgerrit | Aaron Sahlin proposed openstack/horizon: JSCS cleanup - Angular framework widgets (partial2) https://review.openstack.org/187758 | 15:18 |
| matt-borland | Because now I'm assigning myself as the personal gate for JS tests, and I don't like it. | 15:18 |
| ygbo | my pbr version was just pulled from requirements, I'll investigate, but hav to go right now for a meeting | 15:18 |
| *** ygbo has quit IRC | 15:18 | |
| david-lyle | matt-borland: my _guess_ is that maybe it broke when tox was released a while back | 15:19 |
| david-lyle | env variables are no longer implicitly passed | 15:20 |
| *** jbell8 has joined #openstack-horizon | 15:21 | |
| *** Ephur has joined #openstack-horizon | 15:24 | |
| matt-borland | david-lyle: thanks | 15:24 |
| matt-borland | I am looking into this the best I can...is there someone at infra I should work with | 15:25 |
| matt-borland | ? | 15:25 |
| david-lyle | I'm getting core dumping tests when running the horizon tests locally | 15:25 |
| david-lyle | so that's good for a python project, right? | 15:25 |
| matt-borland | :) | 15:25 |
| *** Miouge has joined #openstack-horizon | 15:25 | |
| david-lyle | matt-borland: not really, our tests are our own problem | 15:25 |
| matt-borland | ok | 15:26 |
| matt-borland | I don't know anything about where those job specs are located. | 15:27 |
| david-lyle | matt-borland: ah yes | 15:27 |
| mark-os | ducttape_: do you know where all the static files come from, like what directory are they located in? | 15:27 |
| *** Kunal has quit IRC | 15:28 | |
| *** KunalGandhi has quit IRC | 15:28 | |
| *** KunalGandhi has joined #openstack-horizon | 15:28 | |
| david-lyle | github.com/openstack-infra/project-config | 15:28 |
| ducttape_ | mark-os - read up django docs, it explains it better than I can | 15:29 |
| *** e0ne is now known as e0ne_ | 15:29 | |
| *** e0ne_ is now known as e0ne | 15:30 | |
| *** e0ne is now known as e0ne_ | 15:30 | |
| *** e0ne_ is now known as e0ne | 15:30 | |
| david-lyle | matt-borland: to be more specific | 15:31 |
| david-lyle | https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/horizon.yaml is where the jobs are defined | 15:31 |
| david-lyle | and https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml is where what's run when is setup | 15:32 |
| david-lyle | I can look too | 15:32 |
| david-lyle | I don't want plugin to work any better anyway, right ducttape_? | 15:32 |
| *** oro_ has quit IRC | 15:33 | |
| david-lyle | although the core dump thing is not good | 15:33 |
| david-lyle | anyone else seeing that? | 15:33 |
| david-lyle | I know someone the other day reported random aborts | 15:33 |
| *** hurgleburgler has joined #openstack-horizon | 15:37 | |
| ducttape_ | say huh david-lyle? plugins core dump? what-chu-talkin-bout ? | 15:38 |
| *** gyee_ has joined #openstack-horizon | 15:38 | |
| david-lyle | just saying all the plugin goodness will have to wait a little longer | 15:39 |
| david-lyle | and pointing out that no one needs it anyway ;) | 15:39 |
| ducttape_ | I'm cool with plugins via ducttape, bubblegum, and bailing wire. it fits in with the rest of openstack | 15:40 |
| *** Desh_Shukla has quit IRC | 15:42 | |
| krotscheck | matt-borland, david-lyle: For what it's worth, the karma tests are now running, as of this patch: https://review.openstack.org/#/c/188225/ | 15:44 |
| krotscheck | My personal thought on mrunge's comments is that having them run in the gate is awesome, figuring out how to make it palatable to packagers can be a followup patch. | 15:45 |
| *** david-lyle has quit IRC | 15:46 | |
| *** david-lyle has joined #openstack-horizon | 15:46 | |
| *** ChanServ sets mode: +o david-lyle | 15:46 | |
| krotscheck | matt-borland: I can also help you figure out the crazyness that is the projects-config repository | 15:47 |
| *** markus_z has quit IRC | 15:50 | |
| *** nlahouti has joined #openstack-horizon | 15:54 | |
| *** jtriley has quit IRC | 15:55 | |
| *** jbell8 has quit IRC | 15:57 | |
| *** vishwanathj has joined #openstack-horizon | 15:58 | |
| *** Desh_Shu_ has joined #openstack-horizon | 15:59 | |
| *** Miouge has quit IRC | 16:00 | |
| *** jtriley has joined #openstack-horizon | 16:01 | |
| *** Desh_Shu_ has quit IRC | 16:01 | |
| *** Desh_Shukla has joined #openstack-horizon | 16:01 | |
| *** asahllin is now known as asahlin_away | 16:02 | |
| mark-os | ducttape_: I'm still unsure after reading the docs | 16:03 |
| *** alexvictorchan has joined #openstack-horizon | 16:03 | |
| *** TravT_ has joined #openstack-horizon | 16:03 | |
| mark-os | I've located the file which imports 'django.contrib.staticfiles' | 16:03 |
| *** TravT has quit IRC | 16:04 | |
| *** Desh_Shu_ has joined #openstack-horizon | 16:04 | |
| *** Desh_Shu_ has quit IRC | 16:04 | |
| *** Desh_Shukla has quit IRC | 16:05 | |
| *** TravT_ has quit IRC | 16:07 | |
| ducttape_ | mark-os - what is really your question. you started out saying that static is not populated until you start running stuff, which seems ok to me. what are you looking for? | 16:08 |
| mark-os | ducttape_: I'm trying to understand why the dashboard doesn't have any css files until you access the dashboard | 16:08 |
| ducttape_ | so like on the second request, or before the 1st request is your concern? | 16:09 |
| *** Ala has quit IRC | 16:09 | |
| mark-os | ducttape_: Should the static files not be collected as soon as horizon is installed? | 16:09 |
| *** jingjing_ren has joined #openstack-horizon | 16:09 | |
| ducttape_ | it depends upon what the django config is setup like | 16:09 |
| david-lyle | mark-os: you can collect them online or offline | 16:10 |
| david-lyle | you have it configured to collect online | 16:10 |
| ducttape_ | in dev mode, it should be empty and will populate on demand. in a production config, you should run collectstatic before hand with a different config | 16:10 |
| mark-os | Do these static files come from a local location or are they retrieved remotely? | 16:10 |
| *** TravT has joined #openstack-horizon | 16:10 | |
| david-lyle | otherwise collectstatic and compress are commands you'll have to run manually or via script | 16:11 |
| *** TravT has quit IRC | 16:11 | |
| ducttape_ | this is all covered in https://docs.djangoproject.com/en/1.8/howto/static-files/ | 16:11 |
| david-lyle | mark-os: horizon is configured to pull from the horizon and openstack_dashboard directories | 16:11 |
| ducttape_ | they can come from wherever you want / configure it | 16:11 |
| david-lyle | if you want to configure it to pull from somewhere else that's your prerogative | 16:12 |
| * ducttape_ hopes david-lyle would use smaller words so he could follow along | 16:12 | |
| mark-os | david-lyle: how do I configure it for offline? I tried searching for the css files it has after I go on the dashboard but they weren't found which I thought was odd | 16:12 |
| *** dguerri is now known as dguerri` | 16:13 | |
| *** ttrifonov is now known as zz_ttrifonov | 16:13 | |
| *** yamamoto has joined #openstack-horizon | 16:13 | |
| ducttape_ | mark-os - from https://docs.djangoproject.com/en/1.8/howto/static-files/ turn DEBUG=True to be False | 16:14 |
| ducttape_ | it's likely in your local_settings.py | 16:14 |
| david-lyle | https://github.com/openstack/horizon/blob/master/doc/source/topics/install.rst#installation see #4 | 16:15 |
| *** TravT has joined #openstack-horizon | 16:15 | |
| *** TravT has quit IRC | 16:15 | |
| ducttape_ | david-lyle - you gotta turn off debug too, otherwise collectstatic acts weird / djanky | 16:16 |
| *** TravT has joined #openstack-horizon | 16:16 | |
| mark-os | ducttape_: I think I'll need DEBUG to still = True, for testing purposes :P | 16:16 |
| ducttape_ | well, you gotta choose one or the other. | 16:16 |
| david-lyle | mark-os: if you're debugging why do you care if the collect and compress is online? | 16:16 |
| mark-os | david-lyle: because the way I've set it up atm I'm automating the AVOS install after I install Horizon | 16:17 |
| mark-os | the problem being that because the css and js directories are not generated until after you access the dashboard, I run into issues as I create these in the avos install script so I can add the relevant avos js and css files | 16:18 |
| *** yamamoto has quit IRC | 16:18 | |
| david-lyle | why not use the theming support? | 16:19 |
| ducttape_ | mark-os - you have the what you need to know I think. turn debug on or off, those are your options. | 16:19 |
| *** pkarikh has quit IRC | 16:19 | |
| mark-os | and for whatever reason, when I try and access the dashboard after I've done this automation, the css and js files for the normal horizon dashboard are missing. Which is why I'm asking a) where are they retrieved from and b) why are they only retrieved when you try and access the dashboard | 16:19 |
| david-lyle | the only difference for debugging is looking at the log rather than an error page in the browser | 16:20 |
| david-lyle | I don't think that's a big loss | 16:20 |
| mark-os | david-lyle: I'm guessing I'll just have to store the static files locally | 16:21 |
| david-lyle | so turn debug off, script the collect and compress commands, profit | 16:21 |
| davidmichaelkarr | I could use some help debugging a problem with my attempting to integrate RequireJS into the unit tests. Anyone interested? | 16:21 |
| mark-os | david-lyle: if someone is working on this after me, they'll probably want to use the DEBUG and then that'll cause problems again if it's turned on | 16:21 |
| david-lyle | mark-os: I can't walk you through the django part, but you can pull in static files from other locations | 16:21 |
| david-lyle | mark-os: that's why you document the choices you made | 16:22 |
| * ducttape_ doesn't see how docs are ever used. #irony | 16:22 | |
| david-lyle | or you kludge together a system that works for you, but isn't supported by horizon | 16:22 |
| david-lyle | or go ask in #django | 16:23 |
| david-lyle | what you're wanting is outside the scope of what we're doing | 16:23 |
| *** Miouge has joined #openstack-horizon | 16:23 | |
| *** e0ne is now known as e0ne_ | 16:23 | |
| *** e0ne_ has quit IRC | 16:24 | |
| *** jingjing_ren has quit IRC | 16:24 | |
| *** jingjing_ren has joined #openstack-horizon | 16:25 | |
| mark-os | david-lyle: yeah I got a hackish solution | 16:26 |
| david-lyle | mark-os: if it works for your purposes, no one needs to know it's a hack | 16:27 |
| david-lyle | in that case, it's software | 16:27 |
| david-lyle | done | 16:27 |
| david-lyle | :D | 16:27 |
| *** jbell8 has joined #openstack-horizon | 16:27 | |
| *** sqchen has joined #openstack-horizon | 16:30 | |
| *** ongk has joined #openstack-horizon | 16:30 | |
| TravT | krotscheck: I see your patch as a huge improvement over the current situation, so I +2'd it. I know zuul has completed full testing, but I can see that the npm run test just passed. and looking at the logs shows that the tests all ran. | 16:34 |
| TravT | s/has/hasn't | 16:34 |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Create a Bootstrap Theme Preview Page with HTML Hints https://review.openstack.org/187818 | 16:35 |
| krotscheck | TravT: Thanks. I'm currently doing some more forensics into the various file structures presented by both debian and centos packagers for ther js libraries. I have the sneaking suspicion that neither of them is consistent. | 16:35 |
| TravT | IMO, we should show that it also will fail if there is a failed test. | 16:35 |
| krotscheck | TravT: Revision 2 failed because a test failed :) | 16:36 |
| krotscheck | There was rebasing :) | 16:36 |
| TravT | ah cool | 16:37 |
| *** jingjing_ren has quit IRC | 16:37 | |
| *** jingjing_ren has joined #openstack-horizon | 16:38 | |
| TravT | So, I'm now also wondering why not make this a voting job... or give it a week to be sure? | 16:38 |
| TravT | i mean making it voting once it merges. | 16:38 |
| krotscheck | TravT: That's super easy to do. Once y'all cores decide to flip that switch, just lmk. | 16:39 |
| *** jbell8 has quit IRC | 16:39 | |
| TravT | david-lyle matt-borland ^ https://review.openstack.org/#/c/188225/ | 16:39 |
| TravT | passed check | 16:39 |
| TravT | gate-horizon-npm-run-test | 16:39 |
| *** e0ne has joined #openstack-horizon | 16:40 | |
| *** jbell8 has joined #openstack-horizon | 16:40 | |
| *** ZZelle has joined #openstack-horizon | 16:42 | |
| *** Miouge has quit IRC | 16:42 | |
| *** e0ne has quit IRC | 16:43 | |
| TravT | krotschek: thanks for this. Do you have a suggested best way to run jscs? right now we run it via run_tests.sh -s | 16:43 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: [Launch Instance Fix] Show Admin Password https://review.openstack.org/171450 | 16:43 |
| *** jingjing_ren has quit IRC | 16:43 | |
| *** Miouge has joined #openstack-horizon | 16:44 | |
| *** bpokorny has joined #openstack-horizon | 16:44 | |
| TravT | krotscheck: ^ (I always mistype) But I mean via zuul a way similar to what you just set up for us. right now of course we call jscs directly on individual files. | 16:44 |
| krotscheck | TravT: I can come up with one. Why jscs rather than eslint rather than jshint rather than jslint? (I know the last two are license stupid). | 16:45 |
| *** Desh_Shukla has joined #openstack-horizon | 16:45 | |
| *** Miouge has quit IRC | 16:45 | |
| *** Miouge has joined #openstack-horizon | 16:46 | |
| TravT | matt-borland initially set that up... | 16:46 |
| krotscheck | I'm not opinionated. | 16:46 |
| krotscheck | Just cirous. | 16:46 |
| TravT | maybe because we are adopting the john papa style guide and there are some references to jscs in his stuff. | 16:47 |
| krotscheck | What's the commandline invocation for jscs? I'm getting a "no input files specified" | 16:47 |
| TravT | jscs path to file | 16:47 |
| krotscheck | Hrm. No globbing? | 16:47 |
| TravT | globbing also works | 16:47 |
| *** Drago has quit IRC | 16:47 | |
| TravT | or should | 16:48 |
| krotscheck | TravT: I'd do something like this -> https://review.openstack.org/#/c/185711/5/refstack-ui/package.json | 16:48 |
| krotscheck | Except jscs | 16:48 |
| krotscheck | And then adopt the npm-jobs template I'm working on for refstack | 16:49 |
| TravT | ok, we'll have to look at that... | 16:49 |
| TravT | i actually have to run to something at the moment. | 16:49 |
| krotscheck | kk' | 16:49 |
| TravT | btw here's an example jscs that worked for me: jscs horizon/static/horizon/js/angular/services/hz.api* | 16:49 |
| krotscheck | matt-borland: Hey, where are the jscs rule files? | 16:49 |
| matt-borland | <root>.jscsrc | 16:50 |
| matt-borland | krotscheck: ^^ | 16:50 |
| krotscheck | matt-borland: Cool. Let me play a bit, will get back to you with a patch. | 16:51 |
| matt-borland | awesome | 16:51 |
| *** oro_ has joined #openstack-horizon | 16:52 | |
| *** alanf-mc has joined #openstack-horizon | 16:52 | |
| *** bluex-pl has quit IRC | 16:55 | |
| TravT | krotscheck: :) | 16:55 |
| TravT | robcresswell, tqtran clu doug-fish can any of you look at https://review.openstack.org/#/c/188225/ | 16:57 |
| TravT | would be nice to get it through so we at least have some angular testing happening | 16:57 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Added `npm run lint` command to execute JSCS https://review.openstack.org/188853 | 16:58 |
| krotscheck | matt-borland, TravT ^^ | 16:58 |
| krotscheck | Try that, with an `npm install` followed with an `npm run lint` | 16:58 |
| krotscheck | You should get... urrr... 82 errors? | 16:58 |
| * matt-borland checking it out | 16:59 | |
| *** ybathia has joined #openstack-horizon | 16:59 | |
| krotscheck | You can tweak it if you want to, the globbing may not suit your purposes. | 16:59 |
| TravT | ok, will check in a bit... | 16:59 |
| krotscheck | But with that in place, we can then add gate-horizon-npm-run-lint | 16:59 |
| TravT | i'm late for something. | 16:59 |
| *** alanf-mc_ has joined #openstack-horizon | 17:00 | |
| *** alanf-mc has quit IRC | 17:02 | |
| matt-borland | krotscheck: 82 errors :) | 17:02 |
| krotscheck | matt-borland: There ya go! | 17:02 |
| krotscheck | Ya might want to fix those before we make that job voting :D | 17:03 |
| matt-borland | it's better than it was the other day! I think 2032 or so. | 17:03 |
| *** tjones1 has joined #openstack-horizon | 17:03 | |
| matt-borland | krotscheck: hunh, we actually do have 2035 current errors (./run_tests.sh --jscs) | 17:06 |
| krotscheck | Hrm. | 17:06 |
| matt-borland | darned off-by-three errors | 17:06 |
| krotscheck | Globbing? | 17:06 |
| matt-borland | I think just dir specification, see run_tests.sh | 17:07 |
| krotscheck | matt-borland: I see that. just a minute, I'll fix the patch | 17:07 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Added `npm run lint` command to execute JSCS https://review.openstack.org/188853 | 17:08 |
| krotscheck | There's your 2035 | 17:08 |
| krotscheck | Gooood luck with that. | 17:08 |
| *** Drago has joined #openstack-horizon | 17:08 | |
| *** Drago has quit IRC | 17:10 | |
| *** Drago has joined #openstack-horizon | 17:10 | |
| matt-borland | krotscheck: 2035. | 17:11 |
| *** alanf-mc_ has quit IRC | 17:11 | |
| matt-borland | indeed :( | 17:11 |
| matt-borland | thanks for putting that together! | 17:11 |
| *** alanf-mc has joined #openstack-horizon | 17:11 | |
| *** dguerri` is now known as dguerri | 17:16 | |
| ongk | krotscheck, matt-borland: I think there are some JS files ./run_tests is missing too… so that number might grow :/ | 17:17 |
| *** lhcheng has joined #openstack-horizon | 17:18 | |
| *** Desh_Shu_ has joined #openstack-horizon | 17:19 | |
| *** tyr_ has joined #openstack-horizon | 17:22 | |
| *** Desh_Shukla has quit IRC | 17:22 | |
| *** ybathia has quit IRC | 17:23 | |
| *** lhcheng has quit IRC | 17:28 | |
| *** ongk has quit IRC | 17:29 | |
| *** dscottsf has joined #openstack-horizon | 17:30 | |
| *** dscottsf has quit IRC | 17:31 | |
| *** mark-os has quit IRC | 17:31 | |
| openstackgerrit | Brian Tully proposed openstack/horizon: Updated UX for project and region selector https://review.openstack.org/186193 | 17:31 |
| *** lhcheng has joined #openstack-horizon | 17:32 | |
| *** jbell8 has quit IRC | 17:34 | |
| *** Desh_Shu_ has quit IRC | 17:35 | |
| *** ongk has joined #openstack-horizon | 17:36 | |
| *** oro_ has quit IRC | 17:38 | |
| *** rushiagr is now known as rushiagr_away | 17:40 | |
| *** Desh_Shukla has joined #openstack-horizon | 17:40 | |
| *** jtriley has quit IRC | 17:41 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Filter projects based on selected domain in create user modal https://review.openstack.org/188645 | 17:41 |
| *** jbell8 has joined #openstack-horizon | 17:43 | |
| *** tqtran has joined #openstack-horizon | 17:44 | |
| *** hurgleburgler has quit IRC | 17:46 | |
| *** hurgleburgler1 has joined #openstack-horizon | 17:46 | |
| *** e0ne has joined #openstack-horizon | 17:48 | |
| *** jtriley has joined #openstack-horizon | 17:53 | |
| *** dscottsf has joined #openstack-horizon | 18:03 | |
| *** rwsu has quit IRC | 18:04 | |
| *** TravT_ has joined #openstack-horizon | 18:06 | |
| sqchen | Hi tqtran: | 18:08 |
| tqtran | hi sean | 18:08 |
| *** jwy has joined #openstack-horizon | 18:09 | |
| *** TravT has quit IRC | 18:09 | |
| sqchen | Talked to Matt Borland this morning, he has some ideas on the common mck, and he wanted to talk to you directly. | 18:09 |
| tqtran | ok, is matt-borland here? | 18:10 |
| matt-borland | hey tqtran: sqchen: | 18:10 |
| tqtran | im all ears, lets hear it | 18:11 |
| matt-borland | So Thai, did you read my copious notes on the Model Patch? | 18:11 |
| *** tyr_ has quit IRC | 18:11 | |
| matt-borland | I think there is utility in sharing some of the 'standard' models, which I think you were suggesting. | 18:11 |
| matt-borland | I frankly don't want to tackle that in this patch. | 18:11 |
| *** tyr_ has joined #openstack-horizon | 18:12 | |
| matt-borland | Part of it relies on what we think will be useful elsewhere. | 18:12 |
| matt-borland | Tyr had put together some ideas about having some shared test features, maybe we could use that as a basis for introducing any common data. | 18:13 |
| tqtran | well, i actually mocked some of the api as well in the identity users patch | 18:13 |
| matt-borland | cool | 18:13 |
| tqtran | so i think it would be useful to have a mocked api so that we can build on | 18:13 |
| matt-borland | so that could be a good starting common data set | 18:14 |
| tqtran | i believe the common data set should already exist to some extent, let me see if i can find it | 18:15 |
| matt-borland | we can probably build some helper features to allow the api mocking to be more of a configuration, | 18:17 |
| *** Piet has quit IRC | 18:18 | |
| matt-borland | for example, having dicts with names as the methods, and data to be returned as a resolved promise | 18:18 |
| tqtran | so im still not clear on what your stance is matt-borland | 18:18 |
| matt-borland | rather than having to code each and every call indepdenently. | 18:18 |
| tqtran | are you saying that we don't really need a mocked api? | 18:18 |
| matt-borland | I'm thinking that we simply extend what Kelly did in the model tests and allow that to be shared by other tests, and clean it up so it's more declarative | 18:19 |
| matt-borland | BUT I don't think we should hold up the model patch on that modification. | 18:19 |
| matt-borland | the tests are valid now. | 18:19 |
| tqtran | can you provide a link to what kelly did? | 18:20 |
| matt-borland | it's all that mocking that's going on at the top of the model patch: | 18:20 |
| matt-borland | https://review.openstack.org/#/c/167738/ | 18:20 |
| *** sqchen has quit IRC | 18:20 | |
| matt-borland | I don't think we should be doing anything more than that. | 18:21 |
| *** sqchen has joined #openstack-horizon | 18:21 | |
| matt-borland | I would also point out that it's not the be-all end-all solution. But if people clamor for having this centralized I have no problem with that. | 18:21 |
| tqtran | so here is my concern. about half of that test code is mocking the api | 18:22 |
| matt-borland | ok | 18:22 |
| tqtran | i would prefer to see that mock get shove into a module so its reusable | 18:22 |
| matt-borland | I think we're saying the same thing...? | 18:22 |
| tqtran | ok :) | 18:22 |
| matt-borland | I just don't think it's required BEFORE we approve the patch. | 18:22 |
| tqtran | thats all im saying, we dont have to go crazy with the mock just yet | 18:22 |
| tqtran | just need a mock module as a starting point | 18:23 |
| *** sumanth has joined #openstack-horizon | 18:23 | |
| matt-borland | yep. | 18:23 |
| tqtran | ok so thats where we differ | 18:23 |
| tqtran | i think it should be done before the patch gets merge | 18:23 |
| matt-borland | ok, fair enough...did you want this done as part of this patch, or did you want to create a patch that this is dependent on? I might possibly scream if I put another test patch dependent on another again... :) | 18:24 |
| tqtran | however you want :) | 18:24 |
| matt-borland | I don't feel it's required to wait to approve valid tests :) | 18:24 |
| tqtran | i dont want you to scream | 18:24 |
| matt-borland | TOO LATE!!!! :) | 18:25 |
| tqtran | lol sorry >< | 18:25 |
| tqtran | how does TravT_ feel about this? | 18:25 |
| matt-borland | I don't know, I haven't talked with him about this and I know he had other concerns. | 18:25 |
| matt-borland | I was trying to address them in the patch comments but haven't talked it over in person or IRC | 18:25 |
| tqtran | ok so he probably has his own sets of concerns | 18:26 |
| matt-borland | yeah | 18:26 |
| tqtran | from my standpoint, thats all i would like to see for a +2 | 18:26 |
| tqtran | he wants to use httpbackend i think | 18:27 |
| tqtran | and have each api with its own mock | 18:27 |
| tqtran | like hz.api.keystone.mock.js | 18:27 |
| tqtran | which uses httpbackend | 18:27 |
| tqtran | i agree that would be ideal | 18:27 |
| matt-borland | hunh, see, I don't like that | 18:27 |
| matt-borland | diverts way too far from the notion of a unit test. | 18:28 |
| tqtran | but for now, im fine with just moving the mocks into its own module | 18:28 |
| matt-borland | and all those other things I said in the patch comments, which may not be intelligible. | 18:28 |
| tqtran | we can discuss that some more, but i dont want it to block test patches | 18:28 |
| tqtran | that can be a separate thread | 18:28 |
| matt-borland | yeah, it's a good discussion, for sure. | 18:28 |
| matt-borland | what I'm finding is that Angular's DI doesn't make it as easy to separate out the configuration of injection from the code itself. | 18:29 |
| *** dscottsf has quit IRC | 18:29 | |
| matt-borland | I did years of Spring/Java stuff and that was a good model...Angular's DI strikes me as a little wonky, but mostly because it's JS. | 18:29 |
| tqtran | im not really following :P | 18:30 |
| matt-borland | Like I said, I'm not entirely intelligible today. | 18:30 |
| tqtran | "separate out the config of injection" no idea what that means | 18:30 |
| matt-borland | we explicitly state the thing to be injected by name, in the code itself. | 18:30 |
| matt-borland | "horizon.my.crazy.service" | 18:31 |
| tqtran | i see | 18:31 |
| matt-borland | rather than "some.abstract.service" | 18:31 |
| davidmichaelkarr | But the angular "core" decides what that object actually is. It facilitates mocking for tests. | 18:31 |
| matt-borland | right, I mean, it works, but it's arguably knitting the code closer to its anticipated injectable. | 18:32 |
| davidmichaelkarr | Whatta ya want for Javascript ? :) | 18:32 |
| *** sjmc7 has quit IRC | 18:32 | |
| matt-borland | davidmichaelkarr: exactly :) | 18:32 |
| davidmichaelkarr | It's light years better than what we had before. This is why there are angularjs presentations at java conferences. | 18:33 |
| matt-borland | It's kinda the nature of the beast | 18:33 |
| *** botang has quit IRC | 18:33 | |
| matt-borland | yup | 18:33 |
| matt-borland | that all being said, for *unit* tests you want some kind of static data for inputs and certainly static data for your expectations, which seems like it was thrown into question a bit in that patch comment | 18:34 |
| matt-borland | but most likely I'm conflating several different arguments at the same time | 18:34 |
| *** botang_ has joined #openstack-horizon | 18:34 | |
| matt-borland | so to wrap up tqtran: sounds like we need some more discussion, at least with TravT_, to see if we're in a good place. | 18:35 |
| matt-borland | I feel like we somehow lost focus on what a unit test is, in the model unit test comments. | 18:35 |
| *** rohitk has joined #openstack-horizon | 18:36 | |
| tqtran | yeah, lets touch base again when TravT_ is available | 18:38 |
| *** tjones1 has quit IRC | 18:43 | |
| *** iamjarvo has quit IRC | 18:44 | |
| *** clu has joined #openstack-horizon | 18:46 | |
| *** jingjing_ren has joined #openstack-horizon | 18:46 | |
| *** lhcheng has quit IRC | 18:46 | |
| *** mattfarina has joined #openstack-horizon | 18:47 | |
| *** gyee_ has quit IRC | 18:47 | |
| *** TravT_ has quit IRC | 18:48 | |
| *** TravT has joined #openstack-horizon | 18:48 | |
| *** iamjarvo has joined #openstack-horizon | 18:50 | |
| krotscheck | You people are strange. | 18:50 |
| *** DaveJ__ has quit IRC | 18:51 | |
| *** htruta has quit IRC | 18:52 | |
| *** ybathia has joined #openstack-horizon | 18:52 | |
| *** sumanth has quit IRC | 18:54 | |
| *** davidmichaelkarr has quit IRC | 18:54 | |
| *** ameade has quit IRC | 18:54 | |
| *** sumanth has joined #openstack-horizon | 18:54 | |
| *** lhcheng has joined #openstack-horizon | 18:54 | |
| *** sjmc7 has joined #openstack-horizon | 18:54 | |
| *** botang_ has quit IRC | 18:55 | |
| matt-borland | krotscheck: ++ | 18:56 |
| *** dscottsf has joined #openstack-horizon | 19:02 | |
| *** iamjarvo has quit IRC | 19:06 | |
| *** dscottsf has quit IRC | 19:07 | |
| *** peristeri has quit IRC | 19:09 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Filter projects based on selected domain in create user modal https://review.openstack.org/188645 | 19:09 |
| *** Sukhdev has joined #openstack-horizon | 19:11 | |
| *** clu has quit IRC | 19:12 | |
| *** radez is now known as radez_g0n3 | 19:15 | |
| *** Longgeek has quit IRC | 19:16 | |
| *** iamjarvo has joined #openstack-horizon | 19:19 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Flavor tests - use a digest cycle to test watches https://review.openstack.org/188587 | 19:19 |
| krotscheck | matt-borland: So, random question: Why jscs rather than something else? | 19:21 |
| *** crobertsrh has left #openstack-horizon | 19:21 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: [Launch Instance Fix] Add Flavor Step Unit Tests https://review.openstack.org/167326 | 19:23 |
| *** tyr_ has quit IRC | 19:23 | |
| *** tyr_ has joined #openstack-horizon | 19:23 | |
| matt-borland | krotscheck: no real comparative evaluation was made. People wanted to use jshint to do style checking, and jshint's site said "that was split off to jscs." | 19:24 |
| *** jingjing_ren has quit IRC | 19:24 | |
| matt-borland | I think that was the full extent of analysis in deciding on that tool | 19:24 |
| *** clu has joined #openstack-horizon | 19:25 | |
| *** clu has quit IRC | 19:26 | |
| krotscheck | matt-borland: Hooookay. Starting a thread. I want to make sure we have one linting config between projects, which requires settling on one tool. | 19:27 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Flavor tests - use a digest cycle to test watches https://review.openstack.org/188587 | 19:28 |
| matt-borland | krotscheck: yup | 19:29 |
| *** crobertsrh has joined #openstack-horizon | 19:30 | |
| *** iamjarvo has quit IRC | 19:31 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Flavor tests - use a digest cycle to test watches https://review.openstack.org/188587 | 19:31 |
| *** TravT_ has joined #openstack-horizon | 19:33 | |
| *** hurgleburgler has joined #openstack-horizon | 19:34 | |
| *** hurgleburgler1 has quit IRC | 19:34 | |
| *** TravT has quit IRC | 19:35 | |
| *** rohitk has quit IRC | 19:35 | |
| *** Desh_Shukla has quit IRC | 19:35 | |
| TravT_ | tqtran: matt-borland are you there? | 19:36 |
| *** iamjarvo has joined #openstack-horizon | 19:37 | |
| *** iamjarvo has quit IRC | 19:37 | |
| matt-borland | I'm here!' | 19:38 |
| matt-borland | TravT_: ^^ | 19:38 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Flavor tests - use a digest cycle to test watches https://review.openstack.org/188587 | 19:38 |
| *** iamjarvo has joined #openstack-horizon | 19:38 | |
| TravT_ | i'm so tired of comcast dropping me... | 19:38 |
| matt-borland | no good! | 19:38 |
| TravT_ | tqtran is probably at lunch | 19:38 |
| *** e0ne has quit IRC | 19:39 | |
| matt-borland | I apologize if my writeups have been less than intelligible | 19:39 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Flavor tests - use a digest cycle to test watches https://review.openstack.org/188587 | 19:39 |
| matt-borland | My day has been split 100 ways | 19:39 |
| TravT_ | i bet. | 19:39 |
| TravT_ | i often feel that way | 19:39 |
| matt-borland | I think that is *every* day for you | 19:40 |
| matt-borland | I'm just feeling it more today for some reason | 19:40 |
| *** nlahouti has quit IRC | 19:40 | |
| matt-borland | Did you read through my comments on that Model Tests patch? | 19:41 |
| TravT_ | sooo... you referenced spring and DI. and I wanted to talk to that a bit. | 19:41 |
| TravT_ | In Java, you have interfaces. You can inject different implementations of that interface. | 19:41 |
| matt-borland | yup | 19:41 |
| TravT_ | my point of saying to use spyOn(foo, 'noexist').andCallFake | 19:41 |
| TravT_ | is that the API is essentially the interface | 19:42 |
| TravT_ | and this code needs to conform to that interface not vice versa | 19:42 |
| TravT_ | the APIs don't implement an interface | 19:42 |
| TravT_ | this code is essentially saying "Here is the interface we have defined using value objects and who gives a f*** about what the real interface is" | 19:43 |
| TravT_ | that to me is what the value objects are doing | 19:43 |
| matt-borland | OK, I don't quite it see it that way | 19:44 |
| TravT_ | when you use spyOn(apiObject, "someMethodOnApi").andCallFake at least you are saying this test is injecting an implementation of the interface | 19:44 |
| TravT_ | it is fake | 19:44 |
| matt-borland | first off, an interface doesn't define the structure of the data in Java, just describes calls. | 19:44 |
| *** botang has joined #openstack-horizon | 19:44 | |
| TravT_ | and that is better than this code redefining its own interface completely unrelated to reality. | 19:45 |
| TravT_ | disconnect the data part of this dicsussion from what i just said | 19:45 |
| TravT_ | simply look at the method naming | 19:45 |
| matt-borland | ok. | 19:45 |
| matt-borland | I'm sorry, I'm trying to understand your concern. | 19:45 |
| TravT_ | take the functions in those value objects and stick them in the andCallFake(function) and you'd have the same thing | 19:45 |
| TravT_ | but at least if somebody goes and changes / deletes our interfaces (the API methods) there would be feedback that something is depending on that interface | 19:46 |
| *** sumanth has quit IRC | 19:46 | |
| TravT_ | because when you run the tests it will report that. | 19:47 |
| *** tyr_ has quit IRC | 19:47 | |
| TravT_ | now if we had true interfaces and both the tests and the API implemented them, then fine | 19:47 |
| *** tyr_ has joined #openstack-horizon | 19:47 | |
| matt-borland | ok, can I restate for my benefit? | 19:48 |
| TravT_ | but as of now, those value objects have no such contract. | 19:48 |
| matt-borland | because we have loosely structured objects, the contracts between the layers of the app are more fragile. | 19:48 |
| matt-borland | so the notion of having completely segmented unit testing is less valid. | 19:49 |
| TravT_ | basically. i see the spyOn as being a way to have the kind of contract you get in interfaces and the DI you mentioned. | 19:49 |
| *** sumanth has joined #openstack-horizon | 19:50 | |
| matt-borland | I'm reading back through your other comments to put together the whole picture... | 19:51 |
| TravT_ | you can ignore the $httpBackend stuff above for this. the spyOn is a followup separate concept | 19:51 |
| *** fedexo has joined #openstack-horizon | 19:52 | |
| matt-borland | OK, cool, I think what happened here, as described in the above conversation with tqtran, is that there were many different points that came about | 19:52 |
| matt-borland | and I'm trying to sort through each of them | 19:53 |
| *** botang has quit IRC | 19:53 | |
| tqtran | whoa | 19:53 |
| tqtran | it has started | 19:53 |
| matt-borland | it's a good conversation | 19:53 |
| *** botang has joined #openstack-horizon | 19:55 | |
| matt-borland | TravT: I am grappling with your comment: "redefining its own interface completely unrelated to reality." | 19:55 |
| *** amotoki has joined #openstack-horizon | 19:55 | |
| openstackgerrit | Kahou Lei proposed openstack/horizon: Admin network form should enable port_security_enabled flag https://review.openstack.org/188625 | 19:55 |
| matt-borland | unit tests inherently are selected conjectures and tests of something in a vacuum | 19:56 |
| TravT_ | ok see this: https://review.openstack.org/#/c/167738/30/openstack_dashboard/static/dashboard/launch-instance/launch-instance.model.spec.js | 19:56 |
| TravT_ | Line 33 | 19:56 |
| matt-borland | ok | 19:56 |
| TravT_ | now if out in the real API classes, somebody changes it to getFoo | 19:57 |
| TravT_ | these tests will still happily work | 19:57 |
| matt-borland | won't the API tests fail? | 19:57 |
| TravT_ | go ahead and fix the API tests | 19:57 |
| TravT_ | but this will still work | 19:57 |
| TravT_ | as will every single other place in the code that has redefined complete objects from scratch | 19:58 |
| TravT_ | if you us spyOn as I showed in the comments | 19:58 |
| matt-borland | ok | 19:58 |
| TravT_ | you will get errors | 19:58 |
| matt-borland | gotcha | 19:58 |
| TravT_ | and the person committing the patch will know. | 19:58 |
| matt-borland | OK | 19:59 |
| matt-borland | now i see it | 19:59 |
| TravT_ | so for example, a few days ago clu got rid of the config service | 19:59 |
| tqtran | ok i got caught up | 19:59 |
| TravT_ | and i asked "is it used anywhere?" | 19:59 |
| matt-borland | sorry, I thought that was somehow linked with the httpbackend issue--it's not | 19:59 |
| *** botang has quit IRC | 19:59 | |
| matt-borland | like you said | 19:59 |
| TravT_ | in theory webstorm / grep etc would find it. | 19:59 |
| TravT_ | but i'd rather that the tests catch it | 19:59 |
| *** jingjing_ren has joined #openstack-horizon | 20:00 | |
| matt-borland | OK | 20:00 |
| matt-borland | cool | 20:00 |
| matt-borland | so, I'm wondering how best to make this as declarative as possible, so we don't have to litter the code with all this imperative data creation...we could wrap the spyOn as part of that | 20:01 |
| TravT_ | i don't want to confuse things, but $httpBackend could be used a corollary to the point i'm trying to make on the usage of spy on and having mocks for the APIs. | 20:01 |
| TravT_ | the ngMock of httpBackend was intended as a way to inject into users of the http service | 20:01 |
| TravT_ | so they could actually do unit testing | 20:01 |
| TravT_ | s/users/code | 20:02 |
| TravT_ | i'm not advocating for it here | 20:02 |
| TravT_ | anymore | 20:02 |
| *** nullvariable has quit IRC | 20:02 | |
| TravT_ | but the corollary is that if you had hz.api.foo.mock... maybe it could give us some easier way to than for every bit of code to have to do all the spyOn itself and do all that deferred logic itself | 20:03 |
| matt-borland | right | 20:03 |
| TravT_ | with $httpBackend in ngMocks, you still tell it EXACTLY the data you expect | 20:03 |
| TravT_ | so that part I'm in 100% agreement with you. | 20:04 |
| TravT_ | that tests / data expected is important | 20:04 |
| TravT_ | but, that doesn't have to be completely solved in this patch. | 20:04 |
| TravT_ | I guess I'd be happier if we could at least do the spyOn within this patch | 20:05 |
| tqtran | i think at some point, if you do it the way travis explained, we might be able to easily switch out the mocks with the real stuff to do e2e? | 20:05 |
| *** jbell8 has quit IRC | 20:06 | |
| *** petertr7 is now known as petertr7_away | 20:06 | |
| TravT_ | tqtran yeah! | 20:06 |
| TravT_ | so like spring context (which you mentioned matt) | 20:07 |
| matt-borland | ... | 20:07 |
| TravT_ | all you'd maybe have to do is load in the js | 20:07 |
| tqtran | BAM! done, ok ship it | 20:07 |
| matt-borland | ... | 20:07 |
| tqtran | :D | 20:07 |
| TravT_ | so for unit, you load in the mocks | 20:07 |
| TravT_ | for e2e you load in the real api | 20:08 |
| tqtran | yep | 20:08 |
| TravT_ | although... | 20:08 |
| matt-borland | so for unit, you will have a wide variety of data that each test may swap in and out | 20:08 |
| TravT_ | these tests are pretty dependent on data | 20:08 |
| matt-borland | there is not a single set of data that will be useful | 20:08 |
| TravT_ | but anyway | 20:08 |
| TravT_ | we don't have to get too crazy... | 20:08 |
| *** jbell8 has joined #openstack-horizon | 20:08 | |
| TravT_ | i think you got the base point on what i mean about these value objects "being disconnected from reality"? | 20:09 |
| matt-borland | yes... | 20:09 |
| matt-borland | although... | 20:09 |
| TravT_ | i think you would rather than $provide.value() | 20:09 |
| TravT_ | you'd inject the service by name | 20:10 |
| matt-borland | I agree on that | 20:10 |
| TravT_ | and do spyOn.callFake | 20:10 |
| TravT_ | with the functions defined already | 20:10 |
| TravT_ | in this patch | 20:10 |
| *** doug-fish has left #openstack-horizon | 20:10 | |
| tqtran | doug-fish tsk tsk tsk, leaving in the middle of a testing convo | 20:11 |
| TravT_ | he's a smart man | 20:11 |
| *** jingjing_ren has quit IRC | 20:11 | |
| * tqtran got disconnected. | 20:11 | |
| TravT_ | tqtran: not to derail, but related | 20:12 |
| TravT_ | can we get https://review.openstack.org/#/c/188225/ pushed through? | 20:12 |
| TravT_ | it actually gives us karma testing at the gate | 20:12 |
| tqtran | whoa, battle of the cores | 20:13 |
| *** oro_ has joined #openstack-horizon | 20:13 | |
| tqtran | this is interesting, i shall read | 20:13 |
| matt-borland | sorry if i'm slow today. I'm trying to comprehend all these alternate viewpoints against code that, in this case, I can't recall if I wrote it, and ensure that we aren't just talking academically. | 20:13 |
| tqtran | np matt-borland, take some time to think it over | 20:14 |
| matt-borland | I want to make sure we're not bleeding from unit test into integration test. | 20:14 |
| *** tjones1 has joined #openstack-horizon | 20:14 | |
| tqtran | the way i see it, the api part isn't part of the launch-instance unit test. | 20:15 |
| matt-borland | One reflection I have in general is that, in the case of the model code in particular, it seems that much of the functionality should be broken into separate services, offloading much of the testing into finer-grained tests that don't need to know about APIs. | 20:15 |
| *** clu has joined #openstack-horizon | 20:16 | |
| TravT_ | i just see us writing dozens and dozens of tests like this in the future and all of them redefining the api objects with zero real contract. | 20:16 |
| matt-borland | yeah. That is the problem. | 20:16 |
| *** e0ne has joined #openstack-horizon | 20:16 | |
| matt-borland | I feel like I need to wander off to a mountain and shut myself in a cave for a couple of days. | 20:17 |
| TravT_ | maybe you should leave work early and I'll buy you a beer. | 20:18 |
| tqtran | :D you will come out enlighten, becomes a buddhist | 20:18 |
| matt-borland | I have to run an interview later today, but TravT let's follow up on that beer soon | 20:18 |
| tqtran | or what TravT_ said, buy him a beer, talk sweet and change his mind | 20:18 |
| matt-borland | it's not about changing my mind, I'm not in disagreement with you. I do want to make sure we're going down the right path. | 20:19 |
| tqtran | :D i'm just messing around. you should ask your interviewee this question and see what he/she says (evil lol) | 20:20 |
| matt-borland | I think a lot of it comes from the melding of our async data management with more fundamental logic in our code. | 20:20 |
| matt-borland | OMG great idea tqtran! | 20:20 |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Removing last_activity session flag https://review.openstack.org/179513 | 20:22 |
| matt-borland | bleh, if we make our model tests use the actual api code, that will necessitate dragging in all their dependencies | 20:23 |
| matt-borland | *reference the api code | 20:24 |
| TravT_ | maybe we just need to have festivus | 20:24 |
| TravT_ | https://www.youtube.com/watch?v=c8g4Ztf7hIM | 20:24 |
| *** jingjing_ren has joined #openstack-horizon | 20:24 | |
| TravT_ | have an airing of grievances | 20:24 |
| matt-borland | I dunno, TravT, I completely agree there is a fragility in the existing approach. | 20:25 |
| matt-borland | I'm not sure that dragging in the apis to the test (as needed to perform the spying) is a great idea. | 20:25 |
| matt-borland | this is not limited to APIs, any code that refers to methods in other code and needs to mock it, would have to do this. | 20:26 |
| matt-borland | the only reason we think we should do this here is because a) it's big and obvious mocked data and b) it has to have a lot of code to deal with promises, etc. | 20:27 |
| matt-borland | This is the nature of mocking calls, isn't it? | 20:28 |
| TravT_ | the dependencies are a bit of a catch-22 | 20:29 |
| matt-borland | Will the next JavaScript have interfaces? | 20:29 |
| matt-borland | :) | 20:29 |
| *** lhcheng has quit IRC | 20:29 | |
| matt-borland | I honestly think if the mocking code weren't so big and obvious, we wouldn't complain. We didn't on any other patch that uses mocking. | 20:30 |
| TravT_ | the DRY problem is yet another problem | 20:30 |
| TravT_ | that deferred code is basically copy paste all over | 20:30 |
| matt-borland | (sorry, you all get to watch me go through the 12 steps) | 20:30 |
| matt-borland | 1...denial | 20:30 |
| matt-borland | 2...regret | 20:31 |
| tqtran | lol | 20:31 |
| matt-borland | TravT: no doubt, I agree there. | 20:31 |
| matt-borland | we could clean up the repetitiveness like we did in the API tests. | 20:31 |
| TravT_ | if we swing all the way back around to tqtran's complaint | 20:33 |
| TravT_ | and kept values | 20:33 |
| matt-borland | ok... | 20:33 |
| TravT_ | there are still a lot of things that don't look particularly special about this data. | 20:34 |
| matt-borland | yeah | 20:34 |
| *** annashen has joined #openstack-horizon | 20:34 | |
| TravT_ | i do know that sharing data between tests can sometimes be more confusing than not though | 20:34 |
| matt-borland | right. | 20:35 |
| matt-borland | it might be a real pain if, to write a simple test, I have to swap back and forth between my test file and a big config for some megadatamockserviceobjectthing. | 20:36 |
| matt-borland | again, this doesn't rear its ugly head in other test files because it's not so big and ugly. | 20:36 |
| TravT_ | test data is sometimes useful to leverage, sometimes not | 20:38 |
| matt-borland | exactly | 20:38 |
| *** fedexo has quit IRC | 20:38 | |
| *** nlahouti has joined #openstack-horizon | 20:38 | |
| matt-borland | also, to reach out to the multiple branches of code, you have to have lots of variations on the data | 20:38 |
| TravT_ | yep. | 20:38 |
| matt-borland | which is often better to keep close to the test code, than to have to place out in some other config. | 20:38 |
| TravT_ | but sometimes definitely nice to have some real data to leverage. | 20:39 |
| matt-borland | A core of data might be nice. | 20:39 |
| matt-borland | I agree, esp. for things like...images | 20:39 |
| matt-borland | I just want a basic image data set. | 20:39 |
| TravT_ | also, the APIs actually do change format sometimes. | 20:39 |
| TravT_ | yep | 20:39 |
| *** iamjarvo has quit IRC | 20:39 | |
| matt-borland | doesn't mean you can't write your own or vary it tremendously for a test case | 20:40 |
| TravT_ | yep | 20:40 |
| matt-borland | so we've discussed, between this and the patch comments, about 12+ things. | 20:40 |
| TravT_ | yep | 20:40 |
| TravT_ | while true; print "yep" | 20:40 |
| matt-borland | I feel like to bring myself back to the world of sanity, I need to break out the different concerns. | 20:41 |
| matt-borland | *my sanity* to be clear | 20:41 |
| TravT_ | we're all in this together | 20:41 |
| matt-borland | Although I really am interested in your whiteboard example of the spyOn/andCallFake, I really think that drawing in the APIs in order to do that defeats the purpose of a unit test. | 20:42 |
| matt-borland | so, | 20:42 |
| matt-borland | is there another way? | 20:42 |
| matt-borland | you mentioned Java and those independent Interfaces. Would this be another purpose of the api mocks? | 20:43 |
| *** jtriley has quit IRC | 20:43 | |
| matt-borland | not to draw in the 'actual' apis but the mock apis almost as one would an interface? Where they essentially become the reference point for implementation | 20:44 |
| matt-borland | ? | 20:44 |
| TravT_ | yeah, that's a pretty good idea | 20:44 |
| TravT_ | perhaps... | 20:45 |
| matt-borland | it sounds dodgy to me | 20:45 |
| matt-borland | but I'm throwing it out | 20:45 |
| *** e0ne has quit IRC | 20:45 | |
| TravT_ | it is a little dodgy | 20:45 |
| matt-borland | but it alleviates having to draw in all those dependencies | 20:45 |
| matt-borland | ... | 20:46 |
| matt-borland | so, backing up to a larger picture... | 20:46 |
| matt-borland | what I'm really starting to think is that we need more e2e testing | 20:47 |
| matt-borland | hey, yet another test push | 20:47 |
| TravT_ | or maybe we need no testing. | 20:47 |
| TravT_ | :P | 20:47 |
| tqtran | +2 | 20:47 |
| matt-borland | something to be said for that | 20:47 |
| matt-borland | bleh. | 20:48 |
| *** e0ne has joined #openstack-horizon | 20:48 | |
| TravT_ | but you are right about the "external" dependency aspect. | 20:48 |
| TravT_ | the mocks are a fake implementation | 20:49 |
| TravT_ | i mean you could have a mock api that gets injects | 20:49 |
| matt-borland | *sigh* Although I agree about the brittleness, I keep coming back to the fact that these are 'unit' tests. | 20:49 |
| TravT_ | and then spyOn andCallFake on it | 20:49 |
| *** lblanchard has quit IRC | 20:50 | |
| matt-borland | yeah, that is traditionally how you'd handle this kind of situation. | 20:50 |
| matt-borland | in other programming worlds, so perhaps that is a valid pattern. | 20:50 |
| TravT_ | but there are 150 lines of code in this patch that is mock... maybe half of that is sheer redundancy | 20:51 |
| *** ameade has joined #openstack-horizon | 20:51 | |
| TravT_ | ideally, it would be nice to have a library like the one you referenced before (i think you wrote) | 20:52 |
| matt-borland | API Test? | 20:52 |
| TravT_ | yeah | 20:52 |
| matt-borland | My brain is just about run out. how about this for next steps: | 20:53 |
| TravT_ | that doesn't solve the fragility | 20:53 |
| matt-borland | 1) Clean up the DRY problem of creating all these promises, etc. | 20:53 |
| TravT_ | of method names... | 20:53 |
| matt-borland | 2) make all of this a little more declarative if possible. | 20:54 |
| matt-borland | From there we can then swap in different logic to handle brittleness more easily. | 20:54 |
| matt-borland | One last thought... | 20:54 |
| matt-borland | No one has argued that the tests do not exercise the code under test properly. | 20:55 |
| matt-borland | *so why don't we approve this patch and fix it appropriately?* | 20:55 |
| *** botang has joined #openstack-horizon | 20:55 | |
| TravT_ | fear that nobody will address it in the future. | 20:56 |
| TravT_ | but, i could be arm twisted. | 20:56 |
| matt-borland | what we have argued is that it doesn't address the code *not* under test. | 20:56 |
| matt-borland | TravT: that is always a concern. But we have no tests for this code now. | 20:56 |
| tyr_ | TravT_: I'm a little concerned that we are holding the more important re-org effort hostage with this test effort | 20:57 |
| *** amotoki has quit IRC | 20:57 | |
| tqtran | +2 tyr_ | 20:57 |
| TravT_ | the re-org is not that held up | 20:57 |
| TravT_ | i approved through two last night | 20:57 |
| tqtran | 2 of r1chardj0n3s re-org merged, but they were pretty indepdent, not sure about others | 20:57 |
| TravT_ | only couldn't go further | 20:57 |
| TravT_ | because it has problems | 20:57 |
| TravT_ | https://review.openstack.org/#/c/185132/ | 20:57 |
| matt-borland | TravT: tqtran: guys, I very much appreciate all your thoughts on this...and want these discussions to continue...but I have to prep for the interview. | 20:58 |
| * tyr_ adds a little salt to make his foot tastier | 20:58 | |
| matt-borland | thanks!!! | 20:58 |
| *** mattfarina has quit IRC | 20:59 | |
| *** matt-borland has quit IRC | 21:00 | |
| *** nullvariable has joined #openstack-horizon | 21:02 | |
| *** jingjing_ren has quit IRC | 21:03 | |
| tyr_ | tqtran: FYI, I refactored the flavor tests to use the digest cycle. It is a dependent patch on the original tests. | 21:03 |
| tqtran | thanks tyr_! | 21:03 |
| *** hurgleburgler1 has joined #openstack-horizon | 21:04 | |
| tyr_ | oops. Just noticed some gate fails, but I'll clean that up now. | 21:04 |
| *** hurgleburgler has quit IRC | 21:04 | |
| TravT_ | tyr_ if you think you could fix up r1chardj0n3s next patch, he'd probably appreciate it | 21:04 |
| tyr_ | I bet I can. I'll do that next. Thanks for the suggestion! | 21:04 |
| *** jingjing_ren has joined #openstack-horizon | 21:05 | |
| *** e0ne has quit IRC | 21:06 | |
| *** crobertsrh has left #openstack-horizon | 21:06 | |
| *** lhcheng has joined #openstack-horizon | 21:06 | |
| *** oro_ has quit IRC | 21:08 | |
| *** lhcheng_ has joined #openstack-horizon | 21:08 | |
| *** Sukhdev has quit IRC | 21:10 | |
| *** Ephur has quit IRC | 21:11 | |
| *** davidmichaelkarr has joined #openstack-horizon | 21:11 | |
| *** lhcheng has quit IRC | 21:11 | |
| *** iamjarvo has joined #openstack-horizon | 21:12 | |
| TravT_ | tqtran: there isn't a clear best solution here. | 21:12 |
| *** iamjarvo has quit IRC | 21:12 | |
| TravT_ | what do you think? | 21:12 |
| tqtran | TravT_: i think we can revisit this issue later, lets not hold up the tests and orgs, as it is blocking other angular efforts | 21:13 |
| *** iamjarvo has joined #openstack-horizon | 21:13 | |
| TravT_ | yeah, in the absence of perfection, this is an improvement | 21:13 |
| tqtran | so for now, i think its fine to just push it through | 21:13 |
| tqtran | we can hash it out at the midcycle lol | 21:13 |
| TravT_ | yeah, might as well. | 21:13 |
| TravT_ | :) | 21:14 |
| *** lucasXu has quit IRC | 21:15 | |
| *** jbell8 has quit IRC | 21:15 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: Flavor tests - use a digest cycle to test watches https://review.openstack.org/188587 | 21:18 |
| *** tqtran is now known as tqtran_afk | 21:20 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: ngReorg - move dashboard controllers from horizon https://review.openstack.org/185132 | 21:25 |
| *** sumanth has quit IRC | 21:28 | |
| *** sumanth has joined #openstack-horizon | 21:29 | |
| *** tyr__ has joined #openstack-horizon | 21:30 | |
| *** tyr_ has quit IRC | 21:30 | |
| *** iamjarvo has quit IRC | 21:31 | |
| *** rhagarty has quit IRC | 21:32 | |
| *** cbader has quit IRC | 21:32 | |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - move core HTML from framework to dashboard https://review.openstack.org/186295 | 21:36 |
| *** KunalGandhi has quit IRC | 21:36 | |
| *** KunalGandhi has joined #openstack-horizon | 21:36 | |
| *** Miouge has quit IRC | 21:37 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - Legacy JS files https://review.openstack.org/186921 | 21:37 |
| *** iamjarvo has joined #openstack-horizon | 21:38 | |
| *** jtriley has joined #openstack-horizon | 21:39 | |
| *** openstack has joined #openstack-horizon | 21:42 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: ngReorg - move dashboard controllers from horizon https://review.openstack.org/185132 | 21:44 |
| *** amotoki has joined #openstack-horizon | 21:44 | |
| *** jtriley has quit IRC | 21:44 | |
| *** tqtran_afk is now known as tqtran | 21:45 | |
| *** lhcheng_ has quit IRC | 21:51 | |
| *** Piet has joined #openstack-horizon | 21:51 | |
| *** lhcheng has joined #openstack-horizon | 21:54 | |
| r1chardj0n3s | TravT_, tyr__ ohai | 21:58 |
| *** alanf-mc has quit IRC | 22:00 | |
| *** vijendar has quit IRC | 22:00 | |
| TravT_ | r1chardj0n3s: ohai | 22:00 |
| *** amotoki has quit IRC | 22:11 | |
| *** stevemar has quit IRC | 22:12 | |
| *** tjones1 has quit IRC | 22:13 | |
| *** tjones1 has joined #openstack-horizon | 22:14 | |
| *** annashen has quit IRC | 22:19 | |
| r1chardj0n3s | sounds like I missed a lively discussion about testing methodologies :) \o/ for being asleep :) | 22:19 |
| * r1chardj0n3s sees nothing critical to deal with, enters Saturday Morning Mode | 22:21 | |
| *** tjones2 has joined #openstack-horizon | 22:23 | |
| tyr__ | tqtran: Do you know Justin Pomeroy's handle? | 22:24 |
| *** tjones1 has quit IRC | 22:24 | |
| tqtran | um.... i do not, i dont even know if he logs into irc | 22:24 |
| tyr__ | He just made https://review.openstack.org/#/c/187604 that might have introduced a bug https://bugs.launchpad.net/horizon/+bug/1462544 | 22:25 |
| openstack | Launchpad bug 1462544 in OpenStack Dashboard (Horizon) "Create Image: Uncaught TypeError: $form.on is not a function" [Undecided,New] | 22:25 |
| tyr__ | Not certain the "right" way to contact him. Email...some other channel? | 22:26 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Encase helper-functions spec in IIFE https://review.openstack.org/185721 | 22:27 |
| tqtran | i think email is your best bet | 22:27 |
| tqtran | let me see if he is on sametime | 22:27 |
| tqtran | he is away, i msged him to get on irc when hes available | 22:28 |
| tqtran | but you should email i think | 22:28 |
| tyr__ | ok. Thx! | 22:28 |
| sqchen | Hi tqtran: | 22:29 |
| *** alanf-mc has joined #openstack-horizon | 22:30 | |
| *** jpomero has joined #openstack-horizon | 22:31 | |
| tyr__ | tqtran: What is preferred for .js...tabs or spaces? | 22:31 |
| jpomero | tqtran, tyr__ what's up | 22:33 |
| tyr__ | Hi jpomero I just noticed https://bugs.launchpad.net/horizon/+bug/1462544 might be related to your recent change. | 22:33 |
| openstack | Launchpad bug 1462544 in OpenStack Dashboard (Horizon) "Create Image: Uncaught TypeError: $form.on is not a function" [Undecided,New] | 22:33 |
| *** ZZelle has quit IRC | 22:33 | |
| tyr__ | just wanted to give you a heads up | 22:34 |
| jpomero | tyr__, are you seeing this on any particular browser? | 22:36 |
| tyr__ | chrome 43.0.2357.81 / OSX | 22:36 |
| openstackgerrit | Thai Tran proposed openstack/horizon: Encase helper-functions spec in IIFE https://review.openstack.org/185721 | 22:36 |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Updated UX for project and region selector https://review.openstack.org/186193 | 22:36 |
| *** tjones2 has quit IRC | 22:36 | |
| *** openstackgerrit has quit IRC | 22:37 | |
| jpomero | tyr__, you see this just opening the form? performing an action? what is the scenario? | 22:37 |
| tyr__ | just opening the create image dialog | 22:37 |
| tyr__ | (with the inspector open) | 22:37 |
| *** openstackgerrit has joined #openstack-horizon | 22:37 | |
| *** iamjarvo has quit IRC | 22:37 | |
| openstackgerrit | Thai Tran proposed openstack/horizon: Encase helper-functions spec in IIFE https://review.openstack.org/185721 | 22:37 |
| jpomero | tyr__, ok i will take a look | 22:37 |
| tyr__ | thanks jpomero: I figured it would be fresh in your mind, so you'd be a good person to do a quick triage at least. | 22:40 |
| jpomero | yep makes sense | 22:40 |
| *** ongk has quit IRC | 22:40 | |
| *** cody-somerville has quit IRC | 22:42 | |
| tyr__ | tqtran: I just noticed jscs errors on the flavor.js. Is someone else already fixing that file? Else I'll clean it up today. | 22:46 |
| tqtran | i dont think so, you can go ahead and clean it up | 22:46 |
| tyr__ | thx | 22:47 |
| *** sjmc7 has quit IRC | 22:49 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: Launch Instance NG - Create Volume if Nova Ext https://review.openstack.org/188963 | 22:51 |
| *** tjones1 has joined #openstack-horizon | 22:53 | |
| *** petertr7_away is now known as petertr7 | 22:58 | |
| *** sjmc7 has joined #openstack-horizon | 23:00 | |
| openstackgerrit | Merged openstack/horizon: [Launch Instance Fix] Add Model Unit Tests https://review.openstack.org/167738 | 23:00 |
| *** bradjones is now known as bradjones_away | 23:00 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: JSCS Cleanup - flavor.js https://review.openstack.org/188965 | 23:01 |
| *** dsneddon has quit IRC | 23:01 | |
| *** dsneddon has joined #openstack-horizon | 23:03 | |
| *** jingjing_ren has quit IRC | 23:04 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: JSCS Cleanup - flavor.js https://review.openstack.org/188965 | 23:06 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: JSCS Cleanup - flavor.js https://review.openstack.org/188965 | 23:07 |
| *** nullvariable has quit IRC | 23:07 | |
| *** petertr7 is now known as petertr7_away | 23:07 | |
| openstackgerrit | Diana Whitten proposed openstack/horizon: Minor Reorganization of Default Themes https://review.openstack.org/188966 | 23:12 |
| openstackgerrit | Travis Tripp proposed openstack/horizon: [Launch Instance Fix] Add Model Block Device Test https://review.openstack.org/188967 | 23:13 |
| *** tyr__ has quit IRC | 23:19 | |
| *** tyr_ has joined #openstack-horizon | 23:19 | |
| *** annashen has joined #openstack-horizon | 23:20 | |
| *** bradjones_away is now known as bradjones | 23:20 | |
| *** yamamoto has joined #openstack-horizon | 23:26 | |
| *** annashen has quit IRC | 23:26 | |
| *** tosky has quit IRC | 23:27 | |
| *** jtriley has joined #openstack-horizon | 23:28 | |
| *** alexvictorchan has quit IRC | 23:30 | |
| *** yamamoto has quit IRC | 23:31 | |
| *** jtriley has quit IRC | 23:33 | |
| *** tyr_ has quit IRC | 23:33 | |
| *** hurgleburgler1 has quit IRC | 23:38 | |
| *** iamjarvo has joined #openstack-horizon | 23:38 | |
| sqchen | tqtran: are you around? | 23:39 |
| *** sjmc7 has quit IRC | 23:39 | |
| *** Drago has quit IRC | 23:41 | |
| *** bradjones has quit IRC | 23:42 | |
| *** bradjones has joined #openstack-horizon | 23:42 | |
| *** bradjones is now known as bradjones_away | 23:47 | |
| *** bpokorny has quit IRC | 23:49 | |
| *** tjones1 has quit IRC | 23:50 | |
| *** dboik_ has quit IRC | 23:50 | |
| *** bradjones_away is now known as bradjones|away | 23:52 | |
| *** amotoki has joined #openstack-horizon | 23:53 | |
| *** sseago has quit IRC | 23:55 | |
| *** lhcheng has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!