| * r1chardj0n3s is testing david-lyle's tox env patch | 00:00 | |
| krotscheck | Well, an alternate proposal might be to add a venv_only switch to run_tests, invoke that before npm takes over so the environment has all its dependencies. | 00:00 |
|---|---|---|
| TravT | so, in gate, krotscheck: does your method need a virtual env? | 00:01 |
| krotscheck | TravT: That mostly depends on how the karma file is set up. If it is smart enough to check either the .venv or the globally installed dependencies, then it _shouldn't_ | 00:02 |
| david-lyle | I the reusable job makes sense, I'm all for it. If we have to make a kludgy mess to make it work, it may be a task for when we are more javascripty | 00:02 |
| david-lyle | not making a judgement call on the kludge factor yet | 00:02 |
| *** alexpilotti has quit IRC | 00:03 | |
| krotscheck | .... I somewhat feel that it will require some kind of invocation of run_tests.sh | 00:03 |
| TravT | it is looking in venv | 00:03 |
| r1chardj0n3s | ... and the chicken blood. don't forget the chicken | 00:04 |
| david-lyle | Ill supply the chickens | 00:04 |
| TravT | good call r1chardj0n3s | 00:04 |
| krotscheck | But we can't do run_tests.sh, because it would invoke npm run, which would invoke run tests, which would invoke npm run which would recursion | 00:04 |
| * TravT looks for an open window to jump through | 00:04 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 00:04 |
| * david-lyle casually opens the window | 00:04 | |
| david-lyle | :P | 00:04 |
| krotscheck | Sorry, that was supposed to say 'run_tests.sh -k1 | 00:04 |
| TravT | lol... it is definitely feeling like beer:30 | 00:05 |
| *** yamamoto has quit IRC | 00:05 | |
| r1chardj0n3s | wow, this tox thing takes aaaaages | 00:05 |
| r1chardj0n3s | oh. IT IS INSTALLING NODE | 00:05 |
| r1chardj0n3s | wheeeeeee :) | 00:05 |
| hurgleburgler | yay! | 00:06 |
| r1chardj0n3s | I forgot nodeenv was in there | 00:06 |
| krotscheck | ohai :) | 00:06 |
| r1chardj0n3s | it does take a while ;) | 00:07 |
| krotscheck | The more I think about it, the more I feel y'all should do the venv thing | 00:07 |
| TravT | https://github.com/openstack/horizon/blob/master/openstack_dashboard/karma.conf.js#L4 | 00:07 |
| r1chardj0n3s | IT IS RUNNING TESTS \o/ | 00:07 |
| krotscheck | But hey, there's an npm-install macro that will install node from the distro :) | 00:07 |
| r1chardj0n3s | no, spoke too soon. now it's npm-installing | 00:07 |
| krotscheck | TravT: Yep, that looks hardcoded. | 00:07 |
| *** jingjing_ren has quit IRC | 00:08 | |
| * krotscheck just had an idea and will reappear shortly | 00:08 | |
| krotscheck | Oh. Hrm. Tox doesn't let me specify a directory | 00:10 |
| *** yamamoto has joined #openstack-horizon | 00:11 | |
| krotscheck | Nevermind | 00:11 |
| r1chardj0n3s | "ReferenceError: Can't find variable: angular" running your tox env david-lyle | 00:11 |
| r1chardj0n3s | so yeah | 00:11 |
| krotscheck | Looks like run_scripts does something that tox doesn't know about | 00:12 |
| david-lyle | oh sure blame my env | 00:12 |
| *** vahidh has quit IRC | 00:12 | |
| r1chardj0n3s | david-lyle: it's looking in .venv for the js, which doesn't exist | 00:12 |
| david-lyle | TravT: saw that earlier without my env | 00:12 |
| david-lyle | r1chardj0n3s: because the karma conf is hard coded? | 00:12 |
| david-lyle | yep | 00:13 |
| david-lyle | line 4 | 00:13 |
| r1chardj0n3s | david-lyle: actually, I am confused, since it's using xstatic packages, so I don't see why | 00:13 |
| r1chardj0n3s | ok, poo | 00:13 |
| *** jbell8 has quit IRC | 00:13 | |
| r1chardj0n3s | yeah, that's not good | 00:13 |
| david-lyle | no hard coding paths is never good | 00:14 |
| krotscheck | Ok, I have a hack | 00:14 |
| * krotscheck waits for everyone to put on their hack goggles. | 00:14 | |
| * r1chardj0n3s doesn't take them off | 00:14 | |
| krotscheck | `tox -epy27 --notest; ln -s ./.tox/py27 ./.venv; npm run test;` | 00:15 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 00:15 |
| krotscheck | That worked for me. | 00:15 |
| r1chardj0n3s | krotscheck: lol | 00:15 |
| r1chardj0n3s | krotscheck: that's some hack :) | 00:15 |
| krotscheck | Folder don't exist? FINE! HERE IT IS! *fireball* | 00:16 |
| r1chardj0n3s | :) | 00:16 |
| r1chardj0n3s | so I've added that symlink hack to david's thing, and am testing that | 00:16 |
| r1chardj0n3s | hm, no dice | 00:16 |
| TravT | i've still never seen that variable error. | 00:17 |
| TravT | i just get can't find the files. | 00:17 |
| r1chardj0n3s | TravT: the one I mentioned? | 00:17 |
| TravT | yeah | 00:17 |
| r1chardj0n3s | yeah, it's at the bottom of "all the files are missing" | 00:17 |
| r1chardj0n3s | (for me) | 00:17 |
| david-lyle | it's hard coded path | 00:17 |
| TravT | there it is... too many years of scrolling up to find the issue. | 00:18 |
| david-lyle | http://git.openstack.org/cgit/openstack/horizon/tree/horizon/karma.conf.js#n4 | 00:18 |
| r1chardj0n3s | yeah, I don't know how to work around that, to be honest | 00:18 |
| david-lyle | is bad bad bad bad | 00:18 |
| r1chardj0n3s | krotscheck might have an idea ... | 00:18 |
| krotscheck | Iiiiiit's hacky! | 00:19 |
| krotscheck | hacky mchackypants | 00:19 |
| krotscheck | Wait, no, this is a big hack. That means it's Hack MacHackypants. | 00:19 |
| r1chardj0n3s | krotscheck: if we can figure out how to dynamically get the correct venv path into the karma conf, we can have the tox env working | 00:19 |
| krotscheck | (Because all the big hacks are scottish) | 00:19 |
| r1chardj0n3s | orly? | 00:19 |
| david-lyle | lol | 00:19 |
| *** yamamoto has quit IRC | 00:21 | |
| krotscheck | I'm doing one last pass on this particular hack, and then I will propose all the hackyness. | 00:21 |
| david-lyle | compound hacks, excellent | 00:21 |
| krotscheck | Well, at least in this case I'm _not_ using run_tests, so there isn't any additional wacky chain that might cause dependency issues. | 00:22 |
| krotscheck | And makes deprecating that script easier. | 00:22 |
| krotscheck | One question though: Is setting up the venv more of an "npm install" thing, or more of a "npm run test" thing? | 00:22 |
| krotscheck | (this matters for semantics only) | 00:22 |
| r1chardj0n3s | that has to rate as one of the most bizarre questions I've read here recently :) | 00:23 |
| krotscheck | r1chardj0n3s: Hey, we control npm from tox, why not control tox from npm? | 00:23 |
| *** gyee has quit IRC | 00:23 | |
| TravT | i'd vote run test | 00:23 |
| r1chardj0n3s | sure, so venv is an install thing | 00:23 |
| r1chardj0n3s | lol | 00:23 |
| r1chardj0n3s | david-lyle: tie breaker! | 00:23 |
| david-lyle | install? | 00:24 |
| r1chardj0n3s | given that we don't "npm install" in horizon except to install npm tools | 00:24 |
| TravT | my arm is easily twisted on this question | 00:24 |
| r1chardj0n3s | hmm | 00:24 |
| krotscheck | One comment though. | 00:24 |
| r1chardj0n3s | .. but now we find the npm tools need the venv. we just have to be careful not to go in circles :/ | 00:24 |
| krotscheck | So if I do a run_tests.sh, what it will do is set up its own venv, invoke npm install, which will then invoke tox and blow away the run_tests venv with a symlink | 00:25 |
| r1chardj0n3s | I think there's a higher-level question of how we set up the environment(s) that we need, prior to running commands | 00:25 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 00:25 |
| krotscheck | 'cause _that's_ not brittle | 00:25 |
| r1chardj0n3s | krotscheck: yikes | 00:26 |
| r1chardj0n3s | krotscheck: sorry mate, but -1 :( | 00:26 |
| *** yamamoto has joined #openstack-horizon | 00:26 | |
| r1chardj0n3s | hmm | 00:26 |
| krotscheck | r1chardj0n3s: Yeah, still trying to figure out how to get around that. | 00:26 |
| TravT | can we just pass args for the base path at invocation? | 00:26 |
| r1chardj0n3s | david-lyle: why is the tox env using the -N? does it *have* to? | 00:26 |
| r1chardj0n3s | if the tox karma env didn't -N it would work | 00:27 |
| krotscheck | TravT: maybe. Lemme check | 00:27 |
| r1chardj0n3s | TravT: I looked, but my fu there is lacking, I hope krotscheck can find something to do that | 00:27 |
| TravT | i was also looking (aka googling) | 00:27 |
| david-lyle | probably to be more like devstack and real install, but don't know really | 00:28 |
| krotscheck | TravT: It looks like one can custom add client commands | 00:28 |
| r1chardj0n3s | yeah, problem is that the general use-case of karma has a much saner configuration with a source tree that doesn't move about | 00:28 |
| *** iamjarvo has joined #openstack-horizon | 00:28 | |
| *** iamjarvo has quit IRC | 00:28 | |
| r1chardj0n3s | we're being very weird moving it about :( | 00:28 |
| david-lyle | :q | 00:28 |
| r1chardj0n3s | if the karma conf could shell out to a python program to determine the correct venv for the xstatic ... OMG | 00:28 |
| r1chardj0n3s | actually, tox will set an env var, won't it? | 00:29 |
| *** iamjarvo has joined #openstack-horizon | 00:29 | |
| *** iamjarvo has quit IRC | 00:29 | |
| *** iamjarvo has joined #openstack-horizon | 00:29 | |
| *** iamjarvo has quit IRC | 00:30 | |
| r1chardj0n3s | certainly we can *set* one for it | 00:30 |
| r1chardj0n3s | er, *in* it | 00:30 |
| r1chardj0n3s | if JS can use the env var | 00:30 |
| krotscheck | How about we just tell the karma configuration to look for its own dependencies? | 00:30 |
| david-lyle | can we specify a different package.json? | 00:31 |
| krotscheck | it _is_ a functional language | 00:31 |
| david-lyle | krotscheck: my concern was using a completely different dependency chain to test isn't a really valid way to test | 00:31 |
| *** iamjarvo has joined #openstack-horizon | 00:31 | |
| david-lyle | we want to test horizon based on what it will be shipped with | 00:31 |
| *** iamjarvo has quit IRC | 00:31 | |
| r1chardj0n3s | krotscheck: lol, you imply javascript is a function language? :) | 00:31 |
| krotscheck | david-lyle: I'm proposing that karma.conf.js checks to see whether the xstaticPath should point at .venv or at .tox | 00:32 |
| r1chardj0n3s | krotscheck: yes, that would be good | 00:32 |
| david-lyle | ah, ok | 00:32 |
| david-lyle | that's good | 00:32 |
| krotscheck | Gimme a few minutes, I think I can test that. | 00:32 |
| TravT | yeah, that's what I was implying as well. | 00:32 |
| r1chardj0n3s | we'd probably have to hard-code the tox env name, but that's not too horrid | 00:32 |
| *** iamjarvo has joined #openstack-horizon | 00:32 | |
| krotscheck | r1chardj0n3s: We wouldn't have to, py27 has everything we need. | 00:32 |
| r1chardj0n3s | which is why I was saying we could set an env var in tox which is passed into karma, if karma conf can use the env var | 00:33 |
| TravT | okay, i have to go for now... | 00:33 |
| r1chardj0n3s | ok | 00:33 |
| *** yamamoto has quit IRC | 00:38 | |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - Legacy JS files https://review.openstack.org/186921 | 00:40 |
| openstackgerrit | Cindy Lu proposed openstack/horizon: JSCS Cleanup - Legacy JS files https://review.openstack.org/186921 | 00:43 |
| *** gary-smith has quit IRC | 00:43 | |
| *** Sukhdev has quit IRC | 00:59 | |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Trigger tox from package.json, if necessary. https://review.openstack.org/188225 | 01:00 |
| r1chardj0n3s | krotscheck: not to be a nit, but is there no way to handle an environment var passed in rather than hard-code py27? | 01:01 |
| r1chardj0n3s | actually, s/"not to be"/"being" :) | 01:01 |
| krotscheck | r1chardj0n3s: process.env.VARNAME | 01:01 |
| r1chardj0n3s | lemme just check - I'm pretty sure tox defines the tox env as an env var | 01:01 |
| krotscheck | r1chardj0n3s: You're assuming we're running the tests from inside of a venv. | 01:02 |
| krotscheck | Which I don't think we can do. | 01:02 |
| r1chardj0n3s | oh, I getcha | 01:02 |
| openstackgerrit | Michael Krotscheck proposed openstack/horizon: Trigger tox from package.json, if necessary. https://review.openstack.org/188225 | 01:02 |
| krotscheck | Ok, I think that'll work | 01:02 |
| krotscheck | npm install will now selectively create a venv, if .venv is not found (so that run_tests.sh -k will still work sanely) | 01:03 |
| r1chardj0n3s | krotscheck: so you're looking to not use david-lyle's patch setting up the karma tox env? | 01:03 |
| krotscheck | We can use that too :) | 01:03 |
| r1chardj0n3s | if we can just launch karma from tox that keeps things simpler, yeah | 01:03 |
| krotscheck | I'm still advocating for the JS only tooling ;D | 01:03 |
| r1chardj0n3s | er, maybe not "simpler" but at least consistent ;) | 01:03 |
| krotscheck | Rather than launching tox from karma? | 01:03 |
| krotscheck | :D | 01:03 |
| r1chardj0n3s | yeah, I know, and I'm with ya :/ | 01:03 |
| r1chardj0n3s | yeah | 01:03 |
| krotscheck | Well, we can argue it out on gerrit. At least now the big hurdle, which is the hardcoded paths, is overcome. | 01:04 |
| r1chardj0n3s | hm, I don't think tox sets any env vars by default :/ | 01:04 |
| r1chardj0n3s | yep! | 01:04 |
| krotscheck | And now, I go do anniversary things. | 01:05 |
| krotscheck | Toodles! | 01:05 |
| r1chardj0n3s | oh! go! :) | 01:05 |
| r1chardj0n3s | thanks krotscheck! | 01:05 |
| krotscheck | r1chardj0n3s: btw, you need to look at this: https://etherpad.openstack.org/p/modern-javascript-roadmap | 01:05 |
| r1chardj0n3s | krotscheck: yep | 01:05 |
| krotscheck | It's all still freeform and duplicalicious | 01:06 |
| krotscheck | Anyway, I'm off. | 01:06 |
| krotscheck | Toodles! | 01:06 |
| r1chardj0n3s | "duplicalicious" love it :) | 01:06 |
| *** jtriley has quit IRC | 01:06 | |
| *** openstack has joined #openstack-horizon | 01:22 | |
| *** jwy has joined #openstack-horizon | 01:22 | |
| *** eroussel has joined #openstack-horizon | 01:23 | |
| *** openstack has joined #openstack-horizon | 01:37 | |
| *** iamjarvo has quit IRC | 01:42 | |
| *** tyr_ has quit IRC | 01:46 | |
| *** jtriley has joined #openstack-horizon | 01:48 | |
| openstackgerrit | Merged openstack/horizon: Bootstrap variables should derive from a known theme. https://review.openstack.org/187797 | 01:49 |
| *** jbell8 has joined #openstack-horizon | 01:49 | |
| *** openstack has quit IRC | 01:52 | |
| *** openstack has joined #openstack-horizon | 01:54 | |
| openstackgerrit | WonChon proposed openstack/horizon: Support flavor-id uuid format at trove. https://review.openstack.org/181657 | 01:58 |
| *** iamjarvo has joined #openstack-horizon | 02:00 | |
| *** iamjarvo has quit IRC | 02:00 | |
| *** jbell8 has quit IRC | 02:00 | |
| *** iamjarvo has joined #openstack-horizon | 02:00 | |
| *** doug-fish has left #openstack-horizon | 02:00 | |
| *** iamjarvo has quit IRC | 02:00 | |
| *** packet has quit IRC | 02:01 | |
| *** iamjarvo has joined #openstack-horizon | 02:01 | |
| *** clu_ has joined #openstack-horizon | 02:01 | |
| *** radez is now known as radez_g0n3 | 02:04 | |
| *** clu_ has quit IRC | 02:04 | |
| *** packet has joined #openstack-horizon | 02:05 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move utils from dashboad-app https://review.openstack.org/185140 | 02:06 |
| *** jtriley has quit IRC | 02:08 | |
| *** KunalGan_ has joined #openstack-horizon | 02:33 | |
| *** KunalGandhi has quit IRC | 02:37 | |
| *** iamjarvo_ has joined #openstack-horizon | 02:37 | |
| *** iamjarvo_ has quit IRC | 02:37 | |
| *** iamjarvo_ has joined #openstack-horizon | 02:37 | |
| *** mwhagedorn has quit IRC | 02:37 | |
| *** KunalGan_ has quit IRC | 02:38 | |
| *** tqtran has quit IRC | 02:39 | |
| *** iamjarvo has quit IRC | 02:40 | |
| *** jtriley has joined #openstack-horizon | 02:44 | |
| *** jingliuqing has joined #openstack-horizon | 02:44 | |
| *** iamjarvo_ has quit IRC | 02:46 | |
| *** julim has quit IRC | 02:47 | |
| *** jtriley has quit IRC | 02:56 | |
| *** stevemar has joined #openstack-horizon | 02:58 | |
| *** jwy has quit IRC | 03:01 | |
| *** alanf-mc has quit IRC | 03:04 | |
| *** lhcheng has quit IRC | 03:08 | |
| *** jingjing_ren has joined #openstack-horizon | 03:09 | |
| *** lhcheng has joined #openstack-horizon | 03:32 | |
| *** alanf-mc has joined #openstack-horizon | 03:34 | |
| *** eroussel has quit IRC | 03:35 | |
| *** hurgleburgler1 has quit IRC | 03:42 | |
| *** sumanth has quit IRC | 03:45 | |
| *** sumanth has joined #openstack-horizon | 03:48 | |
| *** sumanth has quit IRC | 03:53 | |
| *** sumanth has joined #openstack-horizon | 03:53 | |
| *** EmilienM|off has quit IRC | 03:55 | |
| *** sumanth has quit IRC | 03:58 | |
| *** EmilienM has joined #openstack-horizon | 04:00 | |
| *** jingliuqing has quit IRC | 04:01 | |
| *** andrew019 has joined #openstack-horizon | 04:01 | |
| andrew019 | hi, i put a pdb debugger before cinder.service_list is called. is there a way to print in human readable format of what the service_list actually is? | 04:02 |
| *** jingjing_ren has quit IRC | 04:12 | |
| *** sumanth has joined #openstack-horizon | 04:12 | |
| *** masco has joined #openstack-horizon | 04:13 | |
| *** Longgeek has joined #openstack-horizon | 04:14 | |
| *** ongk has joined #openstack-horizon | 04:17 | |
| *** ongk has quit IRC | 04:17 | |
| *** krotscheck has quit IRC | 04:19 | |
| *** mordred has quit IRC | 04:21 | |
| *** mordred has joined #openstack-horizon | 04:25 | |
| *** krotscheck has joined #openstack-horizon | 04:25 | |
| *** neelabh has joined #openstack-horizon | 04:29 | |
| *** andrew019 has quit IRC | 04:32 | |
| *** Longgeek has quit IRC | 04:39 | |
| *** rushiagr_away is now known as rushiagr | 04:42 | |
| *** dsneddon has quit IRC | 04:42 | |
| *** clu_ has joined #openstack-horizon | 04:51 | |
| *** Longgeek has joined #openstack-horizon | 04:53 | |
| *** clu_ has quit IRC | 04:53 | |
| *** Longgeek_ has joined #openstack-horizon | 04:57 | |
| *** kiran-r has joined #openstack-horizon | 05:00 | |
| *** sumanth has quit IRC | 05:00 | |
| *** Longgeek has quit IRC | 05:00 | |
| *** stevemar has quit IRC | 05:04 | |
| *** sumanth has joined #openstack-horizon | 05:08 | |
| *** alanf-mc has quit IRC | 05:19 | |
| *** alanf-mc has joined #openstack-horizon | 05:20 | |
| *** pkarikh has quit IRC | 05:41 | |
| *** alanf-mc has quit IRC | 05:51 | |
| *** yingjun has joined #openstack-horizon | 05:54 | |
| *** belmoreira has joined #openstack-horizon | 05:56 | |
| *** lhcheng has quit IRC | 05:56 | |
| *** josecastroleon has joined #openstack-horizon | 05:57 | |
| *** nikunj2512 has joined #openstack-horizon | 06:13 | |
| *** mrunge has joined #openstack-horizon | 06:17 | |
| *** mrunge has quit IRC | 06:17 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Imported Translations from Transifex https://review.openstack.org/188274 | 06:18 |
| *** jtriley has joined #openstack-horizon | 06:23 | |
| *** mrunge has joined #openstack-horizon | 06:26 | |
| *** jtriley has quit IRC | 06:27 | |
| *** yingjun has quit IRC | 06:34 | |
| *** Kunal has joined #openstack-horizon | 06:36 | |
| *** KunalGandhi has joined #openstack-horizon | 06:36 | |
| *** nikunj2512_ has joined #openstack-horizon | 06:39 | |
| *** clu_ has joined #openstack-horizon | 06:40 | |
| *** oro_ has joined #openstack-horizon | 06:40 | |
| *** nikunj2512 has quit IRC | 06:41 | |
| *** jtomasek has quit IRC | 06:41 | |
| *** jtomasek has joined #openstack-horizon | 06:42 | |
| *** clu_ has quit IRC | 06:42 | |
| *** jtomasek has quit IRC | 06:43 | |
| *** jtomasek has joined #openstack-horizon | 06:44 | |
| *** amotoki has joined #openstack-horizon | 06:52 | |
| *** amotoki has quit IRC | 07:03 | |
| *** robcresswell has quit IRC | 07:04 | |
| *** oro_ has quit IRC | 07:10 | |
| *** yingjun has joined #openstack-horizon | 07:21 | |
| *** Ala has joined #openstack-horizon | 07:21 | |
| *** mrunge has quit IRC | 07:23 | |
| *** mrunge has joined #openstack-horizon | 07:23 | |
| *** mrunge_ has joined #openstack-horizon | 07:25 | |
| *** ygbo has joined #openstack-horizon | 07:26 | |
| *** mrunge_ has quit IRC | 07:26 | |
| *** amotoki has joined #openstack-horizon | 07:27 | |
| *** mrunge has quit IRC | 07:29 | |
| *** mrunge has joined #openstack-horizon | 07:30 | |
| *** zz_ttrifonov is now known as ttrifonov | 07:30 | |
| *** KunalGandhi has quit IRC | 07:32 | |
| *** sqchen has quit IRC | 07:33 | |
| *** Kunal has quit IRC | 07:35 | |
| *** sqchen has joined #openstack-horizon | 07:37 | |
| *** chlong has quit IRC | 07:44 | |
| *** dguerri`away is now known as dguerri | 07:49 | |
| *** sqchen has quit IRC | 07:52 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 07:55 | |
| *** romainh has joined #openstack-horizon | 07:57 | |
| *** aix has joined #openstack-horizon | 08:03 | |
| *** pkarikh has joined #openstack-horizon | 08:05 | |
| *** yingjun has quit IRC | 08:17 | |
| openstackgerrit | Merged openstack/horizon: Imported Translations from Transifex https://review.openstack.org/188274 | 08:18 |
| *** yingjun has joined #openstack-horizon | 08:19 | |
| *** amotoki has quit IRC | 08:20 | |
| *** amotoki has joined #openstack-horizon | 08:20 | |
| *** ZZelle has quit IRC | 08:28 | |
| *** ZZelle has joined #openstack-horizon | 08:29 | |
| *** clu_ has joined #openstack-horizon | 08:29 | |
| *** clu_ has quit IRC | 08:31 | |
| *** lhcheng has joined #openstack-horizon | 08:31 | |
| *** JeanBriceCombebi has quit IRC | 08:39 | |
| *** oro_ has joined #openstack-horizon | 08:45 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 08:48 | |
| *** akrivoka has joined #openstack-horizon | 08:59 | |
| *** amotoki has quit IRC | 09:08 | |
| *** yamamoto has quit IRC | 09:11 | |
| *** yamamoto has joined #openstack-horizon | 09:12 | |
| *** Mzoorikh has quit IRC | 09:13 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: JSCS Cleanup - dashboard-app https://review.openstack.org/188316 | 09:17 |
| *** svasheka has joined #openstack-horizon | 09:22 | |
| *** yamamoto has quit IRC | 09:32 | |
| *** amotoki has joined #openstack-horizon | 09:38 | |
| *** yingjun has quit IRC | 09:41 | |
| *** amotoki has quit IRC | 09:42 | |
| *** e0ne has joined #openstack-horizon | 09:44 | |
| *** lhcheng has quit IRC | 09:45 | |
| *** romainh has quit IRC | 09:51 | |
| *** svasheka has quit IRC | 09:52 | |
| *** JeanBriceCombebi has quit IRC | 10:08 | |
| *** clu_ has joined #openstack-horizon | 10:17 | |
| *** clu_ has quit IRC | 10:19 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 10:21 | |
| *** svasheka has joined #openstack-horizon | 10:24 | |
| *** yamamoto has joined #openstack-horizon | 10:24 | |
| *** yamamoto has quit IRC | 10:30 | |
| *** yamamoto has joined #openstack-horizon | 10:46 | |
| *** Longgeek_ has quit IRC | 10:53 | |
| *** Longgeek has joined #openstack-horizon | 10:54 | |
| *** romainh has joined #openstack-horizon | 10:57 | |
| mrunge | Hey Horizoners, just a heads up: we were thinking about a mid cycle meetup (dirty details in yesterdays meeting logs and on https://docs.google.com/spreadsheets/d/1w0eI6SPCA2IrOyHiEYC2uDO3fbYGzahZRUQSva0UD3Y/edit?pli=1#gid=0 | 10:58 |
| mrunge | three places, two dates proposed. If you're interested, please vote in the google docs spreadsheet | 10:59 |
| *** JeanBriceCombebi has quit IRC | 10:59 | |
| *** robcresswell has joined #openstack-horizon | 11:00 | |
| *** sumanth has quit IRC | 11:22 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: JSCS cleanup - openstack_dashboard/static/ https://review.openstack.org/187971 | 11:29 |
| openstackgerrit | Zhenguo Niu proposed openstack/horizon: Delete period from select option in LiveMigrateForm https://review.openstack.org/188349 | 11:29 |
| *** aix has quit IRC | 11:30 | |
| *** nikunj2512_ has quit IRC | 11:35 | |
| *** e0ne is now known as e0ne_ | 11:39 | |
| openstackgerrit | Zhenguo Niu proposed openstack/horizon: Exclude current volume_type from Volume retype list https://review.openstack.org/188354 | 11:43 |
| *** masco has quit IRC | 11:44 | |
| *** jj__ has joined #openstack-horizon | 11:47 | |
| *** e0ne_ has quit IRC | 11:49 | |
| jj__ | if I am adding a new django module should I include url template of module in "horizon/horizon/site_urls" file? | 11:49 |
| *** kiran-r has quit IRC | 11:49 | |
| mrunge | jj__, you should probably hook it in the same way as e.g the router dashboard is added | 11:55 |
| mrunge | jj__, it's in openstack_dashboard/enabled/... | 11:56 |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Add "capabilities: boot_option:local" to flavor creation https://review.openstack.org/188358 | 12:01 |
| *** svasheka has quit IRC | 12:02 | |
| *** clu_ has joined #openstack-horizon | 12:06 | |
| *** jj__ has quit IRC | 12:06 | |
| *** yamamoto has quit IRC | 12:08 | |
| *** clu_ has quit IRC | 12:08 | |
| *** yamamoto has joined #openstack-horizon | 12:09 | |
| *** e0ne has joined #openstack-horizon | 12:13 | |
| openstackgerrit | Ana Krivokapic proposed openstack/tuskar-ui: Add "capabilities: boot_option:local" to flavor creation https://review.openstack.org/188358 | 12:15 |
| *** mpavlase has joined #openstack-horizon | 12:17 | |
| *** chlong has joined #openstack-horizon | 12:20 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:21 | |
| *** jtriley has joined #openstack-horizon | 12:22 | |
| *** unixlike has quit IRC | 12:23 | |
| *** aix has joined #openstack-horizon | 12:30 | |
| openstackgerrit | Christian Berendt proposed openstack/horizon: Remove first newline from generated OpenSTack RC file https://review.openstack.org/188376 | 12:35 |
| *** rushiagr is now known as rushiagr_away | 12:36 | |
| *** rwsu has joined #openstack-horizon | 12:36 | |
| *** JeanBriceCombebi has quit IRC | 12:36 | |
| *** yamamoto has quit IRC | 12:38 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:38 | |
| *** svasheka has joined #openstack-horizon | 12:39 | |
| *** yamamoto has joined #openstack-horizon | 12:39 | |
| *** stevemar has joined #openstack-horizon | 12:41 | |
| *** masco has joined #openstack-horizon | 12:42 | |
| *** svasheka__ has joined #openstack-horizon | 12:44 | |
| *** svasheka has quit IRC | 12:44 | |
| *** DaveJ__ has joined #openstack-horizon | 12:46 | |
| *** mwhagedorn has joined #openstack-horizon | 12:52 | |
| *** JeanBriceCombebi has quit IRC | 12:53 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 12:53 | |
| *** peristeri has joined #openstack-horizon | 12:54 | |
| *** mrunge has quit IRC | 12:55 | |
| *** kiran-r has joined #openstack-horizon | 12:58 | |
| *** zhenguo has quit IRC | 12:58 | |
| *** jtriley has quit IRC | 12:59 | |
| *** e0ne is now known as e0ne_ | 13:01 | |
| *** yamamoto has quit IRC | 13:01 | |
| openstackgerrit | Merged openstack/horizon: added description column in firewall tables https://review.openstack.org/187536 | 13:01 |
| *** yamamoto has joined #openstack-horizon | 13:02 | |
| *** julim has joined #openstack-horizon | 13:04 | |
| *** e0ne_ is now known as e0ne | 13:04 | |
| *** iamjarvo has joined #openstack-horizon | 13:08 | |
| *** Miouge_ has joined #openstack-horizon | 13:09 | |
| *** Miouge has quit IRC | 13:12 | |
| *** Miouge_ is now known as Miouge | 13:12 | |
| *** yamamoto has quit IRC | 13:12 | |
| *** oro_ has quit IRC | 13:13 | |
| *** petertr7_away is now known as petertr7 | 13:15 | |
| *** tosky has joined #openstack-horizon | 13:16 | |
| openstackgerrit | Rob Cresswell proposed openstack/horizon: JSCS Cleanup - dashboard-app https://review.openstack.org/188316 | 13:20 |
| *** pkarikh has quit IRC | 13:24 | |
| *** iamjarvo has quit IRC | 13:27 | |
| *** rushiagr_away is now known as rushiagr | 13:28 | |
| *** lblanchard has joined #openstack-horizon | 13:28 | |
| openstackgerrit | Matt Borland proposed openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 13:28 |
| *** doug-fish has joined #openstack-horizon | 13:28 | |
| *** matt-borland has joined #openstack-horizon | 13:29 | |
| *** yamamoto has joined #openstack-horizon | 13:30 | |
| *** iamjarvo has joined #openstack-horizon | 13:32 | |
| openstackgerrit | Vlad Okhrimenko proposed openstack/horizon: Drop QUnit JS tests in favor of Jasmine https://review.openstack.org/156572 | 13:32 |
| *** kiran-r has quit IRC | 13:41 | |
| *** TravT has quit IRC | 13:44 | |
| *** thiagop has joined #openstack-horizon | 13:45 | |
| *** cardeois________ has quit IRC | 13:48 | |
| *** cardeois________ has joined #openstack-horizon | 13:48 | |
| *** clu_ has joined #openstack-horizon | 13:55 | |
| *** yamamoto has quit IRC | 13:56 | |
| *** TravT has joined #openstack-horizon | 13:56 | |
| *** clu_ has quit IRC | 13:57 | |
| *** oro_ has joined #openstack-horizon | 13:58 | |
| *** e0ne is now known as e0ne_ | 13:59 | |
| *** jtriley has joined #openstack-horizon | 14:02 | |
| *** e0ne_ has quit IRC | 14:04 | |
| *** jprovazn has joined #openstack-horizon | 14:05 | |
| *** e0ne has joined #openstack-horizon | 14:06 | |
| *** masco has quit IRC | 14:07 | |
| *** neelabh has quit IRC | 14:08 | |
| *** iamjarvo has quit IRC | 14:08 | |
| matt-borland | TravT: tqtran: FYI, that API Test patch had a small merge conflict with the other test patch that went in (one line I think). I fixed the patch and re-uploaded. | 14:08 |
| matt-borland | https://review.openstack.org/#/c/178227/ | 14:08 |
| *** thiagop has left #openstack-horizon | 14:08 | |
| *** radez_g0n3 is now known as radez | 14:09 | |
| TravT | matt-borland, thanks! Waiting for jenkins to finish re-checking it. | 14:09 |
| matt-borland | good plan | 14:09 |
| matt-borland | Thanks for supporting those test efforts | 14:10 |
| *** iamjarvo has joined #openstack-horizon | 14:13 | |
| *** peristeri has quit IRC | 14:15 | |
| *** peristeri has joined #openstack-horizon | 14:15 | |
| *** tyr_ has joined #openstack-horizon | 14:17 | |
| openstackgerrit | Zhenguo Niu proposed openstack/horizon: Exclude current volume_type from Volume retype list https://review.openstack.org/188354 | 14:17 |
| *** iamjarvo has quit IRC | 14:20 | |
| *** Ala has quit IRC | 14:28 | |
| *** dboik has joined #openstack-horizon | 14:28 | |
| *** julim has quit IRC | 14:29 | |
| *** JeanBriceCombebi has quit IRC | 14:32 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 14:33 | |
| matt-borland | Hey TravT: out of morbid curiosity what is the npm test error? I don't see it when I check out the code. | 14:38 |
| matt-borland | re: api test patch | 14:38 |
| TravT | look at the tests on the patch itself | 14:39 |
| TravT | there is a new non-voting job | 14:39 |
| TravT | it runs npm test (karma) | 14:39 |
| matt-borland | Oh! sorry, I see what you mean | 14:39 |
| matt-borland | in the gate job | 14:39 |
| TravT | if you are able to get the horizon room logs from last night, you'll see a rather enjoyable 2 hour conversation about this yesterday late afternoon | 14:40 |
| matt-borland | lordy! | 14:40 |
| matt-borland | It's like watching the replay of a baseball game | 14:40 |
| *** iamjarvo has joined #openstack-horizon | 14:40 | |
| *** tyr__ has joined #openstack-horizon | 14:42 | |
| *** tyr_ has quit IRC | 14:42 | |
| *** vijendar has joined #openstack-horizon | 14:43 | |
| *** jtriley has quit IRC | 14:44 | |
| *** chlong has quit IRC | 14:47 | |
| krotscheck | matt-borland, TravT: Yeah, and in the meantime that npm-run job landed on infra. | 14:48 |
| * krotscheck should have marked that as WIP | 14:48 | |
| matt-borland | I like it. ) | 14:49 |
| TravT | krotscheck: i should have removed the +1 at the end of the discussion | 14:51 |
| *** ducttape_ has joined #openstack-horizon | 14:52 | |
| *** ducttape_ has quit IRC | 14:53 | |
| *** tyr__ has quit IRC | 14:53 | |
| krotscheck | TravT: Well, we can decide to revert it. | 14:53 |
| *** tyr_ has joined #openstack-horizon | 14:54 | |
| TravT | it isn't hurting anything really at the moment i guess. we could test it with your other patch though right if we landed it in horizon? | 14:56 |
| TravT | we could work through it further when r1chardj0nes: david-lyle: are available. | 14:56 |
| *** yamamoto has joined #openstack-horizon | 14:56 | |
| TravT | i have to go at the moment... need to run the weekly searchlight meeting | 14:56 |
| *** alexvictorchan has quit IRC | 14:57 | |
| krotscheck | TravT: Oooh, what channel is that in? | 14:57 |
| * krotscheck will lurk | 14:58 | |
| TravT | #openstack-meeting-4 | 14:58 |
| krotscheck | Seems like the only question we have on the karma update patch of mine is r1chardj0n3s's "Hey I wanna merge this" and mrunge's desire to never use venv's. I get both of them, I'll noodle through how the latter might work on my drive in to work. | 14:59 |
| *** yamamoto has quit IRC | 15:02 | |
| *** belmoreira has quit IRC | 15:05 | |
| *** JeanBriceCombebi has quit IRC | 15:06 | |
| *** julim has joined #openstack-horizon | 15:08 | |
| *** Drago has joined #openstack-horizon | 15:08 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:08 | |
| krotscheck | Left some comments for mrunge | 15:09 |
| *** Drago has quit IRC | 15:10 | |
| *** romainh has left #openstack-horizon | 15:10 | |
| *** Drago has joined #openstack-horizon | 15:10 | |
| krotscheck | And now, I commute! | 15:10 |
| *** tyr__ has joined #openstack-horizon | 15:11 | |
| *** tyr_ has quit IRC | 15:11 | |
| *** alexpilotti has joined #openstack-horizon | 15:11 | |
| *** jtriley has joined #openstack-horizon | 15:13 | |
| *** cardeois________ has quit IRC | 15:14 | |
| *** cardeois________ has joined #openstack-horizon | 15:14 | |
| *** ducttape_ has joined #openstack-horizon | 15:14 | |
| *** bpokorny has joined #openstack-horizon | 15:15 | |
| *** tyr_ has joined #openstack-horizon | 15:16 | |
| *** tyr__ has quit IRC | 15:16 | |
| openstackgerrit | Dan Nguyen proposed openstack/horizon: Retrieve domain scoped token https://review.openstack.org/148082 | 15:18 |
| *** mpavlase has quit IRC | 15:19 | |
| esp | btully ^ | 15:19 |
| *** DaveJ__ has quit IRC | 15:21 | |
| btully | heya | 15:22 |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - move dashboard-app/login out https://review.openstack.org/185133 | 15:22 |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - move dashboard controllers from horizon https://review.openstack.org/185132 | 15:22 |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - Move API files to openstack_dashboard https://review.openstack.org/184543 | 15:22 |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - move core HTML from framework to dashboard https://review.openstack.org/186295 | 15:22 |
| openstackgerrit | Ryan Peters proposed openstack/horizon: ngReorg - move utils from dashboad-app https://review.openstack.org/185140 | 15:22 |
| *** notmars has joined #openstack-horizon | 15:23 | |
| btully | thanks esp i’ll take a look | 15:26 |
| esp | you will also need this | 15:26 |
| esp | https://review.openstack.org/#/c/188184/ | 15:26 |
| esp | bpokorny you may care about these too ^ | 15:27 |
| *** sjmc7 has joined #openstack-horizon | 15:28 | |
| *** ongk has joined #openstack-horizon | 15:30 | |
| bpokorny | esp: What's the issue with the subtree that 188184 fixes? | 15:30 |
| *** tosky has quit IRC | 15:31 | |
| esp | bpokorny: fixes the list_role_assignments in secure way | 15:31 |
| esp | https://review.openstack.org/#/c/148082/69..70/openstack_dashboard/api/keystone.py | 15:32 |
| esp | ^ also cleans up the code here significantly | 15:33 |
| *** gyee has joined #openstack-horizon | 15:33 | |
| bpokorny | So for a domain admin to list role assignments, you needed https://review.openstack.org/#/c/180846/ as well as 188184? | 15:33 |
| *** jbell8 has joined #openstack-horizon | 15:33 | |
| esp | bpokorny: yeah dude, you will need the patch start by priti with gyee’s changes | 15:34 |
| *** tosky has joined #openstack-horizon | 15:34 | |
| esp | and then you will need our patch for v3 domain support | 15:34 |
| esp | and finally… a small change to python keystone client | 15:34 |
| *** jtriley has quit IRC | 15:34 | |
| bpokorny | esp: Thanks, that makes sense. | 15:34 |
| esp | np, brb | 15:35 |
| openstackgerrit | Merged openstack/horizon: Angular API Unit Tests https://review.openstack.org/178227 | 15:41 |
| btully | esp so i’m assuming one should handle the python-keystoneclient patch like the django-openstack-auth patch? i.e., clone repo and patch it and then symlink to the patched client from within our local horizon env? | 15:41 |
| *** clu_ has joined #openstack-horizon | 15:44 | |
| *** clu_ has quit IRC | 15:46 | |
| *** jtriley has joined #openstack-horizon | 15:49 | |
| *** JeanBriceCombebi has quit IRC | 15:50 | |
| *** jbell8 has quit IRC | 15:51 | |
| *** JeanBriceCombebi has joined #openstack-horizon | 15:56 | |
| *** nlahouti has joined #openstack-horizon | 15:57 | |
| openstackgerrit | Eric Peterson proposed openstack/horizon: Add fip to lbaas vip info https://review.openstack.org/180676 | 16:00 |
| *** tyr__ has joined #openstack-horizon | 16:02 | |
| *** tyr_ has quit IRC | 16:02 | |
| *** julim has quit IRC | 16:03 | |
| *** mattfarina has joined #openstack-horizon | 16:04 | |
| openstackgerrit | Kelly Domico proposed openstack/horizon: Fix project name error when creating project (Keystone v3) https://review.openstack.org/188116 | 16:05 |
| *** julim has joined #openstack-horizon | 16:05 | |
| *** iamjarvo has quit IRC | 16:05 | |
| *** jbell8 has joined #openstack-horizon | 16:05 | |
| *** ygbo has quit IRC | 16:06 | |
| *** cardeois________ has quit IRC | 16:07 | |
| *** cardeois________ has joined #openstack-horizon | 16:08 | |
| *** alexvictorchan has joined #openstack-horizon | 16:10 | |
| openstackgerrit | Brian Tully proposed openstack/horizon: WIP - Hide Quota/Usage table actions re Domains https://review.openstack.org/187783 | 16:10 |
| openstackgerrit | Matt Borland proposed openstack/horizon: [Launch Instance Fix] Add Flavor Step Unit Tests https://review.openstack.org/167326 | 16:11 |
| matt-borland | tyr: modified the flavor patch as you suggest, should be much happier. Easier to understand too. | 16:11 |
| *** hurgleburgler has joined #openstack-horizon | 16:14 | |
| hurgleburgler | So, a patch went in yesterday that might require a small bit of reorganization of SCSS if you were making use of a custom theme before, but not providing your own bootstrap variables (which means relying on the standard bootstrap shipped variables) | 16:16 |
| ducttape_ | more info pls hurgleburgler - I had some custom themes, and only over-wrote a few variables | 16:17 |
| hurgleburgler | If this broke you, due to some customizations that already exist, I highly recommend the following directory structure for your theme | 16:17 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/django_openstack_auth: Updated from global requirements https://review.openstack.org/188120 | 16:17 |
| hurgleburgler | openstack_dashboard/static/themes/{your custom theme}/ | 16:17 |
| hurgleburgler | Is required to have two files in it: _styles.scss and _variables.scss | 16:17 |
| * ducttape_ commits to review this ^ when he rebases w upstream | 16:18 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/188474 | 16:18 |
| hurgleburgler | I recommend that this base directory contain two subdirectories | 16:18 |
| hurgleburgler | 'bootstrap' and 'horizon' | 16:18 |
| hurgleburgler | and then, each import from there: | 16:18 |
| hurgleburgler | hurgleburgler$ cat _styles.scss | 16:18 |
| hurgleburgler | @import "bootstrap/styles"; | 16:18 |
| hurgleburgler | @import "horizon/styles"; | 16:18 |
| hurgleburgler | hurgleburgler$ cat _variables.scss | 16:19 |
| hurgleburgler | @import "bootstrap/variables"; | 16:19 |
| hurgleburgler | @import "horizon/variables"; | 16:19 |
| hurgleburgler | so … all of your customizations that existed at the base level, should just be moved into a 'horizon' subdirectory and imported from the top directory | 16:19 |
| *** JeanBriceCombebi has quit IRC | 16:20 | |
| hurgleburgler | I recommend keeping ALL bootstrap specific changes (to bootstrap variables and to bootstrap elements) completely separate from all Horizon customizations … that will keep your app easier to skin in the future :) | 16:20 |
| hurgleburgler | You will want to COPY the _variables.scss from the default theme into your new bootstrap/_variables.scss file if you have no already provided a custom bootstrap variable file | 16:21 |
| *** jtriley has quit IRC | 16:21 | |
| hurgleburgler | Be sure that you copy the openstack_dashboard/static/themes/default/_variables.scss … and NOT the default bootstrap one, as they are now going to diverge with Horizon have its own custom Bootstrap skin | 16:22 |
| openstackgerrit | Brian Tully proposed openstack/horizon: Hide Quota/Usage table actions for non Cloud-Admin https://review.openstack.org/187783 | 16:22 |
| hurgleburgler | If anyone hits any bumps with this, just shoot me a message and I can help out | 16:22 |
| *** sqchen has joined #openstack-horizon | 16:25 | |
| *** sqchen has quit IRC | 16:26 | |
| *** jbell8 has quit IRC | 16:26 | |
| *** sqchen has joined #openstack-horizon | 16:27 | |
| *** svasheka__ has quit IRC | 16:29 | |
| *** iamjarvo has joined #openstack-horizon | 16:31 | |
| *** iamjarvo has quit IRC | 16:31 | |
| *** aix has quit IRC | 16:33 | |
| *** petertr7 is now known as petertr7_away | 16:33 | |
| *** matt-borland has quit IRC | 16:35 | |
| krotscheck | ooookay I'm back. | 16:38 |
| *** SimonChung has quit IRC | 16:39 | |
| *** amotoki has joined #openstack-horizon | 16:39 | |
| *** iamjarvo has joined #openstack-horizon | 16:41 | |
| *** iamjarvo has quit IRC | 16:41 | |
| *** iamjarvo has joined #openstack-horizon | 16:41 | |
| *** amotoki has quit IRC | 16:45 | |
| *** jbell8 has joined #openstack-horizon | 16:48 | |
| *** jbell8 has quit IRC | 16:49 | |
| *** iamjarvo has quit IRC | 16:49 | |
| *** bpokorny has quit IRC | 16:49 | |
| *** bpokorny has joined #openstack-horizon | 16:50 | |
| *** clu_ has joined #openstack-horizon | 16:50 | |
| *** jbell8 has joined #openstack-horizon | 16:52 | |
| *** KunalGandhi has joined #openstack-horizon | 16:52 | |
| openstackgerrit | Kahou Lei proposed openstack/horizon: Port should not be detached when changing name https://review.openstack.org/185796 | 16:53 |
| *** alanf-mc has joined #openstack-horizon | 16:59 | |
| *** tosky has quit IRC | 17:00 | |
| *** svasheka__ has joined #openstack-horizon | 17:01 | |
| *** matt-borland has joined #openstack-horizon | 17:04 | |
| *** mwhagedorn has quit IRC | 17:05 | |
| *** jingjing_ren has joined #openstack-horizon | 17:06 | |
| *** mwhagedorn has joined #openstack-horizon | 17:07 | |
| *** jingjing_ren has quit IRC | 17:08 | |
| *** jingjing_ren has joined #openstack-horizon | 17:09 | |
| *** alanf-mc has quit IRC | 17:10 | |
| *** alanf-mc has joined #openstack-horizon | 17:12 | |
| *** mark-os has joined #openstack-horizon | 17:13 | |
| mark-os | Anyone here having issues with keystone? | 17:14 |
| *** jwy has joined #openstack-horizon | 17:15 | |
| *** hurgleburgler has quit IRC | 17:15 | |
| *** hurgleburgler has joined #openstack-horizon | 17:16 | |
| *** svasheka__ has quit IRC | 17:16 | |
| *** bradjones is now known as bradjones_away | 17:19 | |
| *** notmars has quit IRC | 17:19 | |
| *** dscottsf has joined #openstack-horizon | 17:20 | |
| *** dscottsf has quit IRC | 17:21 | |
| *** mark-os has quit IRC | 17:21 | |
| *** oro_ has quit IRC | 17:21 | |
| *** dsneddon has joined #openstack-horizon | 17:21 | |
| *** e0ne has quit IRC | 17:22 | |
| *** dguerri is now known as dguerri`away | 17:24 | |
| *** dguerri`away is now known as dguerri | 17:24 | |
| *** dguerri is now known as dguerri`away | 17:24 | |
| *** Viswanath has joined #openstack-horizon | 17:25 | |
| *** petertr7_away is now known as petertr7 | 17:26 | |
| *** josecastroleon has quit IRC | 17:28 | |
| *** Viswanath has quit IRC | 17:30 | |
| *** Glass_saga has quit IRC | 17:34 | |
| *** sqchen has quit IRC | 17:37 | |
| *** notmars has joined #openstack-horizon | 17:38 | |
| *** sqchen has joined #openstack-horizon | 17:40 | |
| *** bpokorny_ has joined #openstack-horizon | 17:42 | |
| *** jbell8 has quit IRC | 17:42 | |
| *** bpokorny has quit IRC | 17:43 | |
| *** jbell8 has joined #openstack-horizon | 17:45 | |
| *** dontalton has joined #openstack-horizon | 17:47 | |
| *** gyee has quit IRC | 17:49 | |
| david-lyle | robcresswell: ping | 17:49 |
| *** lhcheng has joined #openstack-horizon | 17:50 | |
| *** lhcheng_ has joined #openstack-horizon | 17:51 | |
| *** lhcheng has quit IRC | 17:55 | |
| *** jbell8 has quit IRC | 17:56 | |
| *** rushiagr is now known as rushiagr_away | 17:57 | |
| *** jprovazn has quit IRC | 18:01 | |
| *** Viswanath has joined #openstack-horizon | 18:01 | |
| *** jtriley has joined #openstack-horizon | 18:03 | |
| *** Viswanath has quit IRC | 18:04 | |
| *** lhcheng has joined #openstack-horizon | 18:07 | |
| *** lhcheng_ has quit IRC | 18:07 | |
| *** jbell8 has joined #openstack-horizon | 18:07 | |
| *** jtriley has quit IRC | 18:13 | |
| *** notmars has quit IRC | 18:14 | |
| *** packet has quit IRC | 18:15 | |
| *** iamjarvo has joined #openstack-horizon | 18:15 | |
| *** dguerri`away is now known as dguerri | 18:17 | |
| *** ybathia has joined #openstack-horizon | 18:17 | |
| *** jbell8 has quit IRC | 18:18 | |
| *** lhcheng_ has joined #openstack-horizon | 18:20 | |
| *** iamjarvo has quit IRC | 18:21 | |
| *** Sukhdev has joined #openstack-horizon | 18:22 | |
| *** tqtran has joined #openstack-horizon | 18:23 | |
| *** lhcheng has quit IRC | 18:23 | |
| *** mpavlase has joined #openstack-horizon | 18:24 | |
| *** iamjarvo has joined #openstack-horizon | 18:25 | |
| *** jtriley has joined #openstack-horizon | 18:26 | |
| *** notmars has joined #openstack-horizon | 18:26 | |
| *** jbell8 has joined #openstack-horizon | 18:26 | |
| *** lhcheng_ has quit IRC | 18:27 | |
| *** amotoki has joined #openstack-horizon | 18:28 | |
| *** bradjones_away is now known as bradjones | 18:29 | |
| *** iamjarvo has quit IRC | 18:32 | |
| *** tosky has joined #openstack-horizon | 18:33 | |
| *** amotoki has quit IRC | 18:33 | |
| *** sjmc7 has quit IRC | 18:36 | |
| *** openstackstatus has joined #openstack-horizon | 18:39 | |
| *** ChanServ sets mode: +v openstackstatus | 18:39 | |
| *** bradjones is now known as bradjones_away | 18:40 | |
| -openstackstatus- NOTICE: Gerrit has been restarted to clear an issue with its event stream. Any change events between 17:25 and 18:38 UTC should be rechecked or have their approvals reapplied to initiate testing. | 18:42 | |
| tyr__ | tqtran: I've been looking at the flavor patch. I like your suggestion of triggering the watch code. I also wanted to share with you a technique to search for named functions in the spy. | 18:44 |
| tyr__ | See https://review.openstack.org/#/c/188544 | 18:44 |
| tqtran | yeah i just saw that too | 18:44 |
| tqtran | i also think that is a good idea | 18:45 |
| tqtran | lets have matt do both :) | 18:45 |
| tyr__ | LOL | 18:45 |
| matt-borland | lol | 18:45 |
| matt-borland | !! | 18:45 |
| tqtran | :D | 18:45 |
| openstack | matt-borland: Error: "!" is not a valid command. | 18:45 |
| tqtran | hi matt-borland!!! | 18:45 |
| tqtran | tyr__ and I really appreciate your effort | 18:45 |
| matt-borland | I kinda asked tyr to follow up with you Thai, since he's been looking at solving the same problem. | 18:46 |
| tyr__ | I going to start a 3rd version of dependent patch with the rootscope idea (which is probably the cleanest option). If that looks nice, I'll merge it into flavors test. | 18:46 |
| tqtran | see? even openstack is chewing matt-borland out | 18:46 |
| matt-borland | BURN!!! | 18:46 |
| tqtran | hahaha | 18:46 |
| tqtran | yeah, if we're using rootscope, the name doesn't matter as much but still nice to have since it adheres to JP's guidelines | 18:47 |
| tyr__ | ah! He suggests using named functions also? | 18:47 |
| tqtran | yep | 18:47 |
| tqtran | easier to debug | 18:47 |
| tyr__ | great! | 18:47 |
| tyr__ | Interesting. JPs example is a standalone function definition, but it seems valid to me to name functions in-line too. In things like $watch the brevity is nice. | 18:50 |
| *** packet has joined #openstack-horizon | 18:50 | |
| *** tyr__ is now known as tyr_ | 18:50 | |
| tyr_ | Sheesh...is there really another "Tyr" ? | 18:51 |
| *** packet has quit IRC | 18:51 | |
| *** vahidh has joined #openstack-horizon | 18:51 | |
| *** dguerri is now known as dguerri`away | 18:51 | |
| *** sjmc7 has joined #openstack-horizon | 18:53 | |
| *** jwy has quit IRC | 18:54 | |
| *** sqchen has quit IRC | 18:55 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: [Launch Instance Fix] Add Flavor Step Unit Tests https://review.openstack.org/167326 | 18:56 |
| *** jbell8 has quit IRC | 18:57 | |
| *** sqchen has joined #openstack-horizon | 18:58 | |
| *** jbell8 has joined #openstack-horizon | 18:59 | |
| *** vishwana_ has joined #openstack-horizon | 19:04 | |
| *** lhcheng has joined #openstack-horizon | 19:04 | |
| *** clu_ has quit IRC | 19:06 | |
| *** vishwanathj has quit IRC | 19:06 | |
| *** Longgeek has quit IRC | 19:12 | |
| *** cardeois________ has quit IRC | 19:12 | |
| *** petertr7 is now known as petertr7_away | 19:16 | |
| *** jtriley has quit IRC | 19:16 | |
| *** cardeois________ has joined #openstack-horizon | 19:16 | |
| openstackgerrit | Merged openstack/horizon: [Launch Instance Fix] Clean up Wizard scope https://review.openstack.org/169976 | 19:17 |
| *** Viswanath has joined #openstack-horizon | 19:18 | |
| *** jbell8 has quit IRC | 19:20 | |
| *** petertr7_away is now known as petertr7 | 19:21 | |
| *** Viswanath has quit IRC | 19:21 | |
| *** ybathia has quit IRC | 19:22 | |
| *** alanf-mc has quit IRC | 19:24 | |
| TravT | tqtran: are you there? | 19:25 |
| *** jtriley has joined #openstack-horizon | 19:29 | |
| *** iamjarvo has joined #openstack-horizon | 19:37 | |
| ekarlso | heya guys, what stuff is possible to do with angular atm ? | 19:40 |
| *** jtriley has quit IRC | 19:46 | |
| tqtran | TravT: just got back fom lunvh, wasup? | 19:47 |
| *** clu_ has joined #openstack-horizon | 19:48 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 19:50 |
| *** jbell8 has joined #openstack-horizon | 19:51 | |
| *** TravT has quit IRC | 19:53 | |
| *** TravT has joined #openstack-horizon | 19:54 | |
| TravT | tqtran: my connection dropped right after I messaged you a few ago. | 19:54 |
| tqtran | np, i just back from luch | 19:55 |
| tqtran | so wasup? | 19:55 |
| *** e0ne has joined #openstack-horizon | 19:55 | |
| tqtran | *lunch | 19:55 |
| *** Viswanath has joined #openstack-horizon | 19:55 | |
| *** tyr__ has joined #openstack-horizon | 19:57 | |
| *** tyr_ has quit IRC | 19:57 | |
| *** tyr_ has joined #openstack-horizon | 19:58 | |
| *** tyr__ has quit IRC | 19:58 | |
| *** TravT_ has joined #openstack-horizon | 19:58 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/horizon: Updated from global requirements https://review.openstack.org/188474 | 19:58 |
| *** iamjarvo has quit IRC | 19:59 | |
| *** TravT__ has joined #openstack-horizon | 19:59 | |
| *** TravT__ has quit IRC | 19:59 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 19:59 |
| *** TravT has quit IRC | 19:59 | |
| *** TravT has joined #openstack-horizon | 19:59 | |
| TravT | geez... comcast keeps dropping my internet | 19:59 |
| *** TravT_ has quit IRC | 20:00 | |
| *** Viswanath has quit IRC | 20:00 | |
| TravT | tqtran: trying again. re: https://review.openstack.org/#/c/185725/ i think we could just push it through, but wanted to know why you were blocking it | 20:00 |
| tqtran | is JSCS rules a non-voting job atm? | 20:02 |
| TravT | i don't think it has any job atm | 20:02 |
| *** TravT_ has joined #openstack-horizon | 20:02 | |
| tqtran | really? let me double check, if its not a job, then yeah, we can push it through | 20:02 |
| david-lyle | haha | 20:02 |
| david-lyle | funny story | 20:02 |
| david-lyle | by funny I mean sad | 20:03 |
| david-lyle | I'm not exactly what mixed up state we are in for npm based tests | 20:03 |
| tqtran | how do i check if it is a gate job or not? | 20:03 |
| david-lyle | just listed in the output | 20:04 |
| david-lyle | or you can look at openstack-infra/project-config | 20:04 |
| *** iamjarvo has joined #openstack-horizon | 20:04 | |
| *** iamjarvo has quit IRC | 20:04 | |
| *** iamjarvo has joined #openstack-horizon | 20:05 | |
| *** iamjarvo has quit IRC | 20:05 | |
| david-lyle | but no, it's not running | 20:05 |
| *** iamjarvo has joined #openstack-horizon | 20:05 | |
| tqtran | https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/horizon.yaml | 20:05 |
| tqtran | is this the file? | 20:05 |
| david-lyle | tqtran: that file defines the jobs | 20:06 |
| *** radez is now known as radez_g0n3 | 20:06 | |
| *** TravT__ has joined #openstack-horizon | 20:06 | |
| TravT_ | Yeah we need to finish off yesterdays fun with karma first | 20:06 |
| david-lyle | TravT_: I agree, but that's a slightly different beast | 20:07 |
| *** Viswanath has joined #openstack-horizon | 20:07 | |
| TravT_ | Unless I missed that this morning. | 20:07 |
| tqtran | TravT: ok, lets get it merge then | 20:07 |
| tqtran | i removed the -2 | 20:07 |
| david-lyle | because it won't have venv HARD-CODED into the freaking path | 20:07 |
| tqtran | it should help others who need to run the JSCS checks | 20:07 |
| *** TravT has quit IRC | 20:08 | |
| tqtran | lol | 20:08 |
| TravT__ | so, i'm tag-teaming between irc on my phone and on my computer now... | 20:08 |
| tqtran | thats his way of saying "I disagree" | 20:08 |
| tqtran | hahahaha | 20:08 |
| david-lyle | karma's a bitch, #truestory | 20:08 |
| matt-borland | lol | 20:08 |
| TravT__ | i think i have to pack it up and go into the offie or a coffee shop... | 20:08 |
| openstackgerrit | Merged openstack/horizon: Improve unittests for angular charts https://review.openstack.org/179251 | 20:08 |
| tqtran | go +2 it first | 20:08 |
| TravT__ | already did | 20:08 |
| david-lyle | +2 what | 20:08 |
| tqtran | BAM! got told | 20:09 |
| TravT__ | david-lyle: all the things | 20:09 |
| tqtran | https://review.openstack.org/#/c/185725/ | 20:09 |
| *** radez_g0n3 is now known as radez | 20:09 | |
| openstackgerrit | Merged openstack/horizon: Delete period from select option in LiveMigrateForm https://review.openstack.org/188349 | 20:09 |
| david-lyle | ^^^ that last one made horizon complete, we can go home now | 20:10 |
| *** Viswanath has quit IRC | 20:10 | |
| matt-borland | lol | 20:10 |
| TravT__ | awesome! | 20:10 |
| TravT__ | don't tell our bosses | 20:10 |
| tqtran | time to retired | 20:10 |
| tqtran | beer time | 20:10 |
| TravT__ | next meetup is in tahiti, right? | 20:10 |
| tqtran | so do we know when the midcycle is going to take place? | 20:11 |
| matt-borland | d'oh! now richard's patch is in merge conflict | 20:11 |
| tqtran | or still needing more feedback | 20:11 |
| ekarlso | any idea guys on when the angular stuffs will stabilize ? | 20:11 |
| david-lyle | ekarlso: 2019 | 20:11 |
| tqtran | ekarlso: tototally stable right now | 20:11 |
| tqtran | lol | 20:11 |
| TravT__ | matt-borland, i think his will be until we get the last couple tests through. | 20:11 |
| ekarlso | why always the sad jokes :p | 20:12 |
| *** TravT_ has quit IRC | 20:12 | |
| tqtran | ekarlso: hopefully at the end of this cycle | 20:12 |
| ekarlso | L1 ? | 20:12 |
| tqtran | as in end of liberty i think lol | 20:12 |
| TravT__ | ekarlso: taking care of technical debt on angular is a top priority at the moment. | 20:12 |
| *** TravT_ has joined #openstack-horizon | 20:12 | |
| tqtran | we have a modal example via launch instance, but still lacking a panel example | 20:12 |
| ekarlso | ok then, so not something to bet on for non-in-tree projects then.. | 20:13 |
| TravT__ | what is your timeline? | 20:13 |
| ekarlso | TravT__: just wondered what to use for a demo | 20:13 |
| TravT__ | david-lyle: we should circle back with nikhil and go over that mid-cycle meetup. | 20:13 |
| TravT__ | ekarlso: ongk put that together based on the work from kilo. | 20:14 |
| TravT__ | but we are trying to get tqtran's identity panel patch as the example for others to use | 20:14 |
| ekarlso | TravT__: k | 20:14 |
| ekarlso | TravT__: any link to that ? | 20:14 |
| TravT__ | https://review.openstack.org/#/c/133767/ | 20:15 |
| tqtran | but dont depend on it too much, it may go under some changes as soon as the translation stuff land | 20:16 |
| tqtran | basically, its a good starting point, but things are still in flux | 20:16 |
| ekarlso | omg, that's a big one ! | 20:16 |
| *** Viswanath has joined #openstack-horizon | 20:16 | |
| tqtran | yes, but most of it are comments | 20:16 |
| *** jwy has joined #openstack-horizon | 20:16 | |
| openstackgerrit | Merged openstack/horizon: Hidden HOST in instance overview page for normal user https://review.openstack.org/152763 | 20:17 |
| tqtran | i would say 60+% are comments | 20:17 |
| TravT__ | ideally, we'd get most the technical debt hammered out from kilo in a few weeks and then that panel soon after. | 20:17 |
| *** alanf-mc has joined #openstack-horizon | 20:17 | |
| *** amotoki has joined #openstack-horizon | 20:17 | |
| ekarlso | TravT__: alot of leftovers or ? | 20:17 |
| TravT__ | https://etherpad.openstack.org/p/YVR-horizon-liberty-priorities | 20:17 |
| *** stevemar has quit IRC | 20:18 | |
| TravT__ | so, right around march of 2019... | 20:18 |
| ekarlso | that much huh.. | 20:18 |
| TravT__ | no | 20:18 |
| david-lyle | there tqtran, I hope you're happy | 20:18 |
| david-lyle | :P | 20:18 |
| TravT__ | tqtran has some pretty sweet job security | 20:19 |
| tqtran | lol | 20:19 |
| tqtran | job security woooot | 20:19 |
| tqtran | let me go tell my boss | 20:19 |
| TravT__ | i wonder how long one could make a career of a single horizon panel | 20:20 |
| *** Viswanath has quit IRC | 20:20 | |
| tqtran | march 2019 | 20:20 |
| tqtran | then i need to start a new gig | 20:20 |
| TravT__ | that was a very much needed laugh... | 20:21 |
| *** tyr_ has quit IRC | 20:21 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 20:22 |
| *** amotoki has quit IRC | 20:22 | |
| *** cardeois________ has quit IRC | 20:22 | |
| *** Sukhdev has quit IRC | 20:22 | |
| *** cardeois has joined #openstack-horizon | 20:25 | |
| *** dguerri`away is now known as dguerri | 20:26 | |
| *** bradjones_away has quit IRC | 20:26 | |
| *** dguerri is now known as dguerri` | 20:29 | |
| *** bradjones has joined #openstack-horizon | 20:32 | |
| *** julim has quit IRC | 20:32 | |
| *** jbell8 has quit IRC | 20:33 | |
| *** jbell8 has joined #openstack-horizon | 20:33 | |
| *** cardeois_ has joined #openstack-horizon | 20:34 | |
| openstackgerrit | Merged openstack/horizon: Prevent multiple form submission on table row actions https://review.openstack.org/187604 | 20:35 |
| *** ybathia has joined #openstack-horizon | 20:36 | |
| *** cardeois has quit IRC | 20:37 | |
| *** lblanchard has quit IRC | 20:37 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 20:38 |
| *** peristeri has quit IRC | 20:42 | |
| *** Viswanath has joined #openstack-horizon | 20:44 | |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: [WIP] Flavor tests - use a digest cycle to test watches https://review.openstack.org/188587 | 20:45 |
| *** tyr_ has joined #openstack-horizon | 20:45 | |
| *** Viswanath has quit IRC | 20:47 | |
| *** tyr__ has joined #openstack-horizon | 20:56 | |
| *** tyr_ has quit IRC | 20:56 | |
| openstackgerrit | Merged openstack/horizon: Fixing up how job configs are handled https://review.openstack.org/187280 | 20:59 |
| *** matt-borland has quit IRC | 20:59 | |
| esp | david-lyle lhcheng doug-fish if you have time Presenter: https://www.myroom.hp.com/attend/MEH4M23AQQA | 21:00 |
| esp | or anyone else interest in domain support | 21:00 |
| *** iamjarvo has quit IRC | 21:01 | |
| *** raildo has quit IRC | 21:01 | |
| *** operator99 is now known as gyee | 21:02 | |
| *** nlahouti has quit IRC | 21:02 | |
| *** crobertsrh is now known as _crobertsrh | 21:03 | |
| *** e0ne has quit IRC | 21:05 | |
| openstackgerrit | Merged openstack/horizon: Adding John Papa style guide to JSCS https://review.openstack.org/185725 | 21:05 |
| TravT__ | ^ woot! | 21:06 |
| *** nlahouti has joined #openstack-horizon | 21:06 | |
| david-lyle | woot!, | 21:06 |
| *** svasheka has joined #openstack-horizon | 21:06 | |
| * david-lyle makes subtle joke of defiance | 21:07 | |
| TravT__ | took me a second | 21:07 |
| TravT__ | "disallowTrailingComma": true, | 21:07 |
| * david-lyle just happy to help | 21:08 | |
| *** notmars has quit IRC | 21:09 | |
| *** petertr7 is now known as petertr7_away | 21:09 | |
| *** notmars has joined #openstack-horizon | 21:10 | |
| *** vahidh_ has joined #openstack-horizon | 21:10 | |
| *** vahidh has quit IRC | 21:11 | |
| *** vahidh_ is now known as vahidh | 21:11 | |
| tqtran | haha yeah, not exactly clear | 21:14 |
| tqtran | gosh, these test patches are soooo exciting | 21:16 |
| tqtran | sqchen, TravT_: https://review.openstack.org/#/c/167738/29/openstack_dashboard/static/dashboard/launch-instance/launch-instance.model.spec.js | 21:19 |
| tqtran | I understand the need to provide a reusable mocked hz.api.x | 21:20 |
| tqtran | should we move those $provide.value out into a hz.api.mock or something? | 21:21 |
| sqchen | Yes, I am planning to create such a mock, but haven’t started yet. | 21:21 |
| tqtran | can you quickly ask around hp if there are other places where we are mocking hz.api.x? | 21:22 |
| tqtran | i haven't look at all of the test patches yet, but if its getting mocked in various test files, might be best to introduce a mock api now | 21:23 |
| *** kztsv_mbp has joined #openstack-horizon | 21:23 | |
| sqchen | ok. I think most Matt Borland is creating some ‘local mock’, I can confirm. | 21:23 |
| sqchen | Yes, I agree. | 21:23 |
| *** kztsv_mbp has left #openstack-horizon | 21:24 | |
| tqtran | ok yeah, please confirm, if that is the case, lets get that patch in asap | 21:24 |
| *** nlahouti has quit IRC | 21:24 | |
| TravT__ | tqtran i did talk with Matt about that a few weeks ago. | 21:25 |
| sqchen | k. Matt is offline now. I will ask once he get back. | 21:25 |
| TravT__ | he wanted to just push this through now. | 21:25 |
| *** notmars has quit IRC | 21:25 | |
| TravT__ | i like having some common mock | 21:26 |
| TravT__ | he did talk about having some preference to having the data inline with the tests | 21:26 |
| *** jbell8 has quit IRC | 21:27 | |
| tqtran | i prefer to see a common mock first | 21:27 |
| *** Raildo has joined #openstack-horizon | 21:27 | |
| *** nlahouti has joined #openstack-horizon | 21:27 | |
| tqtran | almost 200 lines of the launch-instance.modal.spec.js is on mocking common api | 21:27 |
| tqtran | thats almost half of the file | 21:27 |
| sqchen | I talked to David, he want a common mick as well. | 21:27 |
| TravT__ | which would be nice to reuse | 21:28 |
| tqtran | right | 21:28 |
| tqtran | it shouldnt be too bad, just copy/paste that code over and create a mock module | 21:28 |
| sqchen | Agree. TravT | 21:28 |
| tqtran | lets make that a focus, i'll try and review other patches with less mock in it | 21:28 |
| sqchen | sure. | 21:29 |
| *** Raildo_ has joined #openstack-horizon | 21:29 | |
| TravT__ | in thinking about this. | 21:29 |
| *** Raildo__ has joined #openstack-horizon | 21:29 | |
| TravT__ | it would actually be nice to not have A common mock | 21:29 |
| *** Raildo__ has quit IRC | 21:30 | |
| TravT__ | but rather each API has a mock sitting next to it | 21:30 |
| TravT__ | just like the spec file | 21:30 |
| tqtran | yeah, like hz.api.keystone.mock.js | 21:30 |
| tqtran | not hz.api.mock.js | 21:30 |
| TravT__ | yes | 21:30 |
| TravT__ | although | 21:31 |
| TravT__ | i'm not sure i'd do it just like this | 21:32 |
| TravT__ | he and i had a discussion about this patch vs injecting $httpBacken | 21:32 |
| *** Raildo has quit IRC | 21:33 | |
| *** asahlin is now known as asahlin_away | 21:33 | |
| tqtran | couldnt you use httpbacakend in the hz.api.keystone.mock.js? | 21:33 |
| *** mpavlase has quit IRC | 21:33 | |
| *** Raildo_ has quit IRC | 21:34 | |
| TravT__ | yes, but I'm comparing this particular patch (model test) | 21:34 |
| TravT__ | the mocks in this one are just value mocks | 21:34 |
| tqtran | yeah basically | 21:34 |
| TravT__ | vs injecting $httpBackend and setting the returned data based on the inputs. | 21:35 |
| TravT__ | a mock library that sits next to each API shouldn't just be writing its own version of the functions. | 21:36 |
| tqtran | let me take a look at httpbackend, need to know more before i can give feedback | 21:36 |
| TravT__ | here, i have some usage in my features patch | 21:36 |
| TravT__ | maybe not as pretty looking | 21:37 |
| TravT__ | https://review.openstack.org/#/c/179545/14/horizon/static/horizon/js/angular/services/hz.api.features.spec.js | 21:37 |
| TravT__ | but see line 41 | 21:37 |
| *** mattfarina has quit IRC | 21:37 | |
| *** mattfarina has joined #openstack-horizon | 21:38 | |
| tqtran | let me get back to you in like 30m, on a call | 21:38 |
| TravT__ | what that one does is inject the real API. | 21:39 |
| *** notmars has joined #openstack-horizon | 21:41 | |
| *** TravT has joined #openstack-horizon | 21:41 | |
| *** TravT__ has quit IRC | 21:43 | |
| r1chardj0n3s | morning | 21:45 |
| TravT | morning | 21:45 |
| *** nlahouti has quit IRC | 21:45 | |
| * r1chardj0n3s catches up on so many patches :) | 21:46 | |
| *** nlahouti has joined #openstack-horizon | 21:46 | |
| openstackgerrit | Travis Tripp proposed openstack/horizon: [Launch Instance Fix] Add Model Unit Tests https://review.openstack.org/167738 | 21:47 |
| *** doug-fish has left #openstack-horizon | 21:49 | |
| *** tyr__ has quit IRC | 21:49 | |
| *** tyr_ has joined #openstack-horizon | 21:50 | |
| *** tyr__ has joined #openstack-horizon | 21:51 | |
| *** tyr_ has quit IRC | 21:51 | |
| *** tyr_ has joined #openstack-horizon | 21:53 | |
| *** tyr__ has quit IRC | 21:53 | |
| *** mattfarina has quit IRC | 21:54 | |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 21:55 |
| r1chardj0n3s | krotscheck: https://review.openstack.org/#/c/188225 so ... having npm's package.json run some Python code to potentially import xstatic (or use hard-coded system packager info) to discover the JS library locations ... \o/ | 21:56 |
| r1chardj0n3s | krotscheck: this is not going to end well :) | 21:56 |
| krotscheck | r1chardj0n3s: Iiiiiiii know. | 21:56 |
| r1chardj0n3s | but I can see the need to run the test suite when in the system-packaged environment | 21:56 |
| *** svasheka has quit IRC | 21:56 | |
| r1chardj0n3s | krotscheck: srsly, you might want to run away screaming for a Real Web Application any time now ;) | 21:57 |
| krotscheck | r1chardj0n3s: I don't understand. I'm advocating Real Web Applications ;) | 21:57 |
| r1chardj0n3s | yeah, but we aren't one | 21:57 |
| krotscheck | r1chardj0n3s: What are _you_ advocating. Django? | 21:57 |
| krotscheck | Oh. | 21:57 |
| r1chardj0n3s | nope | 21:57 |
| r1chardj0n3s | but | 21:57 |
| krotscheck | But we can dream! | 21:57 |
| *** iamjarvo has joined #openstack-horizon | 21:58 | |
| *** iamjarvo has quit IRC | 21:58 | |
| r1chardj0n3s | in our application the location of the js libs is so variable, and defined in one case (hai xstatic!) in Python code | 21:58 |
| r1chardj0n3s | we can hack to work around that (you have, by hard-coding the different venv locations) | 21:58 |
| krotscheck | r1chardj0n3s: Want to come work for HP on Real Web Applications full time? :D | 21:58 |
| *** iamjarvo has joined #openstack-horizon | 21:58 | |
| r1chardj0n3s | but if that location changes to a system location, then it's also configued in Python code :/ | 21:58 |
| *** iamjarvo has quit IRC | 21:58 | |
| krotscheck | Yes, and it's all configured in a script that is deprecated. | 21:59 |
| r1chardj0n3s | krotscheck: haha, thanks but for now this is an interesting challenge :) | 21:59 |
| r1chardj0n3s | you talking about run_tests? no, I was talking about django settings.py | 21:59 |
| *** iamjarvo has joined #openstack-horizon | 21:59 | |
| r1chardj0n3s | (well, static_settings.py) | 21:59 |
| krotscheck | Ah, gotcha. | 21:59 |
| r1chardj0n3s | so | 21:59 |
| r1chardj0n3s | wacky ideas time | 21:59 |
| r1chardj0n3s | how about we configure the paths in a Jason file that knows about how to say "oh, this is actually an xstatic package name, you should __import__ it" or "this is actually a real, bonafide directory name" or "hey, look, we *finally got there* just look in bower" :) | 22:00 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix bug where WEBROOT is not respected https://review.openstack.org/181095 | 22:00 |
| * jrist grumbles at json vs. jason | 22:00 | |
| r1chardj0n3s | so then static_settings et. al can load up that Jason and ask him where to find the files | 22:00 |
| r1chardj0n3s | and so can packages Jason | 22:00 |
| r1chardj0n3s | jrist: ;) | 22:01 |
| TravT | krotscheck r1chardj0n3s FYI that I just found a commit earlier today broke our karma tests | 22:01 |
| r1chardj0n3s | TravT: ya>? | 22:01 |
| TravT | https://review.openstack.org/#/c/169976/ | 22:01 |
| TravT | it got in | 22:01 |
| TravT | and since selenium isn't working right and we don't have karma working and voting | 22:02 |
| r1chardj0n3s | we so need karma in the gate :/ | 22:02 |
| openstackgerrit | Merged openstack/horizon: Updated from global requirements https://review.openstack.org/188474 | 22:02 |
| r1chardj0n3s | pity mrunge isn't here | 22:02 |
| r1chardj0n3s | could we push for the solution krotscheck has proposed with a tech debt fixup to get it working elsewhere | 22:02 |
| TravT | it would prevent other tech debt. | 22:02 |
| r1chardj0n3s | yeah | 22:02 |
| r1chardj0n3s | precisely | 22:03 |
| krotscheck | r1chardj0n3s: We should definitely package jason. | 22:03 |
| jrist | gonna have to be a big box, I'm 6'5" | 22:03 |
| krotscheck | As long as he's OSI compliant. | 22:03 |
| r1chardj0n3s | we'll find a smaller Jason. they're all over these days | 22:03 |
| jrist | crikey | 22:03 |
| krotscheck | jrist, are all your dependencies available in upstream distros? | 22:03 |
| jrist | mroe or less :( | 22:04 |
| * krotscheck checks to see if debian packages coffee | 22:04 | |
| krotscheck | :D | 22:04 |
| *** svasheka has joined #openstack-horizon | 22:04 | |
| * r1chardj0n3s grabs some breakfast | 22:04 | |
| *** cardeois_ has quit IRC | 22:04 | |
| jrist | :) | 22:04 |
| jrist | r1chardj0n3s: breakfast? | 22:04 |
| jrist | must be a kiwi or an aussie | 22:04 |
| *** dboik has quit IRC | 22:05 | |
| *** stevemar has joined #openstack-horizon | 22:05 | |
| *** amotoki has joined #openstack-horizon | 22:06 | |
| r1chardj0n3s | ohai jrist | 22:07 |
| r1chardj0n3s | er | 22:07 |
| r1chardj0n3s | g'day jason maaaaaaate | 22:07 |
| TravT | krotscheck: r1chardj0n3s: mrunge: just read the comments from mrunge. They make sense. but seem like could be followed on, especially since run tests.sh -k is still available. | 22:07 |
| *** svasheka has quit IRC | 22:08 | |
| TravT | krotschek | 22:08 |
| *** svasheka has joined #openstack-horizon | 22:08 | |
| TravT | krotscheck: since the gate job is now in | 22:09 |
| krotscheck | Hrm, I wonder if I recheck my patch, will the job pass? | 22:09 |
| TravT | if you could "touch" that patch to make it run | 22:09 |
| * krotscheck goes off to test that. | 22:09 | |
| krotscheck | Ok, rechecking. Let's see what happens. | 22:10 |
| TravT | ah, i though zuul would ignore recheck if everything already passed (which I guess it didn't anyway due to that test we all ignore) | 22:11 |
| *** amotoki has quit IRC | 22:11 | |
| krotscheck | I'm ok landing the patch, as long as there's an aggreed-upon followup and someone who accepts responsibility to implement it. | 22:11 |
| r1chardj0n3s | you touched it last :) | 22:12 |
| krotscheck | :-P | 22:12 |
| krotscheck | Yeah, but I'm totally content letting the packagers complain :D | 22:12 |
| TravT | you could at least add the /usr that mrunge asked for | 22:12 |
| krotscheck | Right, so it'd create a venv, but then not use it. | 22:12 |
| krotscheck | I can see that. | 22:13 |
| krotscheck | r1chardj0n3s: Any disagreements with my comments on the karma-cli patch? | 22:13 |
| r1chardj0n3s | nope! | 22:13 |
| r1chardj0n3s | I thought I'd already +1'd - lemme check | 22:13 |
| *** notmars has quit IRC | 22:14 | |
| krotscheck | r1chardj0n3s: You -1'd it :) | 22:14 |
| r1chardj0n3s | yeah, that was so yesterday though | 22:14 |
| *** vijendar has quit IRC | 22:15 | |
| krotscheck | So, before I add this /usr patch, is taht actually going to work? Does centos install these things in /usr/lib/python2.7/site-packages/xstatic/pkg/ ? | 22:15 |
| krotscheck | And where does debian put those things? | 22:15 |
| *** clu_ has quit IRC | 22:16 | |
| r1chardj0n3s | um, they don't use xstatic | 22:16 |
| krotscheck | Yet more things I don't know! | 22:16 |
| r1chardj0n3s | the js libs are in their own packages under /usr/share/something IIRC | 22:16 |
| krotscheck | ...so why again does xstatic exist? If the packagers don't use it.... | 22:17 |
| r1chardj0n3s | zigo might be able to enlighten here | 22:17 |
| *** flwang has joined #openstack-horizon | 22:17 | |
| r1chardj0n3s | krotscheck: I KNOW RIGHT | 22:17 |
| *** sjmc7 has quit IRC | 22:17 | |
| zigo | r1chardj0n3s: I'm around, how may I help? | 22:17 |
| flwang | hi guys, anybody know a good way to profile horizon? | 22:17 |
| r1chardj0n3s | I'm pretty sure the #1 reason for xstatic is to discourage us from using 3rd party libs | 22:17 |
| krotscheck | r1chardj0n3s: Look at all the special snowflakes! | 22:17 |
| flwang | now we're running into a performance problem on the instance panel | 22:18 |
| r1chardj0n3s | zigo: krotscheck has some questions about deb packaging of js libs | 22:18 |
| krotscheck | zigo: Well sortof. | 22:18 |
| r1chardj0n3s | scrollback about 10 lines | 22:18 |
| zigo | krotscheck: Go ahead ! | 22:18 |
| *** iamjarvo has quit IRC | 22:18 | |
| flwang | but seems the cli works fine | 22:18 |
| krotscheck | zigo: Right now, the karma.conf file has the path to the libraries it includes hardcoded to the .venv path. | 22:18 |
| krotscheck | We want to fix this. | 22:18 |
| zigo | Good idea ! :) | 22:18 |
| flwang | so i'm wondering if there is any other hidden api call in instance panel cause any problem | 22:18 |
| flwang | need help, thanks | 22:19 |
| krotscheck | zigo: Right! And we can autodetect where things for karma are installed. | 22:19 |
| krotscheck | zigo: The question is: Where are they installed? | 22:19 |
| zigo | krotscheck: All the libjs files? | 22:19 |
| zigo | krotscheck: Unfortunately, I can only say "somewhere in /usr/share/javascript". | 22:19 |
| krotscheck | zigo: The relevant code patch is here: https://review.openstack.org/#/c/188225/2/horizon/karma.conf.js | 22:19 |
| krotscheck | zigo: And that was built from the original code, which as you can see goes directly to the venv. | 22:20 |
| zigo | krotscheck: What is karma? | 22:20 |
| zigo | I think I miss some context here. | 22:20 |
| krotscheck | So, any advice you have on how I can teach those unit tests on where to look is good. | 22:20 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix failed wizard tests https://review.openstack.org/188612 | 22:20 |
| krotscheck | zigo: Test runner for javascript things. Not required for packaging, but useful for making sure the JS things don't break with debian libraries. | 22:21 |
| krotscheck | It's loosely grouped under "dev tools" | 22:21 |
| krotscheck | But frankly, if we can make it pull in debian deps instead of bower deps, that's _awesome_, because it gets us closer to what you were asking for at the summit. | 22:21 |
| zigo | krotscheck: Well, we do run unit tests when building packages, so I may need it too. | 22:21 |
| zigo | krotscheck: Normally, each and every python-xstatic has the path to the javascrpit files. | 22:22 |
| krotscheck | zigo: Right. Baby steps :) | 22:22 |
| zigo | krotscheck: We're still talking about xstatic stuff, right? | 22:23 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix failed wizard tests https://review.openstack.org/188612 | 22:23 |
| krotscheck | zigo: yes. | 22:23 |
| krotscheck | zigo: If you expand the common lines at the end of that review, you can see all the dependencies being explicitly included. | 22:23 |
| zigo | krotscheck: Then nearly all python-xstatic-* packages in Debian include some patches for the BASE_DIR directive. | 22:23 |
| zigo | krotscheck: So that it gets the libjs-* files instead of what is normally embedded in the xstatic package. | 22:24 |
| zigo | So just use that ... | 22:24 |
| openstackgerrit | Shaoquan Chen proposed openstack/horizon: Fix failed wizard tests https://review.openstack.org/188612 | 22:25 |
| zigo | krotscheck: For example: BASE_DIR = '/usr/share/javascript/d3' (in python-xstatic-d3) | 22:25 |
| krotscheck | I think I'm missing quite a bit of domain specific knowledge, because what you just said makes very little sense to me. Would you mind going into more detail? | 22:25 |
| zigo | Then the data folder of the xstatic packages are just removed. | 22:25 |
| krotscheck | Or, helping me teach this config file on how to discover the existence of its packages? | 22:25 |
| *** jrist has quit IRC | 22:26 | |
| * krotscheck is very goal oriented. | 22:26 | |
| *** radez has quit IRC | 22:26 | |
| zigo | krotscheck: Read this patch: http://anonscm.debian.org/cgit/openstack/python-xstatic-spin.git/tree/debian/patches/debianize.patch | 22:26 |
| *** svasheka has quit IRC | 22:26 | |
| zigo | krotscheck: What you should use is the BASE_DIR variable within xstatic/pkg/spin/__init__.py | 22:27 |
| *** tyr_ has quit IRC | 22:27 | |
| *** tyr_ has joined #openstack-horizon | 22:27 | |
| sqchen | TravT: I like your idea about mock. we can have x.mock.js for each x.js which need a mock. and have them sit in the same folder. | 22:28 |
| krotscheck | zigo: Assume I am not allowed to invoke anything python | 22:28 |
| krotscheck | I get where you're going with this though. | 22:28 |
| TravT | sqchen, i was just going to try that out with an API here. | 22:28 |
| *** ducttape_ has quit IRC | 22:28 | |
| TravT | sqchen: i think it should be $httpbackend based and not some value mock though | 22:28 |
| TravT | the value mock seems like it bypasses too much. | 22:29 |
| *** Sukhdev has joined #openstack-horizon | 22:29 | |
| TravT | and makes the tests less valuable. | 22:29 |
| sqchen | Ok, I was thinking to start. will leave it to you. :) | 22:29 |
| TravT | well, we could work together on one. I was just going to put up an example of what I mean. | 22:29 |
| zigo | krotscheck: If you're not able to do anything python when running your .js stuff, then prepare a .js with the path using Python. | 22:30 |
| *** radez has joined #openstack-horizon | 22:30 | |
| *** rwsu has quit IRC | 22:30 | |
| zigo | krotscheck: Are you using node.js? | 22:31 |
| zigo | Karma is a node thing, right? | 22:31 |
| krotscheck | zigo: Yep. | 22:31 |
| sqchen | TravT: Cool, I will wait and have patch on it. | 22:31 |
| flwang | any body know who should I to talk about the performance issue about horizon? | 22:31 |
| flwang | thanks in advance | 22:31 |
| zigo | krotscheck: Then yeah, before running karma, write a tiny Python script that will extract the BASE_DIR stuff for every xstatic package, and build a .js file to give karma to eat. | 22:31 |
| r1chardj0n3s | ah, so the xstatic packages are retained, they just point to a different place. sorry for that red herring krotscheck! | 22:32 |
| krotscheck | RIghto. | 22:33 |
| r1chardj0n3s | if that's the same in rpm land then we're good to go with zigo's approach | 22:33 |
| flwang | or any suggestion how to debug the performance issue for specific page of horizon? thanks | 22:33 |
| krotscheck | r1chardj0n3s: Right, if we can invoke that in a pretest hook, that may even remove the need for that venv build. | 22:33 |
| *** jrist has joined #openstack-horizon | 22:34 | |
| r1chardj0n3s | krotscheck: with the tweak that you can look to see if they're installed, and if the xstatic import fails you'll need to do the venv bootstrapping via tox | 22:34 |
| TravT | flwang: a guy mattfarina has looked into that a bit | 22:34 |
| r1chardj0n3s | krotscheck: yeah, avoiding the build *in that situation* :) | 22:34 |
| TravT | but he's not around | 22:34 |
| krotscheck | Good lord what a hack. | 22:34 |
| r1chardj0n3s | \o/ | 22:34 |
| *** csd has quit IRC | 22:34 | |
| TravT | flwang: what perf issues are you talking about? | 22:34 |
| flwang | TravT: thanks, i even think i'm in a wrong channel without any horizon guy | 22:34 |
| *** tyr_ has quit IRC | 22:34 | |
| *** dontalton has quit IRC | 22:35 | |
| *** tyr_ has joined #openstack-horizon | 22:35 | |
| *** tyr_ has quit IRC | 22:35 | |
| *** csd has joined #openstack-horizon | 22:35 | |
| flwang | TravT: yesterday, we found the instance panel of Project is very slow, but seems the cli works fine | 22:35 |
| *** tyr_ has joined #openstack-horizon | 22:35 | |
| flwang | so i'm wondering how you guys debug the similar thing | 22:35 |
| TravT | well, i know we've put timers in various function calls with LOGGING. | 22:36 |
| krotscheck | flwang: I normally start with chrome's debugging tools, specifically the network panel. I've found that at least 1/2 of the load time for any page in horizon is because of poor caching of static assets. | 22:36 |
| krotscheck | For instance, HP's public cloud horizon downloads 1.5MB of javascript on every page load. | 22:37 |
| TravT | krotscheck: agreed... i show some of that in the searchlight video | 22:37 |
| david-lyle | flwang: it makes a ton of API calls | 22:37 |
| david-lyle | the instances panel | 22:37 |
| david-lyle | 6 API calls | 22:37 |
| *** iamjarvo has joined #openstack-horizon | 22:37 | |
| david-lyle | to piece together all that information | 22:37 |
| TravT | they are also seqential | 22:37 |
| *** iamjarvo has quit IRC | 22:38 | |
| TravT | sequential. | 22:38 |
| david-lyle | the server list on the CLI will be much more effiicient | 22:38 |
| david-lyle | 1 vs 6 | 22:38 |
| *** iamjarvo has joined #openstack-horizon | 22:38 | |
| flwang | yep, i guess it maybe the cause, any workaournd? | 22:39 |
| TravT | don't use it... :P | 22:39 |
| flwang | TravT: you're so smart | 22:39 |
| david-lyle | if you don't care about names instead of IDs, you can get rid of those calls | 22:40 |
| *** mwhagedorn has quit IRC | 22:40 | |
| flwang | actually, we're running public cloud :( | 22:41 |
| TravT | https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/views.py#L64 | 22:41 |
| flwang | TravT: yep, i think it deserves a refactor | 22:43 |
| TravT | so flwang: we are hoping to angularize that table during liberty | 22:43 |
| david-lyle | flwang: well if we can get our house keeping done, we actually have a plan to address that | 22:43 |
| david-lyle | but we like to bicker about tests and other things more | 22:44 |
| TravT | yeah, we enjoy that | 22:44 |
| TravT | flwang: see this: https://youtu.be/eGnGr48E5_4 | 22:44 |
| TravT | this is what i demo'd at the summit | 22:44 |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move utils from dashboad-app https://review.openstack.org/185140 | 22:44 |
| david-lyle | we're about to regain our focus though | 22:45 |
| TravT | david-lyle: we're only a couple tests away | 22:45 |
| flwang | TravT: yep, I even remembered your great work in glance image search in Paris summit :) | 22:45 |
| TravT | :) | 22:46 |
| david-lyle | TravT: does demo nicely | 22:46 |
| TravT | helps when I have people like ongk and sjmc7 | 22:46 |
| *** iamjarvo has quit IRC | 22:47 | |
| flwang | so | 22:47 |
| flwang | do we have a plan for the performance improving? especially for the instance page | 22:47 |
| *** iamjarvo has joined #openstack-horizon | 22:47 | |
| TravT | 1) technical debt of kilo for angular | 22:48 |
| TravT | 2) get indentity user's table fully angular to set example | 22:48 |
| TravT | 3) replicate that work on other tables | 22:49 |
| TravT | we also did a summit presentation main summit, where we talk about that. | 22:49 |
| TravT | let me dig that up | 22:49 |
| TravT | https://www.openstack.org/summit/vancouver-2015/summit-videos/presentation/beyond-the-horizon-innovating-and-customizing-horizon-using-angularjs | 22:50 |
| *** mwhagedorn has joined #openstack-horizon | 22:52 | |
| flwang | cool, so we don't think the problem is about those api calls, but the way to handle those tables? | 22:52 |
| TravT | i think there is a combination of problems | 22:53 |
| david-lyle | flwang: oh, the API calls are slow, but we can make them async with the new design | 22:53 |
| openstackgerrit | Tyr Johanson proposed openstack/horizon: [WIP] Flavor tests - use a digest cycle to test watches https://review.openstack.org/188587 | 22:53 |
| david-lyle | plus django has a bad habit of reloading all of it if it sees its own shadow | 22:53 |
| flwang | david-lyle: yep | 22:53 |
| flwang | so, so let me ask if we found each api call works fine, then how to work around current problem on the Icehouse release? | 22:54 |
| david-lyle | so async data loading, with a larger client side cache of data, and less reloads once there | 22:54 |
| *** clu_ has joined #openstack-horizon | 22:54 | |
| TravT | optimize that function i gave you a link to | 22:56 |
| TravT | compress | 22:56 |
| *** tyr_ has quit IRC | 22:56 | |
| TravT | delete data from your database | 22:57 |
| flwang | TravT: you mean this link https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/instances/views.py#L64 ? | 22:57 |
| TravT | ^ joke | 22:57 |
| flwang | does it need a bp or i can just create a enhancement bug to address that if i can figure out a way to improve it? | 22:57 |
| TravT | yeah, you could try parallelize within there and sub calls | 22:57 |
| *** ongk has quit IRC | 22:58 | |
| TravT | to backport all the way to iceshouse? | 22:58 |
| *** clu_ has quit IRC | 22:59 | |
| TravT | this is a david-lyle kind of question i think... | 22:59 |
| flwang | david-lyle: is this kind of backport workable in Horizon? | 22:59 |
| flwang | TravT: right :) | 22:59 |
| TravT | i know he had somewhere to go, so he might have had to leave | 23:00 |
| TravT | i also have to drop in a seocnd | 23:00 |
| TravT | sqchen: i've got company coming over shortly. will be tomorrow before i start on that api mock. if you want to start. all i was thinking is this | 23:01 |
| TravT | i'd rather that our mocks don't redefine the API functions | 23:01 |
| TravT | if we do that, we have less chance to catch dependency issues if we change the API | 23:02 |
| TravT | matt-borland was thinking that the value mocks gave more isolation to the unit test... | 23:02 |
| *** packet has joined #openstack-horizon | 23:02 | |
| flwang | TravT: ok, thanks | 23:02 |
| TravT | flwang, sure | 23:03 |
| flwang | I will catch up with him later | 23:03 |
| TravT | hope it helped | 23:03 |
| flwang | TravT: thanks a lot | 23:03 |
| *** TravT_ has quit IRC | 23:06 | |
| openstackgerrit | Kahou Lei proposed openstack/horizon: Admin network form should enable port_security_enabled flag https://review.openstack.org/188625 | 23:08 |
| *** TravT_ has joined #openstack-horizon | 23:16 | |
| *** TravT has quit IRC | 23:18 | |
| *** packet has quit IRC | 23:19 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move dashboard-app/login out https://review.openstack.org/185133 | 23:24 |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move dashboard controllers from horizon https://review.openstack.org/185132 | 23:26 |
| *** chlong has joined #openstack-horizon | 23:27 | |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move core HTML from framework to dashboard https://review.openstack.org/186295 | 23:27 |
| *** yamamoto has joined #openstack-horizon | 23:28 | |
| *** Desh_Shukla has joined #openstack-horizon | 23:30 | |
| r1chardj0n3s | hm, my IRC disconnected for a while there :/ | 23:30 |
| *** zhenguo has joined #openstack-horizon | 23:30 | |
| r1chardj0n3s | that's the reorg patch chain back in non-merge-conflict :) | 23:30 |
| r1chardj0n3s | krotscheck: are you all good on the karma conf thing? | 23:31 |
| r1chardj0n3s | for a value of "all good" which means "have a path forward"? :) | 23:31 |
| *** lhcheng has quit IRC | 23:32 | |
| *** lhcheng has joined #openstack-horizon | 23:36 | |
| *** bradjones has quit IRC | 23:36 | |
| krotscheck | r1chardj0n3s: There is a path forward, however it has not been vetted by everyone, and we don't have anyone who's volunteered to do the necessary work. | 23:37 |
| r1chardj0n3s | I know someone I could volunteer... ;) | 23:37 |
| krotscheck | r1chardj0n3s: Yourself? Awesome! | 23:38 |
| krotscheck | In that case, yes, we have a path forward, and a volunteer! :D | 23:38 |
| r1chardj0n3s | maybe an email, just to capture the thoughts, nut out the details before I volunteer you? :) | 23:38 |
| *** bradjones has joined #openstack-horizon | 23:39 | |
| krotscheck | TravT_, r1chardj0n3s: So, looks like thta first patch of mine failed, but it failed by actually bootstrapping successfully and having one of the karma unit tests fail. So I call that a win. | 23:40 |
| *** bpokorny has joined #openstack-horizon | 23:41 | |
| *** bpokorny_ has quit IRC | 23:41 | |
| *** jingjing_ren has quit IRC | 23:44 | |
| *** tqtran has quit IRC | 23:45 | |
| *** yamamoto has quit IRC | 23:51 | |
| *** yamamoto has joined #openstack-horizon | 23:53 | |
| r1chardj0n3s | krotscheck: \o/ (was it the wizard fail?) | 23:56 |
| krotscheck | r1chardj0n3s: Yep | 23:56 |
| krotscheck | wizard directive Broadcast Functions sets beforeSubmit to broadcast BEFORE_SUBMIT FAILED | 23:56 |
| r1chardj0n3s | yep, that should be fixed asap | 23:56 |
| krotscheck | Hey look, karma running in the gate! | 23:56 |
| krotscheck | CRAZYPANTS | 23:56 |
| openstackgerrit | Richard Jones proposed openstack/horizon: ngReorg - move dashboard-app to dashboard https://review.openstack.org/185191 | 23:57 |
| r1chardj0n3s | \o/ | 23:57 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!