| *** tosky has quit IRC | 00:09 | |
| spotz | ok patch coming with fixed svg and calling the svg, not removing the png file from the repo though | 00:14 |
|---|---|---|
| openstackgerrit | Amy Marrich (spotz) proposed openstack/openstack-manuals master: Cleaned up issues with network1-services.svg https://review.opendev.org/c/openstack/openstack-manuals/+/782341 | 00:17 |
| *** rcernin has quit IRC | 02:28 | |
| *** rcernin has joined #openstack-doc | 02:39 | |
| *** rcernin has quit IRC | 05:25 | |
| *** rcernin has joined #openstack-doc | 05:26 | |
| *** miloa has joined #openstack-doc | 07:34 | |
| *** rcernin has quit IRC | 07:46 | |
| *** miloa has quit IRC | 07:50 | |
| *** rcernin has joined #openstack-doc | 08:23 | |
| *** tosky has joined #openstack-doc | 09:04 | |
| *** tosky has quit IRC | 10:13 | |
| *** tosky has joined #openstack-doc | 10:14 | |
| *** rcernin has quit IRC | 10:46 | |
| *** yoctozepto has quit IRC | 11:02 | |
| *** yoctozepto has joined #openstack-doc | 11:03 | |
| *** rcernin has joined #openstack-doc | 11:09 | |
| *** rcernin has quit IRC | 11:17 | |
| *** rcernin has joined #openstack-doc | 11:18 | |
| *** rcernin has quit IRC | 11:25 | |
| pmatulis1 | johnsom, hi, taking you up on your offer to assist with pdf generation for my project. this is where i'm at: https://pastebin.ubuntu.com/p/yXYpHQXfJ4/ | 14:33 |
| johnsom | pmatulis1: I can help in 30 minutes | 14:34 |
| johnsom | Ok, looking | 15:00 |
| johnsom | pmatulis1 https://github.com/openstack/octavia/blob/master/bindep.txt | 15:02 |
| johnsom | You are going to need to update your bindep for some of the tools the PDF job requires | 15:02 |
| pmatulis1 | johnsom, ok, i'm not familiar with such a file | 15:04 |
| johnsom | It is how OpenStack signals that binary packages (deb or rpm) are required for a project. | 15:05 |
| johnsom | https://docs.opendev.org/opendev/bindep/latest/readme.html | 15:06 |
| johnsom | That page has some backgroup and details | 15:06 |
| pmatulis1 | interesting. your project has many. including one for 'svg2pdfconverter' that i have in requirements.txt. does it matter which i use (pip/python or deb/packages)? | 15:09 |
| johnsom | In the case of svg2pdfconverter (Only if your project has svg graphics files), the python package requires the binary in addition to run. | 15:11 |
| johnsom | Until the PDF need, we didn't have much of a binary requirement in Octavia, but the PDF rendering requires a bunch of latex dependencies. | 15:11 |
| pmatulis1 | hm, i don't have any svg files but i guess it's good to be ready | 15:12 |
| johnsom | Ok | 15:12 |
| pmatulis1 | johnsom, so for bindep.txt, would i start by just adding 'python3-sphinxcontrib-svg2pdfconverter-common [doc platform:dpkg]' ? | 15:20 |
| johnsom | I would copy the whole bindep "PDF" section from my bindep. Obviously for charms you may not need the RPM packages, but you are going to end up needing the other latex related packages. | 15:22 |
| johnsom | The PDF build process we put in place for OpenStack takes the RST converts it to Latex and then renders it to PDF | 15:23 |
| pmatulis1 | i see. i need to use the corresponding ubuntu/dpkg package names (not rpm)? | 15:23 |
| johnsom | https://www.irccloud.com/pastebin/LopmrIVM/ | 15:24 |
| johnsom | That is already handled there in the bindep. So, if you have an Ubuntu only project, that snippet would have the list you need in your bindep | 15:24 |
| johnsom | Or you can leave them all for future RPM support. Grin | 15:25 |
| johnsom | The platform tag is how it handles the different packaging. | 15:25 |
| pmatulis1 | i'll try it out | 15:30 |
| johnsom | +1, feel free to ping me again if you hit another issue. Also note, there are some changes we made in the conf.py as well, so you might compare with https://github.com/openstack/octavia/blob/master/doc/source/conf.py | 15:31 |
| pmatulis1 | got it, and thanks! | 15:32 |
| johnsom | No problem | 15:33 |
| *** frickler has quit IRC | 15:37 | |
| *** irclogbot_2 has quit IRC | 15:37 | |
| *** frickler has joined #openstack-doc | 15:37 | |
| *** irclogbot_2 has joined #openstack-doc | 15:38 | |
| *** irclogbot_2 has quit IRC | 15:51 | |
| *** irclogbot_0 has joined #openstack-doc | 15:52 | |
| pmatulis1 | johnsom, so no change in result: https://pastebin.ubuntu.com/p/7T4jgW4qt3/ - i tried adding that last line in requirements.txt but it didn't help | 15:52 |
| johnsom | pmatulis1 Did you run the bindep tool? "sudo apt-get install $(bindep -b)" ? | 15:54 |
| johnsom | The gate jobs will run that for you, but on a local dev box you need to run it to install the needed packages | 15:55 |
| pmatulis1 | no, i didn't do that | 16:02 |
| johnsom | That should install the packages in the list | 16:02 |
| pmatulis1 | need to look for the package that gives me bindep... | 16:03 |
| johnsom | pip if not in deb | 16:06 |
| pmatulis1 | got it but i don't get any output at all, even with 'bindep --file bindep.txt' | 16:10 |
| johnsom | Hmm, I would expect that to not return anything if they are already installed. Is "librsvg2-bin" installed? Does tox run now? | 16:13 |
| pmatulis1 | nope, no change | 16:16 |
| pmatulis1 | librsvg2-bin is not installed | 16:17 |
| johnsom | Hmm, well, maybe for now just install the packages in the list | 16:17 |
| pmatulis1 | in these two lines 1. why doesn't the first one have "platform" and 2. what is the "doc" keyword for? | 16:34 |
| pmatulis1 | make [doc] | 16:34 |
| pmatulis1 | fonts-freefont-otf [doc platform:dpkg] | 16:34 |
| johnsom | Oh, ha, forgot about the "doc" profile, that is why bindep isn't working. | 16:35 |
| pmatulis1 | d'oh | 16:35 |
| johnsom | So make only has "doc" as the package is the same across Ubuntu and RHEL. | 16:35 |
| johnsom | "sudo apt-get install $(bindep -b) doc" | 16:36 |
| pmatulis1 | ok, just 'librsvg2-bin' popped out | 16:36 |
| pmatulis1 | got a lot further but now 'tox' is stalled at a '?' mark. is that where the fun begins? | 16:40 |
| johnsom | maybe, lol. paste if it's not clear what is going on | 16:41 |
| pmatulis1 | https://pastebin.ubuntu.com/p/DtvnQztMVh/ | 16:42 |
| johnsom | Hmmm, I haven't seen that before | 16:44 |
| pmatulis1 | "badness" | 16:47 |
| johnsom | pmatulis1 Well, poke at it for a bit, if you get stuck, post a patch with your changes and I will pull it down and see if I can see why. | 16:48 |
| johnsom | pmatulis1 Just ping me with the link to the patch. | 16:49 |
| pmatulis1 | johnsom, thanks a lot for your help | 17:04 |
| johnsom | pmatulis1 Sure, no problem | 17:05 |
| openstackgerrit | Ghanshyam proposed openstack/contributor-guide master: Add Structural split of changes in best practices https://review.opendev.org/c/openstack/contributor-guide/+/782572 | 17:24 |
| *** pmatulis1 is now known as pmatulis | 17:57 | |
| openstackgerrit | Amy Marrich (spotz) proposed openstack/openstack-manuals master: Cleaned up issues with network1-services.svg https://review.opendev.org/c/openstack/openstack-manuals/+/782341 | 20:08 |
| spotz | fungi - FYI it doesn't look like the process to make docs into PDFs likes svg files. I went ahead and made a new png and the patch passed | 20:18 |
| fungi | yeah, there might be a solution for converting svg to (e)ps, since pdf is really just eps with adobe juice drizzled over it | 20:21 |
| fungi | it's unfortunate that the solution to getting a vector image into a larger vector file is to embed a rasterization | 20:21 |
| fungi | but i agree right now we already have a solution for embedding raster files in pdf, that's the quickest way | 20:22 |
| spotz | Yeah and it passed so we can get that fixed once merged | 20:35 |
| *** rcernin has joined #openstack-doc | 21:01 | |
| *** rcernin has quit IRC | 21:16 | |
| *** rcernin has joined #openstack-doc | 21:46 | |
| *** rcernin has quit IRC | 22:10 | |
| *** rcernin has joined #openstack-doc | 22:10 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!