| *** lennyb has joined #openstack-cinder | 00:02 | |
| *** ntpttr_laptop has quit IRC | 00:05 | |
| *** masber has joined #openstack-cinder | 00:12 | |
| *** wanghao has joined #openstack-cinder | 00:30 | |
| *** wanghao has quit IRC | 00:32 | |
| *** crushil_ has joined #openstack-cinder | 00:35 | |
| *** markvoelker has quit IRC | 00:36 | |
| *** xyang has joined #openstack-cinder | 00:37 | |
| *** xyang has quit IRC | 00:44 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 00:45 | |
| *** wanghao has joined #openstack-cinder | 00:46 | |
| *** AlexeyAbashkin has quit IRC | 00:50 | |
| *** psachin has joined #openstack-cinder | 00:54 | |
| *** yangyapeng has joined #openstack-cinder | 01:10 | |
| *** crushil_ has quit IRC | 01:18 | |
| *** r-daneel has quit IRC | 01:26 | |
| *** wanghao_ has joined #openstack-cinder | 01:27 | |
| *** wanghao has quit IRC | 01:31 | |
| *** oomichi_afk is now known as oomichi | 01:36 | |
| *** linkmark has quit IRC | 01:40 | |
| *** dalgaaf has quit IRC | 01:43 | |
| *** dalgaaf has joined #openstack-cinder | 01:44 | |
| *** sapd has joined #openstack-cinder | 01:45 | |
| *** sapd has quit IRC | 01:55 | |
| *** sapd has joined #openstack-cinder | 01:57 | |
| *** sticker has quit IRC | 01:58 | |
| *** korean101 has joined #openstack-cinder | 02:05 | |
| korean101 | HI guys | 02:05 |
|---|---|---|
| korean101 | cinder-volume can possible Active-Active HA? (in Newton Release + Ceph Backend) | 02:07 |
| tommylikehu | hey korean101 I guess no till now:) | 02:09 |
| *** masber has quit IRC | 02:10 | |
| korean101 | tommylikehu: guess? hmmm. thanks | 02:10 |
| korean101 | somebody tells me that in ceph backend can A/A HA | 02:10 |
| *** mriedem has quit IRC | 02:11 | |
| *** stvnoyes has quit IRC | 02:12 | |
| korean101 | https://blueprints.launchpad.net/cinder/+spec/cinder-volume-active-active-support | 02:12 |
| *** liverpooler has joined #openstack-cinder | 02:12 | |
| korean101 | HA A-A: Add cluster configuration option to allow grouping hosts that share the same backend configurations and should work in Active-Active fashion. (https://docs.openstack.org/releasenotes/cinder/newton.html#new-features) | 02:13 |
| korean101 | what's this?? | 02:13 |
| *** psachin has quit IRC | 02:16 | |
| *** wanghao_ has quit IRC | 02:17 | |
| *** wanghao has joined #openstack-cinder | 02:18 | |
| *** salv-orlando has joined #openstack-cinder | 02:28 | |
| *** stakeda has quit IRC | 02:28 | |
| *** stakeda has joined #openstack-cinder | 02:29 | |
| *** salv-orl_ has quit IRC | 02:31 | |
| *** zengyingzhe has quit IRC | 02:32 | |
| *** Apoorva has quit IRC | 02:34 | |
| *** markvoelker has joined #openstack-cinder | 02:37 | |
| *** markstur has quit IRC | 02:38 | |
| *** harlowja has joined #openstack-cinder | 02:41 | |
| *** harlowja has quit IRC | 02:42 | |
| *** harlowja has joined #openstack-cinder | 02:43 | |
| *** namnh has joined #openstack-cinder | 02:45 | |
| tommylikehu | korean101: that's part of the works we need to support HA | 02:45 |
| korean101 | tommylikehu: yes | 02:47 |
| korean101 | tommylikehu: you think not yet supprorted A/A in HA? | 02:48 |
| korean101 | tommylikehu: even Ceph RBD backend? | 02:48 |
| korean101 | (in newton releases) | 02:48 |
| tommylikehu | korean101: yea, I think so | 02:50 |
| *** psachin has joined #openstack-cinder | 02:50 | |
| *** moshele has quit IRC | 02:54 | |
| *** imran_ansari has joined #openstack-cinder | 02:54 | |
| *** crushil_ has joined #openstack-cinder | 03:05 | |
| *** markvoelker has quit IRC | 03:11 | |
| *** harlowja has quit IRC | 03:15 | |
| *** jappleii__ has joined #openstack-cinder | 03:17 | |
| *** jappleii__ has quit IRC | 03:19 | |
| *** jappleii__ has joined #openstack-cinder | 03:19 | |
| *** threestrands_ has quit IRC | 03:20 | |
| *** yangyapeng has quit IRC | 03:24 | |
| *** abhishekk has joined #openstack-cinder | 03:30 | |
| korean101 | tommylikehu: many thanks!!! | 03:31 |
| *** markstur has joined #openstack-cinder | 03:34 | |
| *** masber has joined #openstack-cinder | 03:38 | |
| *** ganso has quit IRC | 03:45 | |
| openstackgerrit | Neha Alhat proposed openstack/cinder master: V2/V3 jsonschema validation: snapshots https://review.openstack.org/520991 | 03:47 |
| *** armax has quit IRC | 03:47 | |
| *** r-daneel has joined #openstack-cinder | 03:52 | |
| *** liverpooler has quit IRC | 03:54 | |
| *** jappleii__ has quit IRC | 03:56 | |
| *** armax has joined #openstack-cinder | 04:05 | |
| *** r-daneel has quit IRC | 04:07 | |
| *** markvoelker has joined #openstack-cinder | 04:08 | |
| *** jmlowe_ has joined #openstack-cinder | 04:12 | |
| *** jmlowe has quit IRC | 04:14 | |
| *** rmcall has joined #openstack-cinder | 04:15 | |
| *** armax has quit IRC | 04:17 | |
| *** vivsoni_ has quit IRC | 04:24 | |
| *** adisky__ has joined #openstack-cinder | 04:27 | |
| *** chhavi has joined #openstack-cinder | 04:29 | |
| *** s-shiono has joined #openstack-cinder | 04:32 | |
| *** vivsoni has joined #openstack-cinder | 04:33 | |
| *** harlowja has joined #openstack-cinder | 04:36 | |
| *** markvoelker has quit IRC | 04:42 | |
| *** harlowja has quit IRC | 04:45 | |
| *** pgadiya has joined #openstack-cinder | 04:48 | |
| *** zhurong has joined #openstack-cinder | 04:56 | |
| *** kwathore__ has quit IRC | 05:10 | |
| *** kwathore has quit IRC | 05:10 | |
| *** markstur has quit IRC | 05:15 | |
| *** kwathore has joined #openstack-cinder | 05:18 | |
| *** kwathore__ has joined #openstack-cinder | 05:18 | |
| *** harlowja has joined #openstack-cinder | 05:21 | |
| *** harlowja has quit IRC | 05:22 | |
| *** harlowja has joined #openstack-cinder | 05:24 | |
| *** harlowja has quit IRC | 05:29 | |
| kwathore | @Team, Some one facing issue in attachment of lvm volume in Master setup, after attachment volume status become reserve and no specific entry found in /dev/disk/by-path | 05:32 |
| kwathore | is there any activity going around in attachment of a volume? | 05:32 |
| *** harlowja has joined #openstack-cinder | 05:38 | |
| *** markvoelker has joined #openstack-cinder | 05:39 | |
| openstackgerrit | Merged openstack/python-cinderclient master: Backup create is not available from 3.0 to 3.42 https://review.openstack.org/527568 | 05:42 |
| *** sapd_ has joined #openstack-cinder | 06:01 | |
| *** sapd has quit IRC | 06:01 | |
| *** sage__ has quit IRC | 06:08 | |
| *** sage__ has joined #openstack-cinder | 06:10 | |
| *** markvoelker has quit IRC | 06:11 | |
| *** links has joined #openstack-cinder | 06:18 | |
| *** wanghao_ has joined #openstack-cinder | 06:25 | |
| *** wanghao has quit IRC | 06:26 | |
| *** lpetrut has joined #openstack-cinder | 06:31 | |
| *** harlowja has quit IRC | 06:32 | |
| openstackgerrit | Brin Zhang proposed openstack/cinder master: add enough notification for QoS https://review.openstack.org/522482 | 06:34 |
| *** rcernin has quit IRC | 06:47 | |
| openstackgerrit | Niraj Singh proposed openstack/cinder master: Add service_token for cinder-nova interaction https://review.openstack.org/524497 | 06:51 |
| openstackgerrit | Niraj Singh proposed openstack/cinder master: Add service_token for cinder-glance interaction https://review.openstack.org/526611 | 06:51 |
| *** markvoelker has joined #openstack-cinder | 07:09 | |
| openstackgerrit | Chhavi Agarwal proposed openstack/cinder master: Run backup-restore operations on native thread https://review.openstack.org/518316 | 07:19 |
| openstackgerrit | Pooja Jadhav proposed openstack/cinder master: V3 jsonschema validation: Clusters https://review.openstack.org/528182 | 07:30 |
| *** moshele has joined #openstack-cinder | 07:32 | |
| *** lpetrut has quit IRC | 07:35 | |
| openstackgerrit | qtlu proposed openstack/cinder master: [WIP] RBD: get manageable volumes https://review.openstack.org/527903 | 07:40 |
| *** moshele has quit IRC | 07:42 | |
| *** markvoelker has quit IRC | 07:42 | |
| *** lpetrut has joined #openstack-cinder | 07:43 | |
| *** imran_ansari has quit IRC | 07:44 | |
| *** imran_ansari has joined #openstack-cinder | 07:44 | |
| openstackgerrit | Imran Ansari proposed openstack/cinder master: 3PAR - Fix temp snapshot that remains post online copy https://review.openstack.org/524185 | 07:46 |
| openstackgerrit | Imran Ansari proposed openstack/cinder master: 3PAR - Fix temp snapshot that remains post online copy https://review.openstack.org/524185 | 07:50 |
| *** armaan has joined #openstack-cinder | 07:54 | |
| *** zhurong has quit IRC | 07:54 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 07:59 | |
| *** lpetrut has quit IRC | 08:05 | |
| *** crushil_ has quit IRC | 08:10 | |
| *** lhx_ has joined #openstack-cinder | 08:20 | |
| *** amoralej|off is now known as amoralej | 08:21 | |
| *** armaan has quit IRC | 08:23 | |
| *** armaan_ has joined #openstack-cinder | 08:23 | |
| *** armaan_ has quit IRC | 08:24 | |
| *** armaan has joined #openstack-cinder | 08:24 | |
| *** s-shiono has quit IRC | 08:34 | |
| *** wanghao_ has quit IRC | 08:34 | |
| *** wanghao has joined #openstack-cinder | 08:34 | |
| *** wanghao_ has joined #openstack-cinder | 08:37 | |
| *** markvoelker has joined #openstack-cinder | 08:39 | |
| *** wanghao has quit IRC | 08:40 | |
| *** imran_ansari has quit IRC | 08:41 | |
| *** wanghao_ has quit IRC | 08:41 | |
| *** wanghao has joined #openstack-cinder | 08:41 | |
| *** wanghao_ has joined #openstack-cinder | 08:43 | |
| *** wanghao has quit IRC | 08:46 | |
| *** salv-orl_ has joined #openstack-cinder | 08:55 | |
| *** salv-orlando has quit IRC | 08:59 | |
| *** armaan has quit IRC | 09:04 | |
| *** armaan has joined #openstack-cinder | 09:05 | |
| *** imran_ansari has joined #openstack-cinder | 09:07 | |
| *** stakeda has quit IRC | 09:08 | |
| *** markvoelker has quit IRC | 09:13 | |
| *** lhx_ has quit IRC | 09:25 | |
| *** lhx_ has joined #openstack-cinder | 09:25 | |
| *** armaan has quit IRC | 09:28 | |
| *** armaan has joined #openstack-cinder | 09:28 | |
| *** wanghao_ has quit IRC | 09:30 | |
| *** lhx__ has joined #openstack-cinder | 09:32 | |
| *** lhx_ has quit IRC | 09:33 | |
| *** prateek_ has quit IRC | 09:40 | |
| *** e0ne has joined #openstack-cinder | 09:43 | |
| *** armaan_ has joined #openstack-cinder | 09:52 | |
| *** armaan has quit IRC | 09:52 | |
| swamireddy | hi | 09:55 |
| swamireddy | quick Q: volume_clear=0 is this option wipes old data and overwrite with '0' | 09:56 |
| swamireddy | for all types of volumes like lvm and ceph... | 09:56 |
| *** prateek has joined #openstack-cinder | 09:57 | |
| e0ne | swamireddy: it's only for lvm and maybe for nfs | 09:58 |
| *** lpetrut has joined #openstack-cinder | 09:58 | |
| *** pgadiya has quit IRC | 09:59 | |
| *** mvk has quit IRC | 09:59 | |
| swamireddy | e0ne: thanks...so it won't work with ceph volumes? is there way for ceph for the data wipe purpose? | 09:59 |
| *** pgadiya has joined #openstack-cinder | 10:04 | |
| *** armaan_ has quit IRC | 10:06 | |
| *** armaan has joined #openstack-cinder | 10:07 | |
| *** hoangcx has quit IRC | 10:10 | |
| *** markvoelker has joined #openstack-cinder | 10:10 | |
| e0ne | swamireddy: you don't need it for ceph | 10:12 |
| e0ne | swamireddy: ceph does it by itself | 10:12 |
| imran_ansari | e0ne: Regarding https://review.openstack.org/#/c/524185/6 - here I'm spawning a worker thread, that is responsible for tracking asynchronous task(s) running on the array | 10:13 |
| e0ne | imran_ansari: you have to refactor your code or tests (e.g. make tests more granular) | 10:13 |
| e0ne | using sleeps in unit tests is a very bad practice | 10:14 |
| imran_ansari | e0ne: I agree with your comment... However, please me explain what I'm trying to achieve in the unit test and then we can discuss if there is any other approach | 10:15 |
| *** lhx__ has quit IRC | 10:15 | |
| imran_ansari | Please allow me to explain* | 10:15 |
| e0ne | sure | 10:15 |
| imran_ansari | Thanks :) | 10:15 |
| *** lhx__ has joined #openstack-cinder | 10:16 | |
| imran_ansari | My design of task-tracker is based on observer pattern | 10:16 |
| imran_ansari | Wherein task tracker tracks status of asynchronous tasks running on array for the regitered listeners | 10:17 |
| imran_ansari | The task tracker then allows the listeners to take some action for different status of task. As of now I've one listener that is responsible for clean up of a temporary snapshot post task-completion | 10:19 |
| imran_ansari | We have other use cases as well that would be using this mechanism | 10:19 |
| imran_ansari | Now, in the unit test part, I'm mocking the client API for the array - so returning different task status is being mocked | 10:20 |
| imran_ansari | I'm returning two status as part of getTask.side_effect - 1. ACTIVE, 2. DONE | 10:21 |
| imran_ansari | Since getTask is invoked by Task Tracker on a worker thread, my main thread needs to wait until it finishes - there is a race condition here | 10:23 |
| e0ne | seems that you test Task Tracker and driver feature in one test | 10:23 |
| imran_ansari | There is a separate test as well for task tracker | 10:24 |
| e0ne | if you split them into the several tests, you can mock task tracker in driver tests and implement new tests for task tracker | 10:24 |
| imran_ansari | Also, the worker thread needs to keep running all the time - it doesn't exit until someone from outside does that | 10:24 |
| imran_ansari | So the main thread cannot call thread.join() until it stops the worker thread from running | 10:25 |
| imran_ansari | Now the issue is when does the main thread stop the worker thread? | 10:25 |
| imran_ansari | How would the main thread know that the worker thread invoked the function to delete temp snapshot? | 10:26 |
| imran_ansari | This I'm achieving by checking how many times getTask got invoked by task tracker | 10:26 |
| e0ne | do we real need threads in unit tests? | 10:27 |
| e0ne | mocks should be enopgh, I guess | 10:27 |
| e0ne | s/enopgh/enogh | 10:27 |
| imran_ansari | Unit test may not need it... But I've a funtionality that needs to delete tmp snapshot. How do I test that via unit test? | 10:28 |
| *** mvk has joined #openstack-cinder | 10:28 | |
| imran_ansari | And this functionality happens to run on a separate thread | 10:28 |
| imran_ansari | So to continute the explanation - mock_tt.getTask.call_count allows the main thread to know that task tracker has executed it | 10:29 |
| imran_ansari | Since I've configured getTask.side_effect with two values, as soon as the count becomes 2 the main thread knows that delete snapshot logic is either about to be called or already called | 10:29 |
| e0ne | can you just mock threads and checks that all methods were invoked with needed params? | 10:30 |
| *** namnh has quit IRC | 10:31 | |
| imran_ansari | The thing is what I'm looking at is the action that must be eventually invoked on listener - was it invoked or not is what I thought I must check | 10:31 |
| imran_ansari | I could even mock task tracker... but then some of functionality would remain untested | 10:33 |
| e0ne | it means that code should be refactored a bit to be more friendly for tests | 10:34 |
| *** odyssey4me has joined #openstack-cinder | 10:34 | |
| odyssey4me | morning folks - I'm seeing inconsistent information in the docs for upgrades and need clarification before pushing up a patch | 10:34 |
| odyssey4me | in https://docs.openstack.org/cinder/latest/upgrade.html#minimal-downtime-upgrade-procedure it has the note: Assumed service upgrade order is cinder-api, cinder-scheduler, cinder-volume and finally cinder-backup. | 10:35 |
| odyssey4me | Then in https://docs.openstack.org/cinder/latest/upgrade.html#during-maintenance-window it says that cinder-api should go first. | 10:35 |
| odyssey4me | So which is it? | 10:35 |
| odyssey4me | lol, my brain needs more coffee apparently | 10:36 |
| odyssey4me | ah, ok - I figured out where the issue was - it's in https://review.openstack.org/#/c/528084/1/doc/source/upgrade.rst | 10:36 |
| imran_ansari | e0ne: The design i think is straight forward based on observer pattern... I think the complexity is there due to a separate thread | 10:36 |
| *** abhishekk has quit IRC | 10:37 | |
| imran_ansari | Which required introduction to the sleep call as without it the scheduler doesn't allow worker thread to run :) | 10:38 |
| e0ne | you don't need running threads | 10:38 |
| e0ne | you need check that threads start calls were invoked | 10:39 |
| *** daidv has quit IRC | 10:39 | |
| *** daidv has joined #openstack-cinder | 10:39 | |
| imran_ansari | Right, but as I said earlier, is there a way to also check if the registered listener got notified of the task state or not and if the required action was performed by the listener? | 10:40 |
| imran_ansari | e0ne: I recorded the time the relevant unit tests take to complete | 10:41 |
| imran_ansari | There are just three of them: | 10:42 |
| imran_ansari | test_create_cloned_volume [0.114273s] | 10:42 |
| imran_ansari | test_clone_volume_with_vvs [0.120239s] | 10:42 |
| imran_ansari | test_task_tracker_delete_tmp_snapshot [0.115865s] | 10:42 |
| imran_ansari | Do you think these execution times are acceptable? | 10:43 |
| *** markvoelker has quit IRC | 10:44 | |
| e0ne | execution time looks good, but I care not only about it but for code too | 10:45 |
| *** lhx_ has joined #openstack-cinder | 10:48 | |
| *** lhx__ has quit IRC | 10:49 | |
| imran_ansari | e0ne: I agree. I would request you to have a look at the code, in case you haven't had a chance to do so, and please suggest whatever is best | 10:49 |
| imran_ansari | BTW, we have a precedence of using sleep in unit test :) | 10:50 |
| *** daidv has quit IRC | 10:50 | |
| *** daidv has joined #openstack-cinder | 10:51 | |
| e0ne | imran_ansari: could you please point me on such test? I'll fix it:) | 10:51 |
| imran_ansari | test_volume.py -> test_create_delete_volume_with_encrypted_volume_type | 10:51 |
| e0ne | thanks. we have to fix it | 10:52 |
| *** abhishekk has joined #openstack-cinder | 10:53 | |
| imran_ansari | :) | 10:53 |
| imran_ansari | Also please suggest how we can test listener in conjunction with task tracker? | 10:54 |
| e0ne | I have to go deeper into your code to provide such advice. unfortunately, I have no time for it today:( | 10:57 |
| e0ne | but I'll be happy to review new patch if any | 10:58 |
| e0ne | if community decides to approve this patch even with sleeps on weekly meeting or mailing list - I'll remove my -2 | 10:58 |
| imran_ansari | I've pushed one today with Jay's comments addressed. But it has sleep :( | 10:58 |
| *** daidv has quit IRC | 10:58 | |
| imran_ansari | It would be helpful though if u could have a look at the task tracker implementation and provide your comments. If you are ok I can run you through the code quickly | 10:59 |
| imran_ansari | Based on your availability some time early next week if not today | 11:00 |
| imran_ansari | :) | 11:00 |
| e0ne | I can't promise anything but I will try | 11:00 |
| imran_ansari | Thanks Ivan for your time! I appreciate! :) | 11:01 |
| imran_ansari | Ok | 11:01 |
| *** abhishekk has quit IRC | 11:05 | |
| *** abhishekk has joined #openstack-cinder | 11:09 | |
| *** abhishekk has quit IRC | 11:13 | |
| *** wanghao has joined #openstack-cinder | 11:23 | |
| openstackgerrit | Lucian Petrut proposed openstack/os-brick master: Windows: fix connectors 'disconnect_volume' signature https://review.openstack.org/528236 | 11:24 |
| openstackgerrit | Lucian Petrut proposed openstack/os-brick master: Windows SMBFS: allow mounting vhd/x images https://review.openstack.org/528237 | 11:24 |
| *** wanghao has quit IRC | 11:27 | |
| *** wanghao has joined #openstack-cinder | 11:27 | |
| *** sapd_ has quit IRC | 11:28 | |
| *** sapd_ has joined #openstack-cinder | 11:28 | |
| *** markvoelker has joined #openstack-cinder | 11:41 | |
| openstackgerrit | Helen Walsh proposed openstack/cinder master: VMAX doc - Queens feature documentation https://review.openstack.org/527458 | 11:41 |
| *** wanghao has quit IRC | 11:42 | |
| *** wanghao has joined #openstack-cinder | 11:42 | |
| *** moshele has joined #openstack-cinder | 11:48 | |
| *** wanghao has quit IRC | 11:57 | |
| *** imran_ansari has quit IRC | 11:57 | |
| *** chrisyang_0660 has quit IRC | 12:04 | |
| *** erlon has joined #openstack-cinder | 12:05 | |
| *** markvoelker has quit IRC | 12:13 | |
| openstackgerrit | Jeremy Zhang proposed openstack/cinder master: RBD: get manageable volumes https://review.openstack.org/527903 | 12:19 |
| *** dave-mccowan has joined #openstack-cinder | 12:19 | |
| *** mvenesio has joined #openstack-cinder | 12:21 | |
| *** zhaochao has quit IRC | 12:21 | |
| *** dave-mcc_ has joined #openstack-cinder | 12:22 | |
| *** dave-mccowan has quit IRC | 12:24 | |
| pooja_jadhav | tommylikehu: Hi | 12:26 |
| *** catintheroof has joined #openstack-cinder | 12:31 | |
| *** lhx_ has quit IRC | 12:50 | |
| *** abhitechie has joined #openstack-cinder | 12:54 | |
| *** markvoelker has joined #openstack-cinder | 12:56 | |
| *** markvoelker has quit IRC | 12:58 | |
| *** abhitechie has quit IRC | 13:13 | |
| openstackgerrit | Kushal Wathore proposed openstack/cinder master: HPE 3PAR - Implement Tiramisu feature on 3PAR https://review.openstack.org/528266 | 13:17 |
| tommylikehu | pooja_jadhav: hi | 13:18 |
| *** lhx_ has joined #openstack-cinder | 13:20 | |
| *** _alastor__ has quit IRC | 13:22 | |
| *** _alastor__ has joined #openstack-cinder | 13:22 | |
| *** melwitt has quit IRC | 13:23 | |
| *** melwitt has joined #openstack-cinder | 13:25 | |
| *** melwitt is now known as Guest75547 | 13:25 | |
| *** pgadiya has quit IRC | 13:29 | |
| *** liverpooler has joined #openstack-cinder | 13:36 | |
| *** takedakn has joined #openstack-cinder | 13:48 | |
| *** mriedem has joined #openstack-cinder | 13:51 | |
| *** amoralej is now known as amoralej|lunch | 13:53 | |
| smcginnis | odyssey4me: A bug has been opened on that and a patch put up to fix it. | 13:58 |
| *** liverpooler has quit IRC | 13:59 | |
| *** liverpooler has joined #openstack-cinder | 13:59 | |
| odyssey4me | smcginnis to fix that review? | 13:59 |
| smcginnis | odyssey4me: Sorry, I just saw you pointing out the inconsistency earlier. Is there a duplicate patch? | 14:00 |
| smcginnis | odyssey4me: OK, just seeing you commented on that now. Just catching up. :) | 14:01 |
| smcginnis | odyssey4me: Yeah, looks like that needs some more work. | 14:02 |
| odyssey4me | smcginnis well, the review says the docs are inconsistent - but I don't see the inconsistency | 14:03 |
| smcginnis | odyssey4me: There was another part that has a different order pointed out in the bug. So looks like we have the order in a few different parts, but they don't agree. | 14:03 |
| *** psachin has quit IRC | 14:07 | |
| *** takedakn has quit IRC | 14:08 | |
| *** stvnoyes has joined #openstack-cinder | 14:23 | |
| *** links has quit IRC | 14:31 | |
| *** markvoelker has joined #openstack-cinder | 14:31 | |
| *** moshele has quit IRC | 14:33 | |
| e0ne | smcginnis, jungleboyj: hi. should we add release note while removing deprecated config options? | 14:40 |
| smcginnis | e0ne: Yeah, usually we've been putting notice of the removal under the "upgrades" section. | 14:41 |
| *** shaner has quit IRC | 14:41 | |
| e0ne | smcginnis: :(. it will be harder than I expected. now, I have to add release notes | 14:42 |
| e0ne | smcginnis: I'm going to remove ~5 deprecated config options now | 14:43 |
| smcginnis | e0ne: It doesn't need to be much. Just something noting that they are actually removed so deployments hopefully see it and know they need to change their config if they missed them being marked deprecated. | 14:44 |
| e0ne | smcginnis: sure | 14:44 |
| *** amoralej|lunch is now known as amoralej | 14:45 | |
| *** openstackgerrit has quit IRC | 14:48 | |
| *** rcernin has joined #openstack-cinder | 14:57 | |
| *** xyang1 has joined #openstack-cinder | 14:58 | |
| *** xyang1 has quit IRC | 14:59 | |
| *** xyang1 has joined #openstack-cinder | 14:59 | |
| *** xyang has joined #openstack-cinder | 15:00 | |
| *** xyang has quit IRC | 15:01 | |
| *** xyang has joined #openstack-cinder | 15:01 | |
| *** felipemonteiro_ has joined #openstack-cinder | 15:02 | |
| *** crushil_ has joined #openstack-cinder | 15:02 | |
| *** openstackgerrit has joined #openstack-cinder | 15:03 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: Remove deprecated 'nas_ip' config option https://review.openstack.org/528299 | 15:03 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: Remove deprecated HP 3PAR config options https://review.openstack.org/528300 | 15:03 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: Remove deprecated 'netapp_eseries_host_type' config option https://review.openstack.org/528301 | 15:03 |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder master: Remove deprecated 'pybasedir' config option https://review.openstack.org/528302 | 15:03 |
| *** armaan has quit IRC | 15:05 | |
| *** jmlowe_ has quit IRC | 15:05 | |
| *** xyang1 has quit IRC | 15:05 | |
| *** felipemonteiro__ has joined #openstack-cinder | 15:06 | |
| *** Apoorva has joined #openstack-cinder | 15:06 | |
| *** felipemonteiro_ has quit IRC | 15:09 | |
| *** harlowja has joined #openstack-cinder | 15:11 | |
| *** shaner has joined #openstack-cinder | 15:12 | |
| *** harlowja has quit IRC | 15:13 | |
| openstackgerrit | Kushal Wathore proposed openstack/cinder master: HPE 3PAR - Implement Tiramisu feature on 3PAR https://review.openstack.org/528266 | 15:16 |
| openstackgerrit | Jeremy Zhang proposed openstack/cinder master: RBD: get manageable volumes https://review.openstack.org/527903 | 15:16 |
| *** dustins has joined #openstack-cinder | 15:25 | |
| swamireddy | e0ne: Thanks...for ceph volumes, data wiping not needed...can you please let me know, how its doing @ ceph? | 15:28 |
| *** Apoorva has quit IRC | 15:28 | |
| e0ne | swamireddy: I don't know details on it | 15:28 |
| swamireddy | e0ne: ok,,NOP...I will dig more on this..Thank you | 15:29 |
| *** markvoelker has quit IRC | 15:29 | |
| *** armaan has joined #openstack-cinder | 15:30 | |
| *** armax has joined #openstack-cinder | 15:31 | |
| *** rcernin has quit IRC | 15:41 | |
| *** abhitechie has joined #openstack-cinder | 15:42 | |
| *** vivsoni__ has joined #openstack-cinder | 15:44 | |
| vivsoni__ | smcginnis: Hi | 15:46 |
| vivsoni__ | mriedem: has uploaded a new patchset on fixing the tempest failure (passing empty connector to terminate_connection) | 15:47 |
| *** markstur has joined #openstack-cinder | 15:47 | |
| *** markstur has quit IRC | 15:47 | |
| *** markstur has joined #openstack-cinder | 15:48 | |
| vivsoni__ | smcginnis & Team, please review https://review.openstack.org/#/c/528028/ | 15:55 |
| *** mvk has quit IRC | 16:05 | |
| *** e0ne has quit IRC | 16:05 | |
| vivsoni__ | smcginnis: Great ... Thanks for your precious time :) | 16:09 |
| vivsoni__ | smcginnis: Thanks for review | 16:10 |
| adrianofr | Hey guys. Could you please this review https://review.openstack.org/#/c/527762/ when you have some time? | 16:12 |
| smcginnis | vivsoni__: No problem. Just been tied up with other things lately, so didn't get a chance to get back to that after the last update. ;) | 16:12 |
| vivsoni__ | smcginnis: just to re-confirm it .. do we need to handle this in our drivers code ? | 16:14 |
| smcginnis | vivsoni__: Yes | 16:14 |
| vivsoni__ | Ok | 16:14 |
| jungleboyj | smcginnis: It is in the driver? | 16:15 |
| jungleboyj | ;-) | 16:15 |
| smcginnis | _______________________________ | 16:15 |
| smcginnis | < The driver needs to be fixed! > | 16:15 |
| smcginnis | ------------------------------- | 16:15 |
| smcginnis | \ ^__^ | 16:15 |
| smcginnis | \ (oo)\_______ | 16:15 |
| smcginnis | (__)\ )\/\ | 16:15 |
| smcginnis | ||----w | | 16:15 |
| smcginnis | || || | 16:15 |
| jungleboyj | :-) | 16:15 |
| vivsoni__ | :) | 16:16 |
| Swanson | The hell? | 16:18 |
| *** markvoelker has joined #openstack-cinder | 16:18 | |
| *** Guest75547 is now known as melwitt | 16:18 | |
| erlon | Swanson: exactly, all drivers will burn there | 16:18 |
| smcginnis | We discussed this in channel and in a meeting a few months back and realized we all need to handle this situation. | 16:19 |
| erlon | smcginnis: lost that contex, you mean about the new attachment API? | 16:23 |
| *** crushil_ has quit IRC | 16:24 | |
| *** yangyapeng has joined #openstack-cinder | 16:24 | |
| *** crushil_ has joined #openstack-cinder | 16:24 | |
| Swanson | erlon, I think this "passing empty connector to terminate_connection" | 16:26 |
| *** abhitechie has quit IRC | 16:27 | |
| ildikov | smcginnis: with this particular terminate_connection issue, it's not the drivers, it's the microversion concept or just simply the inability to efficiently handle API changes... | 16:27 |
| ildikov | smcginnis: my head is blowing up every single day that we're introducing painful workarounds everywhere to avoid bumping the Nova API microversion | 16:28 |
| *** vivsoni__ has quit IRC | 16:28 | |
| *** vivsoni__ has joined #openstack-cinder | 16:29 | |
| ildikov | smcginnis: and just to the margin it's for a functionality that everyone wants to burn on hell fires and I'm not sure how many people rely on that particular volume state that wold change in this case | 16:29 |
| smcginnis | ildikov: We needed to handle terminate_connection without a connector being passed in for the case of force detach. That was before multiattach. | 16:29 |
| smcginnis | ildikov: But with multiattach, it appears we needed to handle that in the code to *not* pass that down to the driver if it was not a force detach situation. | 16:30 |
| ildikov | smcginnis: well, we're reverting and working around also shelve which I think hit some of these connector issues | 16:30 |
| *** vivsoni__ has quit IRC | 16:30 | |
| smcginnis | ildikov: Yeah, I think it was the shelve/unshelve scenario that uncovered this. | 16:30 |
| *** vivsoni__ has joined #openstack-cinder | 16:30 | |
| ildikov | smcginnis: so with the new flow we shouldn't put the volume into 'in-use' | 16:30 |
| smcginnis | ildikov: I haven't been following that part too close. I think nova does want it that way. | 16:31 |
| ildikov | smcginnis: it should be in 'reserved' state, which means that deleting the attachment wouldn't go that far to having to deal with an empty connector as it would be deleted in the volume/api.py | 16:31 |
| smcginnis | ildikov: I think that's how jgriffith had it, but then that was all reverted because someone somewhere maybe possibily on a Tuesday might have expected the old behavior. | 16:32 |
| *** vivsoni__ has quit IRC | 16:33 | |
| *** itlinux has joined #openstack-cinder | 16:34 | |
| *** vivsoni__ has joined #openstack-cinder | 16:34 | |
| ildikov | smcginnis: if it's now all because of that one particular workaround we started to avoid a Nova API mv bump I'm still strongly against this and think we should bump that version rather and make it sane | 16:36 |
| ildikov | smcginnis: even if mriedem will invest in voodoo dolls after this comment of mine | 16:36 |
| mriedem | i guess i'm not goign to get my results written up today | 16:39 |
| mriedem | ildikov: the microversion bump only changes behavior for that version forward | 16:39 |
| mriedem | it doesn't fix anything for all the versions before that | 16:39 |
| mriedem | the canonical way for a client to wait for a volume to be attached to a server is waiting for the volume status to be in-use | 16:39 |
| mriedem | regardless of the instance status | 16:40 |
| mriedem | that's what novaclient does, that's what tempest does, etc | 16:40 |
| mriedem | if you change that to never go to in-use but reserved b/c of shelved offloaded, you potentially break a bunch of client code | 16:40 |
| ildikov | in a shelved offloaded case I would argue with what attaching actually means | 16:40 |
| mriedem | ildikov: at this point it doesn't matter | 16:40 |
| mriedem | that ship has sailed | 16:40 |
| mriedem | i was just trying to defend compute API stability questions in the 1-year release cycle thread last night | 16:41 |
| ildikov | it still blows my mind as I only saw half of the consequences before and even at that time this whole thing blew my mind | 16:41 |
| mriedem | http://lists.openstack.org/pipermail/openstack-dev/2017-December/125626.html | 16:41 |
| ildikov | on my todo list to read it | 16:41 |
| *** AlexeyAbashkin has quit IRC | 16:41 | |
| jungleboyj | mriedem: and smcginnis Just to make sure I don't do something stupid ... We do want this merged. Right? | 16:44 |
| jungleboyj | https://review.openstack.org/#/c/528028/4 | 16:44 |
| vivsoni__ | jungleboyj: :-) | 16:44 |
| jungleboyj | vivsoni__: Making sure you aren't leading me to hell. | 16:45 |
| smcginnis | jungleboyj: Yeah, that's almost besides the point to the overall issue IMO. | 16:45 |
| smcginnis | I'm only aware of force being a case where the drivers need to handle not having that. | 16:45 |
| smcginnis | So I think it's fine to only send it to the drivers when the force flag is set. | 16:46 |
| jungleboyj | smcginnis: Ok, that was what I thought but wanted to tripple check. | 16:46 |
| smcginnis | __ | 16:46 |
| smcginnis | ++ | 16:46 |
| jungleboyj | Approved. | 16:46 |
| mriedem | jungleboyj: smcginnis: probably need to talk with erlon on the bottom patch | 16:47 |
| mriedem | erlon: see my reply? | 16:47 |
| mriedem | dep order doesn't matter here, they are both separate bugs that impact different CI systems in different ways | 16:47 |
| mriedem | if you reverse the dep order, the other one will fail some CIs | 16:47 |
| smcginnis | Bottom patch? | 16:47 |
| mriedem | they have to both be merged | 16:47 |
| mriedem | yes | 16:47 |
| erlon | mriedem: not yet, Ill look to it | 16:47 |
| mriedem | https://review.openstack.org/#/c/527852/ fixes FC backends | 16:48 |
| mriedem | where wwpns in the connector is a list | 16:48 |
| mriedem | https://review.openstack.org/#/c/528028/ fixes 3HPAR or whatever backends that don't handle a None connector passed to terminate_connection | 16:48 |
| mriedem | i'm not going to squash those changes | 16:48 |
| erlon | mriedem: how do I know that the first patch will pass if the second is merged? for me that look a dependency | 16:49 |
| erlon | mriedem: furthermore, if all will merge anyways doesnt not change for you if they are chained, but we are sure that they all work together | 16:50 |
| erlon | mriedem: Im not suggesting a squash, just a dependency so all are tested together | 16:52 |
| erlon | mriedem: anyway merged, lets see how that goes | 16:53 |
| erlon | jungleboyj: https://review.openstack.org/#/c/527762/ wanna join the merge party :D | 16:57 |
| jungleboyj | erlon: Will do when I can take a look. | 16:57 |
| erlon | jungleboyj: thanks! | 16:58 |
| *** sapd_ has quit IRC | 17:06 | |
| *** lhx_ has quit IRC | 17:06 | |
| *** dustins has quit IRC | 17:06 | |
| *** ntpttr_laptop has joined #openstack-cinder | 17:09 | |
| *** amoralej is now known as amoralej|off | 17:11 | |
| openstackgerrit | Aseel Awwad proposed openstack/cinder master: Check if already managed before manage snapshot https://review.openstack.org/527957 | 17:13 |
| mnaser | is there a gate issue in cinder or was this just a spurious timeout? https://review.openstack.org/#/c/528107/ | 17:17 |
| openstackgerrit | Aseel Awwad proposed openstack/cinder master: Check if already managed before manage snapshot https://review.openstack.org/527957 | 17:18 |
| smcginnis | mnaser: Spurious I think. | 17:18 |
| *** crushil_ has quit IRC | 17:23 | |
| *** mvk has joined #openstack-cinder | 17:25 | |
| openstackgerrit | Lucian Petrut proposed openstack/cinder master: [WIP - UT needed] SMBFS: allow snapshot ro attach https://review.openstack.org/528350 | 17:25 |
| openstackgerrit | Lucian Petrut proposed openstack/cinder master: SMBFS: fix detecting if a volume is in-use https://review.openstack.org/528351 | 17:25 |
| openstackgerrit | Lucian Petrut proposed openstack/cinder master: Add Windows volume backup support https://review.openstack.org/528352 | 17:25 |
| *** lpetrut has quit IRC | 17:38 | |
| jungleboyj | erlon: Done. | 17:43 |
| erlon | jungleboyj: Thanks! | 17:44 |
| jungleboyj | erlon: Welcome. | 17:46 |
| *** crushil_ has joined #openstack-cinder | 17:50 | |
| *** ntpttr__ has joined #openstack-cinder | 17:55 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Correct documented service upgrade order https://review.openstack.org/528084 | 17:56 |
| *** ntpttr_ has quit IRC | 17:56 | |
| *** rmcall has quit IRC | 18:00 | |
| *** imacdonn_ is now known as imacdonn | 18:01 | |
| *** aarefiev has quit IRC | 18:04 | |
| *** catintheroof has quit IRC | 18:07 | |
| *** catinthe_ has joined #openstack-cinder | 18:07 | |
| *** chhavi has quit IRC | 18:09 | |
| *** mvenesio has quit IRC | 18:11 | |
| *** jose-phillips has quit IRC | 18:15 | |
| *** jose-phillips has joined #openstack-cinder | 18:15 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 18:16 | |
| *** AlexeyAbashkin has quit IRC | 18:21 | |
| *** AlexeyAbashkin has joined #openstack-cinder | 18:22 | |
| *** AlexeyAbashkin has quit IRC | 18:26 | |
| *** thiagolib has quit IRC | 18:29 | |
| *** nicolasbock has joined #openstack-cinder | 18:29 | |
| *** dustins has joined #openstack-cinder | 18:35 | |
| *** imacdonn has quit IRC | 18:35 | |
| *** imacdonn has joined #openstack-cinder | 18:36 | |
| *** rmcall has joined #openstack-cinder | 18:36 | |
| *** armaan has quit IRC | 18:38 | |
| *** lpetrut has joined #openstack-cinder | 18:39 | |
| openstackgerrit | Merged openstack/cinder master: NEC driver: delete an unused configuration parameter. https://review.openstack.org/523382 | 18:45 |
| openstackgerrit | Merged openstack/cinder master: Store host connector in volume_attachment.connector column https://review.openstack.org/527852 | 18:50 |
| openstackgerrit | Merged openstack/cinder master: Don't call driver.terminate_connection if there is no connector https://review.openstack.org/528028 | 18:50 |
| *** mriedem has quit IRC | 18:51 | |
| *** dalgaaf has quit IRC | 18:51 | |
| *** ntpttr_laptop has quit IRC | 18:52 | |
| *** lpetrut has quit IRC | 18:53 | |
| *** e0ne has joined #openstack-cinder | 19:00 | |
| *** dalgaaf has joined #openstack-cinder | 19:02 | |
| *** ntpttr_laptop has joined #openstack-cinder | 19:07 | |
| *** crushil_ has quit IRC | 19:08 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Add thin provisioning package to install guide https://review.openstack.org/528372 | 19:08 |
| *** crushil_ has joined #openstack-cinder | 19:09 | |
| openstackgerrit | Merged openstack/cinder master: NetApp ONTAP: Copy offload bugfix https://review.openstack.org/527762 | 19:17 |
| *** catinthe_ has quit IRC | 19:21 | |
| *** e0ne has quit IRC | 19:22 | |
| *** vivsoni__ has quit IRC | 19:31 | |
| *** moshele has joined #openstack-cinder | 19:32 | |
| *** ntpttr_laptop has quit IRC | 19:32 | |
| *** moshele has quit IRC | 19:43 | |
| *** moshele has joined #openstack-cinder | 19:45 | |
| *** dalgaaf has quit IRC | 19:57 | |
| *** dalgaaf has joined #openstack-cinder | 20:08 | |
| *** moshele has quit IRC | 20:22 | |
| *** armaan has joined #openstack-cinder | 20:27 | |
| *** dustins has quit IRC | 20:31 | |
| imacdonn | Trying to figure out if mriedem's fix will address the Oracle ZFSSA blow-ups ... maybe I'm not reading it right, but I think it won't | 20:37 |
| imacdonn | seems that terminate_connection() is getting a connector that's not None, but it has no 'initiator' | 20:37 |
| *** e0ne has joined #openstack-cinder | 20:40 | |
| *** e0ne has quit IRC | 20:42 | |
| Swanson | imacdonn, Yeah. So if you need that to whack a connection then you have an issue. | 20:47 |
| imacdonn | I'm trying to figure out if it's valid to call an iSCSI volume driver with a connector that has no initiator | 20:47 |
| imacdonn | doesn't seem valid to me .... ??? | 20:48 |
| *** openstackgerrit has quit IRC | 20:48 | |
| imacdonn | smcginnis, jungleboyj: open to comments on above ;) | 20:48 |
| Swanson | imacdonn, That was my take but I believe that take was over ridden. | 20:48 |
| imacdonn | I can probably just exist as a noop (or something?) if there's no initiator in the connector.... but don't think I should have to, and not really sure what the right action would be (do nothing, or detach the volume from all initiators??) | 20:50 |
| imacdonn | just exit* (as in return) | 20:50 |
| smcginnis | imacdonn: Do you know how it is getting it with no initiator? | 20:51 |
| imacdonn | smcginnis: I know that it's getting passed a connector that is not None (because it specifically checks for that), but it then tries to get connector['initiator'] and barfs a KeyError | 20:52 |
| smcginnis | imacdonn: But under what circumstance is that happenign? | 20:53 |
| imacdonn | seems to be related to AttachVolumeShelveTestJSON | 20:54 |
| imacdonn | this is CI issue, if that wasn't obvious | 20:54 |
| Swanson | I think it should do that with Force detach, too, right? | 20:54 |
| smcginnis | imacdonn: OK, if it's related to shelve then mriedem's patch is not going to help with that. | 20:55 |
| smcginnis | Force detach won't have a connector at all, so that will still be sent through to the driver. | 20:55 |
| smcginnis | And the driver needs to handle that and delete any attachements. | 20:55 |
| Swanson | Bah. | 20:55 |
| imacdonn | right, and I wrote code to specifically handle that | 20:55 |
| smcginnis | But in this case the check will see that there is a connector and pass it through. | 20:55 |
| imacdonn | it assumes that if connector is None, it's expected to disconnect from any and all initiators | 20:56 |
| smcginnis | So there's probably something on the nova side with shelve/unshelve that mucks with that, but probably a better question for mriedem. | 20:56 |
| imacdonn | right. What's his typical schedule? | 20:57 |
| smcginnis | Usually around now, but appears to have taken off. | 20:58 |
| smcginnis | He's central US time. | 20:58 |
| imacdonn | OK. I'll go grab lunch and hope he pops back in then .. thanks ;) | 20:58 |
| *** itlinux has quit IRC | 20:59 | |
| *** sdague has quit IRC | 21:09 | |
| *** openstackgerrit has joined #openstack-cinder | 21:10 | |
| openstackgerrit | John Griffith proposed openstack/cinder master: Check for migrated UUID in SolidFire delete https://review.openstack.org/522410 | 21:10 |
| *** jmlowe has joined #openstack-cinder | 21:11 | |
| *** armaan has quit IRC | 21:14 | |
| *** armaan has joined #openstack-cinder | 21:15 | |
| *** rmcall has quit IRC | 21:16 | |
| *** jmlowe has quit IRC | 21:17 | |
| *** openstackgerrit has quit IRC | 21:18 | |
| *** openstackgerrit has joined #openstack-cinder | 21:23 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/cinder master: Updated from global requirements https://review.openstack.org/528395 | 21:23 |
| *** dustins has joined #openstack-cinder | 21:28 | |
| imacdonn | smcginnis: where did we end up with the test_snapshot_create_volume_description_non_ascii_code issue ... where it seemed that something was assuming that the description for a snapshot would be copied from the parent volume .... | 21:34 |
| *** rcernin has joined #openstack-cinder | 21:36 | |
| *** ntpttr_laptop has joined #openstack-cinder | 21:36 | |
| *** itlinux has joined #openstack-cinder | 21:40 | |
| smcginnis | imacdonn: Looks like that has merged: https://review.openstack.org/#/c/524946/ | 21:41 |
| imacdonn | smcginnis: hmm, I'm still seeing failures (apparently) related to it | 21:42 |
| imacdonn | Traceback (most recent call last): | 21:42 |
| imacdonn | File "/opt/stack/cinder/cinder/tests/tempest/api/volume/test_volume_unicode.py", line 70, in test_snapshot_create_volume_description_non_ascii_code | 21:42 |
| imacdonn | self.assertEqual(description, snapshot_info['description']) | 21:42 |
| imacdonn | File "/usr/local/lib/python2.7/dist-packages/testtools/testcase.py", line 411, in assertEqual | 21:42 |
| imacdonn | self.assertThat(observed, matcher, message) | 21:42 |
| imacdonn | File "/usr/local/lib/python2.7/dist-packages/testtools/testcase.py", line 498, in assertThat | 21:42 |
| imacdonn | raise mismatch_error | 21:42 |
| imacdonn | testtools.matchers._impl.MismatchError: u'\u05e7\u05d9\u05d9\u05e4\u05e9' != None | 21:42 |
| imacdonn | does that mean that the submitters haven't updated their branches ? | 21:43 |
| openstackgerrit | Marc proposed openstack/cinder master: Solving permission errors due to directory ownership on NFS https://review.openstack.org/524728 | 21:43 |
| imacdonn | not sure where all the bits come from | 21:43 |
| smcginnis | imacdonn: That's possible. They may just need to rebase on current master. | 21:44 |
| imacdonn | ok | 21:44 |
| *** jmlowe has joined #openstack-cinder | 21:44 | |
| imacdonn | yeah, they're not all failing on that ... most are just failing on the shelve thing .. thanks | 21:46 |
| smcginnis | imacdonn: Cool, that was easy. :) | 21:47 |
| imacdonn | :) | 21:47 |
| *** openstackgerrit has quit IRC | 21:48 | |
| *** jmlowe has quit IRC | 21:49 | |
| *** erlon has quit IRC | 21:50 | |
| *** openstackgerrit has joined #openstack-cinder | 21:50 | |
| openstackgerrit | Sean McGinnis proposed openstack/cinder master: Fixes creation of mirrored volumes due to wrong type https://review.openstack.org/517939 | 21:50 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/os-brick master: Updated from global requirements https://review.openstack.org/528423 | 22:01 |
| *** itlinux has quit IRC | 22:01 | |
| *** crushil_ has left #openstack-cinder | 22:05 | |
| *** mriedem has joined #openstack-cinder | 22:07 | |
| *** dave-mcc_ has quit IRC | 22:10 | |
| *** nicolasbock has quit IRC | 22:11 | |
| *** dustins has quit IRC | 22:23 | |
| *** adrianofr has quit IRC | 22:28 | |
| *** armaan has quit IRC | 22:28 | |
| *** catintheroof has joined #openstack-cinder | 22:29 | |
| *** stvnoyes has quit IRC | 22:30 | |
| imacdonn | mriedem: ping | 22:34 |
| imacdonn | mriedem: see discussion while you were out, about terminate_connection() getting passed a connector that is not None, but has no 'initiator' (it's an empty dict) | 22:36 |
| imacdonn | http://eavesdrop.openstack.org/irclogs/%23openstack-cinder/latest.log.html#t2017-12-15T20:37:13 | 22:36 |
| *** AlexeyAbashkin has joined #openstack-cinder | 22:42 | |
| *** AlexeyAbashkin has quit IRC | 22:47 | |
| *** felipemonteiro__ has quit IRC | 23:35 | |
| *** Swimingly has quit IRC | 23:40 | |
| *** Swimingly has joined #openstack-cinder | 23:41 | |
| *** Swimingly has joined #openstack-cinder | 23:41 | |
| *** mriedem has quit IRC | 23:46 | |
| *** adisky__ has quit IRC | 23:56 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!