Thursday, 2017-12-14

*** felipemonteiro has joined #openstack-cinder00:18
*** felipemonteiro_ has joined #openstack-cinder00:19
*** itlinux has quit IRC00:22
*** felipemonteiro has quit IRC00:23
*** wanghao has joined #openstack-cinder00:26
*** wanghao has quit IRC00:26
*** felipemonteiro_ has quit IRC00:26
*** wanghao has joined #openstack-cinder00:27
*** wanghao has quit IRC00:27
openstackgerritMerged openstack/cinder master: TrivialFix: Delete word ā€˜Iā€™ in admin/blockstorage-backup-disks.rst  https://review.openstack.org/52584600:29
openstackgerritMerged openstack/cinder master: added clarification in docs for usage of "volume_clear*" options  https://review.openstack.org/52392300:29
openstackgerritMerged openstack/cinder master: Fix several instances of chap secret being output to logs.  https://review.openstack.org/51973400:29
*** armax has joined #openstack-cinder00:33
*** ntpttr_laptop has joined #openstack-cinder00:33
*** prateek_ has quit IRC00:37
*** prateek_ has joined #openstack-cinder00:38
*** wanghao has joined #openstack-cinder00:39
*** gouthamr has joined #openstack-cinder00:42
*** harlowja has quit IRC00:45
openstackgerritWanjing Xu proposed openstack/cinder master: [DNM] Testing Cisco ZM CI  https://review.openstack.org/52782400:51
*** AlexeyAbashkin has joined #openstack-cinder00:53
*** AlexeyAbashkin has quit IRC00:57
openstackgerritMerged openstack/cinder master: XtremIO: optional clean IG with no mappings  https://review.openstack.org/51539200:59
openstackgerritMerged openstack/cinder master: SMBFS: manageable volumes  https://review.openstack.org/52115800:59
openstackgerritMerged openstack/cinder master: QNAP: Add support for QES 2.0.0  https://review.openstack.org/52699400:59
openstackgerritMerged openstack/cinder master: Fix discrepancy in api-ref for volume_types APIs  https://review.openstack.org/52634400:59
openstackgerritMerged openstack/cinder master: Don't raise 'NotAuthorized' inside when soft authorization  https://review.openstack.org/52632700:59
openstackgerritMerged openstack/cinder master: Restore_backup: set error when volume status not matched  https://review.openstack.org/52002600:59
openstackgerritWanjing Xu proposed openstack/cinder master: [DNM] Testing Cisco Third Party CI Cisco-CI-Experimental-Branch: adding_experimental_zm_cinder  https://review.openstack.org/52782601:03
*** mriedem has quit IRC01:06
tommylikehuhey smcginnis  I guess pooja_jadhav 's idea is to remove the additional parameters in the request body, no in the response:)01:06
tommylikehuhttps://review.openstack.org/#/c/52763701:07
tommylikehualso pooja_jadhav  there are more attributes I think we should remove them, not only the status01:08
openstackgerritWanjing Xu proposed openstack/cinder master: [DNM] Testing Cisco Third Party CI  https://review.openstack.org/52782601:09
*** mriedem has joined #openstack-cinder01:10
tommylikehusmcginnis:  basically we don't verify the additional parameters in the API controller before. But now we introduced the JSON schema, there could be more changes in the cinderclient.01:10
tommylikehuping mriedem01:11
mriedemtommylikehu: hi01:11
tommylikehuhi mriedem  could you take a look at this bug? https://bugs.launchpad.net/cinder/+bug/173772401:11
openstackLaunchpad bug 1737724 in Cinder "FC attachment issue" [Undecided,New]01:11
*** yangyapeng has joined #openstack-cinder01:12
mriedemi'm kind of in the middle of fixing some other bugs associated with the new attach flow in nova01:13
mriedemis there something specific i need to look at?01:13
tommylikehuI am wondering how you correctly handle and save this connection info at nova side:)01:13
*** psachin has joined #openstack-cinder01:13
*** s-shiono has joined #openstack-cinder01:14
mriedemi don't see errors in the c-api, c-vol or n-cpu logs here http://54.209.116.144/93/526893/2/check/kaminario-dsvm-tempest-full-FC/82abd60/logs/01:14
tommylikehumriedem, cause cinder save the connection info in the form of simple key/value strings and it could not meet the requirement of arrays01:14
mriedemnova is not sending connection_info dicts to cinder01:15
mriedemthose come *from* cinder01:15
tommylikehumriedem:  I thought you would save them01:15
tommylikehuhere is the root cause: INSERT INTO attachment_specs (created_at, updated_at, deleted_at, deleted, `key`, value, attachment_id)01:15
tommylikehuVALUES ("2017-12-11 01:49:36", "2017-12-11 01:49:36", "", 0, "wwpns", ["21000024ff34c92d", "21000024ff34c92c"], "e3aab3b7-539c-45c9-855b-ec7aeb908f21")'] [parameters: {'attachment_id': 'e3aab3b7-539c-45c9-855b-ec7aeb908f21', 'deleted': 0, 'created_at': datetime.datetime(2017, 12, 12, 9, 2, 8, 449122), 'updated_at': None, 'value': [u'21000024ff34c92d', u'21000024ff34c92c'], 'key': u'wwpns', 'deleted_at':01:15
tommylikehuNone}]01:15
mriedemthat's coming from the host connector01:16
mriedemnova asks os-brick for the host connector01:16
mriedemand passes that to cinder01:16
mriedemin the PUT /attachments call01:16
mriedemcinder stores the connector dict values in the attachment_specs table01:16
mriedemas key/value pairs01:16
mriedemis there a new release of os-brick maybe that's causing issues?01:16
tommylikehumriedem:  cinder will try to save the connection info in the new attach/detach APIs. we don't in the older style01:17
*** Apoorva has quit IRC01:18
tommylikehumriedem:  I thought you would save them in the nova side in the older attach/detach APIs. so I am wrong:)01:18
tommylikehus/in/at01:18
mriedemnova saves the connection_info dict, returned by cinder, in the nova.block_device_mappings table as a serialized json blob01:20
mriedembut it's assumed that the connection_info is a dict01:20
mriedemand the host connector from os-brick is also a dict01:20
mriedemwhat the values are within that dict, idk01:20
mriedemdoes cinder's attachment_specs table assume all the key/values are strings?01:21
tommylikehumriedem:  ok, now we save them in the key/value pairs such as metadata:)01:21
mriedemyup http://git.openstack.org/cgit/openstack/cinder/tree/cinder/db/sqlalchemy/migrate_repo/versions/091_add_attachment_specs.py#n2501:21
mriedemit expects strings01:21
mriedemidk why01:21
mriedemthe attachment_specs table probably doesn't even need to exist, it could have just been serialized json stored in the attachments table01:22
mriedemit would have been faster that way anyway01:22
mriedemso wwpns is a list and attachment_specs can't handle that01:22
mriedemfor fibrechannel01:22
mriedemanyway, this is a cinder bug01:22
tommylikehumriedem:  i have no idea, that's the problem,  guess we don't have any trouble when trying iscsi01:22
mriedemwell i can see right here: "wwpns", ["21000024ff34c92d", "21000024ff34c92c"],01:23
mriedemthat's not going to work on a String column01:23
mriedemunless you serialize it01:23
*** liverpooler has joined #openstack-cinder01:23
mriedemso, the fix on the cinder side is to probably always serialize the values before putting them into the attachment_specs table, and deserialize when you pull them out01:23
tommylikehuyeah, if we serialize the connector, there is no need to separate them and store in the key/value01:23
mriedemagree01:24
mriedembut you've got this attachment_specs table right now01:24
tommylikehulol01:24
mriedemthere is no versioned object for attachment specs either01:24
mriedemthe connector is not returned back out of the API i don't think...01:25
mriedemfrom the attachment_specs table01:25
mriedemso idk what you'd want to do - either stop using attachment_specs altogether, and add a 'connector' column to the attachments table that is serialized json version of the connector dict you get from nova01:25
mriedemthat's what i'd do01:25
tommylikehumriedem:  yeah, jgriffith  will have the call01:26
mriedemyou could do an online data migration to migrate the existing data out of the attachment_specs table and into the new attachments.connector column01:26
mriedemvia the volume attachment object01:26
mriedemmigrate the data on read01:26
mriedemuse the new column on write01:26
tommylikehumriedem: will it looks like a little silly if we change the attachment_spec's text  column from string to text :)01:28
*** tsuzuki has joined #openstack-cinder01:28
tommylikehu'value' column01:28
mriedemtommylikehu: comment added https://bugs.launchpad.net/cinder/+bug/173772401:30
openstackLaunchpad bug 1737724 in Cinder "FC attachment issue" [High,Triaged]01:30
mriedemtommylikehu: string to text is not what i'm suggesting01:30
mriedemi would stop using the attachment_specs table altogether01:31
mriedemit's unnecessary01:31
mriedemjust store it in a text column in the attachments table as serialized json01:31
mriedemnothing is ever going to index this data01:31
mriedemi.e. you're not going to page volume attachments and filter on the connector blob :)01:31
mriedemunless you're crazy01:32
mriedemdefinitely a stop ship bug though for cinder01:32
tommylikehumriedem:  yeah, it exists for several days, I noticed this bug, but everyone is waiting for jgriffith's feedback01:33
mriedemif i weren't dealing with nova bugs of my own i could help write the fix for this01:35
*** namnh has joined #openstack-cinder01:37
tommylikehumriedem:  I will try to fix this if there is nobody pick  up the bug today01:37
*** ntpttr_laptop has quit IRC01:40
*** dalgaaf has quit IRC01:45
*** dalgaaf has joined #openstack-cinder01:47
*** lkwan has quit IRC01:47
*** lkwan has joined #openstack-cinder01:47
*** lkwan has quit IRC01:53
*** lkwan has joined #openstack-cinder01:53
openstackgerritTommyLike proposed openstack/python-cinderclient master: Backup create is not available from 3.0 to 3.42  https://review.openstack.org/52756801:56
openstackgerritMerged openstack/cinder master: Cleanup XtremIO IG cleanup note  https://review.openstack.org/52779501:59
*** kukacz has quit IRC02:00
*** kukacz has joined #openstack-cinder02:01
*** Apoorva has joined #openstack-cinder02:03
*** Apoorva has quit IRC02:09
*** itlinux has joined #openstack-cinder02:10
*** threestrands_ has joined #openstack-cinder02:22
*** threestrands_ has quit IRC02:22
*** threestrands_ has joined #openstack-cinder02:22
*** threestrands has quit IRC02:22
*** threestrands_ has quit IRC02:22
*** threestrands_ has joined #openstack-cinder02:23
*** threestrands_ has joined #openstack-cinder02:23
*** hoangcx has quit IRC02:29
*** moshele has joined #openstack-cinder02:29
*** salv-orl_ has joined #openstack-cinder02:29
*** hoangcx has joined #openstack-cinder02:29
openstackgerritFelipe Monteiro proposed openstack/cinder master: Fix volume image metadata endpoints raising None  https://review.openstack.org/52783802:31
*** threestrands_ has quit IRC02:32
*** liverpooler has quit IRC02:32
*** psachin has quit IRC02:32
*** abhishek has quit IRC02:32
*** openstackstatus has quit IRC02:32
*** salv-orlando has quit IRC02:32
*** bkopilov has quit IRC02:32
*** zhonghua has quit IRC02:32
*** jose-phillips has quit IRC02:32
*** zhaochao has quit IRC02:32
*** stakeda has quit IRC02:32
*** pooja_jadhav has quit IRC02:32
*** y_storshoo has quit IRC02:32
*** amrith has quit IRC02:32
*** ChanServ has quit IRC02:32
*** rmk has quit IRC02:32
*** ChanServ has joined #openstack-cinder02:34
*** barjavel.freenode.net sets mode: +o ChanServ02:34
*** lkwan is now known as 18WAAA39802:35
*** lkwan has joined #openstack-cinder02:36
*** threestrands_ has joined #openstack-cinder02:36
*** liverpooler has joined #openstack-cinder02:36
*** psachin has joined #openstack-cinder02:36
*** abhishek has joined #openstack-cinder02:36
*** openstackstatus has joined #openstack-cinder02:36
*** bkopilov has joined #openstack-cinder02:36
*** zhonghua has joined #openstack-cinder02:36
*** jose-phillips has joined #openstack-cinder02:36
*** zhaochao has joined #openstack-cinder02:36
*** stakeda has joined #openstack-cinder02:36
*** pooja_jadhav has joined #openstack-cinder02:36
*** y_storshoo has joined #openstack-cinder02:36
*** amrith has joined #openstack-cinder02:36
*** barjavel.freenode.net sets mode: +v openstackstatus02:36
*** rmk has joined #openstack-cinder02:36
*** zhurong has joined #openstack-cinder02:41
*** wanghao_ has joined #openstack-cinder02:46
*** wanghao has quit IRC02:46
*** liverpooler has quit IRC02:48
*** wanghao has joined #openstack-cinder02:51
*** wanghao_ has quit IRC02:55
*** gouthamr has quit IRC03:17
openstackgerritTommyLike proposed openstack/python-cinderclient master: Backup create is not available from 3.0 to 3.42  https://review.openstack.org/52756803:18
*** bkopilov has quit IRC03:20
*** armax has quit IRC03:21
*** markvoelker_ has quit IRC03:24
mriedemtommylikehu: has cinder dropped using shadow tables?03:27
mriedemor did cinder ever have shadow tables?03:27
*** Apoorva has joined #openstack-cinder03:31
tommylikehumriedem:  you want to fix this bug by using this? I have no idea on this history03:32
mriedemno, i'm just adding the migration script03:32
mriedemnova has shadow tables for archive deleted rows03:32
mriedembecause apparently we don't like to ever delete anything03:33
tommylikehumriedem:  ok03:33
*** zhurong has quit IRC03:34
*** lhx_ has joined #openstack-cinder03:35
*** lbragstad has quit IRC03:44
*** moshele has quit IRC03:55
*** armax has joined #openstack-cinder03:55
*** moshele has joined #openstack-cinder03:57
*** zhonghua has quit IRC04:00
*** zhonghua has joined #openstack-cinder04:01
*** tsuzuki has quit IRC04:02
*** owalsh_ has joined #openstack-cinder04:04
*** owalsh has quit IRC04:07
*** armax has quit IRC04:12
*** armax has joined #openstack-cinder04:13
*** armax has quit IRC04:13
*** armax has joined #openstack-cinder04:14
*** armax has quit IRC04:14
*** armax has joined #openstack-cinder04:14
*** moshele has quit IRC04:14
*** armax has quit IRC04:15
*** lhx__ has joined #openstack-cinder04:27
*** lhx_ has quit IRC04:27
openstackgerritBrin Zhang proposed openstack/cinder master: add enough notification for QoS  https://review.openstack.org/52248204:29
jgriffithmriedem: tommylikehu feel free to submit a patch04:35
mriedembe here in 30 seconds04:36
jgriffithtommylikehu: it would've been even better if you responded to my requests and tested your devices inparticular FC sometime over the past year04:36
mriedemjust got the test to pass04:36
jgriffithmriedem: awesome04:37
mriedemwell, pep8 so you're gonna have to wait04:39
mriedem20 seconds04:39
*** hoangcx has quit IRC04:40
*** namnh has quit IRC04:40
*** hoangcx has joined #openstack-cinder04:40
*** namnh has joined #openstack-cinder04:40
jgriffithmriedem: that's a small price to pay... and a fairly fast machine04:41
jgriffithmust be running fast8?04:41
mriedemyup04:41
mriedemhad to recreate the venv though04:41
openstackgerritMatt Riedemann proposed openstack/cinder master: Store host connector in volume_attachment.connector column  https://review.openstack.org/52785204:41
mriedemi don't do cinder code much04:41
mriedemtommylikehu: ^04:41
jgriffithmriedem: migrate the attachment-specs to your fancy new column?04:45
*** itlinux has quit IRC04:45
mriedemjgriffith: that's what _from_db_object does04:45
mriedemat runtime04:45
mriedemrather than during cinder-manage db sync04:46
*** pgadiya has joined #openstack-cinder04:46
jgriffithmriedem: well, don't you know all the fancy tricks!!04:46
jgriffith:)04:46
mriedemwill add a cli hook later04:46
mriedemtommy sprung this on me just a while ago and now it's past my bed time04:46
mriedemmaybe sprung is the wrong word04:47
mriedem"gave me the opportunity to try and help the cinder community"04:47
jgriffithmriedem: it's greatly appreciated by me and others I'm sure04:47
jgriffithincluding nikesh WRT his Kamanario driver04:47
*** bkopilov has joined #openstack-cinder04:48
mriedemleast i can do for the new flow stuff in nova04:48
mriedemalright ttyl04:49
*** mriedem has quit IRC04:49
jgriffithmriedem: good night, and thanks again!04:49
*** lhx__ has quit IRC04:51
pooja_jadhavtommylikehu:Hi04:51
*** abhi89 has joined #openstack-cinder04:58
*** abhishek has quit IRC05:00
*** lhx__ has joined #openstack-cinder05:18
*** adisky__ has joined #openstack-cinder05:18
*** abhishek has joined #openstack-cinder05:23
*** markvoelker has joined #openstack-cinder05:25
*** abhi89 has quit IRC05:25
*** links has joined #openstack-cinder05:35
*** chhavi has joined #openstack-cinder05:38
*** sapd has quit IRC05:38
*** sapd_ has joined #openstack-cinder05:38
*** lkuchlan has joined #openstack-cinder05:38
*** eandersson has quit IRC05:47
*** sticker has quit IRC05:49
openstackgerritXiaojun Liao proposed openstack/cinder master: Fix v3 api-ref for showing API details url error  https://review.openstack.org/52249205:49
*** markvoelker has quit IRC05:58
*** lkuchlan has quit IRC05:58
*** lkuchlan has joined #openstack-cinder05:59
openstackgerritGovardhan Chintha proposed openstack/cinder master: 3PAR: Update CHAP on host record when volume is migrated to new compute host  https://review.openstack.org/52741705:59
tommylikehumriedem, jgriffith  will try to fix this :)06:11
tommylikehupooja_jadhav:  hi06:11
tommylikehumriedem , oh!!! https://review.openstack.org/#/c/527852/06:12
*** links has quit IRC06:13
*** links has joined #openstack-cinder06:21
*** links has quit IRC06:21
*** lkuchlan has quit IRC06:23
*** lpetrut has joined #openstack-cinder06:24
*** Apoorva has quit IRC06:31
*** hoangcx has quit IRC06:41
*** namnh has quit IRC06:41
*** namnh has joined #openstack-cinder06:41
*** hoangcx has joined #openstack-cinder06:41
*** openstackgerrit has quit IRC06:47
*** threestrands_ has quit IRC06:53
*** markvoelker has joined #openstack-cinder06:55
*** Srinivas_ has joined #openstack-cinder06:58
*** sapd__ has joined #openstack-cinder07:07
*** sapd_ has quit IRC07:07
Srinivas_ildikov: Hi07:07
*** josecastroleon has joined #openstack-cinder07:07
*** e0ne has joined #openstack-cinder07:09
*** hoangcx has quit IRC07:14
*** namnh has quit IRC07:14
*** openstackgerrit has joined #openstack-cinder07:14
openstackgerrityixuan zhang proposed openstack/cinder master: Storwize: add hyperswap volume support  https://review.openstack.org/49241407:14
*** namnh has joined #openstack-cinder07:14
*** hoangcx has joined #openstack-cinder07:15
*** lkuchlan has joined #openstack-cinder07:20
*** lpetrut has quit IRC07:28
*** markvoelker has quit IRC07:30
*** felipemonteiro_ has joined #openstack-cinder07:31
*** lkuchlan has quit IRC07:32
*** armaan has quit IRC07:36
*** armaan has joined #openstack-cinder07:36
*** bkopilov has quit IRC07:37
*** moshele has joined #openstack-cinder07:38
openstackgerritGovardhan Chintha proposed openstack/cinder master: 3PAR: Update CHAP on host record when volume is migrated to new compute host  https://review.openstack.org/52741707:40
openstackgerritXiaojun Liao proposed openstack/cinder master: Fix v3 api-ref for showing API details url error  https://review.openstack.org/52249207:42
openstackgerritPooja Jadhav proposed openstack/python-cinderclient master: Removed unnecessary parameters from group and group_snapshots create APIs  https://review.openstack.org/52763707:43
openstackgerritShunei Shiono proposed openstack/cinder master: NEC driver: implement manage/unmanage functions.  https://review.openstack.org/52626807:48
*** lkuchlan has joined #openstack-cinder07:49
*** gkadam has joined #openstack-cinder07:50
*** bkopilov has joined #openstack-cinder07:53
*** gkadam has quit IRC07:55
openstackgerritXiaojun Liao proposed openstack/cinder master: Fix v3 api-ref for showing API details url error  https://review.openstack.org/52249208:01
*** felipemonteiro__ has joined #openstack-cinder08:03
*** daidv has joined #openstack-cinder08:04
*** felipemonteiro_ has quit IRC08:06
*** AlexeyAbashkin has joined #openstack-cinder08:09
*** alexchadin has joined #openstack-cinder08:13
*** rcernin has quit IRC08:15
*** s-shiono has quit IRC08:17
daidvHi all, can anybody let me know about that volume multi attach status of Cinder? thanks08:21
*** markvoelker has joined #openstack-cinder08:26
*** tesseract has joined #openstack-cinder08:28
tommylikehuhey daidv FYI: https://review.openstack.org/#/c/523608/08:29
daidvtommylikehu, thanks, that mean we have no way for multi attach for now, right? or is there any special backend have been supported multi attach?08:36
*** hoonetorg has quit IRC08:37
*** Srinivas_ has quit IRC08:39
*** zzzeek has quit IRC08:43
*** zzzeek has joined #openstack-cinder08:45
*** imran_ansari has joined #openstack-cinder08:46
*** links has joined #openstack-cinder08:52
*** pckizer_ has joined #openstack-cinder08:52
*** e0ne has quit IRC08:53
*** pckizer has quit IRC08:54
*** obre has quit IRC08:54
*** hoonetorg has joined #openstack-cinder08:55
*** obre has joined #openstack-cinder08:56
*** links has quit IRC08:57
*** markvoelker has quit IRC09:00
*** ociuhandu has joined #openstack-cinder09:08
*** amoralej|off is now known as amoralej09:09
*** alexchadin has quit IRC09:09
*** alexchadin has joined #openstack-cinder09:09
*** links has joined #openstack-cinder09:10
*** hamdyk has joined #openstack-cinder09:12
*** kwathore__ has joined #openstack-cinder09:12
openstackgerritJeremy Zhang proposed openstack/cinder master: [WIP] RBD: get manageable volumes  https://review.openstack.org/52790309:12
*** chhavi has quit IRC09:15
*** felipemonteiro__ has quit IRC09:16
kwathore__@Team, Please take out some time for reviwing patch:https://review.openstack.org/#/c/524185/09:16
*** bkopilov has quit IRC09:17
*** ociuhandu has quit IRC09:18
*** pgadiya has quit IRC09:22
*** ociuhandu has joined #openstack-cinder09:22
*** ociuhandu has quit IRC09:22
*** rcernin has joined #openstack-cinder09:23
*** pgadiya has joined #openstack-cinder09:24
*** owalsh_ is now known as owalsh09:28
*** yangyapeng has quit IRC09:29
*** yangyapeng has joined #openstack-cinder09:30
*** wanghao has quit IRC09:31
*** wanghao has joined #openstack-cinder09:32
openstackgerritPooja Jadhav proposed openstack/cinder master: V3 jsonschema validation: Group Snapshots  https://review.openstack.org/52452809:32
*** ganso has joined #openstack-cinder09:47
*** yangyapeng has quit IRC09:49
*** yangyapeng has joined #openstack-cinder09:49
*** ganso has quit IRC09:52
*** ganso has joined #openstack-cinder09:54
*** markvoelker has joined #openstack-cinder09:57
*** lpetrut has joined #openstack-cinder09:59
*** sdague has joined #openstack-cinder09:59
*** yangyapeng has quit IRC10:00
*** e0ne has joined #openstack-cinder10:07
*** bkopilov has joined #openstack-cinder10:09
*** namnh has quit IRC10:09
*** josecastroleon has quit IRC10:18
openstackgerritCiara Stacke proposed openstack/cinder master: VMAX driver - revert a volume to last snapshot  https://review.openstack.org/52065910:27
*** yangyapeng has joined #openstack-cinder10:28
*** markvoelker has quit IRC10:29
openstackgerritCiara Stacke proposed openstack/cinder master: VMAX driver - Fix error handling and checks for generic volume groups  https://review.openstack.org/52108010:30
openstackgerritCiara Stacke proposed openstack/cinder master: VMAX driver - Errors extending replicated volumes  https://review.openstack.org/52421510:31
openstackgerritSilvan Kaiser proposed openstack/cinder master: Adds Overlay Volumes Created from Snapshots to Quobyte  https://review.openstack.org/50705010:32
*** alexchadin has quit IRC10:32
*** alexchadin has joined #openstack-cinder10:33
*** sapd__ has quit IRC10:37
*** yangyapeng has quit IRC10:37
e0netommylikehu: hi. please, take a look on https://review.openstack.org/#/c/524185/10:38
e0netommylikehu: I'm ready to -2 on it because of time.sleep in unit tests10:38
*** yangyapeng has joined #openstack-cinder10:40
*** links has quit IRC10:43
*** sapd__ has joined #openstack-cinder10:51
*** alexchadin has quit IRC10:55
*** alexchadin has joined #openstack-cinder10:55
*** links has joined #openstack-cinder10:57
*** zzzeek has quit IRC11:05
*** _pewp_ has quit IRC11:08
*** hamdyk has quit IRC11:09
*** _pewp_ has joined #openstack-cinder11:09
*** AlexeyAbashkin has quit IRC11:10
*** AlexeyAbashkin has joined #openstack-cinder11:11
tommylikehue0ne:  thanks for your  reminder!11:11
*** armaan has quit IRC11:11
e0netommylikehu: np. just wanted to be on the same page with you11:11
tommylikehue0ne:  could you take a look at this one:) https://review.openstack.org/#/c/527568/11:12
tommylikehue0ne: :)11:12
*** armaan has joined #openstack-cinder11:12
*** zzzeek has joined #openstack-cinder11:12
e0netommylikehu: will do after the meeting11:12
*** armaan has quit IRC11:17
*** armaan has joined #openstack-cinder11:18
*** alexchadin has quit IRC11:18
*** wanghao_ has joined #openstack-cinder11:21
*** wanghao has quit IRC11:24
*** markvoelker has joined #openstack-cinder11:26
openstackgerritNeha Alhat proposed openstack/cinder master: V2/V3 jsonschema validation: snapshots  https://review.openstack.org/52793711:27
*** chhavi has joined #openstack-cinder11:31
*** linkmark has joined #openstack-cinder11:40
*** alexchadin has joined #openstack-cinder11:49
*** markvoelker has quit IRC12:00
openstackgerritDongdong Pei proposed openstack/cinder master: Fix starting cinder-api & cinder-scheduler failed.  https://review.openstack.org/52794412:01
*** amoralej is now known as amoralej|lunch12:02
*** sapd__ has quit IRC12:11
*** sapd__ has joined #openstack-cinder12:12
*** chhavi__ has joined #openstack-cinder12:14
*** chhavi has quit IRC12:15
*** dave-mccowan has joined #openstack-cinder12:21
*** dave-mcc_ has joined #openstack-cinder12:24
*** chhavi__ has quit IRC12:24
*** dave-mccowan has quit IRC12:25
*** chhavi__ has joined #openstack-cinder12:26
*** alexchadin has quit IRC12:27
openstackgerritYingzhe Zeng proposed openstack/cinder master: Huawei driver refactor  https://review.openstack.org/51412612:27
*** alexchadin has joined #openstack-cinder12:28
*** chhavi__ has quit IRC12:37
openstackgerritYingzhe Zeng proposed openstack/cinder master: Huawei driver refactor  https://review.openstack.org/51412612:41
*** psachin has quit IRC12:43
*** catintheroof has joined #openstack-cinder12:49
*** lhx__ has quit IRC12:51
*** markvoelker has joined #openstack-cinder12:57
*** mvenesio has joined #openstack-cinder13:01
*** bkopilov has quit IRC13:07
*** kaisers has quit IRC13:09
*** armaan has quit IRC13:13
*** lhx_ has joined #openstack-cinder13:15
*** kaisers has joined #openstack-cinder13:15
*** wanghao_ has quit IRC13:16
*** wanghao has joined #openstack-cinder13:16
*** wanghao has quit IRC13:17
*** wanghao has joined #openstack-cinder13:17
*** wanghao has quit IRC13:17
*** wanghao has joined #openstack-cinder13:18
*** wanghao has quit IRC13:18
*** wanghao has joined #openstack-cinder13:18
*** wanghao has quit IRC13:19
*** wanghao has joined #openstack-cinder13:19
*** wanghao has quit IRC13:20
*** wanghao has joined #openstack-cinder13:20
*** wanghao has quit IRC13:20
*** wanghao has joined #openstack-cinder13:21
*** wanghao has quit IRC13:21
*** wanghao has joined #openstack-cinder13:22
*** wanghao has quit IRC13:22
*** wanghao has joined #openstack-cinder13:23
*** liverpooler has joined #openstack-cinder13:23
openstackgerritAseel Awwad proposed openstack/cinder master: Check if already managed before manage snapshot  https://review.openstack.org/52795713:26
*** wanghao has quit IRC13:27
*** markvoelker has quit IRC13:28
*** markvoelker has joined #openstack-cinder13:28
*** imran_ansari has quit IRC13:31
*** mchlumsky has joined #openstack-cinder13:33
*** liverpooler has quit IRC13:35
*** liverpooler has joined #openstack-cinder13:35
*** chhavi has joined #openstack-cinder13:36
*** edmondsw has joined #openstack-cinder13:37
*** abhishekk has joined #openstack-cinder13:37
*** mchlumsky has quit IRC13:39
*** mchlumsky has joined #openstack-cinder13:40
*** amoralej|lunch is now known as amoralej13:46
*** mriedem has joined #openstack-cinder13:51
dulekHi guys! Anyone knows the status of Ironic-Cinder integration?13:56
*** dustins has joined #openstack-cinder13:57
*** rcernin has quit IRC13:59
e0nedulek: hi. AFAIK, ironic team has some progress on it14:01
e0nedulek: they don't need anything special from cinder14:01
duleke0ne: https://blueprints.launchpad.net/nova/+spec/ironic-boot-from-volume - I see this as implemented, so it might work. :)14:02
e0ne:)14:02
*** pgadiya has quit IRC14:04
*** dosaboy has quit IRC14:04
*** lkuchlan has quit IRC14:05
*** armaan has joined #openstack-cinder14:05
*** dosaboy has joined #openstack-cinder14:10
mriedemtommylikehu: good point on https://review.openstack.org/#/c/527852/ - i thought about that when i couldn't sleep last night :)14:11
mriedemi'll audit where we're getting attachment specs and see if we need to use the volume attachment object now to get the connector14:11
openstackgerritGovardhan Chintha proposed openstack/cinder master: 3PAR: Update CHAP on host record when volume is migrated to new compute host  https://review.openstack.org/52741714:16
*** erlon has joined #openstack-cinder14:17
*** gouthamr has joined #openstack-cinder14:24
tommylikehuhey mriedem , I audited all the methods related the attachment spec , that seems the only place we need to consider this time (I could be wrong), btw how can you fix this in such a short time :)14:26
openstackgerritMerged openstack/cinder master: V3 jsonschema validation: Volume metadata  https://review.openstack.org/52660614:26
mriedemtommylikehu: lots of amphetamine14:37
openstackgerritGoutham Pacha Ravi proposed openstack/cinder master: NetApp ONTAP: Copy offload bugfix  https://review.openstack.org/52776214:37
* mriedem makes a little drug abuse joke14:38
*** yangyapeng has quit IRC14:38
tommylikehumriedem:  lol14:39
*** sapd__ has quit IRC14:41
*** alexchadin has quit IRC14:46
*** armaan has quit IRC14:49
*** lbragstad has joined #openstack-cinder14:50
openstackgerritLee Yarwood proposed openstack/cinder master: WIP rbd: Allow for the creation of encrypted volumes  https://review.openstack.org/52797914:50
*** xyang1 has joined #openstack-cinder14:50
*** armaan has joined #openstack-cinder14:50
*** abhishekk has quit IRC14:53
*** markstur has joined #openstack-cinder14:54
*** yangyapeng has joined #openstack-cinder14:56
*** jmlowe_ has joined #openstack-cinder14:59
*** jmlowe has quit IRC15:00
*** yangyapeng has quit IRC15:02
*** jmlowe has joined #openstack-cinder15:04
*** jmlowe_ has quit IRC15:06
*** felipemonteiro__ has joined #openstack-cinder15:13
*** yangyapeng has joined #openstack-cinder15:14
*** r-daneel has joined #openstack-cinder15:16
*** felipemonteiro__ has quit IRC15:17
*** yangyapeng has quit IRC15:18
*** itlinux has joined #openstack-cinder15:19
openstackgerritJeremy Zhang proposed openstack/cinder master: Fix for getting manageable volume in cinder/volume/manager.py  https://review.openstack.org/52798815:20
*** itlinux has quit IRC15:22
*** felipemonteiro__ has joined #openstack-cinder15:25
*** felipemonteiro_ has joined #openstack-cinder15:26
*** links has quit IRC15:26
*** Sanatics has joined #openstack-cinder15:29
*** felipemonteiro__ has quit IRC15:30
*** moshele has quit IRC15:30
*** yangyapeng has joined #openstack-cinder15:36
*** yangyapeng has quit IRC15:40
openstackgerritEric Harney proposed openstack/cinder master: qemu-img info --force-share for NFS driver  https://review.openstack.org/51878215:42
*** imran_ansari has joined #openstack-cinder15:44
*** armax has joined #openstack-cinder15:47
*** yangyapeng has joined #openstack-cinder15:56
*** Sanatics has quit IRC15:56
*** vivsoni__ has joined #openstack-cinder15:57
*** markstur has quit IRC15:59
*** catintheroof has quit IRC16:00
*** catintheroof has joined #openstack-cinder16:00
*** yangyapeng has quit IRC16:01
*** armaan has quit IRC16:04
*** armaan has joined #openstack-cinder16:05
*** markstur has joined #openstack-cinder16:05
*** catintheroof has quit IRC16:05
*** jdillaman has joined #openstack-cinder16:07
*** lhx__ has joined #openstack-cinder16:09
*** abhishek has quit IRC16:09
*** lhx_ has quit IRC16:12
*** yangyapeng has joined #openstack-cinder16:17
*** yangyapeng has quit IRC16:21
*** itlinux has joined #openstack-cinder16:21
*** itlinux has quit IRC16:28
*** armaan has quit IRC16:33
*** armaan has joined #openstack-cinder16:33
*** hoonetorg has quit IRC16:35
*** Apoorva has joined #openstack-cinder16:36
*** yangyapeng has joined #openstack-cinder16:37
*** e0ne has quit IRC16:38
*** moshele has joined #openstack-cinder16:39
*** yangyapeng has quit IRC16:41
*** hoonetorg has joined #openstack-cinder16:48
*** yangyapeng has joined #openstack-cinder16:58
*** ntpttr_laptop has joined #openstack-cinder16:59
*** xyang1 has quit IRC17:01
*** yangyapeng has quit IRC17:03
*** edmondsw has quit IRC17:06
*** edmondsw has joined #openstack-cinder17:06
*** imran_ansari has quit IRC17:07
*** chhavi has quit IRC17:07
*** edmondsw_ has joined #openstack-cinder17:10
*** edmondsw has quit IRC17:11
*** lpetrut has quit IRC17:14
*** edmondsw_ has quit IRC17:14
openstackgerritMerged openstack/cinder master: V3 jsonschema validation: Group type specs  https://review.openstack.org/52028517:17
*** yangyapeng has joined #openstack-cinder17:18
*** imran_ansari has joined #openstack-cinder17:19
*** markstur_ has joined #openstack-cinder17:19
*** markstur has quit IRC17:22
*** edmondsw has joined #openstack-cinder17:22
*** AlexeyAbashkin has quit IRC17:23
openstackgerritMerged openstack/python-cinderclient master: Removed unnecessary parameters from group and group_snapshots create APIs  https://review.openstack.org/52763717:23
*** yangyapeng has quit IRC17:24
*** edmondsw has quit IRC17:25
*** crose has joined #openstack-cinder17:27
*** lhx__ has quit IRC17:32
openstackgerritImran Ansari proposed openstack/cinder master: 3PAR - Fix temp snapshot that remains post online copy  https://review.openstack.org/52418517:34
*** Apoorva has quit IRC17:36
*** mdbooth has quit IRC17:37
*** edmondsw has joined #openstack-cinder17:40
*** mdbooth has joined #openstack-cinder17:40
*** felipemonteiro_ has quit IRC17:43
*** logan- has quit IRC17:44
*** crushil has joined #openstack-cinder17:44
*** logan- has joined #openstack-cinder17:45
*** adrianofr has joined #openstack-cinder17:48
openstackgerritMerged openstack/cinder master: Migrate fixed_key encryption keys to Barbican  https://review.openstack.org/52472017:49
*** moshele has quit IRC17:50
*** jmlowe has quit IRC17:51
*** edmondsw has quit IRC17:53
*** tesseract has quit IRC17:53
*** edmondsw has joined #openstack-cinder17:54
*** xyang1 has joined #openstack-cinder17:55
*** catintheroof has joined #openstack-cinder17:57
*** xyang1 has quit IRC17:59
*** Apoorva has joined #openstack-cinder18:03
*** Apoorva has quit IRC18:03
*** Apoorva has joined #openstack-cinder18:03
*** edmondsw has quit IRC18:14
*** rmcall has joined #openstack-cinder18:16
*** edmondsw has joined #openstack-cinder18:21
openstackgerritMatt Riedemann proposed openstack/cinder master: WIP: Don't call driver.terminate_connection if there is no connector  https://review.openstack.org/52802818:23
mriedemvivsoni__: ^ needs tests18:23
*** gouthamr has quit IRC18:24
*** edmondsw has quit IRC18:25
*** itlinux has joined #openstack-cinder18:26
*** edmondsw has joined #openstack-cinder18:27
*** harlowja has joined #openstack-cinder18:29
*** edmondsw has quit IRC18:32
*** stvnoyes has joined #openstack-cinder18:32
*** edmondsw has joined #openstack-cinder18:33
*** imacdonn_ has quit IRC18:35
*** imacdonn_ has joined #openstack-cinder18:35
*** crushil has quit IRC18:36
*** gouthamr has joined #openstack-cinder18:37
*** crushil has joined #openstack-cinder18:37
*** edmondsw has quit IRC18:37
*** edmondsw has joined #openstack-cinder18:39
*** edmondsw has quit IRC18:43
*** edmondsw has joined #openstack-cinder18:45
*** AlexeyAbashkin has joined #openstack-cinder18:47
*** amoralej is now known as amoralej|off18:48
*** ntpttr_laptop has quit IRC18:51
*** AlexeyAbashkin has quit IRC18:52
*** ntpttr_laptop has joined #openstack-cinder18:52
*** armaan has quit IRC18:56
*** felipemonteiro_ has joined #openstack-cinder18:56
*** armaan has joined #openstack-cinder18:56
*** itlinux has quit IRC18:57
*** felipemonteiro__ has joined #openstack-cinder18:58
*** mvk has quit IRC19:00
*** mvk has joined #openstack-cinder19:01
*** felipemonteiro_ has quit IRC19:02
openstackgerritMatt Riedemann proposed openstack/cinder master: Don't call driver.terminate_connection if there is no connector  https://review.openstack.org/52802819:03
mriedemerlon: you're looking for ^19:05
mriedemfor that terminate_connection thing19:05
mriedemhttp://logs.openstack.netapp.com/logs/52/527852/1/upstream-check/cinder-cDOT-iSCSI/11e9870/logs/screen-c-vol.txt.gz?level=ERROR19:05
mriedemdifferent bug19:05
*** dustins has quit IRC19:06
*** catintheroof has quit IRC19:06
*** xyang has joined #openstack-cinder19:10
*** tomh__ has quit IRC19:11
*** adisky__ has quit IRC19:11
*** jmlowe has joined #openstack-cinder19:12
*** edmondsw has quit IRC19:12
*** edmondsw has joined #openstack-cinder19:13
*** vivsoni__ has quit IRC19:13
*** openstack has joined #openstack-cinder20:34
*** ChanServ sets mode: +o openstack20:34
*** yangyapeng has quit IRC20:34
*** crose has joined #openstack-cinder20:35
*** edmondsw has quit IRC20:36
*** lpetrut has joined #openstack-cinder20:38
*** e0ne has quit IRC20:43
*** e0ne has joined #openstack-cinder20:44
*** e0ne has quit IRC20:45
*** jmlowe has joined #openstack-cinder20:45
*** AlexeyAbashkin has joined #openstack-cinder20:46
*** gouthamr has quit IRC20:47
*** liverpooler has quit IRC20:47
*** yangyapeng has joined #openstack-cinder20:50
*** AlexeyAbashkin has quit IRC20:51
*** rmcall has quit IRC20:54
*** yangyapeng has quit IRC20:55
openstackgerritAseel Awwad proposed openstack/cinder master: Check if already managed before manage snapshot  https://review.openstack.org/52795720:55
*** crushil has quit IRC21:05
*** mchlumsky has quit IRC21:07
*** SamYaple has quit IRC21:07
*** SamYaple has joined #openstack-cinder21:08
openstackgerritSean McGinnis proposed openstack/cinder master: Correct documented service upgrade order  https://review.openstack.org/52808421:08
*** openstack has joined #openstack-cinder21:14
*** ChanServ sets mode: +o openstack21:14
*** yangyapeng has quit IRC21:15
*** SamYaple has quit IRC21:22
*** SamYaple has joined #openstack-cinder21:23
*** crose has quit IRC21:27
mnaserjgriffith: smcginnis ill check the permissions and see if thats the reason21:29
smcginnismnaser: If that is it, we should probably get some better documentation added for that backend driver.21:30
*** yangyapeng has joined #openstack-cinder21:30
*** threestrands has joined #openstack-cinder21:31
*** threestrands has quit IRC21:31
*** threestrands has joined #openstack-cinder21:31
*** yangyapeng has quit IRC21:35
mnasersmcginnis: yeah, bummer is that the ceph user for cinder has access to the pool21:38
mnaserso that means we're back to the drawing board21:38
smcginnismnaser: Shoot. Maybe jbernard or eharney will show up with some tips.21:39
mnaserits doing a create almost every 2 seconds21:40
mnaseri just wonder if it's blocking soemhow somewhere21:40
smcginnismnaser: Still not ideal, but you could at least make sure image_volume_cache_enabled is true.21:41
mnasersmcginnis: if my brain parser of the code is operating, i dont think it uses image volume cache if it can clone it21:41
smcginnismnaser: It would still download the image unnecessarily, but at least it would just be once.21:41
smcginnismnaser: Hmm, maybe. It's been awhile for me since I've looked at that part.21:42
*** gouthamr has joined #openstack-cinder21:43
*** erlon has joined #openstack-cinder21:46
*** gouthamr_ has joined #openstack-cinder21:46
*** sticker has joined #openstack-cinder21:46
*** gouthamr has quit IRC21:48
*** armaan has quit IRC21:48
*** yangyapeng has joined #openstack-cinder21:52
*** yangyapeng has quit IRC21:57
*** rcernin has joined #openstack-cinder21:58
*** crushil has joined #openstack-cinder21:59
*** crushil_ has joined #openstack-cinder22:00
*** xyang has quit IRC22:02
*** crushil has quit IRC22:04
*** gouthamr_ is now known as gouthamr22:04
*** diablo_rojo has quit IRC22:04
jgriffiththe whole thing about Ceph is it shouldn't download anything, just does the internal copy stuff and done22:05
*** mvenesio has quit IRC22:05
mnaserwoo22:07
mnaserthink we found a cinder bug22:07
*** diablo_rojo has joined #openstack-cinder22:07
mnaserDeadlock detected when running 'quota_reserve': Retrying...22:07
mriedemhttps://github.com/openstack/nova/blob/stable/pike/nova/db/sqlalchemy/api.py#L382122:11
mriedemyeah you'll probably want a retry decorator there22:11
mnasermriedem: its in cinder (and its retrying forever i guess)22:17
*** Apoorva has quit IRC22:17
smcginnisHmm, we had a patch for something similar lately. Let me see if I can track that down.22:17
mnaserhttps://github.com/openstack/cinder/blob/stable/pike/cinder/db/sqlalchemy/api.py#L114422:17
*** ChanServ has quit IRC22:17
mriedemmnaser: that's because it's using a super super super old version of that decorator from when cinder was nova-volume22:17
mriedem:)22:17
mriedemthere is an oslo.db decorator for this22:17
mriedemwhich limits the max number of retries22:17
mnaseri figured just as much22:17
mnaseri think they're just looping forever now22:18
mriedem@oslo_db_api.wrap_db_retry(max_retries=5, retry_on_deadlock=True)22:18
mnasermax_retries=5 is probably healthier22:18
mriedemyeah there is no limit here https://github.com/openstack/cinder/blob/stable/pike/cinder/db/sqlalchemy/api.py#L24422:18
mriedemthis seems like a task for a part time contributor22:18
mriedemis that me?!22:18
mriedemcould it be possible for me to have 3 active cinder patches at one time22:19
mnaserheh22:19
*** yangyapeng has joined #openstack-cinder22:19
mriedemmnaser: open a bug22:19
mriedemplease22:19
mnasermriedem: sure one sec22:19
smcginnismriedem: I can grab it if you want. But feel free to continue. :)22:20
smcginnismriedem: This is the newer retry decorator? oslo_db_api.wrap_db_retry(max_retries=5, retry_on_deadlock=True)22:21
mnaserhttps://bugs.launchpad.net/cinder/+bug/173829222:21
openstackLaunchpad bug 1738292 in Cinder "Deadlocked queries retry forever" [Undecided,New]22:21
smcginnismriedem: By your silence I am assuming you are busy making that change, but if not, let me know.22:24
*** yangyapeng has quit IRC22:24
*** ChanServ has joined #openstack-cinder22:24
*** barjavel.freenode.net sets mode: +o ChanServ22:24
*** gouthamr has quit IRC22:28
*** ChanServ has quit IRC22:28
*** moshele has quit IRC22:30
*** ChanServ has joined #openstack-cinder22:31
*** barjavel.freenode.net sets mode: +o ChanServ22:31
*** e0ne has joined #openstack-cinder22:33
*** yangyapeng has joined #openstack-cinder22:37
mriedemsmcginnis: go for it22:38
mriedem and that's that the new (old now) decorator22:38
*** yangyapeng has quit IRC22:42
openstackgerritSean McGinnis proposed openstack/cinder master: Switch to oslo_db retry decorator  https://review.openstack.org/52810722:42
smcginnismnaser: I will propose that for backport after it lands. ^22:44
mnaserthank you so much22:44
smcginnismnaser: You and mriedem made it pretty easy. ;)22:44
*** xyang has joined #openstack-cinder22:47
*** felipemonteiro_ has joined #openstack-cinder22:50
*** xyang has quit IRC22:53
*** felipemonteiro__ has quit IRC22:53
*** dustins has quit IRC22:55
*** felipemonteiro_ has quit IRC22:56
*** yangyapeng has joined #openstack-cinder22:59
*** e0ne has quit IRC22:59
*** crushil_ has quit IRC23:01
*** yangyapeng has quit IRC23:04
*** threestrands_ has joined #openstack-cinder23:10
*** threestrands has quit IRC23:13
*** felipemonteiro_ has joined #openstack-cinder23:14
*** masuberu has quit IRC23:15
*** yangyapeng has joined #openstack-cinder23:19
*** lpetrut has quit IRC23:21
*** ntpttr_laptop has quit IRC23:22
*** yangyapeng has quit IRC23:24
*** moshele has joined #openstack-cinder23:27
*** stakeda has quit IRC23:28
*** harlowja has quit IRC23:32
*** felipemonteiro_ has quit IRC23:35
*** dave-mcc_ has quit IRC23:37
*** Apoorva has joined #openstack-cinder23:38
*** harlowja has joined #openstack-cinder23:39
*** yangyapeng has joined #openstack-cinder23:40
*** harlowja has quit IRC23:40
*** harlowja has joined #openstack-cinder23:42
*** yangyapeng has quit IRC23:44
*** harlowja has quit IRC23:50
*** lennyb has quit IRC23:51
*** ntpttr_laptop has joined #openstack-cinder23:54
*** erlon has quit IRC23:55
*** stakeda has joined #openstack-cinder23:56

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!