Monday, 2017-12-04

*** stakeda has quit IRC00:00
*** itlinux has joined #openstack-cinder00:03
*** sticker_ is now known as sticker00:08
*** yangyapeng has quit IRC00:16
*** yangyapeng has joined #openstack-cinder00:16
*** yangyapeng has quit IRC00:21
*** wanghao has joined #openstack-cinder00:25
*** abhitechie has joined #openstack-cinder00:26
*** david-lyle has joined #openstack-cinder00:30
*** david-lyle has quit IRC00:31
*** david-lyle has joined #openstack-cinder00:31
*** cheneydc has joined #openstack-cinder00:33
*** salv-orlando has joined #openstack-cinder00:44
*** jmlowe has joined #openstack-cinder00:47
*** wanghao has quit IRC00:48
*** salv-orlando has quit IRC00:49
*** wanghao has joined #openstack-cinder00:49
*** yangyapeng has joined #openstack-cinder00:58
*** psachin has joined #openstack-cinder00:59
*** yangyapeng has quit IRC01:03
*** yangyapeng has joined #openstack-cinder01:08
openstackgerritTommyLike proposed openstack/python-cinderclient master: Remove 'end_version' parameter in backup update  https://review.openstack.org/52443201:17
*** edmondsw has joined #openstack-cinder01:19
*** zhaochao has joined #openstack-cinder01:20
*** edmondsw has quit IRC01:24
*** yangyapeng has quit IRC01:27
*** wanghao has quit IRC01:28
*** yangyapeng has joined #openstack-cinder01:28
*** wanghao has joined #openstack-cinder01:28
openstackgerritPeter Wang proposed openstack/cinder master: VNX: Fix cloning failure when system is busy  https://review.openstack.org/52000601:32
tommylikehuhey jungleboyj , could you take a look when you free? https://review.openstack.org/#/c/516175/01:33
*** jmlowe has quit IRC01:44
*** salv-orlando has joined #openstack-cinder01:45
*** salv-orlando has quit IRC01:49
*** dhinesh has joined #openstack-cinder01:51
*** gmann_afk is now known as gmann01:54
*** _dalgaaf has quit IRC02:06
*** dalgaaf has joined #openstack-cinder02:06
openstackgerritTommyLike proposed openstack/cinder master: Add cg policies and clean up old policy handling  https://review.openstack.org/52473302:09
*** Apoorva has quit IRC02:23
jungleboyjtommylikehu: will do.02:27
*** salv-orlando has joined #openstack-cinder02:45
*** salv-orlando has quit IRC02:50
*** dhinesh has quit IRC03:01
*** dhinesh has joined #openstack-cinder03:01
*** abhitechie has quit IRC03:04
*** abhitechie has joined #openstack-cinder03:05
*** abhitechie has quit IRC03:06
*** abhitechie has joined #openstack-cinder03:06
*** edmondsw has joined #openstack-cinder03:07
*** edmondsw has quit IRC03:12
*** cheneydc has quit IRC03:14
openstackgerritTommyLike proposed openstack/python-cinderclient master: Bump Max version to 3.46  https://review.openstack.org/52503503:30
*** itlinux has quit IRC03:32
*** edmondsw has joined #openstack-cinder03:32
openstackgerritTommyLike proposed openstack/python-cinderclient master: Bump Max version to 3.46  https://review.openstack.org/52503503:35
*** edmondsw has quit IRC03:36
tommylikehujungleboyj:  on my way to the rest two versions(3.45 3.46) , guess you are waiting for them two:)03:37
jungleboyjYes.  :-)  Appreciate any help you can give to get those done.03:38
*** chhavi has joined #openstack-cinder03:40
jungleboyjtommylikehu:  Do you want me to merge the one for 3.47 and then you will do the 3.45 one ASAP.03:41
jungleboyjI don't think there is anything for 3.46 required, is there?03:41
tommylikehujungleboyj:  appreciated if you can merge them start from 3.45.....03:42
jungleboyjWhere is the patch for 3.45?03:43
tommylikehuwill ping you when done:)03:43
jungleboyjOk, sounds good.  So I am just holding on 3.47 until that one is done.03:44
tommylikehujungleboyj:  yes, and the empty patch for 3.4603:45
tommylikehuhttps://review.openstack.org/52503503:46
*** salv-orlando has joined #openstack-cinder03:46
jungleboyjtommylikehu:  Ok, yeah, probably not a bad idea to do that one as well for completeness.03:48
*** salv-orlando has quit IRC03:51
vivsoni_Hi Jay, if time permits can you please review https://review.openstack.org/#/c/524161/03:52
vivsoni_Its a cherry picked from stable/pike03:52
vivsoni_This fixes the zuul check failure... and this is blocking us to make code changes in stable/ocata03:53
jungleboyjOk, normally Ocata would be closed but that sounds like a critical fix.04:08
*** _alastor_ has quit IRC04:10
*** _alastor__ is now known as _alastor_04:10
*** _alastor__ has joined #openstack-cinder04:12
*** links has joined #openstack-cinder04:13
*** jmlowe has joined #openstack-cinder04:17
*** abhinavtechie has joined #openstack-cinder04:29
*** abhitechie has quit IRC04:30
*** adisky_ has joined #openstack-cinder04:31
vivsoni_Thanks Jay :)04:31
vivsoni_Hi Team, please review https://review.openstack.org/#/c/524161/04:32
*** itlinux has joined #openstack-cinder04:39
*** salv-orlando has joined #openstack-cinder04:47
openstackgerritVivek Soni proposed openstack/cinder master: 3PAR - Fix temp snapshot that remains post online copy  https://review.openstack.org/52418504:47
*** salv-orlando has quit IRC04:52
*** edmondsw has joined #openstack-cinder04:58
*** jmlowe has quit IRC05:02
*** edmondsw has quit IRC05:03
*** dhinesh has quit IRC05:10
*** gcb has joined #openstack-cinder05:11
*** kwathore has joined #openstack-cinder05:12
*** abhinavtechie has quit IRC05:13
*** markstur has joined #openstack-cinder05:21
*** markstur_ has joined #openstack-cinder05:21
*** markstur has quit IRC05:25
*** yikun has quit IRC05:26
*** itlinux has quit IRC05:28
*** zhurong has joined #openstack-cinder05:31
*** andymccr has quit IRC05:32
*** andymccr has joined #openstack-cinder05:33
openstackgerritShay Halsband proposed openstack/cinder master: XtremIO: optional clean IG with no mappings  https://review.openstack.org/51539205:33
*** pgadiya has joined #openstack-cinder05:40
*** pgadiya has quit IRC05:40
*** lkuchlan_wfh has joined #openstack-cinder05:41
*** salv-orlando has joined #openstack-cinder05:48
*** abhitechie has joined #openstack-cinder05:48
*** moshele has joined #openstack-cinder05:51
*** ntpttr_laptop has joined #openstack-cinder05:51
*** salv-orlando has quit IRC05:53
openstackgerritLiron Kuchlani proposed openstack/cinder master: Add test for volume create with non-ascii characters  https://review.openstack.org/52494605:59
*** markstur_ has quit IRC06:09
*** sticker_ has joined #openstack-cinder06:10
*** sticker has quit IRC06:13
openstackgerritLiron Kuchlani proposed openstack/cinder master: Add test for volume create with non-ascii characters  https://review.openstack.org/52494606:13
*** sticker_ has quit IRC06:14
*** ntpttr_laptop has quit IRC06:21
*** salv-orlando has joined #openstack-cinder06:40
openstackgerritAbhishek Sharma M proposed openstack/cinder master: Removed gb quota decrement in grp snapshot delete  https://review.openstack.org/52507106:42
*** edmondsw has joined #openstack-cinder06:46
*** gkadam_ has quit IRC06:47
*** edmondsw has quit IRC06:51
openstackgerritPooja Jadhav proposed openstack/cinder master: V3 jsonschema validation: Group types  https://review.openstack.org/52507706:52
*** zhurong has quit IRC06:57
openstackgerritPooja Jadhav proposed openstack/cinder master: V3 jsonschema validation: Group types  https://review.openstack.org/51964306:57
*** pooja_jadhav has joined #openstack-cinder07:00
*** seitan has joined #openstack-cinder07:01
*** abhitechie has quit IRC07:01
*** abhitechie has joined #openstack-cinder07:06
*** zhurong has joined #openstack-cinder07:20
*** Brin has joined #openstack-cinder07:21
*** yikun has joined #openstack-cinder07:28
*** rcernin has quit IRC07:49
*** abhitechie has quit IRC08:01
*** e0ne has joined #openstack-cinder08:12
*** tesseract has joined #openstack-cinder08:13
*** gkadam_ has joined #openstack-cinder08:15
*** AlexeyAbashkin has joined #openstack-cinder08:16
*** zhurong has quit IRC08:20
*** pcaruana has joined #openstack-cinder08:24
*** abhitechie has joined #openstack-cinder08:25
*** kwathore has quit IRC08:28
*** salv-orlando has quit IRC08:32
*** salv-orlando has joined #openstack-cinder08:32
*** edmondsw has joined #openstack-cinder08:35
*** rcernin has joined #openstack-cinder08:35
*** salv-orlando has quit IRC08:36
*** edmondsw has quit IRC08:40
*** kwathore has joined #openstack-cinder08:43
*** salv-orlando has joined #openstack-cinder08:50
*** e0ne has quit IRC08:50
*** armaan has joined #openstack-cinder08:59
*** zhurong has joined #openstack-cinder09:03
*** mvk has joined #openstack-cinder09:05
*** Guest13268 is now known as zigo09:09
*** hamdyk has joined #openstack-cinder09:25
*** lkuchlan_wfh has quit IRC09:27
*** armaan has quit IRC09:31
*** alexchadin has joined #openstack-cinder09:32
*** armaan has joined #openstack-cinder09:33
*** moshele has quit IRC09:42
*** lkuchlan_wfh has joined #openstack-cinder09:48
*** ganso has joined #openstack-cinder09:49
*** lkuchlan_wfh has quit IRC09:59
openstackgerritTommyLike proposed openstack/python-cinderclient master: Support list with `count` in client  https://review.openstack.org/52512009:59
openstackgerritTommyLike proposed openstack/python-cinderclient master: Support list with 'with_count' in client  https://review.openstack.org/52512010:01
openstackgerritTommyLike proposed openstack/python-cinderclient master: Support list with 'with_count' in client  https://review.openstack.org/52512010:04
*** hamdyk has quit IRC10:04
openstackgerritAmit Oren proposed openstack/cinder master: INFINIDAT: change CI_WIKI_NAME  https://review.openstack.org/52512110:05
*** alexchadin has quit IRC10:05
*** wanghao has quit IRC10:10
*** alexchadin has joined #openstack-cinder10:13
openstackgerritChhavi Agarwal proposed openstack/cinder master: Remove skip_validation_flag to False by default  https://review.openstack.org/52409110:24
*** zhurong has quit IRC10:26
openstackgerritShunei Shiono proposed openstack/cinder master: NEC driver: delete an unused configuration parameter.  https://review.openstack.org/52338210:29
*** mvk has quit IRC10:40
*** armaan has quit IRC10:45
*** gmann is now known as gmann_afk10:52
*** armaan has joined #openstack-cinder10:54
*** armaan has quit IRC10:57
*** e0ne has joined #openstack-cinder11:01
*** seitan has quit IRC11:05
*** armaan has joined #openstack-cinder11:06
*** Brin has quit IRC11:07
*** mvk has joined #openstack-cinder11:09
*** alexchadin has quit IRC11:19
*** alexchadin has joined #openstack-cinder11:20
*** alexchadin has quit IRC11:30
*** alexchadin has joined #openstack-cinder11:30
*** finucannot is now known as stephenfin11:31
*** moshele has joined #openstack-cinder11:40
*** lkuchlan_wfh has joined #openstack-cinder11:43
*** lpetrut has joined #openstack-cinder11:46
*** yangyapeng has quit IRC12:02
*** yangyape_ has joined #openstack-cinder12:06
*** gcb has quit IRC12:10
*** yangyape_ has quit IRC12:11
*** edmondsw has joined #openstack-cinder12:11
TahvokHey guys!12:13
TahvokTrying to understand: https://docs.openstack.org/ha-guide/storage-ha-block.html12:13
TahvokIs it still relevant for ocata?12:13
*** edmondsw has quit IRC12:16
*** lpetrut has quit IRC12:17
*** armaan has quit IRC12:20
*** armaan has joined #openstack-cinder12:20
*** chhavi has quit IRC12:23
*** abhitechie has quit IRC12:25
*** lpetrut has joined #openstack-cinder12:25
*** abhitechie has joined #openstack-cinder12:29
*** rcernin has quit IRC12:31
*** yangyapeng has joined #openstack-cinder12:36
*** alexchadin has quit IRC12:44
*** links has quit IRC12:54
*** abhitechie has quit IRC13:02
*** abhitechie has joined #openstack-cinder13:02
*** abishop has joined #openstack-cinder13:06
*** alexchadin has joined #openstack-cinder13:07
*** salv-orlando has quit IRC13:07
*** salv-orlando has joined #openstack-cinder13:08
*** salv-orlando has quit IRC13:12
*** niedbalski_ is now known as niedbalski13:13
*** niedbalski has quit IRC13:13
*** niedbalski has joined #openstack-cinder13:13
*** edmondsw has joined #openstack-cinder13:23
*** armaan has quit IRC13:29
*** armaan has joined #openstack-cinder13:30
*** links has joined #openstack-cinder13:31
*** armaan has quit IRC13:32
*** armaan has joined #openstack-cinder13:33
*** wN has quit IRC13:35
*** markstur has joined #openstack-cinder13:37
*** wN has joined #openstack-cinder13:37
*** wN has quit IRC13:37
*** wN has joined #openstack-cinder13:37
*** markstur has quit IRC13:42
*** edmondsw has quit IRC13:43
*** chhavi has joined #openstack-cinder13:43
amitoour CI job gets a 502 bad gateway on upload_image (as u can see here: https://openstack-ci-logs.aws.infinidat.com/21/525121/1/check/dsvm-tempest-infinibox-fc/0fcf0cb/logs/devstacklog.txt.gz). Any ideas?13:44
*** itlinux has joined #openstack-cinder13:50
*** abhitechie has quit IRC13:52
*** liverpooler has joined #openstack-cinder14:02
*** lhx_ has joined #openstack-cinder14:06
*** salv-orlando has joined #openstack-cinder14:08
*** dustins has joined #openstack-cinder14:09
*** salv-orlando has quit IRC14:13
*** felipemonteiro has joined #openstack-cinder14:15
*** felipemonteiro_ has joined #openstack-cinder14:16
*** felipemonteiro has quit IRC14:20
*** alexchadin has quit IRC14:22
*** gcb has joined #openstack-cinder14:27
*** gouthamr has joined #openstack-cinder14:52
*** psachin has quit IRC14:53
*** lkuchlan_wfh has quit IRC14:53
*** salv-orlando has joined #openstack-cinder14:57
*** ik__ has joined #openstack-cinder15:01
ik__how do I execute functional tests of cinder?15:01
*** lkuchlan_wfh has joined #openstack-cinder15:03
*** mchlumsky has joined #openstack-cinder15:03
*** _alastor_ has left #openstack-cinder15:06
*** _alastor_ has joined #openstack-cinder15:06
*** links has quit IRC15:10
*** ik__ has quit IRC15:12
*** edmondsw has joined #openstack-cinder15:13
*** gnufied has joined #openstack-cinder15:13
*** edmondsw has quit IRC15:18
*** AlexeyAbashkin has quit IRC15:20
*** itlinux has quit IRC15:26
*** kwathore_ has joined #openstack-cinder15:29
*** kwathore has quit IRC15:30
*** armax has joined #openstack-cinder15:30
*** lkuchlan_wfh has quit IRC15:33
*** moshele has quit IRC15:33
*** lkuchlan_wfh has joined #openstack-cinder15:37
amitosmcginnis: thanks for the +2. The recheck trigger should specifically be "recheck-<...>"? should we change our current "infinidat-openstack: recheck"?15:39
smcginnisamito: It should be "run-<CI Name>"15:39
smcginnisAs per the documented requirement linked.15:39
amitosmcginnis: so run-INFINIDAT then?15:40
amitoI'll fix it now.15:40
smcginnisamito: Cool, thanks.15:41
openstackgerritHelen Walsh proposed openstack/cinder-specs master: Bulk Volume Create within Create Group API  https://review.openstack.org/51419615:43
*** lkuchlan_wfh has quit IRC15:46
*** lkuchlan has joined #openstack-cinder15:46
*** mmethot is now known as mmethot|away15:50
*** gcb has quit IRC15:53
*** diablo_rojo has joined #openstack-cinder15:57
*** david-lyle has quit IRC15:58
*** david-lyle has joined #openstack-cinder15:59
*** sdague has joined #openstack-cinder16:01
*** armaan has quit IRC16:02
*** armaan has joined #openstack-cinder16:03
*** abhitechie has joined #openstack-cinder16:05
*** markstur has joined #openstack-cinder16:07
*** abhitechie has quit IRC16:08
*** armaan has quit IRC16:09
*** abhitechie has joined #openstack-cinder16:09
*** mriedem has joined #openstack-cinder16:09
*** _pewp_ has quit IRC16:14
*** _pewp_ has joined #openstack-cinder16:14
*** lkuchlan has quit IRC16:15
*** dustins has quit IRC16:15
*** dustins has joined #openstack-cinder16:16
*** mnaser has joined #openstack-cinder16:23
mnaserUnknown column 'services.cluster_name' in 'field list' in cinder-backup start up in stable/ocata, even though db-sync was ran (and cinder-volume successfully starts up too).. its blocking changes for puppet-cinder, anyone has any clues?16:24
mnaserlog files can be seen here - http://logs.openstack.org/65/519765/1/check/legacy-puppet-beaker-rspec/0e8ad2f/logs/cinder/16:24
smcginnismnaser: Hmm, I'll take a look. Cluster support as added in Ocata, so IIRC, that should be there.16:25
mnasersmcginnis: could also be a packaging bug too so just to keep in mind as this is not deployed from source also ... so keeping that in mind16:25
*** edmondsw has joined #openstack-cinder16:26
mnaserhmm, cinder-backup starts with no problem under centos-7 (rdo) but UCA is having the issues16:26
smcginnisAhh, so maybe it is a packaging issue.16:26
mnasersmcginnis: most probably is16:28
mnasersmcginnis: ok, so just fyi, ubuntu starts services on installation, so while we're still configuring things, cinder service are endlessly restarting themselves until they are blocked by systemd, leading to puppet not being able to restart them after reconfiguring16:31
mnaserNov 30 17:39:24 ubuntu-xenial-citycloud-lon1-0001145044 systemd[1]: cinder-backup.service: Start request repeated too quickly.16:31
smcginnismnaser: I did verify, cluster_name was added to the services table in ocata.16:31
*** itlinux has joined #openstack-cinder16:31
smcginnismnaser: OK, kind of looked like that might be happening based on those logs.16:31
mnaserrdo packaging doesnt start on install so we can cleanly start up the service on the db is up16:31
mnaserguess i'll report it as a bug and we'll have to see what we can do in the meantime for the gate.. thanks smcginnis ! :)16:32
smcginnismnaser: I think our install guide (used to have) something about disabling things before even installing packages.16:32
mnaseroh thats interesting16:32
mnaseri might have a look at that16:32
smcginnismnaser: No problem. Thanks for the heads up at least. Now we'll know if something else comes asking. ;)16:32
mnaserdont know why all packagers dont do that, who really expects a config to already be there before a package is installed, especially openstack isn't really a apt-get install <foo> type of thing16:32
smcginnismnaser: Yeah, especially OpenStack. Otherwise we could just pip install cinder and go.16:33
*** armax has quit IRC16:33
*** abhinavtechie has joined #openstack-cinder16:33
* mnaser shrugs16:33
*** armax has joined #openstack-cinder16:34
smcginnisChecked and it doesn't look like our install guide says anything about pre-disabling things.16:34
*** abhitechie has quit IRC16:37
*** Swanson has joined #openstack-cinder16:41
*** mvk has quit IRC16:44
*** danpawlik_ has quit IRC16:45
*** itlinux has quit IRC16:46
*** crose has joined #openstack-cinder16:46
*** danpawlik_ has joined #openstack-cinder16:46
*** itlinux has joined #openstack-cinder16:50
mriedemjgriffith: there is nothing preventing us from creating an attachment, marking it complete (in-use) and then updating it with a host connector later, right?16:51
*** lpetrut_ has joined #openstack-cinder16:57
*** lpetrut has quit IRC17:00
*** mchlumsky has quit IRC17:03
*** lpetrut_ has quit IRC17:03
*** imacdonn has joined #openstack-cinder17:04
*** mchlumsky has joined #openstack-cinder17:05
*** felipemonteiro_ has quit IRC17:09
*** mchlumsky has quit IRC17:13
*** lhx_ has quit IRC17:15
*** tesseract has quit IRC17:20
*** xyang has joined #openstack-cinder17:21
*** ntpttr_laptop has joined #openstack-cinder17:21
*** markstur_ has joined #openstack-cinder17:21
*** markstur has quit IRC17:25
jgriffithmriedem: that's correct17:26
jgriffithmriedem: wait... not that's not correct.  But I would like to disallow that17:27
mriedemjgriffith: https://review.openstack.org/#/c/330285/166/nova/compute/api.py@370217:28
jgriffithmriedem: I have no idea what I was typing in that last line17:29
jgriffithlooking...17:29
jgriffithmriedem: ahh... that context helps17:30
*** mvk has joined #openstack-cinder17:30
jgriffithI didn't want to try and update/renew an attachment which is why it creates the new one etc17:31
jgriffithmriedem: and yes, in the case of shelve and migrate there were problems with just trying ot update again17:32
jgriffithI can go back and outline that if it's helpful17:33
jgriffithThe other thing is just because the old API behaved that way I'm not sure I'd agree that the new API should17:33
openstackgerritTadas Ustinavičius proposed openstack/cinder master: Fixes Bug1683228  https://review.openstack.org/52433117:33
jgriffithin my opinion marking a volume as in-use when it's not actually in-use isn't the right behavior is it?17:34
mriedemwhen there is no host connector, yes i get that,17:34
mriedemi'm mostly concerned with api behavior on the compute side, and not breaking that17:34
mriedemat least w/o a microversion17:34
mriedemwill the complete attachment API fail if the attachment doesn't have a connector?17:34
jgriffithyeah17:35
mriedemok, can't complete a 'placement' attachment in the api then17:35
mriedemi was thinking we could create an attachment w/o a connector in the api for the shelved offloaded case and complete it to mark the volume in-use, then on unshelve, create another attachment with the connector and then delete the old placement attachment created in the api,17:37
mriedemthe alternative is a microversion on the compute side i think, but that gets weird too17:37
openstackgerritTadas Ustinavičius proposed openstack/cinder master: Fix for volume from image snapshot free space issue  https://review.openstack.org/52433117:37
mriedemi.e. we could create a new style attachment to a shelved offloaded instance, but we won't unless the user requests a specific microversion indicating they are opting into the volume state behavior change17:38
*** gkadam_ has quit IRC17:38
jgriffithmriedem: so actually... the connecter isn't require for attachment-update... but that just gets you in attaching status17:39
jgriffithmriedem: the addition of attachment-complete was added as a requirement later during the Nova work17:41
jgriffithso now that's there and let's you basically just do all the exact same things you used to do17:41
jgriffithmriedem: I'm not completely sure why you would want to change what I put in for shelve?17:42
mriedem"so actually... the connecter isn't require for attachment-update... but that just gets you in attaching status"17:42
mriedemdid you mean attachment_complete?17:42
jgriffithmriedem: yes, sorry... I updated my response while you were running it :)17:42
mriedemit's a behavior change in attaching a volume to a shelved offloaded instance17:43
jgriffithattachment-complete doesn't take any args btw17:43
mriedemwith the old flow, the volume is in-use when we're done,17:43
mriedemwith the new flow, the volume is 'reserved' when we're done (in the api)17:43
jgriffithmriedem: we talked about that 4 or 5 months ago though17:43
jgriffithmriedem: and I thought we agreed that17:43
mriedemi don't remember talking about that, we might have, but at this point i don't remember17:43
jgriffith1. The existing response/settings were bogus17:43
jgriffith2. We were using a new Cinder API with a new MV17:44
mriedemanything, like tempest, that is attaching a volume to an instance and waiting for the volume status to go 'in-use' would be broken here17:44
jgriffith3. Since the change in behavior is a Cinder Volume (Resource) it's not a Nova problem17:44
mriedemthis is a behavior change in the compute side, not cinder17:44
jgriffithmriedem: alright17:44
mriedemwhich is why i'm saying, nova either needs to complet ethe attachment in the shelved offloaded case to fake out the in-use status on the volume, even though it's not really connected,17:45
mriedemor nova needs to add a microversion to opt into that behavior change17:45
mriedemthe former is simpler at this point if it's possible on the cinder side, i.e. complete an attachment that doesn't have a connector17:45
mriedemwhich is why i asked17:45
jgriffithmriedem: or just don't switch to the new API17:46
mriedemfor shelved offloaded scenarios you mean17:46
jgriffithmriedem: because everything has come up that we "can't" change anything to deviate from the old API's and behaviors so honestly why are we bothering?17:46
mriedemwe could, for now, but at some point we have to cross that bridge since we want to remove the old flows17:46
mriedemfrom what i'm hearing, this isn't going to derail anything17:47
*** xyang has quit IRC17:47
mriedemnova just needs to handle this17:47
mriedemto maintain API compat w/o a new microversion on the compute side17:47
jgriffithmriedem: so I think you could just mark it as complete, then create a new attachment and reset when it's unshelved, which I think is what I did at one point17:48
jgriffithmriedem: I'm not really a good source on this any longer, pretty much every line of code I submitted has been rewritten by now17:48
mriedemthat's what i'm proposing, except instead of creating a new 2nd attachment on the compute when unshelving - couldn't we just update the existing attachment and add the host connector?17:48
mriedemmaybe that changes state from in-use to attaching or something which we don't want,17:49
*** felipemonteiro has joined #openstack-cinder17:49
jgriffithmriedem: Yeah, perhaps17:49
mriedemwe could create a 2nd attachment on unshelve with the connector, and then delete the original (un)connected attachment that the api created17:49
jgriffithmriedem: I don't remember if there's a problem with that or not17:49
*** armax has quit IRC17:49
jgriffithmriedem: sounds like a fun time17:50
jgriffithmriedem: I mean that it sounds brittle and that there is a great opporunity for various races and things to go wrong17:50
*** felipemonteiro_ has joined #openstack-cinder17:50
mriedemi was wondering why test_attach_volume_shelved_or_offload_server didn't fail in tempest,17:51
jgriffithmriedem: I patched tempest17:51
mriedemi see Ia84f4325ddb0080521241ace26f89d1161db9dca now17:51
mriedemyeah, i think we need to revert that17:51
mriedemit masks the behavior change in the compute api17:51
jgriffithYou reverted that?17:52
jgriffithI dind't know17:53
*** diablo_rojo has quit IRC17:53
jgriffithdidn't know17:53
mriedemno, but i'm going to17:53
*** felipemonteiro has quit IRC17:54
jgriffithmriedem: yeah, I see it's still there17:54
*** armax has joined #openstack-cinder17:54
jgriffithmriedem: ok17:54
jgriffithrevert away17:54
mriedemi think we can handle on the nova side, so we'll do that17:54
jgriffithok17:54
jgriffithgreat17:54
*** Apoorva has joined #openstack-cinder17:55
*** xyang has joined #openstack-cinder17:56
*** moshele has joined #openstack-cinder17:57
*** xyang has quit IRC17:59
*** xyang has joined #openstack-cinder18:03
*** moshele has quit IRC18:03
ildikovmriedem: what if we would want to keep the 'reserved' state?18:04
mriedemildikov: it's a microversion on the compute side18:04
ildikovmriedem: I quickly read back only admit, but if we could make things more rational with the new flow then I think we should18:04
*** chhavi has quit IRC18:05
ildikovmriedem: you mean a service version bump?18:05
mriedemildikov: no, a compute api microversion18:05
ildikovmriedem: because it's bumped already18:05
mriedemit's a compute api behavior change18:05
ildikovand is it that hard to do?18:05
openstackgerritJohn Griffith proposed openstack/cinder-specs master: Propose multi-attach using V3 Attachment API's  https://review.openstack.org/52360818:06
mriedemildikov: at this point i think maintaining the existing api behavior, even with the new flow under the covers, is easier than introducing a new compute api microversion18:07
mriedemthis should all be transparent to the compute api user18:07
mriedemit's internal plumbing changes18:07
ildikovyeah, but faking an in-use volume is still insane18:07
ildikovI thought we will try to improve things18:08
mriedemildikov: you can't change that at the expense of the existing compute api behavior18:09
mriedemw/o a microversion18:09
ildikovI didn't argue with that18:09
*** xyang has quit IRC18:11
*** e0ne has quit IRC18:13
*** xyang has joined #openstack-cinder18:13
ildikovmriedem: so it's either a new microversion, or?18:14
*** xyang has quit IRC18:15
mriedemildikov: or we complete the attachment in the api for the shelved offloaded case to mark the volume as in-use,18:16
mriedemand we update the attachment with the host connector on unshelve - but i'm not sure how that will work, or if it will change the state of the volume to 'attaching' or something,18:17
mriedemi think we can deal with the compute side in a couple of ways though18:17
mriedemi'm also willing to help split out that check for existing bdm thing into a separate patch when i'm done with some other stuff18:17
mriedemand could help with these shelved offloaded changes in nova18:18
mriedemi have to review the alternate hosts series in nova this afternoon though, that's my priority today18:18
mriedemanyway, going to lunch, will be back later18:19
*** mriedem has quit IRC18:19
*** xyang has joined #openstack-cinder18:19
ildikovso you want to call attachment_complete in the shelved_offloaded case and create a new attachment with the connector when we unshelve18:20
ildikovok, I can do the split out tomorrow18:20
ildikovwe will need to give a bit more thought to this game18:21
ildikovhowever I would like to note here that if we do all sorts of hacks to avoid bumping an API microversion, then why do we have it on the first place?18:22
ildikovI guess jgriffith agrees with at least this one18:22
*** xyang has quit IRC18:22
*** salv-orlando has quit IRC18:23
*** salv-orlando has joined #openstack-cinder18:24
*** salv-orlando has quit IRC18:28
jgriffithildikov: I'm staying out of it :)18:29
ildikovjgriffith: what? it's Monday; what could possibly go wrong? :)18:30
jgriffithildikov: nothing that couldn't go wrong the 6 other days of the week :)18:31
ildikovjgriffith: I'm on my own it seems, only Garfield understands me :)18:32
*** Apoorva has quit IRC18:33
*** Apoorva has joined #openstack-cinder18:34
*** Sanatics has joined #openstack-cinder18:38
*** salv-orlando has joined #openstack-cinder18:39
*** moshele has joined #openstack-cinder18:40
*** Sanatics has quit IRC18:40
*** moshele has quit IRC18:42
*** xyang has joined #openstack-cinder18:43
*** xyang has quit IRC18:47
*** gkadam_ has joined #openstack-cinder18:47
jgriffithOh yeah!  Garfield18:47
*** xyang has joined #openstack-cinder18:49
*** xyang has quit IRC18:52
*** armax has quit IRC18:55
*** jmlowe has joined #openstack-cinder19:00
*** erlon has joined #openstack-cinder19:01
*** sdague has quit IRC19:03
*** e0ne has joined #openstack-cinder19:04
*** e0ne has quit IRC19:08
*** e0ne has joined #openstack-cinder19:10
*** adisky_ has quit IRC19:10
*** gouthamr has quit IRC19:20
*** xyang has joined #openstack-cinder19:26
*** xyang has quit IRC19:26
*** armax has joined #openstack-cinder19:29
*** xyang has joined #openstack-cinder19:31
*** gouthamr has joined #openstack-cinder19:37
*** mriedem has joined #openstack-cinder19:39
smcginnisMmm, lasagna.19:41
ildikovand coffee19:42
ildikovof course :)19:42
*** gouthamr has quit IRC19:45
*** jccates has joined #openstack-cinder19:45
*** dave-mccowan has joined #openstack-cinder19:45
*** _pewp_ has quit IRC19:45
*** _pewp_ has joined #openstack-cinder19:46
jccatesI've got a change (511346) that's been sitting fallow for a while. Jenkins downvoted it because of a nondeterministic failure; I tried a re-check, but it never re-ran the Jenkins pipeline. What can I do to get that change moving again?19:47
smcginnisjccates: Looks like that was around the time we switched from jenkins to zuul.19:49
smcginnisjccates: And zuul votes +1. So you are fine, but probably not getting much attention because in list views of patches it will look like there's a problem.19:50
smcginnisjccates: Maybe jungleboyj or someone will have time to take a look.19:50
smcginnis/winow 2219:50
smcginnisDang it. :)19:50
jccateshah, thanks19:50
jungleboyjjccates:  Looking.19:51
jgriffithhaha.. smcginnis perhaps my favorite irssi script :)19:51
smcginnistoo many windows. Or winows as the case may be.19:52
jungleboyjjccates: Fixed.19:53
jungleboyj approved.19:53
jccatesjungleboyj: thanks much!19:54
*** e0ne has quit IRC19:59
*** Apoorva has quit IRC19:59
*** itlinux has quit IRC20:01
*** jccates has quit IRC20:01
*** armaan has joined #openstack-cinder20:03
*** e0ne has joined #openstack-cinder20:09
*** Apoorva has joined #openstack-cinder20:11
*** sdague has joined #openstack-cinder20:12
SwansonYes, President James Garfield was known for hating Mondays.20:18
mriedemsmcginnis: jungleboyj: air drummer guy is distracting me20:19
mriedem</drum_solo>20:19
smcginnisWhen you gotta jam out, you gotta jam out.20:19
jungleboyjI hadn't even noticed him.20:19
* jungleboyj is totally going to air drum around mriedem now.20:20
jungleboyjmriedem:  I won't tell you what is distracting me.20:21
mriedemthe common table social hour?20:23
mriedemOMFG I LOVE EVERYTHING!!!20:23
jungleboyjIt will be alright ... It will be alright.20:24
SwansonThe hell is going on there?20:24
jungleboyjStop pampering them, it will be alright.20:24
*** moshele has joined #openstack-cinder20:31
*** armaan has quit IRC20:34
*** gouthamr has joined #openstack-cinder20:36
jungleboyjStop calling me from Jail !20:41
*** salv-orlando has quit IRC20:43
*** salv-orlando has joined #openstack-cinder20:43
*** salv-orlando has quit IRC20:45
*** salv-orlando has joined #openstack-cinder20:45
*** armaan has joined #openstack-cinder20:45
*** gkadam_ has quit IRC20:51
*** armaan has quit IRC21:04
*** itlinux has joined #openstack-cinder21:05
*** itlinux has quit IRC21:06
*** xyang has quit IRC21:16
*** nicolasbock has joined #openstack-cinder21:19
*** liverpooler has quit IRC21:19
mriedemildikov: http://eavesdrop.openstack.org/irclogs/%23openstack-cinder/%23openstack-cinder.2017-12-04.log.html#t2017-12-04T18:20:06 - yes, but i don't think we need a new attachment in the compute when we unshelve if we can just update the connector in the existing attachment21:33
mriedemildikov: also, should depend on this to make sure it works https://review.openstack.org/#/c/525267/21:33
mriedemassuming you can update an attachment that is 'complete'21:34
ildikovmriedem: I need to check those calls21:34
mriedemif not, then yes, we need to create a new attachment with the host connector and delete the old placeholder attachment created by the api21:34
ildikovCurrently we create a new attachment by principle21:35
mriedemby what principle?21:35
ildikovThat attachments are disposable21:35
*** crose has quit IRC21:35
mriedemum21:36
mriedemsure,21:36
mriedembut,21:36
mriedemwhy the runaround if we can just update the one we have with the host connector?21:36
mriedemif you can't update a 'complete' attachment, then i'd understand21:36
mriedemthis isn't any different from the normal volume attach case where the api creates the attachment and the compute updates it with the host connector and then completes it21:37
ildikovI need to check that unless jgriffith knows from the top of his head21:37
mriedembtw, i'd understand and agree with a 409 trying to update the connector on a 'completed' attachment21:37
mriedemi just d'ont know if the cinder api prevents that today21:37
ildikovmriedem: in that case the API just reserves21:37
ildikovmriedem: BTW, is there any plan on removing the shelve API? Or we're looking into workarounds because we're so used to?21:39
jgriffithmriedem: because that was the entire point/philosophy behind these changes21:39
ildikovmriedem: I also need to check whether you can call attachment_complete on a not connected attachment21:39
*** pcaruana has quit IRC21:39
mriedemildikov: at this point, assume that shelve isn't going away - it doesn't really matter for what we're trying to get done here in queens21:40
*** moshele has quit IRC21:40
mriedemeven if we deprecate shelve, we will honor it on older microversions where it's not deprecated21:40
mriedemildikov: we're looking into workarounds to avoid adding a compute microversion for this change, which is in your best interest if you want to avoid dragging this change on longer21:41
mriedembelieve it or not, i'm trying to help here21:41
mriedemwhich is also why i offered to just help work this part of it in a separate patch if you want21:42
ildikovQuestions21:42
ildikovIf we would add a new compute my, would that men to not get even this new attach flow patch landed in Queens?21:43
ildikovs/my/mv/21:44
mriedemildikov: no, but it would add more code and complication to an already very large and complicated patch, which means pushing it out further because of slower review time,21:45
mriedemwhich pushes other things, like multiattach support, out later, and likely means that can't get done21:45
mriedempersonally i'm trying to push for the new flow attach patch to be merged this week21:45
mriedemfor a chance to get multiattach done in q-321:45
ildikovDo you think multi attach is still realistic?21:45
mriedemif we can land this patch this week yes21:46
mriedemwe need a full milestone of burn in time to flush out bugs with the new flow at least21:46
ildikovjgriffith: can we call attachment_complete on a reserved attachment?21:47
ildikovmriedem: I still think it's nasty to add this complexity to the code for seemingly no good reason21:48
mriedemildikov: not breaking the api behavior is a good enough reason IMO21:48
ildikovmriedem: and would at least like to clean it up later if we can however that would just make the code even uglier21:48
mriedemildikov: if you want to clean it up with a compute api microversion rocky, that's fine21:49
mriedem*in rocky21:49
ildikovmriedem: it's just sad that we have to do this because of the microversions21:49
ildikovI guess those are just guards so you don't do anything...21:50
mriedemildikov: you are essentially saying, "it's sad we have to be careful about not changing our API because it's a pain in the ass"21:50
mriedemthat's the burden of having a stable API21:50
ildikovAnd the review time, etc21:52
ildikovAnd improving the API and the code should be part of a still stable API21:53
ildikovAnyway, sorry, I stopped arguing21:53
mriedemi've gotta run21:54
mriedemlet me know if you just want me to take over this shelved offloaded thing21:54
ildikovSo we need to check attachment_complete as well as if it cannot be called on a reserved volume then we're stuck21:54
ildikovAnd without that the volume won't be in 'in-use'21:55
ildikovmriedem: I won't do it today for sure, it's pretty late now21:55
*** mriedem has quit IRC21:56
*** Apoorva_ has joined #openstack-cinder22:02
*** gouthamr has quit IRC22:04
*** Apoorva has quit IRC22:05
*** rcernin has joined #openstack-cinder22:07
*** namnh has joined #openstack-cinder22:14
*** salv-orlando has quit IRC22:15
*** salv-orlando has joined #openstack-cinder22:15
*** ganso has quit IRC22:18
*** salv-orlando has quit IRC22:20
*** abishop has quit IRC22:20
*** namnh has quit IRC22:21
*** salv-orlando has joined #openstack-cinder22:27
*** Apoorva_ has quit IRC22:33
*** armax has quit IRC22:33
*** Apoorva has joined #openstack-cinder22:33
*** armax has joined #openstack-cinder22:36
*** dustins has quit IRC22:40
*** namnh has joined #openstack-cinder22:51
*** felipemonteiro_ has quit IRC22:53
jgriffithildikov: yes, you can skip the update and go straight to complete22:55
*** namnh has quit IRC22:56
mgagnetyvm to whoever moved/renamed os_privileged_* configs to [nova] section, much appreciated =)23:02
*** namnh has joined #openstack-cinder23:03
*** namnh has quit IRC23:08
*** gouthamr has joined #openstack-cinder23:08
jgriffithmgagne: I think smcginnis implemented that23:15
jgriffithor no.. gyorgy23:16
jgriffithanyway :)23:16
mgagnethanks to that person =)23:16
*** namnh has joined #openstack-cinder23:19
*** namnh has quit IRC23:23
*** gmann_afk is now known as gmann23:27
*** namnh has joined #openstack-cinder23:28
*** dhinesh has joined #openstack-cinder23:32
*** namnh has quit IRC23:33
*** dhinesh_ has joined #openstack-cinder23:36
*** dhinesh has quit IRC23:37
*** armax has quit IRC23:38
*** e0ne has quit IRC23:39
*** namnh has joined #openstack-cinder23:42
*** namnh has quit IRC23:47
*** armax has joined #openstack-cinder23:53
*** jmlowe has quit IRC23:55
*** gouthamr has quit IRC23:56
*** gouthamr has joined #openstack-cinder23:58
*** namnh has joined #openstack-cinder23:58
*** felipemonteiro has joined #openstack-cinder23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!