Friday, 2015-07-03

jgriffiththingee: so the static vs dynamic seperation is probably a good idea00:01
*** hemna is now known as hemnafk00:01
*** patrickeast has quit IRC00:01
*** mtanino has quit IRC00:02
thingeejgriffith: sorry I didn't understand your last message00:02
*** tsekiyam_ has joined #openstack-cinder00:03
jgriffiththingee: so there are a number of things the scheduler uses from that call that are dynamic and IMPORTANT, like capacity utilization etc00:05
jgriffiththingee: it would be kinda "stupid" to put a ton of static content in there00:05
jgriffiththingee: so seperate those things is what I'm saying00:05
jgriffiththingee: that's an optimization on the code we already have in some cases00:05
jgriffithfor example my devices "vendor_name" doesn't change00:05
jgriffithso why do I report it back up every 60 seconds :)00:06
thingeejgriffith: ah yeah I see00:06
*** tsekiyama has quit IRC00:06
thingeejgriffith: yeah I think capabilities are unlikely to change...unless you do some upgrade with your vendor backend.00:06
jgriffiththingee: I'll code something up for you on Monday00:07
jgriffithsee what you think00:07
jgriffithwords are hard :)00:07
thingeejgriffith: ok...I'm just trying to grasp if we're somewhat agreeing :)00:07
jgriffiththingee: probably, as long as you leave the whole concept of people wanting to use this as documentation out of it :)00:08
*** tsekiyam_ has quit IRC00:08
jgriffiththingee: I'll never think that's a good idea00:08
thingeejgriffith: what about options to values of extra spec keys?00:08
*** dims__ has joined #openstack-cinder00:10
*** smoriya has joined #openstack-cinder00:10
*** dims_ has quit IRC00:12
jgriffithsamething, although I am still kinda opposed to that idea00:27
*** leeantho has quit IRC00:27
*** jdurgin has joined #openstack-cinder00:48
*** alau2 has quit IRC00:51
*** ociuhandu has quit IRC00:51
*** chlong has joined #openstack-cinder00:57
*** MentalRay has joined #openstack-cinder01:00
*** MentalRay has quit IRC01:03
*** Longgeek has joined #openstack-cinder01:10
*** MentalRay has joined #openstack-cinder01:11
*** davechen has joined #openstack-cinder01:13
*** mriedem has joined #openstack-cinder01:14
*** dhellmann has quit IRC01:15
*** dhellmann has joined #openstack-cinder01:15
*** jaypipes has quit IRC01:16
*** heyun has joined #openstack-cinder01:17
*** Longgeek has quit IRC01:18
*** MentalRay has quit IRC01:19
*** mfisch has quit IRC01:20
*** yrabl has quit IRC01:21
*** yrabl has joined #openstack-cinder01:21
*** IanGovett has joined #openstack-cinder01:22
*** IanGovett has quit IRC01:23
openstackgerritxing-yang proposed openstack/cinder: EMC VMAX Modify CG  https://review.openstack.org/19482901:23
*** IanGovett has joined #openstack-cinder01:24
openstackgerritxing-yang proposed openstack/cinder: Add multiple pools support to VMAX driver  https://review.openstack.org/18999001:24
openstackgerritxing-yang proposed openstack/cinder: EMC VMAX Create CG from CG Snapshot  https://review.openstack.org/19528001:24
*** davechen1 has joined #openstack-cinder01:26
*** asselin_ has joined #openstack-cinder01:27
*** _cjones_ has quit IRC01:27
*** davechen has quit IRC01:28
*** IanGovett has quit IRC01:29
*** marcusvrn1 has joined #openstack-cinder01:30
*** marcusvrn1 has quit IRC01:32
openstackgerritDave Chen proposed openstack/cinder: Policies based properties protection  https://review.openstack.org/16014501:45
openstackgerritxing-yang proposed openstack/os-brick: Add connector driver for the ScaleIO cinder driver  https://review.openstack.org/18583501:46
*** dannywilson has joined #openstack-cinder01:49
openstackgerritDave Chen proposed openstack/cinder: Policies based properties protection  https://review.openstack.org/16014501:50
*** blmartin has joined #openstack-cinder02:03
*** Nikolay_St has quit IRC02:12
*** Nikolay_St has joined #openstack-cinder02:12
*** asselin_ has quit IRC02:19
*** annegentle has joined #openstack-cinder02:25
*** annegentle has quit IRC02:27
*** mutoulbj has joined #openstack-cinder02:27
*** laughterwym_ has joined #openstack-cinder02:31
*** laughterwym has quit IRC02:34
*** julim has joined #openstack-cinder02:41
*** mfisch has joined #openstack-cinder02:42
*** mfisch is now known as Guest6154802:42
*** hakimo_ has joined #openstack-cinder02:52
*** Lee1092 has joined #openstack-cinder02:53
*** hakimo has quit IRC02:54
*** Longgeek has joined #openstack-cinder02:59
openstackgerritLin Yang proposed openstack/python-cinderclient: Improve error message when cinder quota exceeded  https://review.openstack.org/17894603:02
*** jskinner has quit IRC03:04
*** blmartin has quit IRC03:07
*** Longgeek has quit IRC03:16
*** BharatK has quit IRC03:16
*** hemna has joined #openstack-cinder03:17
*** hemna has quit IRC03:21
openstackgerritwanghao proposed openstack/cinder: Validate value when user update quota  https://review.openstack.org/19793803:26
*** jwcroppe has joined #openstack-cinder03:31
*** jwcroppe_ has quit IRC03:33
*** asselin_ has joined #openstack-cinder03:33
*** julim has quit IRC03:36
openstackgerritwanghao proposed openstack/cinder: Incremental backup improvements for L  https://review.openstack.org/18832803:41
openstackgerritwanghao proposed openstack/cinder: Implement function to manage/unmanage snapshots  https://review.openstack.org/14459003:45
*** yamada-h has joined #openstack-cinder03:47
*** dalgaaf has quit IRC03:48
*** ericksonsantos has quit IRC03:48
*** coolsvap|away is now known as coolsvap03:48
*** yamada-h has quit IRC03:51
*** dims__ has quit IRC03:52
openstackgerritLiu Xinguo proposed openstack/cinder: Refactor Huawei Volume driver  https://review.openstack.org/18824003:58
*** lixiaoy11 has quit IRC04:04
*** annashen has joined #openstack-cinder04:09
*** rakesh_mishra has joined #openstack-cinder04:12
*** Longgeek has joined #openstack-cinder04:13
*** Longgeek has quit IRC04:15
*** Longgeek has joined #openstack-cinder04:15
*** Longgeek has quit IRC04:16
*** Longgeek has joined #openstack-cinder04:17
*** _cjones_ has joined #openstack-cinder04:19
*** annashen has quit IRC04:25
*** _cjones_ has quit IRC04:26
*** _cjones_ has joined #openstack-cinder04:26
*** yamada-h has joined #openstack-cinder04:27
*** sgotliv has quit IRC04:28
*** yamada-h has quit IRC04:31
*** p_deore has joined #openstack-cinder04:34
*** jwcroppe_ has joined #openstack-cinder04:40
*** Longgeek has quit IRC04:42
*** Longgeek has joined #openstack-cinder04:42
*** jwcroppe has quit IRC04:43
*** jwcroppe_ has quit IRC04:44
*** jwcroppe has joined #openstack-cinder04:45
*** Longgeek has quit IRC04:50
*** BharatK has joined #openstack-cinder04:50
*** Longgeek has joined #openstack-cinder04:51
*** jwcroppe is now known as jwcroppe_away04:57
*** shausy has joined #openstack-cinder04:57
*** rushiagr_away is now known as rushiagr04:58
*** Apoorva has joined #openstack-cinder04:59
*** dannywilson has quit IRC05:01
*** dannywilson has joined #openstack-cinder05:01
*** shyama has joined #openstack-cinder05:03
*** drjones has joined #openstack-cinder05:05
*** _cjones_ has quit IRC05:07
*** Longgeek has quit IRC05:10
*** jwcroppe_away has quit IRC05:10
*** Longgeek has joined #openstack-cinder05:12
*** deepakcs has joined #openstack-cinder05:14
*** nkrinner has joined #openstack-cinder05:16
*** jwcroppe has joined #openstack-cinder05:19
*** _cjones_ has joined #openstack-cinder05:19
*** Apoorva has quit IRC05:23
*** drjones has quit IRC05:23
*** Longgeek has quit IRC05:24
*** Longgeek has joined #openstack-cinder05:24
*** _cjones_ has quit IRC05:28
openstackgerritAndrey Pavlov proposed openstack/cinder: Fix doc string definitions  https://review.openstack.org/19312405:38
*** igor____ has joined #openstack-cinder05:50
*** lpetrut has joined #openstack-cinder05:53
*** igor___ has quit IRC05:53
*** annashen has joined #openstack-cinder05:59
*** laughterwym_ has quit IRC06:04
*** lixiaoy1 has joined #openstack-cinder06:04
*** annashen has quit IRC06:13
*** lixiaoy11 has joined #openstack-cinder06:14
*** annashen has joined #openstack-cinder06:15
*** lixiaoy1 has quit IRC06:16
*** annashen has quit IRC06:22
*** ankit_ag has joined #openstack-cinder06:24
*** tobe has joined #openstack-cinder06:24
*** nihilifer has joined #openstack-cinder06:28
*** lpetrut has quit IRC06:28
*** anshul has joined #openstack-cinder06:30
*** laughterwym has joined #openstack-cinder06:43
*** Lee1092 has quit IRC06:45
*** belmoreira has joined #openstack-cinder06:46
*** dims_ has joined #openstack-cinder06:53
*** dims_ has quit IRC06:58
*** netapp has quit IRC07:10
*** med_ has quit IRC07:10
*** afazekas has quit IRC07:10
*** coolsvap is now known as coolsvap|away07:11
*** netapp_ has joined #openstack-cinder07:11
*** med_` has joined #openstack-cinder07:11
*** afazekas has joined #openstack-cinder07:11
*** BharatK has quit IRC07:11
*** subscope has quit IRC07:11
*** lennyb has quit IRC07:11
*** subscope has joined #openstack-cinder07:11
*** lennyb has joined #openstack-cinder07:11
*** BharatK has joined #openstack-cinder07:11
*** netapp_ is now known as netapp07:11
*** agarciam has quit IRC07:14
*** agarciam has joined #openstack-cinder07:14
*** BharatK has quit IRC07:16
*** coolsvap has joined #openstack-cinder07:24
*** coolsvap has quit IRC07:25
*** coolsvap|away is now known as coolsvap07:26
*** BharatK has joined #openstack-cinder07:32
*** albertom has quit IRC07:32
*** bnemec has quit IRC07:32
*** jdurgin has quit IRC07:33
*** _afazekas has joined #openstack-cinder07:33
*** e0ne has joined #openstack-cinder07:33
*** powerbsd has joined #openstack-cinder07:33
*** chlong has quit IRC07:33
*** markus_z has joined #openstack-cinder07:33
*** powerbsd is now known as albertom07:33
*** albertom has quit IRC07:33
*** albertom has joined #openstack-cinder07:33
*** markus_z has quit IRC07:33
*** markus_z has joined #openstack-cinder07:33
*** afazekas has quit IRC07:33
*** bnemec has joined #openstack-cinder07:33
*** marcusvrn has quit IRC07:34
*** laughterwym has quit IRC07:35
*** laughterwym has joined #openstack-cinder07:35
*** e0ne has quit IRC07:36
*** dannywilson has quit IRC07:36
*** jordanP has joined #openstack-cinder07:37
*** jistr has joined #openstack-cinder07:39
*** coolsvap is now known as coolsvap|afk07:39
*** rakesh_mishra has quit IRC07:40
*** bluex-pl has joined #openstack-cinder07:42
*** bluex-pl has quit IRC07:42
*** bluex-pl has joined #openstack-cinder07:42
*** openstackstatus has quit IRC07:49
*** aix has joined #openstack-cinder07:50
*** openstackstatus has joined #openstack-cinder07:50
*** ChanServ sets mode: +v openstackstatus07:50
*** mutoulbj has quit IRC07:52
haypohi. can someone please try my python 3.4 patch for os-brick? i would like to know if "tox -e py34" works for you: https://review.openstack.org/#/c/197624/07:55
*** rakesh_mishra has joined #openstack-cinder07:55
haypowalter had issues on his setup. you have to remove .testrepository once, and then run tox -e py34. but later, you should have not to do this workaround anymore07:56
*** ronis has joined #openstack-cinder07:56
haypoby the way, would it be possible to get a release of os-brick? walter's patch to add python3 support has been merged (https://review.openstack.org/#/c/196284/) and i need py3 support in os-brick for my py3 patches for cinder07:57
*** rakesh_mishra has quit IRC08:00
*** zhonghua-lee has joined #openstack-cinder08:00
*** zhonghua-li has joined #openstack-cinder08:00
*** zhonghua-li has quit IRC08:00
*** laughterwym has quit IRC08:01
*** mutoulbj has joined #openstack-cinder08:01
*** laughterwym has joined #openstack-cinder08:02
*** yamada-h has joined #openstack-cinder08:28
*** lixiaoy11 has quit IRC08:30
*** yamada-h has quit IRC08:32
*** afazekas has joined #openstack-cinder08:37
*** rakesh_mishra has joined #openstack-cinder08:44
*** dtynan has quit IRC08:44
*** dtynan has joined #openstack-cinder08:45
*** zhonghua-lee has quit IRC08:52
*** openstackgerrit has quit IRC08:57
*** ndipanov has joined #openstack-cinder08:58
*** openstackgerrit has joined #openstack-cinder08:58
wanghaoping duncan09:06
*** e0ne has joined #openstack-cinder09:08
*** lpetrut has joined #openstack-cinder09:08
wanghaoduncan: There is small patch for Guru Meditation Reports to oslo.reports(https://review.openstack.org/#/c/196489/). We can merge this quickly, would you help to review this.09:09
*** RuiChen has joined #openstack-cinder09:10
*** belmoreira has quit IRC09:11
geguileowanghao: You should use his full nick so he'll notice  ;-)09:12
wanghaogeguileo: aha, I always forgot this, sorry...09:13
wanghaoping DuncanT09:13
geguileono problem09:13
wanghaoDuncanT: There is small patch for Guru Meditation Reports to oslo.reports(https://review.openstack.org/#/c/196489/). We can merge this quickly, would you help to review this.09:14
openstackgerritPetrut Lucian proposed openstack/cinder: RemoteFS: Fix the offline snapshot delete operation  https://review.openstack.org/19519609:16
*** yamada-h has joined #openstack-cinder09:17
*** annashen has joined #openstack-cinder09:23
*** mutoulbj has quit IRC09:23
openstackgerritDaniel Tadrzak proposed openstack/cinder: ConsistencyGroup Object  https://review.openstack.org/16364109:24
*** ronis_ has joined #openstack-cinder09:25
wanghaogeguileo: I saw your latest comment in "Validate value when user update quota" this patch.  I feel that quota can change equal to existing resources, it has same function with current way we do in quota. Both to control the resources creation.09:26
*** annashen has quit IRC09:27
wanghaogeguileo: But in my way it's less confuse to end user.09:27
*** yamada-h has quit IRC09:27
geguileowanghao: I didn't review the quota creation validation, so I didn't complain back then09:28
geguileowanghao: But I saw your patch, sorry ;-)09:28
geguileowanghao: Anyway, that's just my opinion, you should get someone else to review it09:29
*** ronis has quit IRC09:29
geguileowanghao: Look at who added that validation in create and ping him, he'll probably side with you ;-)09:29
openstackgerritDaniel Tadrzak proposed openstack/cinder: CGSnapshot Object  https://review.openstack.org/19502709:30
openstackgerritDaniel Tadrzak proposed openstack/cinder: ConsistencyGroup Object  https://review.openstack.org/16364109:30
openstackgerritDaniel Tadrzak proposed openstack/cinder: Fix saving tz aware datetimes in Versioned Objects  https://review.openstack.org/19607109:30
openstackgerritVictor Stinner proposed openstack/os-brick: Cleanup Python 3 changes  https://review.openstack.org/19762409:31
wanghaogeguileo: Sure, I think I need to collect more opinions, but thanks for your review, it's help me to think deep.09:34
geguileowanghao: No problem, thank you for your patches09:35
*** bluex-pl has quit IRC09:35
*** bluex-pl has joined #openstack-cinder09:35
*** shausy has quit IRC09:36
wanghaogeguileo: :)09:36
*** belmoreira has joined #openstack-cinder09:39
*** jwcroppe has quit IRC09:42
*** davechen1 has left #openstack-cinder09:49
openstackgerritwanghao proposed openstack/cinder: Incremental backup improvements for L  https://review.openstack.org/18832809:54
*** igor____ has quit IRC09:55
*** BharatK has quit IRC09:58
*** BharatK has joined #openstack-cinder09:59
*** ankit8188 has joined #openstack-cinder10:04
*** bluex-pl has quit IRC10:06
*** bluex-pl has joined #openstack-cinder10:07
*** bluex-pl has quit IRC10:07
*** bluex-pl has joined #openstack-cinder10:08
*** ankit_ag has quit IRC10:08
*** ronis_ has quit IRC10:12
deepakcsDuncanT: ping10:13
deepakcsDuncanT: https://review.openstack.org/192736 , why do u think fixing for blockCommit is for another bug/patch ?10:13
deepakcsDuncanT: what makes this bug rebase specific ?10:13
*** sgordon has quit IRC10:14
deepakcsjordanP: ^^10:14
jordanPdeepakcs, I am trying to have the tempest test working on glusterFS, or more generally any RemoteFS. fixing BlockCommit is not required for that.10:15
deepakcsDuncanT: jordanP the reason tempest fails with blockRebase is because in the tempest test its deleting active file, but if someone deletes (in tempest or outside of it) non-active file, which causes blockCommit to happen, you would hit this scneario for commit too10:15
jordanPdeepakcs, I'd like to keep the patch small so that it gets a change to get in quickly10:15
*** ronis_ has joined #openstack-cinder10:15
deepakcsjordanP: i see DuncanT gave +1, but i don't necessarily agree10:16
jordanPdeepakcs, I agree. But as you said 'if someone deletes'. I don't know how, why, when this 'someone' would do it10:16
deepakcsjordanP: DuncanT since the root cause of the issue is similar (libvirt not supporting blockjob for offline domains), the fix should be part of 1 patch10:16
deepakcsjordanP: also -F backing_fmt should be used for security reasons10:17
jordanPdeepakcs, as I don"t "see" any issue with blockCommit, i.e I don"t have a reproducer, I won't fix it myself. But as I said, feel free to submit another patch if you have a reproducer10:18
*** sgordon has joined #openstack-cinder10:18
jordanPdeepakcs, I agree with the -F. so my question is, what value should I pass to -F ?10:18
jordanPqcow2 or raw ?10:18
deepakcsjordanP: that you need to deduce beforehand in the code i guess10:19
deepakcsit could be either, hence need to find out , using qemu-img info10:19
*** SergeyLukjanov has quit IRC10:22
*** ronis_ has quit IRC10:22
jordanPdeepakcs, okay for qemu-imf info. But on which file ? the backing file or the destination file ?10:23
jordanPthe backing file could be ""10:23
jordanPie make the iimage "independent" of any backing file10:23
*** ronis__ has joined #openstack-cinder10:23
*** SergeyLukjanov2 has joined #openstack-cinder10:23
*** SergeyLukjanov2 is now known as SergeyLukjanov10:23
jordanPdeepakcs, btw, to you have any reference to this security issue when we don"t set -F ?10:23
jordanPi believe you, but for my culture :)10:23
deepakcsjordanP: ya, let me google for you10:24
*** bluex-pl has quit IRC10:24
jordanPdeepakcs, thanks ! :p10:24
*** bluex-pl has joined #openstack-cinder10:24
*** dims_ has joined #openstack-cinder10:25
deepakcsjordanP: https://www.redhat.com/archives/libvirt-users/2012-June/msg00022.html (grep for autoprobe and read that para)10:27
*** ociuhandu has joined #openstack-cinder10:27
*** yamada-h has joined #openstack-cinder10:27
jordanPdeepakcs, thanks10:27
jordanPdeepakcs, I guess I should hardcode -F qcow210:28
*** heyun has quit IRC10:28
jordanPbecause there's no way the original for could be raw10:28
deepakcsjordanP: if backing file is "" then we need to pass -F "" , if not, use qemu-img info to find the backing_file's format and use that for -F (we do that on cinder side), not sure if we have pre-available utils to do so on nova, else need to code it up10:28
jordanPbecause raw file format doesn't support backing file right ?10:29
lpetrutjordanP: that's the format of the backing file actualy, so it can be raw10:29
deepakcsjordanP: lpetrut is right10:29
deepakcsjordanP: hence i wanted eblake to get into there, but maybe he is busy10:30
jordanP-F is the format of the backing file ?10:30
lpetrutyep10:30
jordanP(sorry I am not an expert on this subject)10:30
jordanPok lpetrut and deepakcs thanks. So I guess I should10:30
deepakcsjordanP: as i said, it would be best to check with danpb or eblake too10:31
jordanPif backing_file is "" which means, please do a "full" rebase, i.e backing file will be /dev/null then -F ""10:31
*** haomaiwang has joined #openstack-cinder10:31
lpetrutby the way, @deepaks, thanks a lot for reviewing the RemoteFS snapshot delete fix, I made exactly the same mistake :)10:31
jordanPotherwise -F should be the file format of the backing file. Is that right ?10:32
*** yamada-h has quit IRC10:32
deepakcsjordanP: for eg: base (raw) <- snap1 (qcow2) <- snap2 (qcow2) and we delete snap2 by doing a rebase, so chain becomes base(raw) <- snap2 (repr snap1), snap2's backing file is now raw (from the orig qcow2)10:32
deepakcslpetrut: i know :)10:33
jordanPyeah yeah, I just didn"t know that -F was the format of the backing file10:33
deepakcsjordanP: ` man qemu-img`, see the rebase section , if u use -u (unsafe mode) then it doesn't do a full rebase, just changes the ptr, without -u, it does a full rebase. -F "" has nothing to do with it IMO10:34
lpetrutbut wait, if there is no backing file, there is no rebase to be done10:34
jordanPdeepakcs, don't worry I expect danp and eblake to review when things will be serious10:34
jordanPlpetrut, the variable is missnamed backing_file is the "future" backing file, after the rebase10:35
deepakcsjordanP: rebase_base in the nova code, iirc10:35
jordanPyes10:35
*** Lee1092 has joined #openstack-cinder10:36
jordanPlpetrut, what was the last thing you said ?10:36
deepakcslpetrut: not exactly mis-named, the text there says that it is the backing file post rebasing, something liek that :)10:36
*** IanGovett has joined #openstack-cinder10:37
*** rakesh_mishra has quit IRC10:38
*** bluex-pl has quit IRC10:40
jordanPdeepakcs, "qemu-img rebase -b "" -F "" $working_dir/trusty_delta.qcow2" -->>> qemu-img: Invalid format name: ''10:42
jordanPis that what you tried to say and that I fail to understand ? :p10:43
lpetrutif there is no backing file, I think the -F argument must be omitted10:44
deepakcsjordanP: https://github.com/openstack/cinder/blob/a3f4eed52efce50c2eb1176725bc578272949d7b/cinder/volume/drivers/remotefs.py#L69510:45
jordanPdeepakcs, I can't use -u10:45
deepakcsjordanP: so you mean the above works if u don't use -u ?10:46
* deepakcs never tried that ways10:46
DuncanTdeepakcs: I agree it should be fixed, but *not* in the same patch. Patches that fix exactly one issue are far easier to review than a patch that fixes several issues, even if they are related. Good practice says make your patches as small as possible. This patch makes one tempest test pass. That's pretty much idea10:46
deepakcss/dont use / use10:46
jordanPdeepakcs, could you rephrase ? :)10:47
deepakcsjordanP: so you mean the above cmd of yours works if u use -u ?10:47
DuncanTdeepakcs: If there's a second scenario (and it looks like you've found one) then that should be fixed separately, preferably with a tempest test that fails before the second patch and passes afterwards10:47
jordanPI cant' work -u is "unsafe" and just update the pointer. I need some data to be copied10:47
jordanP*it10:47
deepakcsjordanP: just try with -u, u r just saying that backing_file  should be  null10:48
lpetrutby the way, I'd like to refactor the remotefs based drivers soon as there is a lot of common code, leaving only the backend specific stuff. Was there any discussion related to removing the backend preffix from config options, relying on config groups instead?10:48
jordanPand need the backing the be null but also copy the data from the old backing file, so i think i can't use -u10:48
jordanP*I10:49
DuncanTlpetrut: You'd need some way of making those new config options back-compatable10:49
deepakcslpetrut: eharney would be best to comment on that10:49
deepakcsjordanP: letme read man page!10:50
jordanP:)10:50
*** bluex-pl has joined #openstack-cinder10:51
lpetrutthanks guys, I'll try to speak with him as well. We could go through the config option deprecation proccess10:51
deepakcsjordanP: got it, u actualy do the rebase (safe mode) , then use -u (unsafe mode) to change the backing pointer10:52
deepakcsjordanP: for eg: https://github.com/openstack/cinder/blob/a3f4eed52efce50c2eb1176725bc578272949d7b/cinder/volume/drivers/remotefs.py#L105810:52
jordanPyeah. But you can do it in one operation10:52
deepakcsjordanP:  in cinder, we commit and then rebase -u to ensure the backing file_fmt is updated properly10:53
lpetrutalso, @DuncanT, we'd like to support volume backup for the Windows iSCSI and SMB volume drivers, could you please take a look and maybe approve the following two BPs? https://blueprints.launchpad.net/cinder/+spec/windows-smb-backup https://blueprints.launchpad.net/cinder/+spec/windows-iscsi-backup10:53
deepakcsjordanP: if the backing file is present, -F has a value, if the backing file is null, then  use -u with -F"" to ensure backing_file is null10:53
lpetrutDuncanT: those are pretty straight forwards, but if needed, I might provide some specs10:53
deepakcsjordanP: i mean the backing file *after* the rebase (new backing file)10:54
jordanPdeepakcs, no. i just can't use "-u".10:54
DuncanTlpetrut: I can't approve blueprints, Mike has to do that. I can't see why it would need a spec however10:54
*** marcusvrn has joined #openstack-cinder10:54
jordanPdeepakcs, I need some data to be copied, so I cant' use -u. rebase and commit reworks differently I guess.10:55
lpetrutDuncanT: oh, no problem, thanks anyway! I'll try to reach him10:55
deepakcsjordanP: for backing_file null case, u need to do it 2 steps then, first rebase without -u, then use -u -F"" to ensure backing_fmtis none10:55
jordanPdeepakcs, why need 2 steps when I can do it in one step ?10:56
deepakcsjordanP: bcos as u said above, -b"" and -F "" combination errors out10:56
jordanPif i use -b "", there"s just no backing_file. Why should I then use -u -F "" to se a backing_fmt ?10:57
jordanP*to set10:57
jordanPdeepakcs, ^^10:57
deepakcsjordanP: reading manpage again :) i guess u need to use -F only when there is a backing_file to point to, if there is no backing_file, then don't use -F10:57
deepakcsjordanP: yeah, u r right, was confused for some time10:58
lpetrutos-brick BPs go as Cinder BPs, right? We'd like to add Windows support, based on the Nova Hyper-V volume drivers. I'm afraid that may require a spec.10:58
deepakcsDuncanT: for fixing blockCOmmit case, why do i need a tempest testcase ? tempest indicates typical usecase and doesn't cover every case/scenario, we can re-create the blockCommit case outside of tempest in openstack10:59
jordanPdeepakcs, so that we don't introduce regression10:59
jordanPafter you fixed blockCommit :)11:00
deepakcsjordanP: right now there is no tempest code to test blockCommit, the way i see it :)11:00
jordanPdeepakcs, exactly. No failing test, no issue :)11:00
DuncanTdeepakcs: Given it's a fragile code area, more testing is good11:00
deepakcsjordanP: thats like closing ur eyes inspite of seeing a potential problem. as i said, a failign scenario can be created outside of tempest too.. that was the point i was making11:01
deepakcsjordanP: so are u good with the -F debate ? :)11:01
*** bluex-pl has quit IRC11:02
jordanPdeepakcs, I am good. Thank you and theanalyst lpetrut . Will submit something new soon11:02
jordanP**thanks lpetrut11:02
deepakcs:)11:03
DuncanTdeepakcs: Tempest is the only integration level testing we have, so I think putting corner cases in there is totally reasonable11:05
*** bluex-pl has joined #openstack-cinder11:05
DuncanTdeepakcs: Even if we create a new tempest section, especially for volume corner cases11:06
lifelessDuncanT: are they things that can't be expressed in the pure code?11:06
*** ociuhandu has quit IRC11:07
DuncanTlifeless: Interactions between nova and external tools/ not usefully, I don't think - they need to test very precise behaviours between two chunks of code, the none openstack-controlled one of which is fairly fast moving11:07
DuncanTlifeless: I think unit tests that mock out complex external tools are of relatively low value, since there is nothing testing that the external tool behaves (and continues to behave) the same as the mock11:08
lifelessDuncanT: I hate mocks11:09
lifelessDuncanT: so please don't interpret anything I said as being related to mocks :)11:09
DuncanTlifeless: They have their place, but they're really easy to over-use to the point you make your tests worthles11:09
lifelessDuncanT: like, using them at all :)11:09
DuncanTlifeless: So, if you weren't talking about mocks, I'd say tempest is pure code, and ask you to clarify the question :-)11:10
lifelessDuncanT: pure code vs io code11:10
lifelessDuncanT: it was a bit of a tease, since very very little of the openstack code I've seen is split into pure and IO code11:12
lifelessDuncanT: so - its a bit mean to ask it :)11:12
openstackgerritKyrylo Romanenko proposed openstack/python-cinderclient: Add tests for python-cinderclient  https://review.openstack.org/19764311:12
DuncanTlifeless: Ah, no, I think this requires real i/o code to ensure it continues to be correct, since it is the boundaries between openstack and libvirt et al that is the problem11:12
lifelessDuncanT: I'd like to dig into that at some point, since libvirt has a stable API11:13
DuncanTlifeless: Apart from the scheduler, 90% of cinder is just i/o martialing, so trying to do much of a split would be a false dictomy11:13
lifelessDuncanT: but - not now11:13
DuncanTlifeless: Stable API, not a stable feature set IMO, and the stable API has not been 100% stable on the fringes11:14
DuncanTlifeless: Sod trust but verify, I'm a fan of 'assume somebody is gonna bugger it up, and verify. Lots'.11:14
lifelessDuncanT: :) I likethat approach, but there are a few ways it can be assembled11:15
*** BharatK has quit IRC11:15
lifelessDuncanT: one way that I've used great success is to write a conformance test that runs against a blackbox interface11:15
lifelessDuncanT: make that as nasty and corner-casey as possible11:15
lifelessDuncanT: the run that against everything purporting to be $interface11:15
DuncanTlifeless: Yup, I'm a fan of that approach, but with nova/libvirt I don't have nearly enough domain knowledge to start11:16
*** tobe has quit IRC11:16
lifelessthe thing about the tempest approach that I don't like11:16
lifelessis that its actually hard to provoke a bunch of the corner cases11:16
lifelessbecause you're at such a remove from the actual libvirt behaviours11:16
DuncanTAgreed, especially anything timing or ordering related11:16
lifelessright11:17
DuncanTIn this particularly case, it is state related, which I'm pretty sure we can provoke11:17
lifelesson 'false dichotomy' - you might like to look at the Effect library11:17
DuncanTPython?11:17
lifelessand its 2317 here, so we might pick this up another day11:17
lifelessyeah11:17
lifelesshttps://pypi.python.org/pypi/effect11:17
DuncanTlifeless: Looks like callback chain hell to me at a glance, but I'll have a read through and play with the examples11:20
lifelessDuncanT: its in that space11:20
lifelessDuncanT: and I'm not super-super thrilled with it11:20
lifelessDuncanT: but, its got a lot more pure-and-testable to it than eventlet or twisted do11:20
DuncanTMaking more things purely functional has to be a good thing11:21
lifelessDuncanT: so rather than returning opaque deferreds, it returns a static introspectable data structure, which is the plan-of-IO this thing needs11:22
lifelessDuncanT: and you can make assertions about that11:22
lifelessanyhow, have a peek and a think. I'm poking around looking for really good things in this space atm11:23
DuncanTlifeless: Sounds more debuggable than most deferred callback stuff I've seen... I'll definitely take a look11:23
lifelesscool11:23
*** ociuhandu has joined #openstack-cinder11:34
*** subscope has quit IRC11:39
*** deepakcs has quit IRC11:50
*** subscope has joined #openstack-cinder11:53
*** ericksonsantos has joined #openstack-cinder11:53
*** jaypipes has joined #openstack-cinder11:54
*** ganso_ has joined #openstack-cinder11:57
*** subscope has quit IRC12:05
*** e0ne is now known as e0ne_12:08
*** anshul has quit IRC12:10
*** tpsilva has joined #openstack-cinder12:11
*** e0ne_ is now known as e0ne12:12
*** igor___ has joined #openstack-cinder12:14
openstackgerritMarcus V R Nascimento proposed openstack/cinder: Fix HBSD horcm driver with oslo.concurrency 2.1.0  https://review.openstack.org/19768612:17
*** subscope has joined #openstack-cinder12:21
*** e0ne_ has joined #openstack-cinder12:25
*** rakesh_mishra has joined #openstack-cinder12:26
*** bluex-pl has quit IRC12:26
*** coolsvap|afk is now known as coolsvap|away12:27
*** e0ne has quit IRC12:28
*** jasondotstar has joined #openstack-cinder12:33
*** smoriya has quit IRC12:38
*** zhenguo has quit IRC12:43
*** jordanP has quit IRC12:44
*** Longgeek has quit IRC12:49
*** Longgeek has joined #openstack-cinder12:49
*** IanGovett has quit IRC12:51
*** IanGovett has joined #openstack-cinder12:51
DTadrzakgit branch12:53
*** markvoelker has quit IRC12:53
*** nkrinner has quit IRC12:55
*** IanGovett has quit IRC12:56
openstackgerritDaniel Tadrzak proposed openstack/cinder: ConsistencyGroup Object  https://review.openstack.org/16364112:56
openstackgerritDaniel Tadrzak proposed openstack/cinder: CGSnapshot Object  https://review.openstack.org/19502712:56
*** markvoelker has joined #openstack-cinder13:00
*** jaypipes is now known as leakypipes13:01
openstackgerritDaniel Tadrzak proposed openstack/cinder: Cleanup for SnapshotObject  https://review.openstack.org/19834113:01
*** e0ne has joined #openstack-cinder13:05
*** mriedem has quit IRC13:07
*** e0ne_ has quit IRC13:08
*** Longgeek_ has joined #openstack-cinder13:14
*** Longgeek_ has quit IRC13:15
*** Longgeek has quit IRC13:15
*** Longgeek has joined #openstack-cinder13:16
*** DericHorn-HP has joined #openstack-cinder13:18
*** DericHorn-HP has quit IRC13:18
*** ankit8188 has quit IRC13:19
*** Apoorva has joined #openstack-cinder13:24
*** mutoulbj has joined #openstack-cinder13:28
*** mutoulbj has quit IRC13:29
openstackgerritIvan Mironov proposed openstack/cinder: Allow CoW cloning of ISO images on RBD.  https://review.openstack.org/19835413:35
*** bluex-pl has joined #openstack-cinder13:36
*** Apoorva has quit IRC13:41
*** Lee1092 has quit IRC13:45
*** eduardo has joined #openstack-cinder13:47
*** Adriano__ has joined #openstack-cinder13:47
*** bluex-pl has quit IRC13:47
*** jasondotstar has quit IRC13:50
*** ericksonsantos has quit IRC14:05
*** ericksonsantos has joined #openstack-cinder14:07
*** ronis__ has quit IRC14:14
*** ndipanov has quit IRC14:17
*** dtynan has quit IRC14:18
*** dtynan has joined #openstack-cinder14:18
*** ndipanov has joined #openstack-cinder14:19
*** mutoulbj has joined #openstack-cinder14:30
*** nkrinner has joined #openstack-cinder14:38
*** mutoulbj has quit IRC14:40
*** r-daneel has joined #openstack-cinder14:43
*** e0ne is now known as e0ne_14:44
*** e0ne_ is now known as e0ne14:46
*** diogogmt has joined #openstack-cinder14:48
*** haypo has left #openstack-cinder14:54
*** belmoreira has quit IRC14:54
*** mutoulbj has joined #openstack-cinder14:57
*** nihilifer has quit IRC14:59
*** markvoelker has quit IRC15:00
*** Lee1092 has joined #openstack-cinder15:03
*** rakesh_mishra has quit IRC15:04
*** shyama has quit IRC15:04
*** annashen has joined #openstack-cinder15:07
*** annashen has quit IRC15:18
*** afazekas has quit IRC15:26
*** bnemec has quit IRC15:27
openstackgerritChris Gacsal proposed openstack/cinder: Fix target removal in case of multi-attach  https://review.openstack.org/19840015:27
*** bnemec has joined #openstack-cinder15:28
*** _cjones_ has joined #openstack-cinder15:31
*** subscope has quit IRC15:35
*** subscope has joined #openstack-cinder15:35
*** haomaiw__ has joined #openstack-cinder15:40
*** haomaiwang has quit IRC15:42
*** p_deore has quit IRC15:44
*** vilobhmm has joined #openstack-cinder15:45
*** e0ne has quit IRC15:45
*** _cjones_ has quit IRC15:51
*** _cjones_ has joined #openstack-cinder15:52
*** ronis__ has joined #openstack-cinder15:52
*** ericksonsantos has quit IRC15:52
geguileowinston-d: ping - VolumeIsBusy stuff16:02
*** markus_z has quit IRC16:02
*** dims_ has quit IRC16:08
*** ronis__ has quit IRC16:21
*** haomaiwang has joined #openstack-cinder16:24
*** jistr has quit IRC16:24
*** reed has quit IRC16:25
*** reed_ is now known as reed16:25
*** haomaiw__ has quit IRC16:27
*** ctracey has quit IRC16:28
*** ctracey has joined #openstack-cinder16:28
*** lpetrut has quit IRC16:35
*** vilobhmm1 has joined #openstack-cinder16:37
*** vilobhmm has quit IRC16:37
*** mutoulbj has quit IRC16:46
*** drjones has joined #openstack-cinder16:47
*** drjones has quit IRC16:48
*** drjones has joined #openstack-cinder16:48
*** laughterwym has quit IRC16:49
*** markvoelker has joined #openstack-cinder16:49
*** _cjones_ has quit IRC16:49
openstackgerritTom Swanson proposed openstack/cinder: Dell SC: Add support for consistency groups  https://review.openstack.org/19681816:50
*** dims_ has joined #openstack-cinder16:51
*** dims_ has quit IRC17:01
*** serverascode has quit IRC17:04
*** serverascode has joined #openstack-cinder17:04
*** subscope has quit IRC17:09
*** mgarza_ has joined #openstack-cinder17:24
*** ociuhandu has quit IRC17:30
*** kaisers has quit IRC17:32
*** asselin_ has quit IRC17:33
*** ameade_vacation has quit IRC17:35
*** ameade_vacation has joined #openstack-cinder17:35
openstackgerritAlberto Murillo proposed openstack/cinder: Update expected error message from lvs  https://review.openstack.org/19733817:35
*** p_deore has joined #openstack-cinder17:40
*** _cjones_ has joined #openstack-cinder17:44
*** p_deore has quit IRC17:44
*** drjones has quit IRC17:44
*** vilobhmm1 has quit IRC17:45
*** drjones has joined #openstack-cinder17:46
*** drjones has quit IRC17:47
*** drjones has joined #openstack-cinder17:47
*** _cjones_ has quit IRC17:48
*** erlon has joined #openstack-cinder17:49
*** lpetrut has joined #openstack-cinder17:57
*** haomaiw__ has joined #openstack-cinder18:00
*** haomaiwang has quit IRC18:03
*** mgarza_ has quit IRC18:06
*** jasondotstar has joined #openstack-cinder18:07
*** bkopilov has quit IRC18:09
*** mgarza_ has joined #openstack-cinder18:10
*** boris-42 has quit IRC18:12
*** Svedrin has quit IRC18:16
*** haomai___ has joined #openstack-cinder18:17
*** zigo has quit IRC18:18
*** bkopilov has joined #openstack-cinder18:19
*** haomaiw__ has quit IRC18:19
*** Svedrin has joined #openstack-cinder18:21
*** zigo has joined #openstack-cinder18:22
*** strictlyb is now known as sb18:22
*** bnemec has quit IRC18:23
*** bnemec has joined #openstack-cinder18:24
*** lpetrut has quit IRC18:28
*** bkopilov has quit IRC18:31
*** IanGovett has joined #openstack-cinder18:34
*** _cjones_ has joined #openstack-cinder18:36
*** IanGovett has quit IRC18:38
*** drjones has quit IRC18:39
*** zhiyan has quit IRC18:41
*** zhiyan has joined #openstack-cinder18:41
*** jasondotstar has quit IRC18:42
*** bkopilov has joined #openstack-cinder18:46
*** mgarza_ has quit IRC18:49
*** edmondsw has joined #openstack-cinder18:52
*** edmondsw has quit IRC18:52
*** mgarza_ has joined #openstack-cinder18:57
-openstackstatus- NOTICE: etherpad.openstack.org is offline for scheduled database maintenance, ETA 19:30 UTC19:02
*** ChanServ changes topic to "etherpad.openstack.org is offline for scheduled database maintenance, ETA 19:30 UTC"19:02
*** Lee1092 has quit IRC19:25
*** bkopilov has quit IRC19:26
-openstackstatus- NOTICE: etherpad.openstack.org is still offline for scheduled database maintenance, ETA 19:45 UTC19:30
*** ChanServ changes topic to "etherpad.openstack.org is still offline for scheduled database maintenance, ETA 19:45 UTC"19:30
*** drjones has joined #openstack-cinder19:32
*** bkopilov has joined #openstack-cinder19:33
openstackgerritSean McGinnis proposed openstack/cinder: Remove useless logging from unit tests  https://review.openstack.org/19772319:33
*** igor___ has quit IRC19:33
openstackgerritAlberto Murillo proposed openstack/cinder: Update expected error message from lvs  https://review.openstack.org/19733819:33
*** _cjones_ has quit IRC19:34
*** bkopilov has quit IRC19:42
openstackgerritAmador Pahim proposed openstack/cinder: Do not accept qos name with only spaces  https://review.openstack.org/19565119:44
*** lpetrut has joined #openstack-cinder19:47
*** drjones has quit IRC19:47
*** _cjones_ has joined #openstack-cinder19:47
*** mgarza_ has quit IRC19:49
*** mgarza has joined #openstack-cinder19:49
*** tpsilva has quit IRC19:52
*** ChanServ changes topic to "The OpenStack Block Storage Project Cinder | The New Kids On the Block | https://wiki.openstack.org/wiki/Cinder"19:52
*** bkopilov has joined #openstack-cinder19:57
*** tpsilva has joined #openstack-cinder20:04
*** Svedrin has left #openstack-cinder20:07
*** jistr has joined #openstack-cinder20:08
*** lpetrut has quit IRC20:08
*** dtynan has quit IRC20:11
*** bkopilov has quit IRC20:11
*** dtynan has joined #openstack-cinder20:11
*** fifieldt_ has joined #openstack-cinder20:20
*** fifieldt has quit IRC20:22
*** tpsilva has quit IRC20:24
*** bkopilov has joined #openstack-cinder20:25
*** drjones has joined #openstack-cinder20:42
*** drjones has quit IRC20:42
*** drjones has joined #openstack-cinder20:43
*** _cjones_ has quit IRC20:43
*** Longgeek has quit IRC20:44
*** Longgeek has joined #openstack-cinder20:45
openstackgerritOpenStack Proposal Bot proposed openstack/python-cinderclient: Updated from global requirements  https://review.openstack.org/19727320:49
*** Longgeek has quit IRC20:49
*** jistr has quit IRC20:50
*** _cjones_ has joined #openstack-cinder21:01
*** mtanino has joined #openstack-cinder21:01
*** drjones has quit IRC21:04
*** nkrinner has quit IRC21:05
*** jasondotstar has joined #openstack-cinder21:08
*** marcusvrn has quit IRC21:34
*** ganso_ has quit IRC21:38
*** _cjones_ has quit IRC21:42
*** _cjones_ has joined #openstack-cinder21:42
*** Longgeek has joined #openstack-cinder21:46
*** erlon has quit IRC21:50
*** Longgeek has quit IRC21:58
*** r-daneel has quit IRC21:58
*** ociuhandu has joined #openstack-cinder22:05
openstackgerritJeremy Stanley proposed openstack/cinder: Fix MySQL backend migration test for innodb  https://review.openstack.org/19302722:06
*** Adriano__ has quit IRC22:12
*** ociuhandu has quit IRC22:15
*** rushiagr is now known as rushiagr_away22:23
*** mgarza has quit IRC22:26
*** drjones has joined #openstack-cinder22:32
*** _cjones_ has quit IRC22:32
*** ndipanov has quit IRC22:46
*** Longgeek has joined #openstack-cinder22:55
*** dims_ has joined #openstack-cinder23:01
*** dims_ has quit IRC23:07
*** dims_ has joined #openstack-cinder23:14
*** Longgeek has quit IRC23:17
*** dims_ has quit IRC23:18
*** haomai___ has quit IRC23:24
*** haomaiwang has joined #openstack-cinder23:25
*** _cjones_ has joined #openstack-cinder23:27
*** drjones has quit IRC23:29
*** andymccr has quit IRC23:30
*** andymccr has joined #openstack-cinder23:32
*** jasondotstar has quit IRC23:43
*** _cjones_ has quit IRC23:50
*** _cjones_ has joined #openstack-cinder23:51

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!