| *** tsekiyam_ has joined #openstack-cinder | 00:02 | |
| *** Apoorva has quit IRC | 00:03 | |
| *** hemna is now known as hemnafk | 00:04 | |
| *** tsekiyama has quit IRC | 00:06 | |
| *** mtanino has quit IRC | 00:06 | |
| *** tsekiyam_ has quit IRC | 00:07 | |
| *** garthb_ has quit IRC | 00:07 | |
| *** bswartz has quit IRC | 00:18 | |
| *** Rockyg has quit IRC | 00:29 | |
| *** heyun has joined #openstack-cinder | 00:30 | |
| *** albertom has quit IRC | 00:32 | |
| *** Yogi1 has quit IRC | 00:34 | |
| *** vokt has quit IRC | 00:35 | |
| *** leeantho has quit IRC | 00:37 | |
| *** albertom has joined #openstack-cinder | 00:40 | |
| *** adurbin_ has quit IRC | 00:46 | |
| openstackgerrit | xing-yang proposed openstack/os-brick: Add connector driver for the ScaleIO cinder driver https://review.openstack.org/185835 | 00:48 |
|---|---|---|
| *** xyang has quit IRC | 00:48 | |
| *** annashen has joined #openstack-cinder | 00:53 | |
| *** jdurgin has quit IRC | 00:56 | |
| *** annashen has quit IRC | 00:58 | |
| *** albertom has quit IRC | 01:02 | |
| *** dannywilson has quit IRC | 01:02 | |
| *** jasondotstar has joined #openstack-cinder | 01:02 | |
| *** blmartin has joined #openstack-cinder | 01:07 | |
| openstackgerrit | Li Yingjun proposed openstack/cinder: Validate maximum limit for quota https://review.openstack.org/165068 | 01:07 |
| *** patrickeast has quit IRC | 01:09 | |
| *** albertom has joined #openstack-cinder | 01:09 | |
| openstackgerrit | Liu Xinguo proposed openstack/cinder: Add iSCSI multipath support for Huawei driver https://review.openstack.org/188365 | 01:14 |
| *** laudo has quit IRC | 01:17 | |
| *** dims_ has quit IRC | 01:19 | |
| *** jwcroppe_ has quit IRC | 01:23 | |
| *** blmartin has quit IRC | 01:23 | |
| *** jasondotstar has quit IRC | 01:27 | |
| *** annegentle has quit IRC | 01:28 | |
| *** alau2 has quit IRC | 01:32 | |
| *** xyang has joined #openstack-cinder | 01:35 | |
| *** dims has joined #openstack-cinder | 01:39 | |
| *** ociuhandu has quit IRC | 01:46 | |
| *** mutoulbj has joined #openstack-cinder | 01:49 | |
| *** mutoulbj has quit IRC | 01:49 | |
| *** annashen has joined #openstack-cinder | 01:54 | |
| *** marcusvrn has joined #openstack-cinder | 01:55 | |
| *** blmartin has joined #openstack-cinder | 01:55 | |
| *** annashen has quit IRC | 01:58 | |
| openstackgerrit | liusheng proposed openstack/cinder: Switch to oslo.reports https://review.openstack.org/196489 | 01:59 |
| *** jwcroppe has joined #openstack-cinder | 02:01 | |
| *** mutoulbj has joined #openstack-cinder | 02:14 | |
| *** jwang_ has joined #openstack-cinder | 02:18 | |
| *** marcusvrn has quit IRC | 02:19 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Implement the update_migrated_volume for the drivers https://review.openstack.org/180873 | 02:19 |
| *** jwang__ has quit IRC | 02:21 | |
| *** rajinir has quit IRC | 02:25 | |
| *** xyang1 has quit IRC | 02:26 | |
| *** blmartin has quit IRC | 02:26 | |
| *** rajinir has joined #openstack-cinder | 02:27 | |
| *** rajinir has quit IRC | 02:29 | |
| *** rajinir has joined #openstack-cinder | 02:30 | |
| *** jaypipes has quit IRC | 02:30 | |
| *** bill_az has quit IRC | 02:33 | |
| *** Yogi1 has joined #openstack-cinder | 02:35 | |
| *** winston-d_zZZ is now known as winston-d | 02:36 | |
| *** blmartin has joined #openstack-cinder | 02:40 | |
| openstackgerrit | wanghao proposed openstack/cinder: Incremental backup improvements for L https://review.openstack.org/188328 | 02:43 |
| openstackgerrit | Kuo-tung Kao proposed openstack/python-cinderclient: Add more details for replication https://review.openstack.org/196562 | 02:50 |
| *** blmartin has quit IRC | 02:50 | |
| *** blmartin has joined #openstack-cinder | 02:51 | |
| *** annashen has joined #openstack-cinder | 02:55 | |
| *** annashen has quit IRC | 02:59 | |
| openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: Sheepdog: Add class for dog command executor https://review.openstack.org/194532 | 03:04 |
| *** davechen has joined #openstack-cinder | 03:12 | |
| *** davechen1 has joined #openstack-cinder | 03:14 | |
| *** blmartin has quit IRC | 03:14 | |
| *** davechen has quit IRC | 03:17 | |
| *** Yogi1 has quit IRC | 03:18 | |
| *** dims has quit IRC | 03:22 | |
| *** harlowja_at_home has joined #openstack-cinder | 03:24 | |
| *** BharatK has joined #openstack-cinder | 03:41 | |
| *** coolsvap|away is now known as coolsvap | 03:45 | |
| *** sgotliv has joined #openstack-cinder | 03:52 | |
| *** annashen has joined #openstack-cinder | 03:56 | |
| *** annashen has quit IRC | 04:00 | |
| *** BharatK has quit IRC | 04:04 | |
| *** harlowja_at_home has quit IRC | 04:05 | |
| *** xyang has quit IRC | 04:11 | |
| *** BharatK has joined #openstack-cinder | 04:17 | |
| *** DericHorn-HP has joined #openstack-cinder | 04:19 | |
| *** heyun has quit IRC | 04:20 | |
| *** heyun has joined #openstack-cinder | 04:21 | |
| *** DericHorn-HP has quit IRC | 04:23 | |
| *** davechen1 has quit IRC | 04:27 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder-specs: Volume migration improvement for Liberty version https://review.openstack.org/186327 | 04:27 |
| *** davechen has joined #openstack-cinder | 04:27 | |
| *** vincent_hou has joined #openstack-cinder | 04:28 | |
| vincent_hou | Hi cinder folks, I have updated the spec for the volume migration improvement: https://review.openstack.org/#/c/186327/28/specs/liberty/volume-migration-improvement.rst Thank you for your comments. | 04:29 |
| *** vilobhmm has joined #openstack-cinder | 04:29 | |
| *** ianbrown has joined #openstack-cinder | 04:30 | |
| *** yamada-h has joined #openstack-cinder | 04:41 | |
| *** rajinir has quit IRC | 04:43 | |
| *** delattec has joined #openstack-cinder | 04:43 | |
| *** jwcroppe_ has joined #openstack-cinder | 04:43 | |
| *** cdelatte has quit IRC | 04:45 | |
| *** jwcroppe has quit IRC | 04:46 | |
| *** nkrinner has joined #openstack-cinder | 04:54 | |
| *** BharatK has quit IRC | 04:54 | |
| *** harlowja_at_home has joined #openstack-cinder | 04:54 | |
| *** dobson has quit IRC | 04:55 | |
| *** annashen has joined #openstack-cinder | 04:56 | |
| *** amit213 has joined #openstack-cinder | 05:00 | |
| *** annashen has quit IRC | 05:01 | |
| *** dobson has joined #openstack-cinder | 05:02 | |
| *** BharatK has joined #openstack-cinder | 05:08 | |
| *** deepakcs has joined #openstack-cinder | 05:11 | |
| *** BharatK has quit IRC | 05:12 | |
| *** vilobhmm has quit IRC | 05:13 | |
| *** vilobhmm has joined #openstack-cinder | 05:13 | |
| *** shausy has joined #openstack-cinder | 05:15 | |
| *** DericHorn-HP has joined #openstack-cinder | 05:18 | |
| *** yamada-h_ has joined #openstack-cinder | 05:21 | |
| *** yamada-h has quit IRC | 05:24 | |
| *** harlowja_at_home has quit IRC | 05:27 | |
| *** BharatK has joined #openstack-cinder | 05:29 | |
| *** coolsvap is now known as coolsvap|away | 05:37 | |
| *** coolsvap|away is now known as coolsvap | 05:38 | |
| *** nihilifer has joined #openstack-cinder | 05:40 | |
| *** DericHorn-HP has quit IRC | 05:45 | |
| *** Longgeek has joined #openstack-cinder | 05:52 | |
| *** deepakcs has quit IRC | 05:53 | |
| *** deepakcs has joined #openstack-cinder | 05:53 | |
| *** coolsvap is now known as coolsvap|away | 05:54 | |
| *** annashen has joined #openstack-cinder | 05:57 | |
| *** annashen has quit IRC | 06:02 | |
| *** coolsvap|away is now known as coolsvap | 06:02 | |
| *** Vikash_cz has joined #openstack-cinder | 06:04 | |
| *** anshul has joined #openstack-cinder | 06:13 | |
| *** vincent_hou_ has joined #openstack-cinder | 06:15 | |
| openstackgerrit | wanghao proposed openstack/cinder: Incremental backup improvements for L https://review.openstack.org/188328 | 06:15 |
| *** coolsvap is now known as coolsvap|away | 06:16 | |
| *** vincent_hou has quit IRC | 06:17 | |
| *** vincent_hou_ is now known as vincent_hou | 06:17 | |
| openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: Sheepdog: change create and delete operation https://review.openstack.org/197393 | 06:18 |
| *** ianbrown has quit IRC | 06:29 | |
| *** belmoreira has joined #openstack-cinder | 06:44 | |
| *** vilobhmm has quit IRC | 06:45 | |
| *** belmoreira has quit IRC | 06:47 | |
| *** annashen has joined #openstack-cinder | 06:58 | |
| *** belmoreira has joined #openstack-cinder | 06:58 | |
| *** belmoreira has quit IRC | 06:58 | |
| *** belmoreira has joined #openstack-cinder | 06:59 | |
| *** annashen has quit IRC | 07:03 | |
| *** fifieldt has quit IRC | 07:09 | |
| *** yamada-h_ has quit IRC | 07:09 | |
| *** yamada-h has joined #openstack-cinder | 07:12 | |
| *** coolsvap|away has quit IRC | 07:20 | |
| openstackgerrit | Michal Dulko proposed openstack/cinder: Service object https://review.openstack.org/160417 | 07:23 |
| *** coolsvap|away has joined #openstack-cinder | 07:23 | |
| *** aix has joined #openstack-cinder | 07:24 | |
| *** mutoulbj_ has joined #openstack-cinder | 07:32 | |
| *** mutoulbj has quit IRC | 07:34 | |
| *** yamada-h has quit IRC | 07:44 | |
| *** jistr has joined #openstack-cinder | 07:48 | |
| *** pck has quit IRC | 07:50 | |
| *** pck has joined #openstack-cinder | 07:50 | |
| davechen | winston-d: zhiteng, ping? | 07:50 |
| openstackgerrit | Lin Yang proposed openstack/python-cinderclient: Fix typo in comment message https://review.openstack.org/179020 | 07:51 |
| davechen | DuncanT: ping? | 07:52 |
| DuncanT | davechen: hi | 07:53 |
| davechen | hi, Duncan :) | 07:53 |
| davechen | nice to see you are still online. | 07:53 |
| davechen | ah, can you help to review that patch again? | 07:54 |
| davechen | https://review.openstack.org/#/c/147726/, this is link | 07:55 |
| davechen | Sean and winston review that patch and give some comments recently. | 07:56 |
| openstackgerrit | Lin Yang proposed openstack/python-cinderclient: Improve error message when cinder quota exceeded https://review.openstack.org/178946 | 07:56 |
| davechen | Seems Sean are happy with that patch, he has voted +2 on that patch couple of days ago. | 07:57 |
| *** bluex-pl has joined #openstack-cinder | 07:57 | |
| *** bluex-pl has quit IRC | 07:58 | |
| *** bluex-pl has joined #openstack-cinder | 07:58 | |
| *** annashen has joined #openstack-cinder | 07:59 | |
| *** afazekas has joined #openstack-cinder | 08:01 | |
| *** annashen has quit IRC | 08:04 | |
| *** jordanP has joined #openstack-cinder | 08:06 | |
| *** dosaboy has quit IRC | 08:10 | |
| *** dosaboy has joined #openstack-cinder | 08:11 | |
| *** dosaboy has quit IRC | 08:12 | |
| *** rwsu has quit IRC | 08:13 | |
| *** rwsu has joined #openstack-cinder | 08:16 | |
| openstackgerrit | wanghao proposed openstack/cinder: Incremental backup improvements for L https://review.openstack.org/188328 | 08:20 |
| *** jamielennox is now known as jamielennox|away | 08:20 | |
| *** dosaboy has joined #openstack-cinder | 08:21 | |
| *** msno has joined #openstack-cinder | 08:28 | |
| msno | can i have enabled_backends = lvm-1,netapp_iscsi in cinder.conf to support multi backend | 08:29 |
| msno | is it supported or should i just have enabled_backends = netapp_iscsi to get netapp iscsi working | 08:30 |
| msno | by default it has enabled_backends = lvm-1 | 08:30 |
| msno | test | 08:36 |
| *** vincent_hou_ has joined #openstack-cinder | 08:37 | |
| msno | is there a netapp expert here in the room | 08:38 |
| *** vincent_hou has quit IRC | 08:39 | |
| *** vincent_hou_ is now known as vincent_hou | 08:39 | |
| *** jamielennox|away is now known as jamielennox | 08:41 | |
| *** ankit_ag has joined #openstack-cinder | 08:43 | |
| *** laughterwym has quit IRC | 08:49 | |
| *** aix has quit IRC | 08:50 | |
| *** Longgeek has quit IRC | 08:52 | |
| *** Longgeek has joined #openstack-cinder | 08:53 | |
| *** afazekas has quit IRC | 08:54 | |
| openstackgerrit | Gaurang Tapase proposed openstack/cinder: Adding NFS support to the GPFS Driver https://review.openstack.org/197884 | 08:54 |
| *** vincent_hou has quit IRC | 08:59 | |
| *** annashen has joined #openstack-cinder | 09:00 | |
| DuncanT | msno: If you don't want to use the LVM backend as well, then take it out. If you want to use both, then that is supported | 09:01 |
| msno | is this the right forum to ask cinder conf issues wrt netapp storage | 09:01 |
| DuncanT | msno: Yes, it is the right place to ask, however people can be slow to reply - we are all working on other things | 09:02 |
| msno | ok.. when i give both .. my tempest test fails on test_volume_types.VolumeTypesV1Test.test_create_get_delete_volume_with_volume_type_and_extra_specs | 09:02 |
| *** ndipanov has joined #openstack-cinder | 09:02 | |
| msno | when i take out netapp_iscsi this test passes | 09:02 |
| DuncanT | What about with just netapp_iscsi? | 09:04 |
| *** annashen has quit IRC | 09:04 | |
| msno | same result test_volume_types.VolumeTypesV1Test.test_create_get_delete_volume_with_volume_type_and_extra_specs fails | 09:06 |
| msno | so i guess.. netapp_iscsi is not able to pass that extra_specs checks | 09:07 |
| *** afazekas has joined #openstack-cinder | 09:09 | |
| *** gaurangt has joined #openstack-cinder | 09:10 | |
| openstackgerrit | Pradeep Sathasivam proposed openstack/cinder: Adds friendly zone name support https://review.openstack.org/180518 | 09:10 |
| *** BharatK has quit IRC | 09:16 | |
| msno | anyone has experience in working with netapp storage + openstack can give me a pointer | 09:17 |
| *** openstackgerrit has quit IRC | 09:19 | |
| *** openstackgerrit has joined #openstack-cinder | 09:20 | |
| *** jasondotstar has joined #openstack-cinder | 09:22 | |
| *** afazekas has quit IRC | 09:24 | |
| *** dims has joined #openstack-cinder | 09:24 | |
| *** BharatK has joined #openstack-cinder | 09:28 | |
| *** aix has joined #openstack-cinder | 09:34 | |
| *** e0ne has joined #openstack-cinder | 09:35 | |
| *** lixiaoy1 has quit IRC | 09:39 | |
| *** afazekas has joined #openstack-cinder | 09:39 | |
| *** e0ne is now known as e0ne_ | 09:46 | |
| *** BharatK has quit IRC | 09:46 | |
| *** davechen has left #openstack-cinder | 09:55 | |
| *** Swanson has quit IRC | 09:57 | |
| *** Swanson has joined #openstack-cinder | 09:58 | |
| *** dtynan has quit IRC | 10:00 | |
| *** dtynan has joined #openstack-cinder | 10:00 | |
| *** annashen has joined #openstack-cinder | 10:01 | |
| *** zerda has joined #openstack-cinder | 10:03 | |
| *** shyama has quit IRC | 10:03 | |
| *** yamada-h has joined #openstack-cinder | 10:04 | |
| *** e0ne_ is now known as e0ne | 10:05 | |
| *** annashen has quit IRC | 10:06 | |
| *** yamada-h has quit IRC | 10:08 | |
| *** ociuhandu has joined #openstack-cinder | 10:12 | |
| *** BharatK has joined #openstack-cinder | 10:14 | |
| *** IanGovett has joined #openstack-cinder | 10:16 | |
| *** ociuhandu has quit IRC | 10:19 | |
| *** mutoulbj_ has quit IRC | 10:19 | |
| *** mutoulbj has joined #openstack-cinder | 10:20 | |
| *** laughterwym has joined #openstack-cinder | 10:21 | |
| *** mutoulbj has quit IRC | 10:25 | |
| *** ociuhandu has joined #openstack-cinder | 10:27 | |
| *** BharatK has quit IRC | 10:34 | |
| *** BharatK has joined #openstack-cinder | 10:34 | |
| *** rushiagr_away is now known as rushiagr | 10:42 | |
| *** shyama has joined #openstack-cinder | 10:42 | |
| *** lpetrut has joined #openstack-cinder | 10:43 | |
| *** hakimo has joined #openstack-cinder | 10:55 | |
| *** annashen has joined #openstack-cinder | 11:02 | |
| openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: Sheepdog: change create and delete operation https://review.openstack.org/197393 | 11:02 |
| *** heyun has quit IRC | 11:04 | |
| *** ronis has joined #openstack-cinder | 11:05 | |
| *** annashen has quit IRC | 11:06 | |
| *** lpetrut has quit IRC | 11:08 | |
| *** gaurangt has left #openstack-cinder | 11:11 | |
| openstackgerrit | Teruaki Ishizaki proposed openstack/cinder: Sheepdog: change create and delete operation https://review.openstack.org/197393 | 11:12 |
| *** BharatK has quit IRC | 11:14 | |
| *** BharatK has joined #openstack-cinder | 11:14 | |
| *** mutoulbj has joined #openstack-cinder | 11:14 | |
| *** Apoorva has joined #openstack-cinder | 11:19 | |
| geguileo | DuncanT: ping | 11:22 |
| DuncanT | geguileo: hi | 11:23 |
| geguileo | DuncanT: Hi | 11:23 |
| geguileo | DuncanT: Yesterday you mentioned that we accept combinations of commands that queue on the lock on volume manager | 11:23 |
| geguileo | DuncanT: I don't know anything about that XD | 11:23 |
| geguileo | DuncanT: Could you point me to where in the code can I see an example, please? | 11:24 |
| DuncanT | geguileo: It is emergent behaviour. e.g. do a long running operation that locks on the volume, then delete the volume. Both operations complete in order | 11:26 |
| geguileo | Ok, I see what you mean | 11:27 |
| geguileo | Yes, the lock on the volume will make the delete wait | 11:27 |
| DuncanT | Yes | 11:27 |
| DuncanT | And there are client scripts based around that behaviour | 11:27 |
| geguileo | Ok, I thought you meant we actually had a queue in Cinder and I was surprised :) | 11:27 |
| *** lpetrut has joined #openstack-cinder | 11:28 | |
| geguileo | Then since we cannot break API contract | 11:28 |
| geguileo | Our options are use DLM or create new API, right? | 11:29 |
| DuncanT | geguileo: Exactly :-( | 11:29 |
| geguileo | Ok, that sucks but it's logical | 11:30 |
| *** deepakcs has quit IRC | 11:30 | |
| geguileo | hemnafk: Was working on removing locks from the manager, right? | 11:30 |
| geguileo | So how is he going to remove them? | 11:31 |
| geguileo | Since we cannot remove them without changing behavior? | 11:31 |
| *** lpabon has joined #openstack-cinder | 11:33 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Port image/glance.py to Python 3 https://review.openstack.org/197099 | 11:34 |
| *** e0ne is now known as e0ne_ | 11:34 | |
| geguileo | DuncanT: ^ (not the patch, but my last comment ;)) | 11:35 |
| *** e0ne_ is now known as e0ne | 11:36 | |
| DuncanT | geguileo: There not yet any good answer to that question | 11:36 |
| geguileo | DuncanT: Ok, I'll bother him on that one :) | 11:36 |
| geguileo | DuncanT: Thanks | 11:38 |
| DuncanT | You're welcome | 11:38 |
| *** Lee1092 has joined #openstack-cinder | 11:39 | |
| *** Apoorva has quit IRC | 11:42 | |
| openstackgerrit | Victor Stinner proposed openstack/cinder: Fix Python 3 issues in cmd https://review.openstack.org/197124 | 11:42 |
| *** marcusvrn has joined #openstack-cinder | 11:44 | |
| *** jasondotstar has quit IRC | 11:50 | |
| *** Apoorva has joined #openstack-cinder | 11:55 | |
| *** zhenguo has quit IRC | 12:01 | |
| *** ganso_ has joined #openstack-cinder | 12:02 | |
| *** annashen has joined #openstack-cinder | 12:02 | |
| *** e0ne is now known as e0ne_ | 12:06 | |
| *** annashen has quit IRC | 12:07 | |
| *** dtynan has quit IRC | 12:07 | |
| *** dtynan has joined #openstack-cinder | 12:08 | |
| *** shyama_ has joined #openstack-cinder | 12:09 | |
| openstackgerrit | Andrey Pavlov proposed openstack/cinder: Avoid race condition at snapshot deletion stage https://review.openstack.org/193596 | 12:09 |
| *** shyama has quit IRC | 12:09 | |
| *** shyama_ is now known as shyama | 12:10 | |
| *** p_deore has joined #openstack-cinder | 12:11 | |
| *** e0ne_ is now known as e0ne | 12:11 | |
| openstackgerrit | wanghao proposed openstack/cinder: Validate value when user update quota https://review.openstack.org/197938 | 12:12 |
| openstackgerrit | Andrey Pavlov proposed openstack/cinder: Avoid race condition at snapshot deletion stage https://review.openstack.org/193596 | 12:13 |
| openstackgerrit | Andrey Pavlov proposed openstack/cinder: Avoid race condition at snapshot deletion stage https://review.openstack.org/193596 | 12:16 |
| *** bill_az has joined #openstack-cinder | 12:17 | |
| *** julim has joined #openstack-cinder | 12:22 | |
| *** marcusvrn has quit IRC | 12:23 | |
| *** zerda has quit IRC | 12:24 | |
| *** marcusvrn has joined #openstack-cinder | 12:25 | |
| *** julim has quit IRC | 12:27 | |
| *** Apoorva has quit IRC | 12:29 | |
| *** jaypipes has joined #openstack-cinder | 12:32 | |
| *** annegentle has joined #openstack-cinder | 12:34 | |
| *** BharatK has quit IRC | 12:35 | |
| *** BharatK has joined #openstack-cinder | 12:36 | |
| *** jasondotstar has joined #openstack-cinder | 12:37 | |
| *** nkrinner has quit IRC | 12:38 | |
| *** edmondsw has joined #openstack-cinder | 12:42 | |
| *** marcusvrn has quit IRC | 12:43 | |
| *** lpetrut has left #openstack-cinder | 12:46 | |
| *** lpetrut has joined #openstack-cinder | 12:46 | |
| openstackgerrit | Andrey Pavlov proposed openstack/cinder: Avoid race condition at snapshot deletion stage https://review.openstack.org/193596 | 12:50 |
| *** amoturi has quit IRC | 12:53 | |
| *** amoturi has joined #openstack-cinder | 12:53 | |
| *** gaurangt has joined #openstack-cinder | 12:57 | |
| *** annashen has joined #openstack-cinder | 13:03 | |
| *** mutoulbj has quit IRC | 13:04 | |
| *** marcusvrn has joined #openstack-cinder | 13:05 | |
| *** annashen has quit IRC | 13:08 | |
| *** julim has joined #openstack-cinder | 13:15 | |
| *** zhenguo has joined #openstack-cinder | 13:16 | |
| *** ankit_ag has quit IRC | 13:23 | |
| *** thangp has joined #openstack-cinder | 13:23 | |
| *** mriedem has joined #openstack-cinder | 13:25 | |
| *** rmesta has joined #openstack-cinder | 13:26 | |
| *** e0ne is now known as e0ne_ | 13:29 | |
| *** mutoulbj has joined #openstack-cinder | 13:35 | |
| *** r-daneel has joined #openstack-cinder | 13:36 | |
| *** rmesta has left #openstack-cinder | 13:38 | |
| *** e0ne_ is now known as e0ne | 13:43 | |
| *** nihilifer has quit IRC | 13:45 | |
| *** fifieldt has joined #openstack-cinder | 13:53 | |
| *** amoturi_ has joined #openstack-cinder | 14:00 | |
| *** Apoorva has joined #openstack-cinder | 14:03 | |
| *** amoturi has quit IRC | 14:04 | |
| *** annegentle has quit IRC | 14:04 | |
| *** annashen has joined #openstack-cinder | 14:04 | |
| *** lcurtis has joined #openstack-cinder | 14:04 | |
| *** anshul has quit IRC | 14:08 | |
| *** blmartin has joined #openstack-cinder | 14:08 | |
| *** bluex-pl has quit IRC | 14:09 | |
| *** annashen has quit IRC | 14:09 | |
| *** Apoorva has quit IRC | 14:11 | |
| *** rmesta has joined #openstack-cinder | 14:14 | |
| *** Zhongjun has joined #openstack-cinder | 14:16 | |
| openstackgerrit | Vincent Hou proposed openstack/cinder: Implement the update_migrated_volume for the drivers https://review.openstack.org/180873 | 14:16 |
| *** rmesta has left #openstack-cinder | 14:16 | |
| *** BharatK has quit IRC | 14:16 | |
| *** dims has quit IRC | 14:19 | |
| openstackgerrit | Adriano Freires Rosso proposed openstack/cinder: Adds manage/unmanage methods for HNAS drivers https://review.openstack.org/197999 | 14:20 |
| *** aix has quit IRC | 14:21 | |
| openstackgerrit | Dave Chen proposed openstack/cinder: Role based properties protection https://review.openstack.org/160090 | 14:21 |
| openstackgerrit | Dave Chen proposed openstack/cinder: Policies based properties protection https://review.openstack.org/160145 | 14:22 |
| *** MentalRay has joined #openstack-cinder | 14:22 | |
| *** jungleboyj has joined #openstack-cinder | 14:22 | |
| *** BharatK has joined #openstack-cinder | 14:24 | |
| openstackgerrit | Adriano Freires Rosso proposed openstack/cinder: Adds manage/unmanage methods for HNAS drivers https://review.openstack.org/197999 | 14:25 |
| *** erlon has joined #openstack-cinder | 14:27 | |
| *** Vikash_cz has quit IRC | 14:28 | |
| *** eharney has quit IRC | 14:30 | |
| *** e0ne is now known as e0ne_ | 14:30 | |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: CGSnapshot Object https://review.openstack.org/195027 | 14:31 |
| openstackgerrit | Daniel Tadrzak proposed openstack/cinder: ConsistencyGroup Object https://review.openstack.org/163641 | 14:31 |
| *** e0ne_ is now known as e0ne | 14:32 | |
| jungleboyj | jgriffith: You around? | 14:35 |
| *** dims has joined #openstack-cinder | 14:38 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Pass volume size GB to copy_volume function https://review.openstack.org/198006 | 14:40 |
| *** annegentle has joined #openstack-cinder | 14:41 | |
| openstackgerrit | Ivan Kolodyazhny proposed openstack/cinder: Pass volume size in GB to copy_volume function https://review.openstack.org/198006 | 14:41 |
| *** dims has quit IRC | 14:44 | |
| *** dims has joined #openstack-cinder | 14:49 | |
| *** mutoulbj has quit IRC | 14:51 | |
| *** mutoulbj has joined #openstack-cinder | 14:52 | |
| *** mtanino has joined #openstack-cinder | 14:52 | |
| *** ronis has quit IRC | 14:56 | |
| *** xyang has joined #openstack-cinder | 14:59 | |
| *** bswartz has joined #openstack-cinder | 15:00 | |
| *** annashen has joined #openstack-cinder | 15:05 | |
| *** dims has quit IRC | 15:06 | |
| *** jskinner has joined #openstack-cinder | 15:06 | |
| *** Guest42148 has joined #openstack-cinder | 15:07 | |
| *** afazekas has quit IRC | 15:08 | |
| *** Guest42148 is now known as dims_ | 15:09 | |
| *** annashen has quit IRC | 15:10 | |
| *** belmoreira has quit IRC | 15:10 | |
| *** amoturi_ has quit IRC | 15:14 | |
| *** asselin_ has joined #openstack-cinder | 15:14 | |
| *** harlowja_at_home has joined #openstack-cinder | 15:14 | |
| *** MentalRay has quit IRC | 15:15 | |
| *** DericHorn-HP has joined #openstack-cinder | 15:18 | |
| *** chlong has quit IRC | 15:23 | |
| *** hemna has joined #openstack-cinder | 15:26 | |
| *** hemna has quit IRC | 15:29 | |
| *** hemna has joined #openstack-cinder | 15:30 | |
| *** hemna has quit IRC | 15:30 | |
| *** tpsilva has joined #openstack-cinder | 15:36 | |
| *** rakesh_mishra has joined #openstack-cinder | 15:44 | |
| rakesh_mishra | can any one help me please, | 15:45 |
| *** marcusvrn has quit IRC | 15:45 | |
| rakesh_mishra | i want to block cinder API's how can i do it? | 15:46 |
| smcginnis | rakesh_mishra: Not sure I understand what you mean. Can you elaborate? | 15:46 |
| rakesh_mishra | i want to disable some API | 15:46 |
| smcginnis | rakesh_mishra: Only some API calls but still have others accessible? | 15:47 |
| e0ne | rakesh_mishra: did you try policy.json? | 15:47 |
| rakesh_mishra | like cinder list should not work but cinder create should work | 15:47 |
| rakesh_mishra | yes | 15:47 |
| rakesh_mishra | "volume:create": "!" | 15:48 |
| rakesh_mishra | it disable the volume create api | 15:48 |
| *** laughterwym has quit IRC | 15:49 | |
| rakesh_mishra | but in def get_all(self, context, marker=None, limit=None, sort_keys=None, | 15:49 |
| rakesh_mishra | sort_dirs=None, filters=None, viewable_admin_meta=False): | 15:49 |
| rakesh_mishra | check_policy(context, 'get_all') | 15:49 |
| rakesh_mishra | we are checking the policy , that's why it doesn't allow the request | 15:50 |
| *** vokt has joined #openstack-cinder | 15:50 | |
| *** bswartz has quit IRC | 15:50 | |
| rakesh_mishra | but i don't want to change the source code for other API where we are not using check_policy | 15:51 |
| rakesh_mishra | but i want to disable the API | 15:51 |
| rakesh_mishra | @smcginnis, @e0ne : is there any way , i can give a list of api which should be support and rest of the API should disable | 15:53 |
| rakesh_mishra | or is there any way to disable the API from keystone? | 15:54 |
| *** vokt has quit IRC | 16:00 | |
| *** asselin_ has quit IRC | 16:02 | |
| *** jistr has quit IRC | 16:02 | |
| *** dannywilson has joined #openstack-cinder | 16:03 | |
| *** annashen has joined #openstack-cinder | 16:06 | |
| *** leeantho has joined #openstack-cinder | 16:07 | |
| smcginnis | rakesh_mishra: Sorry, pulled away. | 16:08 |
| *** __afazekas is now known as afazekas | 16:08 | |
| smcginnis | rakesh_mishra: Other than setting policy I don't know of another way. | 16:08 |
| smcginnis | rakesh_mishra: I suppose you can customize the code if you really really needed to, but... ick. | 16:09 |
| smcginnis | Sorry, gotta run again. | 16:09 |
| *** p_deore has quit IRC | 16:09 | |
| *** annashen has quit IRC | 16:10 | |
| *** leeantho has quit IRC | 16:11 | |
| *** ndipanov has quit IRC | 16:12 | |
| *** MentalRay has joined #openstack-cinder | 16:13 | |
| *** dannywilson has quit IRC | 16:14 | |
| *** bill_az has quit IRC | 16:15 | |
| *** _cjones_ has joined #openstack-cinder | 16:18 | |
| *** jordanP has quit IRC | 16:19 | |
| *** alau2 has joined #openstack-cinder | 16:21 | |
| *** annashen has joined #openstack-cinder | 16:26 | |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Fix backup metadata import missing fields https://review.openstack.org/183222 | 16:28 |
| openstackgerrit | Gorka Eguileor proposed openstack/cinder: Fix saving tz aware datetimes in Versioned Objects https://review.openstack.org/196071 | 16:28 |
| *** eharney has joined #openstack-cinder | 16:31 | |
| *** MentalRay has quit IRC | 16:31 | |
| haypo | hi. do you plan to release a new version of os-brick including hemnafk fixes for Python3? | 16:32 |
| e0ne | eharney: hi. did you have a time to review my patch? | 16:34 |
| eharney | e0ne: not yet | 16:34 |
| e0ne | ok, thanks | 16:35 |
| *** hemnafk is now known as hemna | 16:38 | |
| hemna | morning | 16:38 |
| *** MentalRay has joined #openstack-cinder | 16:38 | |
| nikeshm | hi, i am going back to INDIA today, so will be available on monday IST, in case any query, please send me email :) | 16:40 |
| *** garthb has joined #openstack-cinder | 16:42 | |
| *** annashen has quit IRC | 16:42 | |
| *** annashen has joined #openstack-cinder | 16:43 | |
| *** annashen has quit IRC | 16:43 | |
| *** annashen has joined #openstack-cinder | 16:44 | |
| nikeshm | rakesh_mishra : better to use "http://paste.openstack.org/" for posting code or contents of a file or traceback etc :) | 16:45 |
| rmstar | hi guys. anyone here for a quick question? :) | 16:47 |
| e0ne | rmstar: just ask it:) | 16:49 |
| *** tsekiyama has joined #openstack-cinder | 16:50 | |
| *** msno has quit IRC | 16:51 | |
| *** shausy has quit IRC | 16:53 | |
| *** storagesujai has joined #openstack-cinder | 16:54 | |
| *** patrickeast has joined #openstack-cinder | 16:55 | |
| *** ronis has joined #openstack-cinder | 16:59 | |
| *** rakesh_mishra has quit IRC | 16:59 | |
| *** BharatK has quit IRC | 17:01 | |
| *** annashen has quit IRC | 17:02 | |
| *** annashen has joined #openstack-cinder | 17:03 | |
| *** blmartin has quit IRC | 17:03 | |
| *** blmartin has joined #openstack-cinder | 17:03 | |
| *** annashen has quit IRC | 17:08 | |
| *** Zhongjun has quit IRC | 17:08 | |
| *** gaurangt1 has joined #openstack-cinder | 17:08 | |
| *** leeantho has joined #openstack-cinder | 17:10 | |
| *** garthb has quit IRC | 17:10 | |
| *** gaurangt has quit IRC | 17:10 | |
| *** Adriano__ has joined #openstack-cinder | 17:11 | |
| *** e0ne has quit IRC | 17:11 | |
| * thingee is so behind on irc backlog | 17:13 | |
| thingee | my favorite from yesterday's discussion on DLM and other random stuff was... | 17:13 |
| thingee | "nova cell is optional, but people get tricked into using it and hard to get away from it." | 17:13 |
| harlowja_at_home | lol | 17:17 |
| harlowja_at_home | thingee, where did u read that | 17:17 |
| * harlowja_at_home i still honestly believe cells is just a hack-fix for bigger fundamental issues | 17:19 | |
| *** jasondotstar is now known as jasondotstar|afk | 17:19 | |
| thingee | jgriffith: still catching up from yesterday's discussion... if we can write a sort-of-simple locks library ;) | 17:23 |
| *** BharatK has joined #openstack-cinder | 17:23 | |
| thingee | harlowja_at_home: in this channel yesterday at 17:35 utc | 17:23 |
| thingee | 17:36 rather | 17:23 |
| harlowja_at_home | thingee, ya, found it, interesting :-p | 17:24 |
| harlowja_at_home | sort-of-simple-locks library :-P | 17:24 |
| harlowja_at_home | sounds like tooz, ha | 17:24 |
| harlowja_at_home | how much simpler u want it :-P | 17:24 |
| patrickeast | sort of simpler? | 17:24 |
| harlowja_at_home | medium-simpler | 17:24 |
| harlowja_at_home | lol | 17:24 |
| patrickeast | lol | 17:24 |
| harlowja_at_home | with a side of veggies | 17:24 |
| thingee | I want options man. I want just in middle simple. | 17:25 |
| harlowja_at_home | how would u like your french fries sir | 17:25 |
| harlowja_at_home | is the poriddge just right, or to hot | 17:25 |
| thingee | plain, but a side of wiiiiiiine please | 17:25 |
| harlowja_at_home | ok, coming up | 17:26 |
| *** MentalRay has quit IRC | 17:26 | |
| Adriano__ | Hi guys... Is there any policy about reusing code from patches that aren't merged yet?? | 17:26 |
| geguileo | Adriano__: You mean your patch depends on that other patch? | 17:27 |
| patrickeast | dependant patches are A-ok, duplicating the code… less good | 17:27 |
| harlowja_at_home | oh ya, jgriffith pulled out the lipstick on a pig, nice | 17:27 |
| Adriano__ | no.. I just reused a part of the code | 17:28 |
| Adriano__ | but got a -1 asking about copyright issues or something like this | 17:28 |
| patrickeast | link? | 17:28 |
| Adriano__ | https://review.openstack.org/#/c/197999/ | 17:28 |
| *** bswartz has joined #openstack-cinder | 17:29 | |
| Adriano__ | patrickeast: https://review.openstack.org/#/c/197999/ | 17:29 |
| geguileo | Adriano__: No copyright issues | 17:29 |
| *** eharney has quit IRC | 17:29 | |
| geguileo | Adriano__: AFAIK | 17:30 |
| Adriano__ | geguileo: tks | 17:30 |
| patrickeast | yea i mean, you could make it a dependant patch so you both don’t add in that util change, otherwise someone would get a conflict | 17:30 |
| harlowja_at_home | ' 'cinder++' blue sky codebase' | 17:30 |
| harlowja_at_home | uh oh | 17:30 |
| harlowja_at_home | lol | 17:30 |
| harlowja_at_home | man this is a good one thingee :-P | 17:30 |
| geguileo | Adriano__: Usually do what patrickeast says | 17:30 |
| geguileo | Adriano__: We don't want the same code repeated all over the place | 17:31 |
| *** garthb has joined #openstack-cinder | 17:31 | |
| Adriano__ | geguileo: I see | 17:31 |
| Adriano__ | geguileo: but I needed to implement complementary functions in our driver and the common code is only in cinder/utils now | 17:34 |
| Adriano__ | geguileo: | 17:34 |
| geguileo | Adriano__: You mean that you only need some stuff from cinder/utils that the other patch has? | 17:35 |
| Adriano__ | geguileo: would it be dependant only because this cinder/utils? | 17:35 |
| Adriano__ | geguileo: yes | 17:35 |
| Adriano__ | geguileo: and it's replicated in my patch | 17:35 |
| *** anshul has joined #openstack-cinder | 17:35 | |
| geguileo | Adriano__: You should add the other as dependent, unless we are talking of 3 lines of code | 17:36 |
| *** anshul has quit IRC | 17:36 | |
| geguileo | Adriano__: You are getting "credit" for his code, and imagine your patch merges before his does | 17:36 |
| Adriano__ | geguileo: hmmm.. I see | 17:37 |
| geguileo | Adriano__: He will have a conflict, and imagine how you would feel if you got a conflict in your patch with somebody else's patch and you see that the conflict is your own code in other patch ;-) | 17:37 |
| Adriano__ | geguileo: Actually, it seems that the other patch is stopped for some time | 17:37 |
| Adriano__ | geguileo: But I agree | 17:37 |
| geguileo | Adriano__: Let me see it | 17:37 |
| Adriano__ | geguileo: I will do that | 17:38 |
| Adriano__ | geguileo: https://review.openstack.org/#/c/138125/14 | 17:38 |
| *** storagesujai has quit IRC | 17:38 | |
| geguileo | Adriano__: Ok, 3 months without any update on the patch | 17:39 |
| *** albertom has quit IRC | 17:39 | |
| *** annashen has joined #openstack-cinder | 17:39 | |
| *** garthb has quit IRC | 17:39 | |
| geguileo | Adriano__: Don't depend on that patch XD | 17:40 |
| geguileo | Adriano__: If you want to be polite drop him a line as a comment in his patch letting him know you'll be using that code | 17:40 |
| Adriano__ | geguileo | 17:40 |
| Adriano__ | tks | 17:40 |
| geguileo | Adriano__: np | 17:40 |
| Adriano__ | geguileo: Anyway, I'll try to contact someone involved in the other patch to talk about later :) | 17:41 |
| geguileo | Adriano__: Extra polite, that's always good ;-) | 17:43 |
| geguileo | hemna: ping - removing manager locks | 17:43 |
| harlowja_at_home | hemna, +1 on the 'ing' stuff, that'd really help | 17:44 |
| *** jasondotstar|afk has quit IRC | 17:45 | |
| harlowja_at_home | i mean make a cinder version of https://github.com/openstack/ironic/blob/master/ironic/common/states.py and start using it... | 17:45 |
| *** eharney has joined #openstack-cinder | 17:45 | |
| harlowja_at_home | get the 80% benefit, andddd then fix another 5% and ... | 17:45 |
| hemna | hey | 17:46 |
| *** albertom has joined #openstack-cinder | 17:47 | |
| geguileo | hemna: Got a minute? | 17:47 |
| hemna | sure | 17:47 |
| geguileo | hemna: You are working on removing the locks from the manager, right? | 17:47 |
| hemna | I'm not currently | 17:48 |
| hemna | nova has to change first | 17:48 |
| geguileo | hemna: I know, but I was told you were working on that ;-) | 17:48 |
| hemna | we had done research on doing it last release, and found that it broke Nova badly. | 17:49 |
| hemna | so Nova has to change in every call to Cinder to expect a VolumeIsBusy exception and gracefully handle that. | 17:49 |
| geguileo | Ok, so you haven't kept working on it | 17:49 |
| hemna | then Cinder's API can change to do the 'ing' checks on every call, and return VolumeIsBusy | 17:49 |
| hemna | nah, I haven't had time to | 17:49 |
| hemna | I've been slammed with os-brick work in Nova, and various other things | 17:50 |
| hemna | :( | 17:50 |
| geguileo | But then you would change the API contract | 17:50 |
| hemna | yup | 17:50 |
| hemna | it has to change | 17:50 |
| geguileo | Yeah, I've been seening lots of os-brick stauff | 17:50 |
| geguileo | hemna: But rules say that we cannot change the API that way, right? | 17:50 |
| hemna | rules? | 17:51 |
| hemna | :) | 17:51 |
| geguileo | XD XD XD | 17:51 |
| hemna | but anyway, we need a nova-spec laying it out | 17:51 |
| hemna | and then a BP | 17:51 |
| hemna | and then a patch | 17:51 |
| hemna | go through the normal process | 17:51 |
| geguileo | hemna: http://specs.openstack.org/openstack/api-wg/guidelines/evaluating_api_changes.html | 17:51 |
| geguileo | Those rules ;-) | 17:51 |
| geguileo | So our options as far as I can see are use DLM locks :-( or new API version :''-( | 17:52 |
| hemna | I'm not so sure about that | 17:53 |
| hemna | it's just catching an exception | 17:53 |
| geguileo | Because right now with those locks some clients may be queuing operations | 17:53 |
| hemna | which nova can get exceptions coming back already | 17:53 |
| hemna | timeouts, etc. | 17:53 |
| hemna | it's just catching a specific one | 17:54 |
| geguileo | Yes, I see the nova fix | 17:54 |
| hemna | it's a grey area IMHO | 17:54 |
| geguileo | And cinderclient can also be changed | 17:54 |
| geguileo | But other clients could be queuing operations based on current API behavior, right? | 17:54 |
| geguileo | Or scripts using cinderclient could be working based on this behaviour as well | 17:55 |
| * harlowja_at_home really VolumeIsBusy (imho) should of been there from the start (its really impossible to guarantee 100% of the time that a volume will not be busy) | 17:55 | |
| hemna | harlowja_at_home, +1 | 17:55 |
| geguileo | harlowja_at_home: The problem is that now we have "contracts" we must honor | 17:55 |
| geguileo | We cannot go around changing things because they were not done as they should in the first time | 17:56 |
| geguileo | s/in// | 17:56 |
| hemna | I dunno if it's a contract change though | 17:56 |
| harlowja_at_home | geguileo, understood, i get that | 17:56 |
| harlowja_at_home | isn't there a http code for this, one of those standard ones | 17:56 |
| geguileo | hemna: I think it is a contract change | 17:57 |
| patrickeast | asselin: oo just saw emails from the hp ci for the fc-passthrough, thats awesome! | 17:57 |
| harlowja_at_home | maybe next time, say in contract, 'we reserve the right to use any http code that we didn't use' | 17:57 |
| geguileo | Since most of the functionallity is not documented we rely on implicit contracts | 17:57 |
| geguileo | A lot of the time | 17:57 |
| harlowja_at_home | and then have little signature line that u get notarized + | 17:57 |
| geguileo | So that would be one of those implicit contracts :( | 17:57 |
| openstackgerrit | John Griffith proposed openstack/python-cinderclient: Revert "Enable version discovery" https://review.openstack.org/194476 | 17:57 |
| harlowja_at_home | ya, implict stuff sucks | 17:58 |
| geguileo | harlowja_at_home: But we don't love documenting either XD | 17:58 |
| harlowja_at_home | and thats how u end up with perl, lol | 17:58 |
| geguileo | XD XD XD | 17:59 |
| geguileo | hemna: So to summarize, we must decide if that implicit contract should be honored or not | 17:59 |
| geguileo | I think I'll send an email asking people to vote on this | 17:59 |
| geguileo | So we can really know how to go from here | 18:00 |
| *** ronis has quit IRC | 18:02 | |
| *** logan2 has quit IRC | 18:03 | |
| rmstar | ok. thanks eOne :D | 18:05 |
| rmstar | i am installing Juno, and I am at the part where i am installing storage node. After going through all the steps, should i see a new partition for the LVM? | 18:05 |
| *** harlowja_at_home has quit IRC | 18:06 | |
| thingee | geguileo: you might want to sync up with winston-d... he's currently tasked with the nova changes to expect VolumeIsBusy. | 18:08 |
| thingee | geguileo: he has been busy though, so it would be good if someone can make that move forward | 18:09 |
| * thingee finds bug | 18:09 | |
| geguileo | thingee: Ok, I'll ping him to see how he's doing with that | 18:09 |
| geguileo | thingee: But I think I should send the email to confirm that we agree on the API change on Cinder side | 18:10 |
| geguileo | thingee: It would be terrible if he keeps working on that and then we decide that we won't do the Cinder change because it breaks API contract | 18:10 |
| *** MentalRay has joined #openstack-cinder | 18:11 | |
| *** ronis has joined #openstack-cinder | 18:16 | |
| *** gaurangt1 has quit IRC | 18:16 | |
| *** annashen has quit IRC | 18:19 | |
| geguileo | winston-d: ping - VolumeIsBusy stuff | 18:19 |
| *** annashen has joined #openstack-cinder | 18:20 | |
| asselin | patrickeast, yeah! I have an intern learning ci and set everything up | 18:20 |
| asselin | he's not on freenode yet, but will be hopefully today | 18:20 |
| *** BharatK has quit IRC | 18:20 | |
| asselin | patrickeast, ok I'll review the patch now....thanks for being patient. :) | 18:22 |
| patrickeast | asselin: haha, no worries, i’m happy to see that stuff getting tested | 18:23 |
| patrickeast | asselin: i think so far i’m the only one who has needed those changes anyway | 18:23 |
| *** mutoulbj has quit IRC | 18:24 | |
| *** annashen has quit IRC | 18:24 | |
| hemna | geguileo, so I think step 1) is to create a nova-spec | 18:24 |
| hemna | detail out the changes | 18:24 |
| hemna | then do a ML post asking for feedback and discussion and point to the nova-spec | 18:25 |
| hemna | and detail out why it's needed, and how Cinder is broken, because of the lack of it, etc. | 18:25 |
| hemna | I can help if you like. | 18:25 |
| hemna | I'd be championing this one if I had time | 18:25 |
| *** rushiagr is now known as rushiagr_away | 18:26 | |
| geguileo | hemna: But the nova spec would made no sense if we are against changing Cinder API contract, right? | 18:27 |
| hemna | meh | 18:27 |
| hemna | write the spec, get the discussion started and buyin by all parties interested | 18:27 |
| hemna | that's how I'd approach it | 18:27 |
| hemna | we'll get feedback on the contract in the ML and the spec itself. | 18:28 |
| hemna | and figure out how to proceed | 18:28 |
| geguileo | hemna: So we work on the nova-specs, winston keeps working on the patch and then we decide we don't want to change the Cinder side... | 18:28 |
| hemna | if we don't start with the detailed spec, then there is no way we can move forward. | 18:28 |
| hemna | we have to change the cinder side IMO | 18:28 |
| geguileo | hemna: But the problem right now is not the contract with Nova | 18:28 |
| *** earlephilhower has quit IRC | 18:28 | |
| geguileo | hemna: Is with other clients outside our control | 18:28 |
| hemna | the entire point of the nova changes is so we can change the cinder side and remove the locks | 18:29 |
| hemna | we can't stay broken forever because of 'rules' | 18:29 |
| geguileo | hemna: But here are people who thing that we cannot change Cinder that way | 18:29 |
| geguileo | hemna: Anyway, I'll send the email with just the part of changing Cinder | 18:29 |
| geguileo | And start working on the specs, which will take me longer | 18:30 |
| hemna | don't send the email about the Cinder change without first discussing the nova changes. | 18:30 |
| hemna | or it makes no sense. | 18:30 |
| hemna | anyway, I've said my $0.02. | 18:30 |
| geguileo | hemna: You mean discuss the nova changes in a spec? With winston? With nova guys? | 18:31 |
| hemna | all of the above | 18:31 |
| hemna | I've stated my case pretty clearly. not sure where the confusion is. | 18:31 |
| geguileo | hemna: Ok, I'll talk with winston to see where he's at | 18:31 |
| *** r-daneel has quit IRC | 18:32 | |
| geguileo | hemna: Anyway, Nova specs are closed for L (afaik), so that's a no go for this cycle | 18:33 |
| *** zhenguo has quit IRC | 18:33 | |
| hemna | the spec's purpose is to detail and layout the changes | 18:33 |
| hemna | at this point, who cares if it can't make it in L | 18:34 |
| hemna | at least the spec is available for folks to reference and discuss. | 18:34 |
| geguileo | Ok | 18:34 |
| *** shyama has quit IRC | 18:38 | |
| *** Longgeek has quit IRC | 18:43 | |
| *** Longgeek has joined #openstack-cinder | 18:43 | |
| *** ronis has quit IRC | 18:44 | |
| *** e0ne has joined #openstack-cinder | 18:46 | |
| *** julim has quit IRC | 18:47 | |
| *** logan2 has joined #openstack-cinder | 18:49 | |
| *** r-daneel has joined #openstack-cinder | 18:50 | |
| *** dannywilson has joined #openstack-cinder | 18:50 | |
| *** VManiac16 has joined #openstack-cinder | 18:53 | |
| *** blmartin has quit IRC | 18:54 | |
| *** Longgeek has quit IRC | 18:54 | |
| *** dannywilson has quit IRC | 18:56 | |
| *** dannywilson has joined #openstack-cinder | 18:56 | |
| tbarron | Adriano__: just take what you need from that other patch https://review.openstack.org/#/c/138125/ | 18:58 |
| tbarron | Adriano__: Don't make your patch dependent on it. | 18:58 |
| tbarron | Adriano__: it is blocked waiting on NFS snapshots, which may still be a while. | 18:59 |
| tbarron | Adriano__: we went on and implemented manage/unmanage directly in NetApp NFS drivers instead of in generic NFS | 18:59 |
| tbarron | because of this blockage. | 18:59 |
| tbarron | When NFS snapshots get implmemted in the generic driver we can re-visit, implement manage-unmanage in generic NFS driver, and remove some code from our driver - and presumably yours too. | 19:00 |
| *** marcusvrn has joined #openstack-cinder | 19:01 | |
| *** Longgeek has joined #openstack-cinder | 19:02 | |
| Adriano__ | tbarron: Ok.. Tks for the info :) | 19:02 |
| tbarron | msno: just catching up on backlog here. NetApp is closed this week so we're slow responding, but ... | 19:02 |
| tbarron | Adriano__: np | 19:03 |
| marcusvrn | hi all, an oslo change broke my driver...I posted a patch to fix it, if someone can review it to fix the driver and turn the CI on again, would be great: https://review.openstack.org/#/c/197686/2 | 19:03 |
| tbarron | msno: you *can* certainly run with enabled_backends = lvm-1,netapp_iscsi in cinder.conf to support multi backend | 19:03 |
| tbarron | msno: for volume_type tempest tests modify this line in /etc/tempest; | 19:04 |
| *** sp4wnr0ot_ has joined #openstack-cinder | 19:05 | |
| tbarron | mwno: # Backend vendor to target when creating volume types (string value) | 19:05 |
| tbarron | mwno: vendor_name = NetApp | 19:05 |
| tbarron | msno: ^^ | 19:05 |
| e0ne | marcusvrn: did your CI find this issue? | 19:06 |
| *** tbarron is now known as tbarron_afk | 19:07 | |
| e0ne | marcusvrn: imo, it would be good to have such issue tested by 3rd-party CI and unit-tests | 19:07 |
| marcusvrn | e0ne: yes, actually after the oslo update it stopped | 19:07 |
| marcusvrn | I ran the CI on this patch | 19:08 |
| e0ne | marcusvrn: stopped? i thought it should just fail on every commit | 19:08 |
| marcusvrn | it's the HBSD2 CI | 19:08 |
| marcusvrn | e0ne: sry, yes..it's failling on every commit | 19:08 |
| e0ne | marcusvrn: thanks | 19:10 |
| *** Longgeek has quit IRC | 19:14 | |
| *** marcusvrn_ has joined #openstack-cinder | 19:14 | |
| *** lpetrut has quit IRC | 19:16 | |
| *** marcusvrn has quit IRC | 19:17 | |
| *** marcusvrn_ is now known as marcusvrn | 19:17 | |
| *** annashen has joined #openstack-cinder | 19:20 | |
| *** nikeshm has quit IRC | 19:20 | |
| *** annashen has quit IRC | 19:25 | |
| *** lpetrut has joined #openstack-cinder | 19:31 | |
| *** delatte has joined #openstack-cinder | 19:34 | |
| *** lpetrut has quit IRC | 19:34 | |
| jgriffith | thingee: thingee jgriffith: in reply to your unit test for check methods implemented by drivers, wouldn't CI catch this from ABC eventually? The volume manager would be unable to load due a method not being implemented. | 19:37 |
| jgriffith | thingee: oops...NM | 19:37 |
| jgriffith | LOL | 19:37 |
| *** delattec has quit IRC | 19:37 | |
| *** Lee1092 has quit IRC | 19:45 | |
| *** igor___ has joined #openstack-cinder | 19:48 | |
| *** ociuhandu has quit IRC | 19:49 | |
| *** jasondotstar|afk has joined #openstack-cinder | 19:49 | |
| *** DericHorn-HP has quit IRC | 19:53 | |
| *** mtanino has quit IRC | 19:54 | |
| *** e0ne has quit IRC | 19:55 | |
| *** tbarron_afk is now known as tbarron | 19:57 | |
| *** marcusvrn1 has joined #openstack-cinder | 19:59 | |
| *** sp4wnr0ot_ has quit IRC | 20:01 | |
| eharney | LIO CI proposed: https://review.openstack.org/#/c/198079/ | 20:03 |
| *** marcusvrn1 has quit IRC | 20:09 | |
| *** boris-42 has quit IRC | 20:12 | |
| *** thangp has quit IRC | 20:13 | |
| *** edmondsw has quit IRC | 20:14 | |
| *** Longgeek has joined #openstack-cinder | 20:14 | |
| *** dtynan has quit IRC | 20:15 | |
| *** e0ne has joined #openstack-cinder | 20:15 | |
| *** dtynan has joined #openstack-cinder | 20:15 | |
| *** hodos has joined #openstack-cinder | 20:17 | |
| *** mtanino has joined #openstack-cinder | 20:18 | |
| *** annashen has joined #openstack-cinder | 20:21 | |
| *** jasondotstar|afk has quit IRC | 20:22 | |
| *** annashen has quit IRC | 20:26 | |
| hemna | eharney, nice | 20:30 |
| *** jasondotstar|afk has joined #openstack-cinder | 20:34 | |
| *** tpsilva has quit IRC | 20:35 | |
| *** reed has quit IRC | 20:37 | |
| *** reed_ is now known as reed | 20:37 | |
| *** reed has quit IRC | 20:38 | |
| *** reed has joined #openstack-cinder | 20:38 | |
| *** reed_ has joined #openstack-cinder | 20:38 | |
| *** jwcroppe has joined #openstack-cinder | 20:48 | |
| *** jskinner has quit IRC | 20:49 | |
| *** jwcroppe_ has quit IRC | 20:50 | |
| *** jwcroppe_ has joined #openstack-cinder | 20:51 | |
| *** jwcroppe has quit IRC | 20:53 | |
| *** jwcroppe has joined #openstack-cinder | 20:54 | |
| *** jwcroppe_ has quit IRC | 20:56 | |
| *** jskinner has joined #openstack-cinder | 20:56 | |
| *** DericHorn-HP has joined #openstack-cinder | 20:56 | |
| *** jskinner has quit IRC | 21:02 | |
| *** annashen has joined #openstack-cinder | 21:04 | |
| *** jwcroppe_ has joined #openstack-cinder | 21:08 | |
| *** Rockyg has joined #openstack-cinder | 21:08 | |
| *** DericHorn-HP has quit IRC | 21:08 | |
| *** annegentle has quit IRC | 21:08 | |
| *** jwcroppe has quit IRC | 21:09 | |
| *** r-daneel has quit IRC | 21:11 | |
| *** xyang has quit IRC | 21:12 | |
| *** jasondotstar|afk has quit IRC | 21:17 | |
| *** tbarron is now known as tbarron_afk | 21:17 | |
| *** ganso_ has quit IRC | 21:18 | |
| *** Apoorva has joined #openstack-cinder | 21:18 | |
| *** Longgeek has quit IRC | 21:20 | |
| *** e0ne has quit IRC | 21:20 | |
| *** logan2 has quit IRC | 21:31 | |
| *** Apoorva has quit IRC | 21:31 | |
| *** Rockyg has quit IRC | 21:31 | |
| *** DericHorn-HP has joined #openstack-cinder | 21:33 | |
| *** lpabon has quit IRC | 21:36 | |
| *** mriedem has quit IRC | 21:36 | |
| *** DericHorn-HP has quit IRC | 21:40 | |
| *** boris-42 has joined #openstack-cinder | 21:49 | |
| *** logan2 has joined #openstack-cinder | 21:56 | |
| *** ianbrown has joined #openstack-cinder | 22:01 | |
| *** r-daneel has joined #openstack-cinder | 22:04 | |
| *** rwsu has quit IRC | 22:05 | |
| *** annegentle has joined #openstack-cinder | 22:07 | |
| *** pv_ has joined #openstack-cinder | 22:11 | |
| pv_ | i have done basic testing on my local vm for the cinder driver I am writing | 22:11 |
| pv_ | and everything seems to be working with our backend | 22:12 |
| pv_ | how do i now test my driver code with the upperlevel cinder client? | 22:12 |
| pv_ | if thats even possible | 22:12 |
| patrickeast | pv_: im not 100% sure what you mean by upperlevel cinder client, but if you mean the python-cinderclient you can do that with devstack, just put your driver code in there and configure it to use your backend | 22:14 |
| pv_ | hell yes thats exactly what i meant | 22:15 |
| pv_ | ok | 22:15 |
| pv_ | ill look into devstack | 22:15 |
| pv_ | thanks | 22:15 |
| patrickeast | np | 22:15 |
| *** eharney has quit IRC | 22:15 | |
| *** Longgeek has joined #openstack-cinder | 22:17 | |
| *** chlong has joined #openstack-cinder | 22:18 | |
| thingee | jgriffith: https://review.openstack.org/#/c/191192/3 | 22:18 |
| thingee | jgriffith: been 90 something days now | 22:18 |
| hemna | 90! | 22:19 |
| hemna | yah +A that shit | 22:19 |
| hemna | want me to pull the trigger ? | 22:20 |
| jgriffith | done | 22:20 |
| thingee | I also reached out to them a while back http://lists.openstack.org/pipermail/third-party-announce/2015-June/000200.html | 22:20 |
| jgriffith | thingee: you get to run interference when I get the nasty email from DuncanT | 22:20 |
| jgriffith | thingee: about that spec... | 22:21 |
| jgriffith | thingee: :) | 22:21 |
| thingee | jgriffith: yup! | 22:21 |
| jgriffith | thingee: so is the plan to just clean up the report_stats in the drivers and expose it via API call? | 22:21 |
| thingee | yes | 22:22 |
| jgriffith | thingee: IMHO that would be the right way to go | 22:22 |
| jgriffith | thingee: ok | 22:22 |
| jgriffith | cool | 22:22 |
| *** DericHorn-HP has joined #openstack-cinder | 22:24 | |
| *** annegentle has quit IRC | 22:24 | |
| thingee | jgriffith: so are we going to thinking of non-standard capabilities as the extra specs that get passed into the volume driver? | 22:24 |
| thingee | and standard capabilities would be what the scheduler can filter on? | 22:24 |
| *** annegentle has joined #openstack-cinder | 22:24 | |
| jgriffith | thingee: I guess so, but the thing is the scheduler CAN filter on anything that's reported in that dict | 22:25 |
| *** Longgeek has quit IRC | 22:25 | |
| jgriffith | thingee: if it's in the capabilities dict from the stats call it's filterable via an extra-spec key | 22:25 |
| jgriffith | thingee: know what I mean? | 22:25 |
| thingee | ok, so if we don't include them in the report stats... or is capabilities a separate report to the scheduler.. | 22:25 |
| jgriffith | thingee: so report_stats is what goes to the scheduler | 22:26 |
| jgriffith | thingee: ie it "is" the capabilities | 22:26 |
| jgriffith | thingee: I don't know how we ended up with two names there | 22:26 |
| thingee | oh I see by "clean up the report_stats" ... you didn't mean remove capabilities there completely | 22:27 |
| thingee | my mistake | 22:27 |
| *** ociuhandu has joined #openstack-cinder | 22:27 | |
| jgriffith | nahh, I just meant rather than reinvent everything just start with exposing what we already have | 22:27 |
| thingee | so non-standard capabilities still makes it a mess IMO, but that's left up to the driver. maybe we're ok with that though | 22:27 |
| jgriffith | thingee: yeah, I'm just thinking if we expose the update_stats or whatever we want to call if for now that's at least fwd progress | 22:28 |
| jgriffith | and *should* be non-controversial | 22:28 |
| thingee | jgriffith: like this already does? https://github.com/openstack/cinder/blob/master/cinder/api/contrib/scheduler_stats.py ... except being a particular backend | 22:29 |
| *** annegentle has quit IRC | 22:30 | |
| thingee | jgriffith: https://github.com/openstack/cinder/blob/master/cinder/api/views/scheduler_stats.py | 22:30 |
| jgriffith | thingee: maybe the same... I was actually saying just retrieve and return: https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/lvm.py#L248 | 22:30 |
| jgriffith | so you'd just leverage all the existing stuff the scheduler uses today | 22:31 |
| jgriffith | maybe do some fancy formatting on it, and spit it out as proper json to the end-user | 22:31 |
| jgriffith | odone | 22:31 |
| thingee | is this as a first step? are we still going to do the standards and non-standards? | 22:33 |
| jgriffith | thingee: well, I'm not as interested in that as some, but yes... I would call it a "first" step | 22:33 |
| jgriffith | thingee: just seems relatively straight forward | 22:33 |
| jgriffith | thingee: and if people want "more stuff" they can easily add it there | 22:34 |
| jgriffith | thingee: we could derive standard based on what common across everyrthing there | 22:34 |
| jgriffith | which kinda makes sense to me | 22:34 |
| thingee | ok | 22:34 |
| thingee | so the formatting then | 22:34 |
| thingee | we had different ideas there before. | 22:35 |
| thingee | and people bring up this graffiti thing | 22:35 |
| thingee | Here's what I want... I want people to be able to know what the extra spec keys are from a backend they have deployed. The driver gets that information how they choose. | 22:36 |
| jgriffith | thingee: well... I'm not really a fan of what's going on with all of that. But if people want to work on it and provide something sane I'm certainly not going to block it | 22:36 |
| jgriffith | thingee: so I see what you're saying | 22:36 |
| *** annashen has quit IRC | 22:36 | |
| *** briancurtin has quit IRC | 22:36 | |
| jgriffith | thingee: but I still argue that for anything other than the standard/common stuff, vendors should write a doc | 22:37 |
| jgriffith | thingee: but we could certainly make it work IMO | 22:37 |
| jgriffith | thingee: so just append the "vendor-unique" stuff into it's own dict | 22:37 |
| *** DericHorn-HP has quit IRC | 22:37 | |
| jgriffith | thingee: and that means the work/effort is up to the vendor interested in exposing the info | 22:37 |
| *** andymccr has quit IRC | 22:38 | |
| thingee | yup | 22:38 |
| jgriffith | thingee: in other words they need to setup the call in their driver to collect the data and append it to the update_stats call (if it's not there already) | 22:38 |
| thingee | are no longer worried about the amount of data we're sending? | 22:38 |
| thingee | are we* | 22:38 |
| jgriffith | Well, that's the thing... | 22:39 |
| jgriffith | we're already sending the stuff in that update_stats call every 60 seconds | 22:39 |
| *** briancurtin has joined #openstack-cinder | 22:39 | |
| jgriffith | adding additional vendor-unique stuff "when asked" isn't a big deal I don't think | 22:39 |
| jgriffith | thingee: do you want me to show you a prototype of what I'm talking about? | 22:39 |
| thingee | I see, a flag to ask for the appended data to report stats. | 22:39 |
| thingee | that are vendor unique | 22:40 |
| thingee | here's an idea...why not let the manager store in memory the last set of capabilities. if that changes, report it up with the next stats update? | 22:41 |
| *** dannywilson has quit IRC | 22:41 | |
| *** erlon has quit IRC | 22:41 | |
| *** rhefner has quit IRC | 22:41 | |
| *** dannywilson has joined #openstack-cinder | 22:42 | |
| *** amit213 has quit IRC | 22:42 | |
| *** MentalRay has quit IRC | 22:43 | |
| *** rwall has quit IRC | 22:43 | |
| *** erlon has joined #openstack-cinder | 22:44 | |
| *** andymccr has joined #openstack-cinder | 22:44 | |
| *** lcurtis has quit IRC | 22:44 | |
| *** rhefner has joined #openstack-cinder | 22:44 | |
| *** rwall has joined #openstack-cinder | 22:44 | |
| *** VManiac16 has quit IRC | 22:50 | |
| thingee | rhe00_: are you around? | 22:50 |
| *** annashen has joined #openstack-cinder | 22:53 | |
| *** mtanino has quit IRC | 22:59 | |
| *** erlon has quit IRC | 23:00 | |
| *** tsekiyama has quit IRC | 23:01 | |
| thingee | jgriffith: ^ in case you didn't see my earlier comments, but yeah I would be happy to see your prototype | 23:01 |
| *** tsekiyama has joined #openstack-cinder | 23:01 | |
| *** annashen has quit IRC | 23:02 | |
| *** dannywilson has quit IRC | 23:03 | |
| *** r-daneel has quit IRC | 23:09 | |
| *** mtanino has joined #openstack-cinder | 23:13 | |
| *** BharatK has joined #openstack-cinder | 23:14 | |
| thingee | jgriffith: unrelated , my long running juno setup has almost 7000 lock files in the cinder state directory =/ | 23:16 |
| jgriffith | thingee: sigh | 23:16 |
| jgriffith | that's just embarassing IMO | 23:16 |
| patrickeast | :o where are they all coming from? | 23:18 |
| jgriffith | patrickeast: everybody that creates a lock file in their driver, and those in the manager | 23:19 |
| jgriffith | or anywhere else for that matter | 23:19 |
| patrickeast | well yea, but those should be cleaned up in normal use, right? | 23:19 |
| jgriffith | patrickeast: people are great at creating lock files, but they don't know how to delete them when they're done | 23:19 |
| jgriffith | *should* | 23:19 |
| jgriffith | I was told by duncan and others you "can't" | 23:19 |
| jgriffith | it was a big long argument in IRC when I filed a bug against it | 23:20 |
| patrickeast | so maybe i should have asked this *before* putting locks in my driver… but i assumed the lock decorator did the right thing, does it not? | 23:20 |
| jgriffith | I think I'll just write a periodic that deletes any older than 24 hours | 23:20 |
| jgriffith | patrickeast: you might want to verify that | 23:20 |
| jgriffith | patrickeast: nova IIRC cleans up its files when it's done | 23:20 |
| patrickeast | hmm thats not good | 23:21 |
| jgriffith | patrickeast: indeed, it's not good at all | 23:21 |
| *** hodos has quit IRC | 23:21 | |
| mtreinish | patrickeast: if it's the oslo.concurrency lock decorator with an external lock it should delete the lock file when the function exits | 23:23 |
| jgriffith | mtreinish: Yeah, in Juno we had a bunch of folks add some home-grown lock decos IIRC | 23:23 |
| patrickeast | mtreinish: ah perfect, so as long as it exits the function its ok | 23:23 |
| patrickeast | what happens if the service is killed mid-function? | 23:23 |
| jgriffith | but I could be wrong on that | 23:24 |
| *** pv_ has quit IRC | 23:27 | |
| mtreinish | patrickeast: if the process stops midfunction then the lock file will probably be left dangling | 23:27 |
| mtreinish | because the rm will never be called | 23:27 |
| mtreinish | but that'll be like if something crashes | 23:27 |
| mtreinish | jgriffith: hmm, yeah that seems weird | 23:27 |
| openstackgerrit | Patrick East proposed openstack/cinder: WIP generic image cache https://review.openstack.org/195795 | 23:28 |
| mtreinish | I'm also confused what you guys are doing if you're making thousands of lock files | 23:28 |
| mtreinish | are there that many potential inter-process conflicts | 23:29 |
| openstackgerrit | Patrick East proposed openstack/cinder: WIP generic image cache https://review.openstack.org/195795 | 23:30 |
| patrickeast | mtreinish: not sure about the other vendors, but we have some issues around creating/modifying config stuff on our array in parallel so some volume operations have to be locked | 23:30 |
| patrickeast | mtreinish: so if someone was hammering cinder with those type of commands it could build up pretty quick | 23:31 |
| mtreinish | patrickeast: sure but shouldn't that just be 1 lock for config operations (or a couple for different types) | 23:31 |
| patrickeast | mtreinish: ah yea, good point | 23:31 |
| patrickeast | i wonder if something is generating a lock name from a volume id or something? | 23:32 |
| *** alexpilotti has joined #openstack-cinder | 23:32 | |
| jgriffith | mtreinish: IMO NO, locks are very heavily abused by drivers writers and others | 23:32 |
| jgriffith | mtreinish: but it turns out I apparantly didn't realize that a bunch of vendors backend devices can't do simultaneous api calls to a resource | 23:33 |
| jgriffith | which seems ludicrous to me | 23:33 |
| patrickeast | jgriffith: speaking of scary things, i got non-public images to work with the cache… but it required some uh… unnatural acts | 23:34 |
| patrickeast | haha | 23:34 |
| jgriffith | patrickeast: LOL | 23:34 |
| mtreinish | heh ok, whatever. I'm still confused, because if you need to serialize api calls to your expensive san because it can't handle multiple requests that still seems like 1 lock to me | 23:35 |
| patrickeast | check out the diff between the last two patches on that POC review | 23:35 |
| mtreinish | but I'll let it go | 23:35 |
| jgriffith | I'm still trying to convince our IT dept to log on to the switch and figure out how the darn iSCSI port got blocked | 23:35 |
| *** lixiaoy1 has joined #openstack-cinder | 23:35 | |
| jgriffith | they keep coming back "we don't block anything" | 23:35 |
| jgriffith | oi vai | 23:35 |
| *** IanGovett has quit IRC | 23:35 | |
| patrickeast | mtreinish: yea i agree, something else must be going on to get thousands of lock files | 23:35 |
| jgriffith | mtreinish: no.. you're absolutely correct IMO | 23:35 |
| *** chlong has quit IRC | 23:36 | |
| *** alexpilotti has quit IRC | 23:38 | |
| mtreinish | jgriffith: hehe, ok | 23:38 |
| *** lixiaoy11 has joined #openstack-cinder | 23:40 | |
| mtreinish | jgriffith: ah, now I see what you mean, you've got things like: http://git.openstack.org/cgit/openstack/cinder/tree/cinder/volume/drivers/hitachi/hbsd_basiclib.py#n176 | 23:40 |
| thingee | jgriffith: this juno setup was using lvm | 23:41 |
| mtreinish | if they're reinventing things like that I'm sure it's leaky | 23:41 |
| *** lixiaoy1 has quit IRC | 23:41 | |
| *** Adriano__ has quit IRC | 23:42 | |
| *** yamada-h has joined #openstack-cinder | 23:42 | |
| jgriffith | thingee: hmm... lvm driver has no locks... but people have been sprinkling them all over through the manager and API code | 23:42 |
| jgriffith | maybe other places as well | 23:42 |
| thingee | yeah, was just saying | 23:43 |
| jgriffith | any-who... mtreinish yes... like that one :( | 23:43 |
| thingee | jgriffith: do you have time for us to go back to capabilities? we never finished | 23:43 |
| jgriffith | thingee: here's your culprit I think: http://git.openstack.org/cgit/openstack/cinder/tree/cinder/volume/manager.py#n126 | 23:43 |
| mtreinish | jgriffith: ah, yeah that would do it, a per volume external lock | 23:44 |
| mtreinish | that'll create a lot of file noise | 23:44 |
| jgriffith | mtreinish: yup | 23:44 |
| thingee | jgriffith: yup matches what I'm seeing in the state directory | 23:44 |
| jgriffith | shame shame | 23:44 |
| *** alexpilotti has joined #openstack-cinder | 23:44 | |
| jgriffith | thingee: beside, IMO they're of little value in most of those places anyway | 23:44 |
| jgriffith | which is highly annoying | 23:45 |
| jgriffith | thingee: kinda.. I have about 5 minutes until I get dagger eyes from my wife | 23:45 |
| patrickeast | are those the infamous manager locks i keep hearning about when HA topics come up? | 23:45 |
| thingee | jgriffith: not getting in the middle of that. | 23:45 |
| jgriffith | patrickeast: yes, and those are what some folks would like to create "more" of | 23:45 |
| jgriffith | thingee: LOL | 23:45 |
| jgriffith | smart man! | 23:45 |
| thingee | jgriffith: so from earlier | 23:46 |
| thingee | 15:40 <thingee> I see, a flag to ask for the appended data to report stats. | 23:46 |
| thingee | 15:40 <thingee> that are vendor unique | 23:46 |
| thingee | 15:41 <thingee> here's an idea...why not let the manager store in memory the last set of capabilities. if that changes, report it up with the next stats update? | 23:46 |
| *** alexpilotti has quit IRC | 23:46 | |
| *** yamada-h has quit IRC | 23:47 | |
| *** jskinner has joined #openstack-cinder | 23:47 | |
| jgriffith | thingee: yeah... a flag that's set by another API call even | 23:47 |
| jgriffith | thingee: so the "in mem and update" might be an ok idea as well | 23:47 |
| jgriffith | thingee: but we already poll the stats call every 60 seconds anyway | 23:48 |
| *** zhenguo has joined #openstack-cinder | 23:48 | |
| thingee | jgriffith: so then when does the scheduler get the capabilities with your approach? I would assume this flag would be a cast directly to the backend, which the scheduler wouldn't know about | 23:49 |
| jgriffith | thingee: so for the vendor unique stuff correct, I wouldn't provide it to the scheduler | 23:50 |
| thingee | backend in my last message meant c-vol service,whoops | 23:50 |
| jgriffith | thingee: but you just suggested storing it in memory | 23:50 |
| jgriffith | so I dunno :) | 23:50 |
| thingee | well yeah, earlier I though we were saying the scheduler could filter on these. | 23:50 |
| thingee | so in order to do that... | 23:50 |
| thingee | we need to tell the scheduler every now and then. | 23:51 |
| thingee | and in order to determine when we need to would be, on start up, and if the driver thinks the capabilities changed. | 23:51 |
| jgriffith | thingee: so if you want the scheduler to filter on them they MUST be in that stats update | 23:51 |
| jgriffith | thingee: so that's an impl detail as far as I'm concerned | 23:52 |
| jgriffith | thingee: and it's left to the driver | 23:52 |
| jgriffith | I don't give a rip how it does it frankly :) | 23:52 |
| thingee | jgriffith: let me try again | 23:52 |
| thingee | jgriffith: in order to filter on capabilities we need them in the stats. We don't want to send these all the time because of the size with the appended unique stuff. How the driver gets the information to surface up to the manager is not what we're concerned with. What I was thinking is we could enforce at the manager level when it should send it for the | 23:55 |
| thingee | appended information in the stats. If the manager keeps in memory at startup what the capabilities were that came from the driver, it can from there on out not send them along with the stats update. If the driver reports something different for capabilities, the manager can compare and recognize it has to send up the capabilities with the stats update. | 23:55 |
| thingee | jgriffith: but I agree, we could just not enforce anything in the manager and let drivers do what they want. | 23:56 |
| jgriffith | thingee: so I'm "ok" with the memory idea maybe...honestly I'm not sure about the concern over size (but I don't know what monster someone is going to build with this) | 23:58 |
| *** laughterwym has joined #openstack-cinder | 23:58 | |
| jgriffith | thingee: I know *some* of this has to be periodic for the capacity filter obviously | 23:58 |
| jgriffith | thingee: but yes a number of things could be just on init and stored | 23:58 |
| jgriffith | thingee: and even updated by driver when need be | 23:59 |
| thingee | jgriffith: I'm unsure of the size issue too. I'm not familiar with message queues in this regard. | 23:59 |
| thingee | jgriffith: this was just raised in the midcycle meetup by DuncanT I believe | 23:59 |
| jgriffith | thingee: it's probably ok... just "stupid" | 23:59 |
| jgriffith | could be | 23:59 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!