| *** claudiub has quit IRC | 00:00 | |
| *** ybathia has quit IRC | 00:32 | |
| openstackgerrit | Jim Mankovich proposed openstack/ceilometer-specs: Generic Notification Sensor Meter Plugin Design Spec https://review.openstack.org/130359 | 00:51 |
|---|---|---|
| *** boris-42 has joined #openstack-ceilometer | 01:13 | |
| *** kbyrne has quit IRC | 01:23 | |
| *** kbyrne has joined #openstack-ceilometer | 01:25 | |
| *** promulo has joined #openstack-ceilometer | 01:30 | |
| *** promulo__ has quit IRC | 01:34 | |
| *** ddieterl_ has joined #openstack-ceilometer | 02:06 | |
| *** ddieterly has quit IRC | 02:09 | |
| *** shengjiemin has quit IRC | 02:17 | |
| *** himangi has quit IRC | 02:58 | |
| *** deepthi has joined #openstack-ceilometer | 03:37 | |
| *** ddieterl_ has quit IRC | 03:47 | |
| *** _nadya_ has joined #openstack-ceilometer | 04:10 | |
| *** rwsu-afk has quit IRC | 04:19 | |
| *** _nadya_ has quit IRC | 04:34 | |
| *** himangi has joined #openstack-ceilometer | 04:52 | |
| *** pcaruana has quit IRC | 05:45 | |
| *** ddieterly has joined #openstack-ceilometer | 05:49 | |
| *** ddieterly has quit IRC | 05:53 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ceilometer: Imported Translations from Transifex https://review.openstack.org/155197 | 06:05 |
| *** ildikov has quit IRC | 06:38 | |
| *** ddieterly has joined #openstack-ceilometer | 06:50 | |
| *** yatin has joined #openstack-ceilometer | 06:51 | |
| *** ddieterly has quit IRC | 06:54 | |
| *** himangi has quit IRC | 06:58 | |
| *** ildikov has joined #openstack-ceilometer | 07:32 | |
| *** ddieterly has joined #openstack-ceilometer | 07:50 | |
| *** ddieterly has quit IRC | 07:55 | |
| *** theanalyst has quit IRC | 08:14 | |
| *** theanalyst has joined #openstack-ceilometer | 08:15 | |
| *** eglynn has joined #openstack-ceilometer | 08:16 | |
| *** Ala has joined #openstack-ceilometer | 08:21 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/ceilometer: Remove duplications from docco https://review.openstack.org/157703 | 08:21 |
| *** ildikov has quit IRC | 08:50 | |
| *** ddieterly has joined #openstack-ceilometer | 08:51 | |
| *** ddieterly has quit IRC | 08:56 | |
| *** ildikov has joined #openstack-ceilometer | 09:06 | |
| *** yatin has quit IRC | 09:12 | |
| *** yatin has joined #openstack-ceilometer | 09:25 | |
| *** ddieterly has joined #openstack-ceilometer | 09:52 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/ceilometer: Remove duplications from docco https://review.openstack.org/157703 | 09:54 |
| *** ddieterly has quit IRC | 09:56 | |
| *** ParsectiX has joined #openstack-ceilometer | 10:02 | |
| *** claudiub has joined #openstack-ceilometer | 10:03 | |
| openstackgerrit | Mehdi Abaakouk proposed openstack/ceilometer: alarming: add gnocchi alarm rules https://review.openstack.org/155712 | 10:09 |
| openstackgerrit | Mehdi Abaakouk proposed openstack/ceilometer: api: move alarm rules into they directory https://review.openstack.org/155711 | 10:09 |
| *** yatin has quit IRC | 10:42 | |
| *** kbyrne has quit IRC | 10:49 | |
| *** kbyrne has joined #openstack-ceilometer | 10:49 | |
| *** ddieterly has joined #openstack-ceilometer | 10:53 | |
| *** yatin has joined #openstack-ceilometer | 10:55 | |
| *** ddieterly has quit IRC | 10:57 | |
| *** himangi has joined #openstack-ceilometer | 11:16 | |
| *** yatin has quit IRC | 11:22 | |
| *** ofcourseistilllo is now known as straycat_ | 11:28 | |
| *** straycat_ is now known as straycat | 11:29 | |
| *** nellysmitt has joined #openstack-ceilometer | 11:29 | |
| *** cdent has joined #openstack-ceilometer | 11:32 | |
| *** yatin has joined #openstack-ceilometer | 11:40 | |
| *** deepthi has quit IRC | 11:45 | |
| *** ddieterly has joined #openstack-ceilometer | 11:53 | |
| *** ddieterly has quit IRC | 11:58 | |
| *** cdent has quit IRC | 12:18 | |
| openstackgerrit | Ildiko Vancsa proposed openstack/ceilometer: Remove duplications from docco https://review.openstack.org/157703 | 12:19 |
| *** exploreshaifali has joined #openstack-ceilometer | 12:25 | |
| *** cdent has joined #openstack-ceilometer | 12:41 | |
| *** yatin has quit IRC | 12:47 | |
| *** zigo has quit IRC | 12:52 | |
| *** ddieterly has joined #openstack-ceilometer | 12:54 | |
| *** zigo has joined #openstack-ceilometer | 12:56 | |
| *** ddieterly has quit IRC | 12:58 | |
| *** yatin has joined #openstack-ceilometer | 13:00 | |
| *** yatin has quit IRC | 13:02 | |
| linuxhermit | good morning | 13:08 |
| *** ParsectiX has quit IRC | 13:10 | |
| *** ParsectiX has joined #openstack-ceilometer | 13:16 | |
| *** lsmola has quit IRC | 13:23 | |
| * cdent waves at linuxhermit | 13:23 | |
| cdent | Can I get your opinion on something linuxhermit? Look at this: https://tank.peermore.com/_/6dd71fd5-194c-45ea-82a8-be3a65e5040c | 13:24 |
| cdent | note the number of xfails and links to bugs | 13:24 |
| linuxhermit | hmm | 13:24 |
| linuxhermit | I like that | 13:24 |
| cdent | Most of those bugs represent opinions on API design, rather than hard and fast rules. So I'm not sure whether to really care. What do you think? | 13:24 |
| linuxhermit | it explains the xfail | 13:24 |
| linuxhermit | well as an outsider | 13:24 |
| linuxhermit | those type things drive me crazy | 13:25 |
| linuxhermit | like sending data with get | 13:25 |
| * cdent nods | 13:25 | |
| linuxhermit | but I'm not casting stones because there is a whole wide world of ways to do things | 13:25 |
| linuxhermit | here is my concern | 13:25 |
| linuxhermit | with doing this, will we be diligent enough to come back and fix the tests when the bugs are gone? | 13:26 |
| linuxhermit | if you think yes, then I'm all for it | 13:26 |
| cdent | that's the main reason I've dedided to actually make bugs (and link them in) rather than just make xfails | 13:26 |
| linuxhermit | cool then I'll do it for mine that works wierd like that | 13:26 |
| cdent | I think it is far more likely the bugs will get fixed in gnocchi (as yet unreleased) than in the main ceilo core | 13:27 |
| cdent | But I think it is worthwhile being optimistic :) | 13:27 |
| *** lsmola has joined #openstack-ceilometer | 13:27 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ceilometer: Updated from global requirements https://review.openstack.org/157641 | 13:28 |
| linuxhermit | nod | 13:28 |
| linuxhermit | I can go with that | 13:28 |
| cdent | eglynn: you have any thoughts on the above? | 13:29 |
| *** gordc has joined #openstack-ceilometer | 13:30 | |
| cdent | what about you gordc have you got an opinion on the stuff that linuxhermit and I were just talking about: http://eavesdrop.openstack.org/irclogs/%23openstack-ceilometer/%23openstack-ceilometer.2015-02-23.log | 13:38 |
| linuxhermit | I've got one I'm a touch confused on | 13:39 |
| linuxhermit | so if I have {"q": { "field": "event_type", "op": "eq", "type": "string" "value": "cookies_chocolate.chip"}} | 13:39 |
| linuxhermit | that I want to send as data | 13:39 |
| linuxhermit | do I do data: then that or do I need to yamlfy it in someway | 13:40 |
| linuxhermit | or just enclose it as a string? | 13:40 |
| cdent | you're going to send that as the body? | 13:40 |
| linuxhermit | yeah | 13:40 |
| cdent | maybe this http://paste.openstack.org/show/180553/ | 13:41 |
| * cdent is not too savvy on the complex query format | 13:41 | |
| cdent | but that's how you can state a json object in the data key | 13:41 |
| linuxhermit | okay | 13:42 |
| linuxhermit | ServerError: {"error_message": {"faultstring": "string indices must be integers, not str", "debuginfo": null, "faultcode": "Server"}} | 13:42 |
| linuxhermit | something about that it doesn't like I'll keep digging | 13:42 |
| *** eglynn has quit IRC | 13:42 | |
| linuxhermit | I think it sent the data correctly | 13:43 |
| linuxhermit | I just don't think the server liked what it got | 13:43 |
| ildikov | cdent: that example above is simple query actually: http://docs.openstack.org/developer/ceilometer/webapi/v2.html#Query | 13:43 |
| ildikov | linuxhermit: ^^^ | 13:43 |
| openstackgerrit | afazekas proposed openstack/ceilometer: requests-aws is runtime dependency https://review.openstack.org/158296 | 13:43 |
| linuxhermit | Thanks ildikov for the link | 13:44 |
| cdent | ildikov: I was meaning complex in the sense that it does in the body | 13:44 |
| linuxhermit | in this case it was more gabbi + dat ain get body | 13:44 |
| cdent | linuxhermit: you want a - in front of a field | 13:44 |
| cdent | to make it a list | 13:44 |
| ildikov | cdent: in the body? | 13:44 |
| linuxhermit | it's not a list though right | 13:44 |
| cdent | i'll update the paste, just a sec | 13:44 |
| linuxhermit | it's q is a json object | 13:44 |
| ildikov | cdent: hmm, I guess I should check back for context :) | 13:44 |
| cdent | in here the value of q is a list: http://docs.openstack.org/developer/ceilometer/webapi/v2.html#api-queries | 13:45 |
| cdent | http://paste.openstack.org/show/180559/ | 13:45 |
| * cdent boggles | 13:46 | |
| openstackgerrit | afazekas proposed openstack/ceilometer: requests-aws is a runtime dependency https://review.openstack.org/158296 | 13:46 |
| linuxhermit | hmm okay | 13:47 |
| *** thomasem has joined #openstack-ceilometer | 13:49 | |
| *** eglynn has joined #openstack-ceilometer | 13:53 | |
| gordc | cdent: whoops. stupid irssi doesn't highlight my name if it's in middle of sentence | 13:53 |
| *** ddieterly has joined #openstack-ceilometer | 13:55 | |
| gordc | cdent: what's the question? if it's cool to add a FIXME to testcase? | 13:58 |
| cdent | gordc: if the gripes about the api are even valid in the first place | 13:59 |
| cdent | (e.g. 404 on an intervening path being bad) | 13:59 |
| *** ddieterly has quit IRC | 14:00 | |
| gordc | 404 seems to make sense for a bad path. is there a better match? | 14:00 |
| *** eglynn has quit IRC | 14:01 | |
| cdent | gordc: the example in those cases is like /v1/resources being 404 when /v1/resource/generic is 200 with a [] | 14:02 |
| cdent | seems like resources should return something, not a 404 | 14:02 |
| cdent | so should /v1 | 14:03 |
| gordc | are you using v1 as just an example? (since v1 doesn't exist anymore) | 14:03 |
| gordc | oh wait. gnocchi | 14:03 |
| gordc | i'd probably lean more towards 404 to be honest... having it return 20x and empty makes it seem like it's suppose to be an actionable path (ie. under some conditions it would return something useful) | 14:05 |
| cdent | the bugs explain it a bit more: https://bugs.launchpad.net/gnocchi/+bug/1423990 | 14:06 |
| openstack | Launchpad bug 1423990 in Gnocchi "/resource returns 404 should probably be list of resource types" [Undecided,New] | 14:06 |
| cdent | and | 14:06 |
| cdent | https://bugs.launchpad.net/gnocchi/+bug/1424627 | 14:06 |
| openstack | Launchpad bug 1424627 in Gnocchi "/v1 returns 404, should maybe be json links" [Undecided,New] | 14:06 |
| cdent | the basic question is: is lack of hypermedia a bug? | 14:07 |
| gordc | cdent: ah i see... make it more a 'get_all' response. | 14:07 |
| gordc | cdent: yeah i could see it being useful to list all resources. | 14:08 |
| *** eglynn has joined #openstack-ceilometer | 14:13 | |
| *** eglynn-office has joined #openstack-ceilometer | 14:14 | |
| openstackgerrit | Jason Myers proposed openstack/ceilometer: Adding Gabbi Tests to Events API https://review.openstack.org/156667 | 14:16 |
| linuxhermit | cdent pushed up a new version with the suggestions you made | 14:16 |
| linuxhermit | gordc in one of you doc patches, do you already have a fix for http://docs.openstack.org/developer/ceilometer/webapi/v2.html#get--v2-event_types-%28event_type%29-traits-%28event_type%29 | 14:17 |
| linuxhermit | using event_type twice instead of event_type and trait_name | 14:18 |
| * cdent looks | 14:18 | |
| gordc | linuxhermit: nope i don't have a fix for that. | 14:18 |
| linuxhermit | cool I'll get one rolling | 14:18 |
| gordc | i think you'll need to modify api code for that (i think it's generated by wsme-sphinx or something along that line) | 14:19 |
| gordc | linuxhermit: cool cool | 14:19 |
| *** exploreshaifali has quit IRC | 14:21 | |
| linuxhermit | gordc never mind looks like it's fixed in code but the docs haven't been regened since then | 14:21 |
| gordc | linuxhermit: odd. i guess you have to directly touch the rst files to trigger a refresh of docs | 14:24 |
| gordc | or i pointed you in the wrong direction. | 14:24 |
| linuxhermit | https://github.com/openstack/ceilometer/blob/master/ceilometer/api/controllers/v2/events.py#L184 | 14:25 |
| linuxhermit | seems to be where the controller is, and in the docs it points to that using the rest-controller:: ceilometer.api.controllers.v2.events:TraitsController directive | 14:26 |
| cdent | linuxhermit I've found it useful on bugs like this one: https://bugs.launchpad.net/ceilometer/+bug/1424642 to provide the gabbi-formatted yaml that tickles the bug. It provides a clear replication strategy and spreads the love. | 14:29 |
| openstack | Launchpad bug 1424642 in Ceilometer "Wrong Content Type results in Server error" [Undecided,New] | 14:29 |
| linuxhermit | added cdent | 14:31 |
| cdent | cool thanks | 14:31 |
| openstackgerrit | Jason Myers proposed openstack/ceilometer: Adding Gabbi Tests to Events API https://review.openstack.org/156667 | 14:33 |
| linuxhermit | those two commends are also fixed and pushed back up as well | 14:33 |
| cdent | eglynn, eglynn-office, gordc You guys might want to have a look at https://review.openstack.org/#/c/158296/ | 14:33 |
| cdent | Sean asks a question I've been asking myself since last May. | 14:33 |
| gordc | yes | 14:33 |
| gordc | whoops... that was me trying to commit something | 14:34 |
| gordc | but yes i will look to (sort of have to now) | 14:34 |
| cdent | gordc has a depedendent patchset! | 14:34 |
| gordc | :) | 14:34 |
| eglynn | swamireddy: ^^^ note also | 14:35 |
| gordc | hmm..yeah we need a way to catch it. i agree with sdague | 14:35 |
| cdent | I agree with sdague too. | 14:36 |
| cdent | We shouldn't be dumping the kitchen sink in setup.cfg | 14:36 |
| cdent | because even if we do conditionally import the S3Auth thing, it will always get imported because stevedore will go romping along and gather the code, won't it? | 14:37 |
| *** ddieterly has joined #openstack-ceilometer | 14:37 | |
| cdent | gerrit needs +1 buttons on comments | 14:37 |
| * cdent switches to facebook to review code | 14:38 | |
| *** claudiub has quit IRC | 14:38 | |
| gordc | cdent: make a script. | 14:38 |
| cdent | if user == "gordc": plus_one() | 14:38 |
| gordc | that's going to trigger a bug to be created | 14:40 |
| gordc | so apparently that bug is breaking the gate. | 14:40 |
| cdent | I reckon we should consider reverting the rgw stuff? | 14:40 |
| gordc | cdent: seems agressive. i do wonder how it passed to begin with... | 14:42 |
| cdent | Something else must have changed around the same time. | 14:42 |
| cdent | The way requests is loaded in the gate changed recently. | 14:42 |
| cdent | s/loaded/installed/ | 14:42 |
| cdent | so that might have had some kind of impact | 14:43 |
| eglynn | this only landed on what, Saturday? | 14:43 |
| gordc | cdent: yep | 14:43 |
| cdent | nearabouts, yeah, eglynn | 14:43 |
| eglynn | TBH I'd be OK with a revert until we have a chance to upack this | 14:43 |
| eglynn | swamireddy: ^^^ we can re-commit once the aws dependency is sorted out | 14:44 |
| cdent | This problem is present in every other plugin which has external dependencies, isn't it? It just so happens that this particular failure has caused some upset because of timing. Our fix in all other times has been to put the missing library in requirements.txt, has it not? | 14:46 |
| cdent | So while I agree with sdague in principle, if we to take his word as gospel we'd have a _lot_ of plugins to revert, wouldn't we? (which would be ossum, but that's a different discussion) | 14:48 |
| gordc | cdent: this shouldn't be loaded. ceph requirements should only be present if you specifically want to to poll ceph | 14:48 |
| cdent | so what about pysnmp | 14:48 |
| cdent | or tooz (which is only needed is doing coordination) | 14:48 |
| gordc | i would say pysnmp shouldn't be there... tooz is actually pretty well integrate across most of the core services so it should be there (even if disabled) | 14:49 |
| gordc | just my opinion. | 14:49 |
| cdent | or requests itself, which seems to be used by opendaylight | 14:50 |
| cdent | but not generally | 14:50 |
| * cdent is just belaboring the point | 14:50 | |
| gordc | yes you are! | 14:50 |
| cdent | The way plugins are done is very wrong. | 14:50 |
| gordc | stop fanning flames. | 14:50 |
| gordc | head back in the sand | 14:50 |
| * cdent takes the role of burninator aaway from gordc | 14:50 | |
| * cdent stomps and burns | 14:50 | |
| gordc | oh that's what you wanted to do? that's cool then. | 14:51 |
| * gordc gives cdent the flamethrower. | 14:51 | |
| * cdent phwwoooops | 14:51 | |
| cdent | okay, I'm done now. | 14:51 |
| cdent | What should we actually do, now, for the short term? | 14:51 |
| gordc | eglynn: you going to push a revert patch? | 14:52 |
| linuxhermit | haha | 14:52 |
| eglynn | gordc: on a call, can do it later if no one else picks it up in the meantime | 14:52 |
| gordc | eglynn: sure thing | 14:52 |
| gordc | cdent: see an easy fix? or revert? i can wrap the import and log it which would fix startup | 14:53 |
| cdent | Do we have an existing standard for this kind of thing? Do we have a way of configuring plugins such that they exist in setup.cfg but don't actually run? | 14:54 |
| gordc | not sure if it makes sense though in real life usage. (it'll log like crazy i think) | 14:55 |
| cdent | (entry_points as configuration is...weird) | 14:55 |
| cdent | I think we should a) revert b) use this an opportunity to fix the real issue that's at the base of this. | 14:55 |
| gordc | let's give it 5 minutes of discussion... then i revert. | 14:55 |
| cdent | k, ideas? | 14:56 |
| cdent | Increasing logging will not be looked upon favorably, so I wouldn't suggest any course that leads that direction... | 14:56 |
| cdent | Is a polling agent only __init__ at startup? | 14:58 |
| cdent | If so, then a plugin that fails to import something could raise: plugin_base.ExtensionLoadError | 14:58 |
| cdent | and only log at __init__ tie | 14:59 |
| cdent | time | 14:59 |
| gordc | seems like it. | 14:59 |
| cdent | or, the _extensions method in the agent base could also catch ImportError | 14:59 |
| cdent | (and log once, and be done with it) | 15:00 |
| cdent | that seems more in keeping with the idea of plugins (they should warn, but not cause the system to die, when they can't work) | 15:00 |
| gordc | cdent: what gate are we failing right now? how are patches still passing? | 15:01 |
| gordc | grenade? | 15:02 |
| cdent | http://logs.openstack.org/55/158255/2/check/check-devstack-dsvm-updown/5e3ae6f/logs/screen-ceilometer-acentral.txt.gz | 15:02 |
| cdent | that's a test that ceilo's gate doesn't run | 15:02 |
| cdent | (I think) | 15:02 |
| gordc | ah i see. | 15:03 |
| gordc | i think the extenstionloaderror might be a sane solution... seems like that's the very reason the exception was created | 15:03 |
| gordc | https://github.com/openstack/ceilometer/blob/master/ceilometer/ipmi/pollsters/sensor.py#L41-L48 | 15:04 |
| cdent | yeah | 15:05 |
| *** prad has joined #openstack-ceilometer | 15:06 | |
| cdent | gordc it seems our quorum of two has reached a consensus | 15:08 |
| gordc | lol | 15:08 |
| gordc | cdent: so we want to revert still to guaruntee unblock? | 15:08 |
| cdent | I'm not sure. I don't understand the nature of the block well enough to know if we can just fix and be happy, or need to do two steps? | 15:09 |
| gordc | cdent: let's just revert for now. seems simpler. | 15:10 |
| cdent | as you wish | 15:10 |
| openstackgerrit | gordon chung proposed openstack/ceilometer: Revert "Add ceph object storage meters" https://review.openstack.org/158329 | 15:10 |
| openstackgerrit | afazekas proposed openstack/ceilometer: Revert "Add ceph object storage meters" https://review.openstack.org/158331 | 15:15 |
| cdent | uh oh | 15:17 |
| *** ccrouch has quit IRC | 15:18 | |
| swamireddy | eglynn: Please let me know, what was the issue?? I could NOT get it.. | 15:18 |
| swamireddy | cdent: Hi | 15:20 |
| cdent | Hi swamireddy | 15:20 |
| swamireddy | cdent: Could you please clarify issue on Revert "Add ceph object storage meters" https://review.openstack.org/158329 | 15:21 |
| swamireddy | cdent: I could FIX it asap, if I know the issue...plz | 15:21 |
| cdent | We're not sure why the problem is only showing up in some tests, but requests-aws was initially in test-requirements.txt but since the rwg stuff runs unconditionally it is always imported | 15:22 |
| *** claudiub has joined #openstack-ceilometer | 15:22 | |
| cdent | somebody tried to fix this by moving requests-aws to requirements.txt but this wasn't the preferred fix from the qa people. They want the import to be conditional. | 15:22 |
| cdent | So the fix (which will come along once the gate has unblocked) is to make the rwg raise ExtensionLoadError when it can't import the awsauth module. | 15:23 |
| cdent | Does that makes sense? | 15:23 |
| cdent | In the meantime, to unblock things, the revert is happening. | 15:23 |
| swamireddy | cdent: I have added the requests-aws pkg in global-requirements.txt and test-requirement.txt only (NOT included in the requirements.txt and requirement-py3.txt) | 15:24 |
| cdent | yes, that's where it is best | 15:24 |
| cdent | but since the rwg pollster plugin is always loaded, the import fails with an error: | 15:24 |
| cdent | http://logs.openstack.org/55/158255/2/check/check-devstack-dsvm-updown/5e3ae6f/logs/screen-ceilometer-acentral.txt.gz | 15:24 |
| cdent | That error needs to be trapped and transformed intoa ExtensionLoadError | 15:25 |
| swamireddy | cdent: Thats right ...I was told that any needed the rgw polling, that use will import the required pkgs (ie requests-aws) | 15:25 |
| *** rbak has joined #openstack-ceilometer | 15:26 | |
| swamireddy | quick fix could be- add the request-aws import to requirement.txt, all will set... | 15:26 |
| cdent | Yeah, the code you provided is mostly correct, except for the need for the new exception | 15:26 |
| cdent | The qa folk not keen on that fix, they want the better longer term fix. | 15:26 |
| gordc | swamireddy: could you try adding a try catch around awsauth requirement in client | 15:27 |
| swamireddy | sure, I wil take-up and fix it asap...its not issue...But one fix could be - add the requests-aws to requirement.txt, so import will not fail, and gate will work...is this OK? | 15:27 |
| cdent | swamireddy: They don't want that. | 15:28 |
| gordc | swamireddy: let's avoid that. we have some time to fix it (just a temporary revert to give us time to do clean fix) | 15:28 |
| swamireddy | gordc: sure, I can try and update you....but, if we add the requests-aws to requirements.txt, will all set... | 15:28 |
| cdent | Because it starts the precedence of having all plugins adding stuff to requirements.txt | 15:28 |
| cdent | gordc: who else is active core these days? | 15:28 |
| gordc | sileht: might be back from holiday... | 15:29 |
| gordc | cdent: why do you need a core? | 15:30 |
| cdent | I don't personally need a core, but that review does, to punch it through. | 15:30 |
| *** Ephur has joined #openstack-ceilometer | 15:31 | |
| ildikov | cdent: the revert one? | 15:31 |
| gordc | let's take your opinion as pseudo +2 and eglynn already suggested it | 15:31 |
| cdent | ildikov: yeah | 15:31 |
| gordc | and ildikov says yes. | 15:31 |
| gordc | i making assumptions. | 15:32 |
| dhellmann | gordc, cdent : I still have have +2 on ceilometer, I think | 15:32 |
| swamireddy | cdent: gordc: Sure, let me fix by adding an exception and will come back | 15:32 |
| gordc | dhellmann: yep! | 15:32 |
| cdent | When we fix it I think it is worthwhile considering trapping ImportError in plugin base as a safety valve. ImportError is an implicit ExtensionLoadError, n'est as? | 15:32 |
| dhellmann | gordc: this one? https://review.openstack.org/#/c/158329/1 | 15:32 |
| cdent | pas | 15:32 |
| * cdent le sighs | 15:32 | |
| ildikov | gordc: ildikov has already written the OS Manuals table for Ceph, so she sadly agrees with this particular revert... :S | 15:33 |
| gordc | dhellmann: yes please. disclaimer (all i did was hit revert button, not tested locally but should be good) | 15:33 |
| swamireddy | cdent: Agreed..will add the ImportError.. | 15:33 |
| linuxhermit | the dhellmann with the trump | 15:33 |
| gordc | ildikov: i think it's ok. we should have it back in cleanly by today/tomorrow | 15:33 |
| *** rbak has quit IRC | 15:33 | |
| sileht | woot, revert just for a import failure, sniff | 15:33 |
| cdent | swamireddy: I'm meaning in plugin base, not in the plugins themselves | 15:33 |
| dhellmann | gordc: approved | 15:34 |
| gordc | dhellmann: thanks | 15:34 |
| ildikov | gordc: sure, I know, it's just a typical Monday happening... :) | 15:34 |
| ildikov | dhellmann: thanks | 15:34 |
| cdent | I think reverting first asking questions later is a reasonable way to keep things moving, no sileht ? | 15:34 |
| *** zigo_ has joined #openstack-ceilometer | 15:35 | |
| cdent | Presumably we should never have let this through in the first place if we were really paying attention? | 15:35 |
| dhellmann | cdent, gordc, ildikov : is someone working on the fix in ceilometer/agent/base.py to trap the import error, or should I? | 15:35 |
| * dhellmann notes he has to disappear for the oslo meeting in ~20 minutes | 15:35 | |
| * cdent doesn't know | 15:36 | |
| *** rbak has joined #openstack-ceilometer | 15:36 | |
| swamireddy | cdent: gordc: Shall I await the fix the plugin base? | 15:37 |
| gordc | dhellmann: i think swamireddy was going to look at it? i think there's some existing infrastructure that we can leverage... revert was just to let us fix it without rushing. | 15:37 |
| *** alexpilotti has joined #openstack-ceilometer | 15:37 | |
| gordc | swamireddy: sure | 15:37 |
| gordc | dhellmann: i guess not. so if you want to look at it... or i can. either or. | 15:38 |
| dhellmann | gordc: I'm looking for a place to put a test. The fix is < 1 line. | 15:38 |
| *** exploreshaifali has joined #openstack-ceilometer | 15:38 | |
| gordc | dhellmann: :) well that's better than what i had planned | 15:38 |
| dhellmann | gordc: actually, logging turned it into 3-4 lines :-) | 15:39 |
| *** yeungp has joined #openstack-ceilometer | 15:39 | |
| ildikov | dhellmann: :) | 15:39 |
| gordc | dhellmann: you disappoint me. :P | 15:40 |
| *** yeungp has quit IRC | 15:40 | |
| *** yeungp has joined #openstack-ceilometer | 15:40 | |
| dhellmann | gordc: heh | 15:42 |
| sileht | cdent, yes I'm ok with that but a bit sad when it occurs | 15:44 |
| cdent | linuxhermit++; making tests and reporting bugs for the win | 15:45 |
| cdent | sileht: true enough | 15:45 |
| gordc | dhellmann: cdent: since i have you, trying to add ceilometermiddleware to devstack but getting this: http://logs.openstack.org/73/155473/4/check/check-tempest-dsvm-full/2fd68de/logs/devstacklog.txt.gz#_2015-02-22_19_28_33_482 | 15:45 |
| * cdent looks | 15:46 | |
| gordc | do i actually have to add ceilometermiddleware to global-requirements.txt (even though it isn't going to be in any requirements.txt) | 15:46 |
| linuxhermit | cdent: just trying to help | 15:46 |
| linuxhermit | will submit fixes for code once I feel more comfortable with it | 15:46 |
| gordc | i should mention i put it in projects.txt (just not requirements.txt) | 15:47 |
| cdent | gordc: what's the review associated with that? | 15:48 |
| gordc | cdent: https://review.openstack.org/#/c/155473/ | 15:48 |
| cdent | that's what I thought but I failed to get gerrit to let me type in a url. | 15:49 |
| * cdent shivers at gerrit | 15:49 | |
| cdent | gordc: you've still got to install the middleware | 15:50 |
| cdent | somewhere | 15:50 |
| cdent | presumably in lib/swift | 15:50 |
| gordc | err add a pip install ceilometermiddleware? | 15:51 |
| cdent | neither ceilometer nor swift will | 15:51 |
| cdent | probably here: | 15:51 |
| cdent | https://github.com/openstack-dev/devstack/blob/master/lib/swift#L379 | 15:51 |
| *** zhenq has joined #openstack-ceilometer | 15:51 | |
| cdent | pip_install ceilometermiddleware | 15:51 |
| cdent | assume it is on pypi? | 15:52 |
| gordc | cdent: yep | 15:52 |
| openstackgerrit | Doug Hellmann proposed openstack/ceilometer: Protect agent startup from import errors in plugins https://review.openstack.org/158339 | 15:52 |
| gordc | i'll do that. wasn't sure if i needed to do it explicitly or not. i guess i do | 15:52 |
| dhellmann | gordc, cdent, ildikov : ^^ | 15:52 |
| cdent | nice | 15:53 |
| gordc | dhellmann: wicked! | 15:53 |
| ildikov | dhellmann: thanks, looking | 15:53 |
| cdent | we should look around and see if there are similar places in the code where stevedore is being used | 15:54 |
| cdent | (that's probably the biggie, though) | 15:54 |
| dhellmann | cdent: good idea -- you, gordc, and ildikov should feel free to take that patch over if you need to extend it with more cases | 15:54 |
| gordc | i wonder if we should kill the revert... too many decisions to make on monday morning! | 15:55 |
| ildikov | dhellmann: sure, thanks much for the quick fix | 15:55 |
| cdent | gordc: most of the time you don't have to install python modules in devstack because it is already in some projects requirements but since the middleware thingie is standalone, you have to make special effort | 15:55 |
| ildikov | gordc: how long is the queue? | 15:56 |
| cdent | gordc: did we determine how wedged the wedge is? | 15:56 |
| swamireddy | gordc: Sorry...I would have taken care.. | 15:56 |
| dhellmann | gordc: no, leave the revert, it will probably land before my change and it should still be testing the import itself explicitly | 15:56 |
| cdent | I thought there was some fear that things wouldn't merge without a revert? | 15:56 |
| gordc | dhellmann: cdent: sounds good. | 15:56 |
| gordc | swamireddy: i guess if you can reapply your patch on top of dhellmann's patch we can verify if it solves your case or not | 15:57 |
| openstackgerrit | Mehdi Abaakouk proposed openstack/ceilometer: alarming: add gnocchi alarm rules https://review.openstack.org/155712 | 15:57 |
| swamireddy | gordc: will test locally and confirm.. | 15:58 |
| gordc | swamireddy: thanks! sorry for reverting. was just simpler. | 15:59 |
| gordc | i'll re-review right away after you've confirmed. | 16:00 |
| swamireddy | gordc: sure.... | 16:00 |
| gordc | cdent: damn, i see the pip_install used everywhere in devstack... thanks for the pointer. | 16:01 |
| gordc | ildikov: did you leave off the 'non-metric' meters from docs? | 16:08 |
| ildikov | gordc: I'm afraid I don't really understand your question :) | 16:08 |
| gordc | ildikov: https://review.openstack.org/#/c/156541/11/doc/admin-guide-cloud/telemetry/tables/ceilometer-measurements-neutron.xml | 16:09 |
| ildikov | gordc: it contains all meters | 16:09 |
| gordc | actually never i see the meters i was trying to block... i was going to ask about vpnaas, lbaas.. | 16:09 |
| gordc | yeah | 16:09 |
| gordc | ignore. | 16:09 |
| ildikov | gordc: I can create a deprecated column if we disable them in Liberty by default | 16:10 |
| ildikov | gordc: but for now I sadly have to include all in the docs | 16:10 |
| gordc | ildikov: that's fine. i don't know if we ever formalised "this is deprecreated" | 16:11 |
| swamireddy | gordc: cdent: I apologize for this glitch on Monday morning..:( | 16:11 |
| gordc | i'm wondering how we can mark them as 'this is an event' | 16:11 |
| cdent | swamireddy: I think its a good thing actually: It allowed us to find a quite important bug in the very good of the polling agents. | 16:11 |
| gordc | swamireddy: no worries. i approved it... and i break stuff all time. | 16:12 |
| ildikov | gordc: I guess deperecation itself means keeping them for two cycles | 16:12 |
| cdent | Breaking stuff is the quickest way to finding and fixing things. | 16:12 |
| gordc | i find it healthy to break stuff. | 16:12 |
| ildikov | gordc: so here we can keep the "support" for collecting them if someone really wants | 16:12 |
| * cdent breaks gordc's arm | 16:13 | |
| gordc | ildikov: yeah i think that's fine. do you think there's a way to hint "you should really use events" | 16:13 |
| ildikov | gordc: I added a note about it somewhere IIRC | 16:14 |
| gordc | cdent: i've seen people type/drum/eat/etc... with their feet. one arm is nothing | 16:14 |
| gordc | ildikov: oh cool! | 16:14 |
| ildikov | gordc: also in the dev docs I included one into the new meters section | 16:14 |
| * cdent breaks gordc's other arm and both legs | 16:14 | |
| ildikov | gordc: I will double check the OS Manuals side | 16:14 |
| ildikov | gordc: the other one I'm sure, but it's not merged yet anyway | 16:14 |
| gordc | cdent: that's cruel. | 16:15 |
| * cdent is the burninator | 16:15 | |
| gordc | lol | 16:15 |
| ildikov | cdent: you should not break gordc's arms, because you have to help me to maintain the docs then :) | 16:18 |
| gordc | ildikov: type with eyes. | 16:18 |
| * cdent takes it all back | 16:19 | |
| ildikov | gordc: sometimes I wish I could :) | 16:19 |
| ildikov | gordc: I checked the source of the api reference today | 16:19 |
| ildikov | gordc: that is a killer one, I mean the OS Manuals version not ours | 16:20 |
| gordc | i haven't seen it. | 16:20 |
| ildikov | gordc: I suggest to keep it this way... | 16:21 |
| ildikov | gordc: looks ugly in the sense of more xml tags and less text | 16:21 |
| gordc | but tbh, anything api is madness in openstack (cdent's problem) | 16:21 |
| *** devlaps has joined #openstack-ceilometer | 16:21 | |
| ildikov | gordc: I wonder if there is a chance to generate it somehow | 16:22 |
| gordc | like what we have in our dev docs? | 16:22 |
| cdent | you're not talking about the API wadl are you? | 16:22 |
| ildikov | gordc: got you, as for the API problem | 16:22 |
| gordc | i just zone out when people say api | 16:22 |
| ildikov | gordc: yeap, somehow like, the OS Manuals version uses wadl format | 16:22 |
| ildikov | gordc: but the file does not look like a generated one though | 16:23 |
| *** zhenq has quit IRC | 16:25 | |
| *** zhenq has joined #openstack-ceilometer | 16:25 | |
| *** amalagon has quit IRC | 16:27 | |
| cdent | ildikov: I made the same conclusion. I think that's hand (or close to) generated WADL. | 16:28 |
| *** jdandrea has quit IRC | 16:28 | |
| *** jdandrea has joined #openstack-ceilometer | 16:29 | |
| ildikov | cdent: I didn't find any suggestions in the README file, where there usually is | 16:29 |
| ildikov | cdent: and also the generated files contain a not at the beginning that yous hould not edit it manually as those are generated files | 16:29 |
| ildikov | cdent: so I'm almost sure | 16:30 |
| cdent | I wonder what from then. It's all very opaque | 16:30 |
| ildikov | cdent: and finally, if there would be a script that generate those files, then it would be up to date and it's not... | 16:30 |
| ildikov | *generates | 16:31 |
| *** zhenq has quit IRC | 16:32 | |
| *** zhenq has joined #openstack-ceilometer | 16:32 | |
| *** Erethon has left #openstack-ceilometer | 16:33 | |
| gordc | ildikov: do you have a link where you mention "store this as events" i'm thinking we should explicitly mark it in each table too | 16:36 |
| gordc | i think i remember that in operator thread it mentioned the meters are confusing (or soemthing about description is not helpful) | 16:37 |
| *** abhi- has joined #openstack-ceilometer | 16:37 | |
| ildikov | gordc: they meant the libvirt ones there as I remember, they mentioned that they had to check the libvirt api doc for info... | 16:38 |
| gordc | ah right | 16:38 |
| ildikov | gordc: I tried to polish them a bit, it would need some more for sure | 16:38 |
| gordc | that sounds familiar | 16:38 |
| ildikov | gordc: but marking those meters are good idea anyway | 16:38 |
| *** ddieterly has quit IRC | 16:39 | |
| ildikov | gordc: that is why I tried to convince Saba as for the disc meters, but then I rewrote those descriptions in the OS Manuals version... | 16:39 |
| gordc | yeah, i think we can polish it but i can't think of a better description "it's trying to explain it as something it isnt" | 16:39 |
| ildikov | gordc: for the event ones for sure | 16:39 |
| gordc | ok. maybe we can mark them after you move everything over | 16:40 |
| ildikov | gordc: amybe we could have an additional column as "event type metric" or smth like... | 16:40 |
| *** fnaval has joined #openstack-ceilometer | 16:41 | |
| gordc | ildikov: i don't know if we need another column. we can probably highlight column or add asterisk and mention it in bottom of each table? | 16:41 |
| ildikov | gordc: http://docs.openstack.org/admin-guide-cloud/content/section_telemetry-measurements.html | 16:41 |
| ildikov | gordc: see the note at the bottom of the page | 16:41 |
| *** devlaps has quit IRC | 16:42 | |
| ildikov | gordc: well, maybe we can play with the background color or add a maker after the name of each one | 16:42 |
| gordc | cool cool. note make sense. | 16:43 |
| ildikov | gordc: we have time to decide it until all the tables get merged and then it can be marked in a single patch | 16:43 |
| gordc | that sounds like a good plan. | 16:44 |
| ildikov | gordc: cool, I never know if what I wrote means as much sense in English as I would like it to... | 16:44 |
| ildikov | gordc: cool, agreed then :) | 16:44 |
| gordc | makes sense to me. although i sort of make up my own sentences when people talk to me. | 16:44 |
| ildikov | gordc: I usually invent new expressions in English that are "similar" to the original ones... :) | 16:46 |
| ildikov | gordc: ok, I need to run now, I'm close to starve to death | 16:46 |
| gordc | i think we all do... and then we add it to urbandictionary.com :).. or maybe just me. | 16:46 |
| gordc | cool cool. ttyl | 16:47 |
| ildikov | gordc: I will check back to your OS Manuals patches after | 16:47 |
| gordc | thanks | 16:47 |
| ildikov | gordc: LOL :), it's good to think I can be the part of building a new dictionary/language :) | 16:47 |
| *** devlaps has joined #openstack-ceilometer | 16:48 | |
| ildikov | gordc: np, laters :) | 16:48 |
| abhi- | gordc: regarding the ceph/rgw requests-aws import failure, wouldn't requests-aws be required in requirements.txt when we require a build with metering of radosgw enabled? | 16:53 |
| gordc | abhi-: the general approach we've taken (although probably not always followed) is to have driver related libs part of test-reqs only. | 16:54 |
| gordc | if ops/deployers want to actually use said driver, than the library is loaded (manually) | 16:55 |
| abhi- | ah ok | 16:55 |
| *** ildikov has quit IRC | 16:55 | |
| *** rwsu has joined #openstack-ceilometer | 17:05 | |
| swamireddy | gordc: ceilometer-acentral is working with the patch...(without the patch it failed with -- ceilometer ImportError: No module named awsauth) | 17:17 |
| *** _cjones_ has joined #openstack-ceilometer | 17:18 | |
| swamireddy | gordc: For this testing I have removed all requests-aws pkg (pip and dpkg pkgs both removed)...and performed the testing.. ceilometer-acentral working (not seen the ImportError) | 17:19 |
| * cdent goes to see waves | 17:20 | |
| cdent | biab | 17:20 |
| swamireddy | gordc: Shall I re-submit the patch with same commit id? or it should be separate and new patch? | 17:21 |
| gordc | swamireddy: cool stuff. i think technically i can revert my revert (once it merges) | 17:21 |
| gordc | i'm not sure you can recommit with same id. | 17:21 |
| gordc | you can try ... i feel like git will yell at you though. | 17:21 |
| swamireddy | gordc: Yep, git will allow the reverts | 17:22 |
| gordc | maybe when my revert merges you can just revert it again. | 17:22 |
| gordc | whatever works. | 17:22 |
| swamireddy | gordc: Both should not tried...you revert and I try to revert may cause the problem... | 17:23 |
| gordc | oh, yeah i'm not doing anything... my suggestion was that when this merges in 30mins (https://review.openstack.org/#/c/158329/) | 17:24 |
| gordc | you can hit the revert and it will technically revert the revert... making it a positive again? | 17:24 |
| gordc | i don't really have a preference. | 17:25 |
| *** ddieterly has joined #openstack-ceilometer | 17:28 | |
| *** himangi has quit IRC | 17:31 | |
| gordc | swamireddy: i created this: https://bugs.launchpad.net/ceilometer/+bug/1424746 | 17:32 |
| openstack | Launchpad bug 1424746 in Ceilometer "central agent will throw error on startup" [Medium,Triaged] | 17:32 |
| gordc | with dhellmann patch your code with work, it'll just show an error at startup which might be nice to hide... don't know if you want to fix it on your end. | 17:32 |
| swamireddy | gordc: Cool.. I can submit the patch with this bug id... | 17:33 |
| swamireddy | gordc: fix in rgw_clint code?? | 17:34 |
| gordc | swamireddy: i'm actually not sure where the proper fix is. i just noticed the error when i looked at the logs: http://logs.openstack.org/39/158339/1/check/check-tempest-dsvm-full/b6fb4f9/logs/screen-ceilometer-acentral.txt.gz | 17:35 |
| gordc | but yeah, you'd probably need to fix it in client... | 17:36 |
| *** zhenq has quit IRC | 17:37 | |
| gordc | and now that i look at error, another side issue that might exist is that we're creating a client for each pollster (we might want to share it. ie make it class level client) | 17:37 |
| gordc | but one fix at a time is cool | 17:37 |
| gordc | or both if easy. | 17:37 |
| swamireddy | gordc: Thats a reason Abhi was asking to include the requests-aws in requirements.txt.. | 17:37 |
| gordc | which reason? the error? | 17:38 |
| *** amalagon_ has joined #openstack-ceilometer | 17:38 | |
| swamireddy | gordc: errors are comming in as Failed to import extension for rgw.usage: .. even I the acentral issue fixed.. | 17:39 |
| gordc | well you can do a try: catch: on import awsauth and raise it as something less aggressive. | 17:40 |
| swamireddy | gordc: I could think it as - some where in conf, rgw is True, then only use the rgw polling... | 17:40 |
| gordc | i think dhellmann's fix is more to avoid breaking agent completely | 17:40 |
| gordc | swamireddy: yes, that could work as well | 17:41 |
| swamireddy | gordc: Not sure, if ceilometer has this type of support ATM... | 17:41 |
| gordc | what support? | 17:41 |
| swamireddy | gordc: Yes, agree. Dhallmann´s fix to avoid the breaking agent.. | 17:42 |
| swamireddy | gordc: If user don´t need the swift or ceph polling, that can be turned-off at conf file level itself... | 17:42 |
| swamireddy | gordc: This gives the top level nob to on or off.. | 17:43 |
| *** Ala has quit IRC | 17:45 | |
| gordc | hmm.. yeah you'd probably need to code in support for that. | 17:45 |
| gordc | i'm ok with the bug being address separately to be honest. | 17:45 |
| gordc | bbl getting called away from computer. | 17:45 |
| *** exploreshaifali has quit IRC | 17:45 | |
| *** zul has quit IRC | 17:51 | |
| linuxhermit | cdent: should I consider moving on to another part of gabbi testing? | 17:51 |
| linuxhermit | prior to that existing on getting merged, or wait a few until more discussion has occurred (which is the way I'm learning) | 17:52 |
| *** zul has joined #openstack-ceilometer | 17:53 | |
| cdent | linuxhermit: feel free to move on or if you want another thing I tend to do is just create a yaml file for the sake of finding bugs, but not to actually commit anything, and then report the bugs | 17:57 |
| *** ccrouch has joined #openstack-ceilometer | 17:57 | |
| linuxhermit | hmm okay | 17:58 |
| cdent | It can be an interesting diversion to learn stuff. | 18:02 |
| *** ybathia has joined #openstack-ceilometer | 18:02 | |
| *** ildikov has joined #openstack-ceilometer | 18:07 | |
| *** eglynn-office is now known as eglynn-officeafk | 18:09 | |
| *** david-lyle_afk is now known as david-lyle | 18:09 | |
| *** _cjones_ has quit IRC | 18:10 | |
| *** zhenq has joined #openstack-ceilometer | 18:12 | |
| *** eglynn has quit IRC | 18:13 | |
| *** _cjones_ has joined #openstack-ceilometer | 18:15 | |
| *** zul has quit IRC | 18:25 | |
| *** zul has joined #openstack-ceilometer | 18:25 | |
| *** sbfox has joined #openstack-ceilometer | 18:26 | |
| swamireddy | gordc: I plan to hold my patch and see if I can fix the import issue also.. (like Failed to import extension for rgw.usage: No module named awsauth).. | 18:31 |
| swamireddy | gordc: I see the same issue might have been there for other driver libs, not sure how they have fixed it... | 18:32 |
| *** harlowja has joined #openstack-ceilometer | 18:33 | |
| *** zul has quit IRC | 18:42 | |
| *** ddieterly has quit IRC | 18:43 | |
| *** ddieterly has joined #openstack-ceilometer | 18:44 | |
| *** zul has joined #openstack-ceilometer | 18:44 | |
| *** abhi- has quit IRC | 18:51 | |
| *** zul has quit IRC | 19:04 | |
| *** zul has joined #openstack-ceilometer | 19:04 | |
| cdent | gordc: I was surprised too | 19:08 |
| cdent | In fact I think when I first wrote the code you've just changed I made the same mistake and eglynn-officeafk caught it. | 19:09 |
| gordc | cdent: i could've sworn i've tried this before... probably some 'everything is an object' bs | 19:09 |
| cdent | It's okay with non reference types | 19:09 |
| cdent | x = y = 1 | 19:09 |
| cdent | but x = y = [] or x = y = {} will get funky | 19:09 |
| *** ddieterly has quit IRC | 19:10 | |
| cdent | it's the same issues as def foo(x=[]) | 19:10 |
| gordc | cdent: ah right. | 19:10 |
| *** ddieterly has joined #openstack-ceilometer | 19:10 | |
| * cdent seeks food | 19:11 | |
| *** zul has quit IRC | 19:11 | |
| *** zul has joined #openstack-ceilometer | 19:11 | |
| *** cdent has quit IRC | 19:14 | |
| *** eglynn has joined #openstack-ceilometer | 19:15 | |
| *** alexpilotti has quit IRC | 19:24 | |
| gordc | eglynn: i don't know if it's worth blocking this: https://review.openstack.org/#/c/158329/ | 19:24 |
| gordc | looking at dhellmann's patch, it seems like it'll resolve the broken client issue. | 19:25 |
| eglynn | gordc: it shouldn't be a problem thought to simply resubmit swamireddy's patch? | 19:25 |
| eglynn | *though | 19:26 |
| gordc | eglynn: yeah, just asking if we want to avoid a "revert a revert" patch. | 19:26 |
| gordc | i'm just slowly watching it move up the merge list since i don't really have an opinion on it. | 19:26 |
| eglynn | gordc: TBH I'm not 100% sure whether simply revoking the +2/+A will stop it in its tracks | 19:27 |
| gordc | eglynn: true. i'm pretty sure i've done it before but it's so rare that i'm not really sure to be honest. | 19:28 |
| gordc | i guess that answers the question | 19:28 |
| gordc | let it be. | 19:28 |
| eglynn | yeap, think so | 19:29 |
| dhellmann | eglynn, gordc : you could submit a change to the patch to kick it out of the queue (tweak the commit message in gerrit) but I think ultimately you do want the revert to land and for a new patch to be submitted that deals with the import error explicitly. My patch is just meant to prevent things from breaking when badly behaved plugins are present. | 19:39 |
| eglynn | dhellmann: yes, that makes sense, thanks! | 19:39 |
| *** zul has quit IRC | 19:48 | |
| *** openstackgerrit has quit IRC | 19:51 | |
| *** openstackgerrit has joined #openstack-ceilometer | 19:52 | |
| openstackgerrit | Merged openstack/ceilometer: Revert "Add ceph object storage meters" https://review.openstack.org/158329 | 19:58 |
| *** zul has joined #openstack-ceilometer | 20:01 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/ceilometer: Updated from global requirements https://review.openstack.org/157641 | 20:01 |
| *** drjones has joined #openstack-ceilometer | 20:10 | |
| *** _cjones_ has quit IRC | 20:10 | |
| openstackgerrit | gordon chung proposed openstack/ceilometer: fix inline multiple assignment https://review.openstack.org/158425 | 20:14 |
| *** promulo has quit IRC | 20:19 | |
| *** eglynn has quit IRC | 20:23 | |
| *** ddieterly has quit IRC | 20:32 | |
| *** ddieterly has joined #openstack-ceilometer | 20:33 | |
| *** harlowja has quit IRC | 20:34 | |
| *** harlowja_ has joined #openstack-ceilometer | 20:34 | |
| *** promulo has joined #openstack-ceilometer | 20:34 | |
| *** ddieterly has quit IRC | 20:37 | |
| *** exploreshaifali has joined #openstack-ceilometer | 20:38 | |
| *** ddieterly has joined #openstack-ceilometer | 20:38 | |
| *** zul has quit IRC | 20:40 | |
| *** zul has joined #openstack-ceilometer | 20:40 | |
| *** ddieterly has quit IRC | 20:46 | |
| *** thomasem has quit IRC | 20:47 | |
| ccrouch | so who has got a summit session proposal that I can vote for? | 21:00 |
| openstackgerrit | Merged openstack/ceilometer: Protect agent startup from import errors in plugins https://review.openstack.org/158339 | 21:03 |
| *** ybathia has quit IRC | 21:04 | |
| *** ddieterly has joined #openstack-ceilometer | 21:14 | |
| *** thomasem has joined #openstack-ceilometer | 21:20 | |
| *** amalagon_ has quit IRC | 21:22 | |
| *** amalagon has joined #openstack-ceilometer | 21:23 | |
| *** amalagon has quit IRC | 21:27 | |
| *** amalagon has joined #openstack-ceilometer | 21:41 | |
| *** sbfox has quit IRC | 21:41 | |
| *** zhenq has quit IRC | 21:45 | |
| *** karimb has joined #openstack-ceilometer | 21:45 | |
| *** karimb has quit IRC | 21:48 | |
| *** ybathia has joined #openstack-ceilometer | 21:49 | |
| *** exploreshaifali has quit IRC | 21:51 | |
| *** yeungp has quit IRC | 21:56 | |
| *** yeungp has joined #openstack-ceilometer | 21:56 | |
| *** yeungp has quit IRC | 21:57 | |
| *** yeungp has joined #openstack-ceilometer | 21:57 | |
| *** sbfox has joined #openstack-ceilometer | 21:57 | |
| *** yeungp has quit IRC | 21:58 | |
| *** yeungp has joined #openstack-ceilometer | 21:58 | |
| *** ddieterly has quit IRC | 22:01 | |
| *** ddieterly has joined #openstack-ceilometer | 22:03 | |
| gordc | ccrouch: http://eavesdrop.openstack.org/meetings/ceilometer/2015/ceilometer.2015-02-19-15.01.log.html see last few minutes of meeting | 22:05 |
| *** nellysmitt has quit IRC | 22:16 | |
| *** nellysmitt has joined #openstack-ceilometer | 22:16 | |
| *** nellysmitt has quit IRC | 22:17 | |
| *** zhenq has joined #openstack-ceilometer | 22:19 | |
| *** harlowja_ has quit IRC | 22:29 | |
| *** harlowja has joined #openstack-ceilometer | 22:30 | |
| ccrouch | gordc: perfect, thanks | 22:34 |
| ccrouch | buttons pushed! | 22:34 |
| gordc | ccrouch: :) | 22:34 |
| ccrouch | i think there is like 25mins left? | 22:34 |
| ccrouch | for all you late voters out there? | 22:34 |
| *** yeungp has quit IRC | 22:37 | |
| *** yeungp has joined #openstack-ceilometer | 22:37 | |
| gordc | ccrouch: any good talks to promote? | 22:39 |
| ccrouch | i'm only telling because you asked :-) | 22:42 |
| ccrouch | http://bit.ly/thanks-docker | 22:42 |
| ccrouch | it will hopefully be good :-) Its got good potential :-) | 22:43 |
| *** yeungp has quit IRC | 22:44 | |
| gordc | ccrouch: :) i appreciate the undersell. | 22:45 |
| gordc | i'm sure you'll get a bunch of interest if it's containers/kolla related. | 22:46 |
| ccrouch | i fear we are at "peak docker" in the hype cycle | 22:47 |
| ccrouch | people are getting a little inured to the topic | 22:48 |
| *** zhenq has quit IRC | 22:48 | |
| gordc | no time for research. just give me keywords. | 22:49 |
| ccrouch | lol | 22:50 |
| ccrouch | gordc: I recommend "doomed" | 22:53 |
| ccrouch | as a good keyword | 22:53 |
| *** thomasem has quit IRC | 22:54 | |
| gordc | https://www.openstack.org/vote-vancouver/presentation/openstack-is-doomed-and-it-is-your-fault | 22:54 |
| gordc | i'm pretty sure i've promoted termie's talk more than my own. | 22:55 |
| ccrouch | how can you *not* vote for a talk like | 22:55 |
| ccrouch | that | 22:55 |
| ccrouch | it should be keynote :-) | 22:55 |
| gordc | i wish. :) | 22:56 |
| *** thomasem has joined #openstack-ceilometer | 23:03 | |
| *** thomasem has quit IRC | 23:03 | |
| *** harlowja has quit IRC | 23:04 | |
| *** rwsu is now known as rwsu-afk | 23:04 | |
| *** thomasem has joined #openstack-ceilometer | 23:04 | |
| *** devlaps has quit IRC | 23:14 | |
| *** devlaps has joined #openstack-ceilometer | 23:14 | |
| *** harlowja has joined #openstack-ceilometer | 23:16 | |
| *** promulo__ has joined #openstack-ceilometer | 23:30 | |
| *** promulo has quit IRC | 23:31 | |
| *** prad has quit IRC | 23:36 | |
| *** alexpilotti has joined #openstack-ceilometer | 23:36 | |
| *** gordc has quit IRC | 23:37 | |
| *** ddieterly has quit IRC | 23:50 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!