| clarkb | ya I finally got out on the bike and I think I decided to do some refactoring even if it diverges from the documented commands for etherpad api management | 00:25 |
|---|---|---|
| opendevreview | Clark Boylan proposed opendev/system-config master: Improve etherpad functional testing https://review.opendev.org/c/opendev/system-config/+/900457 | 00:32 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Improve etherpad functional testing https://review.opendev.org/c/opendev/system-config/+/900457 | 01:10 |
| opendevreview | Artem Goncharov proposed openstack/project-config master: Add hashicorp-vault-plugin-secrets project https://review.opendev.org/c/openstack/project-config/+/847135 | 08:17 |
| opendevreview | Artem Goncharov proposed openstack/project-config master: Add hashicorp-vault-plugin-secrets project https://review.opendev.org/c/openstack/project-config/+/847135 | 08:18 |
| *** dhill is now known as Guest6422 | 15:21 | |
| JayF | Can someone from infra help me with something? | 15:52 |
| tonyb | Almost certainly ;P | 15:52 |
| JayF | How did bugfix/8.1 branch get recreated in openstack/ironic-python-agent gerrit? | 15:52 |
| JayF | It was retired years ago, and now it appears to have zombied | 15:52 |
| JayF | along with many other ironic bugfix branches | 15:52 |
| JayF | which also creates CI noise, zuul config errors, etc that I thought I had cleaned up :( | 15:52 |
| clarkb | we don't create branches for openstack projects. Is that something in a openstack releases config file causing it to be recreated? | 15:53 |
| JayF | I'm trying to find the answer to that question. A dangling open change and gerrit did it? Releases automation? | 15:53 |
| JayF | I went to infra thinking you would have access to audit logs of some kind | 15:53 |
| clarkb | gerrit does not allow you to delete branches with open changes | 15:53 |
| JayF | oof | 15:54 |
| clarkb | so maybe error checking for deletion requests missed that it failed due to open changes, or open changes were not a problem | 15:54 |
| clarkb | I believe we have 30 days of logs without going to backups | 15:54 |
| clarkb | but I'd have to ssh in to be sure of that range | 15:55 |
| tonyb | JayF: when did you notice they existed? | 15:55 |
| JayF | yesteday while trying to create periodic job dashboards | 15:55 |
| JayF | saw a bunch of outta date tests running in bright red | 15:56 |
| JayF | dug it this morning, found zombie bugfix branches | 15:56 |
| clarkb | JayF: personally I would start here: https://codesearch.opendev.org/?q=bugfix%2F8.1&i=nope&literal=nope&files=&excludeFiles=&repos= | 15:56 |
| fungi | JayF: bugfix/8.1 is still included in deliverables/xena/ironic-python-agent.yaml so that may be why it was recreated | 15:56 |
| fungi | i recommend checking with the release managers to find out if branch references should be removed from deliverables before deleting | 15:57 |
| fungi | i still see remotes/origin/bugfix/8.0 in the git branch list too | 15:59 |
| tonyb | gerrit doens't have an 8.0: https://review.opendev.org/admin/repos/openstack/ironic-python-agent,branches | 16:02 |
| JayF | yeah, I'm using gerrit as source of truth | 16:03 |
| fungi | i wonder if the branch deletion for bugfix/8.0 didn't replicate from gerrit to gitea for some reason | 16:04 |
| fungi | gitea also seems to have bugfix branches for 6.2, 6.3, 6.5, 6.6 | 16:05 |
| clarkb | fungi: gitea's database tracking of refs is dijoint from the actual git repos | 16:05 |
| clarkb | its possible the gitea db thinks those refs exist but they aren't actually there in the git repo | 16:06 |
| clarkb | because gitea.... there is an issue around this and gitea sort of waved tehir hands around it and said not a problem | 16:06 |
| fungi | i'm looking at the output of `git branch -a` after doing a remote update | 16:06 |
| tonyb | I'm pretty sure that if the release tools were to recreate a branch it would be "on" at the tag/SHA in the "branches" config or at the very least the last release. the bugfix/8.1 seems to be at $some_point | 16:06 |
| fungi | i'm able to `git checkout origin/bugfix/8.0` too | 16:07 |
| fungi | tonyb: good point | 16:07 |
| fungi | the tip of gerrit/bugfox/8.1 is https://review.opendev.org/871981 which merged 2023-01-31 | 16:08 |
| clarkb | https://review.opendev.org/c/openstack/ironic-python-agent/+/861062 was an open change until very recently | 16:09 |
| tonyb | I at least have my local repo and gerrit agreeing: https://paste.opendev.org/show/bNUvHP17mZz0bXVcW67H/ | 16:09 |
| clarkb | maybe my suggestion that branch deletion failed beacuse there were open changes is something | 16:09 |
| fungi | yeah, it's possible the branch was never actually deleted at all | 16:09 |
| tonyb | clarkb: Yup I'm thinking that it plausible. | 16:10 |
| fungi | whatever's going on with lingering branches in gitea is yet another issue, i guess. likely missed replication events if there was a burst of deletions all at once? | 16:10 |
| tonyb | JayF: The sounds way more accusitory than I'd like or mean but, do you have any proof the branches were actually deleted? | 16:11 |
| fungi | like if we trigger re-replication of the repo in gerrit, they'll just disappear | 16:11 |
| clarkb | fungi: ya we might want to do semi regular full replications just to catch up any missed items | 16:11 |
| JayF | tonyb: I have the runbooks from when I did it, and I validated it at the time | 16:11 |
| clarkb | fungi: could also have been overlap in gitea load due to dos and events happenign together causing some of them to be missed | 16:11 |
| JayF | tonyb: https://etherpad.opendev.org/p/IronicBugfixBranchCleanup and you can search that URL in the ML archives | 16:12 |
| clarkb | fwiw the example change I linked was cherry picked using gerrit if I'm reading the log correctly. When you cherry pick with gerrit it auto completes valid branches for you implying bugfix/8.1 was valid before cherry picking occured | 16:12 |
| fungi | https://review.opendev.org/c/openstack/ironic-python-agent/+/861062 was created targeting bugfix/8.1 on 2022-10-13, and looks like it would still have been open at the time branch deletion was attempted | 16:15 |
| fungi | so i agree, gerrit would not have allowed the bugfix/8.1 branch to be deleted with that change still open | 16:17 |
| fungi | pcheli: not sure if you're around, but pinging you again since your ci now has 88 open connections to gerrit. at this rate, it will probably cease working some time next week. please look into whatever's breaking your ssh connections | 16:18 |
| JayF | fungi: note the date on my etherpad indicates 1/11/23 as retirement date | 16:18 |
| tonyb | JayF: Do you have logs from the actual deletion? | 16:19 |
| fungi | JayF: right. change 861062 created 2022-10-13, branch deletion attempted 2023-01-11, change 861062 closed (abandoned) 2023-11-09 | 16:20 |
| clarkb | looking at acls I think that ironic itself doesn't have perms ot create the branches. The release team or gerrit admin would haev to do that | 16:20 |
| clarkb | just to rule out additional groups that may have taken action here | 16:20 |
| JayF | tonyb: no, I did it almost a year agop | 16:20 |
| fungi | gerrit should have refused to delete the branch on 2023-01-11 because change 861062 was open for it at that time | 16:20 |
| fungi | 861062 was opened over a year ago | 16:21 |
| fungi | and just abandoned today | 16:21 |
| JayF | it was in a weird state | 16:21 |
| JayF | W+1 but not landing | 16:22 |
| JayF | when I abandoned it this morning | 16:22 |
| JayF | (I thought that change had recreated it; but then I got digging, found more, and raised the questions here) | 16:22 |
| fungi | it's possible gerrit incorrectly reported deletion of that branch, i suppose, but it's not supposed to allow you to delete any branch with open changes | 16:23 |
| clarkb | JayF: I think there were no zuul jobs defined for it when it was pushed and +W'd as zuul took no action | 16:23 |
| JayF | fungi: It's also possible, because I was doing a large batch, and the middle batch failed for ACL issues, I missed that failure in the ACL failures | 16:23 |
| clarkb | there are no check or gate jobs implying that no jobs were configured to run against that change. Possibly due to file matchers | 16:23 |
| JayF | fungi: one of the harms in having unautomated things (an issue I brought up with -ironic, and I think folks are taking up the mantle to remove this manual process entirely; and I am grateful) | 16:24 |
| * JayF afk for a bit | 16:26 | |
| opendevreview | Clark Boylan proposed opendev/system-config master: Improve etherpad functional testing https://review.opendev.org/c/opendev/system-config/+/900457 | 16:34 |
| clarkb | if that doesn't make things more clear I may have to hold a node | 16:35 |
| clarkb | aha docker compose by default tries to allocate a tty which is the inverse behavior of docker. That is why it complains about no tty | 16:57 |
| tonyb | LOL, at least you know why. switch to a call to docker instead? | 16:58 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Improve etherpad functional testing https://review.opendev.org/c/opendev/system-config/+/900457 | 16:59 |
| clarkb | tonyb: I'm going to pass -T to disable tty allocation with docker-compose that way the test looks similar to our documented commands | 17:00 |
| tonyb | SOunds good. | 17:01 |
| tonyb | Also +1 for your choice of 4-byte char and message :) | 17:01 |
| clarkb | tonyb: I was really happy when I found that one | 17:01 |
| * tonyb wonders how IRC/IRCCloud handles it ..... | 17:02 | |
| clarkb | 🖖 here | 17:02 |
| tonyb | '🖖 Live long and prosper � | 17:02 |
| clarkb | the second one in your message doesn't render for me for some reason | 17:03 |
| tonyb | Yeah | 17:03 |
| clarkb | maybe the paste was truncated to fewer than 4 bytes? | 17:03 |
| tonyb | I wonder if the copy/paste missed a byte or something | 17:03 |
| tonyb | Yeah that's what happened | 17:04 |
| tonyb | hexdump says "20 ef bf bd 0a " so somehow it lost a byte and the "'" | 17:04 |
| tonyb | Yeah to get the full byte stream I need to include part of the next line | 17:07 |
| tonyb | anyway I can see how you got nerdsniped | 17:07 |
| clarkb | tonyb: the real sniping happened when I ended up on a website with searchable glyphs by different category | 17:07 |
| clarkb | there was a lot of scrolling and copy and paste into my termianl to see if my terminal font supported the glyphs :) | 17:07 |
| tonyb | LOL | 17:08 |
| clarkb | related: years ago I was trying to buy a house and our mortage person at the bank always signed off their emails with 'J'. There were no J's in their name. I eventually figured out that wingdings J is equivalent to :) but in a single glyph. They used outlook which sent wingding chracter J which got rendered as a J and not the wingding because I'm not on windows | 17:11 |
| tonyb | LOL | 17:14 |
| clarkb | https://www.alanwood.net/demos/wingdings.html has the mapping if you ever find weird characters in email and need ot translate | 17:21 |
| fungi | i usually just open up the python repl and use unicodedata.name() or similar | 17:22 |
| clarkb | fungi: the problem here is that wingdings overloads ascii points | 17:23 |
| fungi | ohhhh, got it | 17:23 |
| clarkb | I suspect the problem will slowly go away as utf8/unicode become more common | 17:23 |
| fungi | i thought we were still talking about unicode | 17:23 |
| fungi | i missed the transition to fonts | 17:23 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Improve etherpad functional testing https://review.opendev.org/c/opendev/system-config/+/900457 | 17:28 |
| clarkb | turns out you must create the pad before you can set text on a pad | 17:28 |
| clarkb | but this finally feels like progress | 17:28 |
| tonyb | also you seem to be having fun | 17:31 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Improve etherpad functional testing https://review.opendev.org/c/opendev/system-config/+/900457 | 18:02 |
| *** tosky_ is now known as tosky | 18:43 | |
| clarkb | infra-root https://review.opendev.org/c/opendev/system-config/+/900457 passes testing now for functioanl testing of etherpad including utf8 4 byte character coverage | 18:55 |
| clarkb | tonyb: ^ infra-root is a highlight you may want ot add if you haven't already | 18:55 |
| tonyb | yup I did it yesterday | 18:56 |
| *** dhill is now known as Guest6456 | 20:12 | |
| opendevreview | Amy Marrich proposed opendev/irc-meetings master: Updated D&I meeting to push back an hour due to time change https://review.opendev.org/c/opendev/irc-meetings/+/900558 | 21:03 |
| opendevreview | Merged opendev/irc-meetings master: [iwg] Update office hour date and time https://review.opendev.org/c/opendev/irc-meetings/+/900027 | 21:27 |
| opendevreview | Merged opendev/irc-meetings master: Updated D&I meeting to push back an hour due to time change https://review.opendev.org/c/opendev/irc-meetings/+/900558 | 21:27 |
| opendevreview | Merged opendev/system-config master: Improve etherpad functional testing https://review.opendev.org/c/opendev/system-config/+/900457 | 21:33 |
| tonyb | clarkb: is https://review.opendev.org/c/opendev/system-config/+/848181 still needed? | 23:28 |
| tonyb | clarkb: Also https://review.opendev.org/c/opendev/system-config/+/893571?usp=search | 23:30 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!