| fungi | thanks! | 00:00 |
|---|---|---|
| JayF | tc-members: can I get at least one ack on this before I pop it out to the mailing list? https://etherpad.opendev.org/p/tc-ptg-summary-2024.1 | 00:02 |
| JayF | whoops, ECHAN | 00:04 |
| tonyb | LOL, I didn't even notice | 00:05 |
| JayF | well, I notice it's my EOD, I got that done just in time to leave, finally getting to the end of my PTG documentation duties :D | 00:07 |
| JayF | did the ironic spec and the TC email today, assuming nobody from either end nacks it :D | 00:07 |
| JayF | https://review.opendev.org/c/openstack/ironic-specs/+/899297 (Ironic does it's PTG documentation as a spec) | 00:07 |
| tonyb | Interesting idea | 00:08 |
| JayF | https://specs.openstack.org/openstack/ironic-specs/ I can't take credit, we've been doing it since mitaka | 00:08 |
| JayF | just changed the name from priorities -> themes -> work items over time | 00:08 |
| tonyb | Oh nice | 00:09 |
| JayF | trying to figure out whatever word we can that says "this is our wishlist of stuff we'd like to work on, but the real world existing means we'll get like, half of it done if we're lucky" :D | 00:09 |
| JayF | it's extremely satisfying to be able to go back in time and see the things that you've done though | 00:09 |
| clarkb | I've been nerding out on unicode/utf8 because I got nerd sniped. Its interesting that the vim 'ga' command shows me the unicode point and not the utf8value even though the file is encoded in utf8 | 00:09 |
| clarkb | hexdumping confirms. | 00:09 |
| JayF | clarkb: we actually have code that deals in UTF-16 in ironic (IPA!) | 00:10 |
| JayF | clarkb: fallback uefi bootloader uses csv files that are encoded UTF-16 | 00:10 |
| JayF | or was it -32 | 00:10 |
| JayF | now I gotta go look | 00:10 |
| opendevreview | Clark Boylan proposed opendev/system-config master: A file with tab delimited useful utf8 chars https://review.opendev.org/c/opendev/system-config/+/900379 | 00:11 |
| JayF | yep, utf-16 or utf-16-le | 00:11 |
| JayF | endianness matters, yikes, I forgot about that | 00:11 |
| * JayF out for the day o/ | 00:11 | |
| clarkb | other than failing to properly indicate the tabs in all cases that actually rendered well | 00:12 |
| clarkb | I'm not actually sure we want to merge a change like that. However it might be useful to have four byte utf8 chars readily available somewhere like that due to all the historical problems with mysql and those characters | 00:13 |
| clarkb | also seriously everything has a code point. Even symbols from clay tablets | 00:14 |
| tonyb | Huh, I can see advantages to having something like that. How much do you trust the pre-deploy testing ;P | 00:16 |
| clarkb | tonyb: so far its just adding the content to he git repo which should be pretty safe :) | 00:17 |
| clarkb | but the background idea here is maybe trying to add a testinfra test to etherpad that uses the etherpad admin api to inject 4 byte character pad data then eftches it back out again | 00:17 |
| clarkb | the first step was go figure out what even are four byte characters and then I ended up deep down the rabbit hole of wow there are a lot of characters | 00:17 |
| clarkb | and kind of forgot the original idea here :) | 00:18 |
| tonyb | It happens | 00:25 |
| tonyb | I started today with the goal of proposing gnocchi to g-r and now I'm rewriting our constraints generation infrastructure | 00:29 |
| yadnesh | fungi, at times when downloading fedora images from official fedora urls in telemetry ci fips job fails with error "GnuTLS: One of the involved algorithms has insufficient security level." This happens with some specific mirrors. https://zuul.opendev.org/t/openstack/build/412089d9209b44f2a6a1261bd3593ea5/log/job-output.txt#34092 , openstack | 04:30 |
| yadnesh | telemetry team was planning to switch to a different image source, would it be possible to sync images to opendev mirrors ? | 04:30 |
| frickler | gtema: is https://review.opendev.org/c/openstack/project-config/+/847135 still relevant or can it be abandoned? | 07:48 |
| * frickler doing a bit of backlog trimming | 07:49 | |
| gtema | uhm, honestly speaking I do not know. I changed company, but this still can be done for the glory of OpenStack ;-) | 07:50 |
| gtema | gimme maybe half a day and I will try to check with various parties whether this makes sense (it does make sense, but it requires some dedication) | 07:52 |
| frickler | gtema: no more otc? | 08:00 |
| gtema | I am not there anymore | 08:00 |
| eandersson | Apparently there is a configuration option for coverage that fixes coverage issues with greenlet. | 11:17 |
| eandersson | https://review.opendev.org/c/openstack/designate/+/900108/3/.coveragerc | 11:17 |
| frickler | eandersson: seeing your followup in #-dns it looks like you were just talking to yourself? ;) | 12:16 |
| eandersson | Yea just justifying the two useless rebases | 12:29 |
| Clark[m] | yadnesh: we stopped building and mirroring fedora because it's cadence is just too quick for us to keep up. For example the fedora 37 image your job uses is end of life in less than a week. My suggestion would be that you report the broken mirrors to fedora so they can be fixed and possibly look at alternative images that don't EOL every 13 months. | 13:54 |
| *** amoralej_ is now known as amoralej | 14:06 | |
| fungi | it sounds like the desire is for a more full-featured image to boot in devstack, as opposed to cirros? | 14:13 |
| ildikov | Hi OpenDev Team, I have a patch in the StarlingX election repo that is approved, but didn't reach the merged status: https://review.opendev.org/c/starlingx/election/+/900100 Can you help me figure out what went wrong with it? | 14:15 |
| fungi | ildikov: its parent is abandoned | 14:16 |
| fungi | rebase it onto the current branch state rather than on top of the abandoned https://review.opendev.org/c/starlingx/election/+/900058 change | 14:17 |
| ildikov | fungi: good catch, thank you! | 14:17 |
| fungi | any time! | 14:18 |
| ildikov | I think I stared at it too long to see that trivial issue, lol | 14:18 |
| fungi | Clark[m]: aha, i knew if i was too lazy to look into the compress error, someone else would report it upstream anyway! something about sitting on the river bank while the corpses of your enemies float by... https://github.com/pennersr/django-allauth/issues/3513 | 14:20 |
| tonyb | yadnesh: You should for sure report that to the Fedora mirror admins, meanwhile if you can provide details on what you're looking for by using Fedora that'd be helpful | 14:20 |
| Clark[m] | fungi: looks like they closed it. The changelog entry there probably makes more sense to someone that understands what that library does than it does to me | 14:25 |
| ildikov | fungi: I rebased the change and Gerrit shows that it's in Work in Progress state. How can I make it 'Active'? | 14:26 |
| fungi | Clark[m]: i think it's that mailman needs to add an extra template file | 14:26 |
| ildikov | fungi: I made edits on it to resolve the merge conflict | 14:28 |
| fungi | ildikov: https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/starlingx/election.config doesn't seem to allow anyone other than the change owner to toggle wip state | 14:29 |
| ildikov | fungi: isn't that the workflow label? | 14:30 |
| tonyb | Nope Worflow is +W | 14:30 |
| tonyb | WiP is different | 14:30 |
| ildikov | tonyb: ah, ok, because W -1 puts the patch into 'a' WIP state | 14:31 |
| ildikov | which is where my confusion is coming from with this one | 14:31 |
| ildikov | how can the patch owner fix this? | 14:32 |
| tonyb | They could/should rebase it onto the current master of the election repo and if it's still a "work in progress" they can filp that under the "3 dots" menu to the far right of the gerrit UI | 14:33 |
| tonyb | ildikov: If starlingX's election process doesn't require the change owner and the candidate to be the same account then I/you could do that | 14:34 |
| fungi | or adjust the acl for that repo to allow core reviewers to toggle wip on changes too | 14:35 |
| tonyb | fungi: That too | 14:35 |
| fungi | an example: https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/openstack/bashate.config#L8 | 14:35 |
| ildikov | tonyb: the patch owner needed to fix the commit message and they did it as a new commit, but I missed that the new commit was on top of the original one that needed to be fixed. So I abandoned the orginal one already. Then when the issue got clear to me, then I went ahead and rebased the change to fix it, but it ended up in a weird merge conflict, which I resolved, but couldn't remove the patch from WIP. | 14:36 |
| fungi | a bit of history, workflow -1 votes were our old workaround for gerrit's lack of a wip state. then more recently, gerrit finally added a built-in wip feature, but acls for projects haven't really caught up | 14:37 |
| ildikov | tonyb: The StarlingX election process doesn't say anything about the details of how to fix issues like this, and that the owner has to. | 14:37 |
| ildikov | fungi: ah, thanks for sharing that detail, I did miss that too, regarding Gerrit's 'WIP' state | 14:38 |
| ildikov | tonyb: fungi: many times election officials or someone else help the submitter with submitting their noinations, so having either the election officials or you fix this current issue would be perfectly fine | 14:39 |
| tonyb | ildikov: Okay I'll fix it ... gimme 5 | 14:39 |
| ildikov | fungi: and I think having cores be able to toggle WIP would also be a good way forward | 14:39 |
| fungi | a bunch of openstack projects have added something like "toggleWipState = group myproject-core" to their acls, the starlingx community could consider doing the same | 14:39 |
| ildikov | fungi: thank you!! | 14:39 |
| ildikov | fungi: I'll share that on the ML | 14:39 |
| tonyb | ildikov: just be 100% clear we're talking about https://review.opendev.org/c/starlingx/election/+/900100 | 14:40 |
| fungi | otherwise, yes, you can get in a situation where some change owner sets wip on their change, then goes on vacation and the core reviewers can't merge it until they return | 14:40 |
| fungi | since wip state is "sticky" and persists into subsequent revisions until it gets unset explicitly | 14:41 |
| Clark[m] | Note, gerrit doesn't seem to have recorded a switch to wip so I think it was pushed this way. I would also encourage people to not push code as wip unless they don't want it to be merged | 14:41 |
| Clark[m] | In this case it seems the intent is to make it mergable so wip is counter productive | 14:42 |
| tonyb | clarkb: I think it landed that way because of the mergeconflict and parent issues | 14:42 |
| fungi | well, gerrit won't automatically set work-in-progress on changes | 14:43 |
| fungi | git-review has a -w option where you can set wip when pushing a change though | 14:43 |
| Clark[m] | That doesn't put things into a wip state though? You have to either explicitly select the state in the UI or explicitly push to the WIP push destination | 14:43 |
| Clark[m] | I'm saying people should be told to only do that if their intention is something not merge | 14:44 |
| tonyb | Fair | 14:44 |
| Clark[m] | In this case the intention is to merge a candidacy so wip is problematic | 14:44 |
| fungi | i've seen this before with starlingx changes. i gave someone feedback on a change which was in wip state, and they expressed that they weren't looking for feedback yet and that's why they had pushed it as wip | 14:45 |
| ildikov | tonyb: yes, that is the patch | 14:45 |
| ildikov | Clark[m]: it wasn't pushed as WIP, I rebased it on top of master on the GUI allowing conflicts. Which was probably a stupid choice, but I only realized after I ended up in a pickle with it. | 14:46 |
| fungi | it seems like they may have a culture of pushing their changes in wip state by default, and then turning off wip once they're comfortable with someone reviewing them | 14:46 |
| fungi | ildikov: the original patch bruce pushed was pushed in a wip state, and that persisted onto your revision | 14:47 |
| ildikov | fungi: but it showed 'Active' in Gerrit | 14:47 |
| ildikov | Where is that visible otherwise? | 14:48 |
| ildikov | fungi: I mean the Gerrit GUI had the 'Active' label on it when I last checked | 14:48 |
| fungi | very odd in that case. gerrit's change log doesn't show anyone setting it to wip | 14:48 |
| ildikov | WIP showed up after it ended up in a merge conflict | 14:49 |
| fungi | did you rebase locally and push? | 14:49 |
| ildikov | no, I rebased on the GUI, and checked the chekbox allowing conflicts | 14:50 |
| fungi | maybe this is a new effect of the rebase button in the webui | 14:50 |
| tonyb | That's what I'm thinking | 14:50 |
| tonyb | ildikov: https://review.opendev.org/c/starlingx/election/+/900421 | 14:50 |
| ildikov | yeah, that's my thinking too | 14:50 |
| fungi | oh, i had no idea gerrit started allowing you to rebase changes when they had merge conflicts | 14:50 |
| fungi | i think that must be a new "feature" | 14:50 |
| Clark[m] | Note all wip changes are in merge conflict due to a quirk of gerrit's interpretation of mergable changes. Wip is not mergable so it shows as in merge conflict | 14:50 |
| fungi | in that case, i agree it probably auto-sets wip state on the revision it creates | 14:51 |
| Clark[m] | I'm not sure it was actually in merge conflict | 14:51 |
| ildikov | tonyb: did you end up putting up a new change? | 14:51 |
| fungi | well, in this case it rebased onto a nonexistent parent | 14:51 |
| ildikov | Clark[m]: it was, it modified all the files that Bruce originally submitted with the merge conflict headers. I removed those already | 14:52 |
| tonyb | ildikov: that change doesn't contain a DCO. As the 900100 also doesn't have one due to the rebase/edit history | 14:52 |
| ildikov | tonyb: I think that's fine, I just thought y'all can fix the one that's stuck in WIP | 14:53 |
| tonyb | ildikov: Yup I pushed a new one. I can also push onto 900100 to see what happens, but I suspect as I'm not the owner it will stay in WIP | 14:53 |
| ildikov | otherwise I would've cherry-picked it myself :) | 14:53 |
| tonyb | Ahh sorry I miscommunicated that :/ | 14:54 |
| fungi | ah, okay, the parent isn't nonexistent, gerrit's commit id search link is simply broken. 7878c22 is the penultimate change on the branch at the moment | 14:54 |
| ildikov | fungi: +1 | 14:54 |
| fungi | and just to be clear, bruce isn't around to un-set the wip state on 900100 | 14:56 |
| ildikov | fungi: if he will attend the StarlingX TSC meeting then I can ask him to try to do that. Otherwise I can drop him an email and see. Is this a button on the GUI for him? | 14:57 |
| Clark[m] | fungi: commit sha search doesn't work for merge commits if the parent is a merge commit | 14:58 |
| ildikov | I'm just asking how he can unset it, in case I'll need to explain the process. | 14:58 |
| fungi | ildikov: in the top-right corner next to the rebase button he'll see "mark as active" with an eye icon next to it | 14:58 |
| ildikov | But we also have another version of the change up now | 14:58 |
| Clark[m] | Because typically there is no 1:1 mapping of a merge commit to a change id | 14:58 |
| ildikov | fungi: cool, thank you! | 14:59 |
| fungi | Clark[m]: oh, right, i get it. gerrit won't show the commit if it's not the hash of a change | 14:59 |
| *** blarnath is now known as d34dh0r53 | 15:00 | |
| fungi | ildikov: also, i'd avoid "allow merge-conflicts" in the future, since the change won't be able to merge if it has merge conflicts, and you'll need to resolve those locally and re-push the revision anyway | 15:02 |
| fungi | (if it has actual merge conflicts) | 15:02 |
| ildikov | tonyb: fungi: ok, I did catch Bruce and he fixed the WIP | 15:16 |
| fungi | awesome. i confirm it says "active" now | 15:17 |
| tonyb | Great. I abandoned the one I made | 15:17 |
| ildikov | fungi: this one was a very easy fix. It was also surprising to see how git dealt with it, as there were no files in the folders where the conflicts appeared at the end | 15:18 |
| ildikov | tonyb: great, thank you | 15:18 |
| ildikov | fungi: so I only chose that option as I did see what conflict there would be in the first place | 15:18 |
| fungi | ildikov: yeah, i have a feeling "allow merge conflicts" with the rebase button may just always set the change into a wip state | 15:19 |
| ildikov | *did NOT see | 15:19 |
| ildikov | fungi: yeah, that was the learning curve on my end as I was not aware of the possibility itself of that happening | 15:19 |
| fungi | which seems like an odd behavior if so, since normal users wouldn't otherwise be able to set someone's change to wip | 15:19 |
| ildikov | now that I know, I would not choose that option again :) | 15:19 |
| tonyb | ildikov: You, or another election person, may want to update the acl file to allow toggleWipState, like https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/openstack/bashate.config#L8 | 15:28 |
| ajaiswal[m] | tonyb: i guess we need to update here | 15:40 |
| ajaiswal[m] | https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/starlingx/election.config | 15:40 |
| ajaiswal[m] | field toggleWipState = | 15:41 |
| fungi | ajaiswal[m]: yes. you can see an example at https://opendev.org/openstack/project-config/src/branch/master/gerrit/acls/openstack/bashate.config#L8 | 15:49 |
| frickler | fwiw I've been using the UI rebase-with-conflict a couple of times and resolved the conflicts in the UI editor afterwards. makes it easier if I don't already have the repo locally. so I wouldn't want us to disable that feature | 15:59 |
| fungi | frickler: good to know, and i keep forgetting they added an interactive editor to the ui. have you also observed the behavior described above, where the rebase button with "allow merge conflicts" set switches the change into wip state? | 16:03 |
| fungi | if that's really how it works, my main concern is that the feature effectively allows people to switch a change to wip without the ability to switch it back to ready | 16:03 |
| frickler | fungi: yes, it switches to wip if there are actual merge conflicts, which kind of seems useful to me, but I do see the point about diverging permissions, maybe that could be considered a gerrit bug | 16:13 |
| tonyb | clarkb, fungi: meetpad in ~35mins ? | 17:26 |
| fungi | yeppers | 17:27 |
| * tonyb may wander for coffee | 17:27 | |
| clarkb | yup I made it back in time | 17:45 |
| tonyb | Nice | 17:46 |
| clarkb | I am here: https://meetpad.opendev.org/opendev-root-bootstrap | 18:00 |
| opendevreview | Jeremy Stanley proposed opendev/irc-meetings master: Update OpenStack TC meeting chair https://review.opendev.org/c/opendev/irc-meetings/+/900444 | 18:06 |
| opendevreview | Merged opendev/irc-meetings master: Update OpenStack TC meeting chair https://review.opendev.org/c/opendev/irc-meetings/+/900444 | 18:46 |
| *** JayF is now known as JasonF | 18:53 | |
| *** JasonF is now known as JayF | 18:53 | |
| fungi | popping out for a quick dinner, but should be back around 21:00 utc or so | 19:56 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Improve etherpad functional testing https://review.opendev.org/c/opendev/system-config/+/900457 | 20:55 |
| clarkb | theres the testing thing I wanted to do yesterday before getting distracted by the shiny utf8 glyphs | 20:56 |
| tonyb | Nice | 21:16 |
| tonyb | clarkb: I have a couple of questions before I head out for beer | 21:18 |
| clarkb | go for it | 21:18 |
| tonyb | I notice that the RAX VMs all have '-int' names and addresses. I assume I shoudl just include them with the zone update, and get the IP from the openstack CLI on the bridge node | 21:19 |
| tonyb | .... Or I guess I could get it directly from the new mirror02 with 'ip addr' | 21:19 |
| clarkb | tonyb: oh yes the rax mirrors get dns names for the intenral addresses because traffic is so much quicker there | 21:20 |
| clarkb | ya ip addr works too | 21:20 |
| clarkb | its the 10 net address that only routes within rax and we have test nodes connect to that because throughput is much better | 21:20 |
| tonyb | Okay. got it | 21:20 |
| tonyb | Next, I tried to log into the wiki server to look at it. I think I may have made a mistake with the key choice as it seems to be rejected by the sshd on wiki. | 21:21 |
| tonyb | is there a known workaround | 21:22 |
| tonyb | Note I can get through the hostkey exchnage the server is rejecting my key itself | 21:22 |
| clarkb | tonyb: ya I think that is beacuse it isn't properly managed so one of us need to add you manually | 21:26 |
| clarkb | I'll defer to fungi on that as he has done most of the care and feeding for it | 21:26 |
| tonyb | Ooooooo of course that makes sense. It isn't in the inventory so ... the user didn't get created. | 21:27 |
| tonyb | No rush at all. I found what I was looking for another way. Apparently we're running REL_1.28, and there are offical containers for it. So something to play with later. | 21:29 |
| fungi | okay, back now | 21:34 |
| fungi | yeah, no real config management on wiki.o.o, i'll copy your key to iy | 21:35 |
| fungi | it | 21:35 |
| tonyb | Thanks | 21:36 |
| fungi | tonyb: see if you can authenticate now | 21:43 |
| tonyb | Yup. Thank you. | 21:44 |
| clarkb | thanks for taking care of that | 21:50 |
| fungi | cool | 21:51 |
| clarkb | I got a new phone today because old one will stop getting security updates this month. And now I'm raging at my bank for getting 2fa all wrong | 21:51 |
| fungi | i even matched up the uid/gid | 21:51 |
| clarkb | anyone know why this may be happening: https://zuul.opendev.org/t/openstack/build/3911c69ca9ca4c9cb24b92c6a269ac17/log/job-output.txt#17953 | 21:59 |
| clarkb | maybe because host.run isn't running in a shell and I'm trying to subshell? | 21:59 |
| clarkb | or maybe its the -O- ? | 22:00 |
| tonyb | Yeah I think you need a bash -c in there. | 22:00 |
| fungi | -qO- should send all content from the request to stdout | 22:01 |
| tonyb | I hit a similar issue when debugging the registry update | 22:01 |
| fungi | but yeah, i'm unclear on why that wouldn't make it into cmd.stdout | 22:02 |
| opendevreview | Clark Boylan proposed opendev/system-config master: Improve etherpad functional testing https://review.opendev.org/c/opendev/system-config/+/900457 | 22:02 |
| clarkb | if that works I'll have to think about formatting the commands a bit nicer | 22:02 |
| fungi | right, could be lack of a shell to handle the redirection, i guess | 22:02 |
| clarkb | alternatively I could do mroe of that in python but I watned to keep the command the same as our admin examples as good coverage for that too | 22:03 |
| tonyb | looks like you need whitespace after the -c | 22:42 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!