| opendevreview | David Hill proposed openstack/diskimage-builder master: Add a warning in satellite configuration https://review.opendev.org/c/openstack/diskimage-builder/+/845650 | 00:40 |
|---|---|---|
| opendevreview | David Hill proposed openstack/diskimage-builder master: Add a warning in satellite configuration https://review.opendev.org/c/openstack/diskimage-builder/+/845650 | 00:42 |
| *** rlandy|bbl is now known as rlandy | 00:57 | |
| *** rlandy is now known as rlandy|out | 01:45 | |
| *** ysandeep|sick is now known as ysandeep | 04:37 | |
| *** jpena|off is now known as jpena | 07:35 | |
| *** ysandeep is now known as ysandeep|lunch | 07:45 | |
| *** ysandeep|lunch is now known as ysandeep | 09:14 | |
| *** soniya29|ruck is now known as soniya29|ruck|afk | 09:32 | |
| *** rlandy|out is now known as rlandy | 10:23 | |
| *** soniya29|ruck|afk is now known as soniya29|ruck | 10:23 | |
| BlaisePabon[m]1 | ...probably not... | 11:21 |
| BlaisePabon[m]1 | is there a stray commit in the change? | 11:22 |
| *** dviroel|out is now known as dviroel | 11:22 | |
| fungi | BlaisePabon[m]1: instead of revising the first change to address the review comments, you pushed a separate change with the first change as its parent | 11:22 |
| fungi | normally you'd just revise the first change by amending it and pushing again | 11:22 |
| fungi | remember that in a gerrit workflow (similar to the linux kernel mailing list workflow), you're iterating on improvements to a proposed patch as it will eventually merge, rather than creating a series of patches with each one correcting the mistakes in the previous one | 11:24 |
| fungi | so each revision replaces the original patch in its entirety | 11:25 |
| fungi | gerrit will display the differences between each revision of the patch so reviewers can see how it has evolved | 11:25 |
| *** rlandy is now known as rlandy|mtg | 11:55 | |
| *** ysandeep is now known as ysandeep|afk | 12:15 | |
| *** ysandeep|afk is now known as ysandeep | 12:30 | |
| opendevreview | David Hill proposed openstack/diskimage-builder master: Add a warning in satellite configuration https://review.opendev.org/c/openstack/diskimage-builder/+/845650 | 12:45 |
| opendevreview | Blaise R Pabon proposed opendev/infra-manual master: Update the sandbox instructions Clarify the instructions, reduce ambiguity, increase consistency. Rather than change the legacy OpenStack URLs, I changed the text to acknowledge that we refer to OpenStack. https://review.opendev.org/c/opendev/infra-manual/+/845743 | 12:46 |
| opendevreview | Blaise R Pabon proposed opendev/infra-manual master: Update the sandbox instructions https://review.opendev.org/c/opendev/infra-manual/+/845744 | 12:52 |
| frickler | BlaisePabon[m]1: maybe you should keep practicing in the sandbox for a bit, you keep submitting new patches instead of updating the original one | 12:53 |
| *** gthiemon1e is now known as gthiemonge | 13:15 | |
| *** rlandy|mtg is now known as rlandy | 13:30 | |
| bjonglez_ | hello | 13:43 |
| bjonglez_ | I want to propose changes to Neutron, so I followed https://docs.opendev.org/opendev/infra-manual/latest/gettingstarted.html | 13:43 |
| bjonglez_ | I have an account on Gerrit (bjonglez), and I added my SSH key(s) to it yesterday | 13:43 |
| bjonglez_ | however, "git review -s" doesn't work, my SSH key is not accepted | 13:44 |
| bjonglez_ | ssh review.opendev.org | 13:44 |
| bjonglez_ | bjonglez@review.opendev.org: Permission denied (publickey). | 13:44 |
| bjonglez_ | I'm pretty sure I'm using the right key, I uploaded all of the default ones (id_rsa.pub, id_ecdsa.pub and id_ed25519.pub) to Gerrit | 13:45 |
| bjonglez_ | ah, right, I'm using the wrong SSH port... | 13:47 |
| bjonglez_ | so, SSH login works with port 29418, but "git review -s" still fais: | 13:48 |
| bjonglez_ | The following command failed with exit code 255 "scp -P29418 bjonglez@review.opendev.org:hooks/commit-msg .git/hooks/commit-msg" | 13:48 |
| bjonglez_ | running the scp manually: | 13:48 |
| bjonglez_ | subsystem request failed on channel 0 | 13:48 |
| bjonglez_ | scp: Connection closed | 13:48 |
| BlaisePabon[m]1 | hi bjonglez_ I'm also getting started with Gerrit. Would you like to practice together? | 13:55 |
| * BlaisePabon[m]1 sent a code block: https://matrix.org/_matrix/media/r0/download/matrix.org/vivpuayVnhPrFBwGdUDHxOnu | 13:57 | |
| BlaisePabon[m]1 | in your example you used `scp` | 14:00 |
| jrosser_ | bjonglez_: which version of git-review do you have? | 14:08 |
| bjonglez_ | jrosser_: the version from Debian bookworm, 2.2.0-1 | 14:09 |
| bjonglez_ | I heard about scp being deprecated, maybe my SSH client or the Gerrit server stopped supporting it | 14:10 |
| bjonglez_ | ok, I switched to a HTTPS-based remote URL for gerrit and "git review -s" downloaded the hook | 14:10 |
| jrosser_ | this is probably related to you haveing openssh 9.x | 14:12 |
| jrosser_ | later releases of git-review will work around this | 14:13 |
| jrosser_ | i would recommend installing using pip (and maybe also a virtualenv) rather than using your OS package manager | 14:13 |
| *** ysandeep is now known as ysandeep|out | 14:25 | |
| *** dasm|off is now known as dasm | 14:31 | |
| opendevreview | Blaise R Pabon proposed opendev/infra-manual master: Update the sandbox instructions https://review.opendev.org/c/opendev/infra-manual/+/845593 | 14:33 |
| fungi | bjonglez_: yes, as jrosser_ points out, the scp subsystem deprecation override is in git-review 2.3.0 and later, so 2.2.0 is definitely too old | 14:38 |
| fungi | zigo is one of the maintainers for that package in debian, so may want to be aware. in particular, you could file a bug report against the git-review package in debian asking for it to be updated to latest upstream, since that version is no longer compatible with the openssh version in sid and bookworm | 14:39 |
| zigo | Yes, please file a bug, and I'll do the work. | 14:40 |
| fungi | bjonglez_: if you want to hand-patch your local version with just that fix, you can also just apply the diff for git_review/cmd.py in https://review.opendev.org/823413 (it's really just four additional lines of python) | 14:43 |
| bjonglez_ | fungi: right, thanks a lot! I will open a debian bug report then | 14:54 |
| Clark[m] | Side note rsa keys won't work with Gerrit until 3.6 if using newer openssh | 14:57 |
| BlaisePabon[m]1 | ed25519 FTW | 15:00 |
| bjonglez_ | https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1012808 | 15:12 |
| *** soniya29|ruck is now known as soniya29|out | 15:21 | |
| *** dviroel is now known as dviroel|lunch | 15:58 | |
| opendevreview | Merged openstack/project-config master: Remove lower-constraints and tox-py36 from Neutron Grafana https://review.opendev.org/c/openstack/project-config/+/844254 | 15:58 |
| opendevreview | Merged openstack/project-config master: Add py38/py39 jobs to Grafana https://review.opendev.org/c/openstack/project-config/+/845596 | 15:58 |
| *** marios is now known as marios|out | 16:00 | |
| admin1 | https://gist.githubusercontent.com/a1git/451de74df71977c971455abb806eede9/raw/193defa9d156d04507373f77b2808514e9252034/gistfile1.txt -- this is how I am creating the 8080 via user_variables override | 16:05 |
| fungi | admin1: sorry, i must be missing some context since i have no idea what that is... did you mean to post in a different channel maybe? | 16:35 |
| *** jpena is now known as jpena|off | 17:04 | |
| admin1 | fungi .. sorry .. it was for a diff channel | 17:08 |
| fungi | no problem! just making sure i wasn't missing something important ;) | 17:13 |
| *** dviroel|lunch is now known as dviroel | 17:17 | |
| *** rlandy is now known as rlandy|mtg | 18:15 | |
| *** rlandy|mtg is now known as rlandy | 19:01 | |
| ianw | it looks like since i last looked at grafana alerting it's all basically completely changed anyway -- https://grafana.com/docs/grafana/latest/alerting/alerting-rules/create-grafana-managed-rule/ | 19:52 |
| ianw | the whole rsa key thing is definitely a big carrot for 3.6 | 20:01 |
| ianw | returning to a prior issue -> https://grafana.opendev.org/d/1f6dfd6769/opendev-load-balancer?orgId=1&from=now-7d&to=now&viewPanel=5 | 20:05 |
| ianw | it seems like we had 4 days of really big spikes at periodic job time (it seemed to be causing responsiveness issues for gitea) | 20:06 |
| ianw | but things have settled down now? | 20:06 |
| ianw | theories on this welcome :) | 20:06 |
| fungi | maybe there was something else going on in the background? maybe some other environment also has a cronjob which was pulling from gitea in addition to ours? | 20:15 |
| ianw | it could have been/be external, i had missed the actual period of high load and didn't do a retroactive analysis of the traffic logs to see where it was coming from | 20:20 |
| clarkb | zuul jobs should never talk to gitea | 20:25 |
| clarkb | I think that rule is broken by constraints but otherwise is generally true | 20:26 |
| ianw | maybe one periodic job is doing something odd * number of opendev repositories or something? | 20:28 |
| clarkb | ianw: left a note on the docs update with a -1 since it impacts one of the goals of the change | 20:34 |
| *** dviroel is now known as dviroel|afk | 20:46 | |
| fungi | the openstack/releases jobs also pull from gitea because they can't predict in advance which openstack repos they'll need | 20:50 |
| *** dasm is now known as dasm|off | 21:02 | |
| *** rlandy is now known as rlandy|bbl | 21:58 | |
| opendevreview | Ian Wienand proposed opendev/system-config master: gerrit docs: cleanup and use shell-session https://review.opendev.org/c/opendev/system-config/+/845066 | 22:01 |
| ianw | clarkb: ^ thanks | 22:02 |
| ianw | clarkb: i think where i got stuck was that i needed to remove the email address from the external-id too. in the instructions it calls delete on the identity, do you think we need to note you might need to delete the email too? | 22:03 |
| clarkb | ianw: I'm not sure I understand the question. | 22:06 |
| clarkb | oh I see | 22:06 |
| fungi | that's what one of the account cleanup scripts doea | 22:06 |
| fungi | does | 22:06 |
| clarkb | identity in this case being the openid as described in the doc | 22:07 |
| clarkb | yes the email has to be remove dtoo to remove the conflict if that is the issue | 22:07 |
| clarkb | if the user never added extra emails that won't exist | 22:07 |
| clarkb | so its only in the case where they have added emails on top of what the openid specified | 22:07 |
| ianw | ok, so that is an expected possible outcome. i might add a note | 22:08 |
| fungi | in short, one of the newer gerrit behaviors is that you can't use an e-mail address in a new account even if it's only associated with an inactive account | 22:08 |
| opendevreview | Ian Wienand proposed opendev/system-config master: gerrit docs: add note that duplicate user may have email addresses to remove https://review.opendev.org/c/opendev/system-config/+/845853 | 22:12 |
| *** rlandy|bbl is now known as rlandy | 23:59 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!