| openstackgerrit | Clark Boylan proposed opendev/system-config master: WIP: Add commentlinks for polygerrit https://review.opendev.org/756177 | 00:27 |
|---|---|---|
| clarkb | fungi: ^ I quickly put that together and will test it tomorrow | 00:28 |
| clarkb | infra-root fungi and I successfully upgraded review-test today to 2.16 (pre notedb for changes) | 00:28 |
| clarkb | first thing I've noticed is taht commentlinks don't work for polygerrit which I've starting hacking on at ^ but have run out of time and need to do evening things now | 00:28 |
| clarkb | I'll continue to poke at that tomorrow. Once we're generally happy with it the next thing I want to do is the notedb migration and possibly a 3.0 upgrade | 00:29 |
| ianw | ++ | 00:29 |
| clarkb | I'm beginnig to think our upgrade process might be something like Day N: do the upgrade to 2.16 without notedb. Then Day N + M do notedb migration + 3.x upgrade | 00:30 |
| clarkb | I'm also beginning to realize that we likely won't get every integration working | 00:30 |
| fungi | i'm beginning to realize i need a drink | 00:31 |
| clarkb | in part because if we make 2.16 integrate well we'll likely just throw all that away when we get to 3.x but its hard to make the huge leap to 3.x in one go | 00:31 |
| fungi | okay, that's a lie, i realized hours ago i needed a drink | 00:31 |
| clarkb | but I think that gets us to a better spot that is sustainable then we can build on top of that from there | 00:31 |
| ianw | i think that sounds sane, especially if we're talking days between | 00:31 |
| clarkb | anyway still plenty to learn but early progress is promising | 00:31 |
| ianw | i'm imagining things like storyboard/irc are the pain points? | 00:32 |
| clarkb | ianw: ya | 00:32 |
| clarkb | well actually irc should be fine | 00:32 |
| clarkb | storyboard and the ci summary system are problems | 00:32 |
| clarkb | ci summary system because checks plugin is in limbo? | 00:32 |
| fungi | and maybe anything else which uses hook scripts | 00:32 |
| fungi | or alters the ui javascript | 00:32 |
| ianw | yeah, i'd rate the upgrade more important than the ui overlay at this point | 00:33 |
| clarkb | ok food was just waved in front of me to prove it is dinner time | 00:33 |
| clarkb | I'm going to go do that | 00:33 |
| fungi | enjoy! | 00:33 |
| clarkb | ianw: ya and I'm hoping that we'll be able to build new once there in a sustainable way | 00:33 |
| clarkb | ianw: since polygerrit seems to be sitcking around etc | 00:33 |
| clarkb | we can discuss in tomorrows meeting too | 00:33 |
| *** hamalq has quit IRC | 00:41 | |
| fungi | not entirely certain i'll be around for the meeting, but will try | 00:54 |
| clarkb | ok I did more fiddling with the commentlinks. There were some bugs in my string, fixed those. Then still it wasn't working. Put things in a javascript regex tester, took the output of its substitutions and pasted it into the firefox inspect element rewrite tool and it works then :/ | 01:36 |
| clarkb | which means I'm really stumped at what the problem is now | 01:36 |
| clarkb | it does make me wonder if commentlinks are not handled by polygerrit | 01:36 |
| openstackgerrit | Clark Boylan proposed opendev/system-config master: WIP: Add commentlinks for polygerrit https://review.opendev.org/756177 | 01:40 |
| clarkb | thats the simplified version that based on javascript regex tester should work | 01:40 |
| clarkb | https://gerrit.googlesource.com/gerrit/+/stable-2.16/Documentation/config-gerrit.txt#1431 may be a clue | 01:52 |
| clarkb | ok I give up for the night. Itried fiddling with what I thought was the raw data but that isn't working either :/ | 02:16 |
| clarkb | I've turned the server off again and will look at this again tomorrow | 02:16 |
| *** fressi has joined #opendev | 04:02 | |
| openstackgerrit | Merged openstack/project-config master: Add Review-Priority flag for cloudkitty https://review.opendev.org/756072 | 04:05 |
| *** ykarel|away has joined #opendev | 04:31 | |
| *** ykarel|away is now known as ykarel | 04:36 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: validate network connectivity https://review.opendev.org/755505 | 04:42 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: < 1500 MTU workaround https://review.opendev.org/747063 | 04:42 |
| *** marios has joined #opendev | 05:06 | |
| *** fressi has quit IRC | 05:12 | |
| *** ysandeep|away is now known as ysandeep | 05:26 | |
| *** Topner has joined #opendev | 05:46 | |
| *** Topner has quit IRC | 05:51 | |
| *** cloudnull2 has joined #opendev | 06:03 | |
| *** gouthamr has quit IRC | 06:05 | |
| *** bbezak has quit IRC | 06:05 | |
| *** jbryce has quit IRC | 06:05 | |
| *** dviroel has quit IRC | 06:05 | |
| *** weshay|ruck has quit IRC | 06:05 | |
| *** cloudnull has quit IRC | 06:05 | |
| *** openstackgerrit has quit IRC | 06:05 | |
| *** ttx has quit IRC | 06:05 | |
| *** cloudnull2 is now known as cloudnull | 06:05 | |
| *** bbezak has joined #opendev | 06:05 | |
| *** dviroel has joined #opendev | 06:05 | |
| *** gouthamr has joined #opendev | 06:05 | |
| *** jbryce has joined #opendev | 06:05 | |
| *** weshay has joined #opendev | 06:06 | |
| *** ttx has joined #opendev | 06:10 | |
| *** slaweq has joined #opendev | 06:10 | |
| *** eolivare has joined #opendev | 06:35 | |
| *** ralonsoh has joined #opendev | 06:36 | |
| *** fressi has joined #opendev | 06:46 | |
| *** ttx has quit IRC | 06:50 | |
| *** ttx has joined #opendev | 06:51 | |
| *** slaweq has quit IRC | 07:03 | |
| *** andrewbonney has joined #opendev | 07:21 | |
| *** ralonsoh has quit IRC | 07:21 | |
| *** ralonsoh has joined #opendev | 07:23 | |
| *** fressi has quit IRC | 07:42 | |
| *** tosky has joined #opendev | 07:44 | |
| *** rpittau|afk is now known as rpittau | 07:45 | |
| *** mnasiadka has joined #opendev | 07:47 | |
| *** Topner has joined #opendev | 07:47 | |
| *** fressi has joined #opendev | 07:48 | |
| *** Topner has quit IRC | 07:52 | |
| noonedeadpunk | ianw: can I ask you to look at https://review.opendev.org/#/c/751614/ when you have a chance? | 07:52 |
| *** moppy has quit IRC | 08:01 | |
| *** moppy has joined #opendev | 08:01 | |
| *** ykarel_ has joined #opendev | 08:06 | |
| *** ykarel has quit IRC | 08:09 | |
| *** ykarel_ is now known as ykarel | 08:11 | |
| *** danpawlik has quit IRC | 08:38 | |
| *** danpawlik has joined #opendev | 08:39 | |
| *** fressi has quit IRC | 08:40 | |
| *** dtantsur|afk is now known as dtantsur | 08:41 | |
| *** fressi has joined #opendev | 08:43 | |
| *** openstackgerrit has joined #opendev | 08:45 | |
| openstackgerrit | Carlos Goncalves proposed zuul/zuul-jobs master: configure-mirrors: add CentOS 8 Stream https://review.opendev.org/734787 | 08:45 |
| *** hashar has joined #opendev | 08:46 | |
| *** slaweq has joined #opendev | 08:47 | |
| *** priteau has joined #opendev | 08:54 | |
| *** fressi has quit IRC | 09:04 | |
| *** fressi has joined #opendev | 09:12 | |
| *** ysandeep is now known as ysandeep|lunch | 09:28 | |
| *** fressi has quit IRC | 09:48 | |
| *** priteau has quit IRC | 09:54 | |
| *** DSpider has joined #opendev | 10:01 | |
| *** bbezak has quit IRC | 10:33 | |
| *** dviroel has quit IRC | 10:33 | |
| *** tkajinam has quit IRC | 10:33 | |
| *** dviroel has joined #opendev | 10:34 | |
| *** bbezak has joined #opendev | 10:34 | |
| *** tkajinam has joined #opendev | 10:34 | |
| *** fressi has joined #opendev | 10:46 | |
| *** ysandeep|lunch is now known as ysandeep | 11:05 | |
| *** roman_g has joined #opendev | 11:10 | |
| *** fressi has quit IRC | 11:13 | |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: ensure-docker: < 1500 MTU workaround https://review.opendev.org/747063 | 11:26 |
| *** eolivare has quit IRC | 11:35 | |
| *** eolivare has joined #opendev | 11:42 | |
| *** lpetrut has joined #opendev | 11:54 | |
| openstackgerrit | Michal Nasiadka proposed openstack/diskimage-builder master: Disable growpart in cloud-init-disable-resizefs https://review.opendev.org/748402 | 12:04 |
| *** ykarel has quit IRC | 12:06 | |
| *** ykarel has joined #opendev | 12:08 | |
| *** fressi has joined #opendev | 12:25 | |
| *** elod is now known as elod_afk | 13:12 | |
| *** ykarel_ has joined #opendev | 13:17 | |
| *** ykarel has quit IRC | 13:18 | |
| *** ykarel_ is now known as ykarel | 13:30 | |
| openstackgerrit | Riccardo Pittau proposed openstack/diskimage-builder master: Convert multi line if statement to case https://review.opendev.org/734479 | 13:38 |
| *** hashar has quit IRC | 13:40 | |
| *** mlavalle has joined #opendev | 13:59 | |
| openstackgerrit | Merged opendev/irc-meetings master: Add Rafael Weingärtner to CloudKitty meeting chairs https://review.opendev.org/756087 | 14:12 |
| fungi | just saw someone use this to share a traceback in #zuul... very compelling alternative to lodgeit! https://privatebin.info/ | 14:20 |
| frickler | "As a user you have to trust the server administrator not to inject any malicious javascript code." I'd trust myself in that case, but I wouldn't want to force that trust for others. though otoh we do so with zuul anyhow | 14:24 |
| fungi | yes, i think the selling point there is for the admin of the service, not the user | 14:25 |
| fungi | on the other hand, that would make abuse much harder to detect, i suppose | 14:26 |
| *** ykarel is now known as ykarel|away | 14:27 | |
| fungi | at least right now if somebody uuencodes a multi-gb file and splits it across thousands of pastes, we can find and clean that up | 14:27 |
| fungi | i suppose large-scale abuse could be countered to some degree with throttling/rate limiting | 14:28 |
| openstackgerrit | Tobias Henkel proposed openstack/diskimage-builder master: Fix running in a venv https://review.opendev.org/756325 | 14:30 |
| *** ykarel|away has quit IRC | 14:47 | |
| AJaeger | mnaser: Vexxhost CI has post failures, see https://review.opendev.org/#/c/755505/ for example | 14:53 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul-jobs master: Pin openstacksdk to <0.48.0 https://review.opendev.org/756331 | 15:09 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul-jobs master: Pin openstacksdk to <0.48.0 https://review.opendev.org/756331 | 15:12 |
| *** elod_afk is now known as elod | 15:15 | |
| *** ysandeep is now known as ysandeep|away | 15:18 | |
| *** sgw has quit IRC | 15:22 | |
| *** sgw has joined #opendev | 15:22 | |
| *** fressi has quit IRC | 15:27 | |
| clarkb | update on the commentlinks. I can match the job name like "tempest-full-py3" as a literal string and that works. I can add in the space after that word "tempest-full-py3 ", but if I add the h in https which is part of the next word like "tempest-full-py3 h" it breaks. I have tried doing a .* and also break | 15:31 |
| clarkb | I have a hunch that the url may be represented as a javascript object by the point we run the commentlink matchers so we can't match it, I'm trying to work around the edges of that idea and will do a commentlink for the suffix after the url next and see if that works | 15:32 |
| clarkb | I'm also cloning the gerrit source to see if I can make sense of the polygerrit commentlink implementation that way | 15:32 |
| clarkb | https://gerrit.googlesource.com/gerrit/+/refs/heads/stable-2.16/polygerrit-ui/app/elements/shared/gr-linked-text/link-text-parser.js#268 unfortunately I think that confirms my suspicion | 15:39 |
| clarkb | if polygerrit recognizes text as a link it renders it as is and skips the commentlink parsing which is called in the else block | 15:39 |
| clarkb | we may need to liev with this as a limitation of the polygerrit ui and figure out some other method of making things pretty (though honestly they aren't that bad currently without commentlink substitution) | 15:40 |
| * clarkb checks newer gerrits to see if that branch changes | 15:40 | |
| *** lpetrut has quit IRC | 15:43 | |
| clarkb | ya that behavior exists through 3.2 at least. 3.1 (and 3.2) added the ability to have a url prefix I think so you can do things like git+https:// type stuff | 15:43 |
| clarkb | but nothing that would match our current zuul comments | 15:44 |
| clarkb | corvus: ^ are you still using the checks plugin with upstream gerrit zuul integration? Wondering if you've got any ideas on how we might approach this if not | 15:44 |
| *** rpittau is now known as rpittau|afk | 15:48 | |
| clarkb | given that I'm going to stop digging into this as I think its basically not doable without changing our zuul comment format. We could do something like - zuuljobcomment jobname builduuid SUCCESS $time zuuljobcomment <- and write out a commentlink that would convert that to what we are used to I think | 15:49 |
| clarkb | but I think the output zuul emits is probably good enough and we can roll with it for now | 15:50 |
| clarkb | next I'm going to do a db backup at 2.16 pre notedb then do a snapshot of the cinder volume so that we can test the 2.16 and beyond upgrade path now without needing to fully go back to 2.13 if we do it multiple times | 15:52 |
| *** hashar has joined #opendev | 15:55 | |
| *** marios has quit IRC | 16:00 | |
| *** hamalq has joined #opendev | 16:12 | |
| clarkb | I'm unmounting /home/gerrit2 on review-test now to do the snapshotting | 16:14 |
| *** dtantsur is now known as dtantsur|afk | 16:18 | |
| openstackgerrit | Merged zuul/zuul-jobs master: ensure-docker: validate network connectivity https://review.opendev.org/755505 | 16:19 |
| clarkb | snapshotting is not quick but I expect this to be done before our meeting and I'll have the server running again so peopel can poke at it and leave more feedback | 16:24 |
| clarkb | but then I think tomorrow I'll try the notedb conversion as well as the 3.x upgrades and see what that looks like | 16:24 |
| clarkb | then we can poke at it again | 16:25 |
| fungi | sounds great | 16:25 |
| openstackgerrit | Merged zuul/zuul-jobs master: Pin openstacksdk to <0.48.0 https://review.opendev.org/756331 | 16:53 |
| clarkb | snapshot is done and I've remounted the cinder volume | 17:04 |
| clarkb | https://review-test.opendev.org is up and running for people to interact with. I'll leave it up for a while now. | 17:04 |
| clarkb | I hvae not yet pushed a change which would also eb a good test | 17:06 |
| clarkb | as far as zuul itnegration goes I expect the zuul testing has us largely covered there so am not too worried about it. | 17:07 |
| clarkb | gertty users might want to check that reviwe-test works for them? I think api auth changes slightly? | 17:08 |
| clarkb | (that might be a bit we need to consider for zuul?) | 17:08 |
| clarkb | ya we need to change zuul's gerrit auth_type to digest | 17:09 |
| clarkb | er basic from digesty | 17:10 |
| openstackgerrit | Merged zuul/zuul-jobs master: ensure-docker: < 1500 MTU workaround https://review.opendev.org/747063 | 17:10 |
| *** eolivare has quit IRC | 17:41 | |
| *** sgw has left #opendev | 17:48 | |
| *** ralonsoh has quit IRC | 17:52 | |
| openstackgerrit | Clark Boylan proposed opendev/system-config master: Build images for gerrit 3.1 and 3.2 https://review.opendev.org/756372 | 17:56 |
| clarkb | I half expect ^ to fail but the way we do image builds is we don't build gerrit in the docker image so the easiest way to find out is to have zuul do it | 17:57 |
| clarkb | I realized I need those images to test beyond a 3.0 upgrade though | 17:57 |
| *** andrewbonney has quit IRC | 18:22 | |
| clarkb | hrm that fails trying to find jgit | 18:26 |
| clarkb | Do we need to predownload jgit? | 18:27 |
| fungi | i added a note on the upgrade pad observing that 2.16 seems to have dropped rel="nofollow" (potentially making it a more attractive target for linkspam again) | 18:27 |
| clarkb | ya I noticed that too ,its noopen? something like that | 18:28 |
| clarkb | my hunch is we need to fetch jgit into the workspace of the job that builds the war | 18:28 |
| clarkb | I'm told lunch is ready though so will haev to look at that after the meeting and a bike ride | 18:28 |
| fungi | noopen is not similar nor does it help that | 18:29 |
| fungi | er, noopener | 18:29 |
| fungi | what that does is tell the browser not to allow the link to cause anything new to load in the same tab | 18:29 |
| fungi | in effort to thwart "tabnapping" exploits at the target | 18:30 |
| fungi | nofollow instructs search engines to not index or at least not improve page ranking of link targets, though the newer ugc attribute is starting to get used similarly to indicate hyperlinks supplied as a part of user-generated content | 18:31 |
| fungi | we asked gerrit upstream to add nofollow to user comment and commit message hyperlinks a few years back after a linkspamming scare | 18:32 |
| fungi | it seems to have regressed or been intentionally undone | 18:32 |
| clarkb | I bet polygerrit just didjt do it | 18:34 |
| *** diablo_rojo has joined #opendev | 18:58 | |
| *** roman_g has quit IRC | 19:01 | |
| openstackgerrit | Clark Boylan proposed opendev/system-config master: Build images for gerrit 3.1 and 3.2 https://review.opendev.org/756372 | 19:47 |
| ianw | fungi: could you poke at https://review.opendev.org/#/c/754070/ which fixes the apache gitea proxy, just to clear that | 19:52 |
| fungi | you bet! | 19:52 |
| *** tosky has quit IRC | 19:52 | |
| fungi | lgtm | 19:54 |
| fungi | ianw: yeah, that graphite failure was odd... i couldn't make heads or tails of it either | 19:57 |
| ianw | i'll see if it repeats ... it should be sending some stats over localhost that graphite should show. it doesn't seem those packets could go missing | 19:58 |
| fungi | makes me wonder if we just don't exercise that job often and it has a non-negligible failure race | 19:59 |
| ianw | yeah, i exercised it a lot during bring-up and never saw it ... that's why i'm actually hoping a recheck gives me something to debug | 20:01 |
| clarkb | I'm discovering that "Removing the origin causes git to use relative local filesystem paths." is git magic | 20:07 |
| openstackgerrit | Merged opendev/base-jobs master: Add centos-8-stream nodeset https://review.opendev.org/734788 | 20:09 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: Add CentOS 8 Stream testing https://review.opendev.org/734787 | 20:14 |
| openstackgerrit | Clark Boylan proposed opendev/system-config master: Build images for gerrit 3.1 and 3.2 https://review.opendev.org/756372 | 20:22 |
| clarkb | corvus: ^ fwiw the end state I'd like to get to is using a copy of that role you pointed out, I'm sort of working backwards frmo what mordred built to that to learn things | 20:22 |
| clarkb | for example that git magic about claering out the git origin remote is wow | 20:22 |
| clarkb | and now I'm going to pop out for a bike ride | 20:23 |
| clarkb | they say its the last warm day of the year, need to take advantage :) | 20:23 |
| openstackgerrit | Merged opendev/system-config master: gitea: fix 3081 proxy https://review.opendev.org/754070 | 20:55 |
| *** slaweq has quit IRC | 21:07 | |
| *** slaweq has joined #opendev | 21:12 | |
| ianw | mnaser: fyi https://zuul.vexxhost.dev/t/opendev/builds is looking like a lot of POST_FAILURE | 21:20 |
| *** slaweq has quit IRC | 21:44 | |
| openstackgerrit | Merged opendev/system-config master: Cleanup graphite01 https://review.opendev.org/755150 | 22:03 |
| *** hashar has quit IRC | 22:04 | |
| openstackgerrit | Ian Wienand proposed opendev/system-config master: doc: update Zuul restart instructions https://review.opendev.org/755155 | 22:35 |
| openstackgerrit | Clark Boylan proposed opendev/system-config master: Build images for gerrit 3.1 and 3.2 https://review.opendev.org/756372 | 22:37 |
| clarkb | I think ^ might actually work. The last ps built a 3.2 image | 22:37 |
| clarkb | before we land ^ I'll do some local verification of those images. Probably tomorrow morning then hopefully do the notedb migration and upgrades on test in the afternoon | 22:38 |
| corvus | clarkb: i'm having trouble seeing any commentlink work | 22:38 |
| clarkb | corvus: I got it to work if I just did a job name as the regex | 22:38 |
| clarkb | corvus: eg match = tempest-full-py3 and link = https://some.url | 22:39 |
| corvus | that's what i'm trying, among other even simpler things and it's not happening | 22:39 |
| corvus | i'm using html instead of link | 22:39 |
| clarkb | ah I didn't get far enough to html since I couldn't get the simple case to work | 22:39 |
| corvus | no joy with link either | 22:39 |
| clarkb | also I was restarting the service, I didn't try the more dynamic reload | 22:40 |
| corvus | hrm, let me try restarting then | 22:40 |
| clarkb | maybe the dynamic reload isn't working properly? (not sure if you are restarting or not) | 22:40 |
| corvus | the reload says it noticed the change but maybe doesn't take effect | 22:40 |
| corvus | ugh. yeah that did it. | 22:41 |
| corvus | it takes a long time to restart :( | 22:41 |
| clarkb | we're learning things at least :( | 22:41 |
| *** qchris has quit IRC | 22:41 | |
| clarkb | ya the restart isn't very quick | 22:41 |
| corvus | clarkb: do you happen to know if the regex matcher is multiline mode? | 22:49 |
| clarkb | corvus: I don't, but I can go look in that source a bit more | 22:49 |
| corvus | clarkb: i can look (do you have a source link handy though?) | 22:50 |
| clarkb | ya one sec | 22:50 |
| corvus | (incidentally "docker restart gerrit-compose_gerrit_1; sleep 12; /etc/init.d/apache2 restart" ) is about right timing wise | 22:51 |
| clarkb | corvus: https://gerrit.googlesource.com/gerrit/+/refs/heads/stable-2.16/polygerrit-ui/app/elements/shared/gr-linked-text/link-text-parser.js#277 | 22:51 |
| corvus | clarkb: thx | 22:52 |
| *** qchris has joined #opendev | 22:53 | |
| corvus | (so that's a negative) | 22:55 |
| clarkb | corvus: if I read that correctly the 'g' at https://gerrit.googlesource.com/gerrit/+/refs/heads/stable-2.16/polygerrit-ui/app/elements/shared/gr-linked-text/link-text-parser.js#304 is where you set the modes and m is multiline | 22:55 |
| clarkb | so ya not multiline | 22:55 |
| corvus | agreed | 22:55 |
| *** mlavalle has quit IRC | 23:03 | |
| corvus | clarkb: it iterates over text chunks, apparently after markdown processing and url processing. given the original message format of "- jobname jobname url : result comment", an individual execution of a commentlink regex is going to get "jobname jobname ". then the next execution will get " : result comment" | 23:19 |
| corvus | the initial "- " is hidden from us, as is the url | 23:19 |
| corvus | (and also the trailing newline) | 23:20 |
| corvus | i should say pseudo markdown processing :/ | 23:20 |
| corvus | if it were real md the solution would be obvious | 23:20 |
| fungi | well, to the extent that there's such a thing as "read markdown" given all the competing post-hoc standards which are floating around for it | 23:21 |
| clarkb | ya so we never see the url at all to match on it? even if it is wrapped in {} or similar? | 23:21 |
| corvus | clarkb: correct | 23:21 |
| corvus | i've learned this by stepping through in the debugger | 23:21 |
| clarkb | in that case probably what zuul does is the best option for us? otherwise we'd have to do some weird zuul comment that is expected to be rewritten with comment links | 23:26 |
| clarkb | like - jobname jobuuid status time then render that to a url ourselves? | 23:26 |
| corvus | i think https://gerrit.googlesource.com/gerrit/+/refs/heads/stable-2.16/polygerrit-ui/app/elements/shared/gr-formatted-text/gr-formatted-text.js is the text formatting bit | 23:29 |
| corvus | i don't see anything about handling urls specially | 23:29 |
| * clarkb writes the email about testing review-test now | 23:30 | |
| corvus | and http://benalman.com/code/projects/javascript-linkify/docs/files/ba-linkify-js.html is what does the chunking/linkify stuff | 23:30 |
| corvus | doesn't look like it has any magic syntax either | 23:30 |
| corvus | clarkb: so yeah, i'm not seeing any good options. | 23:31 |
| corvus | clarkb: i think the new-world gerrit answer would be a polygerrit plugin | 23:32 |
| clarkb | ah interesting. And that is something we can owrk on post upgrade problably | 23:32 |
| clarkb | corvus: I wonder if the mediaiwki folks have already done some of that? | 23:40 |
| clarkb | paladox: ^ | 23:40 |
| corvus | maybe could be added to https://gerrit.googlesource.com/plugins/zuul/ ? | 23:45 |
| clarkb | ooh ya I think that could be a good fit | 23:50 |
| clarkb | heh the first 3.3.0 rc for gerrit shows up just as soon as I make a 3.2 image change | 23:51 |
| clarkb | its ok we're making progress | 23:51 |
| fungi | i expect our upgrade to 3.x can target 3.3 then depending on their release timeline | 23:53 |
| clarkb | possibly, we'll see what we learn when we try the 3.x upgrades next. Supposedly they are easier than the old 2.x upgrades have been | 23:54 |
| clarkb | separately I'm really happy that we've managed to convince people submodules are a bad idea | 23:57 |
| clarkb | my brain has melted thinking about the gerrit job setup :) | 23:57 |
| *** DSpider has quit IRC | 23:58 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!