09:30:52 <BobBall> #startmeeting XenAPI
09:30:53 <openstack> Meeting started Wed Jan 20 09:30:52 2016 UTC and is due to finish in 60 minutes.  The chair is BobBall. Information about MeetBot at http://wiki.debian.org/MeetBot.
09:30:55 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
09:30:57 <openstack> The meeting name has been set to 'xenapi'
09:30:58 <BobBall> Ping johnthetubaguy
09:35:12 * BobBall guesses johnthetubaguy is having a nice lie in
09:36:12 * johnthetubaguy sneaks in
09:36:38 <BobBall> Morning!
09:36:50 <BobBall> Will be a quick meeting today as our Nanjing office has no network connection
09:37:09 <BobBall> There's a new patch up for the VIF plug/unplug issues
09:37:27 <BobBall> #link https://review.openstack.org/#/c/254022/
09:37:36 <BobBall> A re-review would be great.
09:37:47 <BobBall> Since it was close last time I'm hoping it'd be a quick one :)
09:38:03 <johnthetubaguy> eek, no network
09:38:15 <johnthetubaguy> yeah, it should be
09:38:21 <BobBall> The other one that'd be really good if you could review would be https://review.openstack.org/#/c/269536/ which is the trivial fix to rotate_xen_guest_logs we talked about yesterday.  A couple of people have highlighted the race shown by the CI
09:38:25 <johnthetubaguy> thats wasn't on the ready for core list when I looked at that?
09:39:00 <BobBall> Ah - sorry - I keep forgetting to update that one (tbh, after last time I was routinely updating it, it didn't seem to impact when reviews happened)
09:39:39 <johnthetubaguy> well, it doesn't impact much when cores are not very active, its a problem
09:39:49 <BobBall> I'll add it to the list in about 10 minutes :)
09:40:16 <johnthetubaguy> I have a feeling we are missing a test for the exception being raised, but will look more at that later
09:40:21 <BobBall> Anyway - it's just those two that we really want approved as soon as
09:40:40 <BobBall> hmmm yes - quite possibly - I didn't notice that
09:40:59 <BobBall> Anything you want to raise XenAPI-wise?
09:41:26 <johnthetubaguy> unit tests for plugins I guess
09:41:39 <BobBall> Yeah - where was the prototype code you had?
09:41:54 <johnthetubaguy> not sure now, I think I replied to the ML with a link
09:41:58 <johnthetubaguy> let me check quickly
09:42:45 <johnthetubaguy> BobBall: https://review.openstack.org/#/c/128886 and https://github.com/JohnGarbutt/nova/commit/bf834032c13f64de9c634e587b14f32b1590789b
09:43:00 <BobBall> ta
09:43:20 <BobBall> We'll take a look and see what can be done
09:43:22 <johnthetubaguy> its running 2.4 code as 2.7, but thats better than not running it at all
09:43:42 <BobBall> Absolutely
09:43:57 <BobBall> unit tests are mostly for logic things anyway not language syntax testing :)
09:44:18 <BobBall> I do worry about what will happen in the py3 tests though
09:44:33 <BobBall> since I don't think 2.4 has all of the six compatability stuff
09:44:44 <johnthetubaguy> yeah, they totally need skipping for that
09:45:16 <BobBall> Anyway - We'll take a look when we get a chance
09:45:21 <johnthetubaguy> cools
09:45:22 <BobBall> Anything else?
09:45:31 <johnthetubaguy> nothing major for me
09:45:47 <BobBall> Awesome - we'll close there then
09:45:51 <BobBall> Thanks johnthetubaguy
09:45:52 <BobBall> #endmeeting