13:00:06 #startmeeting watcher 13:00:07 Meeting started Wed May 24 13:00:06 2017 UTC and is due to finish in 60 minutes. The chair is alexchadin. Information about MeetBot at http://wiki.debian.org/MeetBot. 13:00:08 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 13:00:11 The meeting name has been set to 'watcher' 13:00:18 hi watcher team 13:00:24 hello everyone 13:00:30 hi 13:00:40 you are welcome, ananth_n 13:00:49 hello 13:00:57 hi hidekazu licanwei 13:01:22 hi alex, thank you for your gift :) 13:01:31 i am still awake 13:01:40 Today's agenda: https://wiki.openstack.org/wiki/Watcher_Meeting_Agenda#05.2F24.2F2017 13:01:51 #topic Announcements 13:01:53 morning 13:01:56 Two weeks left until Pike-2 milestone 13:02:07 alexchadin: I agree thx for the gift 13:02:07 sballe_: morning, Susanne 13:02:21 hidekazu: thx for the gift 13:02:48 licanwei, sballe_ I'm happy that you like my gifts ;) 13:02:54 ananth_n: Good to see you :) 13:03:04 hii 13:03:09 hi sballe 13:03:11 hi adisky_ 13:03:20 #info Two weeks left until Pike-2 milestone 13:03:35 we have a lot of things to do 13:04:10 and there are some long term specs that I really would like to merge by second milestone 13:04:20 we will discuss them today 13:05:09 and ananth_n has come to give us a little bit more infos about his specs 13:05:32 let's move on 13:05:37 #info Watcher Install guide dropped its WiP tag and is ready to be reviewed now 13:05:44 #link https://review.openstack.org/#/c/463281/ 13:06:10 the spec is actively reviewed now. 13:07:07 this commit will be changed a lot of time, of course, so please review it asap 13:07:37 if you have personal issues with watcher installing, don't hesitate to share them with us 13:08:43 this commit will affect on project's maturity level 13:09:09 any other announcements? 13:09:38 #topic Review Action Items 13:09:39 alexchadin: I will review since I will reinstall watcher from scratch in a new cluster I have 13:10:44 sballe_: great! if it is possible, please follow the steps adisky_ proposed 13:11:39 Watcher 13:11:51 Add action description needs reviews #link https://review.openstack.org/#/c/450720/ 13:12:02 yes that was what I was going ot do 13:12:24 hidekazu: could you please review it? 13:12:41 alexchadin: ok, 13:13:11 #action hidekazu review https://review.openstack.org/#/c/450720/ 13:13:31 Add action description notification needs new PS (because of merge conflict) #link https://review.openstack.org/#/c/454638/ 13:14:00 licanwei: have you seen this PS now has merge conflict? 13:14:06 alexchadin: revised spec is accepted first though. 13:14:36 yes 13:14:42 hidekazu: I agree 13:15:05 I'll submit a new PS 13:15:06 licanwei: could you please fix it by the time your spec is merged? 13:15:28 ok 13:15:30 great 13:15:42 #action licanwei submit new PS https://review.openstack.org/#/c/454638/ 13:15:51 Reduced the code complexity can it be merged? #link https://review.openstack.org/#/c/441873/ 13:16:18 hidekazu: I've seen you have some unanswered comments 13:16:46 i added -1 due to trivial reason. 13:17:09 alexchadin: i will fix for my comment and +2 :) 13:17:12 hidekazu: but it may be hard to submit new PS since Béla Vancsics don't answer on it last 7 days 13:18:36 Versioned Notifications for service object needs core reviews #link https://review.openstack.org/#/c/437333/ 13:18:58 Vincent is not here, but I want to merge it ASAP 13:19:32 Vladimir answered on Vincent's comments and it should be ready to go 13:20:16 who can review it? 13:20:43 I will 13:21:18 #action licanwei review https://review.openstack.org/#/c/437333/ 13:21:20 licanwei: thanks 13:21:32 of course i will, but this also spec is not merged 13:22:02 alexchadin: https://review.openstack.org/#/c/445817/ 13:22:45 sballe_: could you please review https://review.openstack.org/#/c/445817/ 13:22:51 yes 13:23:48 hidekazu: we have already merged v.notifications without specs before :) 13:24:05 #action sballe_ review https://review.openstack.org/#/c/445817/ 13:24:31 Noisy Neighbor Strategy needs reviews #link https://review.openstack.org/#/c/454359/ 13:25:16 sballe_: I've reviewed your spec, LGTM, but haven't seen code yet 13:25:32 the code is there too 13:25:37 sballe_: Once I get more time to review, I'll do it firstly 13:25:55 the code is here: https://review.openstack.org/#/c/454359/2 13:26:05 sballe_: I know, above is link to the code 13:26:35 oh I see what you mean. Sorry I misunderstood and thought you couldn;t find the code ;-) 13:26:45 who would like to review Noisy Neighbor Strategy? 13:26:59 We need more people to review the spec so we can merge it and the code of course 13:28:36 sballe_: We need more people at all :) 13:28:54 i will do, but code does not have test at all, i treat this as wip. 13:28:56 agreed. hidekazu can you review please? 13:29:15 #action alexchadin hidekazu review https://review.openstack.org/#/c/454359/ 13:29:23 hidekazu: thank you 13:29:32 thx ... We have been working on the tests I thougth he would have pushed those too. maybe he forgot 13:29:52 Watcher specs 13:30:01 update action description needs reviews #link https://review.openstack.org/#/c/459529/ 13:30:59 licanwei: could you please provide more detailed commit message? 13:31:14 yes 13:32:17 i' ll update the commit message 13:32:25 licanwei: nice! 13:32:42 Build baremetal data model in watcher needs new PS #link https://review.openstack.org/#/c/448016/ 13:33:12 seems Yumeng isn't here 13:33:59 I will tell her tommorrow 13:34:32 Add new actions "power on" and "power off" in Watcher needs reviews #link https://review.openstack.org/#/c/435436/ 13:36:25 sballe_: can you review it? 13:36:32 +1 13:36:41 yes 13:36:59 alexchadin, I will review the power on/off too 13:37:20 lakerzhou, sballe_, licanwei: thanks! 13:37:40 #action sballe_ licanwei lakerzhou review https://review.openstack.org/#/c/435436/ 13:38:01 Noisy Neighbor Strategy spec needs reviews #link https://review.openstack.org/#/c/398162/ 13:39:32 There are some problems with watcher-specs-core group 13:40:04 actully, only two core reviewer left there: me and Susanne 13:40:17 I really need people to review the spec so we can get it upstreamed 13:40:32 can other peopel at least review it and gice it a +1 13:40:49 * sballe_ apologizes for the typos 13:41:01 sballe_: your comments are all clear now? 13:41:02 hvprash, Joe Cropper and acabot aren't reviewing watcher specs for now 13:41:20 sballe_: yeah, sure 13:41:50 hidekazu: yes. everything is good 13:41:50 alexchadin, I will review the noisy neighbor too 13:42:18 #action lakerzhou review https://review.openstack.org/#/c/398162/ 13:42:32 sballe_: ok,i will review 13:43:07 #topic Open Discussions 13:43:08 hidekazu: thx 13:44:13 ananth_n: when do you plan to drop WiP tag from https://review.openstack.org/#/c/448402/ ? 13:44:39 ananth_n: and this one: https://review.openstack.org/#/c/448571/ 13:45:18 thanks alexchadin. it's unlikely to make the Pike 2 timeframe you mentioned. 13:46:04 i.e. within the next 2 weeks due to some other priority items to handle at work 13:47:37 alexchadin: i added bp: https://blueprints.launchpad.net/watcher/+spec/volume-migrate-action 13:47:52 ananth_n: ok, and your spec are ready to be reviewed, right? 13:48:11 yes, the spec is ready for review. so please provide your comments. 13:48:49 alexchadin: this bp is separate from zone-migration-strategy. 13:49:01 hidekazu: isn't it a part of https://review.openstack.org/#/c/450642/ ? 13:49:22 as I address the spec comments, I will also know the scope of the code changes required. 13:49:22 ananth_n: thank you 13:49:56 alexchadin: no, volume-migration-action is not part of cinder model. 13:50:53 alexchadin: I will review fingerpriting.. both spec and code 13:51:32 alexchadin: please see dependency tree in https://blueprints.launchpad.net/watcher/+spec/zone-migration-strategy 13:51:34 sballe_: thanks! 13:52:02 hidekazu: yeah, already seeing, now it make more sense 13:52:53 thanks sballe_ 13:53:09 alexchadin: i will propose volume-migrate-action spec by the next meeting 13:53:30 hidekazu: great! 13:54:03 we need more spec reviewers so I propose discuss it on next meeting 13:54:14 core spec reviewers* 13:55:47 well, is there something else to discuss? 13:56:35 then let's end this meeting :) 13:56:43 thank you for attending! 13:57:01 thanks, bye! 13:57:03 thanks everyone. bye 13:57:04 bye 13:57:21 #endmeeting