08:00:27 <ifat_afek> #startmeeting vitrage
08:00:28 <openstack> Meeting started Wed Jan  9 08:00:27 2019 UTC and is due to finish in 60 minutes.  The chair is ifat_afek. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:00:29 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:00:31 <openstack> The meeting name has been set to 'vitrage'
08:00:35 <ifat_afek> Hi :-)
08:00:38 <e0ne> hi
08:00:49 <eyalb> o/
08:02:24 <ifat_afek> #topic Status and updates
08:02:35 <ifat_afek> Yesterday I released stable/rocky.
08:02:41 <ifat_afek> vitrage 3.3.0
08:02:45 <ifat_afek> vitrage-dashboard 1.6.2
08:02:50 <ifat_afek> python-vitrageclient was not released because there were no real changes since the last release.
08:02:55 <ifat_afek> #link https://review.openstack.org/627900
08:03:04 <ifat_afek> Today I will ask to release Stein, towards the stein-2 milestone that happens this week.
08:03:29 <ifat_afek> My updates: I submitted a change for adding libvirt instance_name property to Vitrage. I also pushed a change for Nova to add the instance name to the instance.create.* versioned notifications.
08:03:35 <ifat_afek> #link https://review.openstack.org/#/c/627176/
08:03:41 <ifat_afek> #link https://review.openstack.org/#/c/627967/
08:03:45 <ifat_afek> #link http://lists.openstack.org/pipermail/openstack-discuss/2018-December/001141.html
08:04:01 <ifat_afek> I also wrote a spec for adding templates with parameters option to Vitrage. It is needed for adding Vitrage templates to Heat. I started working on the implementation.
08:04:06 <ifat_afek> #link https://review.openstack.org/627861
08:04:10 <ifat_afek> #link https://review.openstack.org/#/c/578786
08:04:37 <ifat_afek> The integration of Vitrage and Monasca is still under discussion – you are welcome to join.
08:04:42 <ifat_afek> #link https://review.openstack.org/#/c/622899/
08:04:47 <ifat_afek> #link http://lists.openstack.org/pipermail/openstack-discuss/2018-December/000806.html
08:04:50 <ifat_afek> That’s it for me
08:04:50 <e0ne> great progress, ifat_afek!
08:05:00 <ifat_afek> thanks :-)
08:05:13 <e0ne> I think, I know understand how our tempest tests work
08:05:36 <e0ne> I'm working no removing vitrage dependency from tempest plugin
08:06:02 <e0ne> it went to some uncontrolled way: http://paste.openstack.org/show/740733/ - is't less than 10% of work :(
08:06:22 <e0ne> I thinks, I'll rework my patch before post it to the gerrit
08:06:37 <e0ne> I'm going to remove each cliend dependency separately
08:06:53 <e0ne> now, we use *-pythonclient from vitrage
08:07:30 <ifat_afek> e0ne: what does the pastebin show?
08:07:51 <ifat_afek> And I agree it’s a good idea to do the work in stages, there is just too much of it
08:07:58 <e0ne> the number of changes to pass 3 tests only :(
08:08:15 <ifat_afek> :-(
08:08:52 <e0ne> yea, there is a high code cohesion between tempest plugin and vitrage itself
08:08:55 <ifat_afek> But maybe the first 3 tests are a lot of work and then the others will be much faster?
08:09:12 <e0ne> I hope so
08:09:36 <e0ne> but I'll split this change into the few smaller before publish to gerrit
08:09:41 <e0ne> I'll do it this week
08:09:48 <ifat_afek> It’s a huge refactoring, thanks for handling it
08:10:16 <e0ne> you're welcome! I just want to make vitrage a bit better:)
08:10:23 <ifat_afek> :-)
08:10:37 <idan_hefetz> +1
08:11:07 <idan_hefetz> No updates from my side, as i wasn't in the office this past week...
08:11:17 <eyalb> I will update
08:11:34 <eyalb> I added support for uml and dot format for vitrage client
08:11:54 <eyalb> *graphml
08:12:21 <eyalb> working now on support for notifications for zaqar
08:12:30 <e0ne> #link https://review.openstack.org/#/c/628948/
08:12:40 <e0ne> eyalb: I tested your patch and it works for me
08:12:57 <eyalb> cool
08:13:55 <eyalb> somthing that came up while working on zaqar is multi tenancy in notifications
08:14:08 <eyalb> we still dont support fully
08:14:51 <eyalb> notifications should be sent according to template owner
08:15:01 <eyalb> in case there is a template
08:15:22 <eyalb> but for now I will send it as admin like mistral
08:15:26 <eyalb> thats it
08:15:36 <ifat_afek> or - according to the alarm project, in case this information was set according to the template owner
08:15:53 <e0ne> eyalb: oh.. sounds like an importat bug
08:16:00 <ifat_afek> I think we need to handle template multi tenancy for several reasons
08:16:05 <e0ne> s/importat/important
08:16:10 <ifat_afek> e0ne: it’s not a bug, it’s a feature ;-)
08:17:25 <e0ne> ifat_afek: if we always send some kind of notification as admin - I don't agree that it's a feature. but that's only my IMO
08:17:28 <eyalb> multitenancy in vitrage should be discussed
08:17:38 <e0ne> eyalb: +1
08:17:54 <eyalb> its not as simple as it sounds
08:18:13 <ifat_afek> e0ne: well, in StoryBoard there is no difference between a bug and a feature anyway… I said feature because I believe it’s a significant development
08:18:29 <e0ne> ifat_afek: fair enough
08:19:11 <ifat_afek> we need to add tenant info to the templates, handle it in raised alarms, check all specific actions (e.g. how to handle set state of a resource? compare to the resource tenant to see if it’s allowed?, etc.), and more
08:19:21 <ifat_afek> it requires a design
08:19:46 <eyalb> also rca should be considred
08:19:50 <e0ne> +1. it would be good to have a spec first
08:20:23 <ifat_afek> eyalb: in rca view you see only the alarms that the user is allowed to see (I believe it depends on the underlying resources)
08:20:42 <eyalb> but do you see the phisical layer ?
08:20:50 <eyalb> if you are not admin
08:21:55 <ifat_afek> yes… which is probably wrong
08:24:05 <ifat_afek> Reminder: Denver CFP is open! The deadline for submissions is January 23.
08:24:09 <ifat_afek> #link http://lists.openstack.org/pipermail/openstack-discuss/2018-December/001091.html
08:24:18 <ifat_afek> Any other issues for today’s meeting?
08:24:42 <e0ne> nothing from me
08:25:05 <e0ne> ifat_afek: btw, will we have PTG sessions in Denver?
08:25:37 <ifat_afek> I hope so :-)
08:25:42 <e0ne> great!
08:27:12 <ifat_afek> See you next week
08:27:30 <eyalb> bye
08:27:34 <ifat_afek> #endmeeting