08:01:37 <ifat_afek> #startmeeting vitrage
08:01:38 <openstack> Meeting started Wed May 24 08:01:37 2017 UTC and is due to finish in 60 minutes.  The chair is ifat_afek. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:01:39 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:01:41 <openstack> The meeting name has been set to 'vitrage'
08:01:45 <ifat_afek> Hi :-)
08:01:52 <eyalb> \o/
08:03:06 <annarez> Hi :)
08:03:11 <yujunz> hi
08:03:44 <idan_hefetz> Hi
08:03:46 <dwj> hi
08:04:14 <ifat_afek> Today’s agenda:
08:04:19 <ifat_afek> •	Status and Updates
08:04:26 <ifat_afek> •	Open Discussion
08:04:32 <ifat_afek> #topic Status and Updates
08:04:42 <ifat_afek> I found and fixed a bug in mark-down
08:04:52 <ifat_afek> Apparently there was no test for that… the latest changes in Vitrage-ID broke the mark-down action, and we didn’t noticed. I fixed the problem and added tests.
08:05:37 <ifat_afek> While working on that, idan_hefetz and I realized that the use of IS_REAL_VITRAGE_ID flag is not clear. doffek said he would change it (not sure when, it’s a matter of prioritis)
08:06:46 <ifat_afek> I also started thinking about the integration with Mistral. I’m not sure is what the best way to do it yet. Will update when I have a more clear idea
08:06:55 <ifat_afek> That’s it for me
08:07:25 <yujunz> I understand mistral is a workflow engine. How are vitrage going to use it?
08:07:45 <yujunz> A new action type ? Or something else?
08:07:56 <ifat_afek> That’s one of the questions
08:08:05 <ifat_afek> I was thinking of adding something like:
08:08:11 <ifat_afek> action: external
08:08:18 <ifat_afek> type: mistral
08:08:28 <ifat_afek> parameters: …. dictionary ....
08:08:57 <ifat_afek> But - I’m not sure if I should use the existing mechanism of notifiers for that. Or just call Mistral directly from the action
08:09:21 <ifat_afek> Using the notifiers seems like an abuse. Becuase only the Mistral notifier should care about the Mistral actions
08:09:45 <ifat_afek> And BTW - I want to make it generic, so adding a Congress action later on would be straight forward
08:10:18 <ifat_afek> Another option is that Mistral notifier will receive a notification from Vitrage graph, and decide what to do. This would require a new configuration file for Mistral notifier
08:10:44 <ifat_afek> Or - just pass the notification to Mistral via the message bus. And let Mistral workflow register on the wanted notification
08:11:03 <ifat_afek> These are my initial thoughts… and in any case, the implementation should be quite simple
08:11:29 <yujunz> Got it
08:11:38 <ifat_afek> (since I already managed to execute a Mistral workflow from Vitrage as part of the POC that was presented in Boston)
08:12:05 <ifat_afek> If you have any thoughts or ideas, I’ll be happy to hear them. Now, later, or in the mailing list :-)
08:13:24 <ifat_afek> Who wants to update next?
08:14:03 <yujunz> May I?
08:14:13 <ifat_afek> Sure
08:15:06 <yujunz> Entity equivalence is under review, thanks for all the comments
08:15:30 <yujunz> It is currently a combination of refactoring and new features
08:16:07 <yujunz> If someone wants a separate view of the refactoring, please check https://review.openstack.org/#/c/462532/
08:16:39 <ifat_afek> You sent the abandoned issue
08:16:53 <yujunz> This patch does not include anything of equivalence, just an optimization of scenario repository
08:17:01 <ifat_afek> OK
08:17:06 <yujunz> yes
08:17:10 <yujunz> Because I thought Alexey has finished reviewing
08:17:25 <yujunz> And he is confused with the two patches, so I combined the two
08:17:29 <yujunz> And abandon one
08:17:37 <ifat_afek> I think it’s a good idea to combine them
08:17:54 <ifat_afek> I hope we’ll manage to finish the review process soon
08:18:00 <yujunz> Thanks. Another thing is about osprofiler
08:18:02 <ifat_afek> I think it’s a great improvement
08:18:21 <yujunz> I am looking into it for doctor project and it looks also valuable for vitrage
08:18:22 <ifat_afek> Which is MitmStack? something else? I don’t remember…
08:18:35 <yujunz> osprofiler
08:18:37 <yujunz> #link https://docs.openstack.org/developer/osprofiler/index.html
08:18:50 <yujunz> #link https://www.youtube.com/watch?v=57fTdE1hjeo&t=1223s
08:19:15 <ifat_afek> Right, now I remember that I’ve heard about it
08:19:23 <ifat_afek> Sounds like a good idea to use it in Vitrage
08:19:50 <ifat_afek> So did you start working on that?
08:20:17 <yujunz> I'm working on using it in doctor project. I will consider it for vitrage after OPNFV summit
08:20:30 <ifat_afek> Sounds good
08:20:42 <yujunz> Some other colleague in ZTE is also interested in adding trace point for vitrage for performance evaluation
08:21:06 <yujunz> I think this is the right tool rather than inventing another wheel
08:21:18 <ifat_afek> This could definitely help us
08:21:20 <yujunz> Currently, nova, glance, cinder and many openstack services has already integrated it
08:21:32 <alexey_weyl> Hello Streptacocus :)
08:21:43 <ifat_afek> Hi Alexey!
08:21:47 <yujunz> I think it won't be too difficult. That's all
08:22:06 <ifat_afek> yujunz: Thanks
08:22:24 <ifat_afek> alexey_weyl: do you have any updates? ;-)
08:23:26 <alexey_weyl> Wow, good question, let me see.
08:25:21 <alexey_weyl> I haven't had too much time to work due to me being sick, but I have started to talk with people about some code refactoring in our constants so we will have a unified names
08:26:04 <ifat_afek> Good idea
08:27:14 <yujunz> Speaking of constant name, we need also think about some property name in template.
08:27:24 <ifat_afek> Like what?
08:27:37 <yujunz> Maybe a unified namespace `vitrage_` would be good for things like `is_deleted`
08:27:59 <ifat_afek> I think that’s alexey_weyl’s proposal, more or less
08:28:27 <ifat_afek> To add a vitrage_ prefix to all of the Vitrage properties, to avoid confusion
08:28:57 <alexey_weyl> Yujun we all think a like..
08:29:29 <alexey_weyl> this is a refactoring that I have already strated to make and hopefully it will be done will the end of week..
08:29:46 <ifat_afek> If you feel good, that is ;-)
08:29:57 <alexey_weyl> hhhhhhhh, yeah :)
08:30:46 <ifat_afek> Any other update? alexey_weyl or someone else?
08:32:32 <ifat_afek> #topic Open Discussion
08:33:05 <ifat_afek> We need to decide whether we want to join the PTG in Denver in September. If enough people are interested, I will ask for a room for the design sessions
08:33:26 <ifat_afek> I sent an email to the OpenStack mailing list. Waiting for responses.
08:33:50 <ifat_afek> Any other issue you would like to discuss?\
08:34:05 <yujunz> Nope
08:35:08 <ifat_afek> So let’s end the meeting
08:35:12 <ifat_afek> Bye :-)
08:35:16 <eyalb> bye
08:35:22 <annarez> bye
08:35:29 <dwj> bye
08:35:47 <ifat_afek> #endmeeting