14:00:15 <dkrol> #startmeeting trove
14:00:16 <openstack> Meeting started Wed Mar  6 14:00:15 2019 UTC and is due to finish in 60 minutes.  The chair is dkrol. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:18 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:20 <openstack> The meeting name has been set to 'trove'
14:01:27 <dkrol> Hello
14:01:50 <khasior> Hi
14:02:26 <dkrol> Great to have you here. Where are other people from Samsung?
14:03:31 <khasior> To be honest, I don't know - Bartek was available today but now he is probably afk
14:04:31 <dkrol> Let's wait a few more minutes
14:08:01 <bzurkowski> Hello everybody
14:08:51 <dkrol> Hello
14:09:37 <dkrol> Will Marcin or cezary  come today?
14:09:56 <bzurkowski> I'm afraid not today
14:10:09 <bzurkowski> Busy at the moment
14:10:10 <dkrol> Ok, so can we start?
14:10:28 <bzurkowski> Yes, I think we can start
14:10:31 <bzurkowski> Kasper, are you there? :)
14:10:36 <khasior> yep
14:10:43 <bzurkowski> Then we can start
14:10:47 <dkrol> #topic datastores versioning
14:11:13 <dkrol> Did you have time to take a look at my proposal?
14:11:19 <dkrol> On etherpad
14:12:18 <khasior> I haven't looked at that
14:13:08 <bzurkowski> #link https://etherpad.openstack.org/p/trove-datastore-versioning
14:13:54 <dkrol> I've added to options and a description of the current status
14:14:50 <dkrol> It seems that with each datastores there is a manager associated which is passed to guest agent
14:15:12 <dkrol> But guest agent doesn't have information about data store version
14:15:31 <bzurkowski> I glanced at it quickly
14:16:13 <bzurkowski> That's right, GA doesn't have information about datastore version
14:16:58 <bzurkowski> It seems that implementation of datastore versioning wasn't completed
14:17:05 <dkrol> In my opinion, the quickest way to support new version is to create a new manager
14:17:35 <dkrol> And have for example caasandra3 manager
14:18:13 <bzurkowski> Well
14:18:45 <bzurkowski> Recently, we found abandoned change in repository that introduces multi-version support for Cassandra
14:18:48 <bzurkowski> #link https://review.openstack.org/#/c/323590/
14:19:43 <bzurkowski> Kasper, did you manage to analyze the implementation details?
14:19:52 <dkrol> Looks pretty extensive
14:20:21 <bzurkowski> Yes
14:20:59 <bzurkowski> It is similar to Option 1 proposed in your pad
14:21:02 <khasior> Yes, but the most work related to this change is connected with moving one manager to onother file
14:21:08 <dkrol> Did you analyze it?
14:21:23 <khasior> For me it is a natural and simplest solution
14:21:56 <dkrol> Could you describe it?
14:23:05 <khasior> Now we have a separated module for cassandra - it is moved to to cassandra_common and acts as a base class for cassandra22 and cassandra3
14:23:25 <dkrol> https://review.openstack.org/#/c/323590/4/trove/guestagent/dbaas.py
14:23:45 <khasior> So for older cassandra versions(<=2.1) we just inherit from cassandra_common
14:23:47 <dkrol> So versioning is by adding new managers
14:24:14 <bzurkowski> dkrol: This is actually what I proposed during the last IRC meeting :)
14:24:32 <khasior> and for newer versions we just override and add new methods
14:25:01 <dkrol> Ok, but this is not versioning
14:25:52 <dkrol> This is implementation of cassandra support and how to reuse implementation
14:27:59 <bzurkowski> You are right
14:28:01 <dkrol> This is ok for me but does it requires modification of existing cassandra code?
14:29:22 <khasior> I think applying this change requires mainly small updates because the change is quite old
14:29:56 <bzurkowski> We must review the change in details
14:30:13 <bzurkowski> If we want to support multi-versioning then this is the first implementational step
14:31:27 <khasior> There are some hacks and odd code parts but as a base for for multiple versions support it seems ok
14:32:03 <bzurkowski> Having strategies for several datastore versions sharing common code we can add logic responsible for selecting appropriate manager based on a datastore version requested by user
14:34:41 <dkrol> I suppose we don't have to imement any new way of versioning if we agree we will just add new managers every time
14:36:10 <dkrol> It would be great to use this commit as a base for cassandra 3 support
14:36:46 <dkrol> You mentioned you already have some implementation ready
14:37:11 <dkrol> Will you be able to merge your implemention with this change?
14:38:24 <bzurkowski> dkrol: Our implementation is a subset of modification introduced by the "big" change
14:38:26 <bzurkowski> There should be no problem
14:39:21 <dkrol> Great
14:41:00 <dkrol> Did you checked tesora githtb repo?
14:41:23 <khasior> Yes, there is this change applied
14:42:34 <dkrol> With or without modifications?
14:45:40 <bzurkowski> I didn't check
14:46:01 <dkrol> Ok, they might have added something
14:46:15 <khasior> I am not sure
14:46:40 <dkrol> Ok, I think this is decided
14:46:53 <bzurkowski> The change ID is different from the one in our repo
14:47:15 <bzurkowski> #link https://github.com/Tesora/tesora-trove/commit/d69d7696289aa4f08634cc0e65090f61ebbfbdac#diff-6914d05fd298bb363245b6e7cc0d095f
14:47:53 <dkrol> Is there anything else to discuss about this topic?
14:48:30 <bzurkowski> Not from my side
14:48:39 <khasior> Same here
14:48:56 <dkrol> #topic reject changes
14:49:12 <dkrol> #topic recent changes
14:49:52 <dkrol> In the  topic of recent changes, did you have time to check my two changes about docs?
14:51:16 <bzurkowski> Sorry Darek, I didn't have time last week
14:51:25 <bzurkowski> I was working on the paper
14:51:58 <dkrol> Ok, I hope you will find time in the following weeks
14:52:11 <dkrol> Do you have anything from your side?
14:53:38 <khasior> Not from my side
14:53:52 <bzurkowski> Me neither
14:54:14 <dkrol> Ok, so probably we can end the meeting for today
14:54:21 <dkrol> Thanks for coming
14:54:25 <bzurkowski> Thank you
14:54:29 <bzurkowski> Have a nice day!
14:54:33 <dkrol> See you next time
14:54:35 <dkrol> Bye
14:54:38 <khasior> Bye
14:54:40 <dkrol> #endmeeting