15:01:27 #startmeeting third-party 15:01:28 Meeting started Mon Dec 14 15:01:27 2015 UTC and is due to finish in 60 minutes. The chair is anteaya. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:01:29 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:01:32 The meeting name has been set to 'third_party' 15:01:36 hello 15:01:44 hello! 15:01:54 how are you eantyshev 15:02:13 o/ 15:02:28 o/ 15:02:29 hello mmedvede 15:02:33 hello pabelanger 15:02:49 good morning 15:02:56 morning asselin 15:03:07 does anyone have a topic they would like to discuss today? 15:03:23 I have a few changes, mostly approved, which I don't know how to merge: 253642, 254128, 253619 15:03:34 eantyshev: okay so you want some reviews 15:03:38 eantyshev: yes? 15:03:52 Hi 15:03:56 hi lennyb_ 15:04:00 and 239479 15:04:09 o/ 15:04:11 eantyshev: so you are asking for reviews, is that corrent? 15:04:12 yes, sure 15:04:16 okay thanks 15:04:31 does anyone else have anything they would like to dicuss today? 15:05:16 the only topic in the table is eantyshev's review requests? 15:05:37 well actually I have a question before we get to the reviews 15:05:47 eantyshev: in this patch #link https://review.openstack.org/#/c/255930/2 15:05:53 I don't understand the commit message 15:06:03 what were you seeing that that patch was the fix? 15:07:34 it was a quite clear issue, perhaps most of commit message wasn't neccessary 15:07:47 no, I'm not saying that 15:07:59 honestly, I don't understand 15:08:02 I'm saying I don't have enough back ground information to understand your commit message 15:08:16 the issue was that zuul merger failed to checkout, pull any patches 15:08:23 asselin: thank you 15:08:34 you would get an authentication error. 15:08:51 ah thanks 15:08:52 this was caused by a regression in the zuul code 15:08:57 ah 15:09:10 eantyshev 's patch fixes the regression 15:09:11 asselin: do you know what zuul patch caused the regression? 15:09:30 commit message discusses the root cause analysis 15:09:41 yeah....let me look it up 15:09:46 thanks 15:10:00 asselin: yours was the context I needed for this to make sense, thank you 15:12:41 #link issue introduced here: https://review.openstack.org/#/c/121528/53/zuul/lib/connections.py 15:12:46 asselin: thank you 15:13:42 now I understand, thankyou 15:14:04 eantyshev: did you want to discuss any off your patches you mentioned earlier? 15:14:12 any of* 15:14:36 I think they 15:14:50 're straight-forward. 15:15:01 okay please review eantyshev's patches 15:15:16 does anyone have anything else they would like to discuss today? 15:15:55 does anyone have any objections to me closing the meeting? 15:16:38 thank you everyone for your attendance and participation today, see you next week 15:16:41 #endmeeting