08:03:29 <dkushwaha> #startmeeting tacker
08:03:30 <openstack> Meeting started Tue Feb  5 08:03:29 2019 UTC and is due to finish in 60 minutes.  The chair is dkushwaha. Information about MeetBot at http://wiki.debian.org/MeetBot.
08:03:31 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
08:03:33 <openstack> The meeting name has been set to 'tacker'
08:03:42 <dkushwaha> #topic Roll Call
08:03:53 <joxyuki> hello
08:03:54 <dkushwaha> who is here for Tacker weekly meeting?
08:04:33 <dkushwaha> joxyuki, howdy
08:04:56 <bhagyashris_> Hi
08:05:18 <dkushwaha> hi bhagyashris_
08:07:20 <dkushwaha> ok lets start..
08:07:32 <dkushwaha> #topic announcement
08:07:48 <dkushwaha> We are in the last mont of Stein.
08:07:59 <dkushwaha> #link https://releases.openstack.org/stein/schedule.html
08:09:24 <dkushwaha> Please target the stuffs on priorities
08:10:04 <dkushwaha> My plan is as:
08:10:17 <dkushwaha> 1: finalize specs
08:10:41 <dkushwaha> 2: finish client patches for features.
08:11:05 <dkushwaha> 3: Test and merge server patches
08:11:49 <dkushwaha> and after that Stein release we will have around 2 weeks for RC
08:12:27 <dkushwaha> moving next..
08:12:39 <dkushwaha> #topic BPs
08:13:08 <dkushwaha> #link https://review.openstack.org/#/c/561840
08:13:35 <tpatil> dkushwaha: Hi
08:13:44 <dkushwaha> tpatil, hello
08:13:45 <tpatil> I have replied to your comment on above specs
08:14:58 <tpatil> We have added server_group_id in the VDU
08:15:30 <tpatil> you are asking us to generalized it. Can you please elaborate on this point?
08:16:08 <tpatil> When you create a lease in Blazar, then for each reservation it will create a server_group in nova. So that server group id should be mentioned in the VDU properties
08:18:12 <dkushwaha> tpatil,  My point is to keep TOSCA generalized, what i understand : server_group_id and reservation_id both are for reservation but different type.
08:18:42 <dkushwaha> So IMO it would be great if we keep it parameterized.
08:18:56 <dkushwaha> Please see https://github.com/openstack/tacker/blob/master/samples/tosca-templates/vnfd/tosca-vnfd-http-monitor.yaml#L25
08:19:30 <dkushwaha> https://github.com/openstack/tacker/blob/master/samples/tosca-templates/vnfd/tosca-vnfd-monitor.yaml#L25
08:19:51 <tpatil> we have already added "tosca.policies.tacker.Reservation" type under policies
08:20:38 <dkushwaha> tpatil, yes that is fine
08:20:45 <tpatil> so is it ok to  add reservation_id and server_group_id under ""tosca.policies.tacker.Reservation"" type properties
08:21:07 <tpatil> and then we will need to tied that up with target (VDU1, VDU2) etc
08:23:05 <tpatil> or other possibility is to add reservation_policy under each VDU as done in case of monitor_policy
08:23:31 <dkushwaha> tpatil, http://paste.openstack.org/show/744545/
08:23:37 <joxyuki> tpatil, I think that is better.
08:23:47 <dkushwaha> i mean something like that ^^
08:24:32 <tpatil> dkushwaha: Got your point, will make necessary changes in the specs and code
08:24:36 <dkushwaha> tpatil, that is one of my suggestion, I needs your all inputs on that
08:26:05 <tpatil> even though  we have aded server_group_id in properties of VDU section, Tosca-parser is not complaining about it. Maybe it's not enforcing all rules as defined by TOSCA standards
08:26:59 <tpatil> But I agree to add these options under reservation_meta as suggested to keep things simple and clear
08:27:11 <dkushwaha> We needs TOSCA experts guys for that :)
08:27:39 <dkushwaha> tpatil, IMO, In that way we will be open for further improvements and independent of projects
08:28:35 <tpatil> dkushwaha: Agree
08:29:01 <dkushwaha> moving next..
08:29:26 <dkushwaha> phuoc, are you here?
08:30:23 <dkushwaha> Folks, do you have something more to discuss?
08:30:45 <bhagyashris_> yes
08:31:17 <bhagyashris_> Just want to disused regarding the fix �Add vnf to monitor after restarting the tacker service�.
08:31:31 <bhagyashris_> Currently two patches are up for review (stable.queens and stable/pike) but because of test case failing issue, Zulu jobs are failing on patches,
08:31:42 <bhagyashris_> https://review.openstack.org/#/c/630914/  https://review.openstack.org/#/c/631108/
08:32:13 <bhagyashris_> And we can not cherry pick this patch https://review.openstack.org/#/c/631439/ to fix this issue
08:32:31 <bhagyashris_> So I will need to make changes in the patches itself.
08:33:34 <bhagyashris_> Do we really fix this issue in stable queens and pike?
08:34:54 <dkushwaha> bhagyashris_, Looks cool. As this is test cases related only, so from my side, I am keeping it on low priority. But that will be really good, if you interested to fix it.
08:35:19 <bhagyashris_> Ok. Will do the needful
08:35:27 <bhagyashris_> Thank you :)
08:37:10 <dkushwaha> moving next..
08:37:32 <dkushwaha> #topic Open Discussion
08:38:11 <tpatil> dkushwaha: Whatever changes you have suggested related to server_group_id has no impact on heat-translator, IMO. So we need to request heat team to merge this patch soon : https://review.openstack.org/#/c/619154
08:39:17 <tpatil> dkushwaha: and ask heat team to release a new library and then use in tacker. We are following up with heat team for that. but a little push from your end would be appreciated
08:40:04 <dkushwaha> tpatil, I will ping bob and other members to push it up
08:40:17 <tpatil> dkushwaha: Thank you
08:41:42 <dkushwaha> bhagyashris_, joxyuki tpatil and all Tacker guys, As we are in last month of Stein, So little more help on review and bug fixes are required.
08:42:07 <dkushwaha> Kindly help us on the same, for an smooth release
08:43:21 <tpatil> dkushwaha: Sure
08:43:28 <bhagyashris_> dkushwaha: yes, will do the needful. :)
08:43:42 <dkushwaha> tpatil, bhagyashris_  thanks
08:43:54 <dkushwaha> Nothing from my side for today.
08:45:19 <dkushwaha> I think, we have nothing else for now, so closing this meeting
08:45:25 <dkushwaha> Thanks Folks..
08:45:34 <dkushwaha> #endmeeting