21:00:21 #startmeeting swift 21:00:22 Meeting started Wed Mar 31 21:00:21 2021 UTC and is due to finish in 60 minutes. The chair is timburke. Information about MeetBot at http://wiki.debian.org/MeetBot. 21:00:23 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 21:00:25 The meeting name has been set to 'swift' 21:00:30 who's here for the swift meeting? 21:00:58 hello 21:01:14 o/ 21:01:32 o/ 21:02:10 o/ 21:02:19 o/ 21:02:45 as usual, the agenda's at https://wiki.openstack.org/wiki/Meetings/Swift 21:03:01 mostly the same stuff as last week, but there's definitely some progress :-) 21:03:06 #topic PTG 21:03:34 i finally got around to booking our room slots for next month 21:04:08 they're a little more scattered than i'd meant (since i was late in doing it, things were fuller), but i updated the etherpad with the rooms & times 21:04:15 #link https://etherpad.opendev.org/p/swift-ptg-xena 21:04:44 speaking of the etherpad, we all still need to add discussion topics ;-) 21:04:48 cool, thanks for getting that done timburke 21:05:54 i suspect there will be a decent bit of replication, sharding, relinker talk -- but if there are other things you're interested in, please add them! 21:06:25 speaking of those... 21:06:31 #topic relinker 21:07:09 so we merged https://review.opendev.org/c/openstack/swift/+/781908 to prevent get_hashes from creating empty partitions... 21:07:49 ...then fairly quickly discovered that the new checks for whether a suffix is valid or not were too strict (at least on py2) 21:08:28 thanks acoles for running that down yesterday and proposing https://review.opendev.org/c/openstack/swift/+/784108 -- it's working its way through the gate now 21:09:09 and if anyone sees a centos7 probe test failure on a patch in the next day or so, that may be why 21:11:14 there are a couple other relinker patches i wanted to call attention too, though: https://review.opendev.org/c/openstack/swift/+/769633 (for fanning out subprocesses to relink disks in parallel) and https://review.opendev.org/c/openstack/swift/+/783731 (to track which partitions were actually updated when relinking and only rehash those ones) 21:11:54 thanks clayg for figuring out a mostly-sane way to mock out fork/wait for the disk parallelization 21:13:18 so, things are moving; no immediate blockers 21:13:25 any questions or comments? 21:14:27 all right -- next up 21:14:33 #topic shrinking and sharding 21:15:17 acoles, i know we recently approved the repair and analyze commands patch, which was at the root of a chain or two 21:15:26 where are we now? 21:16:03 yes the repair command has merged https://review.opendev.org/c/openstack/swift/+/765624 21:16:08 \o/ 21:16:25 thanks mattoliverau and others ´for reviews 21:16:34 nps 21:16:44 there's a couple of follow ups that I need to rebase, will do that tomorrow 21:17:46 sounds good 21:17:48 I'm working through the new WIP extra ACTIVE states POC to see how that pans out for solving the quick shard shrink issue. Working through all the existing tests and want to write some more. 21:17:49 on shrinking...some progress on reporting tombstones https://review.opendev.org/c/openstack/swift/+/782832 but that's still WIIP 21:19:07 i was just about to ask mattoliverau about quick shard/shrinking :-) does it seem like more states are probably the way to go, then? 21:19:19 my WIP is: https://review.opendev.org/c/openstack/swift/+/782903 but I haven't pushed up a new version yet. But will today, to at least get it off my computer. 21:19:32 it is a little cleaner to be honest 21:20:02 because were storing state with more info, which we can encode into timestamp offsets, but states where kinda made for that. 21:20:45 If anyone has any thoughts, better ideas then https://etherpad.opendev.org/p/swift-shrinking-active-age 21:20:57 cool. and acoles, i like the direction with tombstone counting -- it's nice that we get it pretty much "for free" 21:21:03 Or just want more info. I'll make sure that etherpad is updated today 21:21:57 timburke: yep, on that one I need to work through all the plumbing 21:22:43 great. any blockers or discussion points for any of that work? or questions that others have about it? 21:23:56 for anyone who wants to see acoles analyze in action, I have added a --analyze to my hacked up graph viewer script. 21:24:01 https://review.opendev.org/c/openstack/swift/+/775066 21:24:26 which pipes it through the analyze and then draws that patch on the graph in green. 21:25:32 cool. i've been meaning to try that out 21:25:33 mattoliverau: nice! 21:26:05 those are the main topics i had 21:26:09 #topic open discussion 21:26:26 what else should we bring up this week? 21:27:51 i brought the same retry-failed functionality to func tests that we've had for a bit now with unit and probe tests: https://review.opendev.org/c/openstack/swift/+/783091 21:28:29 hopefully that'll further reduce how often we need to recheck, and allow us to merge patches faster/more reliably 21:29:29 great 21:29:31 Nice 21:30:00 I've been doing a bit of recon stuff lately, so have also gone and done this: https://review.opendev.org/c/openstack/swift/+/783997 in the hopes to clean it up a little. 21:31:09 I was tinkering with recon too, wanted to add --sharding. I'm surprised it didin't exist before, because the middleware has the support, just not the CLI. 21:31:10 thanks for the review on that timburke 21:31:52 mattoliverau, happy to! i like the idea; it was probably overdue 21:31:56 zaitcev, good thought! 21:31:59 yeah, I believe I had a patch to plumb through reconstructor somewhere too (from years ago) not sure it ever landed. 21:35:04 seems like we covered most of the things people wanted to talk about 21:36:17 do people generally feel like they get enough value out of this meeting to block off the time every week? i sometimes feel like i'm mostly repeating myself from the week before, and wonder if an every-other-week cadence would be better 21:36:44 We don't have another meeting point aside from IRC, don't we. 21:37:21 So, I had to bring things up in the meeting at times, to the extent of editing the agenda wiki. 21:37:58 which is great! by all means, always feel free to add items to the agenda 21:38:49 timburke: I'm ok with it, but we shouldn't feel we have to fill an hour - if there is nothing new, but it may still be good for people to have chance to touch base 21:39:52 at the same time, its pretty lat ein the evening for me so I'd be happy with a 2 week cadence 21:40:51 well, it's a discussion we can keep thinking about. i bet we'll talk about it again at the ptg, at the latest :-) 21:41:11 but on that note 21:41:16 thank you all for coming, and thank you for working on swift! 21:41:22 #endmeeting