19:00:36 <zara_the_lemur__> #startmeeting storyboard
19:00:36 <SotK> I am fragile and mobile for a while
19:00:37 <openstack> Meeting started Wed Mar  8 19:00:36 2017 UTC and is due to finish in 60 minutes.  The chair is zara_the_lemur__. Information about MeetBot at http://wiki.debian.org/MeetBot.
19:00:38 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
19:00:40 <openstack> The meeting name has been set to 'storyboard'
19:00:57 <zara_the_lemur__> #topic Announcements
19:01:08 <zara_the_lemur__> #topic urgent items
19:01:15 <zara_the_lemur__> None of which I am aware
19:01:21 <zara_the_lemur__> #topic in-progress work
19:01:50 <zara_the_lemur__> I believe we have at least one webclient patch awaiting reviews
19:02:07 <diablo_rojo_phon> I can take a look today.
19:02:14 <zara_the_lemur__> #link https://review.openstack.org/#/c/436702/
19:02:55 <diablo_rojo_phon> Wonderful. Has anyone been able to review the branch handling patch?
19:03:32 <zara_the_lemur__> for
19:03:36 <zara_the_lemur__> #link https://review.openstack.org/#/c/423877/ ?
19:03:54 <zara_the_lemur__> yeah there should be logs for that from the other evening, though it appears to have timed out
19:03:57 * zara_the_lemur__ will recheck
19:04:39 <SotK> is that the non-master branche one or my "good enough for monasca" halfway house?
19:04:40 <zara_the_lemur__> ohhhh, or the revision of
19:04:45 <zara_the_lemur__> #link https://review.openstack.org/#/c/437469/
19:05:07 <zara_the_lemur__> I haven't looked at that one yet
19:05:21 <zara_the_lemur__> btw the story is up here:
19:05:27 <zara_the_lemur__> #link https://storyboard.openstack.org/#!/story/2000876
19:05:36 <zara_the_lemur__> so if yours is good enough for monasca, those tasks should be edited
19:05:38 <diablo_rojo_phon> The non master branch one.
19:06:21 <diablo_rojo_phon> Hopefully we can get SotKs reverified and merged soon.
19:06:33 * SotK hasn't had time, but will make time today to review that
19:07:54 <diablo_rojo_phon> After that's in what else do we have left before Monasca can move?
19:08:26 <SotK> I think just agree a date for the move
19:08:50 <SotK> testing against the production data went fine so I am confident it will be fairly smooth
19:09:32 <zara_the_lemur__> \o/
19:09:36 <diablo_rojo_phon> Cool. I can reach out to them and see if we can pick a date. Maybe for next week?
19:09:47 * diablo_rojo_phon is excited
19:10:42 <zara_the_lemur__> maybe worth setting the time after the patch is reviewed so we know how much work is left on that
19:11:09 <zara_the_lemur__> (and sorry I haven't had time to get to it yet :()
19:11:31 <SotK> wfm, though I will be around early next week
19:11:41 <SotK> erm
19:11:45 <zara_the_lemur__> good to know :P
19:11:53 <diablo_rojo_phon> Will or won't?
19:12:22 <SotK> around less at early times next week
19:12:33 * SotK cannot type on his slow old phone
19:13:24 <diablo_rojo_phon> Ah got it. So a time end of next week? Thursday or Friday would be better then?
19:14:08 <diablo_rojo_phon> I can float the idea even if we don't confirm a day yet.
19:14:19 <SotK> any day works, just later times
19:14:50 <zara_the_lemur__> tues or wed gets my vote
19:14:57 <zara_the_lemur__> since I have meetings then anyway
19:15:28 <diablo_rojo_phon> Ah got it.
19:15:59 <diablo_rojo_phon> I can see if they are interested in doing it during our next meeting if that would work?
19:16:42 * SotK will likely be not around during the meeting next week :(
19:17:22 <zara_the_lemur__> SotK: what time is sufficiently late for you?
19:18:17 <SotK> I'm hoping 2100 but maybe even later
19:18:30 <SotK> we can wait for a different week if that is too late
19:18:33 <diablo_rojo_phon> Okay that works.
19:19:01 * SotK momentarily disappears
19:19:08 <zara_the_lemur__> SotK: (I'm not too fussed, just want to know in advance if it is that late.)
19:19:32 <diablo_rojo_phon> I'll see what day works for them at least that late.
19:20:17 <zara_the_lemur__> should probably switch to discussion
19:20:20 <zara_the_lemur__> well should've done that before
19:20:25 <zara_the_lemur__> #topic Open Discussion
19:21:38 <diablo_rojo_phon> Oh well :)
19:21:51 <diablo_rojo_phon> You're still a better meeting host than I would be.
19:22:14 <zara_the_lemur__> idk, I just change to 'discussion' at some random point in the discussion each week
19:22:35 <zara_the_lemur__> well, the meeting's pretty small so I don't see a reason to be rigid about it
19:22:37 <zara_the_lemur__> is my excuse
19:24:06 <diablo_rojo_phon> Okay so should we take the leftover time to go figure out why SotKs Patch failed to merge?
19:24:19 <diablo_rojo_phon> And review the other patches.
19:24:22 <zara_the_lemur__> I think it's just timeouts
19:24:44 * zara_the_lemur__ is wondering what would be most helpful from me or SotK on your branches patch
19:25:00 <SotK> probably, the migration scripts are entirely untested afaik
19:25:54 * davidlenwell ran those scripts on my test deployment .. there are a large number of network timeouts and slow responses .. but there might not be much that can be done about it.
19:26:19 <zara_the_lemur__> yeah, it's probably just one where we need to recheck until we're lucky
19:26:27 <SotK> the db migrations or the lp migrations?
19:26:28 <zara_the_lemur__> I am a bad example
19:27:23 <SotK> there was some talk around flattening our db migrations at one point
19:28:29 <diablo_rojo_phon> What all would that entail? A lot of effort or minimal?
19:29:19 <SotK> theoretically not much work I think
19:29:31 <SotK> but I havent thought in much detail
19:30:52 <zara_the_lemur__> currently you can't generate a working storyboard db from the code without editing the db-generation script by hand
19:31:15 <zara_the_lemur__> though it didn't take a lot of hand-editing
19:31:35 <diablo_rojo_phon> My knowledge of DB stuff is limited otherwise I'd jump on this.
19:31:35 <zara_the_lemur__> I think the 'story types' table needed to be populated with at least one row
19:31:59 <zara_the_lemur__> because some code expects there to be a thing to match against type id 1 or something
19:32:08 <zara_the_lemur__> (so also that code could be changed)
19:32:26 <zara_the_lemur__> I think it will all be noted in my postgresql wip from a few weeks ago
19:32:56 <zara_the_lemur__> one of them; I seem to have sent two different changes for that somehow...
19:33:41 <zara_the_lemur__> aw, no, it isn't
19:34:33 <zara_the_lemur__> there are irc logs, then
19:34:34 <zara_the_lemur__> somehwere
19:34:36 <zara_the_lemur__> *somewhere
19:35:53 * SotK wonders if we need story_types
19:36:14 <zara_the_lemur__> I'm not convinced we do.
19:36:31 <SotK> certainly our current implementation of story permissions doesn't need it
19:37:08 <SotK> but there is interesting problems wrt auto-adding the vmt to security issues that it may help solve
19:37:14 <SotK> s/is/are/
19:37:45 <persia> What is the expected total enumeration of types?
19:38:12 <persia> Just security/normal?
19:38:41 <SotK> perhaps, I haven't given this much thought either
19:39:05 <SotK> those are the only two which spring to mind, which doesn't really need a separate table
19:39:35 <persia> I usually argue against types because people want to look at feature/bug, but I would argue in favour of certain enumeration.
19:39:53 <zara_the_lemur__> the current list that storyboard has is 'bug', 'feature', 'private_vulnerability', 'public_vulnerability'
19:40:13 <zara_the_lemur__> which I don't think gives us much
19:40:34 <persia> No.
19:40:40 <zara_the_lemur__> especially given that a story can be of only one type and those types don't exclude each other
19:40:42 <SotK> especially as we don't use it
19:41:17 <zara_the_lemur__> :)
19:41:17 <SotK> we certainly don't need bug/feature
19:41:23 <zara_the_lemur__> indeed
19:41:40 <SotK> and the private/public vulnerability thing is aiming for the launchpad model directly I think
19:41:56 <persia> #agreed bug/feature is user opinion not core story data
19:42:04 <davidlenwell> it surprises me how many people get hung up on not having the distinction between bug/feature
19:42:19 <zara_the_lemur__> and you can convey 'vulnerability' with tags or similar, and  public/private elsewhere
19:42:36 <zara_the_lemur__> my guess is that it can govern who foots the bill?
19:43:04 <davidlenwell> at ptg someone literally said to me "I'd like storyboard but not being to easily filter between bugs / features is a problem"
19:43:14 <persia> Yes, who pays.  Less meaningful in collaborative spaces.
19:43:32 <SotK> I agree, though I feel like it could be argued that "security-related" deserves to be a "story type" or similar
19:44:03 <zara_the_lemur__> I can see the 'if it's a feature request, it's extending the scope of a project from agreed terms, vs if it's a bug, someone didn't meet the terms agreed
19:44:06 <zara_the_lemur__> '
19:44:10 <SotK> it certainly would give us an easier way of programmatically identifying vulnerability stories without hardcoding a tag name
19:44:45 <persia> SotK: I think a hardcore type flag is better than a hardcore tag for that.
19:44:54 <persia> Hardcoded
19:44:59 <zara_the_lemur__> best autocorrect
19:45:01 <SotK> I agree wholeheartedly
19:45:20 <zara_the_lemur__> I am concerned that'll suffer from feature-creep
19:45:34 <zara_the_lemur__> but we already have types
19:45:43 <zara_the_lemur__> so it'd simplify what we already have support for
19:45:52 <SotK> fsvo support :P
19:45:55 <SotK> but yes
19:46:33 * SotK considers having it in a table now is useful in case other actual story types become clear, but I don't know that that is real value without more thought
19:46:51 <zara_the_lemur__> heh
19:47:16 <persia> Just need to take care to semantically distinguish objective types from subjective types.
19:47:24 <zara_the_lemur__> I'd rather tags since people will probably get sad if they can't filter on them in all the ways they can on tags, but it's not a strong preference since anything is better than what we have atm.
19:47:52 <zara_the_lemur__> just be prepared for 'I want a worklist containing only things of this story type' etc
19:48:02 <SotK> we can just implement filtering for the type flag
19:48:19 <SotK> tags is asking for a whole world of complication ime
19:48:50 <zara_the_lemur__> what about it seems complicated ooi?
19:49:04 <persia> Yes.  Tags is bad for deep automation.  Excellent for user automation, but that does not fit VMT needs.
19:49:14 <SotK> what persia said
19:50:03 <SotK> namely, we'd have to say 'you need to add a "vulnerability" tag to your story after you make it to file a security bug'
19:50:30 <zara_the_lemur__> oh, on the submission side, yes
19:50:36 <SotK> and then the added tag would need to be exactly "vulnerability" because it would be hardcoded as our "security issue" tag in the API
19:50:46 <zara_the_lemur__> I was picturing a checkbox that would apply a tag sneakily.
19:51:00 <zara_the_lemur__> but then you lose the reusability of components
19:51:02 <SotK> such a checkbox may as well just set a flag
19:51:05 <zara_the_lemur__> yes
19:51:19 <SotK> and this way someone is probably less likely to remove the tag accidentally
19:51:23 * persia was thinking a checkbox for a binary flag representation.
19:51:29 * SotK too
19:51:57 <diablo_rojo_phon> Sounds pretty unanimous
19:53:11 * SotK thinks we don't want the story_types table
19:53:41 <zara_the_lemur__> hah, I was gonna say I suspect all stories are type '1' currently, so if we don't want to change them, make that the value for 'non-vulnerability', and get rid of the other rows
19:54:32 <SotK> that settles it, all stories are bugs :D
19:55:26 <SotK> but yeah, I can't see any real value in that table over flags for things we think are objectively "types" and tags for opinions
19:56:17 <zara_the_lemur__> sure, I'm not sure how much of the code will need rewriting without it
19:56:19 <zara_the_lemur__> hopefully not much
19:57:15 <diablo_rojo_phon> Making decisions always feels like progress even if it means doing more work :)
19:57:39 <zara_the_lemur__> oh and it's used by can_mutate which we also don't use afaik
19:57:44 <zara_the_lemur__> so maybe some spring cleaning round there
19:58:48 <zara_the_lemur__> oh, we're at the end
19:59:05 <zara_the_lemur__> well there's a fluffy yak to shave anyway
19:59:15 <zara_the_lemur__> #endmeeting