14:01:29 <tellesnobrega> #startmeeting sahara
14:01:30 <openstack> Meeting started Thu Dec 13 14:01:29 2018 UTC and is due to finish in 60 minutes.  The chair is tellesnobrega. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:01:31 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:01:33 <openstack> The meeting name has been set to 'sahara'
14:01:59 <tosky> hi
14:03:11 <tellesnobrega> hi
14:03:21 <tellesnobrega> is jeremy around?
14:03:52 <tellesnobrega> maybe not
14:03:57 <tellesnobrega> lets start
14:04:05 <tellesnobrega> #topic News/Updates
14:04:38 <jeremyfreudberg> o/
14:04:43 <tellesnobrega> hey jeremyfreudberg
14:05:03 <tellesnobrega> I'm mainly working on APIv2 stuff, documentation and 500 issue
14:05:12 <tellesnobrega> we can talk more about them later
14:06:52 <tellesnobrega> tosky, jeremyfreudberg news from you?
14:07:07 <tosky> I reviewed the patch which fixes ambari image generation on ubuntu (still some issues)
14:07:30 <tosky> sent the email about the split of the repositories to openstack-discuss@ (sorry for messing up the subject)
14:08:11 <tosky> worked for a (unrelated) presentation on RBAC in openstack, but that's the reason for that WIP review which adds some RBAC tests to Sahara
14:09:18 <tosky> and in general I should work on the code for https://review.openstack.org/#/c/622492/ , if accepted
14:09:27 <tosky> and that's it
14:10:58 <tellesnobrega> jeremyfreudberg?
14:12:02 <jeremyfreudberg> nothing new really, but the semester is over after mid-next-week
14:12:11 <tellesnobrega> nice
14:12:55 <tellesnobrega> will you be able to take some time to work on some apiv2 them?
14:13:07 <jeremyfreudberg> yes, that's the idea
14:13:13 <jeremyfreudberg> that's my priority for sure
14:13:16 <tellesnobrega> awesome
14:14:25 <tellesnobrega> moving on
14:14:53 <tellesnobrega> #topic APIv2
14:15:07 <tellesnobrega> I'm currently working on 2 issues
14:15:25 <tellesnobrega> the 500 case and the documentation
14:15:33 <tellesnobrega> lets start with the 500 case
14:16:12 <tellesnobrega> I talked with tosky and we decided to make the change happen only on APIv2
14:17:03 <jeremyfreudberg> apiv2 only makes sense to me too
14:17:36 <tellesnobrega> what I'm trying to make it work right now is a decorator that will get the command and check in a dictionary if the params passed are on the whitelist
14:18:35 <tellesnobrega> does that seems ok to you?
14:19:59 <jeremyfreudberg> well, i think this was something that i at least partially suggested on the review, so, yes, it sounds good :)
14:20:03 <jeremyfreudberg> tosky?
14:20:34 <tellesnobrega> jeremyfreudberg, yes it is :)
14:20:58 <tosky> ehm, that's one the reviews that I really didn't check
14:22:43 <tellesnobrega> it would be good if both could take a look, I'm hitting some weird errors on tempest (the change is only on APIv2 and tempest runs against api v1 and it is failing)
14:22:57 <tellesnobrega> also scenarios I couldn't find the errors, if anyone can give me a hand with that
14:23:24 <tosky> the first question is: are you sure that the change is v2 only? :)
14:23:37 <jeremyfreudberg> in any case, the solution is, in theory, elegant: it's the most straightforward way to encapsulate that different API view functions have different allowed query string values
14:23:39 <tosky> iirc some of the v2 code used v1, or the other way, or some common code
14:23:48 <jeremyfreudberg> tosky, good question
14:24:30 <tellesnobrega> tosky, it should be at this point, but I will check
14:25:30 <tosky> tellesnobrega: check the logs of sahara-api
14:25:32 <jeremyfreudberg> tellesnobrega: did you find out where these things are coming from: https://review.openstack.org/#/c/623300/9/sahara/utils/api.py
14:25:40 <tosky> it's definitely going through apiv2 code
14:25:51 <jeremyfreudberg> (my question is unrelated to tosky's question)
14:26:00 <tosky> http://logs.openstack.org/00/623300/9/check/sahara-tests-tempest/94d7ad0/controller/logs/apache/sahara-api_log.txt.gz#_2018-12-12_21_41_49_395831
14:26:41 <tellesnobrega> jeremyfreudberg, I cleaned up it a lot now, I'll test and see if it is better
14:27:11 <tellesnobrega> jeremyfreudberg, it looks more like this now https://review.openstack.org/#/c/623300/9/sahara/service/validation.py
14:27:20 <tellesnobrega> a lot less params
14:27:38 <jeremyfreudberg> tellesnobrega: great, cool
14:27:47 <tellesnobrega> the ones I kept are search_opts passed on the client that it uses to create the query
14:27:54 <tellesnobrega> tosky, thanks, I will fix that
14:30:22 <tellesnobrega> that is all I have on apiv2
14:30:40 <tellesnobrega> hopefully jeremyfreudberg will have time to work on microversioning
14:31:42 <tellesnobrega> any topics you want to cover?
14:32:13 <tosky> an update on plugin split
14:32:39 <tellesnobrega> sure
14:32:43 <tellesnobrega> #topic Split Plugin
14:33:15 <tosky> I sent the email to openstack-discuss@; we had one reaction so far with some feedback which should be implemented (description for plugins)
14:33:58 <tosky> apart from that, the codebase seems to be fine, according my previous tests, so I'd be leaning towards merging the pending patches, rebasing, and try to push the split as soon as possible
14:34:13 <tosky> and fix the breakages when they shows
14:34:34 <tosky> at least a puppet core wrote that he can help when I nagged him earlier today
14:34:46 <tosky> the openstack-ansible part is something that I can help fixing too
14:35:10 <tosky> if anyone else has any comment on the way the split is done, this is the right time :)
14:35:31 <tellesnobrega> it looks like the right path
14:37:36 <tosky> nothing else from my side about the splitting
14:37:51 <tellesnobrega> jeremyfreudberg?
14:39:49 <jeremyfreudberg> not right now
14:40:15 <tellesnobrega> anything else?
14:40:59 <tosky> not on this topic, just a plea to recheck few pending reviews with +2 (I think that tellesnobrega already ninja-approved everything that he could, so it's on jeremyfreudberg now :)
14:41:17 <jeremyfreudberg> yes, i'll give some things a look
14:41:31 <tellesnobrega> I did but didn't want to force approve important stuff
14:42:05 <tellesnobrega> jeremyfreudberg, if you have time today or tomorrow to review would be great so we can merge most of the stuff and we can move on with the split sequece
14:42:08 <tellesnobrega> sequence
14:43:02 <jeremyfreudberg> yup
14:43:15 <tellesnobrega> thanks
14:43:55 <tellesnobrega> I guess we can close it early today
14:45:55 <tellesnobrega> thanks jeremyfreudberg and tosky
14:46:06 <tellesnobrega> lets keep up the good work
14:46:11 <tellesnobrega> see you all next week
14:46:34 <tosky> see you!
14:46:36 <tellesnobrega> #endmeeting