13:02:18 #startmeeting rpm_packaging 13:02:19 Meeting started Thu Mar 9 13:02:18 2017 UTC and is due to finish in 60 minutes. The chair is toabctl. Information about MeetBot at http://wiki.debian.org/MeetBot. 13:02:20 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 13:02:22 The meeting name has been set to 'rpm_packaging' 13:02:34 ping toabctl, dirk, apevec, aplanas, IgorYozhikov, jpena, jruzicka, number80, kaslcrof 13:02:47 o/ 13:02:56 o/ 13:02:58 #chair IgorYozhikov jpena number80 dirk 13:02:59 Current chairs: IgorYozhikov dirk jpena number80 toabctl 13:03:01 o/ 13:03:02 o/ 13:03:33 please add you points to the agenda: https://etherpad.openstack.org/p/openstack-rpm-packaging 13:03:41 let's adjust ^^^ 13:03:48 :) 13:03:49 might disapear so just go ahead without me... 13:03:58 ok 13:06:34 ... and let's start then 13:06:44 #topic https://review.openstack.org/#/q/status:open+project:openstack/rpm-packaging+branch:master+topic:monasca-rpm - usage of additional variables instead of sourceX 13:06:56 hello 13:07:14 witek, please continue 13:07:26 I wanted to discuss the usage of variables for SourceX 13:07:38 it has two advantages: 13:07:47 * better readability 13:08:04 %{buildroot}%{api_conf_dir}/%{api_conf} 13:08:09 instead of 13:08:23 %{buildroot}%{SourceX}%{SourceY} 13:08:52 * the variable values are sed'ed in templates 13:10:16 what do you think about this approach? 13:10:27 * IgorYozhikov suggested to use common approach like %{_sysconfdir}/monasca/%{SourceX} as used for rest projects just to do things in similar way. 13:11:38 OK, I'm fine with it, common coding style is important 13:11:47 I agree w/ IgorYozhikov 13:11:51 Personally, I think using sed to subsitute variable names around is cumbersome, and leads to a more complex spec 13:11:56 and it is required to clarify - are we good with such approach and what is written in packaging policy/rules 13:12:33 +1 for trying to be consistent 13:14:08 can you point me to 'packaging policy/rules' please? 13:14:13 number80, is there any documented stuff for such cases in fedora packaging rules? 13:17:07 Yes 13:17:21 fedoraproject.org/wiki/Packaging/Guidelines 13:17:38 SUSE: https://en.opensuse.org/openSUSE:Packaging_guidelines 13:18:08 I found https://fedoraproject.org/wiki/Packaging:RPM_Source_Dir 13:18:24 where all sources set as files not vars 13:18:36 witek, you can also just look into the other spec.j2 templates and follow what we do there. 13:19:30 thanks for the references 13:20:18 are you OK with using sed to substitute the variable values? 13:20:20 witek, as I saw, you use sed for configuration files update right? 13:20:28 correct 13:20:43 might be crudini could help here? 13:21:29 not sure that my suggestion is the best but for ini like files it should work 13:21:34 witek, we are not doing that in other spec.j2 templates 13:21:53 I would like to be consistent 13:23:29 I haven't found crudini usage in openstack/rpm-packaging 13:24:19 also you are modifying files you are already uploaded within commit, so might be better to upload already prepared files in such case ans do not update them during build step 13:24:27 just suggesting 13:24:41 s/ans/and/ 13:25:05 let's try to avoid crudini 13:25:31 witek, I suggesting crudini as one of tools which could be used for modification of ini like files 13:25:36 ah, ok 13:25:51 I would just do what we already do in keystone 13:26:34 and if we decide that we need to support eg a username switch in the .spec we can fix it in all other places. let's try to keep it simple and consistent for now. 13:26:36 toabctl, are you suggesting to upload already modified files and do not update them during build if those files are not part of source code? 13:26:38 my 2 cents :) 13:27:04 IgorYozhikov I'm suggesting to follow what we already have. 13:27:11 ok 13:28:09 so, the rest changes should be provided by cm system, right? 13:28:23 I'm about config files update 13:29:36 ok, thank you for the comments, we'll update the changes 13:29:49 and we'll be happy about reviews :) 13:30:17 witek, u r welcome :) 13:30:30 anything else related to this topic? 13:31:20 I'm not sure we understand Haikels comment here: 13:31:22 https://review.openstack.org/#/c/433030/37/openstack/monasca-notification/monasca-notification.spec.j2@28 13:32:50 number80, ^^^ 13:33:43 I do not see any provides/obsoletes? 13:34:18 witek: if you rename a package, it has to provides/obsoletes old package name 13:34:25 if you don't, you'll break updates 13:35:08 python-monasca-notifications won't be replaced by openstack-xxxx and it will conflicts since they ship the same stuff 13:35:09 we're not renaming really, just moving to the subpackage 13:35:58 okie 13:36:04 lemme look 13:36:17 ok, thanks 13:37:21 #topic python3 - feedback to singlespec macros 13:39:02 * IgorYozhikov took a look privately -I'm more || less fine, but unfortunately still didn't have enough time for hands on experience. 13:39:12 It's on my TODO list 13:41:13 any feedback about single spec from RDO side? 13:45:34 #topic packages reviews (https://review.openstack.org/#/q/project:openstack/rpm-packaging+status:open ) 13:45:48 I want to discuss my update for nova 13:46:02 how to be with pacement-api 13:46:18 https://review.openstack.org/#/c/425673/ 13:46:33 and suse tests failures 13:46:57 1. about placement-api 13:47:17 I created wsgi config and put it in package 13:48:22 question here - do I need to create a separate systemd unit for it or leave as is under wsgi 13:48:44 I'd leave it under wsgi, it seems to be the recommended setup 13:49:05 yes, I did that according to setup.cfg 13:50:53 ok, and what is about failed tests in SUSE CI - https://build.opensuse.org/package/live_build_log/home:suse-cloud-ci:rpm-packaging-sles12-Master-d6540599133dd567765834b65c02ee2915c63983/openstack-nova/standard/x86_64 13:51:04 toabctl, could you help with ^^^^^ 13:51:29 IgorYozhikov, fix is on it's way. newer pbr needed 13:51:36 aplanas is working on it 13:51:44 ah, cool thanx 13:52:06 so, moving forward then 13:52:43 jpena, according to neutron deps, OVS and Co is on the way. 13:52:56 nice 13:53:00 I found issues with job configs 13:53:33 some of jobs were using 7.2 snapshots and this is fixing right now by our infra team 13:54:28 anything else we need to discus here? 13:54:40 we have 5 min 13:58:50 open floor || finishing meeting? 13:59:11 yep 13:59:49 #endmeeting