14:02:03 #startmeeting Rally 14:02:04 Meeting started Mon Feb 22 14:02:03 2016 UTC and is due to finish in 60 minutes. The chair is andreykurilin. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:02:05 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:02:07 The meeting name has been set to 'rally' 14:02:30 #link https://wiki.openstack.org/wiki/Meetings/Rally#Agenda 14:02:35 o/ 14:02:36 o/ 14:03:01 \o 14:03:42 boris-42 will join us a little bit later, so let's start without him :) 14:04:41 stpierre, rvasilets : ping 14:04:47 i'm here 14:05:01 nice 14:05:47 stpierre: if you do not mind we will skip your first item from agenda for 10-20 minutes, so boris-42 will be able to take part on discussion 14:05:58 sure, i was going to suggest that myself :) 14:06:01 :) 14:06:11 #topic [andreykurilin] plugins based on entry-points 14:06:43 I have an idea how to move our plugins to separate repository 14:06:49 with own requirements list 14:07:01 proof-of-concept https://review.openstack.org/#/c/282381/ 14:07:10 It bases on entry-points 14:07:29 Such way is used by novaclient's extensions 14:07:45 It doesn't require a lot of changes in Rally-side 14:08:00 just something like https://review.openstack.org/#/c/282381/5/rally/common/plugin/discover.py 14:08:16 folks, what do you think about such type of plugins? 14:09:08 would we need one git repo per set of plugins? (e.g., the openstack plugins would be in one repo, the common plugins in another, etc.?) 14:09:36 stpierre: andreykurilin ok I am ehere 14:09:38 I suppose it will be one repo for all openstack plugins 14:09:40 i'm not quite familiar enough with the entry_points magic in setup.cfg -- would we only get to specify one "opts" entry point per repo? 14:10:02 andreykurilin: I like the idea very much, but I haven't review this patch yet :( 14:10:38 stpierre: plugin package should contains only 2-3 lines - https://github.com/andreykurilin/rally_vm_plugins/blob/master/setup.cfg#L26-L28 14:10:41 stpierre: so basically the idea is to make it simple to keep plugins with some specific requriemnents in separated repo 14:10:47 so we'd need a 'rally-plugins-openstack' repo and a 'rally-plugins-common' repo and, whenever someone starts using rally for something else, a 'rally-plugins-foobaz' repo? 14:11:00 stpierre: so users can do pip istanll rally (and it won't need bunch of system packages) 14:11:07 yeah, i understand the goal 14:11:11 stpierre: after that he can run pip isntall rally-openstack-plugins 14:11:15 stpierre: and magic everything works 14:11:21 stpierre: I suppose we will keep comman stuff at the main repo 14:11:21 stpierre: he has plugins for openstack 14:11:28 andreykurilin: yep 14:11:30 *common 14:11:47 andreykurilin: core stuff like runners, slas, some context, maybe generalized cleanup mechanims should stay in repo 14:11:52 so would we need a 'rally-plugins-openstack' repo and a 'rally-plugins-common' repo and, whenever someone starts using rally for something else, a 'rally-plugins-foobaz' repo? 14:12:03 stpierre: nope 14:12:16 okay, so we could specify multiple separate entry points for plugins and opts in the setup.cfg? 14:12:16 stpierre: everything that is common goes into rally 14:12:18 rally-plugins-commin will be part of rally repo 14:12:30 so would we need rally-plugins-openstack and rally-plugins-foobaz and so on? 14:12:33 all in separate repos? 14:12:34 stpierre: so andreykurilin knows how not to do that 14:12:50 stpierre: yep everything should go in seprated repo 14:12:54 and, similarly: would we only get *one* opts module per repo? the openstack plugins are *big*, with lots of options, and that's a big ugly hard-to-maintain module full of options. 14:13:18 stpierre: so as far as I understand we don't need to touch setup.cfg 14:13:24 andreykurilin: ^ am I right? 14:13:30 i'm not explaining myself well 14:13:37 stpierre: we need to touch setup.cfg in plugin repo 14:13:47 https://github.com/andreykurilin/rally_vm_plugins/blob/master/setup.cfg#L26-L28 lists a single 'opts' entry point with all of the options for the vm plugins 14:13:52 that's okay, because there aren't many 14:13:59 but there are *tons* of options for all of the openstack plugins 14:14:08 will we need to squash them all into a single module? 14:14:14 or can we specify multiple opts entry points? 14:14:16 stpierre: so we need to get rid of that stuff 14:14:19 there's a code maintainability issue here 14:14:21 stpierre: no 14:14:22 stpierre: in that way 14:14:23 ok 14:14:40 andreykurilin: stpierre as far as I understand each repo has own conf file? 14:14:49 I suppose single entry point for opt is required only for sample config generation 14:14:56 boris-42: no 14:15:45 this looks and sounds promising, but i'd like to see a much bigger POC. keeping it small shows off the easy parts, but it could be hiding issues that will crop up once we try to cram all bazillionty openstack plugins into it 14:16:18 stpierre: yep yep 14:16:23 stpierre: we are not hurry up with this 14:16:51 stpierre: we are working very slowly =) we moved all plugins under common base and split framework and plugins 14:16:54 stpierre: I can try to move all openstack-plugins to separate repo(without tests :) ) 14:17:03 stpierre: now we have 2 more problems how to make autodiscovering of plugins 14:17:15 stpierre: and what to do with conf options 14:17:40 stpierre: as well there are few more changes in our framework that I would like to do before split 14:17:50 stpierre: it's rally.task.types and rally.task.validation 14:17:50 boris-42: we can make config file per plugin-package, but it looks like not a good idea 14:18:11 andreykurilin: keeping conf options iniside rally is even worse idea 14:18:15 andreykurilin: any other ideas? 14:18:18 ok 14:18:46 andreykurilin: I mean we will keep 200 options that are not related to rally code at all and that are not used iniside it 14:18:49 so we can have a separate config files. It sounds like easy-stuff 14:19:03 *have separate 14:19:48 I'll modify my change to support multiconfigs 14:19:59 any other questions? 14:20:02 andreykurilin stpierre or we can try to remove oslo.config from plugins 14:20:17 hm... 14:20:18 no) 14:20:45 andreykurilin: ok then we have only one choice to split conf files 14:20:56 boris-42: I suppose we need to use the same base libraries across all plugins 14:21:40 andreykurilin: I was thinking about removing configuration at all in that way 14:21:45 :) 14:21:57 andreykurilin: okay we can move to the next topic 14:22:02 nice 14:22:13 [stpierre] 0.3.0 release was buggy; need more transparency, possibly branching/change freeze to protect soon-to-be-released code 14:22:20 #topic [stpierre] 0.3.0 release was buggy; need more transparency, possibly branching/change freeze to protect soon-to-be-released code 14:22:24 stpierre: ^ yep ti was very bad release 14:22:28 yeah 14:22:34 and i have a few questions about the release process 14:22:38 1. how is the release process initiated and communicated? i had no idea we were close to 0.3.0, and i would have reviewed things differently if i had (e.g., "this looks great, we'll merge it after the release") 14:22:44 2. why was there no official change freeze to prep and stabilize the release? 14:22:49 3. do we need a git branching strategy to protect releases? e.g., a few weeks before a release we fork the 0.3.0-prerelease branch and put it into change freeze. that way we can continue to work on master, but we don't merge a bunch of half-tested stuff right before release 14:22:56 14:23:01 a lot of questions:) 14:23:24 what about small release-cycles? 14:23:30 so 14:23:47 1. I am trying to cut releases asap so people will get new functionallity sunner 14:23:52 sooner 14:24:32 2. You should always put +2 on patches if you are ready limitedly to use it in your prod 14:24:50 2. I don't like feature freezes (it's better to have better CI) 14:24:59 and not merge bad code in master 14:25:09 obviously that didn't work this time :) 14:25:25 stpierre: so something changed 14:25:37 stpierre: usually I was more involved in Rally, however I had some interal work to do 14:25:43 "pre-release branches" sounds good 14:25:53 but rally can't depend on you -- that's an antipattern no matter your release schedule 14:25:58 stpierre: plus this thing was not covered by our gates wich is bad 14:26:00 release-candidate 14:26:05 yeah, several things weren't 14:26:13 stpierre: yep but second release was ok =) 14:26:31 boris-42: noone cares about bug-fixes now :( so pre-release branch with one week ff is not a bad idea. Even more - I like it:) 14:26:31 so if we're dedicated to the idea of small, frequent releases (which is good IMO), how can we gain more confidence in our testing so we don't repeat the 0.3.0 fiasco? 14:26:32 stpierre: so that thing was not tested in gates and it is still not tested 14:27:04 i support boris-42 in that we'd better have a better CI than a defined release process 14:27:08 stpierre: that is old missing in gates stuff 14:27:10 +1 to stpierre 14:27:16 i'm aware of at least four bugs covering at least three bits of functionality, so it's not just one thing 14:27:30 stpierre: it was all related to the same problem 14:27:34 no, it wasn't 14:27:42 lemme find one of the other bugs 14:27:59 stpierre: in any case I don't like Feature freeze it is really useless 14:28:06 andreykurilin: ^ 14:28:12 that's fine, but then my last question stands 14:28:16 what we should care is work more on CI/tests 14:28:26 and not merge bad code=( 14:28:28 boris-42: https://bugs.launchpad.net/rally the number of opened bugs is not reduced for a long time 14:28:32 i support boris-42 in that we'd better have a better CI than a defined release proces +1 14:28:47 here's one of the other bugs that got into 0.3.0: https://review.openstack.org/#/c/281437/ 14:28:53 unrelated to the keystone v3 stuff 14:29:17 and even within the keystone authn changes, that broke several different use cases, any of which *could* break independently of the others, and none of which were tested in gates 14:29:27 +1 for better CI, but it can't fix everything in short time. 14:29:29 so a single release revealed a bunch of gaps in our coverage 14:29:31 in fact it would be great to have a dedicated QA activities, yet I'm not sure that there is a good sample ofsuch in any OpenSource project 14:30:08 and just saying "we need better CI" i think glosses over the scope of the issue here -- we're depending on our CI absolutely, but it clearly misses enough that we should be very concerned about our quality 14:30:20 what got broken in keystone? 14:30:27 stpierre: +1 14:30:34 breton: no worries it's rally=) 14:30:48 breton: wrong usga of keystoneclient 14:30:52 *usage 14:31:01 stpierre: so about that issue with kesytone testing 14:31:08 stpierre: we have long long running work on that 14:31:22 stpierre: however it didn't finished 14:31:56 let me ask this a different way: what is our plan to improve release quality? where is it documented? what is its timeline? and how will it be measured? 14:32:42 +1 for page with release scheduling 14:33:19 +1 for short releases(2-4 weeks), so users will be able to get latest features quicker 14:33:26 stpierre: so until we improve gates and cover all the ways of atunetication of keystone we will face this issue 14:33:36 +1 for 2-5 days ff, before release 14:33:44 stpierre: nobody is able to test 300 plugins in 10 different envs 14:33:48 stpierre: by hands 14:34:02 stpierre: so my proposal is to restore redixin patch 14:34:18 which patch? 14:34:24 stpierre: that allows us to test this (like run many tasks in single dsvm job) with different rally deployment 14:34:32 stpierre: let me find it 14:34:36 stpierre: it's very old 14:34:42 that seems like a specific solution to a general problem 14:34:51 stpierre: https://review.openstack.org/#/c/163785/ 14:35:11 #link https://review.openstack.org/#/c/163785/ 14:35:13 stpierre: so we have a lot of places where we don't test everything and we can 14:35:29 stpierre: especially with new functioanllity like multi API version supports 14:35:56 stpierre: however i don't believe in feature freeze in our case, and I do believe that we need to sit down and start fixing bugs, until we get <30 open bugs 14:36:10 so i guess i'm surmising that our plan to improve release quality is to just continue trying to increase CI coverage, but there's no documentation, timeline, or measureables? 14:36:10 stpierre: plus yep we can make release model more transparent 14:36:28 stpierre: documentation and timeline should be done 14:36:35 stpierre: I was trying few time to introcude this 14:36:37 boris-42: but we need to start fixing bugs sometimes... 14:36:51 andreykurilin: nope we don't need to start 14:36:56 andreykurilin: we need to fix them and always 14:37:08 andreykurilin: no matter is it begging of release or end of release or something else 14:37:24 but most of developers just introduce new features and new bugs:) 14:37:26 stpierre: so lets' just set releases each 3 weeks 14:37:37 stpierre: and we will merge them no matter what 14:37:45 cut them* 14:37:51 sounds good. having a known schedule will be helpful 14:38:05 stpierre: okay and it will be quite simple and not depend on feature set that we have 14:38:26 stpierre: because I failed to do that when we have short term releases 14:39:04 stpierre: I am probably going to update this page https://docs.google.com/spreadsheets/d/16DXpfbqvlzMFaqaXAcJsBzzpowb_XpymaK2aFY2gA2g/edit#gid=1993147046 14:41:29 let's move to the next topic? 14:41:40 andreykurilin: aure 14:42:01 #topic [andreykurilin] Using *.openstack.org URLs - https://review.openstack.org/#/c/282646 14:42:36 AJaeger proposed a change for changing links for docs(from readthedocs to docs.openstack.org) and for git repo 14:42:46 #link http://docs.openstack.org/developer/rally/ 14:42:55 #link https://git.openstack.org/cgit/openstack/rally 14:43:16 so I like more read the docs theme lol 14:43:23 yeah... 14:43:38 but docs.openstack.org can be configured too 14:44:10 also, each new merged patch updates it 14:44:31 docs looks good for me but github UI is better than git.penstack.org 14:44:43 while readthedocs should be updated manually(or we should write own job for it) 14:45:20 I don't like this change at all 14:45:22 andreykurilin: lol 14:45:25 amaretskiy: but github is just a mirror for git.openstack.org. Also, if infra-scripts will be broken, github will be not updated 14:45:44 github and readthedocs is more cute 14:46:19 we can use git.openstack.org and additional link to github beside 14:46:24 yep, and they are both more trueЪ 14:46:26 what about proposing both openstack git and github 14:46:32 :) 14:46:44 andreykurilin: +1 14:46:55 andreykurilin: proposing? 14:47:40 ikhudoshyn: write something like "Git repo: git.openstack.org or it's github mirror: github" 14:47:43 in the docs 14:47:58 ic 14:48:49 as for github vs git.os it's not a big deal for me -- we could give a link to the latter but use the former 14:49:03 ok 14:49:22 offtopic stpierre: I updated release page 14:49:30 it looks like there is no disagreements. what about docs.openstack.org ?) 14:49:31 stpierre: so now it's clear when to expect new release 14:49:32 but it's more about politics, I think 14:49:39 boris-42: thanks 14:49:49 stpierre: however we need to fix CI =) 14:49:59 if we're to split from OS, why we'd use these resources) 14:50:01 stpierre: othewise just clear release schedule won't help us 14:50:40 as for docs -- we're kinda have to eat our own dog food 14:50:58 :) 14:51:04 let's move to the last topic 14:51:22 stpierre: your turn, again:) 14:51:30 #topic [stpierre] keystone v3 support 14:51:31 if we move (officially) to docs.os we'd make sure our docs look pretty there with that theme (which I agree, is uglier than readthedocs) 14:51:41 uh that one is pain 14:51:56 ikhudishyn: agreed 14:51:56 stpierre: so did you see document with rally brainstorm 14:52:00 yes 14:52:19 stpierre: so the idea is that services utils refactoring should help us a lot with that 14:52:22 the lack of keystone v3 is really starting to hurt us. one of the patches i linked is just the second attempt at doing keystone auth properly; the other is much bigger. just want some eyes on both 14:52:25 stpierre: especially with atomic actions 14:53:12 stpierre: what patches ? 14:53:23 that's great, but the services refactoring spec still hasn't been updated in six months, and we can't realistically wait for it to get updated, iterated on, approved, and then work started. i think julian's approach represents a good forward-looking middle ground that doesn't abuse wrappers too much, and it's something we can work on merging soon 14:53:27 #link https://review.openstack.org/#/c/282918 14:53:34 #link https://review.openstack.org/#/c/277225 14:53:36 thanks 14:53:37 boris-42 ^ 14:53:58 so, imo, we need to be careful with them:) 14:54:02 stpierre: so basically I am going to update it very soon=) 14:54:05 the second one there has already had several people look at it (thanks!) 14:54:14 stpierre: maybe even tomorrow 14:54:18 stpierre: today* 14:54:23 boris-42: that's the third time you've said that in the past six weeks :P 14:54:25 stpierre: after next my meeting 14:54:33 stpierre: so but we did brainstorm 14:54:41 stpierre: and now it's really clear what to do 14:54:44 but updated != merged, and i suspect it'll take a while before that happens 14:54:48 stpierre: I just need to copy paste that text in spec 14:54:50 stpierre: :D 14:55:01 stpierre: so if you are ok with that approach 14:55:14 stpierre: that is described in doc then it will be merged soon 14:55:58 stpierre: so I will upload and wait for your vote 14:56:05 stpierre: I will upload it in 2 hours from now 14:56:18 i still don't think that's really reasonable. i'm not optimistic that "merged soon" will happen any time in the next week or two, and there's still a bunch of refactoring that we'll need to depend on before we can completely refactor julian's patch 14:56:44 at times rally errs too much on the side of "do it right" over "do it", and this is becoming a pain point for us :/ 14:57:09 +1 to stpierre 14:57:18 fully agreed 14:57:21 stpierre: andreykurilin so guys you won't stable releases or features?) 14:57:26 want* 14:57:49 even if we are trying to merge everything slow and doing it right we are getting bugs and broken releases 14:58:01 boris-42: you said that we will have a good CI in near future. lol 14:58:04 I am personally ok with manual testing Julien patch 14:58:20 and checking that it work in background working on CI 14:58:22 stpierre: ^ 14:58:31 ok, that's great 14:58:39 i fully acknowledge that we need to refactor 14:58:45 i just don't think we should block other work on refactoring 14:59:59 stpierre: let's get merged today/tomorrow spec 15:00:10 stpierre: that will be good balance between do it and do it right 15:00:14 boris-42: previously, we did stable work quicker... 15:00:18 ;( 15:01:24 andreykurilin: so previously I was younger lol 15:01:28 :D 15:01:39 you need to increase a number in you nickname 15:01:41 lol 15:01:57 folks, we don't have more time for a meeting today 15:02:05 thanks everyone 15:02:16 #endmeeting