17:02:24 <msdubov_> #startmeeting rally
17:02:25 <openstack> Meeting started Tue Sep 16 17:02:24 2014 UTC and is due to finish in 60 minutes.  The chair is msdubov_. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:02:26 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:02:29 <openstack> The meeting name has been set to 'rally'
17:03:14 <k4n0> Hi o/
17:03:14 <msdubov_> andreykurilin, rediskin, oanufriev, temujin, k4n0, Good evening, guys
17:03:21 <coolsvap> hello
17:03:21 <msdubov_> olkonami Hi :)
17:03:23 <andreykurilin> hi!
17:03:23 <k4n0> Good evening all
17:03:26 <olkonami> hi
17:03:36 <msdubov_> Okay so before we start
17:03:41 <oanufriev> komichiwa
17:04:02 <msdubov_> I'd like to remind people who are not in Rally team but who are reading us that we have a Trello board: https://trello.com/b/DoD8aeZy/rally
17:04:23 <msdubov_> It is full of easy tasks which you could take to start contributing to Rally
17:04:26 <msdubov_> So you're welcome
17:04:36 <msdubov_> Let's go through a number of topics now
17:05:09 <msdubov_> #topic Plugins
17:05:32 <olkonami> are not ready :(
17:05:37 <msdubov_> olkonami How are things with your work on that?
17:05:42 <olkonami> I had trouble with the bug
17:05:54 <msdubov_> olkonami, Okay, can we help you somehow with that?
17:06:54 <msdubov_> olkonami, Be sure to contact the core team of Rally, so that you're not stuck for a long time at one point
17:07:34 <olkonami> with this https://bugs.launchpad.net/rally/+bug/1368666 now I find how to avoid it
17:07:35 <uvirtbot> Launchpad bug 1368666 in rally "keystoneclient v2 fails" [Undecided,New]
17:08:06 <msdubov_> olkonami, any progress with that? What's your thoughts on why it happens?
17:08:56 <msdubov_> olkonami, I remember rediskin mentioning the same bug, perhaps he's the right person to contact
17:09:18 <olkonami> it happens when "use_public_urls" in config set to true and than we have endpoint something like 'endpoint': 'http://172.18.194.181:35357/v2.0/'
17:10:28 <oanufriev> olkonami: what happens if you curl http://172.18.194.181:35357/v2.0/
17:10:30 <oanufriev> ?
17:11:20 <olkonami> oanufriev: 404, it is not valid url
17:11:34 <olkonami> the reason of bug is here https://github.com/stackforge/rally/blob/master/rally/osclients.py#L104
17:12:52 <olkonami> but I haven't fixed it yet because I don't understand exactly what behavior should we have there
17:13:47 <msdubov_> olkonami, Could you then post an updated version of your patch, so that we could test it?
17:14:00 <msdubov_> olkonami, Too hard to speak about that in theory
17:14:21 <msdubov_> olkonami, Because it is not very obvious what's the actual problem with the plugins then
17:15:21 <olkonami> I finally able to run my plugins, but all of them fail, seems like we have a lot of changes in logic
17:15:36 <msdubov_> olkonami, Rebase issues?)
17:15:46 <msdubov_> Yep, might be
17:16:09 <msdubov_> in any case better make an update of your patch to attract more attention to it
17:16:11 <olkonami> It doesn't seems to be a rebase issues
17:16:41 <olkonami> I will make update when fix fails
17:16:48 <msdubov_> olkonami, Okay!
17:16:54 <msdubov_> Let's move forward now
17:16:59 <msdubov_> #topic CLI improvements
17:17:54 <msdubov_> Last week, we started working on a nice doc with CLI improvement proposals: https://docs.google.com/a/mirantis.com/document/d/1iZa9V8C3Z09JTC3x2MGpBq-FEszwRmVCYoxCbN1zHgo/edit#heading=h.cd7fv0p8e3fk
17:18:04 <msdubov_> First of all, it surely needs to be extended
17:18:23 <msdubov_> Secondly, I've started making trello tasks out of the issues pointed out in the doc
17:19:02 * k4n0 checks google doc
17:19:21 <msdubov_> The task No.2 went to penguinRaider (seems he is currently offline)
17:19:39 <msdubov_> coolsvap, ping
17:19:45 <k4n0> I am working on task 4
17:19:58 <coolsvap> msdubov_, hey
17:20:02 <msdubov_> k4n0, Yes, great!
17:20:27 <msdubov_> coolsvap, I just wanted to ask you if you were so kind to take the CLI improvement task No.7 from the Google doc!
17:20:36 <msdubov_> coolsvap, I've described it in more detail here: https://trello.com/c/2t1WZA88/226-medium-cli-print-friendly-message-in-case-of-db-model-inconsistency
17:21:08 <msdubov_> coolsvap, Seems like not very difficult to implement, but also not trivial as well
17:21:22 <coolsvap> msdubov_, I am opening the doc, you can assign me
17:21:58 <msdubov_> coolsvap, Better read the trello link!
17:22:16 <msdubov_> coolsvap, And if you're ready to work on it, please assign yourself in Trello
17:23:33 <k4n0> msdubov_, please add me to trello board (rkanade@redhat.com)
17:24:19 <msdubov_> k4n0, Done, please check
17:25:07 <k4n0> msdubov_, thanks, works
17:25:13 <msdubov_> coolsvap, Are you registered on Rally Trello board as well?
17:25:24 <coolsvap> msdubov_, yes I do
17:25:41 <msdubov_> coolsvap, Great, so please assign yourself to the task
17:25:48 <coolsvap> msdubov_, done!
17:25:54 <msdubov_> coolsvap, Thanks!
17:26:01 <msdubov_> As for me, I hope I'll do some work on CLI this week as well
17:26:50 <msdubov_> E.g. I wanted to make the "rally info" command more flexible (more options / missspelling handling - see the Trello board)
17:26:57 <msdubov_> Any questions?
17:27:09 <msdubov_> On the CLI topic
17:28:16 <oanufriev> no
17:29:00 <msdubov_> oanufriev, Just to finish the CLI topic, could you share what you've done on CLI functional testing?
17:29:22 <oanufriev> moment please
17:30:19 <oanufriev> there is a ptch on review https://review.openstack.org/#/c/118714/
17:31:01 <oanufriev> in this patch i've implemented all points from this blueptint https://blueprints.launchpad.net/rally/+spec/tests-integrated
17:31:14 <oanufriev> so... waiting for review
17:31:58 <msdubov_> oanufriev, Will do, andreykurilin, k4n0, olkonami Please take a look at it as well!
17:32:06 <k4n0> Sure
17:32:13 <msdubov_> #topic Docs
17:32:30 <msdubov_> oanufriev, And please tell others about your second patch on docs generation
17:33:30 <oanufriev> well... https://review.openstack.org/#/c/120794/
17:33:46 <oanufriev> in this patch i implemented 2 scripts
17:34:09 <oanufriev> in rally docs we have samples directory
17:34:47 <oanufriev> samples, at most, are in json and yaml files, and sometimes rst
17:35:42 <oanufriev> the goal was to automatically generate rst docs from samples during gating
17:36:17 <msdubov_> oanufriev, Thanks, so that has to be reviewed as well
17:36:25 <msdubov_> k4n0, olkonami, andreykurilin ^
17:36:40 <k4n0> msdubov_, ack
17:36:47 <msdubov_> In addition to that, I'm still working on adding a step-by-step tutorial on how Rally works to the docs.
17:37:12 <msdubov_> So that it will be pretty easy for newcomers to go through our readthedocs website
17:38:10 <msdubov_> #topic Free discussion
17:38:15 <msdubov_> boris-42 Hi :)
17:38:27 <msdubov_> Great you're here
17:38:55 <andreykurilin> I want to discuss one bug
17:39:24 <msdubov_> andreykurilin, Yes, go ahead
17:39:37 <andreykurilin> https://bugs.launchpad.net/rally/+bug/1305991
17:39:38 <uvirtbot> Launchpad bug 1305991 in rally "there is no method MagicMock.assert_called_once() " [High,Fix released]
17:39:48 <andreykurilin> this bug was fixed several times
17:39:54 <boris-42> msdubov_ hi thank you for meeting
17:39:58 <boris-42> msdubov_ I mean organizing it
17:40:04 <boris-42> flaper87|afk ping*
17:40:05 <andreykurilin> but we should reopen it again(
17:40:06 <msdubov_> andreykurilin, Where did it appear last time?
17:40:14 <andreykurilin> one moment
17:40:27 <msdubov_> andreykurilin, So we've merged a patch that had this issue, that's sad
17:40:38 <andreykurilin> we have several places
17:41:17 <andreykurilin> http://paste.openstack.org/show/112247/
17:42:05 <msdubov_> andreykurilin, Could you please make a task on Trello and paste this to the description?
17:42:16 <msdubov_> andreykurilin, We'll let then somebody fix that
17:42:22 <andreykurilin> my proposal to use HACKING rules to check such issues
17:42:27 <andreykurilin> like in nova
17:42:37 <msdubov_> andreykurilin, Yep we should discuss how to avoid that in future
17:42:46 <msdubov_> boris-42, Any thoughts?
17:44:22 <msdubov_> andreykurilin, Re-opened the bug
17:45:25 <andreykurilin> msdubov_, I will add new task in trello to fix this problem, but I don't think that this is last time when we missed such usage of mock in tests
17:45:59 <msdubov_> andreykurilin, Yes, that's why I agree with you that we shall add a check for this issue in gates
17:47:01 <boris-42> msdubov_ andreykurilin  you are talking about assert mock?
17:47:09 <andreykurilin> boris-42 yes
17:47:10 <boris-42> msdubov_ andreykurilin  ya we need to re-open bug
17:47:14 <boris-42> msdubov_ andreykurilin  and add hacking rule
17:47:28 <boris-42> msdubov_ andreykurilin I think we should talk with jogo
17:47:46 <boris-42> msdubov_ andreykurilin  cause in Nova they faced the similar stuff and they are thinking about adding hacking rule
17:48:03 <andreykurilin> boris-42, https://review.openstack.org/#/c/121726/ :)
17:48:21 <boris-42> andreykurilin ah great
17:48:37 <boris-42> andreykurilin so actually I would prefer some more strong check
17:49:09 <andreykurilin> boris-42: ? more strong?
17:49:17 <boris-42> andreykurilin e.g. if it begin with "assert_*" then it should be one of "assert_*" methods that can be used
17:49:33 <boris-42> andreykurilin like we have set of ["assert_*"] methods
17:49:45 <andreykurilin> boris-42, hm...
17:49:49 <andreykurilin> agreed
17:50:08 <boris-42> assert_caled_with, assert_called_once_with, assert_any_call ...
17:50:11 <boris-42> andreykurilin ^
17:50:26 <msdubov_> boris-42, Looks like it makes sense
17:50:38 <boris-42> msdubov_ andreykurilin  okay so we can do our hacking rule for that
17:51:15 <msdubov_> Perhaps any other topics to discuss before we finish?
17:52:28 <tzabal> msdubov_ may I ask for something?
17:52:34 <msdubov_> tzabal, Sure
17:52:53 <tzabal> msdubov_ I would like if it is possible for some attention to the vm benchmarking topic
17:53:07 <boris-42> tzabal I will review your patches
17:53:15 <tzabal> boris-42 thanks
17:53:17 <boris-42> tzabal sorry about that I am just finished my trip=)
17:53:26 <tzabal> boris-42 no problem
17:53:27 <boris-42> tzabal so I was off-line for some time
17:53:44 <boris-42> tzabal but yep wee need deffinilty to review your sutff
17:53:44 <msdubov_> tzabal, Will review as well
17:53:55 <tzabal> boris-42 dont't worry about that, I think I am just stuck in gates
17:54:07 <tzabal> boris-42 for this reason i am asking for some second thoughts
17:54:30 <tzabal> i cant make the blogbench scenario pass the check, while in my local environment it finishes successfully
17:54:31 <msdubov_> tzabal, Yes, I saw your message about that you have different errors all the time
17:54:38 <msdubov_> tzabal, I mean in gates
17:54:39 <tzabal> msdubov_ exactly
17:55:08 <tzabal> msdubov_ i can provide you witht the debug log of this task that I run locally and shows that it actually works
17:55:38 <msdubov_> tzabal, It may help
17:55:52 <tzabal> msdubov_ nice
17:56:53 <msdubov_> Okay seems like we are almost out of time
17:57:40 <msdubov_> Before we finish, I'd like to remind one more time people who are interested in starting contributing to Rally that we have a Trello board, full of relatively easy tasks to start with: https://trello.com/b/DoD8aeZy/rally
17:57:57 <boris-42> msdubov_ thanks mike
17:58:00 <msdubov_> If you're taking one of these, please contact either me or boris-42 and assign yourself there
17:58:41 <msdubov_> Okay, guys, see you later
17:58:43 <msdubov_> #endmeeting