13:00:34 #startmeeting qa 13:00:36 Meeting started Tue Jul 7 13:00:34 2020 UTC and is due to finish in 60 minutes. The chair is masayukig. Information about MeetBot at http://wiki.debian.org/MeetBot. 13:00:37 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 13:00:39 The meeting name has been set to 'qa' 13:00:50 Hi, who all are here today? 13:01:44 o/ 13:02:05 o/ 13:03:02 gmann: kopecmartin hi 13:04:13 OK, let's start 13:04:22 #link https://wiki.openstack.org/wiki/Meetings/QATeamMeeting 13:04:30 ^^^^^^ today's agenda 13:04:43 #topic Announcement and Action Item (Optional) 13:05:00 I have no announcement this time 13:05:31 let's skip if no one has announcement 13:05:45 #topic Victoria Priority Items progress 13:05:54 #link https://etherpad.opendev.org/p/qa-victoria-priority 13:06:11 any update about the priority things? 13:06:34 yeah 13:06:35 Feature Freeze idea for new tests in Tempest and Patrole and other QA projects (gmann) 13:06:37 gmann: I saw your patch but not reviewed deeply yet 13:07:00 added Feature Freeze things in https://wiki.openstack.org/wiki/QA/releases#Feature_Freeze 13:07:25 and also added label for that in Tempest, grenade, and patrole - https://review.opendev.org/#/c/739550/ 13:07:37 #link https://wiki.openstack.org/wiki/QA/releases#Feature_Freeze 13:07:44 #link https://review.opendev.org/#/c/739550/ 13:08:08 a job for generating doc out of docstrings is ready, please have a look at the output #link https://review.opendev.org/#/c/735619/ 13:08:31 we can add gate fix/urgent label with +2 on Review Priority 13:08:37 gmann: ++ cool, thanks! That should be very helpful 13:08:49 and -1 for Feature Freeze,+1 for important changes 13:09:14 How to handle the tox.ini constarint for each Tempest new tag (gmann) 13:09:27 #link https://review.opendev.org/#/c/739609/ 13:09:39 I will update kopecmartin comments, thanks for review 13:10:17 kopecmartin: ++, thanks. I added it to my list. 13:10:19 kopecmartin: this still have WIP in cmt msg - 735619 13:10:44 kopecmartin: can you remove "WIP" tag from the commit message and add more commit message? 13:10:53 gmann: oh , yeah, lukas forgot to remove the WIP .. i guess some modifications will need to be done anyway .. 13:11:33 yep, we'll update the commit message, but first just have a look to check if it at least partially meet your expectations 13:11:45 Ghanshyam Mann proposed openstack/tempest master: Document the process to pin the constraint in tox.ini https://review.opendev.org/739609 13:11:56 kopecmartin: ^^ updated 13:12:02 thanks 13:12:06 kopecmartin: ++ yeah :) 13:12:19 kopecmartin: ok, will review that. thanks 13:13:11 gmann: thanks. 13:13:20 i've done some research in regardds of scenario manager 13:13:22 #link https://etherpad.opendev.org/p/tempest-scenario-manager 13:13:39 i was analyzing how many methods are repeated and where 13:14:06 and i found this email about refactoring the scenario manager which was the reason for copying the manager in every plugin 13:14:08 #link http://lists.openstack.org/pipermail/openstack-dev/2017-February/112938.html 13:14:33 as that's quite old effort, I wasn't around much back then .. is that done? 13:14:44 kopecmartin: what changed we need for 'List of plugins (Add plugins we will need to propose changes to):' 13:14:44 i'm kinda confused now :D 13:15:25 kopecmartin: yes, every plugin use their own copy of scenario manager not tempest.scenario.manager 13:15:41 that's just a list of plugins, which contain copied methods from tempest .. i wanted to have all the plugins where we'll need to send reviews at one place 13:15:53 so we can make changes in tempest.scenario.manager without effecting any plugins 13:16:23 kopecmartin: so that needed once we finish and make tempest.scenario.manager stable 13:17:33 kopecmartin: and this method list, plugins uses from their own copy right? - List of methods used by plugins: 13:17:40 L79 13:18:34 yes, there we can see what methods are implemented in what plugins and see how many times are certain methods repeated 13:19:03 yeah, I think we didn't know what functions/methods were necessary at that time. I think that's one of the reason we couldn't make scenario.manager stable. 13:19:05 ok, that is nice investigation and can help us on making them stable 13:19:24 just to make sure ... so the primary goal here is to remove any duplicated method definitions from plugins and use the methods directly from tempest's scneario manager? 13:19:56 kopecmartin: we need to go with 'make complete scenario manager stable and then change to plugins' instead of changing method one by one 13:20:18 create methods and functions which are less grown organically and more organized 13:20:30 kopecmartin: no, we need to make complete scenario manager stable first 13:20:53 gmann: ok, how do we do that? what should be next move? 13:21:08 kopecmartin: idea of copy the scernario manager on plugins side was to avoid change method by method 13:22:34 kopecmartin: 1. make all method available in tempest.scernario.manager as stable 2. declare this file as stable for plugins 3. start replacing the plugins copy with tempest.scenario.manager 13:23:20 for stability we need to do L25 13:23:49 let me update the etherpad for that 13:23:56 gmann: kopecmartin I just copied & pasted to the etherpad at L.35 13:25:36 ok .. so from the 'List of methods used by plugins' we pick the most used ones and make sure they are defined in tempest.scneario.manager the way they fit to all the plugins which use the method 13:27:32 kopecmartin: I will say we can make all even method is used by tempest only. and method used most can be done via how it used in plugins and do we need to modify it little bit to accommodate all usage? 13:29:09 i found small modifications of some methods on plugins' side 13:30:06 kopecmartin: yeah that is good way to make our method stable and usable for all plugins 13:30:29 gmann: kopecmartin : how we are separating the patches so that multiple people can work here? 13:31:05 paras333: we can start adding the method patches in etherpad with their name 13:31:31 paras333: we can use the 'List of methods used by plugins' list .. f.e. now i'm focusing only on create_server method - I put my nick to that line (L92 now) 13:31:32 under this 'List of methods used by plugins:' L89 13:31:39 gmann: yes :) 13:31:41 yeah 13:31:48 ack 13:31:55 cool 13:32:26 greawt, i think it's clear for now, let's move on 13:32:44 ok 13:32:51 kopecmartin: updated L50 step 5,6,7,8. 13:33:15 gmann: great, thanks 13:33:28 Anything else for Victoria Priority Items progress? 13:33:33 kopecmartin: you can add the step to assign the method and add contributor name in 'List of methods used by plugins:' before they start 13:34:30 Dan Smith proposed openstack/devstack master: Use glance import workflow for creating image https://review.opendev.org/735966 13:34:30 nothing from me 13:34:51 ok 13:34:55 #topic OpenStack Events Updates and Planning 13:35:36 gmann: do you know anything about the Berlin summit? 13:35:38 #link https://www.openstack.org/summit/2020/ 13:35:55 masayukig: no, CFP open for presentation sessions. 13:36:17 but no other updates yet, may be you will get for project updates etc 13:36:58 gmann: thanks, yeah. And it seems forum and PTG will be managed separately in the upcoming months. 13:37:08 yeah 13:37:10 ok, let's move on. 13:37:26 #topic Sub Teams highlights (Sub Teams means individual projects under QA program) 13:37:36 Do you have any updates/highlights on the sub-projects such as Tempest, Patrole and Hacking? 13:37:44 #link https://review.openstack.org/#/q/project:openstack/tempest+status:open 13:37:50 #link https://review.openstack.org/#/q/project:openstack/patrole+status:open 13:37:56 #link https://review.opendev.org/#/q/project:openstack/hacking+status:open 13:38:10 we faced the setuptools issue last week 13:38:12 #link http://lists.openstack.org/pipermail/openstack-discuss/2020-July/015782.html 13:38:42 Lee Yarwood proposed openstack/devstack-plugin-ceph master: Use apt-get to update repos on Ubuntu https://review.opendev.org/739694 13:38:46 it is still under discussion on setuptools side but 491.0 is working where they reverted the disutils things 13:39:24 gmann:++ thanks 13:39:56 for focal migration we need hacking release with pyflakes in hacking requirement #link https://review.opendev.org/#/c/739334/ 13:40:36 pyflakes 2.1.1 needed to work on focal. and most of project has that in their lower-constraints so pep8 fail 13:41:24 my idea is we handle the pyflakes version in hacking side and projects can move to new hacking to avoid worry about maintaining pyflakes on their side 13:41:53 hacking patch still fail on lower-constraint job which i need to check 13:42:14 Lucas Alvares Gomes proposed openstack/devstack master: DO NOT REVIEW: Change Neutron's default ML2 driver to OVN https://review.opendev.org/735097 13:42:56 gmann: thanks, I'll check the patch anyway if I have the bandwidth.. 13:43:29 yup I have added myself in review 13:43:29 also one more patch for grenade to add doc for stable testing #link https://review.opendev.org/#/c/736866/ 13:44:02 masayukig: paras333 thanks, let me debug failure after meeting 13:44:31 paras333: somehow it is failing on 'Requirement.parse(\'pyflakes<2.1.0,>=2.0.0\')' 13:44:31 paras333: ++ cool 13:45:10 means pyflakes which is blacklist requirements still controlled by someone else also 13:45:21 :( 13:45:27 that's strange 13:45:36 so complicated and tricky.. 13:45:58 #link https://zuul.opendev.org/t/openstack/build/87ec4badcdda4cc2b30a3db4e28dac12/log/job-output.txt#685 13:46:25 i need to check flake8 or some other package 13:47:51 it might be good to make a tool to check it if it happens frequently.. 13:48:14 you mean version checks? 13:48:59 yeah, like that tool. I have no concrete idea yet though 13:49:47 tool will catch the same as gate does, i mean start failing on incompatible changes if any 13:50:29 Isee pyflakes used in these project from the quick codesearch https://opendev.org/airship/pegleg/src/branch/master/requirements.txt 13:50:34 https://opendev.org/x/python-apmecclient/src/branch/master/test-requirements.txt 13:51:13 paras333: yeah, i am fixing those like - https://review.opendev.org/#/c/739315/4/test-requirements.txt 13:51:35 paras333: gmann cool 13:51:37 so we need to release hacking first to validate the comment i am adding there 13:51:49 Ahh ok 13:52:14 thanks. Anything else on this sub team topic? 13:52:35 just on the hacking methods #link https://etherpad.opendev.org/p/hacking 13:53:09 I see gmann updated one , I can add that one in the patch but would appreciate if I know what we don't need and why as well 13:53:15 yeah, i started yesterday but got another things to do, I will continue todya 13:53:26 gmann++ 13:53:56 paras333++ thanks for notification. 13:54:25 paras333: one things to note, we can hold adding the new checks till we migrate it to focal so projects switching to new hacking for pyflake req etc can easily do without worry about new code checks 13:54:53 paras333: i will finish the focal things on hacking on priority 13:55:02 gmann: ack 13:55:27 ok, let's move on since we have 4.5 mins 13:55:31 #topic Community goal tracking 13:55:44 gmann: any updates? 13:55:57 #link https://etherpad.opendev.org/p/qa-community-wide-goals-tracking 13:56:10 yeah started the focal migration on other project like hacking etc. 13:56:43 gmann: cool 13:56:48 I will add more testing patches or fixed if needed for other sub projects. tempest and devstack is in WIP till we test all projects 13:57:34 great 13:58:42 I'll keep my eyes on the patches 13:58:43 #topic Bug Triage 13:58:54 #link https://etherpad.openstack.org/p/qa-bug-triage-victoria 13:59:24 We(I) need to review more 13:59:46 for the patches on the etherpad 14:00:21 kopecmartin: anything from your side? 14:00:49 masayukig: not atm 14:00:57 kopecmartin: ++ np 14:01:05 #topic Critical Reviews 14:01:22 any patches you'd like to discuss? 14:02:35 may we can start adding the new label now onwards and check the urgent/critical patches with that label 14:02:39 This hight importance bug is there for quite a long time https://bugs.launchpad.net/tempest/+bug/1613819 14:02:39 Launchpad bug 1613819 in tempest "v3 credentials client does not honour the configured domain" [High,New] 14:03:07 gmann: +1 14:03:40 paras333: can you reproduce that? 14:04:02 may be we can close office hour and continue discussion 14:04:08 gmann: ok 14:04:14 thank you all 14:04:21 #endmeeting