15:01:22 #startmeeting openstack search 15:01:22 Meeting started Thu May 12 15:01:22 2016 UTC and is due to finish in 60 minutes. The chair is TravT. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:01:23 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:01:25 The meeting name has been set to 'openstack_search' 15:01:35 o/ 15:01:42 o/ 15:01:44 o/ 15:01:51 o/ 15:02:03 ello 15:02:17 hello everybody! 15:02:40 so meeting agenda is here 15:02:41 https://etherpad.openstack.org/p/search-team-meeting-agenda 15:02:46 please add anything you see fit 15:02:48 o/ 15:03:08 i'm going to skip the first topic and come back to it, because i don't see tyr yet 15:03:44 #topic versioned notifications 15:04:06 So, we brought it up a bit last week 15:04:09 http://lists.openstack.org/pipermail/openstack-dev/2016-May/093962.html 15:04:30 in the context of the nova v2 cells announcement that they were going to look into searchlight for multi-cell deployments 15:04:50 i spent some time going through the specs 15:04:56 and chatted a bit with sjmc7 15:05:16 i was honored 15:05:19 i'll just share a few thoughts and then maybe yingjun also had some time 15:05:25 to look over things 15:05:56 anyway, it seems that versioned notifications will certainly help with being able to tell when notification payloads change 15:06:06 but they don't necessarily guarantee we'll get all the data 15:06:12 well, that depends what they decide to do :) 15:06:18 or have they made a decision? 15:06:45 spec is still unchanged 15:06:50 still has a few -1's 15:06:57 i went to what I thought would be the meeting time this week 15:07:01 but nobody appeared 15:07:07 so maybe they are still doing in every two weeks 15:07:44 so there actually is a chance it’ll make things worse than now if they become just a delta 15:08:09 sjmc7 do you want to explain that a bit for everybody here 15:08:35 right now notification payloads are mostly identical indepdenent of the event 15:08:49 and they contain a (mostly) full representation of the instance 15:09:12 there is some talk of moving to sending payloads that are deltas of what the event changed 15:09:41 since elasticsearch has no ‘update’ mechanism per se, it’s a bit more work for us to do that (though not insurmountable) 15:09:51 but it increases the risk of dangerous race conditions 15:10:12 because we can no longer ignore notifications older than the record we have stored 15:10:35 right now it’s moot since we hit nova’s API but we really need to stop doing that if possible 15:11:29 i’m done explaining 15:11:30 sjmc7: i'm not sure exactly where is the best place to leave those comments, but maybe you could just add them to this spec in the comments so they are captured somewhere 15:11:31 https://review.openstack.org/#/c/286675/ 15:11:46 yeah, will do 15:12:00 it’s not clear what the motiviation for making the versioned change is (i.e. the specific use cases) 15:12:14 so we’ll see how much influence we have 15:12:45 so, the main motivation as i understand it is so that consumers know when the payload changes 15:12:57 eg. version 1.0 of notification to version 1.1 to 2.0 15:13:12 which consumers though? 15:13:35 i get the overall reasoning, i’m just not sure what drives specific decisions 15:13:40 that is unclear and is part of the spirit of the notes i left on the spec 15:13:43 but i guess we’ll find out 15:14:03 the advantage of it all though is that they can potentially add info to payloads 15:14:12 yes. 15:14:17 which might let us stop mashing at nova’s api 15:14:25 so, sjmc7 and i were thinking that we should do the following in newton 15:14:46 interestingly, one counter argument was that it would actually be better if services could query nova’s api more cheaply and do exactly what we do now 15:15:10 1) update our callbacks and mapping to nova to request the latest version 15:15:25 2) https://blueprints.launchpad.net/searchlight/+spec/nova-optionally-disable-some-events 15:16:13 3) keep working on versioned notification with the nova team as consumers, but since we can't count on them 100% do 1) & 2) 15:16:40 thoughts? (hope we didn't suck the oxygen out of the room) 15:17:14 breathe! 15:17:26 i got nothin' 15:17:53 rosmaita coffee running low today? ;) 15:18:25 TravT: just one large this morning, guess that's the problem 15:18:41 * rosmaita needs another coffee with extra oxygen 15:18:52 well, i know we just threw a lot of info out there 15:19:28 we can come back to this if others have more thoughts. 15:19:44 #topic backport 0.2.1 15:19:57 still wanting to finish out items so we can tag stable/mitaka 15:20:15 definite ones are bugs relates to ES 2.0 15:20:35 i believe this is the last one for the service: https://review.openstack.org/#/c/311834/ 15:21:00 gonna look at it again today. it was more complicated than i initially thought 15:21:21 okay 15:21:30 can you also cherry pick this one to stable/mitaka: https://review.openstack.org/#/c/307504/ 15:21:34 ? 15:22:01 yeah. looks like there’s a merge conflict but i’ll do it after this 15:22:11 sjmc7: i think backporting the nova spec could be a follow on backport 15:22:16 https://review.openstack.org/#/c/307504/ 15:22:18 oops 15:22:31 https://blueprints.launchpad.net/searchlight/+spec/nova-optionally-disable-some-events 15:22:37 for a different release tag 15:22:45 yeah, that’s fine. we’re not really meant to backport features, though this one’s kind of a bug-ture 15:23:10 yeah, it could perhaps be considered a scalability bug... 15:23:42 ok, still not tyr or david-lyle it looks like, so will come back to the searchlight ui topic 15:23:59 looks like rosmaita topic is next 15:24:01 TravT: I'm here 15:24:08 hey david-lyle 15:24:08 just reading along 15:24:16 okay 15:24:20 #topic upcoming changes to glance that will affect the searchlight plugin 15:24:24 rosmaita: ^ 15:24:28 ok 15:24:41 the change is that there will be more image 'visibility' values 15:25:03 we like a challenge :) 15:25:15 and the community scheme will allow people to create quasi-public images 15:25:19 anyone can use them 15:25:29 but they only appear in your image-list if you "bookmark" them 15:25:45 by using the member-list thing we already use for 'shared' images 15:25:56 and 'shared' will become an actual visibility 15:26:16 and after that, there's a push for what i'm calling 'protected' images 15:26:25 (though there will be bikeshedding over the name) 15:26:58 these will be images that appear in the default image-list of descendant tenants in the keystone hierarchical tenancy scam 15:27:06 i mean 'scheme' 15:27:10 hahahaha 15:27:19 lol 15:27:22 tip your waiter! 15:27:33 so, it occurs to me that that is a lot of logic to be duplicating into the searchlight plugin 15:27:39 yeah :( 15:27:57 still don't understand why HMT won't die 15:27:57 and also, i wonder whether there is any thing we can do in glance to make this easier for indexing 15:27:59 as long as we know what it is towards the end of a release, it’s not a huge deal 15:28:01 community concept didn't initially freak me out (maybe it should), but that second one scares me 15:28:14 the big concern is that we are never more permissive than glance 15:28:25 right 15:28:38 anyway, i wanted to put this on people's radar 15:28:47 yeah, thanks. are there specs/bps for this? 15:28:53 https://review.openstack.org/#/c/271019/ 15:28:58 on the agenda 15:29:09 so rosmaita, shared will actually be a value now? 15:29:11 ah! splendid 15:29:27 TravT: yes 15:29:59 and all deployments will get this by default? 15:30:04 for v2? 15:30:25 well, it will be in newton (if the spec is approved) 15:30:40 * rosmaita has 50 windows open and can't find the relevant ones 15:30:54 community sounds pretty easy 15:31:17 here's the community spec, close to approval: https://review.openstack.org/#/c/271019/ 15:31:30 the diff between get by ID actually is a new use case... 15:31:33 :-S 15:32:15 the multitenancy stuff is discussed here, though it's preliminary: https://etherpad.openstack.org/p/newton-image-visibility-changes 15:32:28 basically, community is "if i know the ID of it, I can get it directly". "If i'm added as a member to it, I can list it" 15:32:34 rosmaita: ? ^ 15:32:51 TravT: yes, plus you can discover community images 15:33:03 GET v2/images?visibility=community 15:33:03 how do you discover them? 15:33:59 and the listing is subject to the member_status==accepted, just like shared images 15:35:03 anyway, just wanted to request a quick look-over if y'all have some free time, just to point out if we're proposing anything insane 15:35:43 thanks! 15:35:57 as long as we can translate the api to filters we’re good 15:36:03 what's the probability of all this making it into newton? 15:36:17 from a glance perspective 15:36:34 rosmaita would you mind opening a searchlight BP for each of these? 15:37:11 you make it sound so easy 15:37:27 :) 15:37:28 https://blueprints.launchpad.net/searchlight/+addspec 15:37:32 ;) 15:37:45 sorry, that comment was addressed to sjmc7 15:37:54 but sure, i can open a bp 15:37:56 :) 15:37:58 for each 15:38:21 community should make it into newton 15:38:24 everything is easy for sjmc7... at least he makes it look that way 15:38:47 i’m actually juggling plates right now 15:39:11 okay, next topic 15:39:17 was hoping tyr might show up 15:39:21 nikhil has 'image sharing changes' as a priority for newton, that will def include the community spec, possibly the hierarchical 15:39:37 (sorry, i have severe typing lag today) 15:39:58 ++ 15:40:23 okay cool 15:40:38 rosmaita all done with this topic for now? 15:40:47 yep 15:41:05 #topic Searchlight UI as top level Dashboard instead of panel 15:41:18 * sjmc7 puts on helmet 15:41:30 tyr isn't here, but we have matt-borland and david-lyle 15:41:36 o/ 15:41:40 i took a screenshot http://imgur.com/a/p7dmB 15:41:59 basically right now, the SL ui is a panel under the "Project" dashboard 15:42:12 tyr has a patch up to move it into its own dashboard 15:42:21 https://review.openstack.org/#/c/313666/ 15:42:52 right now, you can already check an option to search across projects from the SL dashboard (if you are admin) 15:43:18 and with yingjun's latest patch merging (hypervisors), SL now also has data that is admin only and only shown to admins 15:43:55 david-lyle had some comments on the patch above^ 15:44:17 * david-lyle looking for trouble 15:44:48 so, just wanted to open this up for any additional discussion 15:44:55 I just wanted to point out that mixing admin and owner roles can be confusing to users as well as complicate the action invocation 15:44:56 i’m not a huge fan of it 15:45:19 from a consistency standpoint i think it makes more sense to make it available from Project and Admin 15:45:38 for pretty much the same reasons as david-lyle 15:46:10 sjmc7, does that basically mean that scope is limited to project when within 'project', and across projects when in 'admin'? 15:46:13 i think the usage is likely to be quite different in those two contexts 15:46:17 yeah 15:46:42 it would also allow us to potentially define changes in behavior in the two contexts 15:46:45 an admin very rarely wants to do more than observe unless cleaning up a problem 15:47:02 where as an admin acting on their own project will make changes freely 15:47:19 I think that although it seems strange from a dev's perspective, 2 searches makes more sense from an implementation/use perspective 15:47:28 the line of ownership gets blurry 15:48:01 also is becomes really unclear how/when you can perform actions on the project side 15:48:09 so, david-lyle we have also talked about top-nav search (a searchbar from top nav). if a user clicked into that, wouldn't that face a similar problem. 15:48:11 (when you lump everything together across projects) 15:48:20 two searches also allow us to e.g. change default columns without it looking weird 15:48:38 the top search wouldn’t have actions in the same way, at least in the incarnation we showed in vancouver 15:48:44 TravT: yes and no, depending on whether you expose the actions or redirect 15:48:53 but would you link them into projects or into admin 15:48:58 yes 15:49:23 there is some UX needed to make that choice clear 15:49:35 off the top of my head i’d defauit top search to all but make it clear in results which ones were in your current project 15:49:46 sjmc7: ++ 15:50:06 being in the left-nav causes a lot of the inconsistency for me 15:50:17 * matt-borland is in another meeting, ping if needed 15:50:22 so, here's a couple of items to consider either way 15:50:28 it feels like it fits more neatly in the existing dashboards to me 15:50:55 the available plugins will need to expose context 15:51:13 right now, if you come in with an admin token and list plugins, you just get them all 15:51:33 so if the ui remains in project and gets an admin one, then project should not show them 15:51:37 yeah, there is a BP to implement ‘admin only’ plugins whatever that means 15:51:54 i agree that’s currently a bit weird. although it’s weird however this discussion goes 15:52:02 there also is another alternative to think about if we go with a global search 15:52:32 maybe SL could provide data on each item as to why you got it? 15:52:50 another option is change how the actions are invoked 15:52:52 the only way I know of doing this would be to to do both a project scoped search and if admin also doing admin scoped search 15:53:10 and then mark the admin only ones as such 15:53:10 if there is a choice of admin vs owner, make the user explicitly select that 15:53:24 could still be in a separate dash 15:53:33 I just think the UX needs more thought 15:53:47 yeah, i’m not gonna argue it to death 15:53:53 * david-lyle trails the discussion a bit 15:54:01 but this discussion might’ve been better with some mockups beforehand rather than a full review 15:54:02 the actions are definitely problematic 15:54:28 2 things to be separate dash 15:54:41 1) clear indicator of ownership vs not 15:54:58 2) very explicit user choice as to scope of the action 15:55:28 again fixable, but it's not just as trivial as throwing the views into a new dash 15:57:09 the scope of actions seems rather tricky... with a lot of possible implications. 15:57:23 yes 15:57:35 and batch actions become a nightmare of scope 15:57:45 not sure whether those are in plan 15:58:06 ooo! 15:59:01 okay, so, we are low on time, but i'd like to continue this discussion later if possible. 15:59:07 in the thunderdome! 15:59:11 i think we need a little matrix of scenarios 16:00:05 in any case, i think we need to give more info on plugins 16:00:15 or filter by project or something 16:00:20 but we are out of time for this meeting 16:00:26 thanks everybody 16:00:28 good discussion, good points! 16:00:36 #endmeeting