15:01:41 #startmeeting openstack-helm 15:01:41 Meeting started Tue Jan 9 15:01:41 2018 UTC and is due to finish in 60 minutes. The chair is mattmceuen. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:01:43 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:01:45 The meeting name has been set to 'openstack_helm' 15:01:50 #topic rollcall 15:01:54 o/ 15:01:54 o/ 15:01:57 GM! 15:02:01 o/ 15:02:04 good morning 15:02:13 Agenda: https://etherpad.openstack.org/p/openstack-helm-meeting-2018-01-09 15:02:33 Feel free to add any addn'l topics you'd like to discuss today 15:03:38 Pretty light agenda today, you can all scare up your pent-up roundtable :) 15:03:49 #topic Define WIP 15:04:15 I got a couple suggestions from the community to help get folks on the same page faster 15:04:35 First: not everyone uses WIP the way we do, so it'll help to define it 15:04:53 WIP = Work In Progress, and is a tag that you can prepend on a patchset 15:05:10 o/ 15:05:21 It indicates a PS that is probably not yet fully functional, and probably not ready for a full rigorous review 15:05:39 But is out in the open so it can be shared in an "early access" or "for interested parties" manner 15:06:04 So as reviewers, noone should feel compelled to review a WIP patchset -- just if you're interested in a sneak peak 15:06:12 Did I miss anything? 15:06:30 top o' the morning alanmeadows 15:06:34 thats how I see it 15:07:03 It helps balance out the urge to wait for something to be Pristine before revealing it to the world 15:07:16 i think if anyone wants a review on a WIP, they should add reviewers and maybe ping them directly 15:07:24 My WIP PS if full of TODO comments that I plan to clean up before taking WIP out of the PS, for example 15:07:25 but i typically wont provide any feedback on something with a WIP tag 15:07:59 Good point. A friendly FYI. 15:08:35 Any other WIP bits? 15:09:14 So then the transition of a PS from WIP to non-WIP is typically indicated by simply taking out the WIP from the PS name 15:09:35 At which point serious review is welcome 15:09:42 Which brings us to second topic: 15:09:56 #topic Ways to leverage the OpenStack-Dev ML 15:09:56 thats how I've always done it - as having to "workflow -1" on every ps gets dull quickly. 15:10:06 agree portdirect 15:10:31 We don't leverage the mailing list much to date 15:10:55 One valuable way to use it would be to invite reviews on a "major" PS as it transitions from WIP to ready-for-review 15:11:33 That would serve as a notification to both OSH team members (which is a little redundant if you're watching e.g. the osh channel) but also the broader community 15:12:09 So if you had a major Nova chart PS for example, and it would benefit from review from the Nova team, you could invite review that way 15:12:19 i wouldnt use the mailing list for review requests 15:12:47 How come? 15:13:58 i think IRC or adding specific reviewers would be better -- calling for reviews on the mailing list goes against the mailing list etiquette: https://wiki.openstack.org/wiki/MailingListEtiquette#Reviews_request 15:14:19 i think if we want to discuss a feature and get feedback on it from a high level, it'd be alright but id stop short of requesting reviews 15:14:35 ++ 15:14:51 but we should for sure be much more active there 15:14:56 i agree 15:15:01 as many of our problems are community wide 15:15:12 Agree. I'm thinking of this less like our standing "what PS need eyeballs" meeting item, and more like "announcement: we have a new chart for X and are interested in feedback from team X" 15:15:14 eg: healthchecks 15:15:59 totally. 15:16:05 (also: we'd appreciate contributions / enhancements from team X :) ) 15:16:07 I'd be tempted to bring people in earlier to be honest 15:16:19 eg: we want to do nova live migration, how should we do that? 15:16:38 portdirect: yeah, that's the high level stuff i envision being discussed via the ML 15:16:54 awesome 15:18:14 Other thoughts on either getting more out of the ML, or ways to get eyes on PS and invite review? 15:19:04 On that note, I am seguewaying like a monster today 15:19:12 #topic PS that need review 15:19:47 who needs some review today 15:20:49 well this is an excellent problem for us to have, and maybe a first :) 15:20:58 ive been working on some docs for the current LMA charts -- im hoping to have those ready for review here in a bit 15:21:04 would really like some broad feedback there 15:21:07 good work team: I know there have been a lot of PS yesterday and everyone's been working hard to provide feedback 15:21:17 I'm in a similar boat, expect to be inundated in about 6 hours. 15:21:32 the calm before the storm 15:21:34 deal 15:21:52 oh 15:21:54 i lied 15:21:58 maybe take a gander at this: https://review.openstack.org/#/c/531223/ 15:22:10 o/ 15:22:26 this takes the current fluent-logging chart and adds logging for dockerd and the kubelet via systemd 15:22:31 A lot of PS notifications come by in the IRC channel, especially with our aforementioned WIP practices. Whenever someone would like some eyes on something sooner than later, feel free to drop an extra note in the chat room too. 15:22:36 o/ MarkBaker! 15:22:39 srwilkers: how does the output of this differ for the containers_tail for docker? 15:23:05 can we use the json logger or journald with impunity now? :) 15:23:43 that's the next step -- im going to throw a WIP up here soon to check how using the journald driver looks in comparison 15:24:02 im hesitant to say with impunity just yet, but thinking signs point to yes 15:24:48 with measured punity. 15:24:57 srwilkers: would this be the path for any host-level capturing? 15:24:59 three significant figures of impunity 15:25:04 e.g. expand on this approach as needed 15:25:24 alanmeadows: yeah 15:25:29 cool 15:26:28 Any other patches in need of review at the moment? 15:26:59 Cool. 15:27:03 can we give a shoutout for patches we just merged? 15:27:15 go for it portdirect 15:27:17 yes portdirect :) 15:27:38 so Craig Anderson is a scary, scary dude. 15:27:45 #fact 15:27:57 this is a real leap forward for us i think: https://review.openstack.org/#/c/524422/ 15:28:47 dat gotpl tho 15:28:48 and really is a sterling bit of gotpl 15:28:56 agree on both counts 15:29:10 a work of terrifying beauty 15:29:18 I've used it a few times as a ref, it always makes my brain bleed, but is worth it. 15:29:33 Van Gotpl? 15:29:35 * portdirect like a moth to a flame. 15:29:57 alanmeadows: i see what you did there 15:30:02 lol alanmeadows 15:30:11 I try to add value where I can 15:30:39 Should socializing recent merges of note be a standing agenda item? 15:31:11 hopefully, more than reviews needed ;) 15:31:18 ++ 15:31:24 I trust most cores follow those, perhaps etherpad worthy? 15:32:59 Yep. I like both approaches - good to call out broadly and also track the architecturally relevant ones so that folks could use them to catch up - is that what you're thinking alanmeadows? 15:33:48 sure, besides what other time do we get to a brief happy dance for wins? 15:34:11 :-D 15:34:21 deal 15:34:43 oh also an item of note 15:34:54 I started a small thread after sydney for health APIs 15:36:00 I think this is relevant for OSH input -- prior to mailing list publishing we wanted a spec 15:36:09 comments will be welcome from this group 15:36:15 https://review.openstack.org/#/c/531456/ 15:36:55 especially with an eye (for us) on how this can enable better helm/k8s health checking/management of openstack services 15:37:24 good one - thx for sharing that here 15:38:41 #topic Future knowledge sharing topics? 15:39:10 Are there any terrifying or exciting areas of OSH that anyone would like an overview of in a future team meeting? 15:39:41 don't wanna sign him up for anythiing, but i'd _love_ to hear an eli5 kind of walk through how to apply that 524422 patch 15:40:19 that would be great 15:40:34 selfish on my part 'cause we're going to need it for ceph, but it seems like other subtasks will want to use the technique as well. 15:40:38 as for ceph disk targeting it would be awesome 15:40:43 what he said. 15:41:26 Good idea! 15:41:31 Will do 15:41:42 It would be the more correct way to do it 15:41:52 and an excellent test of what its trying to offer 15:43:23 Alrighty: 15:43:28 #topic Roundtable 15:43:47 Other topics of note? 15:45:04 Well for one: congrats to jayahn, I don't think he was able to join today, but he got a promotion at SKT! Couldn't be happier for him. 15:45:22 If he were here he'd be too modest to brag, so I will brag for him 15:46:17 Also: we were originally going to have the CICD focus meeting this week, but that's been pushed to next week FYI. 15:46:46 The agenda for that is here, if you'd like to add to it: https://etherpad.openstack.org/p/openstack-helm-meeting-2018-01-16 15:47:37 Any other items for discussion? 15:48:18 Sold - good meeting folks. See you in the team channel. 15:48:28 #endmeeting