03:04:34 <Li_Liu> #startmeeting openstack-cyborg
03:04:35 <openstack> Meeting started Wed Mar  6 03:04:34 2019 UTC and is due to finish in 60 minutes.  The chair is Li_Liu. Information about MeetBot at http://wiki.debian.org/MeetBot.
03:04:36 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
03:04:38 <openstack> The meeting name has been set to 'openstack_cyborg'
03:05:08 <Li_Liu> #topic Roll Call
03:05:16 <Sundar> #info Sundar
03:05:18 <Li_Liu> #info Li_Liu
03:05:25 <xinranwang> #info xinranwang
03:05:28 <Yumeng_> #info Yumeng
03:05:44 <Li_Liu> hmm
03:05:52 <Li_Liu> let's wait for coco for a bit
03:05:58 <Li_Liu> let me ping her on wechat
03:11:17 <Coco_gao> Hi all
03:11:40 <Sundar> Hi Coco_gao
03:11:40 <Li_Liu> Hi Coco
03:11:45 <Li_Liu> let's get started
03:11:51 <Coco_gao> OK
03:11:55 <Li_Liu> #topic Status Update
03:12:01 <Coco_gao> #info Coco_gao
03:12:22 <Sundar> Have any of you tried to run https://review.openstack.org/#/c/640616/ ? I am getting an error
03:12:56 <Sundar> ccess wasdenied; cyborg:deployable;create
03:13:07 <Li_Liu> I tried .. it worked
03:13:29 <Li_Liu> well, we will not merge it for now
03:13:29 <Sundar> Apart from sourcing openrc as admin, did you do anything else?
03:13:55 <Sundar> Li_Liu: the code looks good. I may be missing some step.
03:14:12 <Li_Liu> let 's find out what I did
03:14:13 <Coco_gao> I finished most of the functions, but not pass the test. So I still need some some to upload the diff code.
03:14:23 <Coco_gao> some time
03:14:29 <Li_Liu> Coco_gao, thanks for the update
03:14:30 <Coco_gao> maybe today
03:14:39 <Li_Liu> great
03:15:16 <Li_Liu> xinranwang, how is the conductor part?
03:15:27 <Coco_gao> I may not have enough time for the unittest
03:15:44 <Li_Liu> Coco_gao, that's should be fine
03:16:20 <Sundar> All: please review https://review.openstack.org/#/c/641184/
03:16:22 <xinranwang> After discussion, we found Coco and I have some duplicate work on conductor side, so I leave her some interfaces, and coco implement the diff code there
03:16:41 <Coco_gao> xinran's code is depended on me, so I will help update her patch. The code is ready, just need some time for co-test.
03:18:02 <Coco_gao> Hi  Sundar,  thanks for that patch
03:19:05 <Sundar> Coco_gao: We'll fix the pep8 issues. But please see if this is how we want to fix and deprecate v1 API
03:19:38 <Coco_gao> OK, after my code being merged.
03:19:45 <Coco_gao> What's the deadline?
03:19:50 <Sundar> We are just fixing the return value. We should also fix the documentation. Is anybody handling documentation now?
03:21:11 <Sundar> Coco_gao: official deadline is March 8 for features. Bug fixes can go in after that too.
03:21:18 <Yumeng_> Sundar, I can do the doc update.
03:21:32 <Sundar> Yumeng_: Thanks a lot
03:21:33 <xinranwang> Li_Liu:  Also, I have improve the fpga driver to match the newest DB design,  I think we'd better have at least one driver works in this release.
03:21:41 <xinranwang> here is the patch https://review.openstack.org/#/c/599960/
03:21:56 <Coco_gao> Sundar,  after March 8, I can join for the doc.
03:22:00 <Sundar> xinranwang: Rodrigo has a patch almost ready for OPAE-based driver
03:22:15 <Coco_gao> xinranwang, Thank you.
03:22:46 <xinranwang> Sundar:  yes, but better to have one workable driver in this release.
03:23:21 <Li_Liu> I am pulled into another meeting... might be delayed in response
03:24:51 <Li_Liu> xinranwang, thanks a lot for the effort
03:25:27 <zhipeng> Is zhenghao around ?
03:25:31 <xinranwang> Li_Liu Coco_gao  np, pls review it when you got time
03:25:34 <zhipeng> Could we make the GPU driver as well ?
03:25:59 <Coco_gao> I will contact zhenghao for that.
03:26:36 <zhipeng> That'll be a dash for the weekend deadline
03:27:13 <Coco_gao> I think that part won't change much, he had a old patch.
03:29:52 <Coco_gao> wangzhh
03:30:04 <Coco_gao> we need you.
03:30:09 <wangzhh> Hi Coco.
03:30:19 <Coco_gao> Update the GPU driver
03:30:28 <Coco_gao> 😁
03:31:12 <Coco_gao> FPGA driver is ready
03:31:41 <wangzhh> No problem. But I don't have gpu device now. So Maybe I can just unit test.
03:33:03 <zhipeng> wangzhh yep that should be fine
03:33:12 <wangzhh> Anyway, I'll improve the gpu driver these days.
03:33:27 <zhipeng> Plz do that before the S release cut
03:33:41 <wangzhh> When?
03:34:31 <Li_Liu> wangzhh, do you need help on that?
03:34:40 <zhipeng> This weekend I think
03:34:53 <zhipeng> Li should know the exact date
03:35:18 <Li_Liu> Mar 04 - Mar 08	R-5	 Stein-3 milestone Feature freeze
03:35:39 <Li_Liu> Mar 18 - Mar 22	R-3	 RC1 target week Hard StringFreeze
03:36:22 <wangzhh> This work can't be split. And I think I can finish it in time.
03:36:37 <zhipeng> Then we still have time to squeeze more stuff in lol
03:36:58 <Coco_gao> 🤣
03:37:10 <Coco_gao> We still have time fix bug?
03:37:16 <Li_Liu> My understanding is, we can at least merge the features first this week
03:37:19 <wangzhh> And Li, what's the priority of deprecate api and new gpu driver ?
03:37:25 <Li_Liu> and fix them for another week?
03:38:15 <Coco_gao> That's good, cause I found some bugs and don't have time to fix right now.
03:39:03 <zhipeng> I would caution deprecate anything before we have microversion in place
03:39:17 <zhipeng> Bug fixes are needed !
03:40:04 <Coco_gao> Hi all, I have to drop off, pls help review my patches this two days for the emergency.
03:40:11 <Coco_gao> these
03:40:11 <Sundar> zhipeng: The accelerators table got removed, so the API for accelerators is effectively deprecated
03:40:37 <Coco_gao> I will send my link in the wechat group.
03:40:41 <Coco_gao> bye
03:42:34 <zhipeng> Sundar is it possible to at least return error code for that api call now ?
03:43:01 <zhipeng> I'm a little bit cagy about removing APIs
03:43:11 <Sundar> zhipeng: with https://review.openstack.org/#/c/641184/, we treturn None or [].
03:43:12 <wangzhh> In fact, we return None or [] now.
03:43:34 <Sundar> We should also update docs, as wangzhh said
03:43:43 <wangzhh> Yep.
03:44:41 <Sundar> zhipeng: Totally understand your position. But, even if we put back the accelerator table, it will be useless as it doesn't get populated.
03:45:36 <wangzhh> And I 'd like to add extra log info in these api.
03:45:45 <wangzhh> *apis
03:46:07 <Sundar> wangzhh: Could you elaborate? Do you want something in the returned value, or cyborg-api logs?
03:46:37 <wangzhh> Not return value. It is  cyborg-api logs.
03:47:36 <Sundar> Sure
03:51:09 <wangzhh> Anything else?
03:52:19 <Sundar> We keep getting questions on docs
03:52:27 <Li_Liu> I am still in another meeting ><
03:52:32 <Sundar> We need to update docs for API etc.
03:52:49 <Li_Liu> Sundar, we can do docs after the code freeze
03:52:50 <Sundar> I haven't looked at it. But I think it can be done after March 8?
03:52:58 <Li_Liu> yup
03:52:59 <Sundar> Li_Liu: ok
03:53:06 <yikun> sorry, for late, just want to sure should we deprecate cyborg v1 api in Stein release?
03:54:04 <Sundar> yikun: No, we are not deprecating all v1 API. Only accelerator APIs
03:54:25 <zhipeng> +1
03:54:37 <yikun> Sundar: OK, and accelerator will return None/[], right?
03:55:00 <Sundar> yikun: Yes. Please review https://review.openstack.org/#/c/641184/
03:55:16 <wangzhh> Sundar,  the deployable api  does not work with new db schema.
03:55:22 <yikun> Sundar: Cool, will do
03:55:31 <Sundar> wangzhh: Li_Liu's patch fixes that
03:55:51 <Sundar> ^ https://review.openstack.org/#/c/640616/
03:56:34 <zhipeng> Li is in internal meeting now, so he will response slowwww
03:57:02 <zhipeng> OK any other matter we should take care for S ?
03:57:03 <wangzhh> I saw it. But the defination  of deployable is different, how to let others know?
03:57:40 <Sundar> wangzhh: Who is using these APIs today?
03:58:22 <Sundar> wangzhh: I see your point. Not sure how we do that without bumping versions
03:59:26 <Sundar> zhipeng, all: is anybody using Cyborg APIs today?
04:00:08 <wangzhh> I just know another lenovo guys use it. And even though nobody use it, but somebody know the  original concept of deployable.
04:00:54 <zhipeng> We have product development in progress now
04:00:54 <wangzhh> We should let them know we had changed this part.
04:01:55 <Sundar> wangzhh: Are you recommending moving to v2 in Stein? And deprecate v1? Then we  will need v3 in Train
04:03:04 <zhipeng> FWIW giving the time limit I would suggest postpone the version changes to T
04:04:57 <wangzhh> Sure. I mean it's a long term work. We should maintain /v2/accelator, /v2/deployable, not mix v1/xxxx and /v2/xxx
04:05:16 <wangzhh> in next version
04:05:58 <Li_Liu> I think we still keep deployable v1 for now, but fix the part according to our new db change
04:06:15 <Li_Liu> to make it compatible
04:09:18 <zhipeng> +1
04:10:07 <wangzhh> All right.
04:11:13 <Sundar> AT the PTG, let's talk about forming an API WG and a Documentation WG.
04:11:30 <Sundar> I'll work on getting microversions in
04:11:41 <wangzhh> Cool.
04:12:24 <wangzhh> Do we have etherpad to record what to disscuss now?
04:12:31 <zhipeng> So let's try to get the driver code in before s-3
04:12:49 <zhipeng> And bug fixes and doc fixes before RC1
04:13:12 <Sundar> wangzhh: Yes https://etherpad.openstack.org/p/cyborg-ptg-train
04:13:25 <wangzhh> Sundar, Great.
04:14:04 <wangzhh> zhipeng
04:14:09 <wangzhh> Got it.
04:14:18 <Sundar> zhipeng: +1
04:16:38 <wangzhh> Time for lunch, I'll drop off.
04:16:44 <wangzhh> Bye :)
04:17:26 <Sundar> AoB?
04:17:34 <Li_Liu> #topic AoB
04:17:58 <Li_Liu> out engineering sync is tomorrow right?
04:18:03 <Sundar> Yes
04:18:31 <Li_Liu> great, will further sync with you guys tomorrow then
04:18:43 <Sundar> Bye!
04:18:44 <Li_Liu> thanks guys, have a good day/night
04:18:52 <Li_Liu> #endmeeting