16:00:23 <gthiemonge> #startmeeting Octavia
16:00:23 <opendevmeet> Meeting started Wed Aug 23 16:00:23 2023 UTC and is due to finish in 60 minutes.  The chair is gthiemonge. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:00:23 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:00:23 <opendevmeet> The meeting name has been set to 'octavia'
16:00:27 <johnsom> o/
16:00:28 <gthiemonge> hi
16:00:31 <tweining> o/
16:01:48 <gthiemonge> #topic Announcements
16:01:53 <gthiemonge> * Combined PTL/TC 2024.1 cycle Election Season
16:02:02 <gthiemonge> FYI nominations are still open until Aug 30
16:02:08 <gthiemonge> #link https://lists.openstack.org/pipermail/openstack-discuss/2023-August/034744.html
16:03:09 <gthiemonge> * 2023.2 Bobcat Release Schedule: R-6
16:03:14 <gthiemonge> 6 weeks!
16:03:20 * johnsom thinks "four more years!"
16:03:48 <gthiemonge> This week marks the final release for non-client libraries (for us it's octavia-lib)
16:04:03 <gthiemonge> And next week is feature freeze and final release for client libraries
16:04:15 <gthiemonge> reminder: we have the priority review list
16:04:20 <gthiemonge> https://etherpad.opendev.org/p/octavia-priority-reviews
16:04:36 <tweining> thanks for your reviews on the HSTS patches
16:04:49 <gthiemonge> There are a few open patches for octavia-lib but I think the HSTS patches in octavia/octaviaclient should have an higher priority
16:06:03 <gthiemonge> and great news, the sqlalchemy2 stuff is merged!!
16:06:36 <johnsom> +100
16:07:07 <tweining> https://review.opendev.org/c/openstack/octavia/+/880806 regarding this one, the main HSTS patch. it is not merged because it has parent patches in the chain. It would be nice if you could review them, otherwise let me know if I should remove them from the patch chain.
16:07:31 <oschwart_> great to hear about sqlalchemy2! o/ btw
16:07:52 <johnsom> It would probably be best to break those apart, they are unrelated (at least at first glance)
16:08:09 <tweining> yeah, I could try running the pyspy patch on master and see how bad it is now ;)
16:08:28 <gthiemonge> anyway I'll review them tomorrow
16:08:41 <tweining> they are. thanks
16:09:47 <gthiemonge> but if you change the order of the chain we could merge the HSTS patch today since it already has 2 CR+2/W+1
16:09:55 <johnsom> I guess they are in global-requirements, so not as far out there as I thought those patches were
16:10:27 <tweining> ok, sounds good I'll change the order then
16:11:07 <johnsom> I just don't want to have a "special" test runner in Octavia as compared to the rest of OpenStack. So, I haven't had time to go do the research to see if we are causing trouble by using pytest
16:11:44 <tweining> those patches change nothing in the CI. they just add new tox envs that make my life a lot easier when debugging tests
16:11:46 <johnsom> This patch indicates it's more than just an optional test runner: https://review.opendev.org/c/openstack/octavia/+/881805/8
16:12:35 <tweining> pytest runs test classes that start with Test, that is why I had to rename them
16:13:04 <johnsom> I am not clear on the benefit of pytest, what does it bring?
16:13:05 <tweining> function wise it shouldn't change anything
16:13:44 <tweining> more features, more convenience for the user, I think we had that discussion before :)
16:14:24 <johnsom> Sorry I don't remember. I just didn't see any specific benefit in the but or patch commit.
16:15:11 <johnsom> I am asking that we capture this, simply because it's one more thing to maintain, so it's not a zero cost thing for the project.
16:16:32 <tweining> hm, okay. I'll need to think about how to capture it somewhere then.
16:16:43 <johnsom> Thank you
16:17:50 <gthiemonge> #topic CI Status
16:18:05 <gthiemonge> c9s jobs are broken, it seems that it's a regression in devstack
16:18:12 <gthiemonge> https://bugs.launchpad.net/devstack/+bug/2031639
16:18:29 <gthiemonge> they are fixing it but we also need to update the definition of our jobs
16:18:35 <gthiemonge> I proposed a patch
16:18:41 <gthiemonge> https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/892484
16:19:00 <johnsom> Ah cool, I was seeing the keystone wsgi failure in Designate and had pinged the PTL
16:19:09 <gthiemonge> octavia-v2-dsvm-scenario-centos-9-stream-non-traffic-ops failed for an unrelated reason (haproxy crash?), I will investigate
16:19:19 <opendevreview> Tom Weininger proposed openstack/octavia master: Add support for HTTP Strict Transport Security  https://review.opendev.org/c/openstack/octavia/+/880806
16:19:41 <gthiemonge> BTW There's the same issue with rocky linux
16:19:53 <gthiemonge> we haven't yet merged rocky linux support so I will have to update the open commit
16:19:58 <gthiemonge> https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/873490
16:20:29 <gthiemonge> it's just one line... I'll ping you guys to get my CR+2s ;-)
16:22:25 <gthiemonge> #topic Brief progress reports / bugs needing review
16:22:56 <gthiemonge> I forgot one thing, we broke octavia-lib CI
16:23:20 <gthiemonge> the new sqlalchemy-tips tox job is executed there, but it doesn't work and it's not needed
16:23:48 <gthiemonge> I've just proposed a patch in octavia that would fix octavia-lib
16:23:53 <gthiemonge> https://review.opendev.org/c/openstack/octavia/+/892550
16:24:20 <tweining> ok, I'll have a look later
16:26:01 <gthiemonge> on my side, I've done a lot of tests/reviews
16:26:05 <tweining> I'd like to mention another one of my patches. It is also optional, but I hope I don't need to explain why I think it is useful.
16:26:41 <tweining> https://review.opendev.org/c/openstack/octavia/+/879749 the mypy patch will need to be rebased again. but now that sqla2 patches are merged I hope it will be the last time.
16:27:18 <tweining> it's obviously not urgent as it is not considered a feature, but I do want to have it merged during this cycle
16:27:56 <gthiemonge> ack
16:31:10 <gthiemonge> #topic Open Discussion
16:31:16 <gthiemonge> any other topics folks?
16:31:53 <oschwart_> from my side I will start reviewing the patches on the priority list
16:32:07 <oschwart_> I am a little out of the loop
16:32:12 <gthiemonge> thanks oschwart_!
16:32:49 <tweining> I'm looking at https://review.opendev.org/c/openstack/octavia/+/892550 and am a bit confused that it actually doesn't remove anything in the patch
16:33:26 <johnsom> It moved line 123 down to it's own job
16:33:33 <johnsom> job->template
16:33:41 <gthiemonge> tweining: octavia-lib uses octavia-tox-tips (project can use jobs defined in other jobs)
16:33:58 <tweining> ah, got it. it is moved to another template
16:34:06 <gthiemonge> tweining: so it doesn't change anything for octavia, but it will change the jobs in octaiva-lib
16:34:09 <johnsom> The gerrit diff is deceiving
16:36:12 <tweining> IDK. I think I didn't give an update about dpdk tests in a while but you all know the state
16:36:33 <tweining> DPDK just works with Octavia amps. :)
16:37:01 <tweining> nothing else to say from my side
16:37:50 <gthiemonge> tweining: good to know ;-)
16:38:23 <gthiemonge> ok guys, I think that's it!
16:38:25 <gthiemonge> thank you!
16:38:32 <gthiemonge> #endmeeting