12:00:23 #startmeeting nova api 12:00:24 Meeting started Tue Sep 1 12:00:23 2015 UTC and is due to finish in 60 minutes. The chair is alex_xu. Information about MeetBot at http://wiki.debian.org/MeetBot. 12:00:25 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 12:00:27 The meeting name has been set to 'nova_api' 12:00:37 Hello, Who is here today 12:01:04 o/ 12:01:12 o/ 12:01:21 hello :) 12:01:29 hello everyone :) 12:01:44 let's run the meeting 12:01:55 #topic actions from last meeting 12:02:06 alex_xu to updated validation patch which strips out extra params 12:02:13 * edleafe runs out for a few minutes to send family off for the day 12:02:17 I have done that, and the patch merged! 12:02:19 #link https://review.openstack.org/215436 12:02:25 edleafe: no problem 12:02:32 alex_xu: cool 12:02:39 sdague to address any additional tempest issues 12:02:52 that seems also done 12:02:54 this also done 12:02:57 #link https://review.openstack.org/216784 12:02:59 alex_xu: that was done 12:03:05 yea 12:03:20 one more for sdague: sdague will sort out our eventual test matrix here 12:03:46 sdague: hi, are you around? 12:04:23 emm...I guess he is busy on gate. there is something trouble with gate 12:04:41 yeah 12:04:42 let me check with him after meeting 12:04:44 alex_xu: yeh, I'm around, but a little touch and go 12:04:59 sdague: yea, no problem 12:05:07 so, yes, we addressed the tempest issue 12:05:45 sdague: any update about the test? I think the important one is v2 test job 12:05:47 the thing I have not done, that I said I would, is an overall test plan here. I started working on it, then the gate wedged up last week, and I've been trying to get it back to low failure rate for freeze 12:06:00 so, my feeling is the following 12:06:09 we should make v2.1 the default 12:06:14 in the test runs 12:06:26 * edleafe returns 12:06:34 #link https://review.openstack.org/#/c/207183/ 12:06:35 then have 2 runs that are only on nova, which is v2.0 on v2.0 stack and v2.0 on v2.1 stack 12:06:41 sdague: i guess this patch ^ 12:06:55 alex_xu: well, I think that patch is probably not quite right 12:07:09 sdague: +1 for plan. 12:07:25 sdague: ok 12:07:36 sdague: any help you need? 12:07:44 anyway, I can also write down the plan in detail if someone else can fling patches 12:07:55 sdague: are you planning to do those with catalog type or changing paste.ini from devstack 12:07:57 I'll do that on an etherpad as soon as we're done here 12:08:01 I can work on the patch 12:08:06 sdague: i can help on those 12:08:09 alex_xu: cool 12:08:20 gmann_: for v2.1 and v2.0 on v2.1 that should be the way we setup paste directly 12:08:34 v2.0 on v2.0 is going to require a paste change in devstack 12:08:48 sdague: yea 12:08:51 sdague: yea 12:09:01 so there will be a devstack logic bit, then setting the compute url in tempest bit 12:10:00 sdague: ok, so you will write down etherpad? them I and gmann_ will work on it 12:10:03 anyway, I'll write up the plan as soon as the meeting is over 12:10:04 s/them/then 12:10:12 sdague: thanks! 12:10:18 sdague: alex_xu cool Thanks. 12:10:26 #action sdague to write up test plan for v2.x nova, alex_xu and gmann_ will work on patches 12:10:36 thanks folks 12:10:57 sdague: ok, you are typing faster than me... 12:11:01 sdague: np 12:11:16 so any more question, then let's move on 12:11:36 #topic v2.0 on v2.1 12:11:43 #info The patch for fixing tempest on extra param is merged https://review.openstack.org/216784 12:11:51 #info The patch for striping the extra params out is merged https://review.openstack.org/#/c/215436/ 12:12:02 #info The patch for using v2.1 only in api-paste.ini is merging https://review.openstack.org/#/c/214085/ 12:12:28 the only left one is about logging warn message when v2 and v3 running 12:12:30 #link #link https://review.openstack.org/219188 12:12:49 oomichi: sdague ^ hope you can take a look at after meeting 12:13:01 alex_xu: ok :) 12:13:05 one second 12:13:06 alex_xu: whats about this one - https://review.openstack.org/#/c/217727/ 12:13:15 oomichi: thanks 12:13:16 alex_xu: we need that also 12:13:52 alex_xu: will do 12:13:58 gmann_: thanks, I missed that one 12:14:24 alex_xu: np 12:14:30 alex_xu: yeh, we'll need to rerun tests on that 12:14:38 because of the ironic dib test fail 12:14:38 I will check whether the patch need update, as johnthetubaguy is away thoes two days 12:14:41 I can look into that one 12:15:19 sdague: ok 12:15:23 edleafe: which one? 12:15:37 https://review.openstack.org/#/c/217727/ ? 12:15:46 alex_xu: https://review.openstack.org/#/c/217727/ 12:15:49 yes 12:15:58 edleafe: cool, thanks 12:16:14 edleafe: so let me help on review 12:16:21 alex_xu: ok 12:16:56 I think that's all for v2 on v2.1, anything more I missed? 12:17:30 #info https://review.openstack.org/219188 and https://review.openstack.org/#/c/217727/ are last two patches about v2 on v2.1 12:17:47 ok, looks like no more question 12:17:50 let's move on 12:17:56 oops 12:18:09 #action edleafe will update https://review.openstack.org/#/c/217727/ 12:18:11 edleafe: :) 12:18:20 cool 12:18:35 #topic v2.1 default on gate 12:18:48 I think we already talk about this in the beginning 12:18:59 anything more want to talk about? 12:19:05 one point 12:19:15 oomichi: yea, please 12:19:32 johnthetubaguy makes legacy v2 comp API as the default. 12:19:47 isn't that enough for us? 12:19:49 oomichi: yea 12:20:03 oomichi: no, we should make v2.1 as the default 12:20:19 without legacy mode, right? 12:20:24 oomichi: yea 12:20:33 ah, I see. 12:20:43 so another question is 12:20:48 alex_xu: oomichi : yea 12:21:05 how to test legacy v2, legacy v2 comp and v2.1 on the gate? 12:21:20 do we need to test all APIs? 12:21:47 oomichi: we can have v2.1 default and separate job for each on v2 and v2 on v21 12:22:11 gmann__: I see, yeah that is reasonable. 12:22:17 oomichi: sdague will write up the plan in detail 12:22:31 oomichi: yea, we talked it in the beginning of the meeting, Sean will go to write down the detail paln 12:22:40 gmann__: ok, I'd like to see it :) 12:23:11 alex_xu: thanks, my question is solved ;) 12:23:17 oomichi: np :) 12:23:24 oomichi: thanks 12:23:35 then let's move on? 12:23:53 #topic Test collapse of v2.0 and v2.1 12:24:06 gmann__: I think all the works already done, right? 12:24:15 alex_xu: yea those are done. 12:24:24 #info all the works of collapse of v2 and v2.1 tests are done, thanks to gmann__ ! 12:24:46 alex_xu: we have now single set of sample files. sdague will be much happy :) 12:24:55 gmann__: thanks for the works 12:25:03 oomichi: np 12:25:13 gmann__: yea, actually everybody happy, thanks for the works :) 12:25:22 alex_xu: yea. np 12:25:28 so let's move on 12:25:30 #topic Remove extensions 12:25:36 #info Deprecated v2.1 extension options patch is merged https://review.openstack.org/214592 12:25:49 one more patch for deprecated v2 extension option didn't merge yet 12:25:55 #link https://review.openstack.org/214601 12:26:12 hope everybody can review it 12:26:23 oomichi: sdague ^ special you :) 12:26:52 alex_xu: got it o/ 12:26:57 then I think this the parts of remove extension in Liberty 12:27:01 oomichi: thanks :) 12:27:15 alex_xu: :) 12:27:18 anymore question or missing? 12:27:42 so let's move on 12:27:46 #topic Removal of v3 naming from source tree 12:27:54 #link https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:x3,n,z 12:28:01 there are two patches 12:28:19 but those can be merged after freeze, as they are bug fix 12:28:27 alex_xu: johnthetubaguy wants to wait for freeze to merge them 12:28:37 edleafe: yea 12:28:39 they don't affect logic, but could cause extra rebases 12:28:54 but I find one thing we should merge before string freeze 12:28:59 so I'm fine waiting 12:29:00 #link https://review.openstack.org/219188 12:29:06 alex_xu: edleafe : yea that will good 12:29:19 edleafe: yea, really thanks all the works :) 12:29:27 alex_xu: yes, already reviewed 12:29:33 edleafe: thanks 12:30:01 alex_xu: can you respin https://review.openstack.org/#/c/214601/ instead of johnthetubaguy? 12:30:12 alex_xu: I found a wrong message on the patch 12:30:32 alex_xu: after the meeting 12:30:39 oomichi: no problem, thanks! 12:31:09 oomichi: and this for you https://review.openstack.org/219188, probably one minute review 12:31:44 alex_xu: that was done already ;) 12:31:50 oomichi: cool! 12:32:00 ok, let's move on 12:32:03 #topic API Documentation Improvement 12:32:05 sdague 's turn 12:32:13 heh :) 12:32:27 oomichi: :) 12:32:47 so for doc, I guess we didn't have too much update this point 12:33:01 I'm here fwiw 12:33:10 annegentle: good morning 12:33:16 g'mornin' 12:33:19 annegentle: morning :) 12:33:38 Russell and I met yesterday and yes you do have to have WADL to get the swagger/json output. 12:33:54 there is plan for swagger poc in summit, but probably we aren't start yet, as this isn't the focus at this point 12:33:54 We're meeting with Monty this afternoon to discuss server setup to display the docs. 12:34:18 annegentle: why have to? can we jump over the WADL? 12:34:19 Russell and I have a talk Tuesday afternoon about progress so far 12:34:39 alex_xu: if you'd like to go directly to swagger that's fine but the tooling isn't available for nova, unless you write it 12:34:58 alex_xu: looking at it, Russell thinks tempest is the way to get request/responses and errors then add those to the doc 12:35:12 I have a little crazy idea for getting API sample files from tempest.log as the alternative. 12:35:21 annegentle: yea, I and oomichi gmann__ probably will work on it 12:35:25 oomichi: yeah that's probably along the same idea 12:35:26 annegentle: alex_xu : updating WADL manually needs lot of affort 12:35:35 alex_xu: oomichi gmann__ excellent 12:35:39 we will be able to use it for all projects. 12:35:44 annegentle: I thought we were getting away from WADL 12:35:55 gmann__: yeah I'm not advocating for WADL, just letting you know there's no generator other than from WADL 12:35:58 gmann__: that's all 12:35:59 gmann__: yea, that is why we jump over WADL 12:36:14 oomichi: that's great 12:36:24 annegentle: thanks, I can try prototype based on positive feedback :) 12:36:45 oomichi: so in the future, we will remove the api sample tests? 12:36:47 annegentle: humm, 12:36:56 if your idea works 12:36:59 I had an off-list reply to my ML http://lists.openstack.org/pipermail/openstack-dev/2015-August/072546.html 12:37:17 alex_xu: I canot say it at this time 12:37:45 anyway, I've not really had enough concentration on this issue atm given some of the other freeze related things 12:37:45 woops can't find it now, but basically looking for ways to baseline and compare swagger files 12:37:47 alex_xu: I am thnking sample files should be maintained on each probject ideally as the first place 12:38:05 oomichi: alex_xu : yea we may need sample files but we can see those based on how tempest thing goes 12:38:52 gmann__: and oomichi: I agree with you to eventually get rid of the generated samples if tempest works out 12:38:58 gmann__: oomichi ok, let's see what happened 12:39:10 ok 12:39:36 annegentle: yea, that will be much more generic. 12:39:43 annegentle: thanks for info, let's get back to this after freeze 12:40:04 ok -- thanks for looking for generic solutions 12:40:32 anything more question, then let's move on? 12:40:55 #topic API futures - patches for merge 12:41:13 only one I noticed and the code is good shape 12:41:16 #link #link https://review.openstack.org/217572 12:41:20 gmann__: ^ :) 12:41:32 alex_xu: yea 12:41:52 That is bug fix for VIF thing, spec was approved already 12:42:00 not sure we have enough bandwidth for it, but I give +1, give it my best bless 12:42:07 oomichi: reviewed. Than ks 12:42:21 alex_xu: yea, just need 1 more +2 12:42:38 sdague: ^^ in your free time 12:42:42 gmann__: yea, good luck 12:42:49 that's also sdague's turn 12:42:50 yea 12:42:59 and with that one more - https://review.openstack.org/#/c/198944/ 12:43:24 gmann__: yea, that is important 12:43:25 that is kilo backporting for VIF thing. master one is already megred 12:43:49 master one - https://review.openstack.org/#/c/198934/ 12:44:02 oomichi: I can fix the missing space on https://review.openstack.org/#/c/214601/ and push a new version, if you and sdague are around to re-review it 12:44:05 sdague: oomichi this one too - https://review.openstack.org/#/c/198944/ 12:44:39 edleafe: thanks, will re-review it soon after that 12:44:46 ok, let's jump to open directly 12:44:48 #topic open 12:45:08 I started the microversions api-wg guideline again 12:45:10 #link https://review.openstack.org/187112 12:45:19 +A on https://review.openstack.org/#/c/217572 12:45:25 so hope everyone can take a look at it after freeze 12:45:37 sdague: Thanks 12:45:52 gmann__: hah, good luck :) 12:46:09 alex_xu: :) 12:46:30 anymore open? then let's back to review and update patch, then push oomichi and sdague :) 12:46:43 alex_xu: oops, you are trying very difficult topic.. microversion spec ;) 12:46:53 sdague: oomichi : last one for VIF one - https://review.openstack.org/#/c/198944/ 12:47:00 oomichi: yea, thanks to you push part of consistent 12:47:35 oomichi: sdague: others: fixed and pushed https://review.openstack.org/214601 12:47:38 gmann__: that seems different from stable patch way, I guess 12:47:58 ok... let's back to openstack-nova to work 12:48:01 thanks all 12:48:03 #endmeeting