14:00:07 <lujinluo> #startmeeting neutron_upgrades
14:00:09 <openstack> Meeting started Thu May 31 14:00:07 2018 UTC and is due to finish in 60 minutes.  The chair is lujinluo. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:10 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:13 <openstack> The meeting name has been set to 'neutron_upgrades'
14:00:18 <lujinluo> o/
14:00:23 <TuanVu> Hi Luo-san
14:00:33 <lujinluo> hi TuanVu !
14:01:07 <lujinluo> We do not have any AIs from last meeting
14:01:15 <lujinluo> so jump into OVO patches
14:01:17 <lujinluo> https://review.openstack.org/#/q/status:open+project:openstack/neutron+branch:master+topic:bp/adopt-oslo-versioned-objects-for-db
14:01:25 <lujinluo> #topic OVO
14:01:30 <TuanVu> ok
14:01:42 <lujinluo> https://review.openstack.org/#/c/570244/
14:01:47 <lujinluo> this one is from Nate
14:01:59 <njohnston> o/
14:02:05 <lujinluo> The codes look fine to me. but Zuul failed last time
14:02:08 <lujinluo> hi njohnston
14:02:16 <njohnston> There is an issue with the sphinx docs build job
14:02:24 <lujinluo> let's wait for the result of Zuul and see how it goes
14:02:44 <lujinluo> njohnston: does the latest patch solve it?
14:02:51 <njohnston> I have https://review.openstack.org/#/c/571301/ to fix it, but I saw there was a discussion between boden and haleyb about whether it was the right approach.
14:03:27 <njohnston> I rebased 570244 onto 571301 and the build-sphinx-docs job has already succeeded so I believe it will build
14:05:11 <lujinluo> i see. from a rough review, i think it will fix it
14:05:33 <njohnston> hopefully so :-)
14:05:55 <lujinluo> yeah
14:06:15 <lujinluo> next is https://review.openstack.org/#/c/507772/
14:06:30 <TuanVu> I’ve already left a comment about latest status on the patch
14:06:30 <lujinluo> i think you have already fixed the RBAC issue? TuanVu
14:06:39 <TuanVu> yes :)
14:07:00 <lujinluo> good! i see. tempest is still failing
14:07:15 <TuanVu> thanks to the help from both you and Ihar :)
14:07:32 <TuanVu> yeah, I'm not sure how to fix it at this moment
14:07:42 <TuanVu> so any suggestions are welcome
14:08:31 <TuanVu> it looks like it's related to attach qos
14:08:38 <lujinluo> are the failed tests related to qos policies?
14:08:51 <TuanVu> yes, I think so
14:08:59 <lujinluo> neutron_tempest_plugin.api.test_qos.RbacSharedQosPoliciesTest.test_network_presence_prevents_policy_rbac_policy_deletion [5.378070s] ... FAILED
14:10:13 <lujinluo> also, slawek pointed potential failures of mtu
14:10:19 <lujinluo> have you checked that as well?
14:10:41 <TuanVu> yes, I've checked that
14:11:03 <TuanVu> it looks like there's problem with getting mtu in:
14:11:04 <TuanVu> https://review.openstack.org/#/c/507772/54/neutron/plugins/ml2/plugin.py
14:11:08 <lujinluo> is it one of the 5 failed tests?
14:12:21 <TuanVu> yes
14:12:37 <TuanVu> neutron_tempest_plugin.api.test_trunk_negative.TrunkTestMtusJSON	. test_add_subport_with_mtu_greater_than_trunk
14:12:47 <TuanVu> &
14:12:53 <TuanVu> test_create_trunk_with_mtu_smaller_than_subport
14:13:08 <lujinluo> ok, i think i need a bit more time to catch up with the latest patch. will take a closer look rmt. but i understood the current status
14:13:33 <TuanVu> thank you in advance, Luo-san :)
14:14:12 <lujinluo> next https://review.openstack.org/#/c/565358/
14:14:17 <lujinluo> this one is from Ihar
14:14:40 <lujinluo> and it is blocked by sphinx docs issue
14:15:47 <lujinluo> we may need to recheck it after Nate's patch got merged
14:16:04 <TuanVu> yeah, I think so
14:16:13 <lujinluo> i have added more core reviewers to 571301. hopefully they will take time to review it
14:16:48 <lujinluo> https://review.openstack.org/#/c/544206/ this one is on me
14:17:24 <lujinluo> i have two remaining AIs for this patch: 1) reabse it on Migule's patch; 2) resolve the postgresql issue exposed last time
14:18:08 <lujinluo> for 1) I plan to wait for Miguel's patch to get merged, https://review.openstack.org/#/c/414251/. and it is very close to be merged now
14:18:47 <lujinluo> for 2) i need to talk to Ihar, because i could not find which test is deployed with postgresql as backend
14:19:16 <lujinluo> if you know which one it is, or you know how i can find it out, please help me out
14:20:47 <lujinluo> ok, i will try to catch ihar or Miguel or slawek tmr..
14:21:02 <lujinluo> https://review.openstack.org/#/c/537320/ this one is still on me..
14:21:39 <lujinluo> i rebased it to accommodate auto detect engine facade
14:22:01 <lujinluo> but i have one tempest failure, which i believe is related to my change
14:22:10 <lujinluo> i will work it out tmr
14:22:26 <lujinluo> (tmr seems to be a tough day for me)
14:22:53 <TuanVu> yeah
14:22:59 <TuanVu> but please take it easy, Luo
14:23:07 <lujinluo> TuanVu: haha, thanks!
14:23:17 <TuanVu> :)
14:23:30 <lujinluo> we do not have any updates of the remaining patches
14:23:39 <lujinluo> does anyone want to address any of their patches?
14:23:50 <hungpv> yeah
14:23:55 <lujinluo> shoot
14:24:25 <hungpv> i have a few questions, maybe basic ones, but you know I'm still noob :D
14:24:39 <lujinluo> no problem at all. will try my best
14:24:40 <hungpv> https://review.openstack.org/#/c/549168/8/neutron/tests/unit/extensions/test_l3_ext_gw_mode.py
14:25:11 <hungpv> L149    self.context.session.flush()
14:25:56 <hungpv> i'm not sure is this one necessary or not
14:26:30 <lujinluo> after converting to OVO, we do not need it anymore. .flush() commits all the pending commits to the sessions, because after calling .add() all the commits are not actually commited, they are in pending state
14:26:43 <hungpv> that's great!
14:26:44 <lujinluo> while in OVO world, a create() is a commit to db
14:27:17 <lujinluo> good. anything else you want to discuss?
14:27:32 <hungpv> yes, and about create() function
14:27:46 <lujinluo> sure
14:28:06 <hungpv> i saw some patches rewrite it, not use the built-in one in base.py
14:28:20 <hungpv> can you give some ideas about it?
14:28:40 <hungpv> what situations we should do this one or other?
14:29:16 <lujinluo> yeah, normally create() in base.py does the basic stuff. but for some OVO objects, they have special fields, which are not defined in base.py, then it'd better to rewrite
14:29:29 <lujinluo> let me try to find an example here
14:30:19 <lujinluo> https://github.com/openstack/neutron/blob/master/neutron/objects/ports.py#L344
14:31:05 <lujinluo> Port has QoS and security groups as extensions attaching to it
14:31:47 <lujinluo> but QoS and security groups are loaded as synthetic field, thus you need to add additional methods to attach them
14:32:02 <hungpv> i see
14:32:35 <lujinluo> sorry QoS and security groups are NOT loaded as synthetic field
14:33:05 <lujinluo> so it really depends on what object you are dealing with
14:34:16 <hungpv> i've got your point
14:34:29 <lujinluo> great!
14:35:10 <lujinluo> anything else you want to discuss?
14:35:27 <hungpv> yeah, one final question
14:35:46 <lujinluo> sure
14:36:09 <hungpv> L267 router.gw_port.mac_address)
14:37:06 <hungpv> if I understand it, I see router db model calls mac _address of gw_port
14:37:35 <hungpv> just sure how to convert it when dealing with router object
14:38:10 <hungpv> can you shed me some light on it? thank you
14:38:22 <lujinluo> hmm, i do not quit understand your question
14:38:42 <lujinluo> do you mean you want to know how to deal with gw_port and router objects?
14:39:41 <hungpv> yes, that's where I'm stuck right now
14:39:58 <hungpv> thank you for quick understanding
14:41:01 <lujinluo> as far as i recall, we may need to add port as a synthetic field of router's in order to proceed. but this is a bit tricky. can you try if we can call router.db_obj.gw_port to request gw_port from db model
14:41:05 <lujinluo> just an idea though
14:41:47 <lujinluo> can you point me to the patch? i can add one more task to my to-do list for tmr..
14:42:13 <hungpv> @luo-san: https://review.openstack.org/#/c/549168/
14:42:21 <njohnston> A reference to router.gw_port works on L269, so I would expect "router.gw_port['mac_address']" might have a chance of success.
14:43:10 <hungpv> Thank you Nate, gonna try it out
14:43:34 <lujinluo> yeah, worth a try
14:45:13 <lujinluo> ok, i will review the patch tmr
14:45:22 <hungpv> so nothing more from me. thank you
14:45:39 <lujinluo> #topic open discussion
14:45:43 <hungpv> I'm prepare a new patch, and will update tmr for review
14:45:58 <lujinluo> understood, please add us as reviewers
14:46:17 <hungpv> yes, surely
14:46:33 <lujinluo> does anyone have anything to talk about?
14:46:45 <TuanVu> none from me
14:47:30 <lujinluo> cool! now let us call it a day!
14:47:39 <lujinluo> have a good night/day everyone
14:47:43 <lujinluo> see you next week
14:47:54 <lujinluo> #endmeeting