15:00:11 <ralonsoh> #startmeeting neutron_qos
15:00:12 <openstack> Meeting started Tue Jul 16 15:00:11 2019 UTC and is due to finish in 60 minutes.  The chair is ralonsoh. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:13 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:15 <openstack> The meeting name has been set to 'neutron_qos'
15:00:18 <ralonsoh> Yes, this is the command
15:00:20 <ralonsoh> hi
15:00:23 <davidsha> Hey!
15:01:02 <ralonsoh> apart from your feature and a bug almost resolved, there is no agenda
15:01:27 <ralonsoh> let's wait 30 secs more
15:01:58 <ralonsoh> ok, let's go
15:02:02 <ralonsoh> #topic RFEs
15:02:10 <ralonsoh> nothing in the agenda
15:02:35 <ralonsoh> let's move to bug
15:02:37 <ralonsoh> bugs
15:02:38 <ralonsoh> #topic Bugs
15:02:43 <ralonsoh> #link https://bugs.launchpad.net/neutron/+bug/1826695
15:02:45 <openstack> Launchpad bug 1826695 in neutron "[L3][QoS] cache does not removed when router is down or deleted" [Medium,In progress] - Assigned to LIU Yulong (dragon889)
15:02:51 <ralonsoh> patch: #link https://review.opendev.org/#/c/656105/
15:03:08 <ralonsoh> IMO, the code is ok, I'll review it later today
15:03:31 <ralonsoh> nothing else in the list
15:04:07 <ralonsoh> so, let's move to open discussion
15:04:08 <ralonsoh> #topic Open Discussion
15:04:22 <ralonsoh> #link https://bugs.launchpad.net/neutron/+bug/1476527
15:04:24 <openstack> Launchpad bug 1476527 in neutron "[RFE] Add common classifier resource" [Wishlist,Triaged] - Assigned to Igor D.C. (igordcard)
15:04:28 <ralonsoh> davidsha, any updates?
15:04:42 <ralonsoh> I've seen your POC updated today
15:04:49 <davidsha> Yup, I put up that patch that migrated the service plugin into Neutron: https://review.opendev.org/#/c/670050/
15:05:50 <ralonsoh> so 670050 is the first one, introducing the classification groups into the neutron repo
15:06:02 <ralonsoh> (just to follow an order when reviewing)
15:06:12 <davidsha> I need to migrated the RPC advertiser from the other patch over into the new patch and then rebase the QoS patch to remove the DB classification thing
15:06:26 <davidsha> Yup thats correct
15:06:35 <ralonsoh> ok, so first the DB and then the RPC
15:06:47 <davidsha> yup
15:06:51 <ralonsoh> anything peculiar in the DB patch?
15:07:31 <ralonsoh> BTW, https://review.opendev.org/#/c/670049/ should be reviewed first?
15:07:46 <ralonsoh> 670050 depends on the n-lib API change
15:07:56 <davidsha> No, it's basically a straight migration of the code in Neutron Classifier with a little refactoring to clarifying variable types in the functions.
15:08:03 <ralonsoh> ok
15:08:19 <davidsha> Yup 49 is first but the guts of the change are in 50
15:08:26 <ralonsoh> should you remove the "ccf" references?
15:08:33 <ralonsoh> just asking
15:09:08 <davidsha> We can, you wanted to migrate the resources under qos, was it?
15:09:24 <ralonsoh> I think so
15:09:25 <davidsha> or just leave the resources under / ?
15:09:25 <ralonsoh> but
15:09:35 <ralonsoh> please, ask miguel and slaweq
15:09:51 <ralonsoh> I'm in doubt about this...
15:09:55 <davidsha> kk
15:10:12 <ralonsoh> is the neutron classifier (in neutron core) going to be used outside qos?
15:10:31 <ralonsoh> this is, IMO, a QoS extension
15:10:41 <ralonsoh> Am I correct?
15:10:50 <ralonsoh> DSCP -> CCF
15:10:50 <davidsha> There were rfe's to have security groups use it, but that was over a year ago.
15:11:01 <ralonsoh> hmmmm you are right
15:11:13 <ralonsoh> ok, there is no need to make this to depend on QoS
15:11:23 <ralonsoh> maybe you can leave the resources under /
15:11:39 <davidsha> When it was proposed it was a QoS extension, but the original team saw values in expanding it out
15:11:40 <ralonsoh> yes, there is no hard dependency againts this
15:11:48 <davidsha> kk
15:11:53 <ralonsoh> that's the point,
15:11:56 <ralonsoh> perfect!
15:12:18 <davidsha> will I keep /ccf or just / ? ccf=common classification framework
15:12:46 <ralonsoh> I see no reason to keep CCF
15:12:58 <davidsha> kk, I'll remove it
15:13:03 <ralonsoh> but, as I said, make this comment in the patch and I'll do the same
15:13:05 <ralonsoh> I'll review both patches today (or tomorrow morning)
15:13:12 <davidsha> Thanks!
15:13:29 <ralonsoh> something else??
15:13:41 <davidsha> Nope, thats it for me.
15:13:46 <ralonsoh> cool!
15:14:03 <ralonsoh> I think we can finish the meeting now (quite fast today)!
15:14:07 <ralonsoh> thanks David
15:14:24 <ralonsoh> #endmeeting